@snowbridge/contract-types 0.2.8 → 0.2.9

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (2) hide show
  1. package/.turbo/turbo-build.log +1507 -1507
  2. package/package.json +2 -2
@@ -12,14 +12,6 @@ note[mixed-case-variable]: mutable variables should use mixedCase
12
12
  |
13
13
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
14
14
 
15
- note[unused-import]: unused imports should be removed
16
- --> /home/runner/work/snowbridge/snowbridge/contracts/scripts/upgrade/DeployGateway202509.sol:7:9
17
- |
18
- 7 | import {ParaID} from "../../src/Types.sol";
19
- | ------
20
- |
21
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
22
-
23
15
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
24
16
  --> /home/runner/work/snowbridge/snowbridge/contracts/scripts/DeployLocal.sol:84:9
25
17
  |
@@ -28,158 +20,6 @@ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls sho
28
20
  |
29
21
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
30
22
 
31
- note[screaming-snake-case-immutable]: immutables should use SCREAMING_SNAKE_CASE
32
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Token.sol:17:30
33
- |
34
- 17 | address public immutable gateway;
35
- | -------
36
- |
37
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-immutable
38
-
39
- note[unused-import]: unused imports should be removed
40
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:5:9
41
- |
42
- 5 | import {TokenInfo, OperatingMode} from "./types/Common.sol";
43
- | ---------
44
- |
45
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
46
-
47
- note[unused-import]: unused imports should be removed
48
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:5:20
49
- |
50
- 5 | import {TokenInfo, OperatingMode} from "./types/Common.sol";
51
- | -------------
52
- |
53
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
54
-
55
- note[unused-import]: unused imports should be removed
56
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:6:9
57
- |
58
- 6 | import {UD60x18} from "prb/math/src/UD60x18.sol";
59
- | -------
60
- |
61
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
62
-
63
- note[unused-import]: unused imports should be removed
64
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:8:5
65
- |
66
- 8 | ParaID,
67
- | ------
68
- |
69
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
70
-
71
- note[unused-import]: unused imports should be removed
72
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:9:5
73
- |
74
- 9 | ChannelID,
75
- | ---------
76
- |
77
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
78
-
79
- note[unused-import]: unused imports should be removed
80
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:10:5
81
- |
82
- 10 | Channel,
83
- | -------
84
- |
85
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
86
-
87
- note[unused-import]: unused imports should be removed
88
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:11:5
89
- |
90
- 11 | InboundMessage as InboundMessageV1,
91
- | ----------------------------------
92
- |
93
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
94
-
95
- note[unused-import]: unused imports should be removed
96
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:12:5
97
- |
98
- 12 | Command as CommandV1,
99
- | --------------------
100
- |
101
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
102
-
103
- note[unused-import]: unused imports should be removed
104
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:13:5
105
- |
106
- 13 | MultiAddress
107
- | ------------
108
- |
109
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
110
-
111
- note[unused-import]: unused imports should be removed
112
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:15:9
113
- |
114
- 15 | import {CallsV1} from "./v1/Calls.sol";
115
- | -------
116
- |
117
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
118
-
119
- note[unused-import]: unused imports should be removed
120
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:16:9
121
- |
122
- 16 | import {HandlersV1} from "./v1/Handlers.sol";
123
- | ----------
124
- |
125
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
126
-
127
- note[unused-import]: unused imports should be removed
128
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:17:9
129
- |
130
- 17 | import {IGatewayV1} from "./v1/IGateway.sol";
131
- | ----------
132
- |
133
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
134
-
135
- note[unused-import]: unused imports should be removed
136
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:20:5
137
- |
138
- 20 | InboundMessage as InboundMessageV2, Command as CommandV2, CommandKind
139
- | ----------------------------------
140
- |
141
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
142
-
143
- note[unused-import]: unused imports should be removed
144
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:20:41
145
- |
146
- 20 | InboundMessage as InboundMessageV2, Command as CommandV2, CommandKind
147
- | --------------------
148
- |
149
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
150
-
151
- note[unused-import]: unused imports should be removed
152
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:20:63
153
- |
154
- 20 | InboundMessage as InboundMessageV2, Command as CommandV2, CommandKind
155
- | -----------
156
- |
157
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
158
-
159
- note[unused-import]: unused imports should be removed
160
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:22:9
161
- |
162
- 22 | import {CallsV2} from "./v2/Calls.sol";
163
- | -------
164
- |
165
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
166
-
167
- note[unused-import]: unused imports should be removed
168
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:23:9
169
- |
170
- 23 | import {HandlersV2} from "./v2/Handlers.sol";
171
- | ----------
172
- |
173
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
174
-
175
- note[unused-import]: unused imports should be removed
176
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:24:9
177
- |
178
- 24 | import {IGatewayV2} from "./v2/IGateway.sol";
179
- | ----------
180
- |
181
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
182
-
183
23
  note[mixed-case-function]: function names should use mixedCase
184
24
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:19:14
185
25
  |
@@ -220,77 +60,101 @@ note[mixed-case-function]: function names should use mixedCase
220
60
  |
221
61
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
222
62
 
223
- note[screaming-snake-case-immutable]: immutables should use SCREAMING_SNAKE_CASE
224
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Token.sol:18:28
63
+ note[mixed-case-function]: function names should use mixedCase
64
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:76:14
225
65
  |
226
- 18 | uint8 public immutable decimals;
227
- | --------
66
+ 76 | function SendTokenToAddress32(
67
+ | --------------------
228
68
  |
229
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-immutable
69
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
230
70
 
231
71
  note[mixed-case-variable]: mutable variables should use mixedCase
232
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:249:47
72
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:78:16
73
+ |
74
+ 78 | ParaID paraID,
75
+ | ------
76
+ |
77
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
78
+
79
+ note[mixed-case-function]: function names should use mixedCase
80
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:99:14
81
+ |
82
+ 99 | function SendTokenToAddress20(
83
+ | --------------------
84
+ |
85
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
86
+
87
+ note[mixed-case-variable]: mutable variables should use mixedCase
88
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:101:16
233
89
  |
234
- 249 | function channelOperatingModeOf(ChannelID channelID) external view returns (OperatingMode) {
235
- | ---------
90
+ 101 | ParaID paraID,
91
+ | ------
236
92
  |
237
93
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
238
94
 
239
- note[mixed-case-variable]: mutable variables should use mixedCase
240
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:253:40
95
+ note[mixed-case-function]: function names should use mixedCase
96
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:121:14
241
97
  |
242
- 253 | function channelNoncesOf(ChannelID channelID) external view returns (uint64, uint64) {
243
- | ---------
98
+ 121 | function SendForeignTokenToAssetHubAddress32(
99
+ | -----------------------------------
244
100
  |
245
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
101
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
246
102
 
247
103
  note[mixed-case-variable]: mutable variables should use mixedCase
248
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:257:30
104
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:122:17
249
105
  |
250
- 257 | function agentOf(bytes32 agentID)
251
- | -------
106
+ 122 | bytes32 tokenID,
107
+ | -------
252
108
  |
253
109
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
254
110
 
255
111
  note[mixed-case-function]: function names should use mixedCase
256
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:287:14
112
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:140:14
257
113
  |
258
- 287 | function queryForeignTokenID(address token) external view returns (bytes32) {
259
- | -------------------
114
+ 140 | function SendForeignTokenToAddress32(
115
+ | ---------------------------
260
116
  |
261
117
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
262
118
 
263
119
  note[mixed-case-variable]: mutable variables should use mixedCase
264
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:324:37
120
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:141:17
265
121
  |
266
- 324 | function tokenAddressOf(bytes32 tokenID) external view returns (address) {
267
- | -------
122
+ 141 | bytes32 tokenID,
123
+ | -------
124
+ |
125
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
126
+
127
+ note[mixed-case-variable]: mutable variables should use mixedCase
128
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:142:16
129
+ |
130
+ 142 | ParaID paraID,
131
+ | ------
268
132
  |
269
133
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
270
134
 
271
135
  note[mixed-case-function]: function names should use mixedCase
272
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:333:14
136
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:163:14
273
137
  |
274
- 333 | function v1_handleAgentExecute(bytes calldata data) external onlySelf {
275
- | ---------------------
138
+ 163 | function SendForeignTokenToAddress20(
139
+ | ---------------------------
276
140
  |
277
141
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
278
142
 
279
- note[unused-import]: unused imports should be removed
280
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Initializer.sol:5:9
281
- |
282
- 5 | import {AgentExecutor} from "./AgentExecutor.sol";
283
- | -------------
284
- |
285
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
286
-
287
- note[pascal-case-struct]: structs should use PascalCase
288
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:24:12
289
- |
290
- 24 | struct MMRLeafPartial {
291
- | --------------
292
- |
293
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#pascal-case-struct
143
+ note[mixed-case-variable]: mutable variables should use mixedCase
144
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:164:17
145
+ |
146
+ 164 | bytes32 tokenID,
147
+ | -------
148
+ |
149
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
150
+
151
+ note[mixed-case-variable]: mutable variables should use mixedCase
152
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:165:16
153
+ |
154
+ 165 | ParaID paraID,
155
+ | ------
156
+ |
157
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
294
158
 
295
159
  note[unused-import]: unused imports should be removed
296
160
  --> /home/runner/work/snowbridge/snowbridge/contracts/scripts/DeployLocal.sol:17:9
@@ -300,22 +164,78 @@ note[unused-import]: unused imports should be removed
300
164
  |
301
165
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
302
166
 
303
- note[mixed-case-function]: function names should use mixedCase
304
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:76:14
167
+ note[mixed-case-variable]: mutable variables should use mixedCase
168
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:57:16
305
169
  |
306
- 76 | function SendTokenToAddress32(
307
- | --------------------
170
+ 57 | uint64 validatorSetID;
171
+ | --------------
308
172
  |
309
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
173
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
174
+
175
+ note[unused-import]: unused imports should be removed
176
+ --> /home/runner/work/snowbridge/snowbridge/contracts/scripts/upgrade/DeployGateway202509.sol:7:9
177
+ |
178
+ 7 | import {ParaID} from "../../src/Types.sol";
179
+ | ------
180
+ |
181
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
310
182
 
311
183
  note[mixed-case-variable]: mutable variables should use mixedCase
312
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:78:16
184
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:31:34
313
185
  |
314
- 78 | ParaID paraID,
315
- | ------
186
+ 31 | function ensureAgent(bytes32 agentID) internal view returns (address agent) {
187
+ | -------
316
188
  |
317
189
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
318
190
 
191
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
192
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/interfaces/IERC20Metadata.sol:7:8
193
+ |
194
+ 7 | import "./IERC20.sol";
195
+ | --------------
196
+ |
197
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
198
+
199
+ note[mixed-case-variable]: mutable variables should use mixedCase
200
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:249:47
201
+ |
202
+ 249 | function channelOperatingModeOf(ChannelID channelID) external view returns (OperatingMode) {
203
+ | ---------
204
+ |
205
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
206
+
207
+ note[mixed-case-variable]: mutable variables should use mixedCase
208
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:253:40
209
+ |
210
+ 253 | function channelNoncesOf(ChannelID channelID) external view returns (uint64, uint64) {
211
+ | ---------
212
+ |
213
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
214
+
215
+ note[mixed-case-variable]: mutable variables should use mixedCase
216
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:257:30
217
+ |
218
+ 257 | function agentOf(bytes32 agentID)
219
+ | -------
220
+ |
221
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
222
+
223
+ note[mixed-case-function]: function names should use mixedCase
224
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:287:14
225
+ |
226
+ 287 | function queryForeignTokenID(address token) external view returns (bytes32) {
227
+ | -------------------
228
+ |
229
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
230
+
231
+ note[unused-import]: unused imports should be removed
232
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Initializer.sol:5:9
233
+ |
234
+ 5 | import {AgentExecutor} from "./AgentExecutor.sol";
235
+ | -------------
236
+ |
237
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
238
+
319
239
  note[unused-import]: unused imports should be removed
320
240
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/Initializer.sol:7:24
321
241
  |
@@ -348,46 +268,54 @@ note[unused-import]: unused imports should be removed
348
268
  |
349
269
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
350
270
 
351
- note[mixed-case-function]: function names should use mixedCase
352
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:99:14
271
+ note[mixed-case-variable]: mutable variables should use mixedCase
272
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:39:38
353
273
  |
354
- 99 | function SendTokenToAddress20(
355
- | --------------------
274
+ 39 | function ensureChannel(ChannelID channelID) internal view returns (Channel storage ch) {
275
+ | ---------
356
276
  |
357
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
277
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
358
278
 
359
279
  note[mixed-case-variable]: mutable variables should use mixedCase
360
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:101:16
280
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:69:16
281
+ |
282
+ 69 | bytes2 payloadID;
283
+ | ---------
284
+ |
285
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
286
+
287
+ note[screaming-snake-case-immutable]: immutables should use SCREAMING_SNAKE_CASE
288
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Token.sol:17:30
289
+ |
290
+ 17 | address public immutable gateway;
291
+ | -------
292
+ |
293
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-immutable
294
+
295
+ note[screaming-snake-case-immutable]: immutables should use SCREAMING_SNAKE_CASE
296
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Token.sol:18:28
297
+ |
298
+ 18 | uint8 public immutable decimals;
299
+ | --------
300
+ |
301
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-immutable
302
+
303
+ note[mixed-case-variable]: mutable variables should use mixedCase
304
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:324:37
361
305
  |
362
- 101 | ParaID paraID,
363
- | ------
306
+ 324 | function tokenAddressOf(bytes32 tokenID) external view returns (address) {
307
+ | -------
364
308
  |
365
309
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
366
310
 
367
311
  note[mixed-case-function]: function names should use mixedCase
368
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:121:14
312
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:333:14
369
313
  |
370
- 121 | function SendForeignTokenToAssetHubAddress32(
371
- | -----------------------------------
314
+ 333 | function v1_handleAgentExecute(bytes calldata data) external onlySelf {
315
+ | ---------------------
372
316
  |
373
317
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
374
318
 
375
- note[mixed-case-variable]: mutable variables should use mixedCase
376
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:122:17
377
- |
378
- 122 | bytes32 tokenID,
379
- | -------
380
- |
381
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
382
-
383
- note[mixed-case-variable]: mutable variables should use mixedCase
384
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:28:16
385
- |
386
- 28 | uint64 nextAuthoritySetID;
387
- | ------------------
388
- |
389
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
390
-
391
319
  note[mixed-case-function]: function names should use mixedCase
392
320
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:338:14
393
321
  |
@@ -412,85 +340,53 @@ note[mixed-case-function]: function names should use mixedCase
412
340
  |
413
341
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
414
342
 
415
- note[mixed-case-function]: function names should use mixedCase
416
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Token.sol:81:14
417
- |
418
- 81 | function DOMAIN_SEPARATOR() external view returns (bytes32) {
419
- | ----------------
420
- |
421
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
422
-
423
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
424
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/interfaces/IERC20Metadata.sol:7:8
425
- |
426
- 7 | import "./IERC20.sol";
427
- | --------------
428
- |
429
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
430
-
431
- note[mixed-case-function]: function names should use mixedCase
432
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/interfaces/IERC20Permit.sol:11:14
343
+ note[pascal-case-struct]: structs should use PascalCase
344
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:24:12
433
345
  |
434
- 11 | function DOMAIN_SEPARATOR() external view returns (bytes32);
435
- | ----------------
346
+ 24 | struct MMRLeafPartial {
347
+ | --------------
436
348
  |
437
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
438
-
439
- note[mixed-case-function]: function names should use mixedCase
440
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:140:14
441
- |
442
- 140 | function SendForeignTokenToAddress32(
443
- | ---------------------------
444
- |
445
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
446
-
447
- note[mixed-case-variable]: mutable variables should use mixedCase
448
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:141:17
449
- |
450
- 141 | bytes32 tokenID,
451
- | -------
452
- |
453
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
349
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#pascal-case-struct
454
350
 
455
351
  note[mixed-case-variable]: mutable variables should use mixedCase
456
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:57:16
352
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:28:16
457
353
  |
458
- 57 | uint64 validatorSetID;
459
- | --------------
354
+ 28 | uint64 nextAuthoritySetID;
355
+ | ------------------
460
356
  |
461
357
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
462
358
 
463
359
  note[mixed-case-variable]: mutable variables should use mixedCase
464
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:69:16
360
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:51:16
465
361
  |
466
- 69 | bytes2 payloadID;
467
- | ---------
362
+ 51 | bytes4 consensusEngineID;
363
+ | -----------------
468
364
  |
469
365
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
470
366
 
367
+ note[pascal-case-struct]: structs should use PascalCase
368
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:109:12
369
+ |
370
+ 109 | struct MMRLeaf {
371
+ | -------
372
+ |
373
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#pascal-case-struct
374
+
471
375
  note[mixed-case-variable]: mutable variables should use mixedCase
472
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:142:16
376
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:117:16
473
377
  |
474
- 142 | ParaID paraID,
475
- | ------
378
+ 117 | uint64 nextAuthoritySetID;
379
+ | ------------------
476
380
  |
477
381
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
478
382
 
479
383
  note[mixed-case-variable]: mutable variables should use mixedCase
480
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/types/Common.sol:14:13
481
- |
482
- 14 | bytes32 foreignID;
483
- | ---------
484
- |
485
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
486
-
487
- note[unused-import]: unused imports should be removed
488
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/types/Common.sol:5:9
489
- |
490
- 5 | import {UD60x18} from "prb/math/src/UD60x18.sol";
491
- | -------
492
- |
493
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
384
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:155:20
385
+ |
386
+ 155 | bytes32 public latestMMRRoot;
387
+ | -------------
388
+ |
389
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
494
390
 
495
391
  note[mixed-case-function]: function names should use mixedCase
496
392
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:353:14
@@ -508,53 +404,45 @@ note[mixed-case-function]: function names should use mixedCase
508
404
  |
509
405
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
510
406
 
511
- note[mixed-case-variable]: mutable variables should use mixedCase
512
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/interfaces/IGatewayBase.sol:34:50
513
- |
514
- 34 | event ForeignTokenRegistered(bytes32 indexed tokenID, address token);
515
- | -------
516
- |
517
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
407
+ note[mixed-case-function]: function names should use mixedCase
408
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:363:14
409
+ |
410
+ 363 | function v1_handleRegisterForeignToken(bytes calldata data) external onlySelf {
411
+ | -----------------------------
412
+ |
413
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
414
+
415
+ note[mixed-case-function]: function names should use mixedCase
416
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:368:14
417
+ |
418
+ 368 | function v1_handleMintForeignToken(ChannelID channelID, bytes calldata data)
419
+ | -------------------------
420
+ |
421
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
518
422
 
519
423
  note[mixed-case-variable]: mutable variables should use mixedCase
520
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:31:34
521
- |
522
- 31 | function ensureAgent(bytes32 agentID) internal view returns (address agent) {
523
- | -------
524
- |
525
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
526
-
527
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
528
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/upgrade/Gateway202509.sol:5:8
529
- |
530
- 5 | import "../Gateway.sol";
531
- | ----------------
532
- |
533
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
534
-
535
- note[pascal-case-struct]: structs should use PascalCase
536
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:109:12
424
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:368:50
537
425
  |
538
- 109 | struct MMRLeaf {
539
- | -------
426
+ 368 | function v1_handleMintForeignToken(ChannelID channelID, bytes calldata data)
427
+ | ---------
540
428
  |
541
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#pascal-case-struct
429
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
542
430
 
543
- note[mixed-case-variable]: mutable variables should use mixedCase
544
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:117:16
431
+ note[mixed-case-function]: function names should use mixedCase
432
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:394:14
545
433
  |
546
- 117 | uint64 nextAuthoritySetID;
547
- | ------------------
434
+ 394 | function v1_transactionBaseGas() internal pure returns (uint256) {
435
+ | ---------------------
548
436
  |
549
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
437
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
550
438
 
551
439
  note[mixed-case-variable]: mutable variables should use mixedCase
552
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:155:20
553
- |
554
- 155 | bytes32 public latestMMRRoot;
555
- | -------------
556
- |
557
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
440
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/interfaces/IGatewayBase.sol:34:50
441
+ |
442
+ 34 | event ForeignTokenRegistered(bytes32 indexed tokenID, address token);
443
+ | -------
444
+ |
445
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
558
446
 
559
447
  note[screaming-snake-case-immutable]: immutables should use SCREAMING_SNAKE_CASE
560
448
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:182:30
@@ -580,6 +468,38 @@ note[screaming-snake-case-immutable]: immutables should use SCREAMING_SNAKE_CASE
580
468
  |
581
469
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-immutable
582
470
 
471
+ note[mixed-case-variable]: mutable variables should use mixedCase
472
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:116:17
473
+ |
474
+ 116 | bytes32 foreignTokenID,
475
+ | --------------
476
+ |
477
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
478
+
479
+ note[mixed-case-variable]: mutable variables should use mixedCase
480
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:136:39
481
+ |
482
+ 136 | function mintForeignToken(bytes32 foreignTokenID, address recipient, uint128 amount)
483
+ | --------------
484
+ |
485
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
486
+
487
+ note[mixed-case-function]: function names should use mixedCase
488
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Token.sol:81:14
489
+ |
490
+ 81 | function DOMAIN_SEPARATOR() external view returns (bytes32) {
491
+ | ----------------
492
+ |
493
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
494
+
495
+ note[mixed-case-variable]: mutable variables should use mixedCase
496
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:108:16
497
+ |
498
+ 108 | bytes4 encodedParaID,
499
+ | -------------
500
+ |
501
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
502
+
583
503
  note[mixed-case-variable]: mutable variables should use mixedCase
584
504
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/storage/AssetsStorage.sol:13:16
585
505
  |
@@ -589,82 +509,74 @@ note[mixed-case-variable]: mutable variables should use mixedCase
589
509
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
590
510
 
591
511
  note[mixed-case-function]: function names should use mixedCase
592
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:363:14
512
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/interfaces/IERC20Permit.sol:11:14
513
+ |
514
+ 11 | function DOMAIN_SEPARATOR() external view returns (bytes32);
515
+ | ----------------
516
+ |
517
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
518
+
519
+ note[mixed-case-variable]: mutable variables should use mixedCase
520
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:148:44
593
521
  |
594
- 363 | function v1_handleRegisterForeignToken(bytes calldata data) external onlySelf {
595
- | -----------------------------
522
+ 148 | function _ensureTokenAddressOf(bytes32 tokenID) internal view returns (address) {
523
+ | -------
596
524
  |
597
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
525
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
598
526
 
599
527
  note[mixed-case-function]: function names should use mixedCase
600
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:368:14
528
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:410:14
601
529
  |
602
- 368 | function v1_handleMintForeignToken(ChannelID channelID, bytes calldata data)
603
- | -------------------------
530
+ 410 | function v2_submit(
531
+ | ---------
604
532
  |
605
533
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
606
534
 
607
- note[mixed-case-variable]: mutable variables should use mixedCase
608
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:368:50
535
+ note[mixed-case-function]: function names should use mixedCase
536
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:444:14
609
537
  |
610
- 368 | function v1_handleMintForeignToken(ChannelID channelID, bytes calldata data)
611
- | ---------
538
+ 444 | function v2_outboundNonce() external view returns (uint64) {
539
+ | ----------------
612
540
  |
613
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
541
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
614
542
 
615
543
  note[mixed-case-function]: function names should use mixedCase
616
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:394:14
544
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:448:14
617
545
  |
618
- 394 | function v1_transactionBaseGas() internal pure returns (uint256) {
619
- | ---------------------
546
+ 448 | function v2_isDispatched(uint64 nonce) external view returns (bool) {
547
+ | ---------------
620
548
  |
621
549
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
622
550
 
623
- note[mixed-case-variable]: mutable variables should use mixedCase
624
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:51:16
625
- |
626
- 51 | bytes4 consensusEngineID;
627
- | -----------------
628
- |
629
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
630
-
631
- note[mixed-case-variable]: mutable variables should use mixedCase
632
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:159:40
551
+ note[mixed-case-function]: function names should use mixedCase
552
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:453:14
633
553
  |
634
- 159 | function channelNoncesOf(ChannelID channelID) external view returns (uint64, uint64) {
635
- | ---------
554
+ 453 | function v2_sendMessage(
555
+ | --------------
636
556
  |
637
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
557
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
638
558
 
639
- note[mixed-case-variable]: mutable variables should use mixedCase
640
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:164:47
559
+ note[mixed-case-function]: function names should use mixedCase
560
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:464:14
641
561
  |
642
- 164 | function channelOperatingModeOf(ChannelID channelID) external view returns (OperatingMode) {
643
- | ---------
562
+ 464 | function v2_registerToken(
563
+ | ----------------
644
564
  |
645
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
565
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
646
566
 
647
567
  note[mixed-case-variable]: mutable variables should use mixedCase
648
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:170:37
568
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:315:17
649
569
  |
650
- 170 | function tokenAddressOf(bytes32 tokenID) external view returns (address) {
651
- | -------
570
+ 315 | bytes32 ticketID = createTicketID(msg.sender, commitmentHash);
571
+ | --------
652
572
  |
653
573
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
654
574
 
655
- warning[incorrect-shift]: the order of args in a shift operation is incorrect
656
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/utils/Math.sol:82:60
657
- |
658
- 82 | return result + (unsignedRoundsUp(rounding) && 1 << result < value ? 1 : 0);
659
- | -----------
660
- |
661
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#incorrect-shift
662
-
663
575
  note[mixed-case-variable]: mutable variables should use mixedCase
664
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:108:16
576
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:205:53
665
577
  |
666
- 108 | bytes4 encodedParaID,
667
- | -------------
578
+ 205 | function createParachainHeaderMerkleLeaf(bytes4 encodedParaID, ParachainHeader calldata header)
579
+ | -------------
668
580
  |
669
581
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
670
582
 
@@ -676,325 +588,365 @@ warning[incorrect-shift]: the order of args in a shift operation is incorrect
676
588
  |
677
589
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#incorrect-shift
678
590
 
679
- warning[incorrect-shift]: the order of args in a shift operation is incorrect
680
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/utils/SparseBitmap.sol:18:20
681
- |
682
- 18 | uint256 mask = 1 << (index & 0xff);
683
- | -------------------
684
- |
685
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#incorrect-shift
591
+ note[mixed-case-function]: function names should use mixedCase
592
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:475:14
593
+ |
594
+ 475 | function v2_createAgent(bytes32 id) external {
595
+ | --------------
596
+ |
597
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
686
598
 
687
599
  note[mixed-case-function]: function names should use mixedCase
688
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:163:14
600
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:484:14
689
601
  |
690
- 163 | function SendForeignTokenToAddress20(
691
- | ---------------------------
602
+ 484 | function v2_handleUpgrade(bytes calldata data) external onlySelf {
603
+ | ----------------
692
604
  |
693
605
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
694
606
 
695
- note[mixed-case-variable]: mutable variables should use mixedCase
696
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:164:17
607
+ note[mixed-case-function]: function names should use mixedCase
608
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:489:14
697
609
  |
698
- 164 | bytes32 tokenID,
699
- | -------
610
+ 489 | function v2_handleSetOperatingMode(bytes calldata data) external onlySelf {
611
+ | -------------------------
700
612
  |
701
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
613
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
702
614
 
703
- note[mixed-case-variable]: mutable variables should use mixedCase
704
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/SubstrateTypes.sol:165:16
615
+ note[mixed-case-function]: function names should use mixedCase
616
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:494:14
705
617
  |
706
- 165 | ParaID paraID,
707
- | ------
618
+ 494 | function v2_handleUnlockNativeToken(bytes calldata data) external onlySelf {
619
+ | --------------------------
708
620
  |
709
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
621
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
622
+
623
+ note[mixed-case-function]: function names should use mixedCase
624
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:499:14
625
+ |
626
+ 499 | function v2_handleRegisterForeignToken(bytes calldata data) external onlySelf {
627
+ | -----------------------------
628
+ |
629
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
710
630
 
711
631
  note[mixed-case-variable]: mutable variables should use mixedCase
712
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:211:19
632
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:214:43
713
633
  |
714
- 211 | ChannelID channelID = ticket.dest.into();
715
- | ---------
634
+ 214 | function createParachainHeader(bytes4 encodedParaID, ParachainHeader calldata header)
635
+ | -------------
716
636
  |
717
637
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
718
638
 
719
- note[mixed-case-variable]: mutable variables should use mixedCase
720
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:20:27
721
- |
722
- 20 | ChannelID indexed channelID, uint64 nonce, bytes32 indexed messageID, bool success
723
- | ---------
724
- |
725
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
639
+ note[mixed-case-function]: function names should use mixedCase
640
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:243:14
641
+ |
642
+ 243 | function createMMRLeaf(MMRLeafPartial memory leaf, bytes32 parachainHeadsRoot)
643
+ | -------------
644
+ |
645
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
726
646
 
727
647
  note[mixed-case-variable]: mutable variables should use mixedCase
728
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:20:68
729
- |
730
- 20 | ChannelID indexed channelID, uint64 nonce, bytes32 indexed messageID, bool success
731
- | ---------
732
- |
733
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
648
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:359:17
649
+ |
650
+ 359 | bytes32 ticketID = createTicketID(msg.sender, commitmentHash);
651
+ | --------
652
+ |
653
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
734
654
 
735
655
  note[mixed-case-variable]: mutable variables should use mixedCase
736
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:242:17
656
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:362:14
737
657
  |
738
- 242 | bytes32 messageID = keccak256(abi.encodePacked(channelID, channel.outboundNonce));
739
- | ---------
658
+ 362 | bool is_next_session = false;
659
+ | ---------------
740
660
  |
741
661
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
742
662
 
743
663
  note[mixed-case-variable]: mutable variables should use mixedCase
744
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:205:53
664
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:373:17
745
665
  |
746
- 205 | function createParachainHeaderMerkleLeaf(bytes4 encodedParaID, ParachainHeader calldata header)
747
- | -------------
666
+ 373 | bytes32 newMMRRoot = ensureProvidesMMRRoot(commitment);
667
+ | ----------
748
668
  |
749
669
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
750
670
 
751
- note[mixed-case-function]: function names should use mixedCase
752
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:13:10
753
- |
754
- 13 | function ParaIDEq(ParaID a, ParaID b) pure returns (bool) {
755
- | --------
671
+ note[unused-import]: unused imports should be removed
672
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:5:9
673
+ |
674
+ 5 | import {TokenInfo, OperatingMode} from "./types/Common.sol";
675
+ | ---------
676
+ |
677
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
678
+
679
+ note[unused-import]: unused imports should be removed
680
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:5:20
681
+ |
682
+ 5 | import {TokenInfo, OperatingMode} from "./types/Common.sol";
683
+ | -------------
684
+ |
685
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
686
+
687
+ note[unused-import]: unused imports should be removed
688
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:6:9
689
+ |
690
+ 6 | import {UD60x18} from "prb/math/src/UD60x18.sol";
691
+ | -------
692
+ |
693
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
694
+
695
+ note[unused-import]: unused imports should be removed
696
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:8:5
697
+ |
698
+ 8 | ParaID,
699
+ | ------
700
+ |
701
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
702
+
703
+ note[unused-import]: unused imports should be removed
704
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:9:5
705
+ |
706
+ 9 | ChannelID,
707
+ | ---------
708
+ |
709
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
710
+
711
+ note[unused-import]: unused imports should be removed
712
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:10:5
756
713
  |
757
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
714
+ 10 | Channel,
715
+ | -------
716
+ |
717
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
758
718
 
759
- note[mixed-case-variable]: mutable variables should use mixedCase
760
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:39:38
719
+ note[unused-import]: unused imports should be removed
720
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:11:5
761
721
  |
762
- 39 | function ensureChannel(ChannelID channelID) internal view returns (Channel storage ch) {
763
- | ---------
722
+ 11 | InboundMessage as InboundMessageV1,
723
+ | ----------------------------------
764
724
  |
765
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
725
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
726
+
727
+ note[unused-import]: unused imports should be removed
728
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:12:5
729
+ |
730
+ 12 | Command as CommandV1,
731
+ | --------------------
732
+ |
733
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
766
734
 
767
735
  note[mixed-case-variable]: mutable variables should use mixedCase
768
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:25:27
736
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/types/Common.sol:14:13
769
737
  |
770
- 25 | ChannelID indexed channelID, uint64 nonce, bytes32 indexed messageID, bytes payload
771
- | ---------
738
+ 14 | bytes32 foreignID;
739
+ | ---------
772
740
  |
773
741
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
774
742
 
775
- note[mixed-case-variable]: mutable variables should use mixedCase
776
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:116:17
777
- |
778
- 116 | bytes32 foreignTokenID,
779
- | --------------
780
- |
781
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
743
+ note[unused-import]: unused imports should be removed
744
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/types/Common.sol:5:9
745
+ |
746
+ 5 | import {UD60x18} from "prb/math/src/UD60x18.sol";
747
+ | -------
748
+ |
749
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
782
750
 
783
- note[mixed-case-variable]: mutable variables should use mixedCase
784
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Handlers.sol:120:41
751
+ note[mixed-case-function]: function names should use mixedCase
752
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:405:14
785
753
  |
786
- 120 | function mintForeignToken(ChannelID channelID, bytes calldata data) external {
787
- | ---------
754
+ 405 | function verifyMMRLeafProof(bytes32 leafHash, bytes32[] calldata proof, uint256 proofOrder)
755
+ | ------------------
788
756
  |
789
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
757
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
790
758
 
791
- note[mixed-case-variable]: mutable variables should use mixedCase
792
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:25:68
759
+ warning[incorrect-shift]: the order of args in a shift operation is incorrect
760
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/utils/SparseBitmap.sol:18:20
793
761
  |
794
- 25 | ChannelID indexed channelID, uint64 nonce, bytes32 indexed messageID, bytes payload
795
- | ---------
762
+ 18 | uint256 mask = 1 << (index & 0xff);
763
+ | -------------------
796
764
  |
797
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
765
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#incorrect-shift
798
766
 
799
- note[mixed-case-variable]: mutable variables should use mixedCase
800
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:32:47
767
+ note[unused-import]: unused imports should be removed
768
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:8:9
769
+ |
770
+ 8 | import {SubstrateTypes} from "./SubstrateTypes.sol";
771
+ | --------------
772
+ |
773
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
774
+
775
+ warning[incorrect-shift]: the order of args in a shift operation is incorrect
776
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/utils/Math.sol:82:60
801
777
  |
802
- 32 | event AgentFundsWithdrawn(bytes32 indexed agentID, address indexed recipient, uint256 amount);
803
- | -------
778
+ 82 | return result + (unsignedRoundsUp(rounding) && 1 << result < value ? 1 : 0);
779
+ | -----------
804
780
  |
805
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
781
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#incorrect-shift
806
782
 
807
783
  note[mixed-case-variable]: mutable variables should use mixedCase
808
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:355:17
784
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:159:40
809
785
  |
810
- 355 | bytes32 foreignID,
811
- | ---------
786
+ 159 | function channelNoncesOf(ChannelID channelID) external view returns (uint64, uint64) {
787
+ | ---------
812
788
  |
813
789
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
814
790
 
815
791
  note[mixed-case-variable]: mutable variables should use mixedCase
816
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:315:17
792
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:164:47
817
793
  |
818
- 315 | bytes32 ticketID = createTicketID(msg.sender, commitmentHash);
819
- | --------
794
+ 164 | function channelOperatingModeOf(ChannelID channelID) external view returns (OperatingMode) {
795
+ | ---------
820
796
  |
821
797
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
822
798
 
823
- note[mixed-case-function]: function names should use mixedCase
824
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:410:14
799
+ note[mixed-case-variable]: mutable variables should use mixedCase
800
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:170:37
825
801
  |
826
- 410 | function v2_submit(
827
- | ---------
802
+ 170 | function tokenAddressOf(bytes32 tokenID) external view returns (address) {
803
+ | -------
828
804
  |
829
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
805
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
830
806
 
831
- note[mixed-case-variable]: mutable variables should use mixedCase
832
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:42:30
807
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
808
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/upgrade/Gateway202509.sol:5:8
809
+ |
810
+ 5 | import "../Gateway.sol";
811
+ | ----------------
812
+ |
813
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
814
+
815
+ note[unused-import]: unused imports should be removed
816
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:13:5
833
817
  |
834
- 42 | function agentOf(bytes32 agentID) external view returns (address);
835
- | -------
818
+ 13 | MultiAddress
819
+ | ------------
836
820
  |
837
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
821
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
838
822
 
839
- note[mixed-case-variable]: mutable variables should use mixedCase
840
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:44:47
823
+ note[unused-import]: unused imports should be removed
824
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:15:9
841
825
  |
842
- 44 | function channelOperatingModeOf(ChannelID channelID) external view returns (OperatingMode);
843
- | ---------
826
+ 15 | import {CallsV1} from "./v1/Calls.sol";
827
+ | -------
844
828
  |
845
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
846
-
847
- note[mixed-case-variable]: mutable variables should use mixedCase
848
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:214:43
849
- |
850
- 214 | function createParachainHeader(bytes4 encodedParaID, ParachainHeader calldata header)
851
- | -------------
852
- |
853
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
854
-
855
- note[mixed-case-function]: function names should use mixedCase
856
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:243:14
857
- |
858
- 243 | function createMMRLeaf(MMRLeafPartial memory leaf, bytes32 parachainHeadsRoot)
859
- | -------------
860
- |
861
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
829
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
862
830
 
863
831
  note[unused-import]: unused imports should be removed
864
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Handlers.sol:13:9
832
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:16:9
865
833
  |
866
- 13 | import {AgentExecutor} from "../AgentExecutor.sol";
867
- | -------------
834
+ 16 | import {HandlersV1} from "./v1/Handlers.sol";
835
+ | ----------
868
836
  |
869
837
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
870
838
 
871
- note[mixed-case-variable]: mutable variables should use mixedCase
872
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:46:40
839
+ note[unused-import]: unused imports should be removed
840
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:17:9
873
841
  |
874
- 46 | function channelNoncesOf(ChannelID channelID) external view returns (uint64, uint64);
875
- | ---------
842
+ 17 | import {IGatewayV1} from "./v1/IGateway.sol";
843
+ | ----------
876
844
  |
877
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
845
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
878
846
 
879
847
  note[unused-import]: unused imports should be removed
880
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:14:9
848
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:20:5
881
849
  |
882
- 14 | import {AgentExecutor} from "../AgentExecutor.sol";
883
- | -------------
850
+ 20 | InboundMessage as InboundMessageV2, Command as CommandV2, CommandKind
851
+ | ----------------------------------
884
852
  |
885
853
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
886
854
 
887
855
  note[unused-import]: unused imports should be removed
888
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:15:9
856
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:20:41
889
857
  |
890
- 15 | import {Agent} from "../Agent.sol";
891
- | -----
858
+ 20 | InboundMessage as InboundMessageV2, Command as CommandV2, CommandKind
859
+ | --------------------
892
860
  |
893
861
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
894
862
 
895
863
  note[unused-import]: unused imports should be removed
896
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:16:9
864
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:20:63
897
865
  |
898
- 16 | import {Call} from "../utils/Call.sol";
899
- | ----
866
+ 20 | InboundMessage as InboundMessageV2, Command as CommandV2, CommandKind
867
+ | -----------
900
868
  |
901
869
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
902
870
 
903
871
  note[unused-import]: unused imports should be removed
904
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:25:5
872
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:22:9
905
873
  |
906
- 25 | AgentExecuteCommand,
907
- | -------------------
874
+ 22 | import {CallsV2} from "./v2/Calls.sol";
875
+ | -------
908
876
  |
909
877
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
910
878
 
911
879
  note[unused-import]: unused imports should be removed
912
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:31:18
880
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:23:9
913
881
  |
914
- 31 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
915
- | -------
882
+ 23 | import {HandlersV2} from "./v2/Handlers.sol";
883
+ | ----------
916
884
  |
917
885
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
918
886
 
919
- note[mixed-case-function]: function names should use mixedCase
920
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:444:14
887
+ note[mixed-case-variable]: mutable variables should use mixedCase
888
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:211:19
921
889
  |
922
- 444 | function v2_outboundNonce() external view returns (uint64) {
923
- | ----------------
890
+ 211 | ChannelID channelID = ticket.dest.into();
891
+ | ---------
924
892
  |
925
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
893
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
926
894
 
927
895
  note[mixed-case-function]: function names should use mixedCase
928
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:448:14
896
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:451:14
929
897
  |
930
- 448 | function v2_isDispatched(uint64 nonce) external view returns (bool) {
931
- | ---------------
898
+ 451 | function createTicketID(address account, bytes32 commitmentHash)
899
+ | --------------
932
900
  |
933
901
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
934
902
 
935
- note[mixed-case-function]: function names should use mixedCase
936
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:453:14
903
+ note[mixed-case-variable]: mutable variables should use mixedCase
904
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Handlers.sol:120:41
937
905
  |
938
- 453 | function v2_sendMessage(
939
- | --------------
906
+ 120 | function mintForeignToken(ChannelID channelID, bytes calldata data) external {
907
+ | ---------
940
908
  |
941
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
909
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
942
910
 
943
- note[mixed-case-function]: function names should use mixedCase
944
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:464:14
945
- |
946
- 464 | function v2_registerToken(
947
- | ----------------
948
- |
949
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
911
+ note[unused-import]: unused imports should be removed
912
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Handlers.sol:13:9
913
+ |
914
+ 13 | import {AgentExecutor} from "../AgentExecutor.sol";
915
+ | -------------
916
+ |
917
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
950
918
 
951
- note[mixed-case-function]: function names should use mixedCase
952
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:475:14
919
+ note[mixed-case-variable]: mutable variables should use mixedCase
920
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:242:17
953
921
  |
954
- 475 | function v2_createAgent(bytes32 id) external {
955
- | --------------
922
+ 242 | bytes32 messageID = keccak256(abi.encodePacked(channelID, channel.outboundNonce));
923
+ | ---------
956
924
  |
957
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
925
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
958
926
 
959
927
  note[mixed-case-function]: function names should use mixedCase
960
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:484:14
928
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:504:14
961
929
  |
962
- 484 | function v2_handleUpgrade(bytes calldata data) external onlySelf {
963
- | ----------------
930
+ 504 | function v2_handleMintForeignToken(bytes calldata data) external onlySelf {
931
+ | -------------------------
964
932
  |
965
933
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
966
934
 
967
935
  note[mixed-case-function]: function names should use mixedCase
968
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Calls.sol:139:14
936
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:509:14
969
937
  |
970
- 139 | function _handleAssetERC20(address token, uint128 amount) internal returns (Asset memory) {
971
- | -----------------
938
+ 509 | function v2_handleCallContract(bytes32 origin, bytes calldata data) external onlySelf {
939
+ | ---------------------
972
940
  |
973
941
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
974
942
 
975
- note[mixed-case-variable]: mutable variables should use mixedCase
976
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:359:17
977
- |
978
- 359 | bytes32 ticketID = createTicketID(msg.sender, commitmentHash);
979
- | --------
980
- |
981
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
982
-
983
- note[mixed-case-variable]: mutable variables should use mixedCase
984
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:362:14
985
- |
986
- 362 | bool is_next_session = false;
987
- | ---------------
988
- |
989
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
990
-
991
- note[mixed-case-variable]: mutable variables should use mixedCase
992
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:373:17
993
- |
994
- 373 | bytes32 newMMRRoot = ensureProvidesMMRRoot(commitment);
995
- | ----------
996
- |
997
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
943
+ note[mixed-case-function]: function names should use mixedCase
944
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:13:10
945
+ |
946
+ 13 | function ParaIDEq(ParaID a, ParaID b) pure returns (bool) {
947
+ | --------
948
+ |
949
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
998
950
 
999
951
  note[mixed-case-function]: function names should use mixedCase
1000
952
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:17:10
@@ -1028,221 +980,205 @@ note[mixed-case-function]: function names should use mixedCase
1028
980
  |
1029
981
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1030
982
 
1031
- note[unused-import]: unused imports should be removed
1032
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Handlers.sol:13:9
983
+ note[mixed-case-variable]: mutable variables should use mixedCase
984
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:53:15
1033
985
  |
1034
- 13 | import {IGatewayV2} from "./IGateway.sol";
1035
- | ----------
986
+ 53 | ChannelID channelID;
987
+ | ---------
1036
988
  |
1037
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
989
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1038
990
 
1039
991
  note[mixed-case-variable]: mutable variables should use mixedCase
1040
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:136:39
992
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:355:17
1041
993
  |
1042
- 136 | function mintForeignToken(bytes32 foreignTokenID, address recipient, uint128 amount)
1043
- | --------------
994
+ 355 | bytes32 foreignID,
995
+ | ---------
1044
996
  |
1045
997
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1046
998
 
1047
- note[mixed-case-variable]: mutable variables should use mixedCase
1048
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Functions.sol:148:44
999
+ note[mixed-case-function]: function names should use mixedCase
1000
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:566:14
1049
1001
  |
1050
- 148 | function _ensureTokenAddressOf(bytes32 tokenID) internal view returns (address) {
1051
- | -------
1002
+ 566 | function v2_dispatch(InboundMessageV2 calldata message) internal returns (bool) {
1003
+ | -----------
1052
1004
  |
1053
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1005
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1054
1006
 
1055
1007
  note[mixed-case-function]: function names should use mixedCase
1056
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:405:14
1008
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Calls.sol:139:14
1057
1009
  |
1058
- 405 | function verifyMMRLeafProof(bytes32 leafHash, bytes32[] calldata proof, uint256 proofOrder)
1059
- | ------------------
1010
+ 139 | function _handleAssetERC20(address token, uint128 amount) internal returns (Asset memory) {
1011
+ | -----------------
1060
1012
  |
1061
1013
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1062
1014
 
1063
- note[unused-import]: unused imports should be removed
1064
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Calls.sol:29:9
1065
- |
1066
- 29 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1067
- | -------
1068
- |
1069
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1070
-
1071
- note[unused-import]: unused imports should be removed
1072
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Calls.sol:29:18
1073
- |
1074
- 29 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1075
- | -------
1076
- |
1077
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1078
-
1079
- note[unused-import]: unused imports should be removed
1080
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Calls.sol:29:27
1081
- |
1082
- 29 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1083
- | -------
1084
- |
1085
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1086
-
1087
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1088
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:28:20
1089
- |
1090
- 28 | uint8 constant Upgrade = 0;
1091
- | -------
1092
- |
1093
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1015
+ note[mixed-case-variable]: mutable variables should use mixedCase
1016
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:108:13
1017
+ |
1018
+ 108 | bytes32 agentID;
1019
+ | -------
1020
+ |
1021
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1094
1022
 
1095
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1096
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:30:20
1023
+ note[mixed-case-variable]: mutable variables should use mixedCase
1024
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:20:27
1097
1025
  |
1098
- 30 | uint8 constant SetOperatingMode = 1;
1099
- | ----------------
1026
+ 20 | ChannelID indexed channelID, uint64 nonce, bytes32 indexed messageID, bool success
1027
+ | ---------
1100
1028
  |
1101
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1029
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1102
1030
 
1103
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1104
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:32:20
1031
+ note[mixed-case-variable]: mutable variables should use mixedCase
1032
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:20:68
1105
1033
  |
1106
- 32 | uint8 constant UnlockNativeToken = 2;
1107
- | -----------------
1034
+ 20 | ChannelID indexed channelID, uint64 nonce, bytes32 indexed messageID, bool success
1035
+ | ---------
1108
1036
  |
1109
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1037
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1110
1038
 
1111
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1112
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:34:20
1039
+ note[mixed-case-variable]: mutable variables should use mixedCase
1040
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:25:27
1113
1041
  |
1114
- 34 | uint8 constant RegisterForeignToken = 3;
1115
- | --------------------
1042
+ 25 | ChannelID indexed channelID, uint64 nonce, bytes32 indexed messageID, bytes payload
1043
+ | ---------
1116
1044
  |
1117
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1045
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1118
1046
 
1119
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1120
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:36:20
1047
+ note[mixed-case-variable]: mutable variables should use mixedCase
1048
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:25:68
1121
1049
  |
1122
- 36 | uint8 constant MintForeignToken = 4;
1123
- | ----------------
1050
+ 25 | ChannelID indexed channelID, uint64 nonce, bytes32 indexed messageID, bytes payload
1051
+ | ---------
1124
1052
  |
1125
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1053
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1126
1054
 
1127
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1128
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:38:20
1055
+ note[mixed-case-variable]: mutable variables should use mixedCase
1056
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:32:47
1129
1057
  |
1130
- 38 | uint8 constant CallContract = 5;
1131
- | ------------
1058
+ 32 | event AgentFundsWithdrawn(bytes32 indexed agentID, address indexed recipient, uint256 amount);
1059
+ | -------
1132
1060
  |
1133
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1061
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1134
1062
 
1135
1063
  note[mixed-case-variable]: mutable variables should use mixedCase
1136
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:53:15
1064
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:42:30
1137
1065
  |
1138
- 53 | ChannelID channelID;
1139
- | ---------
1066
+ 42 | function agentOf(bytes32 agentID) external view returns (address);
1067
+ | -------
1140
1068
  |
1141
1069
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1142
1070
 
1143
1071
  note[mixed-case-variable]: mutable variables should use mixedCase
1144
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:22:30
1072
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:44:47
1145
1073
  |
1146
- 22 | function agentOf(bytes32 agentID) external view returns (address);
1147
- | -------
1074
+ 44 | function channelOperatingModeOf(ChannelID channelID) external view returns (OperatingMode);
1075
+ | ---------
1148
1076
  |
1149
1077
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1150
1078
 
1151
1079
  note[mixed-case-variable]: mutable variables should use mixedCase
1152
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:29:32
1080
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:46:40
1153
1081
  |
1154
- 29 | event AgentCreated(bytes32 agentID, address agent);
1155
- | -------
1082
+ 46 | function channelNoncesOf(ChannelID channelID) external view returns (uint64, uint64);
1083
+ | ---------
1156
1084
  |
1157
1085
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1158
1086
 
1159
1087
  note[mixed-case-function]: function names should use mixedCase
1160
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:51:14
1088
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:86:14
1161
1089
  |
1162
- 51 | function v2_submit(
1163
- | ---------
1090
+ 86 | function queryForeignTokenID(address token) external view returns (bytes32);
1091
+ | -------------------
1164
1092
  |
1165
1093
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1166
1094
 
1167
- note[mixed-case-function]: function names should use mixedCase
1168
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:81:14
1095
+ note[mixed-case-variable]: mutable variables should use mixedCase
1096
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:117:37
1097
+ |
1098
+ 117 | function tokenAddressOf(bytes32 tokenID) external view returns (address);
1099
+ | -------
1100
+ |
1101
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1102
+
1103
+ note[unused-import]: unused imports should be removed
1104
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Types.sol:24:9
1169
1105
  |
1170
- 81 | function v2_sendMessage(
1171
- | --------------
1106
+ 24 | import {IGatewayV2} from "./v2/IGateway.sol";
1107
+ | ----------
1172
1108
  |
1173
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1109
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1174
1110
 
1175
- note[mixed-case-function]: function names should use mixedCase
1176
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:96:14
1111
+ note[unused-import]: unused imports should be removed
1112
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:8:9
1113
+ |
1114
+ 8 | import {AgentExecutor} from "./AgentExecutor.sol";
1115
+ | -------------
1116
+ |
1117
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1118
+
1119
+ note[unused-import]: unused imports should be removed
1120
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:29:9
1177
1121
  |
1178
- 96 | function v2_registerToken(
1179
- | ----------------
1122
+ 29 | import {Upgrade} from "./Upgrade.sol";
1123
+ | -------
1180
1124
  |
1181
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1125
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1182
1126
 
1183
- note[mixed-case-function]: function names should use mixedCase
1184
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:105:14
1185
- |
1186
- 105 | function v2_createAgent(bytes32 id) external;
1187
- | --------------
1188
- |
1189
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1190
-
1191
- note[mixed-case-function]: function names should use mixedCase
1192
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:108:14
1193
- |
1194
- 108 | function v2_outboundNonce() external view returns (uint64);
1195
- | ----------------
1196
- |
1197
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1127
+ note[unused-import]: unused imports should be removed
1128
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:41:9
1129
+ |
1130
+ 41 | import {PricingStorage} from "./storage/PricingStorage.sol";
1131
+ | --------------
1132
+ |
1133
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1198
1134
 
1199
- note[mixed-case-function]: function names should use mixedCase
1200
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:111:14
1201
- |
1202
- 111 | function v2_isDispatched(uint64 nonce) external view returns (bool);
1203
- | ---------------
1204
- |
1205
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1135
+ note[unused-import]: unused imports should be removed
1136
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:44:18
1137
+ |
1138
+ 44 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1139
+ | -------
1140
+ |
1141
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1206
1142
 
1207
- note[mixed-case-function]: function names should use mixedCase
1208
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:86:14
1143
+ note[unused-import]: unused imports should be removed
1144
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:44:27
1209
1145
  |
1210
- 86 | function queryForeignTokenID(address token) external view returns (bytes32);
1211
- | -------------------
1146
+ 44 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1147
+ | -------
1212
1148
  |
1213
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1149
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1214
1150
 
1215
- note[mixed-case-function]: function names should use mixedCase
1216
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:451:14
1217
- |
1218
- 451 | function createTicketID(address account, bytes32 commitmentHash)
1219
- | --------------
1220
- |
1221
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1151
+ note[unused-import]: unused imports should be removed
1152
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Calls.sol:29:9
1153
+ |
1154
+ 29 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1155
+ | -------
1156
+ |
1157
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1222
1158
 
1223
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1224
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Agent.t.sol:4:8
1225
- |
1226
- 4 | import "forge-std/Test.sol";
1227
- | --------------------
1228
- |
1229
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1159
+ note[unused-import]: unused imports should be removed
1160
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Calls.sol:29:18
1161
+ |
1162
+ 29 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1163
+ | -------
1164
+ |
1165
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1230
1166
 
1231
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1232
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Agent.t.sol:5:8
1233
- |
1234
- 5 | import "forge-std/console.sol";
1235
- | -----------------------
1236
- |
1237
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1167
+ note[unused-import]: unused imports should be removed
1168
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Calls.sol:29:27
1169
+ |
1170
+ 29 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1171
+ | -------
1172
+ |
1173
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1238
1174
 
1239
- note[mixed-case-variable]: mutable variables should use mixedCase
1240
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:108:13
1241
- |
1242
- 108 | bytes32 agentID;
1243
- | -------
1244
- |
1245
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1175
+ note[unused-import]: unused imports should be removed
1176
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Handlers.sol:13:9
1177
+ |
1178
+ 13 | import {IGatewayV2} from "./IGateway.sol";
1179
+ | ----------
1180
+ |
1181
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1246
1182
 
1247
1183
  note[mixed-case-variable]: mutable variables should use mixedCase
1248
1184
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:153:13
@@ -1269,68 +1205,68 @@ note[mixed-case-variable]: mutable variables should use mixedCase
1269
1205
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1270
1206
 
1271
1207
  note[mixed-case-variable]: mutable variables should use mixedCase
1272
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/BeefyClient.t.sol:43:12
1208
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:22:30
1273
1209
  |
1274
- 43 | bytes2 mmrRootID = bytes2("mh");
1275
- | ---------
1210
+ 22 | function agentOf(bytes32 agentID) external view returns (address);
1211
+ | -------
1212
+ |
1213
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1214
+
1215
+ note[mixed-case-variable]: mutable variables should use mixedCase
1216
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:29:32
1217
+ |
1218
+ 29 | event AgentCreated(bytes32 agentID, address agent);
1219
+ | -------
1276
1220
  |
1277
1221
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1278
1222
 
1223
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1224
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Agent.t.sol:4:8
1225
+ |
1226
+ 4 | import "forge-std/Test.sol";
1227
+ | --------------------
1228
+ |
1229
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1230
+
1231
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1232
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Agent.t.sol:5:8
1233
+ |
1234
+ 5 | import "forge-std/console.sol";
1235
+ | -----------------------
1236
+ |
1237
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1238
+
1279
1239
  note[unused-import]: unused imports should be removed
1280
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Bitfield.t.sol:5:9
1240
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:5:9
1281
1241
  |
1282
- 5 | import {console} from "forge-std/console.sol";
1283
- | -------
1242
+ 5 | import {TokenInfo, OperatingMode} from "../types/Common.sol";
1243
+ | ---------
1284
1244
  |
1285
1245
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1286
1246
 
1287
- note[mixed-case-function]: function names should use mixedCase
1288
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:489:14
1289
- |
1290
- 489 | function v2_handleSetOperatingMode(bytes calldata data) external onlySelf {
1291
- | -------------------------
1292
- |
1293
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1294
-
1295
- note[mixed-case-function]: function names should use mixedCase
1296
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:494:14
1297
- |
1298
- 494 | function v2_handleUnlockNativeToken(bytes calldata data) external onlySelf {
1299
- | --------------------------
1300
- |
1301
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1247
+ note[unused-import]: unused imports should be removed
1248
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:6:9
1249
+ |
1250
+ 6 | import {MultiAddress} from "./MultiAddress.sol";
1251
+ | ------------
1252
+ |
1253
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1302
1254
 
1303
1255
  note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1304
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:68:20
1256
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:33:31
1305
1257
  |
1306
- 68 | uint8 constant Raw = 0;
1307
- | ---
1258
+ 33 | address constant internal assetHubAgent = 0xd803472c47a87D7B63E888DE53f03B4191B846a8;
1259
+ | -------------
1308
1260
  |
1309
1261
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1310
1262
 
1311
- note[mixed-case-function]: function names should use mixedCase
1312
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/BeefyClient.t.sol:167:14
1313
- |
1314
- 167 | function decodeMMRLeaf(string memory beefyCommitmentRaw) internal {
1315
- | -------------
1316
- |
1317
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1318
-
1319
1263
  note[mixed-case-variable]: mutable variables should use mixedCase
1320
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/BeefyClient.t.sol:171:16
1321
- |
1322
- 171 | uint64 nextAuthoritySetID =
1323
- | ------------------
1324
- |
1325
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1326
-
1327
- note[unused-import]: unused imports should be removed
1328
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:8:9
1329
- |
1330
- 8 | import {SubstrateTypes} from "./SubstrateTypes.sol";
1331
- | --------------
1332
- |
1333
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1264
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/BeefyClient.t.sol:43:12
1265
+ |
1266
+ 43 | bytes2 mmrRootID = bytes2("mh");
1267
+ | ---------
1268
+ |
1269
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1334
1270
 
1335
1271
  note[mixed-case-variable]: mutable variables should use mixedCase
1336
1272
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:503:17
@@ -1348,229 +1284,229 @@ note[mixed-case-function]: function names should use mixedCase
1348
1284
  |
1349
1285
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1350
1286
 
1351
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1352
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:33:31
1287
+ note[mixed-case-function]: function names should use mixedCase
1288
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:51:14
1353
1289
  |
1354
- 33 | address constant internal assetHubAgent = 0xd803472c47a87D7B63E888DE53f03B4191B846a8;
1355
- | -------------
1290
+ 51 | function v2_submit(
1291
+ | ---------
1356
1292
  |
1357
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1293
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1358
1294
 
1359
1295
  note[mixed-case-function]: function names should use mixedCase
1360
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:499:14
1296
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:81:14
1297
+ |
1298
+ 81 | function v2_sendMessage(
1299
+ | --------------
1300
+ |
1301
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1302
+
1303
+ note[mixed-case-function]: function names should use mixedCase
1304
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:96:14
1305
+ |
1306
+ 96 | function v2_registerToken(
1307
+ | ----------------
1308
+ |
1309
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1310
+
1311
+ note[mixed-case-function]: function names should use mixedCase
1312
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:105:14
1361
1313
  |
1362
- 499 | function v2_handleRegisterForeignToken(bytes calldata data) external onlySelf {
1363
- | -----------------------------
1314
+ 105 | function v2_createAgent(bytes32 id) external;
1315
+ | --------------
1364
1316
  |
1365
1317
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1366
1318
 
1367
1319
  note[mixed-case-function]: function names should use mixedCase
1368
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:504:14
1320
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:108:14
1369
1321
  |
1370
- 504 | function v2_handleMintForeignToken(bytes calldata data) external onlySelf {
1371
- | -------------------------
1322
+ 108 | function v2_outboundNonce() external view returns (uint64);
1323
+ | ----------------
1372
1324
  |
1373
1325
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1374
1326
 
1375
1327
  note[mixed-case-function]: function names should use mixedCase
1376
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:509:14
1328
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/IGateway.sol:111:14
1377
1329
  |
1378
- 509 | function v2_handleCallContract(bytes32 origin, bytes calldata data) external onlySelf {
1379
- | ---------------------
1330
+ 111 | function v2_isDispatched(uint64 nonce) external view returns (bool);
1331
+ | ---------------
1380
1332
  |
1381
1333
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1382
1334
 
1383
- note[unused-import]: unused imports should be removed
1384
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/BeefyClient.t.sol:11:9
1385
- |
1386
- 11 | import {ScaleCodec} from "../src/utils/ScaleCodec.sol";
1387
- | ----------
1388
- |
1389
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1390
-
1391
1335
  note[mixed-case-variable]: mutable variables should use mixedCase
1392
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/IGateway.sol:117:37
1336
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:139:16
1393
1337
  |
1394
- 117 | function tokenAddressOf(bytes32 tokenID) external view returns (address);
1395
- | -------
1338
+ 139 | ParaID paraID = ParaID.wrap(1000);
1339
+ | ------
1396
1340
  |
1397
1341
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1398
1342
 
1343
+ note[mixed-case-function]: function names should use mixedCase
1344
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:590:14
1345
+ |
1346
+ 590 | function encodeMMRLeaf(MMRLeaf calldata leaf) internal pure returns (bytes memory) {
1347
+ | -------------
1348
+ |
1349
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1350
+
1399
1351
  note[unused-import]: unused imports should be removed
1400
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:5:9
1401
- |
1402
- 5 | import {TokenInfo, OperatingMode} from "../types/Common.sol";
1403
- | ---------
1404
- |
1405
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1406
-
1407
- note[unused-import]: unused imports should be removed
1408
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Types.sol:6:9
1352
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Bitfield.t.sol:5:9
1409
1353
  |
1410
- 6 | import {MultiAddress} from "./MultiAddress.sol";
1411
- | ------------
1354
+ 5 | import {console} from "forge-std/console.sol";
1355
+ | -------
1412
1356
  |
1413
1357
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1414
1358
 
1415
- note[mixed-case-variable]: mutable variables should use mixedCase
1416
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:85:20
1359
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1360
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:68:8
1417
1361
  |
1418
- 85 | bytes32 public dotTokenID;
1419
- | ----------
1362
+ 68 | import "./mocks/HighGasToken.sol";
1363
+ | --------------------------
1420
1364
  |
1421
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1422
-
1423
- note[mixed-case-function]: function names should use mixedCase
1424
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:566:14
1425
- |
1426
- 566 | function v2_dispatch(InboundMessageV2 calldata message) internal returns (bool) {
1427
- | -----------
1428
- |
1429
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1365
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1430
1366
 
1431
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1432
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:70:20
1367
+ note[mixed-case-variable]: mutable variables should use mixedCase
1368
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:74:19
1433
1369
  |
1434
- 70 | uint8 constant CreateAsset = 1;
1435
- | -----------
1370
+ 74 | ParaID public bridgeHubParaID = ParaID.wrap(1013);
1371
+ | ---------------
1436
1372
  |
1437
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1373
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1438
1374
 
1439
- note[mixed-case-function]: function names should use mixedCase
1440
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:81:10
1375
+ note[mixed-case-variable]: mutable variables should use mixedCase
1376
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:76:20
1441
1377
  |
1442
- 81 | function makeRawXCM(bytes memory xcm) pure returns (Xcm memory) {
1443
- | ----------
1378
+ 76 | bytes32 public bridgeHubAgentID =
1379
+ | ----------------
1444
1380
  |
1445
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1381
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1446
1382
 
1447
- note[mixed-case-function]: function names should use mixedCase
1448
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:85:10
1383
+ note[mixed-case-variable]: mutable variables should use mixedCase
1384
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:80:19
1449
1385
  |
1450
- 85 | function makeCreateAssetXCM(address token, Network network) pure returns (Xcm memory) {
1451
- | ------------------
1386
+ 80 | ParaID public assetHubParaID = ParaID.wrap(1000);
1387
+ | --------------
1452
1388
  |
1453
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1389
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1454
1390
 
1455
1391
  note[unused-import]: unused imports should be removed
1456
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:5:9
1392
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:4:9
1457
1393
  |
1458
- 5 | import {Strings} from "openzeppelin/utils/Strings.sol";
1459
- | -------
1394
+ 4 | import {Vm} from "forge-std/Vm.sol";
1395
+ | --
1460
1396
  |
1461
1397
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1462
1398
 
1463
1399
  note[unused-import]: unused imports should be removed
1464
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:6:9
1400
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:6:9
1465
1401
  |
1466
- 6 | import {console} from "forge-std/console.sol";
1402
+ 6 | import {stdJson} from "forge-std/StdJson.sol";
1467
1403
  | -------
1468
1404
  |
1469
1405
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1470
1406
 
1471
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1472
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Math.t.sol:4:8
1473
- |
1474
- 4 | import "forge-std/Test.sol";
1475
- | --------------------
1476
- |
1477
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1478
-
1479
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1480
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Math.t.sol:5:8
1481
- |
1482
- 5 | import "forge-std/console.sol";
1483
- | -----------------------
1484
- |
1485
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1486
-
1487
1407
  note[unused-import]: unused imports should be removed
1488
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/MMRProof.t.sol:5:9
1408
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:7:9
1489
1409
  |
1490
- 5 | import {console} from "forge-std/console.sol";
1410
+ 7 | import {console} from "forge-std/console.sol";
1491
1411
  | -------
1492
1412
  |
1493
1413
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1494
1414
 
1495
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1496
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:68:8
1497
- |
1498
- 68 | import "./mocks/HighGasToken.sol";
1499
- | --------------------------
1500
- |
1501
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1502
-
1503
1415
  note[mixed-case-variable]: mutable variables should use mixedCase
1504
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:74:19
1416
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:81:20
1505
1417
  |
1506
- 74 | ParaID public bridgeHubParaID = ParaID.wrap(1013);
1507
- | ---------------
1418
+ 81 | bytes32 public assetHubAgentID =
1419
+ | ---------------
1508
1420
  |
1509
1421
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1510
1422
 
1423
+ note[mixed-case-function]: function names should use mixedCase
1424
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/BeefyClient.t.sol:167:14
1425
+ |
1426
+ 167 | function decodeMMRLeaf(string memory beefyCommitmentRaw) internal {
1427
+ | -------------
1428
+ |
1429
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1430
+
1511
1431
  note[mixed-case-variable]: mutable variables should use mixedCase
1512
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:76:20
1432
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:624:17
1433
+ |
1434
+ 624 | bytes32 ticketID,
1435
+ | --------
1436
+ |
1437
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1438
+
1439
+ note[mixed-case-variable]: mutable variables should use mixedCase
1440
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:85:20
1513
1441
  |
1514
- 76 | bytes32 public bridgeHubAgentID =
1515
- | ----------------
1442
+ 85 | bytes32 public dotTokenID;
1443
+ | ----------
1516
1444
  |
1517
1445
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1518
1446
 
1519
- note[mixed-case-variable]: mutable variables should use mixedCase
1520
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:80:19
1447
+ note[unused-import]: unused imports should be removed
1448
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:8:18
1449
+ |
1450
+ 8 | import {UD60x18, ud60x18, unwrap} from "prb/math/src/UD60x18.sol";
1451
+ | -------
1452
+ |
1453
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1454
+
1455
+ note[unused-import]: unused imports should be removed
1456
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:13:9
1521
1457
  |
1522
- 80 | ParaID public assetHubParaID = ParaID.wrap(1000);
1523
- | --------------
1458
+ 13 | import {Gateway} from "../src/Gateway.sol";
1459
+ | -------
1524
1460
  |
1525
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1461
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1526
1462
 
1527
- note[mixed-case-variable]: mutable variables should use mixedCase
1528
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:81:20
1463
+ note[unused-import]: unused imports should be removed
1464
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:16:24
1529
1465
  |
1530
- 81 | bytes32 public assetHubAgentID =
1531
- | ---------------
1466
+ 16 | import {UpgradeParams, SetOperatingModeParams, OperatingMode, RegisterForeignTokenParams} from "../src/v1/Types.sol";
1467
+ | ----------------------
1532
1468
  |
1533
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1469
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1534
1470
 
1535
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1536
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:98:20
1471
+ note[unused-import]: unused imports should be removed
1472
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:16:48
1537
1473
  |
1538
- 98 | uint8 constant NativeTokenERC20 = 0;
1539
- | ----------------
1474
+ 16 | import {UpgradeParams, SetOperatingModeParams, OperatingMode, RegisterForeignTokenParams} from "../src/v1/Types.sol";
1475
+ | -------------
1540
1476
  |
1541
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1477
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1542
1478
 
1543
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1544
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:99:20
1479
+ note[unused-import]: unused imports should be removed
1480
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:16:63
1545
1481
  |
1546
- 99 | uint8 constant ForeignTokenERC20 = 1;
1547
- | -----------------
1482
+ 16 | import {UpgradeParams, SetOperatingModeParams, OperatingMode, RegisterForeignTokenParams} from "../src/v1/Types.sol";
1483
+ | --------------------------
1548
1484
  |
1549
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1485
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1550
1486
 
1551
- note[pascal-case-struct]: structs should use PascalCase
1552
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:103:8
1553
- |
1554
- 103 | struct AsNativeTokenERC20 {
1555
- | ------------------
1556
- |
1557
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#pascal-case-struct
1487
+ note[unused-import]: unused imports should be removed
1488
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:17:28
1489
+ |
1490
+ 17 | import {ChannelID, ParaID, OperatingMode, InboundMessage, Command, TokenInfo} from "../src/v1/Types.sol";
1491
+ | -------------
1492
+ |
1493
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1558
1494
 
1559
- note[pascal-case-struct]: structs should use PascalCase
1560
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:109:8
1561
- |
1562
- 109 | struct AsForeignTokenERC20 {
1563
- | -------------------
1564
- |
1565
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#pascal-case-struct
1495
+ note[unused-import]: unused imports should be removed
1496
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:5:9
1497
+ |
1498
+ 5 | import {Strings} from "openzeppelin/utils/Strings.sol";
1499
+ | -------
1500
+ |
1501
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1566
1502
 
1567
- note[mixed-case-variable]: mutable variables should use mixedCase
1568
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:110:13
1569
- |
1570
- 110 | bytes32 foreignID;
1571
- | ---------
1572
- |
1573
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1503
+ note[unused-import]: unused imports should be removed
1504
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:6:9
1505
+ |
1506
+ 6 | import {console} from "forge-std/console.sol";
1507
+ | -------
1508
+ |
1509
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1574
1510
 
1575
1511
  note[unused-import]: unused imports should be removed
1576
1512
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:8:9
@@ -1620,128 +1556,104 @@ note[unused-import]: unused imports should be removed
1620
1556
  |
1621
1557
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1622
1558
 
1623
- note[unused-import]: unused imports should be removed
1624
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:23:9
1625
- |
1626
- 23 | import {SubstrateTypes} from "./../src/SubstrateTypes.sol";
1627
- | --------------
1628
- |
1629
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1630
-
1631
1559
  note[mixed-case-variable]: mutable variables should use mixedCase
1632
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:121:35
1560
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/BeefyClient.t.sol:171:16
1633
1561
  |
1634
- 121 | function makeForeignAsset(bytes32 foreignID, uint128 amount) pure returns (Asset memory) {
1635
- | ---------
1562
+ 171 | uint64 nextAuthoritySetID =
1563
+ | ------------------
1636
1564
  |
1637
1565
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1638
1566
 
1639
- note[mixed-case-function]: function names should use mixedCase
1640
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:590:14
1641
- |
1642
- 590 | function encodeMMRLeaf(MMRLeaf calldata leaf) internal pure returns (bytes memory) {
1643
- | -------------
1644
- |
1645
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1646
-
1647
- note[mixed-case-variable]: mutable variables should use mixedCase
1648
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:103:20
1649
- |
1650
- 103 | bytes32 public messageID = keccak256("cabbage");
1651
- | ---------
1652
- |
1653
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1567
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1568
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:28:20
1569
+ |
1570
+ 28 | uint8 constant Upgrade = 0;
1571
+ | -------
1572
+ |
1573
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1654
1574
 
1655
- note[mixed-case-variable]: mutable variables should use mixedCase
1656
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:120:20
1657
- |
1658
- 120 | bytes32 public dotTokenID;
1659
- | ----------
1660
- |
1661
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1662
-
1663
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1664
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/SparseBitmap.t.sol:4:8
1665
- |
1666
- 4 | import "forge-std/Test.sol";
1667
- | --------------------
1668
- |
1669
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1575
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1576
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:30:20
1577
+ |
1578
+ 30 | uint8 constant SetOperatingMode = 1;
1579
+ | ----------------
1580
+ |
1581
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1670
1582
 
1671
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1672
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/SparseBitmap.t.sol:5:8
1673
- |
1674
- 5 | import "forge-std/console.sol";
1675
- | -----------------------
1676
- |
1677
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1583
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1584
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:32:20
1585
+ |
1586
+ 32 | uint8 constant UnlockNativeToken = 2;
1587
+ | -----------------
1588
+ |
1589
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1678
1590
 
1679
- note[unused-import]: unused imports should be removed
1680
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:8:9
1681
- |
1682
- 8 | import {AgentExecutor} from "./AgentExecutor.sol";
1683
- | -------------
1684
- |
1685
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1591
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1592
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:34:20
1593
+ |
1594
+ 34 | uint8 constant RegisterForeignToken = 3;
1595
+ | --------------------
1596
+ |
1597
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1686
1598
 
1687
- note[unused-import]: unused imports should be removed
1688
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:29:9
1599
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1600
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:36:20
1689
1601
  |
1690
- 29 | import {Upgrade} from "./Upgrade.sol";
1691
- | -------
1602
+ 36 | uint8 constant MintForeignToken = 4;
1603
+ | ----------------
1692
1604
  |
1693
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1605
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1694
1606
 
1695
- note[unused-import]: unused imports should be removed
1696
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:41:9
1607
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1608
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:38:20
1697
1609
  |
1698
- 41 | import {PricingStorage} from "./storage/PricingStorage.sol";
1699
- | --------------
1610
+ 38 | uint8 constant CallContract = 5;
1611
+ | ------------
1700
1612
  |
1701
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1613
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1702
1614
 
1703
- note[unused-import]: unused imports should be removed
1704
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:44:18
1615
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1616
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:68:20
1705
1617
  |
1706
- 44 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1707
- | -------
1618
+ 68 | uint8 constant Raw = 0;
1619
+ | ---
1708
1620
  |
1709
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1621
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1710
1622
 
1711
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1712
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:4:8
1713
- |
1714
- 4 | import "forge-std/Test.sol";
1715
- | --------------------
1716
- |
1717
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1623
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1624
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:70:20
1625
+ |
1626
+ 70 | uint8 constant CreateAsset = 1;
1627
+ | -----------
1628
+ |
1629
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1718
1630
 
1719
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1720
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:5:8
1631
+ note[unused-import]: unused imports should be removed
1632
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/MMRProof.t.sol:5:9
1721
1633
  |
1722
- 5 | import "forge-std/console.sol";
1723
- | -----------------------
1634
+ 5 | import {console} from "forge-std/console.sol";
1635
+ | -------
1724
1636
  |
1725
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1637
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1726
1638
 
1727
1639
  note[mixed-case-variable]: mutable variables should use mixedCase
1728
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:139:16
1640
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:103:20
1729
1641
  |
1730
- 139 | ParaID paraID = ParaID.wrap(1000);
1731
- | ------
1642
+ 103 | bytes32 public messageID = keccak256("cabbage");
1643
+ | ---------
1732
1644
  |
1733
1645
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1734
1646
 
1735
1647
  note[unused-import]: unused imports should be removed
1736
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:44:27
1648
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:17:68
1737
1649
  |
1738
- 44 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1739
- | -------
1650
+ 17 | import {ChannelID, ParaID, OperatingMode, InboundMessage, Command, TokenInfo} from "../src/v1/Types.sol";
1651
+ | ---------
1740
1652
  |
1741
1653
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1742
1654
 
1743
1655
  note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1744
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ScaleCodec.t.sol:4:8
1656
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Math.t.sol:4:8
1745
1657
  |
1746
1658
  4 | import "forge-std/Test.sol";
1747
1659
  | --------------------
@@ -1749,84 +1661,20 @@ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." a
1749
1661
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1750
1662
 
1751
1663
  note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1752
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ScaleCodec.t.sol:5:8
1664
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Math.t.sol:5:8
1753
1665
  |
1754
1666
  5 | import "forge-std/console.sol";
1755
1667
  | -----------------------
1756
1668
  |
1757
1669
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1758
1670
 
1759
- note[mixed-case-variable]: mutable variables should use mixedCase
1760
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:624:17
1761
- |
1762
- 624 | bytes32 ticketID,
1763
- | --------
1764
- |
1765
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1766
-
1767
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
1768
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:63:9
1671
+ note[unused-import]: unused imports should be removed
1672
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:23:9
1769
1673
  |
1770
- 63 | token.transfer(receiver, transferAmount);
1771
- | ----------------------------------------
1674
+ 23 | import {SubstrateTypes} from "./../src/SubstrateTypes.sol";
1675
+ | --------------
1772
1676
  |
1773
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
1774
-
1775
- note[mixed-case-variable]: mutable variables should use mixedCase
1776
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:173:17
1777
- |
1778
- 173 | bytes32 agentID,
1779
- | -------
1780
- |
1781
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1782
-
1783
- note[mixed-case-variable]: mutable variables should use mixedCase
1784
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:187:17
1785
- |
1786
- 187 | bytes32 agentID,
1787
- | -------
1788
- |
1789
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1790
-
1791
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1792
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Verification.t.sol:4:8
1793
- |
1794
- 4 | import "openzeppelin/utils/Strings.sol";
1795
- | --------------------------------
1796
- |
1797
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1798
-
1799
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1800
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Uint16Array.t.sol:4:8
1801
- |
1802
- 4 | import "forge-std/Test.sol";
1803
- | --------------------
1804
- |
1805
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1806
-
1807
- note[mixed-case-variable]: mutable variables should use mixedCase
1808
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:605:16
1809
- |
1810
- 605 | ParaID paraID = ParaID.wrap(1000);
1811
- | ------
1812
- |
1813
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1814
-
1815
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
1816
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:102:9
1817
- |
1818
- 102 | token.transferFrom(owner, receiver, transferAmount);
1819
- | ---------------------------------------------------
1820
- |
1821
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
1822
-
1823
- note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1824
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Uint16Array.t.sol:5:8
1825
- |
1826
- 5 | import "forge-std/console.sol";
1827
- | -----------------------
1828
- |
1829
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1677
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1830
1678
 
1831
1679
  note[unused-import]: unused imports should be removed
1832
1680
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:24:24
@@ -1868,85 +1716,93 @@ note[unused-import]: unused imports should be removed
1868
1716
  |
1869
1717
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1870
1718
 
1871
- note[mixed-case-variable]: mutable variables should use mixedCase
1872
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:631:16
1873
- |
1874
- 631 | ParaID paraID = ParaID.wrap(1000);
1875
- | ------
1876
- |
1877
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1719
+ note[unused-import]: unused imports should be removed
1720
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:46:5
1721
+ |
1722
+ 46 | Xcm,
1723
+ | ---
1724
+ |
1725
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1878
1726
 
1879
1727
  note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1880
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Verification.t.sol:5:8
1728
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ScaleCodec.t.sol:4:8
1881
1729
  |
1882
- 5 | import "forge-std/Test.sol";
1730
+ 4 | import "forge-std/Test.sol";
1883
1731
  | --------------------
1884
1732
  |
1885
1733
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1886
1734
 
1887
1735
  note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1888
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Verification.t.sol:6:8
1736
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/ScaleCodec.t.sol:5:8
1889
1737
  |
1890
- 6 | import "forge-std/console.sol";
1738
+ 5 | import "forge-std/console.sol";
1891
1739
  | -----------------------
1892
1740
  |
1893
1741
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1894
1742
 
1895
- note[mixed-case-variable]: mutable variables should use mixedCase
1896
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Verification.t.sol:17:19
1743
+ note[mixed-case-function]: function names should use mixedCase
1744
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:81:10
1897
1745
  |
1898
- 17 | bytes4 public encodedParachainID;
1899
- | ------------------
1746
+ 81 | function makeRawXCM(bytes memory xcm) pure returns (Xcm memory) {
1747
+ | ----------
1900
1748
  |
1901
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1749
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
1902
1750
 
1903
- note[mixed-case-variable]: mutable variables should use mixedCase
1904
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:656:16
1905
- |
1906
- 656 | ParaID paraID = ParaID.wrap(1000);
1907
- | ------
1908
- |
1909
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1751
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1752
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Uint16Array.t.sol:4:8
1753
+ |
1754
+ 4 | import "forge-std/Test.sol";
1755
+ | --------------------
1756
+ |
1757
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1910
1758
 
1911
- note[mixed-case-variable]: mutable variables should use mixedCase
1912
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:674:16
1913
- |
1914
- 674 | ParaID paraID = ParaID.wrap(1000);
1915
- | ------
1916
- |
1917
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1759
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1760
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Uint16Array.t.sol:5:8
1761
+ |
1762
+ 5 | import "forge-std/console.sol";
1763
+ | -----------------------
1764
+ |
1765
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1918
1766
 
1919
- note[mixed-case-variable]: mutable variables should use mixedCase
1920
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Uint16Array.t.sol:98:16
1921
- |
1922
- 98 | uint16 new_value = counters.get(index);
1923
- | ---------
1767
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1768
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/SparseBitmap.t.sol:4:8
1769
+ |
1770
+ 4 | import "forge-std/Test.sol";
1771
+ | --------------------
1772
+ |
1773
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1774
+
1775
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1776
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/SparseBitmap.t.sol:5:8
1777
+ |
1778
+ 5 | import "forge-std/console.sol";
1779
+ | -----------------------
1780
+ |
1781
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1782
+
1783
+ note[unused-import]: unused imports should be removed
1784
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/BeefyClient.t.sol:11:9
1924
1785
  |
1925
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1786
+ 11 | import {ScaleCodec} from "../src/utils/ScaleCodec.sol";
1787
+ | ----------
1788
+ |
1789
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1926
1790
 
1927
1791
  note[mixed-case-variable]: mutable variables should use mixedCase
1928
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:159:13
1792
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:120:20
1929
1793
  |
1930
- 159 | bytes32 foreignTokenID;
1931
- | --------------
1794
+ 120 | bytes32 public dotTokenID;
1795
+ | ----------
1932
1796
  |
1933
1797
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1934
1798
 
1935
1799
  note[mixed-case-variable]: mutable variables should use mixedCase
1936
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:171:13
1937
- |
1938
- 171 | bytes32 foreignTokenID;
1939
- | --------------
1940
- |
1941
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1942
-
1943
- note[unused-import]: unused imports should be removed
1944
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:46:5
1800
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Uint16Array.t.sol:98:16
1945
1801
  |
1946
- 46 | Xcm,
1947
- | ---
1802
+ 98 | uint16 new_value = counters.get(index);
1803
+ | ---------
1948
1804
  |
1949
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1805
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
1950
1806
 
1951
1807
  note[unused-import]: unused imports should be removed
1952
1808
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:51:5
@@ -1980,54 +1836,38 @@ note[unused-import]: unused imports should be removed
1980
1836
  |
1981
1837
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1982
1838
 
1983
- note[unused-import]: unused imports should be removed
1984
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:59:9
1985
- |
1986
- 59 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1987
- | -------
1988
- |
1989
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1839
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1840
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:4:8
1841
+ |
1842
+ 4 | import "forge-std/Test.sol";
1843
+ | --------------------
1844
+ |
1845
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1990
1846
 
1991
- note[unused-import]: unused imports should be removed
1992
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:59:27
1993
- |
1994
- 59 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1995
- | -------
1996
- |
1997
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1847
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
1848
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:5:8
1849
+ |
1850
+ 5 | import "forge-std/console.sol";
1851
+ | -----------------------
1852
+ |
1853
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
1998
1854
 
1999
1855
  note[mixed-case-variable]: mutable variables should use mixedCase
2000
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:990:20
1856
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:173:17
2001
1857
  |
2002
- 990 | bytes32 public expectChannelIDBytes =
2003
- | --------------------
1858
+ 173 | bytes32 agentID,
1859
+ | -------
2004
1860
  |
2005
1861
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2006
1862
 
2007
1863
  note[mixed-case-variable]: mutable variables should use mixedCase
2008
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:994:16
1864
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:187:17
2009
1865
  |
2010
- 994 | ParaID para_id = ParaID.wrap(1000);
2011
- | -------
1866
+ 187 | bytes32 agentID,
1867
+ | -------
2012
1868
  |
2013
1869
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2014
1870
 
2015
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2016
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:140:9
2017
- |
2018
- 140 | token.transferFrom(owner, receiver, transferAmount);
2019
- | ---------------------------------------------------
2020
- |
2021
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2022
-
2023
- note[mixed-case-function]: function names should use mixedCase
2024
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:20:14
2025
- |
2026
- 20 | function v1_handleAgentExecute_public(bytes calldata params) external {
2027
- | ----------------------------
2028
- |
2029
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2030
-
2031
1871
  note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
2032
1872
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:6:8
2033
1873
  |
@@ -2036,149 +1876,141 @@ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." a
2036
1876
  |
2037
1877
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
2038
1878
 
2039
- note[unused-import]: unused imports should be removed
2040
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/ReantrantAttacker.sol:7:9
2041
- |
2042
- 7 | import {console} from "forge-std/console.sol";
2043
- | -------
2044
- |
2045
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2046
-
2047
- note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
2048
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:33:24
1879
+ note[mixed-case-function]: function names should use mixedCase
1880
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:24:14
2049
1881
  |
2050
- 33 | Vm public constant vm = Vm(0x7109709ECfa91a80626fF3989D68f67F5b1DD12D);
2051
- | --
1882
+ 24 | function encodeCommitment_public(Commitment calldata commitment)
1883
+ | -----------------------
2052
1884
  |
2053
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1885
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2054
1886
 
2055
1887
  note[mixed-case-function]: function names should use mixedCase
2056
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:24:14
1888
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:40:14
2057
1889
  |
2058
- 24 | function v1_handleUpgrade_public(bytes calldata params) external {
2059
- | -----------------------
1890
+ 40 | function initialize_public(
1891
+ | -----------------
2060
1892
  |
2061
1893
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2062
1894
 
2063
- note[mixed-case-variable]: mutable variables should use mixedCase
2064
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:995:19
2065
- |
2066
- 995 | ChannelID channel_id = para_id.into();
2067
- | ----------
2068
- |
2069
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2070
-
2071
1895
  note[unused-import]: unused imports should be removed
2072
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:4:9
2073
- |
2074
- 4 | import {Vm} from "forge-std/Vm.sol";
2075
- | --
2076
- |
2077
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1896
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:59:9
1897
+ |
1898
+ 59 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1899
+ | -------
1900
+ |
1901
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2078
1902
 
2079
1903
  note[unused-import]: unused imports should be removed
2080
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:6:9
2081
- |
2082
- 6 | import {stdJson} from "forge-std/StdJson.sol";
2083
- | -------
2084
- |
2085
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1904
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV2.t.sol:59:27
1905
+ |
1906
+ 59 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1907
+ | -------
1908
+ |
1909
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2086
1910
 
2087
1911
  note[unused-import]: unused imports should be removed
2088
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:7:9
2089
- |
2090
- 7 | import {console} from "forge-std/console.sol";
2091
- | -------
2092
- |
2093
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1912
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:14:9
1913
+ |
1914
+ 14 | import {AgentExecutor} from "../AgentExecutor.sol";
1915
+ | -------------
1916
+ |
1917
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2094
1918
 
2095
- note[unused-import]: unused imports should be removed
2096
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:8:18
2097
- |
2098
- 8 | import {UD60x18, ud60x18, unwrap} from "prb/math/src/UD60x18.sol";
2099
- | -------
2100
- |
2101
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1919
+ note[mixed-case-function]: function names should use mixedCase
1920
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:85:10
1921
+ |
1922
+ 85 | function makeCreateAssetXCM(address token, Network network) pure returns (Xcm memory) {
1923
+ | ------------------
1924
+ |
1925
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2102
1926
 
2103
- note[unused-import]: unused imports should be removed
2104
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:13:9
1927
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1928
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:98:20
2105
1929
  |
2106
- 13 | import {Gateway} from "../src/Gateway.sol";
2107
- | -------
1930
+ 98 | uint8 constant NativeTokenERC20 = 0;
1931
+ | ----------------
2108
1932
  |
2109
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1933
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
2110
1934
 
2111
- note[unused-import]: unused imports should be removed
2112
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:16:24
1935
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
1936
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:99:20
2113
1937
  |
2114
- 16 | import {UpgradeParams, SetOperatingModeParams, OperatingMode, RegisterForeignTokenParams} from "../src/v1/Types.sol";
2115
- | ----------------------
1938
+ 99 | uint8 constant ForeignTokenERC20 = 1;
1939
+ | -----------------
2116
1940
  |
2117
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1941
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
1942
+
1943
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
1944
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:63:9
1945
+ |
1946
+ 63 | token.transfer(receiver, transferAmount);
1947
+ | ----------------------------------------
1948
+ |
1949
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2118
1950
 
2119
1951
  note[unused-import]: unused imports should be removed
2120
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:16:48
1952
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:15:9
2121
1953
  |
2122
- 16 | import {UpgradeParams, SetOperatingModeParams, OperatingMode, RegisterForeignTokenParams} from "../src/v1/Types.sol";
2123
- | -------------
1954
+ 15 | import {Agent} from "../Agent.sol";
1955
+ | -----
2124
1956
  |
2125
1957
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2126
1958
 
2127
1959
  note[unused-import]: unused imports should be removed
2128
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:16:63
1960
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:16:9
2129
1961
  |
2130
- 16 | import {UpgradeParams, SetOperatingModeParams, OperatingMode, RegisterForeignTokenParams} from "../src/v1/Types.sol";
2131
- | --------------------------
1962
+ 16 | import {Call} from "../utils/Call.sol";
1963
+ | ----
2132
1964
  |
2133
1965
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2134
1966
 
2135
1967
  note[unused-import]: unused imports should be removed
2136
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:17:28
1968
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:25:5
2137
1969
  |
2138
- 17 | import {ChannelID, ParaID, OperatingMode, InboundMessage, Command, TokenInfo} from "../src/v1/Types.sol";
2139
- | -------------
1970
+ 25 | AgentExecuteCommand,
1971
+ | -------------------
2140
1972
  |
2141
1973
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2142
1974
 
2143
1975
  note[unused-import]: unused imports should be removed
2144
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/ForkUpgrade202509.t.sol:17:68
1976
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:31:18
2145
1977
  |
2146
- 17 | import {ChannelID, ParaID, OperatingMode, InboundMessage, Command, TokenInfo} from "../src/v1/Types.sol";
2147
- | ---------
1978
+ 31 | import {UD60x18, ud60x18, convert} from "prb/math/src/UD60x18.sol";
1979
+ | -------
2148
1980
  |
2149
1981
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2150
1982
 
2151
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2152
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:165:9
1983
+ note[unused-import]: unused imports should be removed
1984
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/ReantrantAttacker.sol:7:9
1985
+ |
1986
+ 7 | import {console} from "forge-std/console.sol";
1987
+ | -------
1988
+ |
1989
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
1990
+
1991
+ note[mixed-case-variable]: mutable variables should use mixedCase
1992
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:605:16
2153
1993
  |
2154
- 165 | token.transferFrom(owner, address(0), amount);
2155
- | ---------------------------------------------
1994
+ 605 | ParaID paraID = ParaID.wrap(1000);
1995
+ | ------
2156
1996
  |
2157
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
1997
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2158
1998
 
2159
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2160
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:196:9
2161
- |
2162
- 196 | token.transferFrom(owner, receiver, transferAmount);
2163
- | ---------------------------------------------------
2164
- |
2165
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2166
-
2167
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2168
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:205:9
2169
- |
2170
- 205 | token.transferFrom(owner, receiver, allowanceAmount);
2171
- | ----------------------------------------------------
2172
- |
2173
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
1999
+ note[mixed-case-function]: function names should use mixedCase
2000
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:20:14
2001
+ |
2002
+ 20 | function v1_handleAgentExecute_public(bytes calldata params) external {
2003
+ | ----------------------------
2004
+ |
2005
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2174
2006
 
2175
- note[mixed-case-variable]: mutable variables should use mixedCase
2176
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/VerificationWrapper.sol:8:16
2177
- |
2178
- 8 | bytes4 encodedParachainID,
2179
- | ------------------
2180
- |
2181
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2007
+ note[mixed-case-function]: function names should use mixedCase
2008
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:24:14
2009
+ |
2010
+ 24 | function v1_handleUpgrade_public(bytes calldata params) external {
2011
+ | -----------------------
2012
+ |
2013
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2182
2014
 
2183
2015
  note[mixed-case-function]: function names should use mixedCase
2184
2016
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:28:14
@@ -2189,45 +2021,69 @@ note[mixed-case-function]: function names should use mixedCase
2189
2021
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2190
2022
 
2191
2023
  note[mixed-case-function]: function names should use mixedCase
2192
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:24:14
2024
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:32:14
2193
2025
  |
2194
- 24 | function encodeCommitment_public(Commitment calldata commitment)
2195
- | -----------------------
2026
+ 32 | function v1_handleSetTokenTransferFees_public(bytes calldata params) external {
2027
+ | ------------------------------------
2196
2028
  |
2197
2029
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2198
2030
 
2199
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2200
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:1058:9
2201
- |
2202
- 1058 | token.transfer(address(assetHubAgent), 200);
2203
- | -------------------------------------------
2204
- |
2205
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2206
-
2207
2031
  note[mixed-case-variable]: mutable variables should use mixedCase
2208
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:132:15
2032
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:631:16
2209
2033
  |
2210
- 132 | bytes consensusEngineID;
2211
- | -----------------
2034
+ 631 | ParaID paraID = ParaID.wrap(1000);
2035
+ | ------
2212
2036
  |
2213
2037
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2214
2038
 
2215
2039
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2216
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:230:9
2040
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:102:9
2217
2041
  |
2218
- 230 | token.transferFrom(owner, receiver, allowanceAmount);
2219
- | ----------------------------------------------------
2042
+ 102 | token.transferFrom(owner, receiver, transferAmount);
2043
+ | ---------------------------------------------------
2220
2044
  |
2221
2045
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2222
2046
 
2223
2047
  note[mixed-case-function]: function names should use mixedCase
2224
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:32:14
2048
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:85:14
2225
2049
  |
2226
- 32 | function v1_handleSetTokenTransferFees_public(bytes calldata params) external {
2227
- | ------------------------------------
2050
+ 85 | function computeNumRequiredSignatures_public(
2051
+ | -----------------------------------
2228
2052
  |
2229
2053
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2230
2054
 
2055
+ note[mixed-case-function]: function names should use mixedCase
2056
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:93:14
2057
+ |
2058
+ 93 | function computeQuorum_public(uint256 numValidators) public pure returns (uint256) {
2059
+ | --------------------
2060
+ |
2061
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2062
+
2063
+ note[unused-import]: unused imports should be removed
2064
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:5:9
2065
+ |
2066
+ 5 | import {Uint16Array, createUint16Array} from "../../src/utils/Uint16Array.sol";
2067
+ | -----------
2068
+ |
2069
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2070
+
2071
+ note[mixed-case-variable]: mutable variables should use mixedCase
2072
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:656:16
2073
+ |
2074
+ 656 | ParaID paraID = ParaID.wrap(1000);
2075
+ | ------
2076
+ |
2077
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2078
+
2079
+ note[mixed-case-variable]: mutable variables should use mixedCase
2080
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:674:16
2081
+ |
2082
+ 674 | ParaID paraID = ParaID.wrap(1000);
2083
+ | ------
2084
+ |
2085
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2086
+
2231
2087
  note[mixed-case-function]: function names should use mixedCase
2232
2088
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:36:14
2233
2089
  |
@@ -2252,46 +2108,6 @@ note[mixed-case-function]: function names should use mixedCase
2252
2108
  |
2253
2109
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2254
2110
 
2255
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2256
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:1251:9
2257
- |
2258
- 1251 | token.transfer(address(assetHubAgent), 200);
2259
- | -------------------------------------------
2260
- |
2261
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2262
-
2263
- note[unused-import]: unused imports should be removed
2264
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:5:9
2265
- |
2266
- 5 | import {Test} from "forge-std/Test.sol";
2267
- | ----
2268
- |
2269
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2270
-
2271
- note[unused-import]: unused imports should be removed
2272
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:7:9
2273
- |
2274
- 7 | import {console} from "forge-std/console.sol";
2275
- | -------
2276
- |
2277
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2278
-
2279
- note[unused-import]: unused imports should be removed
2280
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:9:9
2281
- |
2282
- 9 | import {IUpgradable} from "../../src/interfaces/IUpgradable.sol";
2283
- | -----------
2284
- |
2285
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2286
-
2287
- note[mixed-case-function]: function names should use mixedCase
2288
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:40:14
2289
- |
2290
- 40 | function initialize_public(
2291
- | -----------------
2292
- |
2293
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2294
-
2295
2111
  note[mixed-case-function]: function names should use mixedCase
2296
2112
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:48:14
2297
2113
  |
@@ -2301,188 +2117,308 @@ note[mixed-case-function]: function names should use mixedCase
2301
2117
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2302
2118
 
2303
2119
  note[mixed-case-variable]: mutable variables should use mixedCase
2304
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:249:17
2305
- |
2306
- 249 | bytes32 PERMIT_TYPEHASH = keccak256(
2307
- | ---------------
2308
- |
2309
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2120
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:48:57
2121
+ |
2122
+ 48 | function v1_handleMintForeignToken_public(ChannelID channelID, bytes calldata params)
2123
+ | ---------
2124
+ |
2125
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2310
2126
 
2311
2127
  note[mixed-case-function]: function names should use mixedCase
2312
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:85:14
2128
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:58:14
2313
2129
  |
2314
- 85 | function computeNumRequiredSignatures_public(
2315
- | -----------------------------------
2130
+ 58 | function prank_registerNativeToken(address token) external {
2131
+ | -------------------------
2316
2132
  |
2317
2133
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2318
2134
 
2319
2135
  note[mixed-case-function]: function names should use mixedCase
2320
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:93:14
2136
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:62:14
2321
2137
  |
2322
- 93 | function computeQuorum_public(uint256 numValidators) public pure returns (uint256) {
2323
- | --------------------
2138
+ 62 | function prank_registerForeignToken(
2139
+ | --------------------------
2324
2140
  |
2325
2141
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2326
2142
 
2327
- note[unused-import]: unused imports should be removed
2328
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/BeefyClientMock.sol:5:9
2329
- |
2330
- 5 | import {Uint16Array, createUint16Array} from "../../src/utils/Uint16Array.sol";
2331
- | -----------
2332
- |
2333
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2334
-
2335
- note[unused-import]: unused imports should be removed
2336
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:12:5
2143
+ note[mixed-case-variable]: mutable variables should use mixedCase
2144
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:63:17
2337
2145
  |
2338
- 12 | UpgradeParams,
2339
- | -------------
2146
+ 63 | bytes32 foreignTokenID,
2147
+ | --------------
2340
2148
  |
2341
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2149
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2342
2150
 
2343
- note[unused-import]: unused imports should be removed
2344
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:13:5
2151
+ note[screaming-snake-case-const]: constants should use SCREAMING_SNAKE_CASE
2152
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:33:24
2345
2153
  |
2346
- 13 | SetOperatingModeParams,
2347
- | ----------------------
2154
+ 33 | Vm public constant vm = Vm(0x7109709ECfa91a80626fF3989D68f67F5b1DD12D);
2155
+ | --
2348
2156
  |
2349
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2157
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-const
2158
+
2159
+ note[mixed-case-variable]: mutable variables should use mixedCase
2160
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:990:20
2161
+ |
2162
+ 990 | bytes32 public expectChannelIDBytes =
2163
+ | --------------------
2164
+ |
2165
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2166
+
2167
+ note[mixed-case-variable]: mutable variables should use mixedCase
2168
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:994:16
2169
+ |
2170
+ 994 | ParaID para_id = ParaID.wrap(1000);
2171
+ | -------
2172
+ |
2173
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2350
2174
 
2351
2175
  note[unused-import]: unused imports should be removed
2352
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:14:5
2353
- |
2354
- 14 | OperatingMode,
2355
- | -------------
2356
- |
2357
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2176
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:7:20
2177
+ |
2178
+ 7 | import {ChannelID, ParaID, OperatingMode} from "../../src/Types.sol";
2179
+ | ------
2180
+ |
2181
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2358
2182
 
2359
2183
  note[unused-import]: unused imports should be removed
2360
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:15:5
2361
- |
2362
- 15 | RegisterForeignTokenParams,
2363
- | --------------------------
2364
- |
2365
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2184
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:7:28
2185
+ |
2186
+ 7 | import {ChannelID, ParaID, OperatingMode} from "../../src/Types.sol";
2187
+ | -------------
2188
+ |
2189
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2366
2190
 
2367
2191
  note[unused-import]: unused imports should be removed
2368
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:17:5
2369
- |
2370
- 17 | ParaID,
2371
- | ------
2372
- |
2373
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2192
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:9:9
2193
+ |
2194
+ 9 | import {CoreStorage} from "../../src/storage/CoreStorage.sol";
2195
+ | -----------
2196
+ |
2197
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2374
2198
 
2375
2199
  note[unused-import]: unused imports should be removed
2376
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:18:5
2200
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:11:9
2377
2201
  |
2378
- 18 | OperatingMode,
2379
- | -------------
2202
+ 11 | import {IInitializable} from "../../src/interfaces/IInitializable.sol";
2203
+ | --------------
2380
2204
  |
2381
2205
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2382
2206
 
2383
2207
  note[unused-import]: unused imports should be removed
2384
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:21:5
2208
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:13:9
2385
2209
  |
2386
- 21 | TokenInfo
2387
- | ---------
2210
+ 13 | import {UD60x18} from "prb/math/src/UD60x18.sol";
2211
+ | -------
2388
2212
  |
2389
2213
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2390
2214
 
2391
- note[mixed-case-variable]: mutable variables should use mixedCase
2392
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:48:57
2393
- |
2394
- 48 | function v1_handleMintForeignToken_public(ChannelID channelID, bytes calldata params)
2395
- | ---------
2396
- |
2397
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2215
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2216
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:140:9
2217
+ |
2218
+ 140 | token.transferFrom(owner, receiver, transferAmount);
2219
+ | ---------------------------------------------------
2220
+ |
2221
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2398
2222
 
2399
2223
  note[mixed-case-variable]: mutable variables should use mixedCase
2400
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:286:17
2224
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:995:19
2401
2225
  |
2402
- 286 | bytes32 PERMIT_TYPEHASH = keccak256(
2403
- | ---------------
2226
+ 995 | ChannelID channel_id = para_id.into();
2227
+ | ----------
2404
2228
  |
2405
2229
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2406
2230
 
2231
+ note[pascal-case-struct]: structs should use PascalCase
2232
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:103:8
2233
+ |
2234
+ 103 | struct AsNativeTokenERC20 {
2235
+ | ------------------
2236
+ |
2237
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#pascal-case-struct
2238
+
2239
+ note[pascal-case-struct]: structs should use PascalCase
2240
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:109:8
2241
+ |
2242
+ 109 | struct AsForeignTokenERC20 {
2243
+ | -------------------
2244
+ |
2245
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#pascal-case-struct
2246
+
2407
2247
  note[mixed-case-variable]: mutable variables should use mixedCase
2408
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:1283:16
2409
- |
2410
- 1283 | ParaID paraID = ParaID.wrap(1000);
2411
- | ------
2412
- |
2413
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2248
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:110:13
2249
+ |
2250
+ 110 | bytes32 foreignID;
2251
+ | ---------
2252
+ |
2253
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2414
2254
 
2415
2255
  note[mixed-case-variable]: mutable variables should use mixedCase
2416
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:317:17
2256
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:121:35
2417
2257
  |
2418
- 317 | bytes32 PERMIT_TYPEHASH = keccak256(
2419
- | ---------------
2258
+ 121 | function makeForeignAsset(bytes32 foreignID, uint128 amount) pure returns (Asset memory) {
2259
+ | ---------
2420
2260
  |
2421
2261
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2422
2262
 
2423
- note[mixed-case-function]: function names should use mixedCase
2424
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:58:14
2425
- |
2426
- 58 | function prank_registerNativeToken(address token) external {
2427
- | -------------------------
2428
- |
2429
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2263
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
2264
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Verification.t.sol:4:8
2265
+ |
2266
+ 4 | import "openzeppelin/utils/Strings.sol";
2267
+ | --------------------------------
2268
+ |
2269
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
2270
+
2271
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
2272
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Verification.t.sol:5:8
2273
+ |
2274
+ 5 | import "forge-std/Test.sol";
2275
+ | --------------------
2276
+ |
2277
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
2278
+
2279
+ note[unaliased-plain-import]: use named imports '{A, B}' or alias 'import ".." as X'
2280
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Verification.t.sol:6:8
2281
+ |
2282
+ 6 | import "forge-std/console.sol";
2283
+ | -----------------------
2284
+ |
2285
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unaliased-plain-import
2430
2286
 
2431
2287
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2432
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:503:9
2288
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:1058:9
2289
+ |
2290
+ 1058 | token.transfer(address(assetHubAgent), 200);
2291
+ | -------------------------------------------
2292
+ |
2293
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2294
+
2295
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2296
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:165:9
2433
2297
  |
2434
- 503 | token.transferFrom(owner, pool, swapAmount);
2435
- | -------------------------------------------
2298
+ 165 | token.transferFrom(owner, address(0), amount);
2299
+ | ---------------------------------------------
2436
2300
  |
2437
2301
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2438
2302
 
2303
+ note[mixed-case-variable]: mutable variables should use mixedCase
2304
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:159:13
2305
+ |
2306
+ 159 | bytes32 foreignTokenID;
2307
+ | --------------
2308
+ |
2309
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2310
+
2311
+ note[mixed-case-variable]: mutable variables should use mixedCase
2312
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v2/Types.sol:171:13
2313
+ |
2314
+ 171 | bytes32 foreignTokenID;
2315
+ | --------------
2316
+ |
2317
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2318
+
2439
2319
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2440
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:528:9
2320
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:196:9
2441
2321
  |
2442
- 528 | token.transferFrom(owner, pool, firstSwapAmount);
2443
- | ------------------------------------------------
2322
+ 196 | token.transferFrom(owner, receiver, transferAmount);
2323
+ | ---------------------------------------------------
2444
2324
  |
2445
2325
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2446
2326
 
2447
2327
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2448
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:533:9
2328
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:205:9
2449
2329
  |
2450
- 533 | token.transferFrom(owner, pool, secondSwapAmount);
2451
- | -------------------------------------------------
2330
+ 205 | token.transferFrom(owner, receiver, allowanceAmount);
2331
+ | ----------------------------------------------------
2452
2332
  |
2453
2333
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2454
2334
 
2335
+ note[mixed-case-variable]: mutable variables should use mixedCase
2336
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/VerificationWrapper.sol:8:16
2337
+ |
2338
+ 8 | bytes4 encodedParachainID,
2339
+ | ------------------
2340
+ |
2341
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2342
+
2455
2343
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2456
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:588:9
2344
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:1251:9
2345
+ |
2346
+ 1251 | token.transfer(address(assetHubAgent), 200);
2347
+ | -------------------------------------------
2348
+ |
2349
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2350
+
2351
+ note[mixed-case-variable]: mutable variables should use mixedCase
2352
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Verification.t.sol:17:19
2353
+ |
2354
+ 17 | bytes4 public encodedParachainID;
2355
+ | ------------------
2356
+ |
2357
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2358
+
2359
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2360
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:230:9
2457
2361
  |
2458
- 588 | token.transferFrom(userAddress, pool, permitAmount);
2459
- | ---------------------------------------------------
2362
+ 230 | token.transferFrom(owner, receiver, allowanceAmount);
2363
+ | ----------------------------------------------------
2460
2364
  |
2461
2365
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2462
2366
 
2463
2367
  note[mixed-case-variable]: mutable variables should use mixedCase
2464
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:558:17
2368
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:249:17
2465
2369
  |
2466
- 558 | bytes32 PERMIT_TYPEHASH = keccak256(
2370
+ 249 | bytes32 PERMIT_TYPEHASH = keccak256(
2467
2371
  | ---------------
2468
2372
  |
2469
2373
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2470
2374
 
2471
2375
  note[mixed-case-variable]: mutable variables should use mixedCase
2472
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:573:17
2376
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:132:15
2473
2377
  |
2474
- 573 | bytes32 DOMAIN_SEPARATOR = token.DOMAIN_SEPARATOR();
2475
- | ----------------
2378
+ 132 | bytes consensusEngineID;
2379
+ | -----------------
2476
2380
  |
2477
2381
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2478
2382
 
2479
- warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2480
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:619:13
2383
+ note[mixed-case-variable]: mutable variables should use mixedCase
2384
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:286:17
2481
2385
  |
2482
- 619 | token.transferFrom(owner, recipients[i], transferAmount);
2483
- | --------------------------------------------------------
2386
+ 286 | bytes32 PERMIT_TYPEHASH = keccak256(
2387
+ | ---------------
2484
2388
  |
2485
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2389
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2390
+
2391
+ note[mixed-case-variable]: mutable variables should use mixedCase
2392
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:1283:16
2393
+ |
2394
+ 1283 | ParaID paraID = ParaID.wrap(1000);
2395
+ | ------
2396
+ |
2397
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2398
+
2399
+ note[mixed-case-variable]: mutable variables should use mixedCase
2400
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:317:17
2401
+ |
2402
+ 317 | bytes32 PERMIT_TYPEHASH = keccak256(
2403
+ | ---------------
2404
+ |
2405
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2406
+
2407
+ note[unused-import]: unused imports should be removed
2408
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:5:9
2409
+ |
2410
+ 5 | import {Test} from "forge-std/Test.sol";
2411
+ | ----
2412
+ |
2413
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2414
+
2415
+ note[unused-import]: unused imports should be removed
2416
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:7:9
2417
+ |
2418
+ 7 | import {console} from "forge-std/console.sol";
2419
+ | -------
2420
+ |
2421
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2486
2422
 
2487
2423
  note[unused-import]: unused imports should be removed
2488
2424
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:5:9
@@ -2500,6 +2436,70 @@ note[unused-import]: unused imports should be removed
2500
2436
  |
2501
2437
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2502
2438
 
2439
+ note[unused-import]: unused imports should be removed
2440
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:9:9
2441
+ |
2442
+ 9 | import {IUpgradable} from "../../src/interfaces/IUpgradable.sol";
2443
+ | -----------
2444
+ |
2445
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2446
+
2447
+ note[unused-import]: unused imports should be removed
2448
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:12:5
2449
+ |
2450
+ 12 | UpgradeParams,
2451
+ | -------------
2452
+ |
2453
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2454
+
2455
+ note[unused-import]: unused imports should be removed
2456
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:13:5
2457
+ |
2458
+ 13 | SetOperatingModeParams,
2459
+ | ----------------------
2460
+ |
2461
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2462
+
2463
+ note[unused-import]: unused imports should be removed
2464
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:14:5
2465
+ |
2466
+ 14 | OperatingMode,
2467
+ | -------------
2468
+ |
2469
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2470
+
2471
+ note[unused-import]: unused imports should be removed
2472
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:15:5
2473
+ |
2474
+ 15 | RegisterForeignTokenParams,
2475
+ | --------------------------
2476
+ |
2477
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2478
+
2479
+ note[unused-import]: unused imports should be removed
2480
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:17:5
2481
+ |
2482
+ 17 | ParaID,
2483
+ | ------
2484
+ |
2485
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2486
+
2487
+ note[unused-import]: unused imports should be removed
2488
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:18:5
2489
+ |
2490
+ 18 | OperatingMode,
2491
+ | -------------
2492
+ |
2493
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2494
+
2495
+ note[unused-import]: unused imports should be removed
2496
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/utils/ForkTestFixtures.sol:21:5
2497
+ |
2498
+ 21 | TokenInfo
2499
+ | ---------
2500
+ |
2501
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2502
+
2503
2503
  note[unused-import]: unused imports should be removed
2504
2504
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/GatewayV1.t.sol:8:9
2505
2505
  |
@@ -2565,76 +2565,76 @@ note[unused-import]: unused imports should be removed
2565
2565
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2566
2566
 
2567
2567
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2568
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:649:9
2568
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:503:9
2569
2569
  |
2570
- 649 | token.transferFrom(owner, pool, firstAmount);
2571
- | --------------------------------------------
2570
+ 503 | token.transferFrom(owner, pool, swapAmount);
2571
+ | -------------------------------------------
2572
2572
  |
2573
2573
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2574
2574
 
2575
- note[mixed-case-function]: function names should use mixedCase
2576
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:62:14
2577
- |
2578
- 62 | function prank_registerForeignToken(
2579
- | --------------------------
2580
- |
2581
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
2575
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2576
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:528:9
2577
+ |
2578
+ 528 | token.transferFrom(owner, pool, firstSwapAmount);
2579
+ | ------------------------------------------------
2580
+ |
2581
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2582
2582
 
2583
- note[mixed-case-variable]: mutable variables should use mixedCase
2584
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:63:17
2585
- |
2586
- 63 | bytes32 foreignTokenID,
2587
- | --------------
2588
- |
2589
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2583
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2584
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:533:9
2585
+ |
2586
+ 533 | token.transferFrom(owner, pool, secondSwapAmount);
2587
+ | -------------------------------------------------
2588
+ |
2589
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2590
2590
 
2591
2591
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2592
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:658:9
2592
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:588:9
2593
2593
  |
2594
- 658 | token.transferFrom(owner, pool, secondAmount);
2595
- | ---------------------------------------------
2594
+ 588 | token.transferFrom(userAddress, pool, permitAmount);
2595
+ | ---------------------------------------------------
2596
2596
  |
2597
2597
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2598
2598
 
2599
- note[unused-import]: unused imports should be removed
2600
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:7:20
2601
- |
2602
- 7 | import {ChannelID, ParaID, OperatingMode} from "../../src/Types.sol";
2603
- | ------
2604
- |
2605
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2599
+ note[mixed-case-variable]: mutable variables should use mixedCase
2600
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:558:17
2601
+ |
2602
+ 558 | bytes32 PERMIT_TYPEHASH = keccak256(
2603
+ | ---------------
2604
+ |
2605
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2606
2606
 
2607
- note[unused-import]: unused imports should be removed
2608
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:7:28
2609
- |
2610
- 7 | import {ChannelID, ParaID, OperatingMode} from "../../src/Types.sol";
2611
- | -------------
2612
- |
2613
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2607
+ note[mixed-case-variable]: mutable variables should use mixedCase
2608
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:573:17
2609
+ |
2610
+ 573 | bytes32 DOMAIN_SEPARATOR = token.DOMAIN_SEPARATOR();
2611
+ | ----------------
2612
+ |
2613
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
2614
2614
 
2615
- note[unused-import]: unused imports should be removed
2616
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:9:9
2617
- |
2618
- 9 | import {CoreStorage} from "../../src/storage/CoreStorage.sol";
2619
- | -----------
2620
- |
2621
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2615
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2616
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:619:13
2617
+ |
2618
+ 619 | token.transferFrom(owner, recipients[i], transferAmount);
2619
+ | --------------------------------------------------------
2620
+ |
2621
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2622
2622
 
2623
- note[unused-import]: unused imports should be removed
2624
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:11:9
2625
- |
2626
- 11 | import {IInitializable} from "../../src/interfaces/IInitializable.sol";
2627
- | --------------
2628
- |
2629
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2623
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2624
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:649:9
2625
+ |
2626
+ 649 | token.transferFrom(owner, pool, firstAmount);
2627
+ | --------------------------------------------
2628
+ |
2629
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2630
2630
 
2631
- note[unused-import]: unused imports should be removed
2632
- --> /home/runner/work/snowbridge/snowbridge/contracts/test/mocks/MockGateway.sol:13:9
2633
- |
2634
- 13 | import {UD60x18} from "prb/math/src/UD60x18.sol";
2635
- | -------
2636
- |
2637
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#unused-import
2631
+ warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2632
+ --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:658:9
2633
+ |
2634
+ 658 | token.transferFrom(owner, pool, secondAmount);
2635
+ | ---------------------------------------------
2636
+ |
2637
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#erc20-unchecked-transfer
2638
2638
 
2639
2639
  warning[erc20-unchecked-transfer]: ERC20 'transfer' and 'transferFrom' calls should check the return value
2640
2640
  --> /home/runner/work/snowbridge/snowbridge/contracts/test/Token.t.sol:705:9
@@ -2676,6 +2676,32 @@ note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline
2676
2676
  |
2677
2677
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2678
2678
 
2679
+ note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2680
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/TokenLib.sol:76:26
2681
+ |
2682
+ 76 | bytes32 digest = keccak256(
2683
+ | __________________________-
2684
+ 77 | | abi.encodePacked(
2685
+ ... |
2686
+ 85 | | )
2687
+ 86 | | );
2688
+ | |_________-
2689
+ |
2690
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2691
+
2692
+ note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2693
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/TokenLib.sol:99:16
2694
+ |
2695
+ 99 | return keccak256(
2696
+ | ________________-
2697
+ 100 | | abi.encode(
2698
+ ... |
2699
+ 106 | | )
2700
+ 107 | | );
2701
+ | |_________-
2702
+ |
2703
+ = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2704
+
2679
2705
  note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2680
2706
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:283:34
2681
2707
  |
@@ -2693,29 +2719,21 @@ note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline
2693
2719
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2694
2720
 
2695
2721
  note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2696
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:158:28
2722
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:242:29
2697
2723
  |
2698
- 158 | bytes32 leafHash = keccak256(abi.encode(message));
2699
- | ------------------------------
2724
+ 242 | bytes32 messageID = keccak256(abi.encodePacked(channelID, channel.outboundNonce));
2725
+ | -------------------------------------------------------------
2700
2726
  |
2701
2727
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2702
2728
 
2703
2729
  note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2704
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:422:28
2730
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:158:28
2705
2731
  |
2706
- 422 | bytes32 leafHash = keccak256(abi.encode(message));
2732
+ 158 | bytes32 leafHash = keccak256(abi.encode(message));
2707
2733
  | ------------------------------
2708
2734
  |
2709
2735
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2710
2736
 
2711
- note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2712
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:257:16
2713
- |
2714
- 257 | return keccak256(encodedLeaf);
2715
- | ----------------------
2716
- |
2717
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2718
-
2719
2737
  note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2720
2738
  --> /home/runner/work/snowbridge/snowbridge/contracts/src/BeefyClient.sol:616:30
2721
2739
  |
@@ -2725,36 +2743,18 @@ note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline
2725
2743
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2726
2744
 
2727
2745
  note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2728
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/TokenLib.sol:76:26
2729
- |
2730
- 76 | bytes32 digest = keccak256(
2731
- | __________________________-
2732
- 77 | | abi.encodePacked(
2733
- ... |
2734
- 85 | | )
2735
- 86 | | );
2736
- | |_________-
2737
- |
2738
- = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2739
-
2740
- note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2741
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/TokenLib.sol:99:16
2746
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Gateway.sol:422:28
2742
2747
  |
2743
- 99 | return keccak256(
2744
- | ________________-
2745
- 100 | | abi.encode(
2746
- ... |
2747
- 106 | | )
2748
- 107 | | );
2749
- | |_________-
2748
+ 422 | bytes32 leafHash = keccak256(abi.encode(message));
2749
+ | ------------------------------
2750
2750
  |
2751
2751
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2752
2752
 
2753
2753
  note[asm-keccak256]: use of inefficient hashing mechanism; consider using inline assembly
2754
- --> /home/runner/work/snowbridge/snowbridge/contracts/src/v1/Calls.sol:242:29
2754
+ --> /home/runner/work/snowbridge/snowbridge/contracts/src/Verification.sol:257:16
2755
2755
  |
2756
- 242 | bytes32 messageID = keccak256(abi.encodePacked(channelID, channel.outboundNonce));
2757
- | -------------------------------------------------------------
2756
+ 257 | return keccak256(encodedLeaf);
2757
+ | ----------------------
2758
2758
  |
2759
2759
  = help: https://book.getfoundry.sh/reference/forge/forge-lint#asm-keccak256
2760
2760