@snacky/ui 0.3.4 → 0.3.5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +7 -1
- package/README.md +11 -7
- package/package.json +1 -1
package/CHANGELOG.md
CHANGED
|
@@ -61,7 +61,13 @@ where `components.json`'s prose spec disagrees with it.
|
|
|
61
61
|
`List` and `Header` were additionally cross-checked directly against their
|
|
62
62
|
Figma component sets, and both agreed with the verified implementation.
|
|
63
63
|
|
|
64
|
-
`BottomSheet` and `Section`
|
|
64
|
+
`BottomSheet` and `Section` were checked later, while porting them to the
|
|
65
|
+
Compose package, and both turned up real bugs: `BottomSheet` defaulted to
|
|
66
|
+
showing a drag handle that none of the nine documented Figma variants actually
|
|
67
|
+
have (the prop was inverted to `showHandle`, defaulting to `false`), and
|
|
68
|
+
`Section`'s "see more" chevron was using the wrong color. That check also
|
|
69
|
+
established that their spacing is variant-dependent by design rather than
|
|
70
|
+
unverified - see the README's Verification status.
|
|
65
71
|
|
|
66
72
|
## Other fixes worth recording
|
|
67
73
|
|
package/README.md
CHANGED
|
@@ -62,8 +62,8 @@ Illustration, ProductImage, ProductCard.
|
|
|
62
62
|
Every component is diffed against `index.html`'s own Live Preview
|
|
63
63
|
implementation - the code that actually renders the documentation site - not
|
|
64
64
|
just the spec values in `components.json`. Where the two disagree, the
|
|
65
|
-
verified implementation wins. `List` and `
|
|
66
|
-
against their Figma component sets directly.
|
|
65
|
+
verified implementation wins. `List`, `Header`, `BottomSheet` and `Section`
|
|
66
|
+
were additionally checked against their Figma component sets directly.
|
|
67
67
|
|
|
68
68
|
Three things worth knowing before you rely on them:
|
|
69
69
|
|
|
@@ -73,9 +73,13 @@ Three things worth knowing before you rely on them:
|
|
|
73
73
|
a deliberate deviation rather than a mismatch.
|
|
74
74
|
- **`List`'s 56x56 thumbnail frame uses a literal `#f4f4f5`**, not a token -
|
|
75
75
|
it is a distinct value with no equivalent in the generated surface colors.
|
|
76
|
-
- **`BottomSheet` and `Section
|
|
77
|
-
|
|
78
|
-
|
|
76
|
+
- **`BottomSheet` and `Section` spacing is variant-dependent by design.** Both
|
|
77
|
+
shells have since been checked against Figma, and the finding was that no
|
|
78
|
+
single shell default reproduces every variant: BottomSheet's block gap is
|
|
79
|
+
32px on Welcome, 24px on Calendar and 16px elsewhere, and Section's "Variant"
|
|
80
|
+
layout has no horizontal shell padding at all, with its header owning the
|
|
81
|
+
24px instead. The shells ship sensible defaults and expect `children` to
|
|
82
|
+
override the spacing where a specific composition needs to.
|
|
79
83
|
|
|
80
84
|
See [CHANGELOG.md](https://github.com/rezatresnas/snacky-design-system/blob/main/packages/react-ui/CHANGELOG.md)
|
|
81
85
|
for how the package got here, including the mistakes.
|
|
@@ -140,8 +144,8 @@ what is already in the bundle.
|
|
|
140
144
|
Section "variants", but each is really the *same* shell component
|
|
141
145
|
(`BottomSheet` / `Section`) with different `children` - so that's what's
|
|
142
146
|
exported, matching every `code.tsx` sample exactly, rather than 22 near-
|
|
143
|
-
duplicate components. (See Verification status above
|
|
144
|
-
|
|
147
|
+
duplicate components. (See Verification status above on why their spacing is
|
|
148
|
+
variant-dependent.)
|
|
145
149
|
|
|
146
150
|
## Keeping this in sync
|
|
147
151
|
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@snacky/ui",
|
|
3
|
-
"version": "0.3.
|
|
3
|
+
"version": "0.3.5",
|
|
4
4
|
"description": "Snacky App design system - React component library. Generated from the source-of-truth design system at ../../index.html (tokens.json / components.json), pixel-accurate to Figma.",
|
|
5
5
|
"license": "MIT",
|
|
6
6
|
"author": "rezatresnas",
|