@smthrs/control 1.0.0-rc.3 → 1.0.0-rc.4

package/docs/guides/postgres-tests.md

@@ -3,3 +3,5 @@
 The default unit suite needs no PostgreSQL server. Set `SMITHERS_TEST_PG_URL` to run `test/SqlControlRuntimePostgres.test.ts` against a dedicated test database.
 
 `//packages/smithers/control:postgresInventory` runs the same assertions on Linux with the `adapterPostgresDatabase` service and loopback networking. It checks filtered inventory pagination, duplicate and absent IDs, empty filters, large ID sets, and time boundaries.
+
+The package `test` target runs the suite twice, on SQLite and on a real PostgreSQL server, and merges the coverage before it checks the 100% floors. The PostgreSQL pass runs this file, so the PostgreSQL-only inventory filter counts toward coverage. Run the same matrix from the package directory with `pnpm run test:matrix`.

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@smthrs/control",
   "type": "module",
-  "version": "1.0.0-rc.3",
+  "version": "1.0.0-rc.4",
   "license": "MIT",
   "smthrs": {
     "group": "agent"
@@ -356,27 +356,27 @@
     "tag": "next"
   },
   "dependencies": {
-    "@smthrs/model": "1.0.0-rc.3",
-    "@smthrs/canonical": "1.0.0-rc.3",
-    "@smthrs/crypto": "1.0.0-rc.3",
-    "@smthrs/database": "1.0.0-rc.3",
-    "@smthrs/journal": "1.0.0-rc.3",
-    "@smthrs/notifications": "1.0.0-rc.3",
-    "@smthrs/plan": "1.0.0-rc.3",
-    "@smthrs/registry": "1.0.0-rc.3",
-    "@smthrs/run-store": "1.0.0-rc.3",
-    "@smthrs/flow": "1.0.0-rc.3"
+    "@smthrs/model": "1.0.0-rc.4",
+    "@smthrs/canonical": "1.0.0-rc.4",
+    "@smthrs/crypto": "1.0.0-rc.4",
+    "@smthrs/database": "1.0.0-rc.4",
+    "@smthrs/journal": "1.0.0-rc.4",
+    "@smthrs/notifications": "1.0.0-rc.4",
+    "@smthrs/plan": "1.0.0-rc.4",
+    "@smthrs/registry": "1.0.0-rc.4",
+    "@smthrs/run-store": "1.0.0-rc.4",
+    "@smthrs/flow": "1.0.0-rc.4"
   },
   "devDependencies": {
     "@effect/language-service": "0.87.2",
     "@effect/vitest": "4.0.0-rc.115",
     "@eslint/js": "9.39.5",
-    "@smthrs/core": "1.0.0-rc.3",
-    "@smthrs/engine-store": "1.0.0-rc.3",
-    "@smthrs/jj": "1.0.0-rc.3",
-    "@smthrs/plan-store": "1.0.0-rc.3",
-    "@smthrs/step-cache": "1.0.0-rc.3",
-    "@smthrs/time-travel": "1.0.0-rc.3",
+    "@smthrs/core": "1.0.0-rc.4",
+    "@smthrs/engine-store": "1.0.0-rc.4",
+    "@smthrs/jj": "1.0.0-rc.4",
+    "@smthrs/plan-store": "1.0.0-rc.4",
+    "@smthrs/step-cache": "1.0.0-rc.4",
+    "@smthrs/time-travel": "1.0.0-rc.4",
     "@types/node": "26.4.1",
     "@vitest/coverage-v8": "5.0.0",
     "dprint": "0.57.1",

package/src/ControlLive.ts

@@ -207,7 +207,11 @@ const AttributedResumeInput = Schema.Struct({
   principal: Schema.optional(Principal)
 })
 const AttributedRunInput = Schema.Union([
-  Schema.Struct({ ...RunInputSchema.members[0].fields, principal: Schema.optional(Principal), reservedRunId: Schema.optional(Schema.NonEmptyString) }),
+  Schema.Struct({
+    ...RunInputSchema.members[0].fields,
+    principal: Schema.optional(Principal),
+    reservedRunId: Schema.optional(Schema.NonEmptyString)
+  }),
   Schema.Struct({ ...RunInputSchema.members[1].fields, principal: Schema.optional(Principal) })
 ])
 const AttributedSignalInput = Schema.Struct({
@@ -995,12 +999,16 @@ export const layer: Layer.Layer<
         // A detached live host keeps its fence. Delegate the admitted event
         // wake to it, just as a node decision does, instead of leaving an idle
         // retained module with input it will never get a boundary to drain.
-        Effect.catchTag("/control/ClaimLost", (refusal) => refusal.parkedBy === undefined ? Effect.void : Effect.gen(function*() {
-          const delegated = yield* runtime.requestResume(run.runId).pipe(
-            Effect.catchTag("/control/InvalidInput", () => Effect.succeed(undefined))
-          )
-          if (delegated !== undefined) yield* emit(run.runId, "control.run.resumed", { runId: run.runId })
-        })),
+        Effect.catchTag(
+          "/control/ClaimLost",
+          (refusal) =>
+            refusal.parkedBy === undefined ? Effect.void : Effect.gen(function*() {
+              const delegated = yield* runtime.requestResume(run.runId).pipe(
+                Effect.catchTag("/control/InvalidInput", () => Effect.succeed(undefined))
+              )
+              if (delegated !== undefined) yield* emit(run.runId, "control.run.resumed", { runId: run.runId })
+            })
+        ),
         Effect.catchTag("/control/RunNotFound", () => Effect.void),
         Effect.catchTag(
           "/control/CodeDrift",
@@ -1763,7 +1771,13 @@ export const layer: Layer.Layer<
             principal,
             fingerprint("run", principal, input),
             Effect.gen(function*() {
-              const launched = yield* runtime.launch(input.planId, input.digest, input.envelope, principal, input.reservedRunId)
+              const launched = yield* runtime.launch(
+                input.planId,
+                input.digest,
+                input.envelope,
+                principal,
+                input.reservedRunId
+              )
               if (launched._tag === "Parked") {
                 return { ...launched.receipt, receiptId: input.idempotencyKey }
               }

package/src/ControlRuntime.ts

@@ -1182,73 +1182,77 @@ export const layerMemory = (options: MemoryOptions = {}): Layer.Layer<ControlRun
             }
           }
         ),
-        launch: Effect.fn("ControlRuntime.launch")(function*(planId, requestedDigest, envelope, principal, reservedRunId) {
-          const plan = yield* Effect.fromOption(
-            Option.fromNullishOr(plans.get(planId)),
-            () => new PlanNotFound({ planId })
-          )
-          if (plan.card.digest !== requestedDigest) {
-            return yield* new PlanDigestMismatch({
-              planId,
-              expected: plan.card.digest,
-              actual: requestedDigest
-            })
-          }
-          if (!sameEnvelope(plan.card.envelope, envelope)) {
-            return yield* new EnvelopeMismatch({
+        launch: Effect.fn("ControlRuntime.launch")(
+          function*(planId, requestedDigest, envelope, principal, reservedRunId) {
+            const plan = yield* Effect.fromOption(
+              Option.fromNullishOr(plans.get(planId)),
+              () => new PlanNotFound({ planId })
+            )
+            if (plan.card.digest !== requestedDigest) {
+              return yield* new PlanDigestMismatch({
+                planId,
+                expected: plan.card.digest,
+                actual: requestedDigest
+              })
+            }
+            if (!sameEnvelope(plan.card.envelope, envelope)) {
+              return yield* new EnvelopeMismatch({
+                planId,
+                expected: canonical(plan.card.envelope),
+                actual: canonical(envelope)
+              })
+            }
+            if (plan.decision === "pending") {
+              return {
+                _tag: "Parked",
+                receipt: {
+                  _tag: "Parked",
+                  receiptId: `launch:${planId}`,
+                  planId,
+                  status: "waiting-approval"
+                }
+              }
+            }
+            if (plan.decision !== "approved") {
+              return yield* new PlanDenied({ planId })
+            }
+            const sequence = ++runSequence
+            const runId = reservedRunId ?? `run-${sequence}`
+            if (runs.has(runId)) {
+              return yield* new PersistenceError({ operation: "reserve a run", message: "Run identity already exists" })
+            }
+            const fence = `fence-${++fenceSequence}`
+            const timestamp = now()
+            const summary: RunSummary = {
+              runId,
+              flowId: plan.card.flowId,
+              status: "accepted",
               planId,
-              expected: canonical(plan.card.envelope),
-              actual: canonical(envelope)
+              planDigest: plan.card.digest,
+              ...(plan.card.executionDigest === undefined ? {} : { executionDigest: plan.card.executionDigest }),
+              ...(options.engineVersion === undefined ? {} : { engineVersion: options.engineVersion }),
+              ownerId: "memory-owner",
+              ...(principal === undefined ? {} : { launchedBy: { id: principal.id, kind: principal.kind } }),
+              ...(plan.card.envelope.budget.deadline === undefined
+                ? {}
+                : { deadlineAt: timestamp + plan.card.envelope.budget.deadline }),
+              createdAt: timestamp,
+              updatedAt: timestamp
+            }
+            runs.set(runId, {
+              summary: snapshot(summary),
+              fence,
+              localFence: fence,
+              sequence: runSequence,
+              signals: []
             })
-          }
-          if (plan.decision === "pending") {
             return {
-              _tag: "Parked",
-              receipt: {
-                _tag: "Parked",
-                receiptId: `launch:${planId}`,
-                planId,
-                status: "waiting-approval"
-              }
+              _tag: "Started",
+              receipt: accepted(`launch:${planId}:${runId}`, runId),
+              run: snapshot(summary)
             }
           }
-          if (plan.decision !== "approved") {
-            return yield* new PlanDenied({ planId })
-          }
-          const sequence = ++runSequence
-          const runId = reservedRunId ?? `run-${sequence}`
-          if (runs.has(runId)) return yield* new PersistenceError({ operation: "reserve a run", message: "Run identity already exists" })
-          const fence = `fence-${++fenceSequence}`
-          const timestamp = now()
-          const summary: RunSummary = {
-            runId,
-            flowId: plan.card.flowId,
-            status: "accepted",
-            planId,
-            planDigest: plan.card.digest,
-            ...(plan.card.executionDigest === undefined ? {} : { executionDigest: plan.card.executionDigest }),
-            ...(options.engineVersion === undefined ? {} : { engineVersion: options.engineVersion }),
-            ownerId: "memory-owner",
-            ...(principal === undefined ? {} : { launchedBy: { id: principal.id, kind: principal.kind } }),
-            ...(plan.card.envelope.budget.deadline === undefined
-              ? {}
-              : { deadlineAt: timestamp + plan.card.envelope.budget.deadline }),
-            createdAt: timestamp,
-            updatedAt: timestamp
-          }
-          runs.set(runId, {
-            summary: snapshot(summary),
-            fence,
-            localFence: fence,
-            sequence: runSequence,
-            signals: []
-          })
-          return {
-            _tag: "Started",
-            receipt: accepted(`launch:${planId}:${runId}`, runId),
-            run: snapshot(summary)
-          }
-        }),
+        ),
         getRun: Effect.fn("ControlRuntime.getRun")((runId) =>
           Effect.map(requireRun(runId), (run) => snapshot(run.summary))
         ),

package/src/SqlControlRuntime.ts

@@ -692,7 +692,10 @@ const makeRuntime = (
           // so the walk stops at one rather than telling a reader that a run
           // which can proceed cannot.
           ...(pendingWaits === undefined ? {} : { pendingWaits }),
-          ...(pendingWaits === undefined || !pendingWaits.some((wait) => wait.reason === ControlExecutor.humanWaitReason) || terminal(base.status)
+          ...(pendingWaits === undefined || !pendingWaits.some((wait) =>
+              wait.reason === ControlExecutor.humanWaitReason
+            ) ||
+              terminal(base.status)
             ? {}
             : { status: "waiting-approval" as const }),
           ...(pendingResume === undefined ? {} : { pendingResume }),
@@ -1393,7 +1396,6 @@ const makeRuntime = (
         const ids = JSON.stringify([...new Set(filters.runIds)])
         conditions.push(
           sql.onDialectOrElse({
-            /* v8 ignore next -- PostgreSQL adapter; covered by //packages/smithers/control:postgresInventory */
             pg: () => sql`runs.run_id IN (SELECT jsonb_array_elements_text(${ids}::jsonb))`,
             orElse: () => sql`runs.run_id IN (SELECT value FROM json_each(${ids}))`
           })