@smoothbricks/cli 0.2.0 → 0.3.1

package/src/monorepo/package-policy.test.ts

@@ -2,6 +2,11 @@ import { afterEach, describe, expect, it, spyOn } from 'bun:test';
 import { mkdir, mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
 import { tmpdir } from 'node:os';
 import { dirname, join } from 'node:path';
+import {
+  BOUNDED_TEST_EXECUTOR,
+  BOUNDED_TEST_KILL_AFTER_MS,
+  BOUNDED_TEST_TIMEOUT_MS,
+} from '@smoothbricks/nx-plugin/bounded-test-policy';
 import {
   applyFixableMonorepoDefaults,
   applyNxPluginDefaults,
@@ -14,6 +19,20 @@ import {
   validateWorkspaceDependencies,
 } from './package-policy.js';
 
+const buildOutputDependencies = [
+  '^build',
+  '*-js',
+  '*-web',
+  '*-html',
+  '*-css',
+  '*-ios',
+  '*-android',
+  '*-native',
+  '*-napi',
+  '*-bun',
+  '*-wasm',
+];
+
 describe('root smoo monorepo policy', () => {
   afterEach(() => {
     console.error = originalConsoleError;
@@ -216,6 +235,26 @@ describe('Nx project name policy', () => {
       await rm(root, { recursive: true, force: true });
     }
   });
+
+  it('accepts private unversioned workspace projects as commit scopes', async () => {
+    const root = await createWorkspace({
+      rootName: '@smoothbricks/codebase',
+      packages: [{ dir: 'tooling', name: '@smoothbricks/tooling', private: true, version: null }],
+    });
+    try {
+      expect(validateNxProjectNames(root)).toBe(1);
+
+      applyNxProjectNameDefaults(root);
+
+      const tooling = JSON.parse(await readFile(join(root, 'packages/tooling/package.json'), 'utf8'));
+      expect(tooling.version).toBeUndefined();
+      expect(tooling.nx).toEqual({ name: 'tooling' });
+      expect(validateNxProjectNames(root)).toBe(0);
+      expect(listValidCommitScopes(root)).toEqual(new Set(['release', 'tooling']));
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
 });
 
 describe('workspace package script policy', () => {
@@ -428,11 +467,146 @@ describe('workspace package script policy', () => {
     }
   });
 
-  it('rejects old test tsconfig output and build.zig without steps', async () => {
+  it('accepts wildcard aggregate build dependencies', async () => {
+    const root = await createWorkspace({
+      rootName: '@smoothbricks/codebase',
+      packages: [
+        {
+          dir: 'native',
+          name: '@smoothbricks/native',
+          nx: {
+            name: 'native',
+            targets: {
+              build: { executor: 'nx:noop', dependsOn: buildOutputDependencies },
+            },
+          },
+        },
+      ],
+    });
+    try {
+      expect(validateWorkspaceDependencies(root)).toBe(0);
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
+  it('removes noop aggregate build targets when wildcard dependencies match resolved Nx plugin output', async () => {
+    const root = await createWorkspace({
+      rootName: '@smoothbricks/codebase',
+      packages: [
+        {
+          dir: 'native',
+          name: '@smoothbricks/native',
+          nx: {
+            name: 'native',
+            targets: {
+              build: { executor: 'nx:noop', dependsOn: buildOutputDependencies },
+            },
+          },
+        },
+      ],
+    });
+    try {
+      const resolvedTargetsByProject = new Map([
+        ['native', { targets: new Set(['build', 'tsc-js', 'zig-wasm']), buildDependsOn: buildOutputDependencies }],
+      ]);
+
+      applyWorkspaceDependencyDefaults(root, { resolvedTargetsByProject });
+
+      const native = await readJson(join(root, 'packages/native/package.json'));
+      expect(native.nx).toEqual({ name: 'native', targets: {} });
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
+  it('preserves explicit repo-local output targets with cache metadata', async () => {
+    const root = await createWorkspace({
+      rootName: '@smoothbricks/codebase',
+      packages: [
+        {
+          dir: 'bundled',
+          name: '@smoothbricks/bundled',
+          nx: {
+            name: 'bundled',
+            targets: {
+              build: { executor: 'nx:noop', dependsOn: buildOutputDependencies },
+              'tsdown-js': {
+                executor: 'nx:run-commands',
+                cache: true,
+                inputs: ['production', '^production'],
+                outputs: ['{projectRoot}/dist'],
+                options: { command: 'tsdown', cwd: '{projectRoot}' },
+              },
+            },
+          },
+        },
+      ],
+    });
+    try {
+      expect(validateWorkspaceDependencies(root)).toBe(0);
+
+      applyWorkspaceDependencyDefaults(root);
+
+      const bundled = await readJson(join(root, 'packages/bundled/package.json'));
+      expect(bundled).toMatchObject({
+        nx: {
+          targets: {
+            build: { dependsOn: buildOutputDependencies },
+            'tsdown-js': {
+              executor: 'nx:run-commands',
+              cache: true,
+              inputs: ['production', '^production'],
+              outputs: ['{projectRoot}/dist'],
+              options: { command: 'tsdown', cwd: '{projectRoot}' },
+            },
+          },
+        },
+      });
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
+  it('rejects build.zig without steps', async () => {
     const root = await createWorkspace({
       rootName: '@smoothbricks/codebase',
       packages: [{ dir: 'native', name: '@smoothbricks/native', nx: { name: 'native' } }],
     });
+    try {
+      await writeFile(join(root, 'packages/native/build.zig'), 'pub fn build(b: *std.Build) void { _ = b; }\n');
+
+      expect(validateWorkspaceDependencies(root)).toBe(1);
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
+  it('rejects old test tsconfig output for packages with test runners', async () => {
+    const root = await createWorkspace({
+      rootName: '@smoothbricks/codebase',
+      packages: [
+        {
+          dir: 'native',
+          name: '@smoothbricks/native',
+          nx: {
+            name: 'native',
+            targets: {
+              test: {
+                executor: BOUNDED_TEST_EXECUTOR,
+                options: {
+                  command: 'bun test',
+                  cwd: '{projectRoot}',
+                  timeoutMs: BOUNDED_TEST_TIMEOUT_MS,
+                  killAfterMs: BOUNDED_TEST_KILL_AFTER_MS,
+                },
+              },
+            },
+          },
+          scripts: { test: 'nx run native:test --outputStyle=stream' },
+        },
+      ],
+    });
     try {
       await writeJson(join(root, 'packages/native/tsconfig.test.json'), {
         compilerOptions: {
@@ -443,9 +617,8 @@ describe('workspace package script policy', () => {
           tsBuildInfoFile: 'dist-test/tsconfig.test.tsbuildinfo',
         },
       });
-      await writeFile(join(root, 'packages/native/build.zig'), 'pub fn build(b: *std.Build) void { _ = b; }\n');
 
-      expect(validateWorkspaceDependencies(root)).toBe(7);
+      expect(validateWorkspaceDependencies(root)).toBe(6);
     } finally {
       await rm(root, { recursive: true, force: true });
     }
@@ -467,7 +640,7 @@ describe('workspace package script policy', () => {
         compilerOptions: { baseUrl: '.', rootDir: 'src', types: ['node'], outDir: 'dist' },
       });
 
-      expect(validateWorkspaceDependencies(root)).toBe(1);
+      expect(validateWorkspaceDependencies(root)).toBe(2);
 
       applyWorkspaceDependencyDefaults(root);
 
@@ -500,18 +673,42 @@ describe('workspace package script policy', () => {
     }
   });
 
-  it('does not require tsconfig.test.json for non-Bun test runners', async () => {
+  it('creates no-emit test typecheck config for packages that use vitest', async () => {
     const root = await createWorkspace({
       rootName: '@smoothbricks/codebase',
       packages: [{ dir: 'app', name: '@smoothbricks/app', scripts: { test: 'vitest run' } }],
     });
     try {
+      await writeJson(join(root, 'packages/app/tsconfig.lib.json'), {
+        extends: '../../tsconfig.base.json',
+        compilerOptions: { baseUrl: '.', rootDir: 'src', outDir: 'dist' },
+      });
+
+      expect(validateWorkspaceDependencies(root)).toBe(2);
+
+      applyWorkspaceDependencyDefaults(root);
+
+      const testTsconfig = await readJson(join(root, 'packages/app/tsconfig.test.json'));
+      expect(testTsconfig).toMatchObject({ compilerOptions: { noEmit: true } });
+      expect(testTsconfig).not.toMatchObject({ compilerOptions: { types: expect.anything() } });
       expect(validateWorkspaceDependencies(root)).toBe(0);
     } finally {
       await rm(root, { recursive: true, force: true });
     }
   });
 
+  it('does not require tsconfig.test.json for other test runners but still requires bounded execution', async () => {
+    const root = await createWorkspace({
+      rootName: '@smoothbricks/codebase',
+      packages: [{ dir: 'app', name: '@smoothbricks/app', scripts: { test: 'node --test' } }],
+    });
+    try {
+      expect(validateWorkspaceDependencies(root)).toBe(1);
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
   it('detects bun test commands configured directly in Nx targets', async () => {
     const root = await createWorkspace({
       rootName: '@smoothbricks/codebase',
@@ -529,7 +726,7 @@ describe('workspace package script policy', () => {
       ],
     });
     try {
-      expect(validateWorkspaceDependencies(root)).toBe(1);
+      expect(validateWorkspaceDependencies(root)).toBe(2);
 
       applyWorkspaceDependencyDefaults(root);
 
@@ -559,6 +756,21 @@ describe('workspace package script policy', () => {
     }
   });
 
+  it('requires a test script or target when test files exist', async () => {
+    const root = await createWorkspace({
+      rootName: '@smoothbricks/codebase',
+      packages: [{ dir: 'app', name: '@smoothbricks/app' }],
+    });
+    try {
+      await mkdir(join(root, 'packages/app/src'), { recursive: true });
+      await writeFile(join(root, 'packages/app/src/example.test.ts'), 'export const testValue = true;\n');
+
+      expect(validateWorkspaceDependencies(root)).toBe(1);
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
   it('rewrites safe scripts that use workspace dependencies into Nx aliases', async () => {
     const root = await createWorkspace({
       rootName: '@smoothbricks/codebase',
@@ -581,16 +793,16 @@ describe('workspace package script policy', () => {
       ],
     });
     try {
-      expect(validateWorkspaceDependencies(root)).toBe(6);
+      expect(validateWorkspaceDependencies(root)).toBe(7);
 
       applyWorkspaceDependencyDefaults(root);
 
       const app = await readJson(join(root, 'packages/app/package.json'));
       expect(app.dependencies).toEqual({ '@smoothbricks/lib': 'workspace:*' });
       expect(app.scripts).toEqual({
-        dev: 'nx run app:dev --tui=false --outputStyle=stream',
-        serve: 'nx run app:serve --tui=false --outputStyle=stream',
-        test: 'nx run app:test',
+        dev: 'nx run app:dev --outputStyle=dynamic-legacy',
+        serve: 'nx run app:serve --outputStyle=dynamic-legacy',
+        test: 'nx run app:test --outputStyle=stream',
         build: 'nx run app:build',
         deploy: 'wrangler deploy',
         astro: 'astro',
@@ -611,9 +823,13 @@ describe('workspace package script policy', () => {
             options: { command: 'vite dev --host 0.0.0.0', cwd: '{projectRoot}' },
           },
           test: {
-            executor: 'nx:run-commands',
-            dependsOn: ['^build'],
-            options: { command: 'bun test --pass-with-no-tests', cwd: '{projectRoot}' },
+            executor: BOUNDED_TEST_EXECUTOR,
+            options: {
+              command: 'bun test --pass-with-no-tests',
+              cwd: '{projectRoot}',
+              timeoutMs: BOUNDED_TEST_TIMEOUT_MS,
+              killAfterMs: BOUNDED_TEST_KILL_AFTER_MS,
+            },
           },
           build: {
             executor: 'nx:run-commands',
@@ -637,13 +853,18 @@ describe('workspace package script policy', () => {
           dir: 'app',
           name: '@smoothbricks/app',
           dependencies: { '@smoothbricks/lib': 'workspace:*' },
-          scripts: { test: 'nx run app:test' },
+          scripts: { test: 'nx run app:test --outputStyle=stream' },
           nx: {
             name: 'app',
             targets: {
               test: {
-                executor: 'nx:run-commands',
-                options: { command: 'bun run test', cwd: '{projectRoot}' },
+                executor: BOUNDED_TEST_EXECUTOR,
+                options: {
+                  command: 'bun run test',
+                  cwd: '{projectRoot}',
+                  timeoutMs: BOUNDED_TEST_TIMEOUT_MS,
+                  killAfterMs: BOUNDED_TEST_KILL_AFTER_MS,
+                },
               },
             },
           },
@@ -651,7 +872,7 @@ describe('workspace package script policy', () => {
       ],
     });
     try {
-      expect(validateWorkspaceDependencies(root)).toBe(2);
+      expect(validateWorkspaceDependencies(root)).toBe(1);
     } finally {
       await rm(root, { recursive: true, force: true });
     }
@@ -681,9 +902,9 @@ describe('workspace package script policy', () => {
 
       const website = await readJson(join(root, 'packages/website/package.json'));
       expect(website.scripts).toEqual({
-        dev: 'nx run website:dev --tui=false --outputStyle=stream',
+        dev: 'nx run website:dev --outputStyle=dynamic-legacy',
         build: 'nx run website:build',
-        preview: 'nx run website:preview --tui=false --outputStyle=stream',
+        preview: 'nx run website:preview --outputStyle=stream',
         astro: 'astro',
       });
       expect(website.nx).toEqual({
@@ -737,19 +958,23 @@ describe('workspace package script policy', () => {
       ],
     });
     try {
-      expect(validateWorkspaceDependencies(root)).toBe(2);
+      expect(validateWorkspaceDependencies(root)).toBe(3);
 
       applyWorkspaceDependencyDefaults(root);
 
       const app = await readJson(join(root, 'packages/app/package.json'));
-      expect(app.scripts).toEqual({ test: 'nx run @external/app:test' });
+      expect(app.scripts).toEqual({ test: 'nx run @external/app:test --outputStyle=stream' });
       expect(app.nx).toEqual({
         name: '@external/app',
         targets: {
           test: {
-            executor: 'nx:run-commands',
-            dependsOn: ['^build'],
-            options: { command: 'bun test --pass-with-no-tests', cwd: '{projectRoot}' },
+            executor: BOUNDED_TEST_EXECUTOR,
+            options: {
+              command: 'bun test --pass-with-no-tests',
+              cwd: '{projectRoot}',
+              timeoutMs: BOUNDED_TEST_TIMEOUT_MS,
+              killAfterMs: BOUNDED_TEST_KILL_AFTER_MS,
+            },
           },
         },
       });
@@ -765,6 +990,8 @@ async function createWorkspace(input: {
   packages: Array<{
     dir: string;
     name: string;
+    private?: boolean;
+    version?: string | null;
     dependencies?: Record<string, string>;
     scripts?: Record<string, string>;
     nx?: Record<string, unknown>;
@@ -780,7 +1007,8 @@ async function createWorkspace(input: {
   for (const pkg of input.packages) {
     await writeJson(join(root, `packages/${pkg.dir}/package.json`), {
       name: pkg.name,
-      version: '0.0.0',
+      ...(pkg.version === null ? {} : { version: pkg.version ?? '0.0.0' }),
+      ...(pkg.private === undefined ? {} : { private: pkg.private }),
       ...(pkg.dependencies ? { dependencies: pkg.dependencies } : {}),
       ...(pkg.scripts ? { scripts: pkg.scripts } : {}),
       ...(pkg.nx ? { nx: pkg.nx } : {}),
@@ -844,7 +1072,7 @@ function validNxJson(): Record<string, unknown> {
         specifierSource: 'conventional-commits',
         currentVersionResolver: 'git-tag',
         fallbackCurrentVersionResolver: 'disk',
-        versionActions: '@smoothbricks/cli/nx-version-actions',
+        versionActions: '@smoothbricks/nx-plugin/version-actions',
       },
       releaseTag: { pattern: '{projectName}@{version}' },
       changelog: {