@smilodon/core 1.4.7 → 1.4.10

package/dist/index.umd.js

@@ -1879,7 +1879,22 @@
         }
         set classMap(map) {
             this._classMap = map;
-            this._setGlobalStylesMirroring(Boolean(this._optionRenderer || map));
+            this._setGlobalStylesMirroring(Boolean(this._optionRenderer || map || this._groupHeaderRenderer));
+            if (!this.isConnected)
+                return;
+            this._renderOptions();
+        }
+        /**
+         * DOM-based renderer for group headers.  When provided, the component will
+         * call this function for each group during rendering.  The returned element
+         * will receive `.group-header` and `part="group-header"` automatically.
+         */
+        get groupHeaderRenderer() {
+            return this._groupHeaderRenderer;
+        }
+        set groupHeaderRenderer(renderer) {
+            this._groupHeaderRenderer = renderer;
+            this._setGlobalStylesMirroring(Boolean(this._optionRenderer || this._classMap || renderer));
             if (!this.isConnected)
                 return;
             this._renderOptions();
@@ -1938,6 +1953,8 @@
             this._initializeObservers();
         }
         connectedCallback() {
+            // register instance
+            EnhancedSelect._instances.add(this);
             // WORKAROUND: Force display style on host element for Angular compatibility
             // Angular's rendering seems to not apply :host styles correctly in some cases
             // Must be done in connectedCallback when element is attached to DOM
@@ -1956,6 +1973,8 @@
             }
         }
         disconnectedCallback() {
+            // unregister instance
+            EnhancedSelect._instances.delete(this);
             // Cleanup observers
             this._resizeObserver?.disconnect();
             this._intersectionObserver?.disconnect();
@@ -2241,6 +2260,8 @@
         right: 0;
         bottom: 0;
         width: var(--select-arrow-width, 40px);
+        /* allow explicit height override even though container normally stretches */
+        height: var(--select-arrow-height, auto);
         display: flex;
         align-items: center;
         justify-content: center;
@@ -2306,9 +2327,14 @@
         background-color: var(--select-arrow-hover-bg, rgba(102, 126, 234, 0.08));
       }
       
+      .dropdown-arrow:hover {
+        /* legacy alias --select-arrow-hover for icon color */
+        color: var(--select-arrow-hover, var(--select-arrow-hover-color, #667eea));
+      }
+      
       .dropdown-arrow {
-        width: var(--select-arrow-size, 16px);
-        height: var(--select-arrow-size, 16px);
+        width: var(--select-arrow-width, var(--select-arrow-size, 16px));
+        height: var(--select-arrow-height, var(--select-arrow-size, 16px));
         color: var(--select-arrow-color, #667eea);
         transition: transform 0.2s ease, color 0.2s ease;
         transform: translateY(0);
@@ -2417,6 +2443,20 @@
         background: var(--select-options-bg, var(--select-dropdown-bg, var(--select-bg, white)));
       }
 
+      .group-header {
+        padding: var(--select-group-header-padding, 8px 12px);
+        font-weight: var(--select-group-header-weight, 600);
+        color: var(--select-group-header-color, #6b7280);
+        background-color: var(--select-group-header-bg, #f3f4f6);
+        font-size: var(--select-group-header-font-size, 12px);
+        text-transform: var(--select-group-header-text-transform, uppercase);
+        letter-spacing: var(--select-group-header-letter-spacing, 0.05em);
+        position: sticky;
+        top: 0;
+        z-index: 1;
+        border-bottom: var(--select-group-header-border-bottom, 1px solid #e5e7eb);
+      }
+
       .option {
         padding: var(--select-option-padding, 8px 12px);
         cursor: pointer;
@@ -2590,9 +2630,12 @@
         }
       }
       
-      /* Dark mode - Opt-in via class or data attribute */
+      /* Dark mode - Opt-in via class, data attribute, or ancestor context */
       :host(.dark-mode),
-      :host([data-theme="dark"]) {
+      :host([data-theme="dark"]),
+      :host-context(.dark-mode),
+      :host-context(.dark),
+      :host-context([data-theme="dark"]) {
         .input-container {
           background: var(--select-dark-bg, #1f2937);
           border-color: var(--select-dark-border, #4b5563);
@@ -2645,6 +2688,13 @@
         
         .option.active:not(.selected) {
           background-color: var(--select-dark-option-active-bg, #374151);
+        }
+
+        /* Group header in dark mode */
+        .group-header {
+          color: var(--select-dark-group-header-color, var(--select-group-header-color, #6b7280));
+          background-color: var(--select-dark-group-header-bg, var(--select-group-header-bg, #374151));
+        }
           color: var(--select-dark-option-active-color, #f9fafb);
           outline: var(--select-dark-option-active-outline, 2px solid rgba(129, 140, 248, 0.55));
         }
@@ -2727,19 +2777,14 @@
                 this._boundArrowClick = (e) => {
                     e.stopPropagation();
                     e.preventDefault();
-                    const wasOpen = this._state.isOpen;
-                    this._state.isOpen = !this._state.isOpen;
-                    this._updateDropdownVisibility();
-                    this._updateArrowRotation();
-                    if (this._state.isOpen && this._config.callbacks.onOpen) {
-                        this._config.callbacks.onOpen();
-                    }
-                    else if (!this._state.isOpen && this._config.callbacks.onClose) {
-                        this._config.callbacks.onClose();
+                    // delegate to the existing open/close helpers so we don't accidentally
+                    // drift out of sync with the logic in those methods (focus, events,
+                    // scroll-to-selected, etc.)
+                    if (this._state.isOpen) {
+                        this._handleClose();
                     }
-                    // Scroll to selected when opening
-                    if (!wasOpen && this._state.isOpen && this._state.selectedIndices.size > 0) {
-                        setTimeout(() => this._scrollToSelected(), 50);
+                    else {
+                        this._handleOpen();
                     }
                 };
                 this._arrowContainer.addEventListener('click', this._boundArrowClick);
@@ -2756,7 +2801,12 @@
                 });
             }
             // Input container click - focus input and open dropdown
+            // Prevent the original pointer event from bubbling/causing default focus behavior
+            // which can interfere with option click handling when opening the dropdown
             this._inputContainer.addEventListener('pointerdown', (e) => {
+                // Prevent propagation to document click listener but do NOT preventDefault.
+                // Allow default so browser events (click) on newly opened options still fire.
+                e.stopPropagation();
                 const target = e.target;
                 if (!this._config.enabled)
                     return;
@@ -2764,10 +2814,27 @@
                     return;
                 if (target && target.closest('.clear-control-button'))
                     return;
-                if (!this._state.isOpen) {
+                const wasClosed = !this._state.isOpen;
+                if (wasClosed) {
                     this._handleOpen();
                 }
+                else {
+                    // clicking the input while open should close the dropdown too
+                    this._handleClose();
+                }
+                // Focus the input (do not prevent default behavior)
                 this._input.focus();
+                // If we just opened the dropdown, transfer pointer capture to the
+                // options container so the subsequent pointerup lands there instead of
+                // staying with the input container (which would swallow the event).
+                if (wasClosed && this._optionsContainer && typeof e.pointerId === 'number') {
+                    try {
+                        this._optionsContainer.setPointerCapture(e.pointerId);
+                    }
+                    catch (_err) {
+                        // Some browsers may throw if element is not yet "connected"; ignore
+                    }
+                }
             });
             // Input container click - prevent event from reaching document listener
             this._container.addEventListener('click', (e) => {
@@ -2775,6 +2842,12 @@
             });
             // Input focus/blur
             this._input.addEventListener('focus', () => this._handleOpen());
+            // When the input loses focus we normally close the dropdown, but
+            // clicking an option will blur the input before the option's click
+            // handler executes. To avoid the blur timer closing the dropdown
+            // prematurely we use a short-lived flag that is set whenever we start
+            // interacting with the options container. The close callback checks this
+            // flag and skips closing if the user is about to click an option.
             this._input.addEventListener('blur', (e) => {
                 const related = e.relatedTarget;
                 if (related && (this._shadow.contains(related) || this._container.contains(related))) {
@@ -2782,6 +2855,10 @@
                 }
                 // Delay to allow option click/focus transitions
                 setTimeout(() => {
+                    if (this._suppressBlurClose) {
+                        // another pointerdown inside options is in progress; keep open
+                        return;
+                    }
                     const active = document.activeElement;
                     if (active && (this._shadow.contains(active) || this._container.contains(active))) {
                         return;
@@ -2796,11 +2873,33 @@
                 const query = e.target.value;
                 this._handleSearch(query);
             });
-            // Delegated click listener for improved event handling (smart fallback)
-            this._optionsContainer.addEventListener('click', (e) => {
-                const target = e.target;
-                // Handle option clicks
-                const option = target.closest('[data-sm-selectable], [data-selectable], [data-sm-state]');
+            // If the user presses down inside the options container we should
+            // temporarily suppress blur-based closing until after the click has
+            // been handled. Setting a flag that gets cleared in the next tick is
+            // sufficient.
+            this._optionsContainer.addEventListener('pointerdown', () => {
+                this._suppressBlurClose = true;
+                setTimeout(() => {
+                    this._suppressBlurClose = false;
+                }, 0);
+            });
+            // Delegated click listener for improved event handling (robust across shadow DOM)
+            const handleOptionEvent = (e) => {
+                const path = (e.composedPath && e.composedPath()) || [e.target];
+                let option = null;
+                for (const node of path) {
+                    if (!(node instanceof Element))
+                        continue;
+                    try {
+                        if (node.matches('[data-sm-selectable], [data-selectable], [data-sm-state]')) {
+                            option = node;
+                            break;
+                        }
+                    }
+                    catch (err) {
+                        continue;
+                    }
+                }
                 if (option && !option.hasAttribute('aria-disabled')) {
                     const indexStr = option.getAttribute('data-sm-index') ?? option.getAttribute('data-index');
                     const index = Number(indexStr);
@@ -2811,13 +2910,45 @@
                         });
                     }
                 }
-            });
+            };
+            this._optionsContainer.addEventListener('click', handleOptionEvent);
+            // also watch pointerup to catch cases where the pointerdown started outside
+            // (e.g. on the input) and the click never fires
+            this._optionsContainer.addEventListener('pointerup', handleOptionEvent);
             // Keyboard navigation
             this._input.addEventListener('keydown', (e) => this._handleKeydown(e));
-            // Click outside to close
+            // Click outside to close — robust detection across shadow DOM and custom renderers
             document.addEventListener('pointerdown', (e) => {
                 const path = (e.composedPath && e.composedPath()) || [];
-                const clickedInside = path.includes(this) || path.includes(this._container) || this._shadow.contains(e.target);
+                let clickedInside = false;
+                for (const node of path) {
+                    if (node === this || node === this._container) {
+                        clickedInside = true;
+                        break;
+                    }
+                    if (node instanceof Node) {
+                        try {
+                            if (this._shadow && this._shadow.contains(node)) {
+                                clickedInside = true;
+                                break;
+                            }
+                        }
+                        catch (err) {
+                            // ignore
+                        }
+                    }
+                    if (node instanceof Element) {
+                        try {
+                            if (node.matches('[data-sm-selectable], [data-selectable], [data-sm-state], .input-container, .select-container, .dropdown-arrow-container, .clear-control-button')) {
+                                clickedInside = true;
+                                break;
+                            }
+                        }
+                        catch (err) {
+                            // ignore
+                        }
+                    }
+                }
                 if (!clickedInside) {
                     this._handleClose();
                 }
@@ -2866,6 +2997,16 @@
         _handleOpen() {
             if (!this._config.enabled || this._state.isOpen)
                 return;
+            // close any other open selects before proceeding
+            EnhancedSelect._instances.forEach(inst => {
+                if (inst !== this)
+                    inst._handleClose();
+            });
+            // Always focus the input when opening so callers (arrow click,
+            // programmatic `open()`, etc.) get the keyboard cursor.  This was a
+            // frequent source of confusion in #14 where people opened the dropdown
+            // but the text field never received focus.
+            this._input.focus();
             this._markOpenStart();
             this._state.isOpen = true;
             this._dropdown.style.display = 'block';
@@ -3281,13 +3422,14 @@
             // FIX: Do not rely on this._optionsContainer.children[index] because filtering changes the children
             // Instead, use the index to update state directly
             const item = this._state.loadedItems[index];
+            // Debug: log selection attempt
             if (!item)
                 return;
+            const isCurrentlySelected = this._state.selectedIndices.has(index);
             // Keep active/focus styling aligned with the most recently interacted option.
             // Without this, a previously selected item may retain active classes/styles
             // after selecting a different option.
             this._state.activeIndex = index;
-            const isCurrentlySelected = this._state.selectedIndices.has(index);
             if (this._config.selection.mode === 'single') {
                 // Single select: clear previous and select new
                 const wasSelected = this._state.selectedIndices.has(index);
@@ -3518,6 +3660,7 @@
             const getValue = this._config.serverSide.getValueFromItem || ((item) => item?.value ?? item);
             const selectedValues = selectedItems.map(getValue);
             const selectedIndices = Array.from(this._state.selectedIndices);
+            // Debug: log change payload
             this._emit('change', { selectedItems, selectedValues, selectedIndices });
             this._config.callbacks.onChange?.(selectedItems, selectedValues);
         }
@@ -3837,23 +3980,25 @@
             const query = this._state.searchQuery.toLowerCase();
             // Handle Grouped Items Rendering (when no search query)
             if (this._state.groupedItems.length > 0 && !query) {
-                this._state.groupedItems.forEach(group => {
-                    const header = document.createElement('div');
-                    header.className = 'group-header';
-                    header.textContent = group.label;
-                    Object.assign(header.style, {
-                        padding: '8px 12px',
-                        fontWeight: '600',
-                        color: '#6b7280',
-                        backgroundColor: '#f3f4f6',
-                        fontSize: '12px',
-                        textTransform: 'uppercase',
-                        letterSpacing: '0.05em',
-                        position: 'sticky',
-                        top: '0',
-                        zIndex: '1',
-                        borderBottom: '1px solid #e5e7eb'
-                    });
+                this._state.groupedItems.forEach((group, groupIndex) => {
+                    let header;
+                    if (this.groupHeaderRenderer) {
+                        header = this.groupHeaderRenderer(group, groupIndex);
+                        // make sure the returned element has the correct semantics so
+                        // people can style it. we add the class/part even if the renderer
+                        // returned something else to ensure backward compatibility.
+                        if (!(header instanceof HTMLElement)) {
+                            // fall back to default if API is misused
+                            header = document.createElement('div');
+                            header.textContent = String(group.label);
+                        }
+                    }
+                    else {
+                        header = document.createElement('div');
+                        header.textContent = group.label;
+                    }
+                    header.classList.add('group-header');
+                    header.setAttribute('part', 'group-header');
                     this._optionsContainer.appendChild(header);
                     group.options.forEach(item => {
                         // Find original index for correct ID generation and selection
@@ -4126,6 +4271,8 @@
             }
         }
     }
+    /** live set of all connected instances; used to auto-close siblings */
+    EnhancedSelect._instances = new Set();
     // Register custom element
     if (!customElements.get('enhanced-select')) {
         customElements.define('enhanced-select', EnhancedSelect);