@sme.up/ketchup 5.0.0 → 5.2.1-SNAPSHOT

package/dist/collection/components/kup-data-table/kup-data-table-helper.js

@@ -1,6 +1,5 @@
-import numeral from 'numeral';
 import { SortMode, TotalMode, } from './kup-data-table-declarations';
-import { isEmpty, stringToNumber } from '../../utils/utils';
+import { stringToNumber } from '../../utils/utils';
 import { getCellValueForDisplay, getColumnByName, compareCell, } from '../../utils/cell-utils';
 import { FiltersRows } from '../../utils/filters/filters-rows';
 const dom = document.documentElement;
@@ -234,7 +233,7 @@ function updateGroupTotal(groupRow, totals, addedRow, distinctObj) {
     return;
   }
   keys.forEach((key) => {
-    const currentTotalValue = groupRow.group.totals[key] || 0;
+    const currentTotalValue = dom.ketchup.math.numberify(groupRow.group.totals[key] || 0);
     const cell = addedRow.cells[key];
     if (cell) {
       let _isNumber = dom.ketchup.objects.isNumber(cell.obj);
@@ -253,7 +252,7 @@ function updateGroupTotal(groupRow, totals, addedRow, distinctObj) {
         case TotalMode.DISTINCT:
           let cellValue;
           if (_isNumber) {
-            cellValue = numeral(stringToNumber(cell.value)).value();
+            cellValue = dom.ketchup.math.numberify(stringToNumber(cell.value));
           }
           else {
             cellValue = cell.value;
@@ -305,17 +304,15 @@ function updateGroupTotal(groupRow, totals, addedRow, distinctObj) {
         case TotalMode.SUM:
         case TotalMode.AVERAGE:
           if (_isNumber) {
-            const cellValue = numeral(stringToNumber(cell.value));
-            groupRow.group.totals[key] = numeral(cellValue)
-              .add(currentTotalValue)
-              .value();
+            const cellValue = dom.ketchup.math.numberify(stringToNumber(cell.value));
+            groupRow.group.totals[key] =
+              cellValue + currentTotalValue;
             // updating parents
             let parent = groupRow.group.parent;
             while (parent != null) {
-              const currentParentSum = parent.group.totals[key] || 0;
-              parent.group.totals[key] = numeral(cellValue)
-                .add(currentParentSum)
-                .value();
+              const currentParentSum = dom.ketchup.math.numberify(parent.group.totals[key] || 0);
+              parent.group.totals[key] =
+                cellValue + currentParentSum;
               parent = parent.group.parent;
             }
           }
@@ -324,7 +321,7 @@ function updateGroupTotal(groupRow, totals, addedRow, distinctObj) {
         case TotalMode.MIN:
           if (_isNumber) {
             const currentTotalValue = groupRow.group.totals[key];
-            const cellValue = numeral(stringToNumber(cell.value)).value();
+            const cellValue = dom.ketchup.math.numberify(stringToNumber(cell.value));
             if (currentTotalValue) {
               groupRow.group.totals[key] = Math.min(currentTotalValue, cellValue);
             }
@@ -387,7 +384,7 @@ function updateGroupTotal(groupRow, totals, addedRow, distinctObj) {
         case TotalMode.MAX:
           if (_isNumber) {
             const currentTotalValue = groupRow.group.totals[key];
-            const cellValue = numeral(stringToNumber(cell.value)).value();
+            const cellValue = dom.ketchup.math.numberify(stringToNumber(cell.value));
             if (currentTotalValue) {
               groupRow.group.totals[key] = Math.max(currentTotalValue, cellValue);
             }
@@ -528,13 +525,13 @@ function adjustGroupAverageOrFormula(row, type, toAdjustKeys, totals) {
   // adjust average/formulas
   toAdjustKeys.forEach((key) => {
     if (type == TotalMode.AVERAGE) {
-      row.group.totals[key] = numeral(row.group.totals[key])
-        .divide(numberOfLeaf)
-        .value();
+      row.group.totals[key] =
+        dom.ketchup.math.numberify(row.group.totals[key]) /
+          numberOfLeaf;
     }
     if (type == TotalMode.MATH) {
       let formula = totals[key].substring(TotalMode.MATH.length);
-      row.group.totals[key] = dom.ketchup.data.formulas.custom(formula, row.group.totals);
+      row.group.totals[key] = dom.ketchup.math.formulas.custom(formula, row.group.totals);
     }
   });
   return numberOfLeaf;
@@ -564,7 +561,8 @@ export function normalizeRows(columns, rows) {
   }
 }
 export function calcTotals(rows = [], totals = {}) {
-  if (isEmpty(rows) || isEmpty(totals)) {
+  if (dom.ketchup.objects.isEmptyJsObject(rows) ||
+    dom.ketchup.objects.isEmptyJsObject(totals)) {
     return {};
   }
   const keys = Object.keys(totals);
@@ -586,7 +584,7 @@ export function calcTotals(rows = [], totals = {}) {
           if (totals[key] === TotalMode.DISTINCT) {
             let cellValue;
             if (dom.ketchup.objects.isNumber(cell.obj)) {
-              cellValue = numeral(stringToNumber(cell.value)).value();
+              cellValue = dom.ketchup.math.numberify(stringToNumber(cell.value));
             }
             else {
               cellValue = cell.value;
@@ -603,32 +601,32 @@ export function calcTotals(rows = [], totals = {}) {
             }
           }
           else if (dom.ketchup.objects.isNumber(cell.obj)) {
-            const cellValue = numeral(stringToNumber(cell.value));
+            const cellValue = dom.ketchup.math.numberify(stringToNumber(cell.value));
             let currentFooterValue = footerRow[key];
             switch (true) {
               // TODO DRY the MIN and MAX functions
               case totals[key] === TotalMode.MIN:
                 if (currentFooterValue) {
-                  footerRow[key] = Math.min(currentFooterValue, cellValue.value());
+                  footerRow[key] = Math.min(currentFooterValue, cellValue);
                 }
                 else {
-                  footerRow[key] = cellValue.value();
+                  footerRow[key] = cellValue;
                 }
                 break;
               case totals[key] === TotalMode.MAX:
                 if (currentFooterValue) {
-                  footerRow[key] = Math.max(currentFooterValue, cellValue.value());
+                  footerRow[key] = Math.max(currentFooterValue, cellValue);
                 }
                 else {
-                  footerRow[key] = cellValue.value();
+                  footerRow[key] = cellValue;
                 }
                 break;
               default:
                 // SUM
                 currentFooterValue = footerRow[key] || 0;
-                footerRow[key] = cellValue
-                  .add(currentFooterValue)
-                  .value();
+                footerRow[key] =
+                  cellValue +
+                    dom.ketchup.math.numberify(currentFooterValue);
             }
             // TODO DRY the MIN and MAX functions
           }
@@ -684,20 +682,21 @@ export function calcTotals(rows = [], totals = {}) {
         case totals[key] === TotalMode.AVERAGE:
           const sum = footerRow[key];
           if (sum && rows.length > 0) {
-            footerRow[key] = numeral(sum)
-              .divide(rows.length)
-              .value();
+            footerRow[key] = sum / rows.length;
           }
           break;
         case totals[key] === TotalMode.COUNT:
           footerRow[key] = rows.length;
           break;
         case totals[key].indexOf(TotalMode.MATH) == 0:
-          footerRow[key] = dom.ketchup.data.formulas.custom(totals[key].substring(TotalMode.MATH.length), footerRow);
+          footerRow[key] = dom.ketchup.math.formulas.custom(totals[key].substring(TotalMode.MATH.length), footerRow);
           break;
         default:
           break;
       }
+      if (footerRow[key]) {
+        footerRow[key] = +footerRow[key].toFixed(2);
+      }
     }
   }
   return footerRow;

package/dist/collection/components/kup-data-table/kup-data-table-state.js

@@ -5,8 +5,8 @@ export class KupDataTableState {
     this.expandGroups = false;
     this.groupLabelDisplay = GroupLabelDisplayMode.BOTH;
     this.density = 'small';
-    this.enableExtraColumns = true;
     this.enableSortableColumns = false;
+    this.enableExtraColumns = true;
     this.forceOneLine = false;
     this.globalFilter = false;
     this.globalFilterValue = '';