@smartspectra/node-sdk 3.3.0-rc.7 → 3.3.0

package/js/ffi.js

@@ -262,6 +262,17 @@ class Session {
         }
 
         this._registeredThunks = [];
+        // Held from a successful start*() until native teardown completes
+        // (_teardownNative(), the destroy() path) — NOT released by
+        // stop()/stopAsync()/reset(). Those calls can return while a worker
+        // thread is still mid-relay of a trailing callback (e.g. the idle
+        // status transition after stop()); only session_destroy's joins
+        // guarantee no SDK thread can still call our trampolines. koffi's
+        // registered thunks do NOT ref the libuv loop, so without this a host
+        // whose only pending work is awaiting an SDK-callback-resolved
+        // promise drains its loop, Node disposes the isolate, and the next
+        // relayed callback segfaults the process (exit 139).
+        this._keepAlive = null;
         this._destroyed = false;
         // In-flight stopAsync() promise, if any. session_stop runs on a koffi
         // worker thread; destroy() must wait for it to settle before deleting
@@ -329,6 +340,7 @@ class Session {
         } : null;
         const rc = sessionStartFile(this._sess, videoPath, timestampsPath, opts, err);
         if (rc !== 0) throw makeFfiError(err);
+        this._takeKeepAlive();
     }
 
     // options (optional): { deviceIndex, width, height, fps, frameTransform }
@@ -344,6 +356,7 @@ class Session {
         } : null;
         const rc = sessionStartCamera(this._sess, opts, err);
         if (rc !== 0) throw makeFfiError(err);
+        this._takeKeepAlive();
     }
 
     startCustom(frameTransform = 0) {
@@ -351,6 +364,7 @@ class Session {
         const err = {};
         const rc = sessionStartCustom(this._sess, frameTransform | 0, err);
         if (rc !== 0) throw makeFfiError(err);
+        this._takeKeepAlive();
     }
 
     sendFrame(buffer, width, height, strideBytes, pixelFormat, timestampUs) {
@@ -455,27 +469,21 @@ class Session {
     // Returns a promise that resolves once native teardown (including any
     // worker-thread joins inside session_destroy) has completed.
     _teardownNative() {
-        if (this._sess === null) return Promise.resolve();
-        // stop → wait → destroy → unregister. session_destroy joins every
-        // worker thread SpawnWorker ever started for this session — including
-        // one that's mid-flight relaying an onError/onStatus callback to JS
-        // (e.g. an async graph failure). That relay can only complete once
-        // the JS event loop is free to service it, so running session_destroy
-        // synchronously here would deadlock: this call IS the JS thread, and
-        // it would be blocked joining a thread that's blocked waiting on this
-        // same thread's event loop. Run it on a koffi worker thread instead —
-        // the same reason stopAsync() runs session_stop off-thread above —
-        // so the event loop stays free no matter what a worker is mid-relay
-        // of. _releaseThunks() only runs after the callback fires, matching
-        // the original synchronous ordering (unregister only after the joins
-        // that guarantee no SDK thread can still call our trampolines).
-        sessionStop(this._sess);
-        sessionWait(this._sess, 0);
+        if (this._sess === null) {
+            this._releaseKeepAlive();
+            return Promise.resolve();
+        }
+        // session_destroy performs the required best-effort stop and worker
+        // joins. Run that entire drain off the JS thread: an SDK worker may be
+        // blocked relaying a callback onto this event loop, so synchronously
+        // stopping or waiting here would deadlock both threads. Unregister the
+        // thunks only after destroy has joined every possible caller.
         const sess = this._sess;
         this._sess = null;
         return new Promise((resolve) => {
             sessionDestroy.async(sess, () => {
                 this._releaseThunks();
+                this._releaseKeepAlive();
                 resolve();
             });
         });
@@ -498,6 +506,19 @@ class Session {
         for (const t of this._registeredThunks) koffi.unregister(t);
         this._registeredThunks = [];
     }
+
+    _takeKeepAlive() {
+        if (this._keepAlive !== null) return;
+        // Max-int32 ms (~24.8 days): the timer exists only to hold a loop
+        // reference; it never meaningfully fires.
+        this._keepAlive = setInterval(() => {}, 2 ** 31 - 1);
+    }
+
+    _releaseKeepAlive() {
+        if (this._keepAlive === null) return;
+        clearInterval(this._keepAlive);
+        this._keepAlive = null;
+    }
 }
 
 // Wrap a populated smartspectra_error_t into a JS Error with numeric `code`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartspectra/node-sdk",
-  "version": "3.3.0-rc.7",
+  "version": "3.3.0",
   "description": "Node.js (Electron) FFI binding for SmartSpectra vitals measurement",
   "author": "Presage Technologies, Inc.",
   "license": "SEE LICENSE IN LICENSE",
@@ -70,10 +70,10 @@
   "dependencies": {
     "koffi": "^2.10.0",
     "protobufjs": "^7.6.5",
-    "@smartspectra/node-sdk-linux-x64": "3.3.0-rc.7",
-    "@smartspectra/node-sdk-linux-arm64": "3.3.0-rc.7",
-    "@smartspectra/node-sdk-darwin-arm64": "3.3.0-rc.7",
-    "@smartspectra/node-sdk-win32-x64": "3.3.0-rc.7"
+    "@smartspectra/node-sdk-linux-x64": "3.3.0",
+    "@smartspectra/node-sdk-linux-arm64": "3.3.0",
+    "@smartspectra/node-sdk-darwin-arm64": "3.3.0",
+    "@smartspectra/node-sdk-win32-x64": "3.3.0"
   },
   "devDependencies": {
     "@types/node": "^24.0.0",