@smartsoft001-mobilems/claude-plugins 2.88.0 → 2.90.0

package/plugins/mobilems/skills/mobilems-thematic-publications/scripts/verify-module.sh

@@ -51,6 +51,49 @@ grep -q "@smartsoft001-mobilems/articles-domain" package.json && pass "articles-
 grep -q "@smartsoft001-mobilems/articles-shell-angular" package.json && pass "articles-shell-angular dep" || bad "articles-shell-angular dep missing"
 grep -q "@smartsoft001-mobilems/articles-shell-dtos" package.json && pass "articles-shell-dtos dep" || bad "articles-shell-dtos dep missing"
 
+echo "== Framework first (packages/shared/angular/README.md) =="
+LIBDIR="libs/museum-thematic-paths/shell/angular/src/lib"
+# 1. masonry belongs to the framework's MasonryGridComponent — no module-level instances
+MAS="$(grep -rlnE "new Masonry\(|MasonryInstance" libs apps/web/src 2>/dev/null || true)"
+if [ -n "$MAS" ]; then
+  bad "hand-rolled masonry — render grids with <smart-mobilems-masonry-grid> (MasonryGridComponent):"
+  printf '        %s\n' $MAS >&2
+else
+  pass "no hand-rolled masonry instances"
+fi
+# 2. the Masonry provider exists ONLY to feed MasonryGridComponent. Providing it without ever
+#    rendering the component means the grid was hand-rolled some other way (CSS columns, flex, …),
+#    which the `new Masonry(` grep above cannot see.
+if grep -rq "provide: Masonry" "$LIBDIR" 2>/dev/null; then
+  if grep -rq "smart-mobilems-masonry-grid" "$LIBDIR" 2>/dev/null; then
+    pass "grids render via <smart-mobilems-masonry-grid>"
+  else
+    bad "module provides Masonry but never renders <smart-mobilems-masonry-grid> — hand-rolled grid"
+  fi
+fi
+# 3. a list page must render through the framework grid
+LISTP="$(find "$LIBDIR/pages" -maxdepth 1 -type d -name 'list*' 2>/dev/null || true)"
+if [ -n "$LISTP" ]; then
+  if grep -rq "smart-mobilems-masonry-grid" $LISTP 2>/dev/null; then
+    pass "list page renders via <smart-mobilems-masonry-grid>"
+  else
+    bad "list page does not render <smart-mobilems-masonry-grid> (README.md#masonrygridcomponent)"
+  fi
+fi
+# 4. filters must EXTEND the framework base class — `context.` alone proves nothing, and a
+#    differently-named dir must not silently skip the check
+FILT="$(find "$LIBDIR/components" -maxdepth 1 -type d \( -name 'filters*' -o -name 'search*' -o -name 'facet*' \) 2>/dev/null || true)"
+if [ -n "$FILT" ]; then
+  if grep -rqE "FiltersBaseComponent" $FILT 2>/dev/null; then
+    pass "filters use the framework filter API"
+  else
+    bad "filters do not extend FiltersBaseComponent — no ad-hoc query building:"
+    printf '        %s\n' $FILT >&2
+  fi
+else
+  pass "no filters component in this module"
+fi
+
 echo
 if [ "$fail" = 0 ]; then echo "VERIFY: all checks passed."; else echo "VERIFY: FAILED — fix the items above and re-run." >&2; fi
 exit "$fail"