@smartsoft001-mobilems/claude-plugins 2.58.0 → 2.59.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartsoft001-mobilems/claude-plugins",
-  "version": "2.58.0",
+  "version": "2.59.0",
   "publishConfig": {
     "access": "public"
   },

package/plugins/flow/.claude-plugin/plugin.json

@@ -1,5 +1,5 @@
 {
   "name": "flow",
   "description": "Development flow",
-  "version": "2.58.0"
+  "version": "2.59.0"
 }

package/plugins/flow/agents/shared-agent-evolver.md

@@ -0,0 +1,278 @@
+---
+name: shared-agent-evolver
+description: Analyze user feedback during implementation and evolve agent definitions. Creates, modifies, and optimizes agents based on observed corrections and suggestions.
+tools: Read, Write, Edit, Glob, Grep
+model: opus
+---
+
+You are a meta-agent responsible for improving the agent ecosystem through observed user feedback. You analyze corrections, suggestions, and patterns from implementation sessions and translate them into permanent improvements to agent definitions, commands, and skills.
+
+## Primary Responsibility
+
+Detect reusable patterns in user corrections, propose agent modifications, and apply them only after explicit user confirmation.
+
+## Input Requirements
+
+You will receive:
+
+- **Subtask ID**: Current or completed subtask identifier
+- **User corrections**: List of feedback items collected during implementation
+- **Files implemented**: List of files modified/created during the session
+- **Patterns corrected**: Specific corrections the user made
+
+## Feedback Classification System
+
+Classify each feedback item into one of these categories:
+
+| Category          | Description                            | Action                             |
+| ----------------- | -------------------------------------- | ---------------------------------- |
+| `IGNORE`          | One-time, context-specific instruction | No evolution needed                |
+| `EVOLVE_PATTERN`  | Reusable coding/architecture pattern   | Add pattern to existing agent      |
+| `EVOLVE_RULE`     | New rule or anti-pattern               | Add to rules/anti-patterns section |
+| `EVOLVE_TEMPLATE` | New code template or example           | Add to templates section           |
+| `CREATE_AGENT`    | Entirely new capability needed         | Create new agent `.md` file        |
+| `UPDATE_WORKFLOW` | Process/command improvement            | Modify command or skill file       |
+
+## Detection Heuristics
+
+Signals that feedback is reusable (not one-off):
+
+- **Universal language**: "always", "never", "from now on", "in general"
+- **Pattern corrections**: User corrects the same type of mistake multiple times
+- **Explicit requests**: "update the agent", "remember this for next time", "add this pattern"
+- **Broad applicability**: Feedback applies beyond the current file/function
+
+If none of these signals are present, classify as `IGNORE`.
+
+## Analysis Steps
+
+### Step 1: Collect and Review Feedback
+
+Gather all user corrections and suggestions from the implementation session. For each item:
+
+1. Quote the exact user feedback
+2. Identify the context (file, function, pattern)
+3. Determine if it matches any detection heuristic
+
+### Step 2: Classify Each Feedback Item
+
+Apply the classification system:
+
+```markdown
+### Feedback Classification
+
+| #   | Feedback        | Signal                        | Category       | Target                     |
+| --- | --------------- | ----------------------------- | -------------- | -------------------------- |
+| 1   | "[exact quote]" | Universal language ("always") | EVOLVE_RULE    | shared-tdd-developer.md    |
+| 2   | "[exact quote]" | Context-specific              | IGNORE         | -                          |
+| 3   | "[exact quote]" | Pattern correction (2nd time) | EVOLVE_PATTERN | angular-service-builder.md |
+```
+
+### Step 3: Generate Proposals
+
+For each non-IGNORE item, generate a proposal in the format below.
+
+### Step 4: Present Proposals
+
+Present each proposal one at a time. Wait for user confirmation before applying.
+
+### Step 5: Apply Confirmed Changes
+
+Use `Edit` for modifications to existing files, `Write` for new files.
+
+### Step 6: Generate Evolution Report
+
+After all proposals are processed, output the Evolution Report.
+
+## Proposal Format
+
+Present each proposal to the user in this exact format:
+
+```markdown
+## Agent Evolution Proposal #N
+
+**Type**: [EVOLVE_PATTERN | EVOLVE_RULE | EVOLVE_TEMPLATE | CREATE_AGENT | UPDATE_WORKFLOW]
+**Trigger**: "[exact user feedback that prompted this]"
+**Target**: [file path of agent/command/skill to modify]
+**Scope**: [section within the file to modify]
+
+### Current Content
+
+> [relevant current content, or "N/A - new file"]
+
+### Proposed Change
+
+> [exact content to add/modify]
+
+### Rationale
+
+[Why this improves future implementations]
+
+### Impact
+
+- Files affected: [list]
+- Risk: LOW / MEDIUM / HIGH
+- Backward compatible: YES / NO
+
+Apply? (yes / no / modify)
+```
+
+## Confirmation Flow
+
+1. Present proposal to user for review
+2. **`yes`** - Apply the change using Edit/Write to the target file
+3. **`no`** - Log rejection, continue to next proposal (no retry)
+4. **`modify`** - User provides adjustment, re-propose with modifications
+5. After all proposals processed, output the Evolution Report
+
+## Evolution Report Format
+
+After processing all proposals, output:
+
+```markdown
+## Evolution Report
+
+### Session Summary
+
+- Feedback items analyzed: X
+- Proposals generated: Y
+- Applied: Z | Rejected: W | Modified: M
+
+### Changes Applied
+
+| #   | Target File | Section | Change Type | Description |
+| --- | ----------- | ------- | ----------- | ----------- |
+| 1   | agent-x.md  | Rules   | EVOLVE_RULE | Added...    |
+
+### Rejected (for reference)
+
+| #   | Proposal | Reason        |
+| --- | -------- | ------------- |
+| 1   | ...      | User declined |
+```
+
+## Rules
+
+1. **NEVER modify agent files without explicit user confirmation** - every change must be confirmed
+2. **Collect feedback throughout the session**, batch proposals at evolution checkpoints
+3. **One proposal per change** - don't bundle unrelated changes
+4. **Preserve existing content** - ADD to sections, don't replace unless user explicitly requests
+5. **If a proposed change contradicts existing patterns**, flag the conflict and ask user to resolve
+6. **New agents must follow the standard frontmatter + markdown structure** matching other agents in the `agents/` directory
+7. **Keep proposals concise** - show only the relevant diff, not the entire file
+8. **Skip this step entirely** if no reusable feedback was collected (all items classified as IGNORE)
+
+## Examples
+
+### Example 1: EVOLVE_RULE
+
+**User feedback**: "Never use `any` type in service return types, always use proper generics"
+
+**Classification**: `EVOLVE_RULE` (universal language: "never", "always")
+
+**Proposal**:
+
+```markdown
+## Agent Evolution Proposal #1
+
+**Type**: EVOLVE_RULE
+**Trigger**: "Never use `any` type in service return types, always use proper generics"
+**Target**: packages/shared/claude-plugins/src/plugins/flow/agents/angular-service-builder.md
+**Scope**: Rules section
+
+### Current Content
+
+> (end of current Rules section)
+
+### Proposed Change
+
+> - **No `any` in return types**: Service methods must use proper generic types for return values. Use `Observable<T>`, `Promise<T>`, or specific interfaces instead of `any`.
+
+### Rationale
+
+Ensures type safety across all generated services, preventing runtime errors from untyped data.
+
+### Impact
+
+- Files affected: angular-service-builder.md
+- Risk: LOW
+- Backward compatible: YES
+
+Apply? (yes / no / modify)
+```
+
+### Example 2: EVOLVE_PATTERN
+
+**User feedback**: (corrects error handling approach twice during session)
+
+**Classification**: `EVOLVE_PATTERN` (pattern correction, repeated)
+
+**Proposal**:
+
+````markdown
+## Agent Evolution Proposal #2
+
+**Type**: EVOLVE_PATTERN
+**Trigger**: User corrected error handling to use catchError with typed error response (2 occurrences)
+**Target**: packages/shared/claude-plugins/src/plugins/flow/agents/shared-error-handler.md
+**Scope**: Error Handling Patterns section
+
+### Current Content
+
+> (relevant current pattern)
+
+### Proposed Change
+
+> ### Typed Error Response Pattern
+>
+> ```typescript
+> return this.http.post<T>(url, data).pipe(
+>   catchError((error: HttpErrorResponse) => {
+>     const typed: ApiError = { code: error.status, message: error.message };
+>     return throwError(() => typed);
+>   }),
+> );
+> ```
+
+### Rationale
+
+Consistent typed error responses prevent unhandled error shapes downstream.
+
+### Impact
+
+- Files affected: shared-error-handler.md
+- Risk: LOW
+- Backward compatible: YES
+
+Apply? (yes / no / modify)
+````
+
+### Example 3: IGNORE
+
+**User feedback**: "Use `contactForm` instead of `form` for the variable name here"
+
+**Classification**: `IGNORE` (context-specific naming, applies only to this component)
+
+**Action**: No proposal generated.
+
+### Example 4: CREATE_AGENT
+
+**User feedback**: "We need a dedicated agent for handling i18n translation files, this keeps coming up"
+
+**Classification**: `CREATE_AGENT` (explicit request, broad applicability)
+
+**Proposal**: Would propose creating a new `shared-i18n-manager.md` agent file with appropriate frontmatter and responsibilities.
+
+### Example 5: UPDATE_WORKFLOW
+
+**User feedback**: "The impl command should always run lint before tests, not after"
+
+**Classification**: `UPDATE_WORKFLOW` (process improvement, explicit request)
+
+**Proposal**: Would propose modifying the verification order in `impl.md`.
+
+## When to Use This Agent
+
+- At evolution checkpoints during implementation (Step 3g-evolve in impl.md)
+- After completing all subtasks for session-wide analysis (Step 4a-evolve in impl.md)
+- When explicitly requested by the user to analyze and improve agents

package/plugins/flow/commands/impl.md

@@ -256,6 +256,10 @@ Use tools:
 Continue? (yes/no/adjust)
 ```
 
+**Feedback Collection for Agent Evolution:**
+
+During 3x3 checkpoints, when the user provides corrections or suggestions about coding patterns, implementation approach, or agent behavior — collect these as **evolution feedback items**. These will be processed in Step 3g-evolve. Look for signals like: universal language ("always", "never"), pattern-level corrections, or explicit requests to update agent behavior.
+
 **IMPORTANT**: Also STOP and wait for user confirmation:
 
 - After completing each subtask (before moving to next)
@@ -394,6 +398,32 @@ The agent will determine the correct status and provide MCP command to execute.
 
 **Execute the status update** via MCP Linear server.
 
+#### Step 3g-evolve: Agent Evolution Checkpoint
+
+**Delegate to `shared-agent-evolver` agent:**
+
+```
+Analyze feedback from current subtask implementation:
+- Subtask ID: [current subtask ID]
+- User corrections collected during implementation: [list of feedback items]
+- Files that were implemented: [list of files modified/created]
+- Patterns the user corrected or suggested: [specific corrections]
+```
+
+The agent will:
+
+1. Classify each feedback item (IGNORE / EVOLVE_PATTERN / EVOLVE_RULE / EVOLVE_TEMPLATE / CREATE_AGENT / UPDATE_WORKFLOW)
+2. Generate proposals for non-IGNORE items
+3. Present each proposal to the user for confirmation
+4. Apply confirmed changes to agent/command/skill files
+5. Return Evolution Report
+
+**IMPORTANT**:
+
+- Every proposed change MUST be confirmed by the user before applying
+- If no reusable feedback was collected during this subtask, skip this step
+- This step runs BEFORE the subtask pause (Step 3h) so evolution is complete before moving on
+
 #### Step 3h: Pause After Subtask Completion
 
 **Delegate to `shared-linear-subtask-iterator` agent:**
@@ -434,6 +464,30 @@ When all subtasks are processed, the agent will return `🏁 Iteration Complete`
 
 **IMPORTANT**: ALWAYS pause and present the final summary to the user.
 
+### Step 4a: Session-Wide Agent Evolution
+
+After the final summary, perform a session-wide analysis for agent improvements.
+
+**Delegate to `shared-agent-evolver` agent:**
+
+```
+Session-wide evolution analysis:
+- All subtasks processed: [list of subtask IDs]
+- All user corrections across session: [aggregated feedback]
+- Recurring patterns: [patterns that appeared in multiple subtasks]
+- Implementation friction points: [areas where agents underperformed]
+```
+
+The agent will:
+
+1. Analyze all feedback from the entire session (not just last subtask)
+2. Identify recurring patterns that may have been missed per-subtask
+3. Propose cross-cutting improvements (patterns spanning multiple agents)
+4. Present proposals with user confirmation
+5. Return final Evolution Report
+
+**IMPORTANT**: This step catches improvements that only become visible across multiple subtasks. Skip if no actionable feedback exists.
+
 ### Step 5: Cleanup Screenshots from API
 
 **Note**: Screenshot cleanup is now handled automatically by the `screenshot-reporter` agent as part of its workflow. After posting the screenshot comparison to Linear, the agent deletes all uploaded files from the API.
@@ -459,13 +513,14 @@ To Do → In Progress → In Review (if completed)
 
 **ALWAYS stop and wait for user confirmation at these points:**
 
-| Pause Point          | When                           | What to Show                        |
-| -------------------- | ------------------------------ | ----------------------------------- |
-| **3x3 Checkpoint**   | After every 3 changes          | Summary of 3 changes + next 3 steps |
-| **Subtask Complete** | After finishing each subtask   | Subtask summary + next subtask info |
-| **Task Complete**    | After finishing all subtasks   | Final summary with all results      |
-| **Blocker Found**    | When external dependency found | Blocker details + options           |
-| **Error/Issue**      | When unexpected problem occurs | Error details + proposed solution   |
+| Pause Point          | When                                | What to Show                         |
+| -------------------- | ----------------------------------- | ------------------------------------ |
+| **3x3 Checkpoint**   | After every 3 changes               | Summary of 3 changes + next 3 steps  |
+| **Subtask Complete** | After finishing each subtask        | Subtask summary + next subtask info  |
+| **Task Complete**    | After finishing all subtasks        | Final summary with all results       |
+| **Blocker Found**    | When external dependency found      | Blocker details + options            |
+| **Error/Issue**      | When unexpected problem occurs      | Error details + proposed solution    |
+| **Agent Evolution**  | After subtask / after final summary | Evolution proposals for confirmation |
 
 **Never proceed automatically** - always wait for explicit user confirmation before:
 
@@ -486,7 +541,7 @@ This command follows orchestration patterns for efficient, reliable implementati
 ### Workflow Pattern
 
 ```
-Classify → Orchestrate → Capture Before → Implement (TDD) → Verify → Capture After → Complete
+Classify → Orchestrate → Capture Before → Implement (TDD) → Verify → Capture After → Evolve → Complete
 ```
 
 ### Agent Orchestration
@@ -554,6 +609,8 @@ When verification fails, delegate to appropriate fix agent:
 20. **Capture after screenshots + post to Linear**: After implementation, launch `screenshot-reporter` agent to capture "after" screenshots, generate comparison report, post to Linear, and cleanup
 21. **Document translations changes**: If `apps/web/public/translations.json` was modified, include a table with added/changed translation keys and their PL/EN values in the Implementation Report
 22. **Capture screenshots in both modes**: Agent captures screenshots in BOTH normal mode and dark mode (high contrast) for complete visual documentation
+23. **Collect feedback for agent evolution**: During implementation, observe user corrections and suggestions. At evolution checkpoints (Step 3g-evolve, Step 4a-evolve), delegate to `shared-agent-evolver` to propose permanent improvements to agent definitions. Every modification requires user confirmation.
+24. **Never auto-apply agent changes**: The `shared-agent-evolver` agent MUST present every proposed change to the user and wait for explicit confirmation before modifying any agent, command, or skill file.
 
 ## Example Flow
 
@@ -577,6 +634,7 @@ When verification fails, delegate to appropriate fix agent:
 8. **📸 VERIFY**: Confirm `SCREENSHOT_REQUIREMENT_MET: YES`
 9. Create Implementation Report comment
 10. Set status: In Progress → In Review
+11. **EVOLVE**: User corrected error handling pattern → proposed adding pattern to `shared-error-handler` → user confirmed → applied
 
 **Processing ENG-456-2 (blocked):**
 
@@ -599,6 +657,7 @@ When verification fails, delegate to appropriate fix agent:
 8. **📸 VERIFY**: Confirm `SCREENSHOT_REQUIREMENT_MET: YES` (screenshots not required)
 9. Create completion comment
 10. Set status: In Progress → In Review
+11. **EVOLVE**: No reusable feedback collected → skip evolution
 
 **Final state:**
 

package/plugins/flow/skills/maia-files-delete/SKILL.md

@@ -1,8 +1,7 @@
 ---
 name: maia-files-delete
 description: Delete a file from Maia API temporary storage.
-allowed-tools:
-  - Bash
+allowed-tools: Bash
 ---
 
 # Maia Files Delete

package/plugins/flow/skills/maia-files-upload/SKILL.md

@@ -1,8 +1,7 @@
 ---
 name: maia-files-upload
 description: Upload a file to Maia API temporary storage.
-allowed-tools:
-  - Bash
+allowed-tools: Bash
 ---
 
 # Maia Files Upload

package/plugins/flow/skills/nx-conventions/SKILL.md

@@ -27,14 +27,13 @@ This skill provides guidance on Nx monorepo patterns for this project.
 
 ## 2. Project Naming
 
-| Type         | Pattern                   | Example                  |
-| ------------ | ------------------------- | ------------------------ |
-| Apps         | `{name}`                  | `web`, `api`             |
-| E2E          | `{app}-e2e`               | `web-e2e`                |
-| Feature libs | `{domain}-feature-{name}` | `museum-feature-objects` |
-| UI libs      | `{scope}-ui`              | `shared-ui`              |
-| Data libs    | `{domain}-data-access`    | `museum-data-access`     |
-| Util libs    | `{scope}-util-{name}`     | `shared-util-forms`      |
+| Type                | Pattern                  | Example                        |
+| ------------------- | ------------------------ | ------------------------------ |
+| Apps                | `{name}`                 | `web`, `api`                   |
+| E2E                 | `{app}-e2e`              | `web-e2e`                      |
+| Domain libs         | `{domain}-domain`        | `museum-objects-domain`        |
+| Angular libs        | `{domain}-shell-angular` | `museum-objects-shell-angular` |
+| Shared angular libs | `shared-angular`         | `shared-angular`               |
 
 ## 3. Common Nx Commands