@smartsoft001-mobilems/claude-plugins 2.128.0 → 2.129.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartsoft001-mobilems/claude-plugins",
-  "version": "2.128.0",
+  "version": "2.129.0",
   "publishConfig": {
     "access": "public"
   },

package/plugins/mobilems/.claude-plugin/plugin.json

@@ -1,5 +1,5 @@
 {
   "name": "mobilems",
   "description": "MobilEMS-specific Claude Code skills (MuzaCMS / MobileMS indexer API)",
-  "version": "2.128.0"
+  "version": "2.129.0"
 }

package/plugins/mobilems/skills/mobilems-objects/SKILL.md

@@ -35,16 +35,21 @@ list — re-implementing framework code is a defect, not a shortcut:
 2. [`packages/objects/README.md`](https://github.com/smartsoft001/mobilems-framework/blob/main/packages/objects/README.md) — this module's package catalog
 3. `libs/shared/angular/README.md` — the app's own shared lib (built by `mobilems-project-init`)
 
-| Do not hand-roll                                                                                                  | Use                                                                                                                                                               |
-| ----------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| a masonry grid (`new Masonry(...)`, per-page masonry JS/CSS)                                                      | `<smart-mobilems-masonry-grid>` (`MasonryGridComponent`) with a `#masonryContentTpl`; the `Masonry` provider in step 3 only feeds it                              |
-| filter state / hand-built `query` arrays                                                                          | `FiltersBaseComponent<MsObject>` + its `FiltersContext` accessors (`searchText`, `keywords`, `page`, `sort`, `onlyImage`, …)                                      |
-| list page logic (first read, persistence, SSR read, read guard, load-more, masonry lifecycle, list SEO)           | `ObjectsCatalogBaseComponent` (`pages/list` extends it; the app keeps its own markup and `sortOptions` over `isNewType`)                                          |
-| detail page logic (SSR SEO, scroll, visit counter, retry, opt-in related / related collections)                   | `ObjectDetailsBaseComponent` (extends `ObjectsItemComponent`; `pages/item` extends it, `related` and `relatedCollections` are opt-in via the constructor options) |
-| object detail field helpers (title, tags, inventory, bibliography, description, related articles, ask-about link) | the `objectTitle`, `tagValues`, `inventoryValues`, `bibliography`, `descriptionHtml`, `relatedArticles`, `askAboutObjectHref` tools                               |
-| gallery / media lists                                                                                             | `ObjectMediaService`                                                                                                                                              |
-| visit counter, related objects, collection / archaeological dictionaries                                          | `ObjectsDataService` (extends `ObjectsService`)                                                                                                                   |
-| media URLs, meta/OG tags, filter dictionaries, modals, WCAG                                                       | `FileUrlService`, `SeoService`/`MetaService`, `DictionaryService`, `ModalService`, `WcagService`                                                                  |
+| Do not hand-roll                                                                                                  | Use                                                                                                                                                                                               |
+| ----------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| a masonry grid (`new Masonry(...)`, per-page masonry JS/CSS)                                                      | `<smart-mobilems-masonry-grid>` (`MasonryGridComponent`) with a `#masonryContentTpl`; the `Masonry` provider in step 3 only feeds it                                                              |
+| filter state / hand-built `query` arrays                                                                          | `FiltersBaseComponent<MsObject>` + its `FiltersContext` accessors (`searchText`, `keywords`, `page`, `sort`, `onlyImage`, …)                                                                      |
+| list page logic (first read, persistence, SSR read, read guard, load-more, masonry lifecycle, list SEO)           | `ObjectsCatalogBaseComponent` (`pages/list` extends it; the app keeps its own markup and `sortOptions` over `isNewType`)                                                                          |
+| detail page logic (SSR SEO, scroll, visit counter, retry, opt-in related / related collections)                   | `ObjectDetailsBaseComponent` (extends `ObjectsItemComponent`; `pages/item` extends it, `related` and `relatedCollections` are opt-in via the constructor options)                                 |
+| object detail field helpers (title, tags, inventory, bibliography, description, related articles, ask-about link) | the `objectTitle`, `tagValues`, `inventoryValues`, `bibliography`, `descriptionHtml`, `relatedArticles`, `askAboutObjectHref` tools                                                               |
+| gallery / media lists                                                                                             | `ObjectMediaService`                                                                                                                                                                              |
+| visit counter, related objects, collection / archaeological dictionaries                                          | `ObjectsDataService` (extends `ObjectsService`)                                                                                                                                                   |
+| filter bar (sort / limit, chips, dictionary toggles, year range, theme tags)                                      | `ObjectsFiltersBarBaseComponent` (`components/filters-top` extends it; the app keeps its markup; the cycle theme tags are opt-in with `cycleTags: true`, otherwise no `dictionary/Cycle` request) |
+| search panel (phrase, tags, boolean filters) - Podlasie-style museums only                                        | `ObjectsSearchPanelBaseComponent` (S/T-style museums have no search panel: they use the filters bar only)                                                                                         |
+| advanced filters panel - Podlasie-style museums only                                                              | `ObjectsAdvancedFiltersBaseComponent` (the field config `IObjectsAdvancedFilterField[]` stays in the app, the framework exports only the types; S/T-style museums skip it)                        |
+| share results link                                                                                                | `ObjectsShareResultsBaseComponent` (extends the shared `ShareLinkBaseComponent`; set `objectsShareResultsListPath` for another list)                                                              |
+| sort / limit options, sort keys, results URL                                                                      | `OBJECTS_SORT_OPTIONS`, `OBJECTS_NEW_TYPE_SORT_OPTIONS`, `OBJECTS_LIMIT_OPTIONS`, `objectsSortKey`, `objectsSortFromKey`, `buildObjectsResultsUrl`                                                |
+| media URLs, meta/OG tags, filter dictionaries, modals, WCAG                                                       | `FileUrlService`, `SeoService`/`MetaService`, `DictionaryService`, `ModalService`, `WcagService`                                                                                                  |
 
 Anything the framework genuinely lacks goes into `libs/shared/angular` **once** (and into its
 README) — never a per-module copy. `scripts/verify-module.sh` fails the run on hand-rolled masonry.
@@ -109,7 +114,7 @@ tab, the grid/list item cards and the object gallery widget.
 The cross-cutting rules live in `mobilems-project-init`
 `references/qa-hardening.md`; these are the objects-specific ones:
 
-- **Search debounce.** The panel full-text search (`app-objects-searchbar variant="panel"`, a standalone component: a live debounced search through `searchEvent` / `closeEvent`, an `autofocus` input, never navigates - it does not extend `SearchbarBaseComponent`, which navigates to the search route) must
+- **Search debounce.** For apps that render the panel full-text search with `app-objects-searchbar variant="panel"` (a standalone component: a live debounced search through `searchEvent` / `closeEvent`, an `autofocus` input, never navigates - it does not extend `SearchbarBaseComponent`, which navigates to the search route; the filter bases do not need it), the host must
   re-emit through a handler with `@debounce(250)` (`lodash-decorators`) — without it every keystroke
   hits the API. Collections and news filters already do this; keep the modules consistent.
 - **List page:** show the total result count (`facade.totalCount()`) and add the shared

package/plugins/mobilems/skills/mobilems-objects/references/lib-contents.md

@@ -20,8 +20,10 @@ libs/museum-objects/
         └── lib/
             ├── objects.module.ts        # MuseumObjectsModule (references/module-and-routes.md)
             ├── objects.routes.ts
-            ├── components/              # description, filter-input (may extend FilterInputBaseComponent - its API is a subset), high-def-request-modal,
-            │                            #   menu, objects-searchbar (standalone, live search), tabs/*
+            ├── components/              # description, filters-top (extends ObjectsFiltersBarBaseComponent), high-def-request-modal,
+            │                            #   menu, objects-searchbar (only where the app renders the panel search), tabs/*;
+            │                            #   no filter-input (it comes from the shared lib); Podlasie-style apps also keep
+            │                            #   objects-search-panel and objects-advanced-filters (extend the framework bases)
             ├── pages/                   # list (ListComponent), item (ItemComponent) + index
             └── services/               # no local objects.service / object-media.service (framework ObjectsDataService, ObjectMediaService)
 ```
@@ -29,7 +31,10 @@ libs/museum-objects/
 `pages/list` extends `ObjectsCatalogBaseComponent` (logic only: first read, persistence, SSR read, read guard,
 load-more, masonry lifecycle, list SEO) and keeps the app's own markup and `sortOptions` over `isNewType`;
 `pages/item` extends `ObjectDetailsBaseComponent` (SSR SEO, scroll, visit counter, retry, opt-in related / related
-collections; the app keeps its markup). There is no local `objects.service` or `object-media.service`.
+collections; the app keeps its markup). `components/filters-top` extends `ObjectsFiltersBarBaseComponent` (cycle tags
+opt-in); `objects-search-panel` / `objects-advanced-filters` / `objects-share-results`, where an app has them, extend
+`ObjectsSearchPanelBaseComponent` / `ObjectsAdvancedFiltersBaseComponent` / `ObjectsShareResultsBaseComponent`
+(S/T-style museums use the filters bar only). There is no local `objects.service` or `object-media.service`.
 
 ## Domain entity (verbatim, thread nothing — pure types)
 

package/plugins/mobilems/skills/mobilems-objects/scripts/verify-module.sh

@@ -138,6 +138,35 @@ else
   pass "no hand-rolled visit counter, SSR apply or media service"
 fi
 
+# 7. filter bar logic lives in the framework filters bar base; no local copies of its helpers
+FILTERSF="$LIBDIR/components/filters-top/filters-top.component.ts"
+if [ -f "$FILTERSF" ]; then
+  if grep -qE "extends[[:space:]]+ObjectsFiltersBarBaseComponent" "$FILTERSF"; then
+    pass "filters-top extends ObjectsFiltersBarBaseComponent"
+  else
+    bad "components/filters-top/filters-top.component.ts does not extend ObjectsFiltersBarBaseComponent — filter bar logic belongs to the framework base ($FILTERSF)"
+  fi
+fi
+if grep -rqE "class RedirectFiltersContext|function buildObjectsResultsUrl" "$LIBDIR" 2>/dev/null; then
+  bad "lib contains class RedirectFiltersContext or function buildObjectsResultsUrl — use ObjectsFiltersBarBaseComponent / buildObjectsResultsUrl from the framework:"
+  grep -rnE "class RedirectFiltersContext|function buildObjectsResultsUrl" "$LIBDIR" >&2 || true
+else
+  pass "no hand-rolled redirect filters context or results URL builder"
+fi
+
+# 8. search panel and advanced filters (Podlasie-style apps only) extend the framework bases
+for pair in "objects-search-panel.component.ts:ObjectsSearchPanelBaseComponent" "objects-advanced-filters.component.ts:ObjectsAdvancedFiltersBaseComponent"; do
+  fname="${pair%%:*}"
+  base="${pair##*:}"
+  for found in $(find "$LIBDIR" -name "$fname" 2>/dev/null); do
+    if grep -qE "extends[[:space:]]+$base" "$found"; then
+      pass "$fname extends $base"
+    else
+      bad "$fname does not extend $base — its logic belongs to the framework base ($found)"
+    fi
+  done
+done
+
 echo "== Translations (REF_ROOT=${REF_ROOT:-unset}) =="
 # Groups: present in pl+en, no dead references, complete vs the reference repo
 # (export REF_ROOT=<reference-repo-root> to enable the completeness diff).

package/plugins/mobilems/skills/mobilems-project-init/references/shared-lib.md

@@ -57,6 +57,8 @@ not as copies of the reference logic. The museum keeps its own template and styl
 stores (favorites, selection, downloads, recommended items) stay in the museum and reach the base
 through its hooks (`IFavoriteHooks`, `ISelectionActionsFavorites`, `IRecommendedSources`, the abstract `downloadCardsExport`).
 
+A share-link button (e.g. `share-results`, collection share) extends `ShareLinkBaseComponent` (`SHARE_LINK_COPIED_TIMEOUT`): implement `shareLinkUrl()`, bind `share()` and `copied()`, write the markup yourself.
+
 The same applies to the foundation shared components `favorite-button`, `favorites-notice`,
 `selection-actions`, `download-cards` and `recommended`: extend `FavoriteButtonBaseComponent`,
 `FavoritesNoticeBaseComponent`, `SelectionActionsBaseComponent`, `DownloadCardsBaseComponent` and