@smartsoft001-mobilems/claude-plugins 2.119.0 → 2.120.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartsoft001-mobilems/claude-plugins",
-  "version": "2.119.0",
+  "version": "2.120.0",
   "publishConfig": {
     "access": "public"
   },

package/plugins/mobilems/.claude-plugin/plugin.json

@@ -1,5 +1,5 @@
 {
   "name": "mobilems",
   "description": "MobilEMS-specific Claude Code skills (MuzaCMS / MobileMS indexer API)",
-  "version": "2.119.0"
+  "version": "2.120.0"
 }

package/plugins/mobilems/skills/mobilems-object-collections/SKILL.md

@@ -34,12 +34,14 @@ list — re-implementing framework code is a defect, not a shortcut:
 2. [`packages/public-collections/README.md`](https://github.com/smartsoft001/mobilems-framework/blob/main/packages/public-collections/README.md) — this module's package catalog
 3. `libs/shared/angular/README.md` — the app's own shared lib (built by `mobilems-project-init`)
 
-| Do not hand-roll                                             | Use                                                                                                                               |
-| ------------------------------------------------------------ | --------------------------------------------------------------------------------------------------------------------------------- |
-| a masonry grid (`new Masonry(...)`, per-page masonry JS/CSS) | `<smart-mobilems-masonry-grid>` (`MasonryGridComponent`) with a `#masonryContentTpl`; the `Masonry` provider only feeds it        |
-| filter state / hand-built `query` arrays                     | `FiltersBaseComponent<PublicCollection>` + its `FiltersContext` accessors (`searchText`, `keywords`, `cycles`, `page`, `sort`, …) |
-| list/detail plumbing (facade wiring, id-from-route)          | the `PublicCollectionsListComponent` / `PublicCollectionsItemComponent` base classes                                              |
-| media URLs, meta/OG tags, filter dictionaries, modals, WCAG  | `FileUrlService`, `SeoService`/`MetaService`, `DictionaryService`, `ModalService`, `WcagService`                                  |
+| Do not hand-roll                                                                    | Use                                                                                                                                                        |
+| ----------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| a masonry grid (`new Masonry(...)`, per-page masonry JS/CSS)                        | `<smart-mobilems-masonry-grid>` (`MasonryGridComponent`) with a `#masonryContentTpl`; the `Masonry` provider only feeds it                                 |
+| filter state / hand-built `query` arrays                                            | `FiltersBaseComponent<PublicCollection>` + its `FiltersContext` accessors (`searchText`, `keywords`, `cycles`, `page`, `sort`, …)                          |
+| list page logic (first read, persistence, SSR read, read guard, load-more, tag bar) | `CollectionsCatalogBaseComponent` (extends `PublicCollectionsListComponent`; the page keeps its own markup)                                                |
+| collection page logic (paged items, sort/limit, 404 vs error, SEO, list mode)       | `CollectionDetailsBaseComponent` (extends `PublicCollectionsItemComponent`) + `PublicCollectionItemsService` (provided by `PublicCollectionsSharedModule`) |
+| list/detail plumbing (facade wiring, id-from-route)                                 | the `PublicCollectionsListComponent` / `PublicCollectionsItemComponent` base classes (already under the two catalog bases)                                 |
+| media URLs, meta/OG tags, filter dictionaries, modals, WCAG                         | `FileUrlService`, `SeoService`/`MetaService`, `DictionaryService`, `ModalService`, `WcagService`                                                           |
 
 Anything the framework genuinely lacks goes into `libs/shared/angular` **once** (and into its
 README) — never a per-module copy. `scripts/verify-module.sh` fails the run on hand-rolled masonry.
@@ -62,7 +64,7 @@ README) — never a per-module copy. `scripts/verify-module.sh` fails the run on
    `references/lib-contents.md`. The `museum-collections` commit scope registers automatically from the `libs/` dir name.
 3. **Module + routes** — see `references/module-and-routes.md`: `MuseumCollectionsModule` wraps
    `PublicCollectionsSharedModule.forFeature({ routing: false, config: { type: MuseumCollection, apiUrl, entity: 'publicCollections' } })`
-   with the `Masonry` SSR factory and the `CrudService → CollectionsService` provider. Add the lazy
+   with `provideBrowserMasonry()`. No `CollectionsService` — the framework `PublicCollectionsSharedModule` provides `PublicCollectionItemsService`. Add the lazy
    `kolekcje` route to `appRoutes` in `apps/web/src/app/app.routes.ts` and a matching child under the
    `wyszukaj/:text` search route.
 4. **Collections shared component** — see `references/shared-components.md`: build

package/plugins/mobilems/skills/mobilems-object-collections/references/lib-contents.md

@@ -20,10 +20,13 @@ libs/museum-collections/
             ├── collections.module.ts    # MuseumCollectionsModule (references/module-and-routes.md)
             ├── collections.routes.ts
             ├── components/              # filters (keywords/cycles) + index
-            ├── pages/                   # list (ListComponent), item (ItemComponent) + index
-            └── services/               # collections.service.ts + index
+            └── pages/                   # list (ListComponent), item (ItemComponent) + index
 ```
 
+There is no `services/` dir: the module declares no collections service (`PublicCollectionsSharedModule`
+provides `PublicCollectionItemsService`). `pages/list` extends `CollectionsCatalogBaseComponent` and
+`pages/item` extends `CollectionDetailsBaseComponent`; each keeps the app's own markup (the bases hold logic only).
+
 There are no `enums/`, `specifications/`, or `value-objects/` dirs in the domain — the connection
 shape (keywords/cycles) is inlined on the entity below.
 

package/plugins/mobilems/skills/mobilems-object-collections/references/module-and-routes.md

@@ -3,15 +3,14 @@
 ## `libs/museum-collections/shell/angular/src/lib/collections.module.ts`
 
 Thread `<PREFIX>` (the `environment` + domain imports). `PublicCollectionsSharedModule.forFeature`
-provides the list/detail behaviour over `MuseumCollection`; `CollectionsService` is provided as the
-`CrudService`; `provideBrowserMasonry()` supplies the real library in the browser and `null` during
+provides the list/detail behaviour over `MuseumCollection` (including `PublicCollectionItemsService`, so the
+module declares no collections service of its own); `provideBrowserMasonry()` supplies the real library in the browser and `null` during
 SSR (the grid then skips layout). Note: unlike the objects module this one does NOT import `SmartSharedModule`.
 
 ```ts
 import { NgModule } from '@angular/core';
 import { FormsModule } from '@angular/forms';
 import { RouterModule } from '@angular/router';
-import { CrudService } from '@smartsoft001/crud-shell-angular';
 import { PublicCollectionsSharedModule } from '@smartsoft001-mobilems/public-collections-shell-angular';
 import { provideBrowserMasonry } from '@smartsoft001-mobilems/angular';
 
@@ -19,17 +18,9 @@ import { environment } from '@<PREFIX>/angular';
 import { MuseumCollection } from '@<PREFIX>/museum-collections/domain';
 
 import { routes } from './collections.routes';
-import { CollectionsService } from './services';
 
 @NgModule({
-  providers: [
-    CollectionsService,
-    {
-      provide: CrudService,
-      useClass: CollectionsService,
-    },
-    provideBrowserMasonry(),
-  ],
+  providers: [provideBrowserMasonry()],
   imports: [
     FormsModule,
     PublicCollectionsSharedModule.forFeature({

package/plugins/mobilems/skills/mobilems-object-collections/scripts/verify-module.sh

@@ -102,6 +102,27 @@ else
   pass "no filters component in this module"
 fi
 
+# 5. page logic lives in the framework catalog bases — the pages only add markup
+for pair in "list:CollectionsCatalogBaseComponent" "item:CollectionDetailsBaseComponent"; do
+  pdir="${pair%%:*}"; base="${pair#*:}"
+  pf="$LIBDIR/pages/$pdir/$pdir.component.ts"
+  if [ -f "$pf" ]; then
+    if grep -qE "extends[[:space:]]+$base" "$pf"; then
+      pass "pages/$pdir extends $base"
+    else
+      bad "pages/$pdir/$pdir.component.ts does not extend $base — page logic belongs to the framework base ($pf)"
+    fi
+  fi
+done
+# 6. no module-level CollectionsService that only re-declares getItems
+CS="$(grep -rlE "class[[:space:]]+CollectionsService" "$LIBDIR" 2>/dev/null | xargs grep -lE "getItems" 2>/dev/null || true)"
+if [ -n "$CS" ]; then
+  bad "module-level CollectionsService re-declares getItems — drop it, PublicCollectionItemsService covers it:"
+  printf '        %s\n' $CS >&2
+else
+  pass "no module-level CollectionsService re-declaring getItems"
+fi
+
 echo "== Translations (REF_ROOT=${REF_ROOT:-unset}) =="
 # Groups: present in pl+en, no dead references, complete vs the reference repo
 # (export REF_ROOT=<reference-repo-root> to enable the completeness diff).