@smartmemory/compose 0.2.49-beta → 0.2.51-beta

package/server/vision-routes.js

@@ -42,7 +42,10 @@ function getSchemaValidator() {
 }
 
 import { randomUUID } from 'node:crypto';
-import { getTargetRoot, resolveProjectPath, loadProjectConfig } from './project-root.js';
+import { getTargetRoot, resolveProjectPath } from './project-root.js';
+import { resolveFeaturesPathFromConfig } from '../lib/project-paths.js';
+import { getCompletions } from '../lib/completion-writer.js';
+import { isFeatureCode } from '../lib/feature-code.js';
 import { anchorBoundary } from '../lib/checkpoint/checkpoint-writer.js';
 import { appendGateLogEntry, readGateLog, mapResolveOutcomeToSchema } from './gate-log-store.js';
 import { addOpenLoop, resolveOpenLoop, listOpenLoops } from './open-loops-store.js';
@@ -55,6 +58,20 @@ import { requireSensitiveOrPaired as requireSensitiveToken } from './security.js
 
 const PROJECT_ROOT = getTargetRoot();
 
+/**
+ * Read the compose.json config for an ARBITRARY workspace root (not the bound
+ * target). The alternate-root lifecycle branch must resolve `paths.features`
+ * against that root's own config, not the process-global cache
+ * (COMP-PATHS-EXTERNAL, Decision 1 / Codex finding 3).
+ */
+function loadComposeConfig(root) {
+  try {
+    return JSON.parse(fs.readFileSync(path.join(root, '.compose', 'compose.json'), 'utf-8'));
+  } catch {
+    return {};
+  }
+}
+
 /**
  * Attach vision CRUD and lifecycle REST routes to an Express app.
  *
@@ -78,6 +95,33 @@ export function attachVisionRoutes(app, { store, scheduleBroadcast, broadcastMes
   const guardAuthEnabled = capabilities?.guardAuth === true;
   const guardAuth = (req, res, next) =>
     guardAuthEnabled ? requireSensitiveToken(req, res, next) : next();
+
+  // PARITY-5: GET /api/completions — read-only recorded-completion log for a
+  // feature. Reads are open (not guardAuth-wrapped); wraps the same
+  // getCompletions() the CLI uses so the cockpit and CLI agree byte-for-byte.
+  app.get('/api/completions', (req, res) => {
+    try {
+      const opts = {};
+      const fc = req.query.featureCode;
+      if (typeof fc === 'string' && fc) {
+        // This route is open (no auth) and feature_code is join()'d into a
+        // filesystem path downstream (feature-json.js#readFeature). Reject
+        // anything that isn't a canonical feature code so `../`-style traversal
+        // can't read feature.json outside the features dir.
+        if (!isFeatureCode(fc)) {
+          return res.status(400).json({ error: 'invalid featureCode' });
+        }
+        opts.feature_code = fc;
+      }
+      const rawLimit = parseInt(req.query.limit, 10);
+      if (Number.isFinite(rawLimit)) opts.limit = rawLimit;
+      const result = getCompletions(getTargetRoot(), opts);
+      res.json(result);
+    } catch (err) {
+      res.status(400).json({ error: err.message || String(err) });
+    }
+  });
+
   // GET /api/vision/items — full state (optional ?group= filter)
   app.get('/api/vision/items', (req, res) => {
     let state = store.getState();
@@ -167,7 +211,7 @@ export function attachVisionRoutes(app, { store, scheduleBroadcast, broadcastMes
 
   // ── Lifecycle endpoints (simplified — no state machine) ──────────────
   const featuresPath = projectRoot !== PROJECT_ROOT
-    ? path.join(projectRoot, loadProjectConfig().paths?.features || 'docs/features')
+    ? resolveFeaturesPathFromConfig(projectRoot, loadComposeConfig(projectRoot))
     : resolveProjectPath('features');
 
   // Phase graph + SKIPPABLE + TERMINAL are owned by lifecycle-guard.js (single

package/server/vision-server.js

@@ -27,11 +27,15 @@ import { attachSessionRoutes } from './session-routes.js';
 import { attachActivityRoutes } from './activity-routes.js';
 import { SettingsStore } from './settings-store.js';
 import { attachSettingsRoutes } from './settings-routes.js';
+import { attachHealthRoutes } from './health-routes.js';
+import { attachValidateRoutes } from './validate-routes.js';
+import { attachQaScopeRoutes } from './qa-scope-routes.js';
 import { attachDesignRoutes } from './design-routes.js';
 import { DesignSessionManager } from './design-session.js';
 import { attachPipelineRoutes } from './pipeline-routes.js';
 import { attachIdeaboxRoutes } from './ideabox-routes.js';
 import { attachBuildRoutes } from './build-routes.js';
+import { attachFeatureScaffoldRoutes } from './feature-scaffold-routes.js';
 import { attachJournalRoutes } from './journal-routes.js';
 import { CoalescingBuffer } from './coalescing-buffer.js';
 /** Settings defaults (previously derived from contracts/lifecycle.json). */
@@ -55,7 +59,8 @@ const SETTINGS_DEFAULTS = {
   policyModes: ['gate', 'flag', 'skip'],
 };
 
-import { getTargetRoot, getDataDir } from './project-root.js';
+import { getTargetRoot, getDataDir, resolveProjectPath } from './project-root.js';
+import { relForDisplay } from '../lib/project-paths.js';
 
 export class VisionServer {
   constructor(store, sessionManager = null, { config } = {}) {
@@ -84,6 +89,19 @@ export class VisionServer {
       broadcastMessage: (msg) => this.broadcastMessage(msg),
     });
 
+    // ── Environment-health route (COMP-PARITY-3) ──────────────────────────
+    // Read-only GET /api/environment-health; resolves its own compose package
+    // root + composeBin/Node defaults, reads hooks off req.workspace.
+    attachHealthRoutes(app);
+
+    // ── Cross-artifact validation findings (COMP-PARITY-6) ─────────────────
+    // Read-only GET /api/validate; reads workspace off req.workspace.
+    attachValidateRoutes(app);
+
+    // ── QA-scope affected-routes panel (COMP-PARITY-10) ────────────────────
+    // Read-only GET /api/qa-scope?featureCode=…; reads off req.workspace.
+    attachQaScopeRoutes(app);
+
     // ── Vision CRUD + lifecycle routes ─────────────────────────────────────
     attachVisionRoutes(app, {
       store: this.store,
@@ -151,6 +169,10 @@ export class VisionServer {
     // ── Build start/abort routes (sensitive) ───────────────────────────────
     attachBuildRoutes(app);
 
+    // ── Feature scaffolding (COMP-PARITY-9, sensitive) ─────────────────────
+    // POST /api/features/scaffold — writes feature.json + a ROADMAP row.
+    attachFeatureScaffoldRoutes(app, { getProjectRoot: () => getTargetRoot() });
+
     // ── Build state hydration ─────────────────────────────────────────────
     app.get('/api/build/state', (_req, res) => {
       const buildPath = path.join(getDataDir(), 'active-build.json');
@@ -264,7 +286,7 @@ export class VisionServer {
         const projectsRoot = process.env.CC_PROJECTS_ROOT ||
           path.join(process.env.HOME || process.env.USERPROFILE || '', '.claude', 'projects');
         const sessionsFile = this.sessionManager?.sessionsFile || path.join(getDataDir(), 'sessions.json');
-        const featureRoot = path.join(getTargetRoot(), 'docs', 'features');
+        const featureRoot = resolveProjectPath('features');
 
         const findItemIdByFeatureCode = (fc) => {
           for (const it of this.store.items.values()) {
@@ -457,7 +479,7 @@ export class VisionServer {
   /** Resolve a file path to matching tracker items */
   resolveItems(filePath) {
     const rel = filePath.startsWith(getTargetRoot())
-      ? filePath.slice(getTargetRoot().length + 1)
+      ? relForDisplay(getTargetRoot(), filePath)
       : filePath.replace(/^\.\//, '');
     const matches = [];
     const matchType = new Map();

package/server/vision-utils.js

@@ -10,10 +10,25 @@ import fs from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 
-import { getTargetRoot, loadProjectConfig } from './project-root.js';
+import { getTargetRoot } from './project-root.js';
+import { resolveJournalPathFromConfig, relForDisplay } from '../lib/project-paths.js';
 
 const PROJECT_ROOT = getTargetRoot();
 
+/**
+ * Read the compose.json config for an ARBITRARY workspace root (not the bound
+ * target). Routes/agents that serve an alternate `projectRoot` must resolve
+ * artifact paths against that root's own config, not the process-global cache
+ * (COMP-PATHS-EXTERNAL, Decision 1 / Codex finding 3).
+ */
+function loadComposeConfig(root) {
+  try {
+    return JSON.parse(fs.readFileSync(path.join(root, '.compose', 'compose.json'), 'utf-8'));
+  } catch {
+    return {};
+  }
+}
+
 // ---------------------------------------------------------------------------
 // Error detection
 // ---------------------------------------------------------------------------
@@ -71,8 +86,12 @@ export function detectError(tool, input, responseText) {
  * @param {string} [projectRoot] — defaults to PROJECT_ROOT
  */
 export function spawnJournalAgent(session, transcriptPath, projectRoot = PROJECT_ROOT) {
-  const config = loadProjectConfig();
-  const journalRel = config.paths?.journal || 'docs/journal';
+  // Resolve the journal path against the PASSED projectRoot's own config — not
+  // the process-global cached config of the bound target (COMP-PATHS-EXTERNAL).
+  const journalAbs = resolveJournalPathFromConfig(projectRoot, loadComposeConfig(projectRoot));
+  // Display path for the agent prompt: clean relative when in-root (the agent
+  // runs with cwd: projectRoot), absolute when the journal escapes the root.
+  const journalRel = relForDisplay(projectRoot, journalAbs);
 
   const itemSummaries = Object.entries(session.items || {})
     .map(([_id, data]) => `- ${data.title}: ${data.writes} writes, ${data.reads} reads. ${(data.summaries || []).map(s => s.summary || '').filter(Boolean).join('. ')}`)
@@ -88,7 +107,7 @@ export function spawnJournalAgent(session, transcriptPath, projectRoot = PROJECT
   const today = new Date().toISOString().slice(0, 10);
   let sessionNum = 0;
   try {
-    const entries = fs.readdirSync(path.join(projectRoot, journalRel));
+    const entries = fs.readdirSync(journalAbs);
     for (const f of entries) {
       const m = f.match(new RegExp(`^${today}-session-(\\d+)`));
       if (m) sessionNum = Math.max(sessionNum, parseInt(m[1]) + 1);