@smartmemory/compose 0.2.16-beta → 0.2.17-beta

package/lib/feature-validator.js

@@ -300,6 +300,15 @@ function finding(severity, kind, code, detail, source) {
   return f;
 }
 
+// A code owned by another repo (matches a declared externalPrefix, e.g. STRAT-*)
+// is a cross-repo REFERENCE. Compose can validate that the reference resolves, but
+// not the external feature's local artifacts, completion records, folder layout,
+// row-schema, or authoritative status — all of which live in the owning repo. The
+// per-feature local-correspondence checks consult this and skip such codes.
+function isExternalCode(code, ctx) {
+  return !!code && (ctx?.externalPrefixes || []).some((p) => code.startsWith(p));
+}
+
 // ---------------------------------------------------------------------------
 // Per-feature checks
 // ---------------------------------------------------------------------------
@@ -373,7 +382,7 @@ function runSchemaChecks(fctx, ctx, findings) {
       }
     }
   }
-  if (roadmap) {
+  if (roadmap && !isExternalCode(code, ctx)) {
     const v = getValidator(ROADMAP_ROW_SCHEMA);
     const r = v.validateRoot(roadmap);
     if (!r.valid) {
@@ -401,8 +410,11 @@ function projectToVisionStatus(s) {
   return s === 'PARTIAL' ? 'IN_PROGRESS' : s;
 }
 
-function runStateMismatchChecks(fctx, findings) {
+function runStateMismatchChecks(fctx, ctx, findings) {
   const { code, roadmap, vision, featureJson } = fctx;
+  // Compose is not the authority on an external feature's status — its ROADMAP/
+  // vision rows are cross-repo mirrors that may legitimately lag the owning repo.
+  if (isExternalCode(code, ctx)) return;
   const rStatus = normalizeStatus(roadmap?.status);
   const fStatus = normalizeStatus(featureJson?.status);
   const vStatus = normalizeStatus(vision?.status);
@@ -471,21 +483,18 @@ function runFolderRoadmapLinkageChecks(fctx, ctx, findings) {
   const { code, folder, roadmap, vision, featureJson } = fctx;
   const rStatus = normalizeStatus(roadmap?.status);
 
+  // Externally-owned codes (e.g. STRAT-*) are cross-repo references whose folder,
+  // artifacts, and row layout live in the owning project — folder-linkage does not
+  // apply, so skip the whole check (row↔folder, folder↔row, empty-folder).
+  if (isExternalCode(code, ctx)) return;
+
   if (roadmap && !folder) {
-    // Externally-owned rows (code matches an externalPrefix, e.g. STRAT-*) are
-    // cross-repo references whose folder lives in the owning project — folder
-    // linkage does not apply, so emit nothing. (Asymmetric with the external
-    // *folder* case below, which downgrades to info: an external folder present
-    // locally is unusual; an external row without a local folder is the norm.)
-    const isExternal = ctx.externalPrefixes.some((p) => code.startsWith(p));
-    if (isExternal) {
-      // no finding — out of scope for folder-linkage validation
-    } else if (rStatus === 'IN_PROGRESS') {
-      // Severity model for missing folder:
-      //   IN_PROGRESS         → error (active work without a tracking artifact)
-      //   PARTIAL / BLOCKED   → warning (sub-tickets may live elsewhere; partial progress)
-      //   PLANNED             → warning (un-started work)
-      //   COMPLETE / SUPERSEDED / KILLED / PARKED / unknown → warning (historical baseline)
+    // Severity model for missing folder:
+    //   IN_PROGRESS         → error (active work without a tracking artifact)
+    //   PARTIAL / BLOCKED   → warning (sub-tickets may live elsewhere; partial progress)
+    //   PLANNED             → warning (un-started work)
+    //   COMPLETE / SUPERSEDED / KILLED / PARKED / unknown → warning (historical baseline)
+    if (rStatus === 'IN_PROGRESS') {
       findings.push(finding('error', 'ROADMAP_ROW_WITHOUT_FOLDER', code,
         `ROADMAP row status is IN_PROGRESS (active work) but no folder exists`));
     } else {
@@ -519,6 +528,8 @@ function runFolderRoadmapLinkageChecks(fctx, ctx, findings) {
 function runArtifactLinkChecks(fctx, ctx, findings) {
   const { code, folder, featureJson } = fctx;
   if (!folder) return;
+  // External features keep their design/report/artifacts in the owning repo.
+  if (isExternalCode(code, ctx)) return;
   const featureRootArg = ctx.paths.features;
   const am = new ArtifactManager(featureRootArg);
   let assessment = null;
@@ -607,6 +618,9 @@ function runCrossFeatureRefChecks(fctx, ctx, findings) {
 
 function runCoherenceChecks(fctx, ctx, findings) {
   const { code, featureJson } = fctx;
+  // External features record their changelog/journal in the owning repo, so
+  // compose can't (and shouldn't) assert those entries exist here.
+  if (isExternalCode(code, ctx)) return;
   // COMPLETION_WITHOUT_CHANGELOG — check at project level, but per-feature too
   const status = effectiveStatus(fctx, ctx);
   if (status === 'COMPLETE' || status === 'PARTIAL') {
@@ -663,6 +677,9 @@ function runChangelogReferenceCheck(ctx, findings) {
   let m;
   while ((m = headerRe.exec(text))) {
     const code = m[1];
+    // External codes (e.g. STRAT-*) are legitimately referenced in compose's
+    // CHANGELOG without a local folder/row — their home is the owning repo.
+    if (isExternalCode(code, ctx)) continue;
     if (!ctx.roadmapByCode.has(code) && !ctx.foldersByCode.has(code) && !ctx.visionByCode.has(code)) {
       // Downgraded from error: many shipped features have CHANGELOG entries without
       // ROADMAP rows or vision-state items (legacy pattern where CHANGELOG is the
@@ -729,7 +746,7 @@ export async function validateFeature(cwd, code, options = {}) {
   }
 
   runSchemaChecks(fctx, ctx, findings);
-  runStateMismatchChecks(fctx, findings);
+  runStateMismatchChecks(fctx, ctx, findings);
   runFolderRoadmapLinkageChecks(fctx, ctx, findings);
   runArtifactLinkChecks(fctx, ctx, findings);
   runCrossFeatureRefChecks(fctx, ctx, findings);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartmemory/compose",
-  "version": "0.2.16-beta",
+  "version": "0.2.17-beta",
   "description": "Structured AI dev pipeline — goal-to-product orchestration with gates, iteration loops, and feature lifecycle management.",
   "author": "SmartMemory",
   "license": "MIT",