@smartmemory/compose 0.1.6-beta → 0.1.8-beta

package/server/schema-validator.js

@@ -5,26 +5,43 @@ import Ajv from 'ajv';
 import addFormats from 'ajv-formats';
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
-const SCHEMA_PATH = resolve(__dirname, '../contracts/comp-obs-contract.schema.json');
+const DEFAULT_SCHEMA_PATH = resolve(__dirname, '../contracts/comp-obs-contract.schema.json');
 
-let cached = null;
+// Per-path cache. Each entry: { schema, ajv }.
+const cache = new Map();
 
-function load() {
-  if (cached) return cached;
-  const schema = JSON.parse(readFileSync(SCHEMA_PATH, 'utf8'));
+function load(schemaPath = DEFAULT_SCHEMA_PATH) {
+  if (cache.has(schemaPath)) return cache.get(schemaPath);
+  const schema = JSON.parse(readFileSync(schemaPath, 'utf8'));
   const ajv = new Ajv({ strict: false, allErrors: true });
   addFormats(ajv);
   ajv.addSchema(schema);
-  cached = { schema, ajv };
-  return cached;
+  const entry = { schema, ajv };
+  cache.set(schemaPath, entry);
+  return entry;
+}
+
+/**
+ * Load (and cache) a schema by absolute path. Returns `{ schema, ajv }`.
+ * Used by code that wants to compile arbitrary `$ref`s against the schema
+ * without going through the SchemaValidator class.
+ */
+export function loadSchema(schemaPath) {
+  return load(schemaPath);
 }
 
 export class SchemaValidator {
-  constructor() {
-    const { schema, ajv } = load();
+  /**
+   * @param {string} [schemaPath] Absolute path to a JSON Schema file.
+   *   Default is the comp-obs-contract schema (back-compat for existing
+   *   callers that pass no args).
+   */
+  constructor(schemaPath = DEFAULT_SCHEMA_PATH) {
+    const { schema, ajv } = load(schemaPath);
     this.schema = schema;
     this.ajv = ajv;
     this._validators = new Map();
+    this._rootValidator = null;
   }
 
   _getValidator(defName) {
@@ -39,11 +56,35 @@ export class SchemaValidator {
     return v;
   }
 
+  /**
+   * Validate `obj` against `schema.definitions[defName]`. Used by the
+   * comp-obs-contract code paths.
+   */
   validate(defName, obj) {
     const v = this._getValidator(defName);
     const valid = v(obj);
     return { valid: !!valid, errors: valid ? [] : (v.errors || []) };
   }
+
+  /**
+   * Validate `obj` against the schema's root (no $defs/$ref indirection).
+   * Used by feature-json / vision-state / roadmap-row schemas, which are
+   * top-level shapes without nested definitions.
+   */
+  validateRoot(obj) {
+    if (!this._rootValidator) {
+      // ajv.getSchema by $id returns the root validator if the schema was
+      // added via addSchema (which load() does).
+      let v = this.schema.$id ? this.ajv.getSchema(this.schema.$id) : null;
+      if (!v) v = this.ajv.compile(this.schema);
+      this._rootValidator = v;
+    }
+    const v = this._rootValidator;
+    const valid = v(obj);
+    return { valid: !!valid, errors: valid ? [] : (v.errors || []) };
+  }
 }
 
+// Back-compat export — points at the comp-obs schema version. Existing
+// callers consuming SCHEMA_VERSION continue to work unchanged.
 export const SCHEMA_VERSION = load().schema.version;

package/server/vision-routes.js

@@ -338,7 +338,7 @@ export function attachVisionRoutes(app, { store, scheduleBroadcast, broadcastMes
     }
   });
 
-  app.post('/api/vision/items/:id/lifecycle/complete', (req, res) => {
+  app.post('/api/vision/items/:id/lifecycle/complete', async (req, res) => {
     try {
       const item = store.items.get(req.params.id);
       if (!item?.lifecycle) return res.status(404).json({ error: 'No lifecycle on this item' });
@@ -360,7 +360,56 @@ export function attachVisionRoutes(app, { store, scheduleBroadcast, broadcastMes
       emitDriftAxes(broadcastMessage, store, item, projectRoot, now);
       // COMP-OBS-STATUS: emit status snapshot after lifecycle transition (complete)
       emitStatusSnapshot(broadcastMessage, store, item.lifecycle.featureCode, now);
-      res.json({ completedAt: now });
+
+      // COMP-MCP-MIGRATION: reconcile cockpit complete with record_completion
+      // (commit-bound completion writer). Best-effort: failures emit a decision
+      // event but never roll back the lifecycle transition.
+      const featureCode = item.lifecycle.featureCode;
+      const completionResult = { partial: false };
+      if (featureCode) {
+        const { commit_sha, tests_pass, files_changed, notes } = req.body || {};
+        if (commit_sha) {
+          try {
+            const { recordCompletion } = await import('../lib/completion-writer.js');
+            await recordCompletion(projectRoot, {
+              feature_code: featureCode,
+              commit_sha,
+              tests_pass: tests_pass ?? true,
+              files_changed: files_changed ?? [],
+              notes: notes ?? `cockpit lifecycle: ${featureCode} complete`,
+            });
+          } catch (err) {
+            completionResult.partial = true;
+            const eventType = err.code === 'STATUS_FLIP_AFTER_COMPLETION_RECORDED'
+              ? 'cockpit_completion_partial_status_flip'
+              : 'cockpit_completion_failed';
+            completionResult.completion_failed = err.code || 'UNKNOWN';
+            completionResult.message = err.message;
+            try {
+              emitDecisionEvent(broadcastMessage, {
+                type: eventType,
+                featureCode,
+                timestamp: now,
+                error: { code: err.code, message: err.message },
+              });
+            } catch { /* decision event emit best-effort */ }
+            // eslint-disable-next-line no-console
+            console.warn(`[lifecycle/complete] record_completion ${eventType} for ${featureCode}: ${err.message}`);
+          }
+        } else {
+          // No SHA — emit a skip event so validate_feature can flag drift later
+          try {
+            emitDecisionEvent(broadcastMessage, {
+              type: 'cockpit_completion_skipped',
+              featureCode,
+              timestamp: now,
+              reason: 'no_commit_sha',
+            });
+          } catch { /* decision event emit best-effort */ }
+        }
+      }
+
+      res.json({ completedAt: now, ...completionResult });
     } catch (err) {
       const status = err.message.includes('not found') ? 404 : 400;
       res.status(status).json({ error: err.message });

package/templates/ROADMAP.md

@@ -5,6 +5,7 @@
 
 ---
 
+<!-- preserved-section: roadmap-conventions -->
 ## Roadmap Conventions
 
 - **Status:** `PLANNED` | `IN_PROGRESS` | `PARTIAL` | `COMPLETE` | `SUPERSEDED` | `PARKED`
@@ -12,6 +13,8 @@
 - Items are numbered sequentially across all phases — never reuse a number.
 - Cross-reference stable IDs (e.g. `FEAT-1`, `Phase 2`) not section headings.
 
+<!-- /preserved-section -->
+
 ---
 
 ## Phase 1: Foundation — PLANNED
@@ -37,6 +40,7 @@ Bootstrap: establish the core structure and first working milestone.
 
 ---
 
+<!-- preserved-section: dogfooding-milestones -->
 ## Dogfooding Milestones
 
 | Milestone | Description | Status |
@@ -44,3 +48,5 @@ Bootstrap: establish the core structure and first working milestone.
 | D0: Bootstrap | Manual, out-of-band. | PLANNED |
 | D1: [First self-use milestone] | [Description] | PLANNED |
 | D2: [Second self-use milestone] | [Description] | PLANNED |
+
+<!-- /preserved-section -->

package/dist/assets/channel-LRG9kHqJ.js

@@ -1 +0,0 @@
-import{aq as o,ar as n}from"./index-DkRKLuNr.js";const t=(r,a)=>o.lang.round(n.parse(r)[a]);export{t as c};

package/dist/assets/classDiagram-6PBFFD2Q-BC9a6pDE.js

@@ -1 +0,0 @@
-import{s as a,c as s,a as e,C as t}from"./chunk-4TB4RGXK-BdlMSdEA.js";import{_ as i}from"./index-DkRKLuNr.js";import"./chunk-FMBD7UC4-Cd6Hrux2.js";import"./chunk-YZCP3GAM-DFN9X99H.js";import"./chunk-55IACEB6-vrQHZTdv.js";import"./chunk-EDXVE4YY-B8wioVlW.js";var u={parser:e,get db(){return new t},renderer:s,styles:a,init:i(r=>{r.class||(r.class={}),r.class.arrowMarkerAbsolute=r.arrowMarkerAbsolute},"init")};export{u as diagram};

package/dist/assets/classDiagram-v2-HSJHXN6E-BC9a6pDE.js

@@ -1 +0,0 @@
-import{s as a,c as s,a as e,C as t}from"./chunk-4TB4RGXK-BdlMSdEA.js";import{_ as i}from"./index-DkRKLuNr.js";import"./chunk-FMBD7UC4-Cd6Hrux2.js";import"./chunk-YZCP3GAM-DFN9X99H.js";import"./chunk-55IACEB6-vrQHZTdv.js";import"./chunk-EDXVE4YY-B8wioVlW.js";var u={parser:e,get db(){return new t},renderer:s,styles:a,init:i(r=>{r.class||(r.class={}),r.class.arrowMarkerAbsolute=r.arrowMarkerAbsolute},"init")};export{u as diagram};

package/dist/assets/clone-dRxgFrBv.js

@@ -1 +0,0 @@
-import{b as r}from"./graph-CRnO_ifT.js";var e=4;function a(o){return r(o,e)}export{a as c};

package/dist/assets/stateDiagram-v2-QKLJ7IA2-BW0ezXb4.js

@@ -1 +0,0 @@
-import{s as t,b as r,a,S as s}from"./chunk-OYMX7WX6-CfrhdQXY.js";import{_ as i}from"./index-DkRKLuNr.js";import"./chunk-55IACEB6-vrQHZTdv.js";import"./chunk-EDXVE4YY-B8wioVlW.js";var l={parser:a,get db(){return new s(2)},renderer:r,styles:t,init:i(e=>{e.state||(e.state={}),e.state.arrowMarkerAbsolute=e.arrowMarkerAbsolute},"init")};export{l as diagram};