@smartledger/bsv 9.16.0 → 9.16.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -7,6 +7,98 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
7
7
 
8
8
  ## [Unreleased]
9
9
 
10
+ ## [9.16.1] - 2026-10-01
11
+
12
+ Three resource and validation defects in the shift and binary-conversion opcodes, found by a
13
+ differential fuzzer run against this package and by independent review of the first fix. The
14
+ conformance corpus passes 1483/1483 before and after: every one of these was invisible to it.
15
+
16
+ ### Security — `OP_LSHIFT` and `OP_RSHIFT` did work proportional to the shift COUNT
17
+
18
+ Both built the shifted value as a bignum and then truncated it, so `ushln(n)` allocated a value of
19
+ the shifted width — the count's magnitude, not the operand's. A short script could therefore buy
20
+ an unbounded amount of work from a verifier, in **every era**, since a count of 2^31-1 fits the
21
+ four bytes allowed before Genesis, and `IsOpcodeDisabled` in the node disables only `OP_2MUL`
22
+ and `OP_2DIV` — never the shifts. Confirmed by execution: a pre-Genesis `OP_LSHIFT` with a count
23
+ of 2^31-1 is accepted and returns one zero byte. Past a certain count the implied length is not a valid array
24
+ length and bn.js raised a `RangeError`, which the evaluator reported as
25
+ `SCRIPT_ERR_UNKNOWN_ERROR`. **That is a false reject**, not merely a slow one: the node returns
26
+ zero bytes for the same script, so this library refused spends the node accepts. So the path had
27
+ two faults at once — unbounded work, and a wrong verdict in the direction of refusal. No false
28
+ accept was found on this path; the false accept in this release is the separate empty-operand bug
29
+ below.
30
+
31
+ Both opcodes now follow the node's shape, which bounds the work by the operand:
32
+
33
+ ```cpp
34
+ CScriptNum n{top, requireMinimal, params.MaxScriptNumLength(), utxo_after_genesis};
35
+ if(n < 0) return SCRIPT_ERR_INVALID_NUMBER_RANGE;
36
+ if(n >= values.size() * bits_per_byte) fill(begin(values), end(values), 0);
37
+ else { ... LShift(values, n.getint()) ... }
38
+ ```
39
+
40
+ The count is compared as a bignum before any narrowing, and a shift reaching the operand's full
41
+ width returns that many zero bytes directly. The node's `LShift` allocates
42
+ `valtype result(x.size(), 0x00)` and loops over `x.size()`; nothing it allocates follows the
43
+ count. Verified against the previous implementation on 719,360 operand-and-count pairs — every value at
44
+ operand lengths 1 to 4, sampled above 4096 per length, at every count from 0 to 8·len+4, both
45
+ directions — and against an independent bit-string model. That equivalence covers the **valid
46
+ counts for which the previous implementation completed**, and over those the output is
47
+ byte-identical. It deliberately does not cover the counts that previously threw, or the
48
+ empty-operand counts in the next section, where the verdict changes on purpose; both are covered
49
+ by their own tests.
50
+
51
+ ### Security — an invalid shift count was accepted whenever the operand was empty
52
+
53
+ Both opcodes short-circuited when the value being shifted was empty, popping the count without
54
+ decoding it, and therefore without any of its three checks. A negative count, a count too wide for
55
+ the era, and a non-minimally-encoded count were all accepted, where the node refuses each by name.
56
+ **A false accept.** The node's only guard before the decode is `stack.size() < 2`, and it checks
57
+ `n < 0` before it reads the operand at all.
58
+
59
+ This one was found by review of the first shift fix, which corrected the cost and left this in
60
+ place.
61
+
62
+ ### Fixed — `OP_NUM2BIN`'s size was not bounded by `INT32_MAX`
63
+
64
+ The node caps it in every era, **before** the element-size test:
65
+
66
+ ```cpp
67
+ if(n < 0 || n > std::numeric_limits<int32_t>::max()) return SCRIPT_ERR_PUSH_SIZE;
68
+ const auto size{n.to_size_t_limited()};
69
+ if(!utxo_after_genesis && (size > MAX_SCRIPT_ELEMENT_SIZE_BEFORE_GENESIS))
70
+ return SCRIPT_ERR_PUSH_SIZE;
71
+ ```
72
+
73
+ The era only widens the second test; the first is fixed. Without it a size above `INT32_MAX`
74
+ passed the post-Genesis element check, which is effectively unbounded, and the allocation that
75
+ followed was proportional to the operand's **value** rather than its length. A size the node
76
+ refuses without allocating is now refused the same way, and the bound is checked on the bignum
77
+ before narrowing, because `toNumber()` rounds past 2^53 and returns `Infinity` at extreme widths
78
+ rather than failing.
79
+
80
+ **This cap matches the node; it does not make the opcode cheap.** A size just under `INT32_MAX` is
81
+ consensus-valid and still requests an allocation approaching 2 GB, from a script of a few bytes —
82
+ so a limit on script size does not address it. **This release adds no execution or allocation
83
+ budget, and this package enforces none.** Evaluating untrusted scripts therefore needs a bound on
84
+ execution resources, not just on input size: run it in a process whose memory and CPU time are
85
+ capped, or do not evaluate untrusted scripts in a process you need to keep alive.
86
+
87
+ ### Note on `OP_DIV` and `OP_MOD`
88
+
89
+ Both are quadratic in operand length. **This is not a consensus divergence, and it is not fixed in
90
+ this release.** The node shares the shape: `OP_DIV`/`OP_MOD` are bounded only by
91
+ `params.MaxScriptNumLength()` and its `bsv::bint` division is also schoolbook, so verdicts and
92
+ bounds match and changing ours would diverge from consensus.
93
+
94
+ Parity settles the verdict, not the cost. **Quadratic CPU exhaustion remains a risk when
95
+ evaluating attacker-controlled scripts**, and the node's practical protection is policy rather
96
+ than consensus — `DEFAULT_MAX_SCRIPT_SIZE_POLICY_AFTER_GENESIS` of 500 KB and
97
+ `DEFAULT_STACK_MEMORY_USAGE_POLICY_AFTER_GENESIS` of 100 MB. Neither is a CPU-time bound, and this
98
+ package enforces neither. Measured here: 320 KB of operand takes about 18 seconds, growing by
99
+ roughly 4× per doubling. Bound execution resources yourself, as above. An opt-in budget is under
100
+ consideration and will not change default behaviour.
101
+
10
102
  ## [9.16.0] - 2026-10-01
11
103
 
12
104
  ### Security — `OP_CHECKMULTISIG`'s counts were decoded with the era's length, not four bytes
package/README.md CHANGED
@@ -2,7 +2,7 @@
2
2
 
3
3
  Bitcoin SV library with an interpreter-verified script engine.
4
4
 
5
- [![Version](https://img.shields.io/badge/version-9.16.0-blue.svg)](https://www.npmjs.com/package/@smartledger/bsv)
5
+ [![Version](https://img.shields.io/badge/version-9.16.1-blue.svg)](https://www.npmjs.com/package/@smartledger/bsv)
6
6
  [![License](https://img.shields.io/badge/license-MIT-green.svg)](LICENSE)
7
7
  [![Stability](https://img.shields.io/badge/9.x%20stable%20until-2027--09--01-brightgreen.svg)](STABILITY.md)
8
8
 
@@ -155,44 +155,44 @@ const bsv = require('@smartledger/bsv') // 128 modules
155
155
  ### **Core Modules**
156
156
  | Module | Size | Use Case | CDN |
157
157
  |--------|------|----------|-----|
158
- | **bsv.min.js** | 1062KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@9.16.0/bsv.min.js` |
159
- | **bsv.bundle.js** | 1062KB | Everything in one file | `unpkg.com/@smartledger/bsv@9.16.0/bsv.bundle.js` |
158
+ | **bsv.min.js** | 1062KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@9.16.1/bsv.min.js` |
159
+ | **bsv.bundle.js** | 1062KB | Everything in one file | `unpkg.com/@smartledger/bsv@9.16.1/bsv.bundle.js` |
160
160
 
161
161
  ### **W3C Verifiable Credentials**
162
162
  | Module | Size | Use Case | CDN |
163
163
  |--------|------|----------|-----|
164
- | **🟢 bsv-didweb.min.js** | 166KB | **DID:web generation** | `unpkg.com/@smartledger/bsv@9.16.0/bsv-didweb.min.js` |
165
- | **🟢 bsv-vcjwt.min.js** | 166KB | **VC-JWT issue/verify** | `unpkg.com/@smartledger/bsv@9.16.0/bsv-vcjwt.min.js` |
166
- | **🟢 bsv-statuslist.min.js** | 256KB | **StatusList2021 revocation** | `unpkg.com/@smartledger/bsv@9.16.0/bsv-statuslist.min.js` |
167
- | **🟢 bsv-anchor.min.js** | 164KB | **BSV anchoring (hash-only)** | `unpkg.com/@smartledger/bsv@9.16.0/bsv-anchor.min.js` |
164
+ | **🟢 bsv-didweb.min.js** | 166KB | **DID:web generation** | `unpkg.com/@smartledger/bsv@9.16.1/bsv-didweb.min.js` |
165
+ | **🟢 bsv-vcjwt.min.js** | 166KB | **VC-JWT issue/verify** | `unpkg.com/@smartledger/bsv@9.16.1/bsv-vcjwt.min.js` |
166
+ | **🟢 bsv-statuslist.min.js** | 256KB | **StatusList2021 revocation** | `unpkg.com/@smartledger/bsv@9.16.1/bsv-statuslist.min.js` |
167
+ | **🟢 bsv-anchor.min.js** | 164KB | **BSV anchoring (hash-only)** | `unpkg.com/@smartledger/bsv@9.16.1/bsv-anchor.min.js` |
168
168
 
169
169
  ### **Smart Contract & Development**
170
170
  | Module | Size | Use Case | CDN |
171
171
  |--------|------|----------|-----|
172
- | **bsv-smartcontract.min.js** | 141KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@9.16.0/bsv-smartcontract.min.js` |
173
- | **bsv-covenant.min.js** | 35KB | Covenant operations | `unpkg.com/@smartledger/bsv@9.16.0/bsv-covenant.min.js` |
174
- | **bsv-script-helper.min.js** | 33KB | Custom script tools | `unpkg.com/@smartledger/bsv@9.16.0/bsv-script-helper.min.js` |
175
- | **bsv-security.min.js** | 32KB | Security enhancements | `unpkg.com/@smartledger/bsv@9.16.0/bsv-security.min.js` |
172
+ | **bsv-smartcontract.min.js** | 141KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@9.16.1/bsv-smartcontract.min.js` |
173
+ | **bsv-covenant.min.js** | 35KB | Covenant operations | `unpkg.com/@smartledger/bsv@9.16.1/bsv-covenant.min.js` |
174
+ | **bsv-script-helper.min.js** | 33KB | Custom script tools | `unpkg.com/@smartledger/bsv@9.16.1/bsv-script-helper.min.js` |
175
+ | **bsv-security.min.js** | 32KB | Security enhancements | `unpkg.com/@smartledger/bsv@9.16.1/bsv-security.min.js` |
176
176
 
177
177
  ### **Legal & Compliance**
178
178
  | Module | Size | Use Case | CDN |
179
179
  |--------|------|----------|-----|
180
- | **bsv-ltp.min.js** | 542KB | Legal Token Protocol | `unpkg.com/@smartledger/bsv@9.16.0/bsv-ltp.min.js` |
181
- | **bsv-gdaf.min.js** | 1062KB | Digital Identity & Attestation | `unpkg.com/@smartledger/bsv@9.16.0/bsv-gdaf.min.js` |
180
+ | **bsv-ltp.min.js** | 542KB | Legal Token Protocol | `unpkg.com/@smartledger/bsv@9.16.1/bsv-ltp.min.js` |
181
+ | **bsv-gdaf.min.js** | 1062KB | Digital Identity & Attestation | `unpkg.com/@smartledger/bsv@9.16.1/bsv-gdaf.min.js` |
182
182
 
183
183
  ### **Advanced Cryptography**
184
184
  | Module | Size | Use Case | CDN |
185
185
  |--------|------|----------|-----|
186
- | **bsv-shamir.min.js** | 177KB | Threshold Cryptography | `unpkg.com/@smartledger/bsv@9.16.0/bsv-shamir.min.js` |
186
+ | **bsv-shamir.min.js** | 177KB | Threshold Cryptography | `unpkg.com/@smartledger/bsv@9.16.1/bsv-shamir.min.js` |
187
187
 
188
188
  ### **Utilities**
189
189
  | Module | Size | Use Case | CDN |
190
190
  |--------|------|----------|-----|
191
- | **bsv-ecies.min.js** | 137KB | Encryption | `unpkg.com/@smartledger/bsv@9.16.0/bsv-ecies.min.js` |
192
- | **bsv-message.min.js** | 34KB | Message signing | `unpkg.com/@smartledger/bsv@9.16.0/bsv-message.min.js` |
193
- | **bsv-mnemonic.min.js** | 320KB | HD wallets | `unpkg.com/@smartledger/bsv@9.16.0/bsv-mnemonic.min.js` |
191
+ | **bsv-ecies.min.js** | 137KB | Encryption | `unpkg.com/@smartledger/bsv@9.16.1/bsv-ecies.min.js` |
192
+ | **bsv-message.min.js** | 34KB | Message signing | `unpkg.com/@smartledger/bsv@9.16.1/bsv-message.min.js` |
193
+ | **bsv-mnemonic.min.js** | 320KB | HD wallets | `unpkg.com/@smartledger/bsv@9.16.1/bsv-mnemonic.min.js` |
194
194
  ```html
195
- <script src="https://unpkg.com/@smartledger/bsv@9.16.0/bsv.min.js"></script>
195
+ <script src="https://unpkg.com/@smartledger/bsv@9.16.1/bsv.min.js"></script>
196
196
  <script>
197
197
  const key = bsv.PrivateKey.fromRandom()
198
198
  </script>
@@ -240,4 +240,4 @@ MIT
240
240
 
241
241
  ---
242
242
 
243
- **SmartLedger-BSV v9.16.0**
243
+ **SmartLedger-BSV v9.16.1**