@smartledger/bsv 8.0.1 → 8.2.0

package/CHANGELOG.md

@@ -7,6 +7,124 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [8.2.0] - 2026-08-15
+
+Two independent reviews of 8.1.0, both acted on after reproducing every claim. Between
+them they found a proof system that verified nothing, a selective-disclosure scheme that
+leaked the fields it withheld, and a signature canonicalization no other implementation
+can reproduce. **4,469 tests passed with all of it in place**, because none of them
+touched those files.
+
+### `lib/gdaf/zk-prover.js` — verified nothing, and leaked what it hid
+
+This module had **zero test coverage**.
+
+**`verifyRangeProof` verified nothing.** It ended at `return proof.inRange === true` — a
+boolean the prover writes about itself. `valueCommitment` was never consulted, so any
+object of the right shape passed:
+
+```js
+{ type: 'RangeProof', range: { min: 18, max: 120 },
+  valueCommitment: '00…', proofHash: 'de…', inRange: true }   // → true
+```
+
+`verifyAgeProof` had the same shape: it accepted `meetsRequirement`, then checked only
+that `challengeResponse` was a non-empty string.
+
+Both now require the **opening**, check the commitment actually opens to the claimed
+value, and recompute the range or age rather than trusting the prover. Without an opening
+they return `false`, because nothing has been proven. The generators return the opening
+alongside the proof rather than inside it — embedding it would make every proof
+self-opening.
+
+**Selective disclosure leaked the withheld fields.** One salt covered every leaf and
+travelled in the proof, so the sibling hashes on the Merkle path could be brute-forced
+back into the hidden values. Disclosing only `credentialSubject.name` recovered `id`
+directly, and `partyAffiliation` with `eligible` from their shared parent node. Each leaf
+now carries its own salt, derived from a master that never leaves the generator, and only
+the disclosed leaves' salts travel in the proof.
+
+**A proof generated without an explicit salt could never verify.** The return used the
+`salt` argument — `undefined` when omitted — instead of the one `createMerkleTree`
+produced.
+
+**Nothing here is zero-knowledge**, and the module said otherwise in three places. These
+are hash commitments and a Merkle tree; the range and age commitments can only be checked
+by opening them, which reveals the committed value. The npm keyword
+`zero-knowledge-proofs` is replaced with `selective-disclosure`, the "Bulletproof-style"
+comment is corrected, and the docblock states the limitation plainly.
+
+21 tests where there were none, each pinning the attack rather than the fix.
+
+### GDAF canonicalization is now RFC 8785
+
+`_canonicalizeJSON` sorted keys and then rebuilt an object, which loses the sort: V8
+orders integer-like own properties numerically, ahead of string keys.
+
+```
+ours   {"2":"two","10":"ten"}
+JCS    {"10":"ten","2":"two"}      (UTF-16 code-unit order)
+```
+
+Within this library that was deterministic — signing and verification agreed, and no
+forgery follows. The failure is interoperability: GDAF credentials exist to be checked by
+other parties, and a JCS-conformant verifier in any language computes a different hash and
+rejects a valid signature.
+
+`_canonicalizeJCS` serializes directly rather than round-tripping through an object, so
+the order survives. Non-finite numbers now throw rather than serializing as `null`, which
+would silently sign a different document than the one supplied.
+
+**Migration is handled**: signing uses JCS, and verification tries JCS then the legacy
+form, so credentials, presentations and `rootHash` values written before this keep
+verifying. `1847`, `1847.0` and `1.847e3` still hash identically, which is correct rather
+than a weakness — they are the same IEEE-754 double — and a test pins it.
+
+### Packaging
+
+`files` shipped `test/` but not `tools/`, and three consensus specs require it. `tools/`
+now ships, and the tarball file-count guard is raised to 370 to accommodate it: the
+vectors are inert without the harnesses that run them.
+
+Note that a consumer still cannot run the shipped tests, because devDependencies are
+absent — whether `test/` should ship at all is a separate question.
+
+## [8.1.0] - 2026-08-13
+
+### `useGenesisLimits()` no longer raises the script-number bound
+
+It raised `MAXIMUM_ELEMENT_SIZE` along with the three size caps. That was right before the
+limits became era-derived, when it was the only way to reach post-Genesis arithmetic. It
+is not any more, and the raise had become purely harmful.
+
+`MAXIMUM_ELEMENT_SIZE` is CScriptNum's `max_length`, and since 8.0.0 it serves only as the
+**pre-Genesis fallback** for `maxScriptNumLength()` — post-Genesis is 750,000 and
+post-Chronicle 32,000,000, both reached through the era flags. So raising it could not
+enable post-Genesis arithmetic. It could only corrupt pre-Genesis validation:
+
+```
+5-byte operand under P2SH,STRICTENC
+
+  fresh process:            SCRIPT_ERR_SCRIPTNUM_OVERFLOW   (what the node says)
+  after useGenesisLimits(): ACCEPTED
+```
+
+A false accept, in the direction that can cost money, reached through a process-wide side
+effect on unrelated code later in the same process. The node's vectors agree
+independently: all 22 `SCRIPTNUM_OVERFLOW` rows are pre-Genesis, and raising this static
+turns 15 of them into false accepts.
+
+The three size caps still lift, so the documented reason to call the function is
+unaffected, and `setLimits()` can still set the bound explicitly.
+
+**Migration.** If you called `useGenesisLimits()` to get arithmetic wider than four bytes,
+ask for the era instead — `Interpreter.mainnetFlags()`, or simply omit the flags argument,
+which has defaulted to current mainnet since 8.0.0. Calling `useGenesisLimits()` for that
+purpose was already unsound, because it changed the rules for every later `verify()` in
+the process, including ones deliberately validating under pre-Genesis rules.
+
+Minor rather than patch: a public helper stops doing one of the four things it documented.
+
 ## [8.0.1] - 2026-08-13
 
 ### `mainnetFlags()` was applying 2019 limits

package/README.md

@@ -186,42 +186,42 @@ console.log('Status:', status) // 'revoked'
 ### **Core Modules**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv.min.js** | 1149KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js` |
-| **bsv.bundle.js** | 1149KB | Everything in one file | `unpkg.com/@smartledger/bsv@8.0.1/bsv.bundle.js` |
+| **bsv.min.js** | 1149KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js` |
+| **bsv.bundle.js** | 1149KB | Everything in one file | `unpkg.com/@smartledger/bsv@8.2.0/bsv.bundle.js` |
 
 ### **W3C Verifiable Credentials**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **🟢 bsv-didweb.min.js** | 315KB | **DID:web generation** | `unpkg.com/@smartledger/bsv@8.0.1/bsv-didweb.min.js` |
-| **🟢 bsv-vcjwt.min.js** | 315KB | **VC-JWT issue/verify** | `unpkg.com/@smartledger/bsv@8.0.1/bsv-vcjwt.min.js` |
-| **🟢 bsv-statuslist.min.js** | 415KB | **StatusList2021 revocation** | `unpkg.com/@smartledger/bsv@8.0.1/bsv-statuslist.min.js` |
-| **🟢 bsv-anchor.min.js** | 314KB | **BSV anchoring (hash-only)** | `unpkg.com/@smartledger/bsv@8.0.1/bsv-anchor.min.js` |
+| **🟢 bsv-didweb.min.js** | 315KB | **DID:web generation** | `unpkg.com/@smartledger/bsv@8.2.0/bsv-didweb.min.js` |
+| **🟢 bsv-vcjwt.min.js** | 315KB | **VC-JWT issue/verify** | `unpkg.com/@smartledger/bsv@8.2.0/bsv-vcjwt.min.js` |
+| **🟢 bsv-statuslist.min.js** | 415KB | **StatusList2021 revocation** | `unpkg.com/@smartledger/bsv@8.2.0/bsv-statuslist.min.js` |
+| **🟢 bsv-anchor.min.js** | 314KB | **BSV anchoring (hash-only)** | `unpkg.com/@smartledger/bsv@8.2.0/bsv-anchor.min.js` |
 
 ### **Smart Contract & Development**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-smartcontract.min.js** | 873KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@8.0.1/bsv-smartcontract.min.js` |
-| **bsv-covenant.min.js** | 873KB | Covenant operations | `unpkg.com/@smartledger/bsv@8.0.1/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 30KB | Custom script tools | `unpkg.com/@smartledger/bsv@8.0.1/bsv-script-helper.min.js` |
-| **bsv-security.min.js** | 30KB | Security enhancements | `unpkg.com/@smartledger/bsv@8.0.1/bsv-security.min.js` |
+| **bsv-smartcontract.min.js** | 873KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@8.2.0/bsv-smartcontract.min.js` |
+| **bsv-covenant.min.js** | 873KB | Covenant operations | `unpkg.com/@smartledger/bsv@8.2.0/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 30KB | Custom script tools | `unpkg.com/@smartledger/bsv@8.2.0/bsv-script-helper.min.js` |
+| **bsv-security.min.js** | 30KB | Security enhancements | `unpkg.com/@smartledger/bsv@8.2.0/bsv-security.min.js` |
 
 ### **Legal & Compliance**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-ltp.min.js** | 1149KB | Legal Token Protocol | `unpkg.com/@smartledger/bsv@8.0.1/bsv-ltp.min.js` |
-| **bsv-gdaf.min.js** | 1149KB | Digital Identity & Attestation | `unpkg.com/@smartledger/bsv@8.0.1/bsv-gdaf.min.js` |
+| **bsv-ltp.min.js** | 1149KB | Legal Token Protocol | `unpkg.com/@smartledger/bsv@8.2.0/bsv-ltp.min.js` |
+| **bsv-gdaf.min.js** | 1149KB | Digital Identity & Attestation | `unpkg.com/@smartledger/bsv@8.2.0/bsv-gdaf.min.js` |
 
 ### **Advanced Cryptography**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-shamir.min.js** | 353KB | Threshold Cryptography | `unpkg.com/@smartledger/bsv@8.0.1/bsv-shamir.min.js` |
+| **bsv-shamir.min.js** | 353KB | Threshold Cryptography | `unpkg.com/@smartledger/bsv@8.2.0/bsv-shamir.min.js` |
 
 ### **Utilities**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-ecies.min.js** | 79KB | Encryption | `unpkg.com/@smartledger/bsv@8.0.1/bsv-ecies.min.js` |
-| **bsv-message.min.js** | 30KB | Message signing | `unpkg.com/@smartledger/bsv@8.0.1/bsv-message.min.js` |
-| **bsv-mnemonic.min.js** | 592KB | HD wallets | `unpkg.com/@smartledger/bsv@8.0.1/bsv-mnemonic.min.js` |
+| **bsv-ecies.min.js** | 79KB | Encryption | `unpkg.com/@smartledger/bsv@8.2.0/bsv-ecies.min.js` |
+| **bsv-message.min.js** | 30KB | Message signing | `unpkg.com/@smartledger/bsv@8.2.0/bsv-message.min.js` |
+| **bsv-mnemonic.min.js** | 592KB | HD wallets | `unpkg.com/@smartledger/bsv@8.2.0/bsv-mnemonic.min.js` |
 
 ## ⚡ **2-Minute Quick Start**
 
@@ -232,7 +232,7 @@ Get started with Bitcoin SV development in under 2 minutes:
 npm install @smartledger/bsv
 
 # Or include in HTML
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js"></script>
 ```
 
 > **🔒 v5.0.0 (production hardening — has breaking changes):** Shamir secret
@@ -332,8 +332,8 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🔧 **Basic Development** (~1.2MB total)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-script-helper.min.js"></script>
 <script>
   const privateKey = new bsv.PrivateKey();
   const utxos = new bsv.SmartContract.UTXOGenerator().createRealUTXOs(2, 100000);
@@ -342,9 +342,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🔒 **Smart Contract Development** (~2.8MB total — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = bsv.SmartContract.createCovenantBuilder()
     .extractField('amount').push(50000).greaterThanOrEqual().verify().build();
@@ -354,9 +354,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🆕 **Legal & Identity Development** (~3.4MB total — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const propertyToken = bsv.createPropertyToken({
@@ -370,9 +370,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🆕 **Security & Cryptography** (~1.5MB total)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-shamir.min.js"></script>
 <script>
   // Threshold Cryptography
   const shares = bsv.splitSecret('my_secret_key', 5, 3); // 5 shares, 3 needed
@@ -384,7 +384,7 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🎯 **Everything Bundle** (~1.1MB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.bundle.js"></script>
 <script>
   // Everything available immediately
   const shares = bsv.splitSecret('secret', 5, 3);           // Shamir Secret Sharing
@@ -494,8 +494,8 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 1. **Minimal Setup** - Core + Script Helper (~1.2MB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-script-helper.min.js"></script>
 <script>
   const tx = new bsv.Transaction();
   const sig = bsvScriptHelper.createSignature(tx, privateKey, 0, script, satoshis);
@@ -504,9 +504,9 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 2. **DeFi Development** - Core + Covenants + Debug (~2.8MB — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = new bsvCovenant.CovenantInterface();
   const debugInfo = SmartContract.interpretScript(script);
@@ -516,8 +516,8 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 3. **Security First** - Core + Enhanced Security (~1.2MB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv-security.min.js"></script>
 <script>
   const verified = bsvSecurity.SmartVerify.verify(signature, hash, publicKey);
   const enhanced = bsvSecurity.EllipticFixed.createSignature(privateKey, hash);
@@ -526,7 +526,7 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 4. **Everything Bundle** - One File Solution (~1.1MB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@8.0.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@8.2.0/bsv.bundle.js"></script>
 <script>
   // Everything available under bsv namespace
   const keys = bsv.SmartLedgerBundle.generateKeys();
@@ -834,7 +834,7 @@ const timelockScript = helper.createTimelockScript(
 
 See the **[16 Loading Options](#-16-loading-options---choose-your-approach)**
 table near the top for the full list of bundles with current sizes and
-canonical `unpkg.com/@smartledger/bsv@8.0.1/...` URLs.
+canonical `unpkg.com/@smartledger/bsv@8.2.0/...` URLs.
 
 ## 🔐 Security