@smartledger/bsv 7.5.6 → 7.5.8

package/CHANGELOG.md

@@ -7,6 +7,72 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [7.5.8] - 2026-08-07
+
+### Fixed
+
+- **Directory deep imports under `lib/` did not resolve.** The `exports` map carried
+  `"./lib/*": "./lib/*.js"`, which maps `lib/script` to `lib/script.js` — a file that
+  does not exist, since `script` is a directory. So
+  `require('@smartledger/bsv/lib/script')` raised `MODULE_NOT_FOUND`, and the same
+  applied to all 16 directory modules (`ordinals`, `smart_contract`, `transaction`,
+  `gdaf`, `ltp`, `spv`, `mnemonic`, `vcjwt`, …). Only the explicit
+  `lib/script/index.js` form worked.
+
+  Each directory that has an `index.js` now has an explicit entry pointing at it.
+  Non-pattern keys take priority over patterns in Node's resolution, so directories
+  resolve through these while files continue to use `"./lib/*"`. Both CommonJS
+  `require` and ESM `import` are covered, since the map governs both.
+
+  Node's fallback-array form (`["./lib/*.js", "./lib/*/index.js"]`) was tried first and
+  does **not** work: Node falls through on an *invalid* target, not on a missing file.
+
+  The regression test enumerates `lib/` at runtime rather than hard-coding names, so a
+  new directory module cannot be added without also being exported, and asserts the
+  bare and explicit forms return the *same* module object (one cache entry, not two).
+
+  This is the resolution gap behind the reproduction in the 7.5.7 report: the literal
+  line `require('@smartledger/bsv/lib/script')` failed here before it could reach the
+  require-cycle defect that release fixed.
+
+Suite 4601 → 4603.
+
+## [7.5.7] - 2026-08-07
+
+### Fixed
+
+- **`Address` threw whenever `lib/script` was required before `lib/address`.**
+  The two modules form a require cycle, and `address.js` ended with the usual idiom
+  — export yourself, then `var Script = require('./script')`. That only holds when
+  `address` loads first. Reaching `lib/script` first meant the require returned
+  script's **partially initialised** exports (`{}`), the captured binding stayed `{}`
+  forever, and every `instanceof Script` raised
+  `TypeError: Right-hand side of 'instanceof' is not callable`. `var` hoisting hid it,
+  since the name is in scope for the functions defined above the assignment.
+
+  This was reachable, not theoretical: deep imports are public API through the
+  `exports` map (`"./lib/*"`), so requiring `lib/script` first is a supported way to
+  use the package. Both `Address.fromScript(script)` and `new Address(script)` threw,
+  reaching the check through `_transformScript` and `_classifyArguments` respectively.
+
+  `Script` is now resolved at call time through a small accessor rather than captured
+  at module scope. `require` is cached, so it costs nothing, and by the time any of
+  these functions run the module is complete — which keeps `instanceof` **exact**
+  rather than loosening the check to a structural duck-type that a non-Script object
+  could satisfy.
+
+- **`scripts/check-address-load-order.js`** guards it, wired into CI and available as
+  `npm run check:load-order`. It deliberately lives outside mocha: the check must clear
+  `require.cache`, which would invalidate every module reference an in-process suite is
+  holding. It exercises `fromScript`, the constructor **and** `payingTo` — the first
+  two reach the check by different paths, and `payingTo` reaches the `Script`
+  constructor itself. Confirmed to fail against the unpatched module rather than
+  passing vacuously.
+
+Reported with an accurate reproduction and diagnosis in
+`BUG-address-load-order-instanceof.md`. Suite 4601 (unchanged — the guard is a
+standalone script, by necessity).
+
 ## [7.5.6] - 2026-08-07
 
 ### Fixed

package/README.md

@@ -186,42 +186,42 @@ console.log('Status:', status) // 'revoked'
 ### **Core Modules**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv.min.js** | 1149KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js` |
-| **bsv.bundle.js** | 1149KB | Everything in one file | `unpkg.com/@smartledger/bsv@7.5.6/bsv.bundle.js` |
+| **bsv.min.js** | 1149KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js` |
+| **bsv.bundle.js** | 1149KB | Everything in one file | `unpkg.com/@smartledger/bsv@7.5.8/bsv.bundle.js` |
 
 ### **W3C Verifiable Credentials**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **🟢 bsv-didweb.min.js** | 315KB | **DID:web generation** | `unpkg.com/@smartledger/bsv@7.5.6/bsv-didweb.min.js` |
-| **🟢 bsv-vcjwt.min.js** | 315KB | **VC-JWT issue/verify** | `unpkg.com/@smartledger/bsv@7.5.6/bsv-vcjwt.min.js` |
-| **🟢 bsv-statuslist.min.js** | 415KB | **StatusList2021 revocation** | `unpkg.com/@smartledger/bsv@7.5.6/bsv-statuslist.min.js` |
-| **🟢 bsv-anchor.min.js** | 314KB | **BSV anchoring (hash-only)** | `unpkg.com/@smartledger/bsv@7.5.6/bsv-anchor.min.js` |
+| **🟢 bsv-didweb.min.js** | 315KB | **DID:web generation** | `unpkg.com/@smartledger/bsv@7.5.8/bsv-didweb.min.js` |
+| **🟢 bsv-vcjwt.min.js** | 315KB | **VC-JWT issue/verify** | `unpkg.com/@smartledger/bsv@7.5.8/bsv-vcjwt.min.js` |
+| **🟢 bsv-statuslist.min.js** | 415KB | **StatusList2021 revocation** | `unpkg.com/@smartledger/bsv@7.5.8/bsv-statuslist.min.js` |
+| **🟢 bsv-anchor.min.js** | 314KB | **BSV anchoring (hash-only)** | `unpkg.com/@smartledger/bsv@7.5.8/bsv-anchor.min.js` |
 
 ### **Smart Contract & Development**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-smartcontract.min.js** | 873KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@7.5.6/bsv-smartcontract.min.js` |
-| **bsv-covenant.min.js** | 873KB | Covenant operations | `unpkg.com/@smartledger/bsv@7.5.6/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 30KB | Custom script tools | `unpkg.com/@smartledger/bsv@7.5.6/bsv-script-helper.min.js` |
-| **bsv-security.min.js** | 30KB | Security enhancements | `unpkg.com/@smartledger/bsv@7.5.6/bsv-security.min.js` |
+| **bsv-smartcontract.min.js** | 873KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@7.5.8/bsv-smartcontract.min.js` |
+| **bsv-covenant.min.js** | 873KB | Covenant operations | `unpkg.com/@smartledger/bsv@7.5.8/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 30KB | Custom script tools | `unpkg.com/@smartledger/bsv@7.5.8/bsv-script-helper.min.js` |
+| **bsv-security.min.js** | 30KB | Security enhancements | `unpkg.com/@smartledger/bsv@7.5.8/bsv-security.min.js` |
 
 ### **Legal & Compliance**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-ltp.min.js** | 1149KB | Legal Token Protocol | `unpkg.com/@smartledger/bsv@7.5.6/bsv-ltp.min.js` |
-| **bsv-gdaf.min.js** | 1149KB | Digital Identity & Attestation | `unpkg.com/@smartledger/bsv@7.5.6/bsv-gdaf.min.js` |
+| **bsv-ltp.min.js** | 1149KB | Legal Token Protocol | `unpkg.com/@smartledger/bsv@7.5.8/bsv-ltp.min.js` |
+| **bsv-gdaf.min.js** | 1149KB | Digital Identity & Attestation | `unpkg.com/@smartledger/bsv@7.5.8/bsv-gdaf.min.js` |
 
 ### **Advanced Cryptography**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-shamir.min.js** | 353KB | Threshold Cryptography | `unpkg.com/@smartledger/bsv@7.5.6/bsv-shamir.min.js` |
+| **bsv-shamir.min.js** | 353KB | Threshold Cryptography | `unpkg.com/@smartledger/bsv@7.5.8/bsv-shamir.min.js` |
 
 ### **Utilities**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-ecies.min.js** | 79KB | Encryption | `unpkg.com/@smartledger/bsv@7.5.6/bsv-ecies.min.js` |
-| **bsv-message.min.js** | 30KB | Message signing | `unpkg.com/@smartledger/bsv@7.5.6/bsv-message.min.js` |
-| **bsv-mnemonic.min.js** | 592KB | HD wallets | `unpkg.com/@smartledger/bsv@7.5.6/bsv-mnemonic.min.js` |
+| **bsv-ecies.min.js** | 79KB | Encryption | `unpkg.com/@smartledger/bsv@7.5.8/bsv-ecies.min.js` |
+| **bsv-message.min.js** | 30KB | Message signing | `unpkg.com/@smartledger/bsv@7.5.8/bsv-message.min.js` |
+| **bsv-mnemonic.min.js** | 592KB | HD wallets | `unpkg.com/@smartledger/bsv@7.5.8/bsv-mnemonic.min.js` |
 
 ## ⚡ **2-Minute Quick Start**
 
@@ -232,7 +232,7 @@ Get started with Bitcoin SV development in under 2 minutes:
 npm install @smartledger/bsv
 
 # Or include in HTML
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js"></script>
 ```
 
 > **🔒 v5.0.0 (production hardening — has breaking changes):** Shamir secret
@@ -332,8 +332,8 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🔧 **Basic Development** (~1.2MB total)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-script-helper.min.js"></script>
 <script>
   const privateKey = new bsv.PrivateKey();
   const utxos = new bsv.SmartContract.UTXOGenerator().createRealUTXOs(2, 100000);
@@ -342,9 +342,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🔒 **Smart Contract Development** (~2.8MB total — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = bsv.SmartContract.createCovenantBuilder()
     .extractField('amount').push(50000).greaterThanOrEqual().verify().build();
@@ -354,9 +354,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🆕 **Legal & Identity Development** (~3.4MB total — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const propertyToken = bsv.createPropertyToken({
@@ -370,9 +370,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🆕 **Security & Cryptography** (~1.5MB total)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-shamir.min.js"></script>
 <script>
   // Threshold Cryptography
   const shares = bsv.splitSecret('my_secret_key', 5, 3); // 5 shares, 3 needed
@@ -384,7 +384,7 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🎯 **Everything Bundle** (~1.1MB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.bundle.js"></script>
 <script>
   // Everything available immediately
   const shares = bsv.splitSecret('secret', 5, 3);           // Shamir Secret Sharing
@@ -494,8 +494,8 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 1. **Minimal Setup** - Core + Script Helper (~1.2MB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-script-helper.min.js"></script>
 <script>
   const tx = new bsv.Transaction();
   const sig = bsvScriptHelper.createSignature(tx, privateKey, 0, script, satoshis);
@@ -504,9 +504,9 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 2. **DeFi Development** - Core + Covenants + Debug (~2.8MB — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = new bsvCovenant.CovenantInterface();
   const debugInfo = SmartContract.interpretScript(script);
@@ -516,8 +516,8 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 3. **Security First** - Core + Enhanced Security (~1.2MB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv-security.min.js"></script>
 <script>
   const verified = bsvSecurity.SmartVerify.verify(signature, hash, publicKey);
   const enhanced = bsvSecurity.EllipticFixed.createSignature(privateKey, hash);
@@ -526,7 +526,7 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 4. **Everything Bundle** - One File Solution (~1.1MB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.5.6/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.5.8/bsv.bundle.js"></script>
 <script>
   // Everything available under bsv namespace
   const keys = bsv.SmartLedgerBundle.generateKeys();
@@ -834,7 +834,7 @@ const timelockScript = helper.createTimelockScript(
 
 See the **[16 Loading Options](#-16-loading-options---choose-your-approach)**
 table near the top for the full list of bundles with current sizes and
-canonical `unpkg.com/@smartledger/bsv@7.5.6/...` URLs.
+canonical `unpkg.com/@smartledger/bsv@7.5.8/...` URLs.
 
 ## 🔐 Security