@smartledger/bsv 7.0.2 → 7.2.0

package/docs/MODULE_REFERENCE_COMPLETE.md

@@ -55,19 +55,19 @@ Three advanced modules totaling **~2.7MB** of functionality:
 - **Purpose**: Threshold cryptography for secure secret distribution
 - **Use Cases**: Backup keys, multi-party security, key recovery
 - **Features**: Split secrets into N shares, require M to reconstruct
-- **CDN**: `unpkg.com/@smartledger/bsv@7.0.2/bsv-shamir.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@7.2.0/bsv-shamir.min.js`
 
 #### **🌐 Global Digital Attestation Framework - GDAF (1184KB)**  
 - **Purpose**: W3C Verifiable Credentials and decentralized identity
 - **Use Cases**: Identity verification, attestations, zero-knowledge proofs
 - **Features**: DID creation, credential issuance, selective disclosure
-- **CDN**: `unpkg.com/@smartledger/bsv@7.0.2/bsv-gdaf.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@7.2.0/bsv-gdaf.min.js`
 
 #### **⚖️ Legal Token Protocol - LTP (1184KB)**
 - **Purpose**: Legal compliance framework for tokenized assets
 - **Use Cases**: Property rights, obligations, compliant tokenization  
 - **Features**: Legal primitives, compliance checking, attestation anchoring
-- **CDN**: `unpkg.com/@smartledger/bsv@7.0.2/bsv-ltp.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@7.2.0/bsv-ltp.min.js`
 
 ### **2. Incorrect File Sizes in Documentation**
 
@@ -81,18 +81,18 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 | Module | Size | Use Case | CDN Link |
 |--------|------|----------|----------|
-| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js` |
-| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@7.0.2/bsv.bundle.js` |
-| **bsv-smartcontract.min.js** | 937KB | Covenant development | `unpkg.com/@smartledger/bsv@7.0.2/bsv-smartcontract.min.js` |
-| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@7.0.2/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@7.0.2/bsv-script-helper.min.js` |
-| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@7.0.2/bsv-security.min.js` |
-| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@7.0.2/bsv-ecies.min.js` |
-| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@7.0.2/bsv-message.min.js` |
-| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@7.0.2/bsv-mnemonic.min.js` |
-| **🆕 bsv-shamir.min.js** | 432KB | **Secret sharing** | `unpkg.com/@smartledger/bsv@7.0.2/bsv-shamir.min.js` |
-| **🆕 bsv-gdaf.min.js** | 1184KB | **Digital attestation** | `unpkg.com/@smartledger/bsv@7.0.2/bsv-gdaf.min.js` |
-| **🆕 bsv-ltp.min.js** | 1184KB | **Legal tokens** | `unpkg.com/@smartledger/bsv@7.0.2/bsv-ltp.min.js` |
+| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js` |
+| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@7.2.0/bsv.bundle.js` |
+| **bsv-smartcontract.min.js** | 937KB | Covenant development | `unpkg.com/@smartledger/bsv@7.2.0/bsv-smartcontract.min.js` |
+| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@7.2.0/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@7.2.0/bsv-script-helper.min.js` |
+| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@7.2.0/bsv-security.min.js` |
+| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@7.2.0/bsv-ecies.min.js` |
+| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@7.2.0/bsv-message.min.js` |
+| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@7.2.0/bsv-mnemonic.min.js` |
+| **🆕 bsv-shamir.min.js** | 432KB | **Secret sharing** | `unpkg.com/@smartledger/bsv@7.2.0/bsv-shamir.min.js` |
+| **🆕 bsv-gdaf.min.js** | 1184KB | **Digital attestation** | `unpkg.com/@smartledger/bsv@7.2.0/bsv-gdaf.min.js` |
+| **🆕 bsv-ltp.min.js** | 1184KB | **Legal tokens** | `unpkg.com/@smartledger/bsv@7.2.0/bsv-ltp.min.js` |
 
 ## 🎯 **Updated Usage Examples**
 
@@ -100,22 +100,22 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **1. Basic Development (~963KB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-script-helper.min.js"></script>
 ```
 
 #### **2. Smart Contract Development (~2.7MB — each bundle re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-smartcontract.min.js"></script>
 ```
 
 #### **3. 🆕 Legal & Compliance Development (~3.2MB — each bundle re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const legalToken = bsv.createLegalToken({
@@ -132,9 +132,9 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **4. 🆕 Security & Cryptography (~1.4MB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-shamir.min.js"></script>
 <script>
   // Shamir Secret Sharing
   const shares = bsv.splitSecret('my_secret_key', 5, 3); // 5 shares, 3 needed
@@ -146,7 +146,7 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **5. Everything Bundle (937KB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.bundle.js"></script>
 <script>
   // Everything available immediately
   const shares = bsv.splitSecret('secret', 5, 3);

package/docs/advanced/UTXO_MANAGER_GUIDE.md

@@ -722,7 +722,7 @@ interface UTXO {
 <html>
 <head>
     <title>UTXO Manager Demo</title>
-    <script src="https://cdn.jsdelivr.net/npm/@smartledger/bsv@7.0.2/bsv.min.js"></script>
+    <script src="https://cdn.jsdelivr.net/npm/@smartledger/bsv@7.2.0/bsv.min.js"></script>
 </head>
 <body>
     <script>

package/docs/getting-started/INSTALLATION.md

@@ -48,7 +48,7 @@ const tx: Transaction = new Transaction();
 #### **Core Library Only (937KB)**
 For basic Bitcoin SV operations:
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
 <script>
   const privateKey = new bsv.PrivateKey();
   const address = privateKey.toAddress();
@@ -58,7 +58,7 @@ For basic Bitcoin SV operations:
 #### **Complete Bundle (937KB)**  
 Everything in one file:
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.bundle.js"></script>
 <script>
   // All features available immediately
   const shares = bsv.splitSecret('secret', 5, 3);
@@ -71,9 +71,9 @@ Everything in one file:
 
 #### **Smart Contract Development (~2.7MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = bsv.SmartContract.createCovenantBuilder()
     .extractField('amount').push(50000).greaterThanOrEqual().build();
@@ -82,9 +82,9 @@ Everything in one file:
 
 #### **Legal & Identity Development (~3.2MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const propertyToken = bsv.createPropertyToken({
@@ -98,9 +98,9 @@ Everything in one file:
 
 #### **Security & Cryptography (~1.4MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-shamir.min.js"></script>
 <script>
   // Threshold Cryptography
   const shares = bsv.splitSecret('my_secret_key', 5, 3);
@@ -114,18 +114,18 @@ Everything in one file:
 
 | Module | Size | Purpose | CDN Link |
 |--------|------|---------|----------|
-| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js` |
-| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@7.0.2/bsv.bundle.js` |
-| **bsv-smartcontract.min.js** | 937KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@7.0.2/bsv-smartcontract.min.js` |
-| **bsv-ltp.min.js** | 1184KB | **Legal Token Protocol** | `unpkg.com/@smartledger/bsv@7.0.2/bsv-ltp.min.js` |
-| **bsv-gdaf.min.js** | 1184KB | **Digital Identity & Attestation** | `unpkg.com/@smartledger/bsv@7.0.2/bsv-gdaf.min.js` |
-| **bsv-shamir.min.js** | 432KB | **Threshold Cryptography** | `unpkg.com/@smartledger/bsv@7.0.2/bsv-shamir.min.js` |
-| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@7.0.2/bsv-security.min.js` |
-| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@7.0.2/bsv-mnemonic.min.js` |
-| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@7.0.2/bsv-ecies.min.js` |
-| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@7.0.2/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@7.0.2/bsv-script-helper.min.js` |
-| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@7.0.2/bsv-message.min.js` |
+| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js` |
+| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@7.2.0/bsv.bundle.js` |
+| **bsv-smartcontract.min.js** | 937KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@7.2.0/bsv-smartcontract.min.js` |
+| **bsv-ltp.min.js** | 1184KB | **Legal Token Protocol** | `unpkg.com/@smartledger/bsv@7.2.0/bsv-ltp.min.js` |
+| **bsv-gdaf.min.js** | 1184KB | **Digital Identity & Attestation** | `unpkg.com/@smartledger/bsv@7.2.0/bsv-gdaf.min.js` |
+| **bsv-shamir.min.js** | 432KB | **Threshold Cryptography** | `unpkg.com/@smartledger/bsv@7.2.0/bsv-shamir.min.js` |
+| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@7.2.0/bsv-security.min.js` |
+| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@7.2.0/bsv-mnemonic.min.js` |
+| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@7.2.0/bsv-ecies.min.js` |
+| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@7.2.0/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@7.2.0/bsv-script-helper.min.js` |
+| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@7.2.0/bsv-message.min.js` |
 
 ## ⚙️ **Development Environment Setup**
 

package/docs/getting-started/QUICK_START.md

@@ -14,10 +14,10 @@ npm install @smartledger/bsv
 ### Browser CDN (Instant)
 ```html
 <!-- Core library (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
 
 <!-- Everything included (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.bundle.js"></script>
 ```
 
 ## 💰 **Your First Transaction (60 seconds)**
@@ -127,19 +127,19 @@ SmartLedger-BSV offers 12 different loading options - use only what you need:
 
 ```html
 <!-- Core BSV only (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
 
 <!-- Smart contracts (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-smartcontract.min.js"></script>
 
 <!-- Legal tokens (1.16MB) -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-ltp.min.js"></script>
 
 <!-- Digital identity (1.16MB) -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-gdaf.min.js"></script>
 
 <!-- Everything (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.bundle.js"></script>
 ```
 
 ## ⚡ **Key Advantages**

package/docs/migration/FROM_BSV_1_5_6.md

@@ -159,17 +159,17 @@ const recovered = bsv.reconstructSecret([shares[0], shares[2], shares[4]]);
 ### **New Modular Options** 
 ```html
 <!-- Core compatibility (same size as bsv@1.5.6) -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.min.js"></script>
 
 <!-- Add smart contracts when ready -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-smartcontract.min.js"></script>
 
 <!-- Add advanced features as needed -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv-gdaf.min.js"></script>
 
 <!-- Everything in one file -->
-<script src="https://unpkg.com/@smartledger/bsv@7.0.2/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@7.2.0/bsv.bundle.js"></script>
 ```
 
 ## 🔍 **Testing Your Migration**

package/lib/crypto/ecdsa.js

@@ -18,6 +18,21 @@ var ECDSA = function ECDSA (obj) {
   }
 }
 
+// A nonce may be consumed by at most one signature: signing two messages under
+// one k reveals the private key. Assigning k marks it fresh; _findSignature
+// marks it stale once used, and derives a new RFC 6979 nonce when it is stale.
+Object.defineProperty(ECDSA.prototype, 'k', {
+  get: function () {
+    return this._k
+  },
+  set: function (k) {
+    this._k = k
+    this._kFresh = true
+  },
+  enumerable: true,
+  configurable: true
+})
+
 ECDSA.prototype.set = function (obj) {
   this.hashbuf = obj.hashbuf || this.hashbuf
   this.endian = obj.endian || this.endian // the endianness of hashbuf
@@ -39,7 +54,11 @@ ECDSA.prototype.set = function (obj) {
     this.sig = this.sig
   }
   
-  this.k = obj.k || this.k
+  // Must not be `this.k = obj.k || this.k`: that re-runs the setter and would
+  // re-mark an already-spent nonce as fresh.
+  if (obj.k) {
+    this.k = obj.k
+  }
   this.verified = obj.verified || this.verified
   return this
 }
@@ -226,7 +245,8 @@ ECDSA.prototype._findSignature = function (d, e) {
   var badrs = 0
   var k, Q, r, s
   do {
-    if (!this.k || badrs > 0) {
+    // A spent nonce (!this._kFresh) must never be reused for a second message.
+    if (!this.k || !this._kFresh || badrs > 0) {
       this.deterministicK(badrs)
     }
     badrs++
@@ -236,6 +256,8 @@ ECDSA.prototype._findSignature = function (d, e) {
     s = k.invm(N).mul(e.add(d.mul(r))).umod(N)
   } while (r.cmp(BN.Zero) <= 0 || s.cmp(BN.Zero) <= 0)
 
+  this._kFresh = false
+
   s = ECDSA.toLowS(s)
   return {
     s: s,

package/lib/crypto/signature.js

@@ -82,8 +82,26 @@ Signature.fromString = function (str) {
   return Signature.fromDER(buf)
 }
 
+/**
+ * A DER INTEGER carrying r or s must be non-empty, positive (high bit clear,
+ * since ECDSA r/s are unsigned), and minimally padded — a leading 0x00 is
+ * permitted only to clear the high bit of the byte that follows. Anything else
+ * is a second encoding of the same number, i.e. a malleable signature.
+ */
+function checkCanonicalInt (name, ibuf) {
+  $.checkArgument(ibuf.length > 0, new Error('Length of ' + name + ' is zero'))
+  $.checkArgument(!(ibuf[0] & 0x80), new Error('Value of ' + name + ' is negative'))
+  $.checkArgument(!(ibuf.length > 1 && ibuf[0] === 0x00 && !(ibuf[1] & 0x80)),
+    new Error('Value of ' + name + ' is excessively padded'))
+}
+
 /**
  * In order to mimic the non-strict DER encoding of OpenSSL, set strict = false.
+ *
+ * Non-strict is required to parse the non-canonical signatures already on chain
+ * and is what fromTxFormat uses; consensus-level canonicality is enforced
+ * separately by isTxDER under the interpreter's flags. Strict is the default and
+ * is what application-level callers (fromDER/fromString) get.
  */
 Signature.parseDER = function (buf, strict) {
   $.checkArgument(Buffer.isBuffer(buf), new Error('DER formatted signature should be a buffer'))
@@ -115,12 +133,17 @@ Signature.parseDER = function (buf, strict) {
   var slength = buf[2 + 2 + rlength + 1]
   var sbuf = buf.slice(2 + 2 + rlength + 2, 2 + 2 + rlength + 2 + slength)
   var s = BN.fromBuffer(sbuf)
-  var sneg = buf[2 + 2 + rlength + 2 + 2] === 0x00
+  var sneg = buf[2 + 2 + rlength + 2] === 0x00
   $.checkArgument(slength === sbuf.length, new Error('Length of s incorrect'))
 
   var sumlength = 2 + 2 + rlength + 2 + slength
   $.checkArgument(length === sumlength - 2, new Error('Length of signature incorrect'))
 
+  if (strict) {
+    checkCanonicalInt('r', rbuf)
+    checkCanonicalInt('s', sbuf)
+  }
+
   var obj = {
     header: header,
     length: length,
@@ -384,24 +407,28 @@ Signature.prototype.isValid = function () {
 }
 
 /**
- * Apply SmartLedger security canonicalization - called during crypto operations
+ * Assert that this signature is safe to accept: r and s in (0, n) and s
+ * canonical (low-S). Throws if not; returns `this` for chaining.
+ *
+ * This asserts rather than rewrites. Silently replacing a high-S s with n-s
+ * cannot protect against malleability — ECDSA accepts s and n-s equally, so the
+ * rewritten signature verifies exactly as the original did, and the only effect
+ * is to hide from the caller that they were handed a malleated signature. Use
+ * toCanonical() to deliberately normalize one.
  */
 Signature.prototype.applySecurityPatches = function () {
   var Point = require('./point')
   var n = Point.getN()
   var nh = n.shrn(1) // n/2
 
-  // Security validation
   if (this.r.isZero() || this.s.isZero()) {
     throw new Error('Invalid signature: zero r or s')
   }
   if (this.r.gte(n) || this.s.gte(n)) {
     throw new Error('Invalid signature: out of range')
   }
-
-  // Canonicalize s value (anti-malleability)
   if (this.s.gt(nh)) {
-    this.s = n.sub(this.s)
+    throw new Error('Invalid signature: non-canonical (high) s')
   }
 
   return this

package/lib/crypto/smartledger_verify.js

@@ -59,20 +59,19 @@ function smartVerify (msgHash, sig, pubkey) {
     return false
   }
 
-  // Canonicalize s to lower half (anti-malleability)
-  let canonicalS = s
+  // Reject high-S rather than canonicalizing it: ECDSA accepts s and n-s
+  // equally, so verifying a rewritten s would report every malleated signature
+  // as valid — the outcome this module exists to prevent.
   if (s.gt(nh)) {
-    canonicalS = n.sub(s)
+    return false
   }
 
-  // Create canonicalized signature object for ECDSA verify
   const Signature = require('./signature')
   const canonicalSig = new Signature({
     r: r,
-    s: canonicalS
+    s: s
   })
 
-  // Use BSV's ECDSA verify with canonical signature object
   return ECDSA.verify(msgHash, canonicalSig, pubkey)
 }
 

package/lib/ltp/claim.js

@@ -3,6 +3,7 @@
 var bsv = require('../../')
 var Hash = bsv.crypto.Hash
 var $ = bsv.util.preconditions
+var Id = require('../util/id')
 
 /**
  * Legal Token Protocol - Claim Preparation Primitives
@@ -691,9 +692,7 @@ var ClaimValidator = {
    * @private
    */
   _generateBatchId: function() {
-    // Non-security: identifier collision avoidance only
-    var data = 'batch_' + Date.now() + '_' + Math.random()
-    return Hash.sha256(Buffer.from(data)).toString('hex').substring(0, 16)
+    return Id.randomHex(16)
   },
   
   /**

package/lib/ltp/obligation.js

@@ -6,6 +6,7 @@ var ECDSA = bsv.crypto.ECDSA
 var Signature = bsv.crypto.Signature
 var PrivateKey = bsv.PrivateKey
 var $ = bsv.util.preconditions
+var Id = require('../util/id')
 
 /**
  * Resolve the AUTHORITATIVE signer public key for a token: the issuer's key,
@@ -976,12 +977,7 @@ var ObligationToken = {
    * @private
    */
   _generateUUID: function() {
-    // Non-security: identifier collision avoidance only (not RFC 4122 v4 random)
-    return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function(c) {
-      var r = Math.random() * 16 | 0
-      var v = c === 'x' ? r : (r & 0x3 | 0x8)
-      return v.toString(16)
-    })
+    return Id.uuid4()
   }
 }
 

package/lib/ltp/registry.js

@@ -5,6 +5,7 @@ var Hash = bsv.crypto.Hash
 var Address = bsv.Address
 var Transaction = bsv.Transaction
 var $ = bsv.util.preconditions
+var Id = require('../util/id')
 
 /**
  * Legal Token Protocol - Registry Primitives
@@ -552,9 +553,7 @@ var LTPRegistry = {
    * @private
    */
   _generateRegistryId: function() {
-    // Non-security: identifier collision avoidance only
-    var data = 'reg_' + Date.now() + '_' + Math.random()
-    return 'reg_' + Hash.sha256(Buffer.from(data)).toString('hex').substring(0, 16)
+    return 'reg_' + Id.randomHex(16)
   },
   
   /**
@@ -686,9 +685,11 @@ var LTPRegistry = {
    * @private
    */
   _generateAuditId: function() {
-    // Non-security: identifier collision avoidance only
-    var data = 'audit_' + Date.now() + '_' + Math.random()
-    return 'audit_' + Hash.sha256(Buffer.from(data)).toString('hex').substring(0, 12)
+    // 128 bits. Audit entries are minted per action and retained for years, and
+    // a collision silently overwrites a record in a Map-keyed store, so this is
+    // sized to close the birthday question outright rather than to match the
+    // per-registry ids above (which are minted once each).
+    return 'audit_' + Id.randomHex(32)
   },
   
   /**

package/lib/ltp/right.js

@@ -7,6 +7,7 @@ var Signature = bsv.crypto.Signature
 var PrivateKey = bsv.PrivateKey
 var $ = bsv.util.preconditions
 var _ = require('../util/_')
+var Id = require('../util/id')
 
 /**
  * Resolve the AUTHORITATIVE signer public key for a token: the issuer's key.
@@ -925,12 +926,7 @@ var RightToken = {
    * @private
    */
   _generateUUID: function() {
-    // Non-security: identifier collision avoidance only (not RFC 4122 v4 random)
-    return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function(c) {
-      var r = Math.random() * 16 | 0
-      var v = c === 'x' ? r : (r & 0x3 | 0x8)
-      return v.toString(16)
-    })
+    return Id.uuid4()
   }
 }
 

package/lib/ordinals/README.md

@@ -29,7 +29,8 @@ var script = Ord.buildInscription({
 })
 var output = Ord.createInscriptionOutput({ address: ownerAddress, contentType: 'image/png', content: pngBuffer })
 
-// Parse it back.
+// Parse it back. `lock` is the whole script minus the envelope: the 1Sat spec allows the
+// locking script to be prepended OR appended, and both are recovered.
 var insc = Ord.parseInscription(script)      // { contentType, content, contentText, lock }
 Ord.isInscription(script)                    // true
 
@@ -40,6 +41,28 @@ var outs = Ord.batchInscriptionOutputs([
 ])
 ```
 
+### Arguments are checked, because an inscription is permanent
+
+`content` may be any data — a string or a `Buffer` of arbitrary bytes, under any MIME
+type. What the builder will not do is guess, because every guess it used to make wrote
+something other than what the caller asked for onto a permanent record:
+
+| Call | Before | Now |
+| --- | --- | --- |
+| `content` omitted | built a valid-looking script inscribing **nothing** | throws, and names the field you passed instead (`data`, `body`, `payload`, …) |
+| `content: {…}` or a number | inscribed `[object Object]` / `"42"` | throws; encode it yourself (`JSON.stringify`, `Buffer.from`) |
+| `Buffer` content, no `contentType` | labelled it `text/plain` | throws — bytes carry no hint about what they are |
+| empty `lock` | emitted an **anyone-can-spend** ordinal | throws unless you pass `allowEmptyLock: true` |
+| both `lock` and `address` | silently used `lock` | throws — they name different owners |
+| `satoshis: 0` | built a 0-sat output carrying no ordinal | throws; must be a positive integer |
+
+Deliberate cases are still expressible: pass `content: ''` for an empty payload, and
+`allowEmptyLock: true` when you are appending the envelope to a lock you supply yourself
+(this is how the OrdLock listing carries its inline inscription).
+
+The default `contentType` of `text/plain` still applies to **string** content, which is
+the common case and is truthfully described by it.
+
 ## Marketplace: the OrdLock covenant
 
 A listing locks the 1-sat ordinal behind a script with two spend paths: