@smartledger/bsv 6.0.0 → 6.0.2

package/docs/MODULE_REFERENCE_COMPLETE.md

@@ -55,19 +55,19 @@ Three advanced modules totaling **~2.7MB** of functionality:
 - **Purpose**: Threshold cryptography for secure secret distribution
 - **Use Cases**: Backup keys, multi-party security, key recovery
 - **Features**: Split secrets into N shares, require M to reconstruct
-- **CDN**: `unpkg.com/@smartledger/bsv@6.0.0/bsv-shamir.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@6.0.2/bsv-shamir.min.js`
 
 #### **🌐 Global Digital Attestation Framework - GDAF (1184KB)**  
 - **Purpose**: W3C Verifiable Credentials and decentralized identity
 - **Use Cases**: Identity verification, attestations, zero-knowledge proofs
 - **Features**: DID creation, credential issuance, selective disclosure
-- **CDN**: `unpkg.com/@smartledger/bsv@6.0.0/bsv-gdaf.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@6.0.2/bsv-gdaf.min.js`
 
 #### **⚖️ Legal Token Protocol - LTP (1184KB)**
 - **Purpose**: Legal compliance framework for tokenized assets
 - **Use Cases**: Property rights, obligations, compliant tokenization  
 - **Features**: Legal primitives, compliance checking, attestation anchoring
-- **CDN**: `unpkg.com/@smartledger/bsv@6.0.0/bsv-ltp.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@6.0.2/bsv-ltp.min.js`
 
 ### **2. Incorrect File Sizes in Documentation**
 
@@ -81,18 +81,18 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 | Module | Size | Use Case | CDN Link |
 |--------|------|----------|----------|
-| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js` |
-| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@6.0.0/bsv.bundle.js` |
-| **bsv-smartcontract.min.js** | 937KB | Covenant development | `unpkg.com/@smartledger/bsv@6.0.0/bsv-smartcontract.min.js` |
-| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@6.0.0/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@6.0.0/bsv-script-helper.min.js` |
-| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@6.0.0/bsv-security.min.js` |
-| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@6.0.0/bsv-ecies.min.js` |
-| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@6.0.0/bsv-message.min.js` |
-| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@6.0.0/bsv-mnemonic.min.js` |
-| **🆕 bsv-shamir.min.js** | 432KB | **Secret sharing** | `unpkg.com/@smartledger/bsv@6.0.0/bsv-shamir.min.js` |
-| **🆕 bsv-gdaf.min.js** | 1184KB | **Digital attestation** | `unpkg.com/@smartledger/bsv@6.0.0/bsv-gdaf.min.js` |
-| **🆕 bsv-ltp.min.js** | 1184KB | **Legal tokens** | `unpkg.com/@smartledger/bsv@6.0.0/bsv-ltp.min.js` |
+| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js` |
+| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@6.0.2/bsv.bundle.js` |
+| **bsv-smartcontract.min.js** | 937KB | Covenant development | `unpkg.com/@smartledger/bsv@6.0.2/bsv-smartcontract.min.js` |
+| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@6.0.2/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@6.0.2/bsv-script-helper.min.js` |
+| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@6.0.2/bsv-security.min.js` |
+| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@6.0.2/bsv-ecies.min.js` |
+| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@6.0.2/bsv-message.min.js` |
+| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@6.0.2/bsv-mnemonic.min.js` |
+| **🆕 bsv-shamir.min.js** | 432KB | **Secret sharing** | `unpkg.com/@smartledger/bsv@6.0.2/bsv-shamir.min.js` |
+| **🆕 bsv-gdaf.min.js** | 1184KB | **Digital attestation** | `unpkg.com/@smartledger/bsv@6.0.2/bsv-gdaf.min.js` |
+| **🆕 bsv-ltp.min.js** | 1184KB | **Legal tokens** | `unpkg.com/@smartledger/bsv@6.0.2/bsv-ltp.min.js` |
 
 ## 🎯 **Updated Usage Examples**
 
@@ -100,22 +100,22 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **1. Basic Development (~963KB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-script-helper.min.js"></script>
 ```
 
 #### **2. Smart Contract Development (~2.7MB — each bundle re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-smartcontract.min.js"></script>
 ```
 
 #### **3. 🆕 Legal & Compliance Development (~3.2MB — each bundle re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const legalToken = bsv.createLegalToken({
@@ -132,9 +132,9 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **4. 🆕 Security & Cryptography (~1.4MB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-shamir.min.js"></script>
 <script>
   // Shamir Secret Sharing
   const shares = bsv.splitSecret('my_secret_key', 5, 3); // 5 shares, 3 needed
@@ -146,7 +146,7 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **5. Everything Bundle (937KB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.bundle.js"></script>
 <script>
   // Everything available immediately
   const shares = bsv.splitSecret('secret', 5, 3);

package/docs/advanced/UTXO_MANAGER_GUIDE.md

@@ -722,7 +722,7 @@ interface UTXO {
 <html>
 <head>
     <title>UTXO Manager Demo</title>
-    <script src="https://cdn.jsdelivr.net/npm/@smartledger/bsv@6.0.0/bsv.min.js"></script>
+    <script src="https://cdn.jsdelivr.net/npm/@smartledger/bsv@6.0.2/bsv.min.js"></script>
 </head>
 <body>
     <script>

package/docs/getting-started/INSTALLATION.md

@@ -48,7 +48,7 @@ const tx: Transaction = new Transaction();
 #### **Core Library Only (937KB)**
 For basic Bitcoin SV operations:
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
 <script>
   const privateKey = new bsv.PrivateKey();
   const address = privateKey.toAddress();
@@ -58,7 +58,7 @@ For basic Bitcoin SV operations:
 #### **Complete Bundle (937KB)**  
 Everything in one file:
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.bundle.js"></script>
 <script>
   // All features available immediately
   const shares = bsv.splitSecret('secret', 5, 3);
@@ -71,9 +71,9 @@ Everything in one file:
 
 #### **Smart Contract Development (~2.7MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = bsv.SmartContract.createCovenantBuilder()
     .extractField('amount').push(50000).greaterThanOrEqual().build();
@@ -82,9 +82,9 @@ Everything in one file:
 
 #### **Legal & Identity Development (~3.2MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const propertyToken = bsv.createPropertyToken({
@@ -98,9 +98,9 @@ Everything in one file:
 
 #### **Security & Cryptography (~1.4MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-shamir.min.js"></script>
 <script>
   // Threshold Cryptography
   const shares = bsv.splitSecret('my_secret_key', 5, 3);
@@ -114,18 +114,18 @@ Everything in one file:
 
 | Module | Size | Purpose | CDN Link |
 |--------|------|---------|----------|
-| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js` |
-| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@6.0.0/bsv.bundle.js` |
-| **bsv-smartcontract.min.js** | 937KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@6.0.0/bsv-smartcontract.min.js` |
-| **bsv-ltp.min.js** | 1184KB | **Legal Token Protocol** | `unpkg.com/@smartledger/bsv@6.0.0/bsv-ltp.min.js` |
-| **bsv-gdaf.min.js** | 1184KB | **Digital Identity & Attestation** | `unpkg.com/@smartledger/bsv@6.0.0/bsv-gdaf.min.js` |
-| **bsv-shamir.min.js** | 432KB | **Threshold Cryptography** | `unpkg.com/@smartledger/bsv@6.0.0/bsv-shamir.min.js` |
-| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@6.0.0/bsv-security.min.js` |
-| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@6.0.0/bsv-mnemonic.min.js` |
-| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@6.0.0/bsv-ecies.min.js` |
-| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@6.0.0/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@6.0.0/bsv-script-helper.min.js` |
-| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@6.0.0/bsv-message.min.js` |
+| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js` |
+| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@6.0.2/bsv.bundle.js` |
+| **bsv-smartcontract.min.js** | 937KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@6.0.2/bsv-smartcontract.min.js` |
+| **bsv-ltp.min.js** | 1184KB | **Legal Token Protocol** | `unpkg.com/@smartledger/bsv@6.0.2/bsv-ltp.min.js` |
+| **bsv-gdaf.min.js** | 1184KB | **Digital Identity & Attestation** | `unpkg.com/@smartledger/bsv@6.0.2/bsv-gdaf.min.js` |
+| **bsv-shamir.min.js** | 432KB | **Threshold Cryptography** | `unpkg.com/@smartledger/bsv@6.0.2/bsv-shamir.min.js` |
+| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@6.0.2/bsv-security.min.js` |
+| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@6.0.2/bsv-mnemonic.min.js` |
+| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@6.0.2/bsv-ecies.min.js` |
+| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@6.0.2/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@6.0.2/bsv-script-helper.min.js` |
+| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@6.0.2/bsv-message.min.js` |
 
 ## ⚙️ **Development Environment Setup**
 

package/docs/getting-started/QUICK_START.md

@@ -14,10 +14,10 @@ npm install @smartledger/bsv
 ### Browser CDN (Instant)
 ```html
 <!-- Core library (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
 
 <!-- Everything included (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.bundle.js"></script>
 ```
 
 ## 💰 **Your First Transaction (60 seconds)**
@@ -127,19 +127,19 @@ SmartLedger-BSV offers 12 different loading options - use only what you need:
 
 ```html
 <!-- Core BSV only (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
 
 <!-- Smart contracts (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-smartcontract.min.js"></script>
 
 <!-- Legal tokens (1.16MB) -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-ltp.min.js"></script>
 
 <!-- Digital identity (1.16MB) -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-gdaf.min.js"></script>
 
 <!-- Everything (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.bundle.js"></script>
 ```
 
 ## ⚡ **Key Advantages**

package/docs/migration/FROM_BSV_1_5_6.md

@@ -159,17 +159,17 @@ const recovered = bsv.reconstructSecret([shares[0], shares[2], shares[4]]);
 ### **New Modular Options** 
 ```html
 <!-- Core compatibility (same size as bsv@1.5.6) -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.min.js"></script>
 
 <!-- Add smart contracts when ready -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-smartcontract.min.js"></script>
 
 <!-- Add advanced features as needed -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv-gdaf.min.js"></script>
 
 <!-- Everything in one file -->
-<script src="https://unpkg.com/@smartledger/bsv@6.0.0/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@6.0.2/bsv.bundle.js"></script>
 ```
 
 ## 🔍 **Testing Your Migration**

package/lib/ordinals/bsv20.js

@@ -24,13 +24,15 @@ var MAX_DEC = 18
 /** A non-negative integer string (no sign, no decimal point). */
 function isIntString (v) { return typeof v === 'string' && /^\d+$/.test(v) }
 
-/** Normalize an amount-like field to a non-negative integer string. */
+/** Normalize an amount-like field to a CANONICAL non-negative integer string (no leading zeros). */
 function normInt (v, name) {
   if (typeof v === 'number') {
     if (!Number.isInteger(v) || v < 0) throw new Error(name + ' must be a non-negative integer')
     return String(v)
   }
-  if (isIntString(v)) return v
+  // Strip leading zeros ("007" -> "7", "000" -> "0") so the emitted payload is canonical
+  // and not rejected by indexers that expect canonical decimal integers.
+  if (isIntString(v)) return v.replace(/^0+(?=\d)/, '')
   throw new Error(name + ' must be a non-negative integer (string or number)')
 }
 

package/lib/ordinals/ordlock.js

@@ -45,7 +45,6 @@ var inscription = require('./inscription')
 var Script = bsv.Script
 var Opcode = bsv.Opcode
 var BufferReader = bsv.encoding.BufferReader
-var BN = bsv.crypto.BN
 
 // OrdLock commits to the FULL output set (so payments can be pinned) but leaves the
 // input set open for the buyer's funding — SIGHASH_ALL|ANYONECANPAY|FORKID (0xc1).
@@ -57,6 +56,14 @@ function pushData (s, buf) { return (buf && buf.length) ? s.add(Buffer.from(buf)
 /** Serialize a Transaction.Output to its on-wire bytes (8-byte value || varint || script). */
 function serializeOutput (out) { return out.toBufferWriter().toBuffer() }
 
+/** Assert a value is a non-negative integer satoshi amount; return it. */
+function assertSats (v, label) {
+  if (typeof v !== 'number' || !isFinite(v) || v < 0 || Math.floor(v) !== v) {
+    throw new Error(label + ' must be a non-negative integer number of satoshis (got ' + v + ')')
+  }
+  return v
+}
+
 /** Coerce a Script, Buffer, or hex string to a Script. */
 function coerceScript (v) {
   if (v instanceof Script) return v
@@ -81,9 +88,13 @@ function resolvePubKeyHash (owner) {
   return toAddress(owner).hashBuffer
 }
 
-/** Build the seller's payment Output (P2PKH) from an address/pubkey/key and a price in sats. */
+/**
+ * Build the seller's payment Output (P2PKH) from an address/pubkey/key and a price in sats.
+ * A pre-built Transaction.Output is NOT accepted here — use it directly (or pass it as a
+ * `payOutputs`/`payTo` spec) — so that `price` is never silently ignored.
+ */
 function payOutputFor (payTo, price) {
-  if (payTo instanceof bsv.Transaction.Output) return payTo
+  assertSats(price, 'payment price')
   return new bsv.Transaction.Output({
     script: Script.buildPublicKeyHashOut(toAddress(payTo)), satoshis: price
   })
@@ -112,7 +123,10 @@ function resolvePayOutputs (params) {
   }
   if (params.payOutput != null) return [outputFromSpec(params.payOutput)]
   if (params.price != null) {
-    var arr = [payOutputFor(params.payTo != null ? params.payTo : params.seller, params.price)]
+    var payTo = params.payTo != null ? params.payTo : params.seller
+    // A pre-built Output as payTo is used verbatim (its own value); otherwise build P2PKH(price).
+    var first = (payTo instanceof bsv.Transaction.Output) ? payTo : payOutputFor(payTo, params.price)
+    var arr = [first]
     if (params.royalties) params.royalties.forEach(function (r) { arr.push(outputFromSpec(r)) })
     return arr
   }
@@ -193,6 +207,9 @@ function splitPayBlob (blob) {
  * is not a recognizable OrdLock (so it doubles as a detector).
  *
  * @param {Script|Buffer|string} script
+ * @param {object} [opts]  { network }  network for the returned address strings
+ *   ('livenet' | 'testnet' | a bsv.Networks.Network); defaults to livenet. The
+ *   pubKeyHash / output scripts are network-agnostic and always exact.
  * @returns {null|{
  *   seller: { pubKeyHash: Buffer, address: string },
  *   payOutputs: Array<{ satoshis: number, script: Script, address: string|null }>,
@@ -201,7 +218,8 @@ function splitPayBlob (blob) {
  *   inscription: null|{ contentType: string, content: Buffer, contentText: string }
  * }}
  */
-function parseOrdLock (script) {
+function parseOrdLock (script, opts) {
+  var network = opts && opts.network
   try {
     var s = coerceScript(script)
     var chunks = s.chunks
@@ -239,7 +257,7 @@ function parseOrdLock (script) {
 
     var payOutputs = splitPayBlob(payBlob).map(function (o) {
       var addr = null
-      try { if (o.script.isPublicKeyHashOut()) addr = o.script.toAddress().toString() } catch (e) {}
+      try { if (o.script.isPublicKeyHashOut()) addr = o.script.toAddress(network).toString() } catch (e) {}
       return { satoshis: o.satoshis, script: o.script, address: addr }
     })
     var totalPrice = payOutputs.reduce(function (a, o) { return a + o.satoshis }, 0)
@@ -251,7 +269,7 @@ function parseOrdLock (script) {
     }
 
     return {
-      seller: { pubKeyHash: sellerPKH, address: bsv.Address.fromPublicKeyHash(sellerPKH).toString() },
+      seller: { pubKeyHash: sellerPKH, address: bsv.Address.fromPublicKeyHash(sellerPKH, network).toString() },
       payOutputs: payOutputs,
       payBlob: payBlob,
       totalPrice: totalPrice,
@@ -263,7 +281,7 @@ function parseOrdLock (script) {
 }
 
 /** True if `script` is a recognizable OrdLock listing. */
-function isOrdLock (script) { return parseOrdLock(script) !== null }
+function isOrdLock (script, opts) { return parseOrdLock(script, opts) !== null }
 
 /**
  * Build the 1-sat Transaction.Output that lists an ordinal for sale under an OrdLock.
@@ -312,7 +330,8 @@ function purchase (params) {
   var satoshis = params.satoshis != null ? params.satoshis : 1
   var outs = spend.outputs || []
 
-  var parsed = parseOrdLock(lockingScript)
+  // Reuse a caller-supplied parse of the SAME lockingScript when given (avoids re-parsing).
+  var parsed = params.parsed || parseOrdLock(lockingScript)
   var payoutCount = params.payoutCount != null ? params.payoutCount
     : (parsed ? parsed.payOutputs.length : 1)
   if (payoutIndex + payoutCount > outs.length) {
@@ -389,6 +408,9 @@ function addSpendInput (tx, outpoint, script, satoshis) {
 
 /** Sign input `idx` as P2PKH with `coin.privateKey` over the finalized tx (ALL|FORKID). */
 function signP2PKHInput (tx, idx, coin) {
+  // The satoshi amount is part of the BIP-143 preimage — a missing/NaN value silently
+  // produces a signature over the wrong amount that fails on-chain, so require it explicitly.
+  assertSats(coin.satoshis, 'input ' + idx + ' satoshis')
   var sc = coerceScript(coin.script)
   var sig = H.signInput(tx, coin.privateKey, idx, sc, coin.satoshis, P.SIGHASH_ALL_FORKID)
   var us = new Script()
@@ -419,12 +441,12 @@ function buildListingTx (params) {
   if (!ordinal || !ordinal.script || !ordinal.privateKey) {
     throw new Error('buildListingTx requires ordinal { script, privateKey, txid, outputIndex }')
   }
-  var ordSats = ordinal.satoshis != null ? ordinal.satoshis : 1
+  var ordSats = assertSats(ordinal.satoshis != null ? ordinal.satoshis : 1, 'ordinal satoshis')
   var lock = buildOrdLock(params)
 
   var funding = params.funding || []
   var fee = params.fee != null ? params.fee : 500
-  var fundingTotal = funding.reduce(function (a, f) { return a + f.satoshis }, 0)
+  var fundingTotal = funding.reduce(function (a, f) { return a + assertSats(f.satoshis, 'funding satoshis') }, 0)
   var change = fundingTotal - fee
   if (change < 0) {
     throw new Error('buildListingTx: insufficient funding — need ' + fee + ' sat fee, funded ' + fundingTotal)
@@ -439,7 +461,9 @@ function buildListingTx (params) {
     tx.addOutput(payOutputFor(params.changeAddress || ordinal.privateKey.toAddress(), change))
   }
 
-  signP2PKHInput(tx, 0, ordinal)
+  // Sign the ordinal input with the RESOLVED value (ordSats), not the raw (maybe-omitted)
+  // ordinal.satoshis — else the signature commits to the wrong amount and fails on-chain.
+  signP2PKHInput(tx, 0, { script: ordinal.script, privateKey: ordinal.privateKey, satoshis: ordSats })
   funding.forEach(function (f, i) { signP2PKHInput(tx, 1 + i, f) })
 
   return { tx: tx, listingScript: lock, listingOutpoint: { txid: tx.hash, outputIndex: 0 } }
@@ -477,7 +501,7 @@ function buildPurchaseTx (params) {
   var lockingScript = coerceScript(listing.script)
   var parsed = parseOrdLock(lockingScript)
   if (!parsed) throw new Error('buildPurchaseTx: listing.script is not a parseable OrdLock')
-  var ordSats = listing.satoshis != null ? listing.satoshis : 1
+  var ordSats = assertSats(listing.satoshis != null ? listing.satoshis : 1, 'listing satoshis')
 
   var payOuts = params.payOutputs
     ? params.payOutputs.map(outputFromSpec)
@@ -487,7 +511,7 @@ function buildPurchaseTx (params) {
   var paidTotal = payOuts.reduce(function (a, o) { return a + o.satoshis }, 0)
 
   var fee = params.fee != null ? params.fee : 500
-  var fundingTotal = params.funding.reduce(function (a, f) { return a + f.satoshis }, 0)
+  var fundingTotal = params.funding.reduce(function (a, f) { return a + assertSats(f.satoshis, 'funding satoshis') }, 0)
   var change = fundingTotal - paidTotal - fee
   if (change < 0) {
     throw new Error('buildPurchaseTx: insufficient funding — need ' + (paidTotal + fee) +
@@ -508,6 +532,7 @@ function buildPurchaseTx (params) {
   purchase({
     spend: tx,
     lockingScript: lockingScript,
+    parsed: parsed, // reuse the parse above — don't re-parse inside purchase()
     satoshis: ordSats,
     inputIndex: 0,
     payoutIndex: 1,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartledger/bsv",
-  "version": "6.0.0",
+  "version": "6.0.2",
   "description": "🚀 Complete Bitcoin SV development framework with legally-recognizable DID:web + W3C VC-JWT toolkit, Legal Token Protocol (LTP), Global Digital Attestation Framework (GDAF), StatusList2021 revocation, and 16 flexible loading options. Standards-based credentials with ES256/ES256K support, on-chain BSV anchoring, and comprehensive Bitcoin SV API. Perfect for legal tokens, verifiable credentials, DeFi, smart contracts, and secure Bitcoin applications.",
   "author": "SmartLedger Technology <hello@smartledger.technology> (https://smartledger.technology)",
   "homepage": "https://github.com/codenlighten/smartledger-bsv#readme",
@@ -9,6 +9,9 @@
   },
   "main": "index.js",
   "types": "bsv.d.ts",
+  "engines": {
+    "node": ">=20.19.0"
+  },
   "bin": {
     "smartledger-bsv": "./bin/cli.js"
   },

package/test/ordinals/bsv20.js

@@ -66,6 +66,16 @@ describe('Ordinals BSV-20 fungible tokens', function () {
     p.amt.should.equal('42')
   })
 
+  // Code-review finding #4: leading-zero integer strings are canonicalized (indexers expect
+  // canonical decimals), while preserving arbitrary precision.
+  it('canonicalizes leading-zero amount strings', function () {
+    B.parseBsv20(B.buildMint({ address: address, tick: 'ORDI', amt: '007' })).amt.should.equal('7')
+    B.parseBsv20(B.buildDeploy({ address: address, tick: 'ORDI', max: '000100' })).max.should.equal('100')
+    // canonicalization does not corrupt a huge value
+    var huge = '90000000000000000000000000'
+    B.parseBsv20(B.buildMint({ address: address, tick: 'ORDI', amt: '0' + huge })).amt.should.equal(huge)
+  })
+
   it('builds a 1-sat token output', function () {
     var out = B.createMintOutput({ address: address, tick: 'ORDI', amt: '1' })
     out.satoshis.should.equal(1)

package/test/ordinals/ordlock.js

@@ -480,3 +480,73 @@ describe('Ordinals OrdLock — full lifecycle (list -> buy / cancel)', function
     }).should.throw(/insufficient funding/)
   })
 })
+
+describe('Ordinals OrdLock — code-review regressions', function () {
+  this.timeout(20000)
+  var I = bsv.Script.Interpreter
+  var saved
+  before(function () {
+    saved = { el: I.MAX_SCRIPT_ELEMENT_SIZE, num: I.MAXIMUM_ELEMENT_SIZE, ops: I.MAX_OPS_PER_SCRIPT }
+    SC.enableGenesis()
+  })
+  after(function () {
+    I.MAX_SCRIPT_ELEMENT_SIZE = saved.el
+    I.MAXIMUM_ELEMENT_SIZE = saved.num
+    I.MAX_OPS_PER_SCRIPT = saved.ops
+  })
+
+  var owner = PrivateKey.fromRandom()
+  var fundKey = PrivateKey.fromRandom()
+  var ownerScript = bsv.Script.buildPublicKeyHashOut(owner.toAddress())
+  var fundScript = bsv.Script.buildPublicKeyHashOut(fundKey.toAddress())
+
+  // Finding #1: buildListingTx must sign the ordinal input with the resolved value even
+  // when the caller omits ordinal.satoshis (documented to default to 1).
+  it('buildListingTx signs a valid ordinal input when ordinal.satoshis is omitted', function () {
+    var out = Ord.buildListingTx({
+      ordinal: { txid: '0e'.repeat(32), outputIndex: 0, script: ownerScript, privateKey: owner }, // no satoshis
+      seller: owner.toAddress(),
+      price: PRICE,
+      funding: [{ txid: 'f0'.repeat(32), outputIndex: 0, script: fundScript, satoshis: 20000, privateKey: fundKey }],
+      fee: 500
+    })
+    verify(out.tx.inputs[0].script, ownerScript, { tx: out.tx, satoshis: 1, inputIndex: 0 }).ok.should.equal(true)
+  })
+
+  // Finding #2: parsed addresses honor a network option instead of always being livenet.
+  it('parseOrdLock formats addresses for the requested network', function () {
+    var lock = Ord.buildOrdLock({ seller: owner.toAddress(), price: PRICE })
+    var live = Ord.parseOrdLock(lock).seller.address
+    var test = Ord.parseOrdLock(lock, { network: 'testnet' }).seller.address
+    live.should.not.equal(test)
+    bsv.Address.fromString(test).network.name.should.equal('testnet')
+    bsv.Address.fromString(live).network.name.should.equal('livenet')
+  })
+
+  // Finding #3: a funding coin missing satoshis fails fast (was a silent wrong-amount signature).
+  it('buildPurchaseTx throws when a funding coin has no satoshis', function () {
+    var lock = Ord.buildOrdLock({ seller: owner.toAddress(), price: PRICE })
+    ;(function () {
+      Ord.buildPurchaseTx({
+        listing: { txid: 'a1'.repeat(32), outputIndex: 0, script: lock, satoshis: 1 },
+        ordinalDestination: fundKey.toAddress(),
+        funding: [{ txid: 'b1'.repeat(32), outputIndex: 0, script: fundScript, privateKey: fundKey }], // no satoshis
+        fee: 500
+      })
+    }).should.throw(/satoshis/)
+  })
+
+  // Finding #5: payOutputFor never silently ignores price when handed a full Output.
+  it('payOutputFor rejects a Transaction.Output (price would be ignored)', function () {
+    var o = new bsv.Transaction.Output({ script: ownerScript, satoshis: 5 })
+    ;(function () { Ord.payOutputFor(o, PRICE) }).should.throw()
+  })
+
+  it('buildOrdLock still accepts a pre-built Output as payTo (uses its own value)', function () {
+    var lock = Ord.buildOrdLock({
+      seller: owner.toAddress(), price: 1,
+      payTo: new bsv.Transaction.Output({ script: ownerScript, satoshis: 777 })
+    })
+    Ord.parseOrdLock(lock).totalPrice.should.equal(777)
+  })
+})