@smartledger/bsv 4.5.0 → 5.0.0

package/CHANGELOG.md

@@ -5,6 +5,108 @@ All notable changes to SmartLedger-BSV will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [5.0.0] - 2026-06-13
+
+### BREAKING — Shamir Secret Sharing now uses a vetted GF(2⁸) engine
+
+`crypto.Shamir` previously used a hand-rolled finite-field implementation over a
+31-bit prime, with no authentication of shares. It is now backed by
+`secrets.js-grempe` (a vetted GF(2⁸) implementation), with two safety additions:
+a per-split nonce (`splitId`) so shares from different splits can't be silently
+mixed, and an integrity `checksum` so a tampered/mismatched share set is rejected
+at combine time instead of returning garbage.
+
+- **New share format (v2).** `split()` returns objects shaped
+  `{ v, id, threshold, shares, length, splitId, share, checksum }` instead of the
+  old `{ id, threshold, shares, length, bytes:[{x,y}] }`.
+- **Old shares remain recoverable.** `combine()` and `verifyShare()` detect and
+  accept legacy (≤ 4.x) shares for recovery; you do not need the old version to
+  reconstruct previously-split secrets.
+- Randomness is sourced from the library's own `crypto.Random` (Node CSPRNG /
+  `window.crypto`) via `secrets.setRNG`, and `secrets` is loaded lazily so simply
+  importing the library never triggers its init.
+- New coverage in `test/crypto/shamir.js` (round-trips, threshold subsets,
+  leading-zero/Buffer secrets, tamper detection, split isolation, legacy
+  recovery).
+
+Browser bundles that bundle the full library no longer mock node `crypto` as
+empty (`bsv.min.js`, `bsv.bundle.js`, `bsv-security.min.js`); webpack's default
+`crypto` polyfill is used so Shamir can obtain a CSPRNG. This increases the size
+of the full bundles (e.g. `bsv.min.js` ~951 KB → ~1.2 MB); the dedicated
+non-Shamir module bundles are unaffected.
+
+### BREAKING — VC-JWT signatures are now JOSE-compliant (IEEE P1363)
+
+Up to and including 4.6.0, `VcJwt.issueVcJwt` signed with Node's default
+ECDSA output, which is **DER-encoded**. The JOSE specs (RFC 7515/7518, and
+RFC 8812 for ES256K) require ECDSA JWS signatures to be the raw `r||s`
+concatenation (**IEEE P1363**). As a result, tokens issued by older versions
+**did not verify in any standards-compliant library** (`jose`, `jsonwebtoken`,
+etc.), and this library could not verify standard tokens from other issuers.
+This also affected `StatusList`, which issues its lists via `VcJwt`.
+
+- **`VcJwt.issueVcJwt`** now emits P1363 signatures and is verifiable by `jose`.
+- **`VcJwt.verifyVcJwt`** now decodes P1363 signatures.
+- **Migration:** tokens issued by ≤ 4.6.0 carry DER signatures and will fail
+  verification by default. Pass `{ allowLegacyDER: true }` to `verifyVcJwt` to
+  accept them while you re-issue. New tokens require no flag.
+- Round-trip interoperability with `jose` (both directions, ES256 + ES256K) is
+  now covered by `test/vcjwt/interop.js`.
+
+### Security
+
+- **VC-JWT algorithm pinning.** `verifyVcJwt` now rejects any token whose
+  `alg` is not in the allowed set (default `['ES256','ES256K']`, overridable via
+  `opts.allowedAlgs`) **before** verifying — closing the classic JWT algorithm
+  substitution hole. It also binds the resolved key's curve to the algorithm
+  (an ES256K signature can no longer be checked against a P-256 key), and
+  `issueVcJwt` refuses to sign when the key curve and `alg` disagree.
+- **`crypto/elliptic-fixed` low-S now preserves `recoveryParam`.** The previous
+  manual `s → n-s` flip did not update the recovery id, so public-key recovery
+  returned the wrong key for ~50% of signatures. Canonicalization now uses
+  elliptic's own `{ canonical: true }`, which keeps `recoveryParam` consistent.
+- **ECIES MAC check is now constant-time** (portable comparison; no early-out
+  on the first differing byte).
+
+### Fixed
+
+- **Removed the self-referential dependency.** `package.json` listed
+  `@smartledger/bsv` as one of its own `dependencies`, causing npm to install a
+  nested older copy of the package and triggering the "More than one instance of
+  bsv" guard. Removed.
+
+### Changed
+
+- Deduplicated `package.json` keywords (86 → 79).
+- `bsv.SmartUTXO` removal pushed from v5.0.0 to v6.0.0 (still soft-deprecated).
+
+## [4.6.0] - 2026-06-09
+
+### Fixed — covenants are now mainnet-relayable (MINIMALDATA)
+
+OP_PUSH_TX covenants up to 4.5.0 were consensus-valid but **non-standard**: their
+locking scripts contained non-minimal data pushes, so every mainnet miner
+rejected the spend with `non-mandatory-script-verify-flag (Data push larger than
+necessary)` = `SCRIPT_ERR_MINIMALDATA`. Found by actually broadcasting to BSV
+mainnet (WhatsOnChain/Taal **and** GorillaPool ARC both rejected it).
+
+The non-minimal pushes were: a bare `0x00` sign byte, a bare `0x02` pubkey
+prefix, and small integers (3/4/8) pushed as data. Fixes:
+
+- **`PushTx.pushTxCore`**: drop the `0x00` sign-extension — the grind now requires
+  `z[0]` (first byte of HASH256(preimage)) to be `0x01..0x7f`, so the hash is
+  already a positive, minimally-encoded number. Use `OP_2` for the pubkey prefix.
+- **`CovenantHelpers.scriptNum`**: emit `OP_0`/`OP_1..OP_16`/`OP_1NEGATE` for
+  `0..16`/`-1` instead of a data push (fixes PELS, token, and the DSL's
+  `lockUntil`).
+- **`CovenantHelpers.flags`**: now includes `SCRIPT_VERIFY_MINIMALDATA`, so local
+  `verifyScript`/`trace` mirror real mainnet relay policy and catch non-relayable
+  covenants before broadcast.
+
+A value covenant built with this release was **deployed and spent on BSV
+mainnet** (txids `f9f25dbd…` deploy, `ea438096…` spend). Full suite 4206 passing,
+lint clean.
+
 ## [4.5.0] - 2026-06-09
 
 ### Added — declarative covenant DSL + stack debugger

package/README.md

@@ -181,42 +181,42 @@ console.log('Status:', status) // 'revoked'
 ### **Core Modules**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js` |
-| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@4.2.1/bsv.bundle.js` |
+| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js` |
+| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@5.0.0/bsv.bundle.js` |
 
 ### **W3C Verifiable Credentials**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **🟢 bsv-didweb.min.js** | 419KB | **DID:web generation** | `unpkg.com/@smartledger/bsv@4.2.1/bsv-didweb.min.js` |
-| **🟢 bsv-vcjwt.min.js** | 419KB | **VC-JWT issue/verify** | `unpkg.com/@smartledger/bsv@4.2.1/bsv-vcjwt.min.js` |
-| **🟢 bsv-statuslist.min.js** | 487KB | **StatusList2021 revocation** | `unpkg.com/@smartledger/bsv@4.2.1/bsv-statuslist.min.js` |
-| **🟢 bsv-anchor.min.js** | 418KB | **BSV anchoring (hash-only)** | `unpkg.com/@smartledger/bsv@4.2.1/bsv-anchor.min.js` |
+| **🟢 bsv-didweb.min.js** | 419KB | **DID:web generation** | `unpkg.com/@smartledger/bsv@5.0.0/bsv-didweb.min.js` |
+| **🟢 bsv-vcjwt.min.js** | 419KB | **VC-JWT issue/verify** | `unpkg.com/@smartledger/bsv@5.0.0/bsv-vcjwt.min.js` |
+| **🟢 bsv-statuslist.min.js** | 487KB | **StatusList2021 revocation** | `unpkg.com/@smartledger/bsv@5.0.0/bsv-statuslist.min.js` |
+| **🟢 bsv-anchor.min.js** | 418KB | **BSV anchoring (hash-only)** | `unpkg.com/@smartledger/bsv@5.0.0/bsv-anchor.min.js` |
 
 ### **Smart Contract & Development**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-smartcontract.min.js** | 937KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@4.2.1/bsv-smartcontract.min.js` |
-| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@4.2.1/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@4.2.1/bsv-script-helper.min.js` |
-| **bsv-security.min.js** | 26KB | Security enhancements | `unpkg.com/@smartledger/bsv@4.2.1/bsv-security.min.js` |
+| **bsv-smartcontract.min.js** | 937KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@5.0.0/bsv-smartcontract.min.js` |
+| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@5.0.0/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@5.0.0/bsv-script-helper.min.js` |
+| **bsv-security.min.js** | 26KB | Security enhancements | `unpkg.com/@smartledger/bsv@5.0.0/bsv-security.min.js` |
 
 ### **Legal & Compliance**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-ltp.min.js** | 1184KB | Legal Token Protocol | `unpkg.com/@smartledger/bsv@4.2.1/bsv-ltp.min.js` |
-| **bsv-gdaf.min.js** | 1184KB | Digital Identity & Attestation | `unpkg.com/@smartledger/bsv@4.2.1/bsv-gdaf.min.js` |
+| **bsv-ltp.min.js** | 1184KB | Legal Token Protocol | `unpkg.com/@smartledger/bsv@5.0.0/bsv-ltp.min.js` |
+| **bsv-gdaf.min.js** | 1184KB | Digital Identity & Attestation | `unpkg.com/@smartledger/bsv@5.0.0/bsv-gdaf.min.js` |
 
 ### **Advanced Cryptography**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-shamir.min.js** | 432KB | Threshold Cryptography | `unpkg.com/@smartledger/bsv@4.2.1/bsv-shamir.min.js` |
+| **bsv-shamir.min.js** | 432KB | Threshold Cryptography | `unpkg.com/@smartledger/bsv@5.0.0/bsv-shamir.min.js` |
 
 ### **Utilities**
 | Module | Size | Use Case | CDN |
 |--------|------|----------|-----|
-| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@4.2.1/bsv-ecies.min.js` |
-| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@4.2.1/bsv-message.min.js` |
-| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@4.2.1/bsv-mnemonic.min.js` |
+| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@5.0.0/bsv-ecies.min.js` |
+| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@5.0.0/bsv-message.min.js` |
+| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@5.0.0/bsv-mnemonic.min.js` |
 
 ## ⚡ **2-Minute Quick Start**
 
@@ -227,7 +227,7 @@ Get started with Bitcoin SV development in under 2 minutes:
 npm install @smartledger/bsv
 
 # Or include in HTML
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js"></script>
 ```
 
 > **🔧 v4.x:** First-class interpreter-verified covenants (4.2.0), post-Genesis
@@ -325,8 +325,8 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🔧 **Basic Development** (~963KB total)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-script-helper.min.js"></script>
 <script>
   const privateKey = new bsv.PrivateKey();
   const utxos = new bsv.SmartContract.UTXOGenerator().createRealUTXOs(2, 100000);
@@ -335,9 +335,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🔒 **Smart Contract Development** (~2.7MB total — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = bsv.SmartContract.createCovenantBuilder()
     .extractField('amount').push(50000).greaterThanOrEqual().verify().build();
@@ -347,9 +347,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🆕 **Legal & Identity Development** (~3.2MB total — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const propertyToken = bsv.createPropertyToken({
@@ -363,9 +363,9 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🆕 **Security & Cryptography** (~1.4MB total)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-shamir.min.js"></script>
 <script>
   // Threshold Cryptography
   const shares = bsv.splitSecret('my_secret_key', 5, 3); // 5 shares, 3 needed
@@ -377,7 +377,7 @@ const covenant = bsv.SmartContract.createCovenantBuilder()
 
 ### 🎯 **Everything Bundle** (937KB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.bundle.js"></script>
 <script>
   // Everything available immediately
   const shares = bsv.splitSecret('secret', 5, 3);           // Shamir Secret Sharing
@@ -457,8 +457,8 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 1. **Minimal Setup** - Core + Script Helper (~963KB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-script-helper.min.js"></script>
 <script>
   const tx = new bsv.Transaction();
   const sig = bsvScriptHelper.createSignature(tx, privateKey, 0, script, satoshis);
@@ -467,9 +467,9 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 2. **DeFi Development** - Core + Covenants + Debug (~2.7MB — each bundle re-embeds core BSV)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = new bsvCovenant.CovenantInterface();
   const debugInfo = SmartContract.interpretScript(script);
@@ -479,8 +479,8 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 3. **Security First** - Core + Enhanced Security (~963KB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv-security.min.js"></script>
 <script>
   const verified = bsvSecurity.SmartVerify.verify(signature, hash, publicKey);
   const enhanced = bsvSecurity.EllipticFixed.createSignature(privateKey, hash);
@@ -489,7 +489,7 @@ const contractTx = covenant.createCovenantTransaction({
 
 #### 4. **Everything Bundle** - One File Solution (937KB)
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@4.2.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@5.0.0/bsv.bundle.js"></script>
 <script>
   // Everything available under bsv namespace
   const keys = bsv.SmartLedgerBundle.generateKeys();
@@ -789,7 +789,7 @@ const timelockScript = helper.createTimelockScript(
 
 See the **[16 Loading Options](#-16-loading-options---choose-your-approach)**
 table near the top for the full list of bundles with current sizes and
-canonical `unpkg.com/@smartledger/bsv@4.2.1/...` URLs.
+canonical `unpkg.com/@smartledger/bsv@5.0.0/...` URLs.
 
 ## 🔐 Security