@smartledger/bsv 4.5.0 → 4.6.0

package/lib/smart_contract/covenant_helpers.js

@@ -17,15 +17,18 @@ var Signature = require('../crypto/signature')
 // SIGHASH_ALL | SIGHASH_FORKID — the BSV default these covenants are built for.
 var SIGHASH = Signature.SIGHASH_ALL | Signature.SIGHASH_FORKID // 0x41
 
-// Post-Genesis consensus flags (big numbers, OP_CAT/OP_SPLIT/OP_MUL, FORKID,
-// CLTV/CSV). LOW_S is enforced: the OP_PUSH_TX grind produces a canonical
-// (low-S) in-script signature, so these covenants meet mainnet standardness.
+// Post-Genesis consensus + STANDARD RELAY flags — what mainnet miners actually
+// enforce. Includes SCRIPT_VERIFY_MINIMALDATA (every push must be minimal) and
+// SCRIPT_VERIFY_LOW_S (canonical signatures). Verifying with these locally
+// catches non-relayable covenants BEFORE broadcast — covenants verified here
+// have been deployed and spent on BSV mainnet.
 function flags () {
   var I = bsv.Script.Interpreter
   return I.SCRIPT_VERIFY_P2SH |
     I.SCRIPT_VERIFY_STRICTENC |
     I.SCRIPT_VERIFY_DERSIG |
     I.SCRIPT_VERIFY_LOW_S |
+    I.SCRIPT_VERIFY_MINIMALDATA |
     I.SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY |
     I.SCRIPT_VERIFY_CHECKSEQUENCEVERIFY |
     I.SCRIPT_ENABLE_SIGHASH_FORKID |
@@ -102,6 +105,13 @@ function p2pkhOutput (addressOrPubKey, satoshis) {
 
 /** Minimal little-endian script-number Buffer (push as data to put a number on-stack). */
 function scriptNum (n) {
+  // Minimal on-stack number: 0..16 and -1 use the dedicated opcodes (OP_0..OP_16,
+  // OP_1NEGATE) instead of a data push, so covenant scripts stay MINIMALDATA-clean
+  // (mainnet relay policy). Larger values use a minimal scriptNum push. The result
+  // is passed to Script.add(), which accepts an opcode number or a Buffer.
+  if (n === 0) return bsv.Opcode.OP_0
+  if (n === -1) return bsv.Opcode.OP_1NEGATE
+  if (n >= 1 && n <= 16) return bsv.Opcode['OP_' + n]
   return new BN(n).toScriptNumBuffer()
 }
 

package/lib/smart_contract/pushtx.js

@@ -54,8 +54,9 @@ function reverseBytes (script, n) {
  */
 function pushTxCore (script) {
   script.add(Opcode.OP_HASH256) // z = HASH256(preimage), 32B BE
-  reverseBytes(script, 32) // -> little-endian
-  script.add(Buffer.from([0x00])).add(Opcode.OP_CAT).add(Opcode.OP_BIN2NUM) // e (positive)
+  reverseBytes(script, 32) // -> little-endian = e. The grind guarantees e is
+  // already positive and minimally encoded (z[0] in 0x01..0x7f), so NO 0x00 sign
+  // byte is appended — keeping the script MINIMALDATA-clean (mainnet-relayable).
   script.add(gxLe).add(Opcode.OP_ADD) // e + Gx
   script.add(N_LE).add(Opcode.OP_MOD) // s = (e + Gx) mod n
   script.add(scriptNum(32)).add(Opcode.OP_NUM2BIN) // s -> 32-byte LE
@@ -64,7 +65,7 @@ function pushTxCore (script) {
   // r-value inside the DER prefix and the body of the 02||Gx pubkey). Sharing it
   // via the altstack saves a 32-byte constant vs. embedding Gx twice.
   script.add(Gx).add(Opcode.OP_DUP) // [s_be, Gx, Gx]
-  script.add(Buffer.from([0x02])).add(Opcode.OP_SWAP).add(Opcode.OP_CAT) // pubkey = 02||Gx
+  script.add(Opcode.OP_2).add(Opcode.OP_SWAP).add(Opcode.OP_CAT) // pubkey = 02||Gx (OP_2 = minimal push of 0x02)
   script.add(Opcode.OP_TOALTSTACK) // park pubkey ; [s_be, Gx]
   script.add(Buffer.from([0x30, 0x44, 0x02, 0x20])).add(Opcode.OP_SWAP).add(Opcode.OP_CAT) // 30440220||Gx
   script.add(Buffer.from([0x02, 0x20])).add(Opcode.OP_CAT) // ||0220  => DER prefix
@@ -117,6 +118,10 @@ var HALF_N = new BN('7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF5D576E7357A4501DDFE92F46681
  */
 function sFromPreimage (preimage) {
   var z = Hash.sha256sha256(preimage)
+  // Script no longer sign-extends z, so e (= reverse(z) as a number) must be
+  // positive AND minimally encoded: its little-endian MSB (= z[0]) in 0x01..0x7f.
+  // This keeps the locking script MINIMALDATA-clean (mainnet-relayable).
+  if (z[0] < 0x01 || z[0] > 0x7f) return null
   var s = new BN(z).add(new BN(Gx)).mod(N)
   if (s.gt(HALF_N)) return null // enforce low-S (canonical / non-malleable)
   var sBE = s.toBuffer('be', 32)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartledger/bsv",
-  "version": "4.5.0",
+  "version": "4.6.0",
   "description": "🚀 Complete Bitcoin SV development framework with legally-recognizable DID:web + W3C VC-JWT toolkit, Legal Token Protocol (LTP), Global Digital Attestation Framework (GDAF), StatusList2021 revocation, and 16 flexible loading options. Standards-based credentials with ES256/ES256K support, on-chain BSV anchoring, and comprehensive Bitcoin SV API. Perfect for legal tokens, verifiable credentials, DeFi, smart contracts, and secure Bitcoin applications.",
   "author": "SmartLedger Technology <hello@smartledger.technology> (https://smartledger.technology)",
   "homepage": "https://github.com/codenlighten/smartledger-bsv#readme",