@smartive/eslint-config 7.0.0 → 7.0.2

package/README.md

@@ -24,7 +24,7 @@ export default config('typescript');
 export default config('react');
 
 // .. or Next.js applications
-// make sure to add `eslint-config-next@16` 
+// make sure to add `eslint-config-next@16`
 // to your devDependencies
 export default config('nextjs');
 ```
@@ -35,7 +35,22 @@ To use eslint add the following to your package.json:
 
 ```json
 "scripts": {
-  "lint": "eslint .",
-  "lint:fix": "eslint . --fix"
+  "lint": "eslint {your source directory}",
+  "lint:fix": "eslint {your source directory} --fix"
 }
 ```
+
+## Development
+
+```sh
+$ npm run check-types  # type-check the config sources
+$ npm run prettier     # formatting
+$ npm test             # build, type-check the tests, then run them
+```
+
+The tests in `test/` lint the fixtures in `test/fixtures/` with each of the three rule sets and assert that
+a given fixture line is flagged. They deliberately never assert on rule ids, so that swapping out a plugin
+for an equivalent one does not require rewriting them.
+
+> `npm test` runs the TypeScript test files directly through Node's type stripping, which needs Node
+> 22.18 or newer.

package/dist/configs.js

@@ -29,6 +29,18 @@ const baseConfig = {
         },
     },
 };
+/**
+ * Type-aware rules cannot run on plain JavaScript.
+ *
+ * This has to come *after* every block that switches such a rule on — `typescriptRules` in
+ * `baseConfig` and `reactRules` both do — because in flat config the later block wins. Applied too
+ * early, ESLint fails with "You have used a rule which requires type information" on `.js` files.
+ */
+const jsDisableTypeChecked = {
+    name: '@smartive/eslint-config/js-disable-type-checked',
+    files: ['**/*.js', '**/*.mjs'],
+    rules: tsEslint.configs.disableTypeChecked.rules,
+};
 const reactConfig = { name: '@smartive/eslint-config/react', rules: reactRules };
 export const flatConfigTypescript = (rulesOnly = false) => defineConfig([
     js.configs.recommended,
@@ -36,6 +48,12 @@ export const flatConfigTypescript = (rulesOnly = false) => defineConfig([
     ...(rulesOnly
         ? [
             {
+                // `eslint-config-next` registers this plugin, but only for `**/*.ts` and `**/*.tsx`. Without
+                // registering it here, every `@typescript-eslint/*` rule reference — these, plus the ones in
+                // `typescriptRules` and `reactRules` — makes ESLint fail with `Could not find plugin` the
+                // moment a `.js` file is linted. Registering it twice is harmless: it is the same instance,
+                // since npm dedupes `typescript-eslint` between this package and `eslint-config-next`.
+                plugins: { '@typescript-eslint': tsEslint.plugin },
                 rules: tsEslintConfigs.reduce((combinedRules, { rules }) => ({ ...combinedRules, ...(rules ? rules : {}) }), {}),
             },
         ]
@@ -56,11 +74,8 @@ export const flatConfigTypescript = (rulesOnly = false) => defineConfig([
             ...tsEslint.configs.recommendedTypeChecked,
             ...tsEslint.configs.stylisticTypeChecked,
         ]),
-    {
-        files: ['**/*.js', '**/*.mjs'],
-        extends: [tsEslint.configs.disableTypeChecked],
-    },
     baseConfig,
+    jsDisableTypeChecked,
 ]);
 export const flatConfigReact = () => defineConfig([
     ...flatConfigTypescript(),
@@ -68,9 +83,11 @@ export const flatConfigReact = () => defineConfig([
     reactPlugin.configs.flat['jsx-runtime'],
     reactHooks.configs.flat.recommended,
     reactConfig,
+    jsDisableTypeChecked,
 ]);
 export const flatConfigNext = () => defineConfig([
     ...createRequire(import.meta.url)('eslint-config-next/core-web-vitals'),
     ...flatConfigTypescript(true),
     reactConfig,
+    jsDisableTypeChecked,
 ]);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartive/eslint-config",
-  "version": "7.0.0",
+  "version": "7.0.2",
   "description": "ESLint configuration by smartive",
   "files": [
     "README.md",
@@ -35,7 +35,7 @@
     "eslint-plugin-prettier": "^5.5.4",
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^7.0.1",
-    "globals": "^16.0.0",
+    "globals": "^17.0.0",
     "typescript-eslint": "^8.15.0"
   },
   "peerDependencies": {
@@ -52,29 +52,41 @@
     }
   },
   "devDependencies": {
-    "@commitlint/cli": "^20.1.0",
-    "@commitlint/config-conventional": "^20.0.0",
-    "@eslint/js": "^9.15.0",
-    "@smartive/prettier-config": "^3.0.0",
-    "@types/node": "24.9.2",
-    "cz-conventional-changelog": "^3.3.0",
-    "eslint": "^9.22.0",
-    "husky": "^9.1.7",
-    "prettier": "^3.6.2",
-    "typescript": "^5.9.3"
+    "@commitlint/cli": "21.2.2",
+    "@commitlint/config-conventional": "21.2.2",
+    "@eslint/js": "9.39.5",
+    "@smartive/prettier-config": "3.1.2",
+    "@types/node": "25.9.5",
+    "@types/react": "19.2.18",
+    "@types/react-dom": "19.2.5",
+    "cz-conventional-changelog": "3.3.0",
+    "eslint": "9.39.5",
+    "eslint-config-next": "16.3.4",
+    "husky": "9.1.7",
+    "next": "16.3.4",
+    "prettier": "3.9.6",
+    "react": "19.2.8",
+    "react-dom": "19.2.8",
+    "typescript": "6.0.3"
   },
   "engines": {
     "node": "^20.19.0 || >=22.12"
   },
   "scripts": {
     "tsc": "tsc",
+    "prettier": "prettier --check . --ignore-path .prettierignore-cli",
+    "check-types": "tsc --noEmit",
     "build": "rm -rf dist && tsc",
     "commitlint": "commitlint --edit",
-    "prepare": "[ ! -f node_modules/.bin/husky ] || husky"
+    "prepare": "[ ! -f node_modules/.bin/husky ] || husky",
+    "test": "npm run build && tsc --noEmit -p tsconfig.test.json && node --test \"test/**/*.test.ts\""
   },
   "config": {
     "commitizen": {
       "path": "./node_modules/cz-conventional-changelog"
     }
+  },
+  "allowScripts": {
+    "unrs-resolver@1.12.2": true
   }
 }