@smartbit4all/ng-client 7.3.29 → 7.3.31

package/MIGRATION-7.0.md

@@ -462,7 +462,12 @@ The library line now builds against Angular 19. Host-relevant changes:
   `(click)="(someCallback)"` — previously silently dead — are now flagged at
   build time. Warning only, the build stays green.
 - TypeScript requirement stays satisfied by 5.5 (Angular 19 supports
-  TS 5.5–5.8).
+  TS 5.5–5.8). `ng update @angular/core@19` can install **TS 5.9** all the same, and the
+  build then stops with "requires TypeScript >=5.5.0 and <5.9.0"; pin `typescript ~5.8.3`
+  (p009-angular, 2026-10-27).
+- TS 5.8 reports two dead constructs as errors: **TS2869** on a `` `${x}` ?? '' `` (a template
+  literal is never nullish) and **TS2353** on a property the widget type does not have, e.g.
+  `direction` on a `SELECT` widget. Both never did anything; delete them (p034).
 
 ### Angular 20 hop (Phase 2, 19 → 20)
 
@@ -497,7 +502,17 @@ The library line now builds against Angular 20. Host-relevant changes:
 - **`moduleResolution: "node"` → `"bundler"`** in `tsconfig.json` (and any
   `tsconfig.lib.json` that sets it explicitly). Automatic migration; it changes
   how sub-path exports resolve, so a host with hand-written `paths` entries
-  should re-verify its build.
+  should re-verify its build. A deep import such as
+  `import { UiAction } from '@smartbit4all/ng-client/projects'` stops resolving
+  (TS2307); import from `@smartbit4all/ng-client` instead. A 4.5-era deep import of a
+  generated model (`@smartbit4all/document-explorer/lib/api/...`,
+  `@smartbit4all/ng-client/lib/smart-generic-pages/api/...`) breaks the same way and has no
+  root export: take the host's own generated model, or derive the type from the field it
+  copies (`AdminTemplate['file']`) (p034).
+- **A host without `skipLibCheck` that still imports `primeng/dynamicdialog` stays red from
+  this hop**: PrimeNG 17's typings name `InjectFlags`, which Angular 20 removed (TS2305 inside
+  `node_modules/primeng`). The 6.x `SmartdialogService` subclasses need that import until the
+  codemod removes it, so this hop joins 21 and 22 as red until the 7.0 library is in (p034).
 - **Workspace generation defaults**: the CLI adds a `schematics` block to
   `angular.json` pinning the pre-20 file-naming style (`type: "component"`,
   `typeSeparator: "."`). Cosmetic — it only affects newly generated files.
@@ -696,6 +711,13 @@ functioning in TypeScript 7.0"). Two ways out:
 - `strictTemplates` is on by default in v22; the lib workspace was already
   strict, so nothing changed. If your host was not strict, the `ng update`
   migration adds `"strictTemplates": false` to keep it that way.
+- A `@HostListener('document:keydown.enter', ['$event'])` handler typed `KeyboardEvent` fails
+  with TS2345 (`Event` is not assignable); type the parameter as `Event` when the handler only
+  reads `target` (p034).
+- **An Angular CLI 1x `src/test.ts` breaks `ng test`**: `require.context` is a webpack API the
+  22 karma builder no longer provides (`__webpack_require__(...).context is not a function`,
+  0 specs run). Delete the `require.context` block; the builder collects the specs from
+  `tsconfig.spec.json` itself (p034).
 
 ### The third-party packages the library does *not* own (Phase 2)
 
@@ -961,7 +983,13 @@ app-formmate or `@smartbit4all/document-explorer`:
   the table internally. **All `SmartTable*` model types stay** (`SmartTableType`,
   `SmartTableInterfaceTypeEnum`, `SmartTableHeader`, …). p043 imports
   `SmarttableComponent` in `ad-groups.component.ts` but never uses it — delete
-  that one import line.
+  that one import line. An import is not the only way in: p009-angular created it
+  through `ComponentFactoryService` (`recommendations-page`), so grep for the class
+  name, not only for the import, and rebuild such a page on `<smart-grid>`. p034 used it
+  three times for a client-side check box table (a `<smarttable>` in a template and two
+  `ComponentFactoryService` sites) whose rows come from the host, not from a backend grid;
+  there a small host component rendering the still public `SmartTable` model with
+  `mat-table` keeps the pages, because `<smart-grid>` needs a backend grid model.
 - `GoogleMap`, `LeafletMap`, `AbstractMap` — select an engine with
   `withSmartMap({ engine })`.
 - `SmartFilterParamComponent`, `SmartFilterParamsComponent`,
@@ -987,6 +1015,10 @@ No host provided them, so no action is needed.
   and the ui-action menus no longer carry `[subActions]`. All four were dead
   bindings that the NgModules' `CUSTOM_ELEMENTS_SCHEMA` had been hiding — they
   wrote a DOM property nobody read. Rendering is unchanged.
+- The same schema on a **host** module hides library selectors that 7.0 no longer
+  exports: the template compiles and the element renders nothing.
+  `<smart-filter-group-params>` (p009-angular, two admin pages) is one; grep the
+  templates for `smart-` selectors that the build does not resolve.
 - The dead `ExpandableGridComponent` is deleted (it was declared in
   `SmartGridModule` but its selector was used nowhere).
 
@@ -1312,6 +1344,30 @@ compiles: `actions` is your field, and the freeze only covers the entries. It ke
 array reference, so the toolbar does not re-render. Reassign the array — or, if you hold it
 in a `signal`, `update()` it.
 
+**A component's own toolbar entries come from its `actionModels` signal.** The 6.x pattern
+`this.uiActionModels.forEach((a) => (a.cssClass = 'eji-button'))` in `initActions` becomes an
+override of that signal, which bound, pulled and layout-embedded toolbars all read:
+
+```ts
+// the helper runs while this.actionModels is still the base class's signal
+function withCssClass(component: SmartComponent<any>, cssClass: string) {
+  const source = component.actionModels;
+  return computed(() => source().map((a) => ({ ...a, cssClass })));
+}
+
+override readonly actionModels = withCssClass(this, 'eji-button');
+```
+
+Reading `this.actionModels` directly in its own initializer is `TS2729`; passing `this` to a
+function is what captures the base signal (p009-angular, `src/app/utils/action-css-class.ts`).
+A host field of its own named `actionModels` now collides with the base signal
+(`TS2416` + `TS4114`): rename it.
+
+When the mapping reads the component's data (mark the entry of `data.currentPage`), read
+`component.modelSignal()` inside the `computed` as well: `data` is a plain field, so without it
+the class does not follow a data change that leaves the action list alone (p034,
+`src/app/utils/action-models.ts`).
+
 The descriptor a toolbar resolves is no longer written back into the entry either. Nothing
 outside the toolbar read it; if you did, resolve it yourself through
 `UiActionDescriptorService.getActionDescriptor(uiAction)` — which is
@@ -1321,8 +1377,18 @@ outside the toolbar read it; if you did, resolve it yourself through
 
 `SmartTranslateService`, `viewContext.translateService` and the `translateServiceChanged`
 subject are removed, together with `originalLabel` / `originalPlaceholder` on the widget
-interfaces. No measured host assigned any of them — the three references in p014/p043 were
-unused imports — and the backend localizes server-side.
+interfaces, and the `translateService` field of `SmartForm`, `SmartGrid` and `SmartFilter`. The
+backend localizes server-side, and in p014/p043 the three references were unused imports.
+
+**A host that sends translation keys still needs translating.** p009-angular keeps ngx-translate
+keys in its client-built forms, its client action descriptors and its titles; deleting the
+calls would put raw keys on screen. It now translates in the host: the widget labels,
+placeholders, validator messages and item labels when a form is built, and the descriptor map
+on every `onLangChange`, with `bootstrap.start()` waiting for the language to load. **Grid
+column headers and filter labels have no host-side replacement**: they show what the backend
+sends, so localize them on the backend. A page that read `this.translate` without assigning it
+got `undefined` already on 6.x (the base class never set it), so check what a title showed
+before calling a now-translated one a regression.
 
 What the frontend authors itself is now configuration: