@sma1lboy/rove 0.9.230 → 0.9.231

package/dist/web-ui/index.html

@@ -5,7 +5,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Rove</title>
-    <script type="module" crossorigin src="/assets/index-DxszcdCE.js"></script>
+    <script type="module" crossorigin src="/assets/index-DQjknI0o.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-D3usUDr4.css">
   </head>
   <body>

package/dist/web-ui/pty-server.mjs

@@ -6,7 +6,8 @@
  * PTY is spawned lazily on first attach (launch spec fetched from daemon web
  * transport by taskId + mode) and kept alive across WebSocket reconnects, so a
  * page refresh re-attaches to the same process. Closing a tab (POST
- * /pty/close) kills its PTY.
+ * /pty/close) kills its PTY, and so does no socket re-attaching within the
+ * detach grace window. The sidecar exits with its parent process.
  *
  *   ws  /pty?tab=<id>&taskId=<id>&mode=engine|shell&cols=<n>&rows=<n>
  *   POST /pty/close   { tab }                          kill the tab process
@@ -20,6 +21,7 @@ import { allowedHostForBindHost, originAllowed } from "./origin-policy.mjs"
 import { ptyRequestAuthorized } from "./pty-auth.mjs"
 import { ptyEnv } from "./pty-env.mjs"
 import { createScrollback } from "./pty-scrollback.mjs"
+import { watchParent } from "./pty-parent-watch.mjs"
 import { createPtySessionManager } from "./pty-session-lifecycle.mjs"
 import { createSpecFetcher } from "./pty-spec.mjs"
 
@@ -210,3 +212,4 @@ const shutdown = () => {
 }
 process.on("SIGINT", shutdown)
 process.on("SIGTERM", shutdown)
+watchParent({ onGone: shutdown })

package/dist/web-ui/pty-session-lifecycle.mjs

@@ -18,6 +18,11 @@ const DEFAULT_SUBMIT_DELAYS = {
 // session is being actively viewed.
 const DEFAULT_MAX_SESSIONS = 64
 
+// The page never POSTs /pty/close when a browser tab just closes, so a session
+// nobody re-attaches to within this window is killed. Long enough to ride out a
+// refresh or a laptop lid, short enough that abandoned TUIs don't pile up.
+const DEFAULT_DETACH_GRACE_MS = 10 * 60 * 1000
+
 // PTY→WebSocket backpressure: a flooding pty (`yes`) outruns a slow browser, so
 // node buffers the unsent bytes (ws.bufferedAmount) without bound. Pause the pty
 // once any socket's buffer crosses the high-water mark and resume once every
@@ -68,10 +73,12 @@ export function createPtySessionManager({
   scrollbackCap,
   env,
   setTimeoutFn = setTimeout,
+  clearTimeoutFn = clearTimeout,
   setIntervalFn = setInterval,
   clearIntervalFn = clearInterval,
   submitDelays = DEFAULT_SUBMIT_DELAYS,
   maxSessions = DEFAULT_MAX_SESSIONS,
+  detachGraceMs = DEFAULT_DETACH_GRACE_MS,
   backpressure = DEFAULT_BACKPRESSURE,
 }) {
   /** @type {Map<string, { pty: any, scrollback: ReturnType<createScrollback>, sockets: Set<any> }>} */
@@ -110,6 +117,22 @@ export function createPtySessionManager({
     }
   }
 
+  /** Start the reap countdown for a session no socket is watching. */
+  function armDetachTimer(tabId, entry) {
+    if (entry.detachTimer !== null || entry.sockets.size > 0) return
+    entry.detachTimer = setTimeoutFn(() => {
+      entry.detachTimer = null
+      if (sessions.get(tabId) === entry && entry.sockets.size === 0) closeSession(tabId)
+    }, detachGraceMs)
+  }
+
+  function clearDetachTimer(entry) {
+    if (entry.detachTimer !== null) {
+      clearTimeoutFn(entry.detachTimer)
+      entry.detachTimer = null
+    }
+  }
+
   function spawnSession(tabId, spec, cols, rows) {
     // Enforce the session cap before allocating another process: evict the
     // oldest unwatched session, or reject when every session is in active use.
@@ -141,6 +164,7 @@ export function createPtySessionManager({
       sockets: new Set(),
       paused: false,
       drainTimer: null,
+      detachTimer: null,
     }
     pty.onData((data) => {
       entry.scrollback.push(data)
@@ -154,9 +178,13 @@ export function createPtySessionManager({
       for (const ws of entry.sockets) {
         if (ws.readyState === ws.OPEN) ws.close(1000, "engine exited")
       }
+      // After the socket loop: a synchronous close re-arms the reap timer.
+      clearDetachTimer(entry)
       if (sessions.get(tabId) === entry) sessions.delete(tabId)
     })
     sessions.set(tabId, entry)
+    // A spawn-on-send with no viewer is reaped too; an attach cancels this.
+    armDetachTimer(tabId, entry)
     return entry
   }
 
@@ -216,8 +244,12 @@ export function createPtySessionManager({
 
   async function attachSocket({ ws, tabId, taskId, mode, cols, rows }) {
     const entry = await ensureSession(tabId, taskId, mode, cols, rows)
+    // The browser can leave during the spawn; its close event already fired,
+    // so tracking the socket would pin the session as watched forever.
+    if (ws.readyState !== ws.OPEN) return entry
     const replay = entry.scrollback.length() > 0 ? entry.scrollback.replay() : ""
     entry.sockets.add(ws)
+    clearDetachTimer(entry)
     if (replay && ws.readyState === ws.OPEN) ws.send(replay)
     safePty(tabId, entry, (pty) => pty.resize(cols, rows))
 
@@ -239,6 +271,7 @@ export function createPtySessionManager({
 
     ws.on("close", () => {
       entry.sockets.delete(ws)
+      if (sessions.get(tabId) === entry) armDetachTimer(tabId, entry)
     })
 
     return entry
@@ -248,6 +281,7 @@ export function createPtySessionManager({
     const entry = sessions.get(tabId)
     if (!entry) return false
     clearDrainTimer(entry)
+    clearDetachTimer(entry)
     try {
       entry.pty.kill()
     } catch {
@@ -275,6 +309,7 @@ export function createPtySessionManager({
   function shutdown() {
     for (const entry of sessions.values()) {
       clearDrainTimer(entry)
+      clearDetachTimer(entry)
       try {
         entry.pty.kill()
       } catch {

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@sma1lboy/rove",
-  "version": "0.9.230",
+  "version": "0.9.231",
   "description": "Rove — the agent multiplexer for your terminal. Run coding agents on parallel tasks with isolated worktrees and persistent sessions.",
   "keywords": [
     "terminal",
@@ -78,12 +78,12 @@
     "node-pty": "^1.1.0",
     "react": "^19.2.8",
     "smol-toml": "^1.7.1",
-    "ws": "^8.18.0"
+    "ws": "^8.21.3"
   },
   "devDependencies": {
     "@biomejs/biome": "1.9.4",
     "@sma1lboy/kobe-daemon": "0.7.19",
-    "@tsconfig/bun": "1.0.10",
+    "@tsconfig/bun": "1.0.11",
     "@types/bun": "1.3.14",
     "@types/node": "25.6.2",
     "@types/react": "^19.2.0",

package/dist/cli/chunk-59xc6m1q.js

@@ -1,3 +0,0 @@
-// @bun
-var ROW_TOKEN_TONES=["info","success","warning","error","muted"];function isRowTokenTone(value){return typeof value==="string"&&ROW_TOKEN_TONES.includes(value)}var ROW_TOKEN_MAX_TEXT=24,ROW_TOKEN_MAX_PER_SOURCE=2,ROW_TOKEN_MIN_TTL_MS=1000,ROW_TOKEN_MAX_TTL_MS=3600000,ROW_TOKEN_DEFAULT_TTL_MS=60000;function clampRowTokenTtl(ms){if(ms===void 0||!Number.isFinite(ms))return ROW_TOKEN_DEFAULT_TTL_MS;return Math.min(ROW_TOKEN_MAX_TTL_MS,Math.max(ROW_TOKEN_MIN_TTL_MS,Math.floor(ms)))}function normalizeRowTokenText(text){return text.replace(/\s+/g," ").trim().slice(0,ROW_TOKEN_MAX_TEXT)}class RowTokenStore{bus;now;byTask=new Map;timer;constructor(bus,now=Date.now){this.bus=bus;this.now=now}set(write){let token={source:write.source,key:write.key,text:normalizeRowTokenText(write.text),...write.tone?{tone:write.tone}:{},expiresAt:this.now()+clampRowTokenTtl(write.ttlMs)},live=this.liveTokens(write.taskId).filter((t)=>!(t.source===token.source&&t.key===token.key));live.push(token);let mine=live.filter((t)=>t.source===token.source).sort((a,b)=>a.expiresAt-b.expiresAt),evict=new Set(mine.slice(0,Math.max(0,mine.length-ROW_TOKEN_MAX_PER_SOURCE)));return this.store(write.taskId,live.filter((t)=>!evict.has(t))),token}clear(taskId,source,key){let before=this.liveTokens(taskId),after=before.filter((t)=>t.source!==source||key!==void 0&&t.key!==key);return this.store(taskId,after),after.length!==before.length}clearTask(taskId){if(!this.byTask.delete(taskId))return;this.publish()}snapshot(){let out={};for(let taskId of[...this.byTask.keys()]){let live=this.liveTokens(taskId);if(live.length>0)out[taskId]=live;else this.byTask.delete(taskId)}return out}close(){if(this.timer)clearTimeout(this.timer);this.timer=void 0}liveTokens(taskId){let at=this.now();return(this.byTask.get(taskId)??[]).filter((t)=>t.expiresAt>at)}store(taskId,tokens){if(tokens.length>0)this.byTask.set(taskId,[...tokens]);else this.byTask.delete(taskId);this.publish()}publish(){let tokens=this.snapshot();if(this.bus.publish("task.tokens",{tokens}),this.timer)clearTimeout(this.timer);this.timer=void 0;let next=Number.POSITIVE_INFINITY;for(let list of Object.values(tokens))for(let token of list)next=Math.min(next,token.expiresAt);if(!Number.isFinite(next))return;this.timer=setTimeout(()=>{this.timer=void 0,this.publish()},Math.max(1,next-this.now())),this.timer.unref?.()}}
-export{ROW_TOKEN_TONES,isRowTokenTone,ROW_TOKEN_MAX_TEXT,RowTokenStore};

package/dist/cli/chunk-chmhmxmc.js

@@ -1,4 +0,0 @@
-// @bun
-import{engineEntry,identifiableEngineIds}from"./chunk-rhczy26f.js";import{recordSpawn}from"./chunk-40dgv828.js";import{loadStateFile}from"./chunk-zyd6k6ak.js";import{PsProbeUnavailableError}from"./chunk-pxk2c2vj.js";import{__require}from"./chunk-wqfp8d9w.js";import{basename}from"path";var WRAPPERS=new Set(["node","bun","npx","deno","sh","zsh","bash","env","script"]);function binaryName(token){return basename(token).replace(/\.(exe|js|mjs|cjs)$/,"")}function executableNameFromArgv(argv){for(let token of argv.slice(0,8)){if(/^[A-Za-z_][A-Za-z0-9_]*=/.test(token))continue;let name=binaryName(token);if(WRAPPERS.has(name))continue;return name||null}return null}function vendorFromArgv(commandLine){let name=executableNameFromArgv(commandLine.trim().split(/\s+/));if(!name)return null;return identifiableEngineIds().find((v)=>{let entry=engineEntry(v);return entry.defaultCommand[0]===name||entry.processNames?.includes(name)===!0})??null}function parsePsSnapshot(text){let rows=[];for(let line of text.split(`
-`)){let m=/^\s*(\d+)\s+(\d+)\s+(\S.*)$/.exec(line);if(m)rows.push({pid:Number(m[1]),ppid:Number(m[2]),args:m[3]})}return rows}function childrenIndex(rows){let kids=new Map;for(let row of rows){let list=kids.get(row.ppid);if(list)list.push(row);else kids.set(row.ppid,[row])}return kids}function hasAncestor(rows,pid,ancestorPid){let parents=new Map(rows.map((r)=>[r.pid,r.ppid])),cur=pid;for(let hops=0;hops<=rows.length;hops++){if(cur===ancestorPid)return!0;let next=parents.get(cur);if(next===void 0||next<=1)return!1;cur=next}return!1}function customEngineBinaries(){let state=loadStateFile(),ids=state.customEngineIds,out=new Map;if(!Array.isArray(ids))return out;for(let id of ids){if(typeof id!=="string"||id.trim().length===0)continue;let command=state[`engineCommand.${id}`],argv=typeof command==="string"&&command.trim().length>0?command.trim().split(/\s+/):[id],name=executableNameFromArgv(argv);if(name)out.set(name,id)}return out}function walkDescendants(rows,rootPid,identify){let kids=childrenIndex(rows),queue=[...kids.get(rootPid)??[]];while(queue.length>0){let row=queue.shift();if(!row)break;let vendor=identify(row.args);if(vendor)return{vendor,argv:row.args,pid:row.pid};queue.push(...kids.get(row.pid)??[])}return null}function foregroundEngineIn(rows,rootPid){let builtin=walkDescendants(rows,rootPid,vendorFromArgv);if(builtin)return builtin;let custom=customEngineBinaries();if(custom.size===0)return null;return walkDescendants(rows,rootPid,(args)=>custom.get(executableNameFromArgv(args.trim().split(/\s+/))??"")??null)}function engineProcessIn(rows,rootPid,extraLaunch){if(foregroundEngineIn(rows,rootPid))return!0;let expected=extraLaunch?executableNameFromArgv(typeof extraLaunch==="string"?[extraLaunch]:extraLaunch):null;if(!expected)return!1;let kids=childrenIndex(rows),queue=[...kids.get(rootPid)??[]];while(queue.length>0){let row=queue.shift();if(!row)break;if(executableNameFromArgv(row.args.trim().split(/\s+/))===expected)return!0;queue.push(...kids.get(row.pid)??[])}return!1}var PS_PROBE_TIMEOUT_MS=5000,bunPsSpawn=()=>{recordSpawn("engine.foregroundWalk",["ps","-A","-o","pid=,ppid=,args="]);let proc=Bun.spawn(["ps","-A","-o","pid=,ppid=,args="],{stdout:"pipe",stderr:"ignore"});return{text:new Response(proc.stdout).text(),kill:()=>proc.kill()}};async function psSnapshotWith(spawn,timeoutMs=PS_PROBE_TIMEOUT_MS){let proc=spawn(),timer;try{let text=await Promise.race([proc.text,new Promise((_resolve,reject)=>{timer=setTimeout(()=>{try{proc.kill()}catch{}reject(new PsProbeUnavailableError(`ps did not answer within ${timeoutMs}ms`))},timeoutMs)})]);if(parsePsSnapshot(text).length===0)throw new PsProbeUnavailableError("ps returned no usable rows");return text}finally{if(timer)clearTimeout(timer)}}var psSnapshot=async(anchors)=>{if(process.platform!=="win32")return psSnapshotWith(bunPsSpawn);let{defaultWinProcessProbe,winProcessSnapshot}=await import("./chunk-kxaqge09.js");return winProcessSnapshot(anchors??[],defaultWinProcessProbe())};async function foregroundEngine(rootPid,snapshot=psSnapshot){try{return foregroundEngineIn(parsePsSnapshot(await snapshot([rootPid])),rootPid)}catch{return null}}
-export{vendorFromArgv,parsePsSnapshot,hasAncestor,foregroundEngineIn,engineProcessIn,PS_PROBE_TIMEOUT_MS,psSnapshotWith,psSnapshot,foregroundEngine};

package/dist/cli/chunk-xb9b93ts.js

@@ -1,3 +0,0 @@
-// @bun
-var PLACEHOLDER_TASK_TITLE="(new task)";function sanitizeTaskTitle(title){return title.replace(/[\u0000-\u0020\u007f]+/g," ").trim()}function deriveTitleFromPrompt(prompt){if(typeof prompt!=="string")return"";let collapsed=prompt.replace(/\s+/g," ").trim();if(collapsed.length===0)return"";let points=[...collapsed];if(points.length<=40)return collapsed;return`${points.slice(0,40).join("")}\u2026`}function isPlaceholderDerivedBranch(branch,taskId){let id6=taskId.slice(-6).toLowerCase();if(branch===`rove/new-task-${id6}`||branch===`kobe/new-task-${id6}`)return!0;return/^(?:[^/]+\/)?new-task(?:-\d+)?$/.test(branch)}
-export{PLACEHOLDER_TASK_TITLE,sanitizeTaskTitle,deriveTitleFromPrompt,isPlaceholderDerivedBranch};