@slope-dev/slope 1.62.3 → 1.63.0

package/dist/cli/commands/sprint.js

@@ -1,5 +1,5 @@
-import { loadSprintState, loadSprintStateResult, createSprintState, initializeSprintState, mutateSprintState, updateGate, updateSprintPhase, updateSprintPhaseForSprint, clearSprintState, isSprintComplete, isReviewGateSatisfied, isRequiredReviewGate, waivedReviewGateNames, pendingGateNames, pendingGates, isSprintPhase, isReviewGateName, validateReviewGateCompletion, SPRINT_PHASES, } from '../sprint-state.js';
-import { WorkflowEngine, loadWorkflow, resolveVariables, validateWorkflow, loadConfig, parseRoadmap, castRoadmapStructure, formatSprintLabel, formatSprintNumber, parseSprintNumber } from '../../core/index.js';
+import { loadSprintState, loadSprintStateResult, createSprintState, initializeSprintState, mutateSprintState, updateGate, updateSprintPhase, updateSprintPhaseForSprint, clearSprintState, isSprintComplete, isReviewGateSatisfied, isRequiredReviewGate, waivedReviewGateNames, pendingGateNames, pendingGates, isSprintPhase, isReviewGateName, isReviewGateVerdict, validateReviewGateCompletion, SPRINT_PHASES, } from '../sprint-state.js';
+import { WorkflowEngine, loadWorkflow, resolveVariables, validateWorkflow, loadConfig, parseRoadmap, castRoadmapStructure, formatSprintLabel, formatSprintNumber, formatRoadmapSprintLabel, parseSprintNumber } from '../../core/index.js';
 import { createHash } from 'node:crypto';
 import { formatActorName, formatActorSource, formatConflictSummary, resolveActor } from '../actor.js';
 import { inspectSprintRollover, performSprintRollover, SprintRolloverError, verifySprintRolloverLineage, } from '../sprint-rollover.js';
@@ -103,6 +103,12 @@ function parseGateOptions(args) {
     let notes;
     let reason;
     let overrideReason;
+    let verdict;
+    let packet;
+    let reviewedCommit;
+    let tokenBudget;
+    let tokensUsed;
+    let overBudgetReason;
     let help = false;
     for (let i = 0; i < args.length; i++) {
         const arg = args[i];
@@ -137,6 +143,69 @@ function parseGateOptions(args) {
             i = prReviewValue.next;
             continue;
         }
+        const verdictValue = optionValue(args, i, '--verdict');
+        if (verdictValue) {
+            const normalized = verdictValue.value?.trim().toLowerCase().replace(/[\s-]+/g, '_');
+            if (!normalized || normalized.startsWith('--'))
+                errors.push('--verdict requires pass, changes_requested, or blocked');
+            else if (!isReviewGateVerdict(normalized))
+                errors.push('--verdict must be pass, changes_requested, or blocked');
+            else
+                verdict = normalized;
+            i = verdictValue.next;
+            continue;
+        }
+        const packetValue = optionValue(args, i, '--packet');
+        if (packetValue) {
+            if (!packetValue.value || packetValue.value.startsWith('--'))
+                errors.push('--packet requires a value');
+            else
+                packet = packetValue.value;
+            i = packetValue.next;
+            continue;
+        }
+        const reviewedCommitValue = optionValue(args, i, '--reviewed-commit') ?? optionValue(args, i, '--head');
+        if (reviewedCommitValue) {
+            if (!reviewedCommitValue.value || reviewedCommitValue.value.startsWith('--'))
+                errors.push('--reviewed-commit requires a value');
+            else
+                reviewedCommit = reviewedCommitValue.value;
+            i = reviewedCommitValue.next;
+            continue;
+        }
+        const tokenBudgetValue = optionValue(args, i, '--token-budget');
+        if (tokenBudgetValue) {
+            if (!tokenBudgetValue.value || tokenBudgetValue.value.startsWith('--'))
+                errors.push('--token-budget requires a value');
+            else
+                tokenBudget = tokenBudgetValue.value;
+            i = tokenBudgetValue.next;
+            continue;
+        }
+        const tokensUsedValue = optionValue(args, i, '--tokens-used');
+        if (tokensUsedValue) {
+            if (!tokensUsedValue.value || tokensUsedValue.value.startsWith('--')) {
+                errors.push('--tokens-used requires a numeric value');
+            }
+            else {
+                const parsed = Number(tokensUsedValue.value);
+                if (!Number.isFinite(parsed) || parsed < 0)
+                    errors.push('--tokens-used must be a non-negative number');
+                else
+                    tokensUsed = parsed;
+            }
+            i = tokensUsedValue.next;
+            continue;
+        }
+        const overBudgetValue = optionValue(args, i, '--over-budget-reason');
+        if (overBudgetValue) {
+            if (!overBudgetValue.value || overBudgetValue.value.startsWith('--'))
+                errors.push('--over-budget-reason requires a value');
+            else
+                overBudgetReason = overBudgetValue.value;
+            i = overBudgetValue.next;
+            continue;
+        }
         if (arg === '--self-review') {
             selfReview = true;
             continue;
@@ -183,6 +252,7 @@ function parseGateOptions(args) {
     if (modeCount > 1) {
         errors.push('Use only one review provenance mode: --reviewer/--evidence, --pr-review, --self-review, --waive-independent-review, or --override.');
     }
+    const inferredVerdict = verdict ?? inferVerdictFromEvidence(evidence);
     let review;
     if (modeCount === 1) {
         if (hasPrReview) {
@@ -200,9 +270,45 @@ function parseGateOptions(args) {
         else {
             review = { provenance: 'independent_review', evidence, reviewer, notes: notes ?? reason };
         }
+        review = {
+            ...review,
+            ...(inferredVerdict ? { verdict: inferredVerdict } : {}),
+            ...(packet ? { packet } : {}),
+            ...(reviewedCommit ? { reviewed_commit: reviewedCommit } : {}),
+            ...(tokenBudget ? { token_budget: tokenBudget } : {}),
+            ...(tokensUsed !== undefined ? { tokens_used: tokensUsed } : {}),
+            ...(overBudgetReason ? { over_budget_reason: overBudgetReason } : {}),
+        };
     }
     return { review, errors, help };
 }
+function inferVerdictFromEvidence(evidence) {
+    const verdicts = [];
+    for (const item of evidence) {
+        if (/^https?:\/\//i.test(item))
+            continue;
+        const path = isAbsolute(item) ? item : join(process.cwd(), item);
+        if (!existsSync(path))
+            continue;
+        try {
+            const content = readFileSync(path, 'utf8');
+            const match = content.match(/^\s*verdict\s*:\s*([A-Za-z _-]+)/im);
+            const value = match?.[1]?.trim().toLowerCase().replace(/[\s-]+/g, '_');
+            if (isReviewGateVerdict(value))
+                verdicts.push(value);
+        }
+        catch {
+            continue;
+        }
+    }
+    if (verdicts.includes('blocked'))
+        return 'blocked';
+    if (verdicts.includes('changes_requested'))
+        return 'changes_requested';
+    if (verdicts.includes('pass'))
+        return 'pass';
+    return undefined;
+}
 function printGateUsage(gateName) {
     const gate = gateName && isReviewGateName(gateName) ? gateName : 'code_review';
     console.error('');
@@ -210,6 +316,7 @@ function printGateUsage(gateName) {
     console.error('  slope sprint gate <name>');
     console.error(`  slope sprint gate ${gate} --reviewer=<agent-or-person> --evidence=<transcript-or-output>`);
     console.error(`  slope sprint gate ${gate} --pr-review=<url-or-id>`);
+    console.error(`  slope sprint gate ${gate} --reviewer=<id> --evidence=<file> --verdict=pass --packet=<review-packet.json>`);
     console.error(`  slope sprint gate ${gate} --self-review --reason="why self-review is acceptable"`);
     console.error(`  slope sprint gate ${gate} --waive-independent-review --reason="why the required independent review is being waived"`);
     console.error(`  slope sprint gate ${gate} --override="manual override reason"`);
@@ -220,6 +327,7 @@ function printGateUsage(gateName) {
     console.error('  self_review (weaker): requires --self-review and --reason');
     console.error('  independent_review_waived: explicit waiver for a required review; requires --waive-independent-review and --reason');
     console.error('  manual_override (weaker): requires --override');
+    console.error('  verdict metadata: --verdict=pass|changes_requested|blocked; local evidence files with "Verdict:" are parsed automatically');
     console.error('');
 }
 function commandValue(value) {
@@ -229,6 +337,28 @@ function commandValue(value) {
         ? `'${value.replaceAll("'", "''")}'`
         : `'${value.replaceAll("'", `'"'"'`)}`;
 }
+function loadRoadmapForSprintLabels(cwd) {
+    const config = loadConfig(cwd);
+    const roadmapPath = join(cwd, config.roadmapPath);
+    if (!existsSync(roadmapPath))
+        return null;
+    try {
+        const raw = JSON.parse(readFileSync(roadmapPath, 'utf8'));
+        const parsed = parseRoadmap(raw);
+        return parsed.roadmap ?? castRoadmapStructure(raw);
+    }
+    catch {
+        return null;
+    }
+}
+function sprintLabelForCwd(cwd, sprint) {
+    const roadmap = loadRoadmapForSprintLabels(cwd);
+    return roadmap ? formatRoadmapSprintLabel(roadmap, sprint) : formatSprintLabel(sprint);
+}
+function sprintNumberForCwd(cwd, sprint) {
+    const label = sprintLabelForCwd(cwd, sprint);
+    return label.startsWith('S') ? label.slice(1) : label;
+}
 function actorRetryOption(args) {
     for (const flag of ['--actor', '--player']) {
         const value = findOptionValue(args, flag);
@@ -450,6 +580,8 @@ async function beginCommand(args, cwd) {
         process.exit(1);
     }
     // Step 1: initialize without overwriting existing or corrupt local state.
+    const sprintLabel = sprintLabelForCwd(cwd, sprint);
+    const sprintNumber = sprintNumberForCwd(cwd, sprint);
     const initialized = initializeSprintState(cwd, createSprintState(sprint, 'planning'));
     if (initialized.status === 'corrupt') {
         console.error(`Refusing to begin: corrupt sprint evidence was preserved at ${relative(cwd, initialized.path)}.`);
@@ -457,11 +589,11 @@ async function beginCommand(args, cwd) {
     }
     let state = initialized.state;
     const retryActor = actorRetryOption(args);
-    if (initialized.status === 'existing' && requireMatchingSprintOrRollover(cwd, state, sprint, `begin ${formatSprintLabel(sprint)}`, `slope sprint begin --sprint=${formatSprintNumber(sprint)} --ticket=${commandValue(ticket)}${retryActor ? ` ${retryActor}` : ''}`)) {
-        console.log(`Sprint ${formatSprintNumber(sprint)}: already started (phase: ${state.phase}).`);
+    if (initialized.status === 'existing' && requireMatchingSprintOrRollover(cwd, state, sprint, `begin ${sprintLabel}`, `slope sprint begin --sprint=${sprintNumber} --ticket=${commandValue(ticket)}${retryActor ? ` ${retryActor}` : ''}`)) {
+        console.log(`Sprint ${sprintNumber}: already started (phase: ${state.phase}).`);
     }
     else {
-        console.log(`Sprint ${formatSprintNumber(sprint)}: started (phase: planning).`);
+        console.log(`Sprint ${sprintNumber}: started (phase: planning).`);
     }
     // Step 2: claim
     const { resolveStore } = await import('../store.js');
@@ -491,7 +623,7 @@ async function beginCommand(args, cwd) {
                 console.error(`\nClaim blocked — overlap conflict(s) detected:`);
                 for (const c of overlaps)
                     console.error(`  [!!] ${formatConflictSummary(c)}`);
-                console.error(`\nResolve conflicts or run \`slope claim --target=${ticket} --sprint=${formatSprintNumber(sprint)} --force\` to override.`);
+                console.error(`\nResolve conflicts or run \`slope claim --target=${ticket} --sprint=${sprintNumber} --force\` to override.`);
                 process.exit(1);
             }
             const claim = await store.claim({ sprint_number: sprint, player, target: ticket, scope: 'ticket' });
@@ -508,11 +640,11 @@ async function beginCommand(args, cwd) {
     console.log('\n' + '─'.repeat(50));
     try {
         const { briefingCommand } = await import('./briefing.js');
-        await briefingCommand([`--sprint=${formatSprintNumber(sprint)}`]);
+        await briefingCommand([`--sprint=${sprintNumber}`]);
     }
     catch (err) {
         console.error(`  Could not run briefing: ${err.message}`);
-        console.error(`  Sprint state was already created; retry with: slope briefing --sprint=${formatSprintNumber(sprint)}`);
+        console.error(`  Sprint state was already created; retry with: slope briefing --sprint=${sprintNumber}`);
     }
     // Step 4: prep --lite
     console.log('\n' + '─'.repeat(50));
@@ -582,28 +714,30 @@ async function startCommand(args, cwd) {
         ...(retryActor ? [retryActor] : []),
         ...(force ? ['--force'] : []),
     ];
-    const retryStart = `slope sprint start --number=${formatSprintNumber(sprint)} --phase=${phase}${retryExtras.length > 0 ? ` ${retryExtras.join(' ')}` : ''}`;
+    const sprintLabel = sprintLabelForCwd(cwd, sprint);
+    const sprintNumber = sprintNumberForCwd(cwd, sprint);
+    const retryStart = `slope sprint start --number=${sprintNumber} --phase=${phase}${retryExtras.length > 0 ? ` ${retryExtras.join(' ')}` : ''}`;
     failOnCorruptSprintState(cwd);
     const existingResult = loadSprintStateResult(cwd);
     const existing = existingResult.status === 'valid' ? existingResult.state : null;
     if (existing) {
-        requireMatchingSprintOrRollover(cwd, existing, sprint, `start ${formatSprintLabel(sprint)}`, retryStart);
+        requireMatchingSprintOrRollover(cwd, existing, sprint, `start ${sprintLabel}`, retryStart);
         if (phaseValue && existing.phase !== phase) {
             const updated = updateSprintPhaseForSprint(cwd, existing.sprint, phase);
             if (!updated.matched) {
                 console.error('Refusing to update phase because sprint state changed concurrently; retry the start command.');
                 process.exit(1);
             }
-            console.log(`Sprint ${formatSprintNumber(sprint)} phase updated: ${phase}.`);
+            console.log(`Sprint ${sprintNumber} phase updated: ${phase}.`);
             return;
         }
-        console.log(`Sprint ${formatSprintNumber(sprint)} state already exists (phase: ${existing.phase}).`);
+        console.log(`Sprint ${sprintNumber} state already exists (phase: ${existing.phase}).`);
         return;
     }
     const roadmapReality = loadRoadmapReality(cwd);
     const blockingRoadmapIssues = blockingRoadmapIssuesForSprint(roadmapReality, sprint);
     if (blockingRoadmapIssues.length > 0 && !force) {
-        console.error(`\nPre-sprint reality check failed for ${formatSprintLabel(sprint)}:`);
+        console.error(`\nPre-sprint reality check failed for ${sprintLabel}:`);
         for (const issue of blockingRoadmapIssues) {
             console.error(`  [${issue.type}] ${issue.message}`);
         }
@@ -629,12 +763,12 @@ async function startCommand(args, cwd) {
         process.exit(1);
     }
     if (initialized.status === 'existing') {
-        requireMatchingSprintOrRollover(cwd, initialized.state, sprint, `start ${formatSprintLabel(sprint)}`, retryStart);
-        console.log(`Sprint ${formatSprintNumber(sprint)} state already exists (phase: ${initialized.state.phase}).`);
+        requireMatchingSprintOrRollover(cwd, initialized.state, sprint, `start ${sprintLabel}`, retryStart);
+        console.log(`Sprint ${sprintNumber} state already exists (phase: ${initialized.state.phase}).`);
         return;
     }
     const autoClaim = await autoClaimSprint(cwd, sprint, actorOverride(args));
-    console.log(`Sprint ${formatSprintNumber(sprint)} started (phase: ${phase}). Use 'slope sprint gate <name>' to mark gates; review gates require evidence options.`);
+    console.log(`Sprint ${sprintNumber} started (phase: ${phase}). Use 'slope sprint gate <name>' to mark gates; review gates require evidence options.`);
     if (autoClaim)
         console.log(autoClaim);
 }
@@ -643,7 +777,7 @@ async function autoClaimSprint(cwd, sprint, explicitActor) {
     const actor = resolveActor(cwd, { explicitActor });
     const player = actor.name;
     const playerDisplay = formatActorName(actor);
-    const target = `sprint:${formatSprintLabel(sprint)}`;
+    const target = `sprint:${sprintLabelForCwd(cwd, sprint)}`;
     try {
         const store = await resolveStore(cwd);
         try {
@@ -681,10 +815,10 @@ function phaseCommand(args, cwd) {
     }
     updateSprintPhase(cwd, phaseInput);
     if (before.phase === phaseInput) {
-        console.log(`Sprint ${formatSprintNumber(before.sprint)} already in ${phaseInput} phase.`);
+        console.log(`Sprint ${sprintNumberForCwd(cwd, before.sprint)} already in ${phaseInput} phase.`);
     }
     else {
-        console.log(`Sprint ${formatSprintNumber(before.sprint)} phase updated: ${before.phase} -> ${phaseInput}.`);
+        console.log(`Sprint ${sprintNumberForCwd(cwd, before.sprint)} phase updated: ${before.phase} -> ${phaseInput}.`);
     }
 }
 function gateCommand(args, cwd) {
@@ -800,7 +934,7 @@ function statusCommand(cwd) {
         ? waivedReviews.length > 0 ? 'ready_for_pr_with_review_waiver' : 'ready_for_pr'
         : state.phase;
     const phaseContext = complete ? ' (all gates complete)' : ` (phase: ${state.phase})`;
-    console.log(`Sprint ${formatSprintNumber(state.sprint)} - status: ${derivedStatus}${phaseContext}`);
+    console.log(`Sprint ${sprintNumberForCwd(cwd, state.sprint)} - status: ${derivedStatus}${phaseContext}`);
     console.log(`Started: ${state.started_at}`);
     console.log(`Updated: ${state.updated_at}`);
     console.log('');