@slicemachine/manager 0.25.3-alpha.jp-unauthorized-error.5 → 0.25.3-alpha.jp-unauthorized-error-improvement.2

package/src/managers/slices/SlicesManager.ts

@@ -147,9 +147,16 @@ type SliceMachineManagerUpdateSliceMocksArgsReturnType = {
 	errors: HookError[];
 };
 
-type SlicesManagerUpsertHostedSliceScrenshotsArgs = {
+type SlicesManagerUpsertHostedSliceScreenshotsArgs = {
 	libraryID: string;
 	model: SharedSlice;
+	/**
+	 * A map of variation IDs to remote screenshot URLs. These URLs are used to
+	 * detect if a screenshot has changed when comparing with local ones and to
+	 * push slices with the current screenshot. If a matching screenshot is not
+	 * found in this map, the current local screenshot is uploaded again.
+	 */
+	variationImageUrlMap: Record<string, string>;
 };
 
 type SliceMachineManagerDeleteSliceArgs = {
@@ -759,8 +766,11 @@ export class SlicesManager extends BaseManager {
 		if (model) {
 			const modelWithScreenshots =
 				await this.updateSliceModelScreenshotsInPlace({
-					libraryID: args.libraryID,
 					model,
+					libraryID: args.libraryID,
+					// We are pushing it for the first time here, no remote image URLs to
+					// use during the update.
+					variationImageUrlMap: {},
 				});
 
 			const authenticationToken = await this.user.getAuthenticationToken();
@@ -1003,7 +1013,7 @@ export class SlicesManager extends BaseManager {
 	}
 
 	async updateSliceModelScreenshotsInPlace(
-		args: SlicesManagerUpsertHostedSliceScrenshotsArgs,
+		args: SlicesManagerUpsertHostedSliceScreenshotsArgs,
 	): Promise<SharedSlice> {
 		const repositoryName = await this.project.getResolvedRepositoryName();
 
@@ -1023,13 +1033,19 @@ export class SlicesManager extends BaseManager {
 					};
 				}
 
-				const hasScreenshotChanged = !variation.imageUrl?.includes(
+				const remoteImageUrl = args.variationImageUrlMap?.[variation.id];
+				const hasScreenshotChanged = !remoteImageUrl?.includes(
 					createContentDigest(screenshot.data),
 				);
 
-				// If screenshot hasn't changed, do nothing
+				// If screenshot hasn't changed, no need to upload it again, just use
+				// the existing variation with the remote image URL if it exists.
 				if (!hasScreenshotChanged) {
-					return variation;
+					return {
+						...variation,
+						// Keep the existing remote screenshot URL if it exists.
+						imageUrl: remoteImageUrl ?? variation.imageUrl,
+					};
 				}
 
 				const keyPrefix = [

package/src/managers/telemetry/types.ts

@@ -46,6 +46,8 @@ export const SegmentEventType = {
 	sharedOnboarding_tutorial: "shared-onboarding:follow-tutorial",
 	sliceGenerationFeedback: "slice-generation-feedback",
 	navigation_documentationLinkClicked: "navigation:documentation-link-clicked",
+	sidebar_link_clicked: "sidebar:link-clicked",
+	mcp_promo_link_clicked: "mcp:promo-link-clicked",
 } as const;
 type SegmentEventTypes =
 	(typeof SegmentEventType)[keyof typeof SegmentEventType];
@@ -104,6 +106,8 @@ export const HumanSegmentEventType = {
 	[SegmentEventType.sliceGenerationFeedback]: "Slice Generation Feedback",
 	[SegmentEventType.navigation_documentationLinkClicked]:
 		"SliceMachine Documentation Link Clicked",
+	[SegmentEventType.sidebar_link_clicked]: "Sidebar Link Clicked",
+	[SegmentEventType.mcp_promo_link_clicked]: "MCP Promo Link Clicked",
 } as const;
 
 export type HumanSegmentEventTypes =
@@ -424,6 +428,22 @@ type NavigationDocumentationLinkClicked = SegmentEvent<
 	}
 >;
 
+type SidebarLinkClicked = SegmentEvent<
+	typeof SegmentEventType.sidebar_link_clicked,
+	{
+		link_name: string;
+		source: string;
+	}
+>;
+
+type McpPromoLinkClicked = SegmentEvent<
+	typeof SegmentEventType.mcp_promo_link_clicked,
+	{
+		source: string;
+		target: string;
+	}
+>;
+
 export type SegmentEvents =
 	| CommandInitStartSegmentEvent
 	| CommandInitIdentifySegmentEvent
@@ -461,4 +481,6 @@ export type SegmentEvents =
 	| SliceMachinePostPushToastCtaClicked
 	| SliceMachineExperimentExposure
 	| SliceGenerationFeedback
-	| NavigationDocumentationLinkClicked;
+	| NavigationDocumentationLinkClicked
+	| SidebarLinkClicked
+	| McpPromoLinkClicked;