@slicemachine/manager 0.24.14-alpha.jp-update-cr-links-remove-recursion.4 → 0.24.14-alpha.jp-update-cr-links-unit.6

package/src/managers/customTypes/CustomTypesManager.ts

@@ -188,133 +188,6 @@ export class CustomTypesManager extends BaseManager {
 		};
 	}
 
-	private updateCRCustomType(
-		args: { customType: CrCustomType } & CustomTypeFieldIdChangedMeta,
-	): CrCustomType {
-		const { previousPath, newPath } = args;
-
-		const customType = shallowClone(args.customType);
-
-		const previousId = previousPath[0];
-		const newId = newPath[0];
-
-		if (!previousId || !newId || typeof customType === "string") {
-			return customType; // we don't support custom type id renaming
-		}
-
-		if (customType.fields) {
-			const newFields = customType.fields.map((fieldArg) => {
-				const field = shallowClone(fieldArg);
-
-				const previousId = previousPath[1];
-				const newId = newPath[1];
-
-				if (!previousId || !newId) {
-					return field;
-				}
-
-				if (typeof field === "string") {
-					if (field === previousId && field !== newId) {
-						// We have reached a field id that matches the id that was renamed,
-						// so we update it new one. The field is a string, so return the new
-						// id.
-						return newId;
-					}
-
-					return field;
-				}
-
-				if (field.id === previousId && field.id !== newId) {
-					// We have reached a field id that matches the id that was renamed,
-					// so we update it new one.
-					// Since field is not a string, we don't exit, as we might have
-					// something to update further down in customtypes.
-					field.id = newId;
-				}
-
-				return {
-					...field,
-					customtypes: field.customtypes.map((customTypeArg) => {
-						const customType = shallowClone(customTypeArg);
-						const previousId = previousPath[0];
-						const newId = newPath[0];
-
-						if (!previousId || !newId || typeof customType === "string") {
-							return customType; // we don't support custom type id renaming
-						}
-
-						if (customType.fields) {
-							return {
-								...customType,
-								fields: customType.fields.map((fieldArg) => {
-									const field = shallowClone(fieldArg);
-									const previousId = previousPath[1];
-									const newId = newPath[1];
-
-									if (field === previousId && field !== newId) {
-										// Matches the previous id, so we update it and return because
-										// it's the last level.
-										return newId;
-									}
-
-									return field;
-								}),
-							};
-						}
-
-						return customType;
-					}),
-				};
-			});
-
-			return { ...customType, fields: newFields };
-		}
-
-		return customType;
-	}
-
-	/**
-	 * Map over the custom types of a Content Relationship Link and update the API
-	 * IDs that were changed during the custom type update.
-	 */
-	private updateCRCustomTypes(
-		args: { customTypes: CrCustomTypes } & CustomTypeFieldIdChangedMeta,
-	): CrCustomTypes {
-		const { customTypes, ...updateMeta } = args;
-
-		return customTypes.map((customType) => {
-			return this.updateCRCustomType({ customType, ...updateMeta });
-		});
-	}
-
-	/**
-	 * Update the Content Relationship API IDs of a single field. The change is
-	 * determined by the `previousPath` and `newPath` properties.
-	 */
-	private updateFieldContentRelationships<
-		T extends UID | NestableWidget | Group | NestedGroup,
-	>(args: { field: T } & CustomTypeFieldIdChangedMeta): T {
-		const { field, ...updateMeta } = args;
-		if (
-			field.type !== "Link" ||
-			field.config?.select !== "document" ||
-			!field.config?.customtypes
-		) {
-			// not a content relationship field
-			return field;
-		}
-
-		const newCustomTypes = this.updateCRCustomTypes({
-			...updateMeta,
-			customTypes: field.config.customtypes,
-		});
-
-		return {
-			...field,
-			config: { ...field.config, customtypes: newCustomTypes },
-		};
-	}
-
 	/**
 	 * Update the Content Relationship API IDs for all existing custom types and
 	 * slices. The change is determined by properties inside the `updateMeta`
@@ -340,24 +213,19 @@ export class CustomTypesManager extends BaseManager {
 				// any custom type and update them to use the new one.
 				const customTypes = await this.readAllCustomTypes();
 
-				for (const customType of customTypes.models) {
-					const updatedCustomTypeModel = traverseCustomType({
-						customType: customType.model,
-						onField: ({ field }) => {
-							return this.updateFieldContentRelationships({
-								field,
-								previousPath,
-								newPath,
-							});
-						},
-					});
-
-					crUpdates.push(
-						this.sliceMachinePluginRunner.callHook("custom-type:update", {
-							model: updatedCustomTypeModel,
-						}),
-					);
-				}
+				updateCustomTypeContentRelationships({
+					models: customTypes.models,
+					onUpdate: (model) => {
+						pushIfDefined(
+							crUpdates,
+							this.sliceMachinePluginRunner?.callHook("custom-type:update", {
+								model,
+							}),
+						);
+					},
+					previousPath,
+					newPath,
+				});
 
 				// Find existing slice with content relationships that link to the renamed
 				// field id in all libraries and update them to use the new one.
@@ -368,26 +236,20 @@ export class CustomTypesManager extends BaseManager {
 						libraryID: library.libraryID,
 					});
 
-					for (const slice of slices.models) {
-						const updatedSliceModel = traverseSharedSlice({
-							path: ["."],
-							slice: slice.model,
-							onField: ({ field }) => {
-								return this.updateFieldContentRelationships({
-									field,
-									previousPath,
-									newPath,
-								});
-							},
-						});
-
-						crUpdates.push(
-							this.sliceMachinePluginRunner.callHook("slice:update", {
-								libraryID: library.libraryID,
-								model: updatedSliceModel,
-							}),
-						);
-					}
+					updateSharedSliceContentRelationships({
+						models: slices.models,
+						onUpdate: (model) => {
+							pushIfDefined(
+								crUpdates,
+								this.sliceMachinePluginRunner?.callHook("slice:update", {
+									libraryID: library.libraryID,
+									model,
+								}),
+							);
+						},
+						previousPath,
+						newPath,
+					});
 				}
 
 				// Process all the Content Relationship updates at once.
@@ -633,10 +495,192 @@ const InferSliceResponse = z.object({
 	langSmithUrl: z.string().url().optional(),
 });
 
-function shallowClone<T>(value: T): T {
+function updateCRCustomType(
+	args: { customType: CrCustomType } & CustomTypeFieldIdChangedMeta,
+): CrCustomType {
+	const { previousPath, newPath } = args;
+
+	const customType = shallowCloneIfObject(args.customType);
+
+	const previousId = previousPath[0];
+	const newId = newPath[0];
+
+	if (!previousId || !newId || typeof customType === "string") {
+		return customType; // we don't support custom type id renaming
+	}
+
+	if (customType.fields) {
+		const newFields = customType.fields.map((fieldArg) => {
+			const field = shallowCloneIfObject(fieldArg);
+
+			const previousId = previousPath[1];
+			const newId = newPath[1];
+
+			if (!previousId || !newId) {
+				return field;
+			}
+
+			if (typeof field === "string") {
+				if (field === previousId && field !== newId) {
+					// We have reached a field id that matches the id that was renamed,
+					// so we update it new one. The field is a string, so return the new
+					// id.
+					return newId;
+				}
+
+				return field;
+			}
+
+			if (field.id === previousId && field.id !== newId) {
+				// We have reached a field id that matches the id that was renamed,
+				// so we update it new one.
+				// Since field is not a string, we don't exit, as we might have
+				// something to update further down in customtypes.
+				field.id = newId;
+			}
+
+			return {
+				...field,
+				customtypes: field.customtypes.map((customTypeArg) => {
+					const customType = shallowCloneIfObject(customTypeArg);
+					const previousId = previousPath[0];
+					const newId = newPath[0];
+
+					if (!previousId || !newId || typeof customType === "string") {
+						return customType; // we don't support custom type id renaming
+					}
+
+					if (customType.fields) {
+						return {
+							...customType,
+							fields: customType.fields.map((fieldArg) => {
+								const field = shallowCloneIfObject(fieldArg);
+								const previousId = previousPath[1];
+								const newId = newPath[1];
+
+								if (field === previousId && field !== newId) {
+									// Matches the previous id, so we update it and return because
+									// it's the last level.
+									return newId;
+								}
+
+								return field;
+							}),
+						};
+					}
+
+					return customType;
+				}),
+			};
+		});
+
+		return { ...customType, fields: newFields };
+	}
+
+	return customType;
+}
+
+/**
+ * Map over the custom types of a Content Relationship Link and update the API
+ * IDs that were changed during the custom type update.
+ */
+function updateCRCustomTypes(
+	args: { customTypes: CrCustomTypes } & CustomTypeFieldIdChangedMeta,
+): CrCustomTypes {
+	const { customTypes, ...updateMeta } = args;
+
+	return customTypes.map((customType) => {
+		return updateCRCustomType({ customType, ...updateMeta });
+	});
+}
+
+/**
+ * Update the Content Relationship API IDs of a single field. The change is
+ * determined by the `previousPath` and `newPath` properties.
+ */
+function updateFieldContentRelationships<
+	T extends UID | NestableWidget | Group | NestedGroup,
+>(args: { field: T } & CustomTypeFieldIdChangedMeta): T {
+	const { field, ...updateMeta } = args;
+	if (
+		field.type !== "Link" ||
+		field.config?.select !== "document" ||
+		!field.config?.customtypes
+	) {
+		// not a content relationship field
+		return field;
+	}
+
+	const newCustomTypes = updateCRCustomTypes({
+		...updateMeta,
+		customTypes: field.config.customtypes,
+	});
+
+	return {
+		...field,
+		config: { ...field.config, customtypes: newCustomTypes },
+	};
+}
+
+export function updateCustomTypeContentRelationships(
+	args: {
+		models: { model: CustomType }[];
+		onUpdate: (model: CustomType) => void;
+	} & CustomTypeFieldIdChangedMeta,
+): void {
+	const { models, previousPath, newPath, onUpdate } = args;
+
+	for (const customType of models) {
+		const updatedCustomTypeModel = traverseCustomType({
+			customType: customType.model,
+			onField: ({ field }) => {
+				return updateFieldContentRelationships({
+					field,
+					previousPath,
+					newPath,
+				});
+			},
+		});
+
+		onUpdate(updatedCustomTypeModel);
+	}
+}
+
+export function updateSharedSliceContentRelationships(
+	args: {
+		models: { model: SharedSlice }[];
+		onUpdate: (model: SharedSlice) => void;
+	} & CustomTypeFieldIdChangedMeta,
+): void {
+	const { models, previousPath, newPath, onUpdate } = args;
+
+	for (const slice of models) {
+		const updatedSliceModel = traverseSharedSlice({
+			path: ["."],
+			slice: slice.model,
+			onField: ({ field }) => {
+				return updateFieldContentRelationships({
+					field,
+					previousPath,
+					newPath,
+				});
+			},
+		});
+
+		onUpdate(updatedSliceModel);
+	}
+}
+
+function shallowCloneIfObject<T>(value: T): T {
 	if (typeof value === "object") {
 		return { ...value };
 	}
 
 	return value;
 }
+
+function pushIfDefined<T>(array: T[], value: T | undefined) {
+	if (value) {
+		array.push(value);
+	}
+}