@sleighmaster/bmad 1.5.11 → 1.5.13

package/data/_bmad/_config/manifest.yaml

@@ -1,7 +1,7 @@
 distribution:
   name: BMad6GitHub
   version: 1.2.0
-  upstream: 6.0.0-Beta.4
+  upstream: 6.2.0
   repo: https://github.com/SleighMaster99/BMad6GitHub
 installation:
   version: 6.0.0-Beta.4

package/data/_bmad/bmm/workflows/4-implementation/code-review/instructions.xml

@@ -54,11 +54,29 @@
       3. **Code Quality**: Security, performance, maintainability
       4. **Test Quality**: Real tests vs placeholder bullshit
     </action>
+
+    <!-- Initialize review loop counter -->
+    <action>Set {{review_round}} = 0</action>
+    <action>Set {{cumulative_fixed}} = 0</action>
   </step>
 
   <step n="3" goal="Execute adversarial review">
     <critical>VALIDATE EVERY CLAIM - Check git reality vs story claims</critical>
 
+    <!-- Review loop tracking -->
+    <action>Set {{review_round}} = {{review_round}} + 1</action>
+    <check if="{{review_round}} gt 1">
+      <critical>⚠️ THIS IS NOT A VERIFICATION PASS — THIS IS A FULL ADVERSARIAL RE-REVIEW FROM SCRATCH.
+        You MUST NOT assume your fixes are correct. You have confirmation bias — fight it.
+        Treat this round as if a DIFFERENT reviewer is seeing the code for the first time.
+        Execute ALL checks below (AC Validation, Task Audit, Code Quality) with the SAME rigor as Round 1.
+        "Re-read modified files" means read EVERY file in the comprehensive review list, not just the ones you touched.</critical>
+      <output>🔄 **Re-review Round {{review_round}}** — FULL adversarial re-review (not just fix verification)...</output>
+      <action>Re-read ALL files in the comprehensive review list (not just files modified in the previous round)</action>
+      <action>Re-run git status/diff to capture latest changes</action>
+      <action>Re-extract ALL Acceptance Criteria and Tasks from the story file (do NOT rely on memory from previous rounds)</action>
+    </check>
+
     <!-- Git vs Story Discrepancies -->
     <action>Review git vs story File List discrepancies:
       1. **Files changed but not in story File List** → MEDIUM finding (incomplete documentation)
@@ -106,20 +124,47 @@
       </action>
       <action>Find at least 3 more specific, actionable issues</action>
     </check>
+
+    <!-- Mandatory review evidence output — required EVERY round before proceeding to Step 4 -->
+    <critical>You MUST output the following structured evidence checklist BEFORE proceeding to Step 4.
+      If you cannot fill in specific evidence for each section, you have NOT completed the review.
+      Do NOT proceed to Step 4 until every section has concrete evidence.</critical>
+    <output>### 📋 Review Evidence (Round {{review_round}})
+
+      **Files Actually Read This Round:** [list every file path you read]
+
+      **AC Verification:**
+      {{for each AC}}
+      - AC#{{n}}: {{IMPLEMENTED|PARTIAL|MISSING}} — Evidence: {{file:line or specific code reference}}
+      {{/for}}
+
+      **Task Audit:**
+      {{for each [x] task}}
+      - Task {{n}}: {{VERIFIED|NOT DONE}} — Evidence: {{file:line or specific code reference}}
+      {{/for}}
+
+      **Security/Performance Spot-Check:**
+      - Checked: {{list specific checks performed with file references}}
+
+      **Issues Found This Round:** {{count}} ({{high}} HIGH, {{medium}} MEDIUM, {{low}} LOW)
+    </output>
   </step>
 
-  <step n="4" goal="Present findings and fix them">
+  <step n="4" goal="Record findings, auto-fix, and loop until clean">
+    <critical>This step automatically records findings → fixes code → loops back to Step 3 for re-review until no HIGH/MEDIUM issues remain</critical>
+
+    <!-- 4a. Categorize and present findings -->
     <action>Categorize findings: HIGH (must fix), MEDIUM (should fix), LOW (nice to fix)</action>
     <action>Set {{fixed_count}} = 0</action>
     <action>Set {{action_count}} = 0</action>
 
-    <output>**🔥 CODE REVIEW FINDINGS, {user_name}!**
+    <output>**🔥 CODE REVIEW FINDINGS (Round {{review_round}}), {user_name}!**
 
       **Story:** {{story_file}}
       **Git vs Story Discrepancies:** {{git_discrepancy_count}} found
       **Issues Found:** {{high_count}} High, {{medium_count}} Medium, {{low_count}} Low
 
-      ## 🔴 CRITICAL ISSUES
+      ## 🔴 CRITICAL/HIGH ISSUES
       - Tasks marked [x] but not actually implemented
       - Acceptance Criteria not implemented
       - Story claims files changed but no git evidence
@@ -138,33 +183,34 @@
       - Git commit message quality
     </output>
 
-    <ask>What should I do with these issues?
-
-      1. **Fix them automatically** - I'll update the code and tests
-      2. **Create action items** - Add to story Tasks/Subtasks for later
-      3. **Show me details** - Deep dive into specific issues
-
-      Choose [1], [2], or specify which issue to examine:</ask>
+    <!-- 4b. Record findings in story file (document BEFORE fixing) -->
+    <action>Add or update "Review Follow-ups (AI) — Round {{review_round}}" subsection in Tasks/Subtasks</action>
+    <action>For each HIGH and MEDIUM issue: `- [ ] [AI-Review][Round {{review_round}}][{{Severity}}] {{Description}} [{{file}}:{{line}}]`</action>
+    <action>For each LOW issue: `- [ ] [AI-Review][Round {{review_round}}][LOW] {{Description}} [{{file}}:{{line}}]`</action>
+    <action>Set {{action_count}} = number of action items recorded</action>
+
+    <!-- 4c. Check if there are any issues to fix -->
+    <check if="{{high_count}} + {{medium_count}} + {{low_count}} == 0">
+      <!-- No issues at all — review is clean -->
+      <output>✅ **No issues found! Code is clean.**</output>
+      <!-- Proceed to Step 5 (completion) -->
+    </check>
 
-    <check if="user chooses 1">
-      <action>Fix all HIGH and MEDIUM issues in the code</action>
+    <check if="{{high_count}} + {{medium_count}} + {{low_count}} gt 0">
+      <!-- 4d. Auto-fix all issues (HIGH, MEDIUM, and LOW) -->
+      <output>🔧 **Auto-fixing {{high_count}} HIGH + {{medium_count}} MEDIUM + {{low_count}} LOW issues...**</output>
+      <action>Fix all HIGH, MEDIUM, and LOW issues in the code</action>
       <action>Add/update tests as needed</action>
       <action>Update File List in story if files changed</action>
       <action>Update story Dev Agent Record with fixes applied</action>
-      <action>Set {{fixed_count}} = number of HIGH and MEDIUM issues fixed</action>
-      <action>Set {{action_count}} = 0</action>
-    </check>
+      <action>Set {{fixed_count}} = number of all issues fixed</action>
+      <action>Mark fixed items with [x] in "Review Follow-ups (AI)" section</action>
+      <action>Set {{cumulative_fixed}} = {{cumulative_fixed}} + {{fixed_count}}</action>
 
-    <check if="user chooses 2">
-      <action>Add "Review Follow-ups (AI)" subsection to Tasks/Subtasks</action>
-      <action>For each issue: `- [ ] [AI-Review][Severity] Description [file:line]`</action>
-      <action>Set {{action_count}} = number of action items created</action>
-      <action>Set {{fixed_count}} = 0</action>
-    </check>
+      <output>🔧 **Round {{review_round}} fixes applied:** {{fixed_count}} issues fixed. Looping back for re-review...</output>
 
-    <check if="user chooses 3">
-      <action>Show detailed explanation with code examples</action>
-      <action>Return to fix decision</action>
+      <!-- Loop back to Step 3 for FULL re-review — not just verification of fixes -->
+      <goto step="3" scope="FULL" depth="adversarial">Full adversarial re-review — re-execute ALL checks from scratch, not just verify fixes</goto>
     </check>
   </step>
 
@@ -217,10 +263,10 @@
     <output>**✅ Review Complete!**
 
       **Story Status:** {{new_status}}
-      **Issues Fixed:** {{fixed_count}}
-      **Action Items Created:** {{action_count}}
+      **Review Rounds:** {{review_round}}
+      **Total Issues Fixed:** {{cumulative_fixed}}
 
-      {{#if new_status == "done"}}Code review complete!{{else}}Address the action items and continue development.{{/if}}
+      {{#if new_status == "done"}}Code review complete — all issues resolved!{{else}}Some issues could not be resolved. Check story file for details.{{/if}}
     </output>
   </step>
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sleighmaster/bmad",
-  "version": "1.5.11",
+  "version": "1.5.13",
   "description": "BMad6GitHub CLI - BMAD + GitHub Integration installer",
   "type": "module",
   "bin": {