@sleep2agi/commhub-server 0.9.0-preview.89 → 0.9.0-preview.91

package/src/requirements-comment-http.test.ts

@@ -0,0 +1,165 @@
+// #474(MCP 任务生命周期测试报告问题 5)—— 评论 / 进展:只追加,进「动态」(requirement_events kind=comment),
+// 不改任务本身。钉住:
+//   - Agent(节点令牌)经 MCP、人经 REST 都能评论,署名是调用者;description / updated_at 一个字节都不动;
+//   - requirements_events 里是 kind=comment、new.text 全文,单任务的动态体积可控;
+//   - 看不见这张卡的人评论 = 404(和读一样),只读角色 = 403,空 / 超长 = 400 + 提示;
+//   - 只追加:没有改 / 删评论的路由。
+import { describe, expect, test, beforeAll, afterAll } from "bun:test";
+import { mkdtempSync, rmSync } from "fs";
+import { join } from "path";
+import { tmpdir } from "os";
+import { register, createNetworkTokenForNode } from "./auth.js";
+import { db } from "./db.js";
+import { COMMENT_MAX_CHARS } from "./requirements.js";
+
+const DIR = mkdtempSync(join(tmpdir(), "anet-req-comment-"));
+let BASE = "";
+let hub: any = null;
+const PW = "ReqCommentPassw0rd!xyz";
+let NET = "";
+const U: Record<string, { token: string; id: string }> = {};
+let card = { id: "", seq: 0 };
+
+async function rest(token: string, method: string, path: string, body?: unknown) {
+  const res = await fetch(`${BASE}${path}`, { method, headers: { Authorization: `Bearer ${token}`, "Content-Type": "application/json" }, body: body === undefined ? undefined : JSON.stringify(body) });
+  const text = await res.text();
+  let json: any = null;
+  try { json = JSON.parse(text); } catch {}
+  return { status: res.status, body: json, bytes: text.length };
+}
+async function rpc(token: string, name: string, args: Record<string, unknown>): Promise<{ data: any; raw: any; bytes: number }> {
+  const res = await fetch(`${BASE}/mcp`, {
+    method: "POST",
+    headers: { Authorization: `Bearer ${token}`, "Content-Type": "application/json", Accept: "application/json, text/event-stream", "MCP-Protocol-Version": "2025-03-26" },
+    body: JSON.stringify({ jsonrpc: "2.0", id: 1, method: "tools/call", params: { name, arguments: args } }),
+  });
+  const raw = await res.text();
+  const lines = raw.split("\n").filter(x => x.startsWith("data:"));
+  const out = lines.length ? JSON.parse(lines.at(-1)!.slice(5).trim()) : JSON.parse(raw);
+  const text = out.result?.content?.[0]?.text ?? "";
+  let data: any = null;
+  try { data = JSON.parse(text); } catch { data = text; }
+  return { data, raw: out, bytes: text.length };
+}
+const mcp = async (token: string, name: string, args: Record<string, unknown>) => (await rpc(token, name, args)).data;
+const cardRow = (id: string) => db.get<{ description: string | null; updated_at: string | null; updated_by_json: string | null }>("SELECT description, updated_at, updated_by_json FROM requirements WHERE requirement_id = ?1", id)!;
+
+beforeAll(async () => {
+  process.env.COMMHUB_DB ||= join(DIR, "hub.db");
+  process.env.COMMHUB_UPLOADS_DIR = join(DIR, "uploads");
+  process.env.HOST = "127.0.0.1";
+  const a = register(`cmt_owner_${Date.now()}`, PW, undefined, "Owner");
+  U.owner = { token: a.token!, id: a.user!.user_id };
+  NET = a.network_id!;
+  db.run("UPDATE users SET role = 'admin' WHERE user_id = ?1", [U.owner.id]);
+  const mod: any = await import("./server.js");
+  hub = mod.bootServer({ port: 0, hostname: "127.0.0.1" });
+  BASE = `http://127.0.0.1:${hub.port}`;
+  const mk = async (username: string, role: string) => {
+    expect((await rest(U.owner.token, "POST", "/api/admin/users", { username, password: PW, network_id: NET, role })).status).toBe(200);
+    const login = await rest("", "POST", "/api/auth/login", { username, password: PW });
+    return { token: login.body.token as string, id: login.body.user.user_id as string };
+  };
+  const stamp = Date.now();
+  U.member = await mk(`cmt_member_${stamp}`, "member");
+  U.viewer = await mk(`cmt_viewer_${stamp}`, "viewer");
+  U.scoped = await mk(`cmt_scoped_${stamp}`, "member");
+  expect((await rest(U.owner.token, "PUT", `/api/networks/${NET}/members/${U.scoped.id}/task-grants`, { task_access: "scoped", project_grants: [] })).status).toBe(200);
+  U.nodeA = { token: createNetworkTokenForNode(U.owner.id, NET, "示例-甲", "node_cmt_a").token!, id: "node_cmt_a" };
+  const created = (await mcp(U.nodeA.token, "requirements_create", { name: "示例任务:评论", description: "## 背景\n原文。" })).requirement;
+  card = { id: created.id, seq: created.seq };
+}, 30_000);
+
+afterAll(() => {
+  try { hub?.stop?.(true); } catch {}
+  try { rmSync(DIR, { recursive: true, force: true }); } catch {}
+});
+
+describe("requirements_comment", () => {
+  test("an Agent comments over MCP (#N): one comment event, attributed to the node; the task itself is untouched", async () => {
+    const before = cardRow(card.id);
+    const r = await mcp(U.nodeA.token, "requirements_comment", { id: `#${card.seq}`, text: "进展:示例草稿已写完,等人看。" });
+    expect(r.ok).toBe(true);
+    expect(r.event.kind).toBe("comment");
+    expect(r.event.field).toBeNull();
+    expect(r.event.new).toEqual({ text: "进展:示例草稿已写完,等人看。" });
+    expect(r.event.actor).toEqual({ kind: "node", id: "node_cmt_a" });
+    expect(r.event.requirement_id).toBe(card.id);
+    const after = cardRow(card.id);
+    expect(after).toEqual(before); // description, updated_at, updated_by all unchanged
+  });
+
+  test("a person comments over REST; both show in requirements_events with the full text, newest first", async () => {
+    const r = await rest(U.member.token, "POST", `/api/requirements/${card.id}/comments`, { text: "  好的,我下午看。  " });
+    expect(r.status).toBe(201);
+    expect(r.body.event.new.text).toBe("好的,我下午看。"); // trimmed
+    expect(r.body.event.actor).toEqual({ kind: "user", id: U.member.id });
+    const ev = await rpc(U.nodeA.token, "requirements_events", { requirement_id: `#${card.seq}` });
+    const comments = ev.data.events.filter((e: any) => e.kind === "comment");
+    expect(comments.map((e: any) => e.new.text)).toEqual(["好的,我下午看。", "进展:示例草稿已写完,等人看。"]);
+    expect(ev.data.events.at(-1).kind).toBe("created");
+  });
+
+  test("full text up to the cap, and the timeline stays small", async () => {
+    const long = "长".repeat(COMMENT_MAX_CHARS);
+    const r = await mcp(U.nodeA.token, "requirements_comment", { id: card.id, text: long });
+    expect(r.ok).toBe(true);
+    expect(r.event.new.text.length).toBe(COMMENT_MAX_CHARS);
+    const ev = await rpc(U.nodeA.token, "requirements_events", { requirement_id: card.id });
+    // 1 created + 3 comments (one of them 4000 chars): well under 20 KB.
+    expect(ev.bytes).toBeLessThan(20_000);
+    expect(ev.data.events.some((e: any) => e.kind === "comment" && e.new.text === long)).toBe(true);
+  });
+
+  test("bad input: empty → invalid_comment, over the cap → comment_too_long (REST), MCP schema → -32602; both with hints", async () => {
+    const empty = await rest(U.member.token, "POST", `/api/requirements/${card.id}/comments`, { text: "   " });
+    expect(empty.status).toBe(400);
+    expect(empty.body.error).toBe("invalid_comment");
+    expect(empty.body.field).toBe("text");
+    const tooLong = await rest(U.member.token, "POST", `/api/requirements/${card.id}/comments`, { text: "x".repeat(COMMENT_MAX_CHARS + 1) });
+    expect(tooLong.status).toBe(400);
+    expect(tooLong.body.error).toBe("comment_too_long");
+    expect(tooLong.body.hint).toContain("Split");
+    const viaMcp = await rpc(U.nodeA.token, "requirements_comment", { id: card.id, text: "x".repeat(COMMENT_MAX_CHARS + 1) });
+    expect(String(viaMcp.raw.error?.code ?? viaMcp.raw.result?.content?.[0]?.text)).toMatch(/-32602|too big|Too big/i);
+  });
+
+  test("permissions: a non-reader gets 404 (like reading), a read-only role 403; neither writes anything", async () => {
+    const count = () => db.get<{ n: number }>("SELECT COUNT(*) AS n FROM requirement_events WHERE requirement_id = ?1 AND kind = 'comment'", card.id)!.n;
+    const n = count();
+    // scoped member with no grant cannot see the task → cannot read it → cannot comment on it.
+    expect((await rest(U.scoped.token, "GET", `/api/requirements/${card.id}`)).status).toBe(404);
+    const scoped = await rest(U.scoped.token, "POST", `/api/requirements/${card.id}/comments`, { text: "看不见也想评论" });
+    expect(scoped.status).toBe(404);
+    expect(scoped.body.error).toBe("requirement_not_found");
+    const viewer = await rest(U.viewer.token, "POST", `/api/requirements/${card.id}/comments`, { text: "只读角色" });
+    expect(viewer.status).toBe(403);
+    expect(viewer.body.error).toBe("permission_denied");
+    expect(count()).toBe(n);
+    // …and the scoped member does not see the comments in the network timeline either.
+    const ev = await rest(U.scoped.token, "GET", `/api/requirements/events?network_id=${NET}`);
+    expect((ev.body.events ?? []).some((e: any) => e.requirement_id === card.id)).toBe(false);
+  });
+
+  test("append-only: no route edits or deletes a comment; unknown task → requirement_not_found with a hint", async () => {
+    expect((await rest(U.owner.token, "PATCH", `/api/requirements/${card.id}/comments`, { text: "改" })).status).toBe(404);
+    expect((await rest(U.owner.token, "DELETE", `/api/requirements/${card.id}/comments`)).status).toBe(404);
+    const missing = await mcp(U.nodeA.token, "requirements_comment", { id: "#9999", text: "没有这张卡" });
+    expect(missing.error).toBe("requirement_not_found");
+    expect(missing.hint).toContain("requirements_list");
+  });
+
+  test("discoverable: tools/list carries requirements_comment, and requirements_events mentions comments", async () => {
+    const res = await fetch(`${BASE}/mcp`, {
+      method: "POST",
+      headers: { Authorization: `Bearer ${U.nodeA.token}`, "Content-Type": "application/json", Accept: "application/json, text/event-stream", "MCP-Protocol-Version": "2025-03-26" },
+      body: JSON.stringify({ jsonrpc: "2.0", id: 1, method: "tools/list" }),
+    });
+    const raw = await res.text();
+    const lines = raw.split("\n").filter(x => x.startsWith("data:"));
+    const tools = (lines.length ? JSON.parse(lines.at(-1)!.slice(5).trim()) : JSON.parse(raw)).result.tools as any[];
+    const byName = new Map(tools.map(t => [t.name, t]));
+    expect(String(byName.get("requirements_comment")?.description)).toContain("append-only");
+    expect(String(byName.get("requirements_events")?.description)).toContain("kind=comment");
+  });
+});

package/src/requirements-errors-mcp-http.test.ts

@@ -73,8 +73,9 @@ describe("each hint, over MCP", () => {
     const byAlias = await mcp(nodeToken, "requirements_update", { id: cardId, agent_owner: { kind: "node", id: "示例-甲" } });
     expect(byAlias.error).toBe("person_not_in_network");
     expect(byAlias.field).toBe("agent_owner");
-    expect(byAlias.hint).toContain("get_all_status");
-    expect(byAlias.hint).toContain("Aliases and usernames are not accepted");
+    // #473:人员字段也收名字 —— 提示改为指向 requirements_people,并说明 alias / username 的写法。
+    expect(byAlias.hint).toContain("requirements_people");
+    expect(byAlias.hint).toContain("{kind:'node', alias}");
     expect((await mcp(nodeToken, "requirements_update", { id: cardId, owner: { kind: "user", id: "u_nobody" } })).field).toBe("owner");
     expect((await mcp(nodeToken, "requirements_update", { id: cardId, participants: [{ kind: "node", id: "node_reqerr_a" }, { kind: "user", id: "u_nobody" }] })).field).toBe("participants");
   });

package/src/requirements-errors.ts

@@ -23,7 +23,8 @@ type Detail = { field?: string; message: string; hint?: string };
 type Entry = Detail | ((ctx: ErrorContext) => Detail);
 
 const DUE_FORMATS = 'YYYY-MM-DD (all day) or ISO 8601 with Z / ±HH:MM (e.g. 2026-10-10T18:00:00+08:00); "" clears it';
-const PERSON_IDS = "node ids (kind:'node') come from get_all_status (node_id) or a task's agent_owner / participants; user ids (kind:'user') from a task's owner / created_by / participants. Aliases and usernames are not accepted.";
+// #473 —— 人员字段也收名字({kind:'user', username} / {kind:'node', alias}),只在任务所在的网络里解析;查人用 requirements_people。
+const PERSON_IDS = "Look people up with requirements_people (q= filters by name): it returns each member's user_id and username and the node_id and alias of their Agents. Pass {kind:'user', id} or {kind:'user', username}, {kind:'node', id} or {kind:'node', alias}; names resolve only in the task's own network.";
 
 const ENTRIES: Record<string, Entry> = {
   // ── 定位 / 范围 ──
@@ -40,12 +41,20 @@ const ENTRIES: Record<string, Entry> = {
   upsert_not_allowed: { message: 'Task-scoped members cannot upsert by external_ref.', hint: 'Use requirements_create / requirements_update on tasks you can see.' },
   external_ref_not_allowed: { field: 'external_ref', message: 'Task-scoped members cannot set external_ref.', hint: 'Leave external_ref out.' },
   // ── 人员 ──
-  invalid_person: (ctx) => ({ field: ctx.field ?? 'owner', message: 'A person must be an object {kind:"user"|"node", id}.', hint: PERSON_IDS }),
-  person_not_in_network: (ctx) => ({ field: ctx.field ?? 'owner', message: `${ctx.field ?? 'owner'} names nobody in this network (unknown id, wrong kind, or a node you cannot see).`, hint: PERSON_IDS }),
+  invalid_person: (ctx) => ({ field: ctx.field ?? 'owner', message: 'A person must be an object {kind:"user", id | username} or {kind:"node", id | alias}.', hint: PERSON_IDS }),
+  person_not_in_network: (ctx) => ({ field: ctx.field ?? 'owner', message: `${ctx.field ?? 'owner'} names nobody in this network (unknown id / username / alias, wrong kind, or a node you cannot see).`, hint: PERSON_IDS }),
+  person_ambiguous: (ctx) => ({ field: ctx.field ?? 'agent_owner', message: 'More than one Agent in this network has that alias.', hint: 'Call requirements_people (q=<alias>) and pass the node_id instead.' }),
   owner_must_be_human: { field: 'owner', message: 'owner (负责人) must be a person.', hint: "Use owner: {kind:'user', id}. To assign a node / Agent, use agent_owner: {kind:'node', id}." },
   agent_owner_must_be_agent: { field: 'agent_owner', message: 'agent_owner (负责 Agent) must be a node.', hint: "Use agent_owner: {kind:'node', id}. To assign a person, use owner: {kind:'user', id}." },
   agent_owner_not_granted: { field: 'agent_owner', message: 'The current responsible Agent is one you are not granted, so you cannot replace or clear it.', hint: 'Leave agent_owner out of the patch.' },
   invalid_participants: { field: 'participants', message: 'participants must be an array of up to 100 persons {kind, id}; it replaces the whole list.', hint: 'Send the full list you want (read it first with requirements_get).' },
+  department_scope_denied: { field: 'owner', message: 'As a department head you can hand this task only to people in your department (or yourself) and to their Agents.', hint: 'Pick someone from your department, or ask an owner / admin to move it to another department.' },
+  department_not_found: { field: 'department_id', message: 'No department with that id in your network(s).', hint: 'Department ids come from GET /api/networks/{id}/departments.' },
+  invalid_participants_delta: { field: 'participants_add', message: 'participants_add / participants_remove must each be an array of up to 100 persons ({kind, id}, {kind:"user", username} or {kind:"node", alias}).', hint: PERSON_IDS },
+  participants_conflict: { field: 'participants', message: 'participants (replace the whole list) cannot be combined with participants_add / participants_remove.', hint: 'Use participants_add / participants_remove to change a few people, or participants alone to replace the list.' },
+  participants_add_remove_overlap: { field: 'participants_remove', message: 'The same person is in both participants_add and participants_remove.', hint: 'Send each person in only one of the two lists.' },
+  too_many_participants: { field: 'participants_add', message: 'A task can have at most 100 participants.', hint: 'Remove some with participants_remove first.' },
+  status_conflicts_with_column: { field: 'status', message: 'status is an alias of column, and the two values sent differ.', hint: 'Send only one of them (pool, doing or done).' },
   invalid_assignee: { field: 'assignee', message: 'assignee must be a string (legacy free-text field).', hint: 'Prefer owner / agent_owner.' },
   // ── 项目 ──
   invalid_project: { field: 'project_id', message: 'project_id must be a project id string or null.', hint: 'Call projects_list to get project ids (proj_…); null removes the task from its project.' },
@@ -102,6 +111,8 @@ const ENTRIES: Record<string, Entry> = {
   invalid_updated_since: { field: 'updated_since', message: 'updated_since must be an ISO 8601 time.', hint: 'Use server_time from the previous changes=true response.' },
   updated_since_required: { field: 'updated_since', message: 'changes=true needs updated_since.', hint: 'Pass updated_since (ISO time; server_time from the last call).' },
   invalid_since: { field: 'since', message: 'since must be an ISO 8601 time.', hint: 'Use server_time from the previous requirements_events response.' },
+  invalid_comment: { field: 'text', message: 'A comment needs non-empty text.', hint: 'Pass text (markdown), e.g. a progress note or a conclusion.' },
+  comment_too_long: { field: 'text', message: 'A comment can be at most 4000 characters.', hint: 'Split it into several comments, or put the long part in the description.' },
   insert_failed: { message: 'The hub could not save the task.', hint: 'Retry once; if it fails again, report it.' },
 };
 

package/src/requirements-people-mcp-http.test.ts

@@ -0,0 +1,225 @@
+// #473(#469 问题 2)—— Agent 查人 + 人员字段按名字写。
+//
+// 钉住:
+//   1. MCP requirements_people:紧凑行(user_id / username / display_name / role / department / agents),
+//      没主人的 Agent 单列;q 按用户名 / 显示名 / 部门 / Agent 别名筛;50 人一页、offset 翻页;一页有字节上限。
+//   2. 严格参数:不认识的参数 → -32602,列出能用的参数。
+//   3. requirements_create / update / upsert 的 owner / agent_owner / participants 收 {kind:'user', username} 与
+//      {kind:'node', alias},在任务所在的网络里解析,存下来仍是 {kind, id}。
+//   4. 别名对上多个 Agent → person_ambiguous;找不到 → person_not_in_network;都带 field 和指向 requirements_people 的 hint。
+//   5. 绝不跨网络:别的网络的用户名 / 别名都是「找不到」。受限成员看不见的 Agent:通讯录里没有,按别名写也是「找不到」。
+//   6. REST GET /api/requirements/people 的形状不变。
+//
+// 跑法:cd server && COMMHUB_DB=/tmp/x.db bun test src/requirements-people-mcp-http.test.ts
+//       PG:COMMHUB_TEST_PG_URL=… COMMHUB_PG_EXPERIMENTAL=1(tests/test2123-hub-postgres-ladder 里注册)
+import { afterAll, beforeAll, describe, expect, test } from "bun:test";
+import { Client } from "@modelcontextprotocol/sdk/client/index.js";
+import { InMemoryTransport } from "@modelcontextprotocol/sdk/inMemory.js";
+import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { addNetworkMember, register } from "./auth.js";
+import { db } from "./db.js";
+import { createDepartment, setMemberDepartment } from "./departments.js";
+import { registerTools } from "./tools.js";
+
+const activeDbPath = process.env.COMMHUB_DB ?? (process.env.COMMHUB_TEST_PG_URL ? "postgres" : undefined);
+if (!activeDbPath) throw new Error("requirements-people-mcp requires COMMHUB_DB (or COMMHUB_TEST_PG_URL) before module import");
+
+const stamp = Date.now();
+const PW = "PeopleLookup123!";
+/** 一页 50 人(每人带部门、1 个 Agent)的字节上限。实测约 12.6 KB(≈ 250 B / 人);上限 16 KB。 */
+const PAGE_MAX_BYTES = 16_000;
+const EXTRA_MEMBERS = 60;
+
+let server: any;
+let base = "";
+let netA = "", netB = "";
+let boss: { id: string; token: string; username: string };
+let alice: { id: string; username: string };
+let bob: { id: string; username: string };
+let carol: { id: string; username: string };
+let ruth: { id: string; username: string };
+let deptId = "";
+const node = (suffix: string) => `n_pl_${suffix}_${stamp}`;
+const ALIAS = { alice: `alice-bot-${stamp}`, dup: `dup-bot-${stamp}`, free: `free-bot-${stamp}`, far: `far-bot-${stamp}` };
+
+type Mcp = { call: (name: string, args: Record<string, unknown>) => Promise<any>; close: () => Promise<void> };
+async function connect(userId: string, username: string): Promise<Mcp> {
+  const s = new McpServer({ name: "people", version: "1" });
+  registerTools(s, undefined, null, userId, username, false, "tok_user");
+  const client = new Client({ name: "people-client", version: "1" });
+  const [ct, st] = InMemoryTransport.createLinkedPair();
+  await s.connect(st);
+  await client.connect(ct);
+  return {
+    call: async (name, args) => {
+      const r: any = await client.callTool({ name, arguments: args });
+      const text = String(r.content?.[0]?.text ?? "");
+      if (r.isError) return { mcpError: true, text };
+      return { ...JSON.parse(text), _bytes: Buffer.byteLength(text, "utf8") };
+    },
+    close: async () => { await client.close(); await s.close(); },
+  };
+}
+let asBoss: Mcp, asRuth: Mcp;
+
+function mk(name: string) {
+  const r = register(`${name}_${stamp}`, PW, undefined, name === "alice" ? "爱丽丝" : undefined);
+  expect(r.ok).toBe(true);
+  return { id: r.user!.user_id, token: r.token!, username: r.user!.username, net: r.network_id! };
+}
+const insertNode = (id: string, alias: string, net: string, owner: string | null) =>
+  db.run("INSERT INTO nodes (node_id, node_name, alias, network_id, owner_user_id) VALUES (?1, ?2, ?2, ?3, ?4)", [id, alias, net, owner]);
+
+beforeAll(async () => {
+  const b = mk("boss"); boss = { id: b.id, token: b.token, username: b.username }; netA = b.net;
+  const a = mk("alice"); alice = { id: a.id, username: a.username };
+  const o = mk("bob"); bob = { id: o.id, username: o.username };
+  const c = mk("carol"); carol = { id: c.id, username: c.username }; netB = c.net;
+  const r = mk("ruth"); ruth = { id: r.id, username: r.username };
+  expect(addNetworkMember(netA, alice.id, "member", boss.id, { agentAccess: "all" }).ok).toBe(true);
+  expect(addNetworkMember(netA, bob.id, "member", boss.id, { agentAccess: "all" }).ok).toBe(true);
+  // ruth:受限成员(只看授权的 Agent),一个都没授权
+  expect(addNetworkMember(netA, ruth.id, "member", boss.id, { agentAccess: "granted" }).ok).toBe(true);
+  const dept = createDepartment(netA, boss.id, { name: `研发部${stamp % 1000}` });
+  expect(dept.ok).toBe(true);
+  deptId = (dept as any).department.id;
+  expect(setMemberDepartment(netA, alice.id, deptId).ok).toBe(true);
+  insertNode(node("alice"), ALIAS.alice, netA, alice.id);
+  insertNode(node("dup1"), ALIAS.dup, netA, null);
+  insertNode(node("dup2"), ALIAS.dup, netA, null);
+  insertNode(node("free"), ALIAS.free, netA, null);
+  insertNode(node("far"), ALIAS.far, netB, carol.id);
+  for (let i = 0; i < EXTRA_MEMBERS; i++) {
+    const m = register(`pl_m${String(i).padStart(2, "0")}_${stamp}`, PW, undefined, `成员${i}`);
+    expect(addNetworkMember(netA, m.user!.user_id, "member", boss.id, { agentAccess: "all" }).ok).toBe(true);
+    setMemberDepartment(netA, m.user!.user_id, deptId);
+    insertNode(node(`m${i}`), `m${i}-bot-${stamp}`, netA, m.user!.user_id);
+  }
+  const mod: any = await import("./server.js");
+  server = mod.bootServer({ port: 0, hostname: "127.0.0.1" });
+  base = `http://127.0.0.1:${server.port}`;
+  asBoss = await connect(boss.id, boss.username);
+  asRuth = await connect(ruth.id, ruth.username);
+}, 120_000);
+afterAll(async () => { await asBoss?.close(); await asRuth?.close(); server?.stop?.(true); });
+
+describe("#473 requirements_people", () => {
+  test("compact rows: username, display_name, role, department, owned agents; unowned agents listed once", async () => {
+    const r = await asBoss.call("requirements_people", { network_id: netA, q: "alice" });
+    expect(r.ok).toBe(true);
+    expect(r.people).toEqual([{
+      user_id: alice.id, username: alice.username, display_name: "爱丽丝", role: "member",
+      department: { id: deptId, name: `研发部${stamp % 1000}` }, agents: [{ node_id: node("alice"), alias: ALIAS.alice }],
+    }]);
+    const all = await asBoss.call("requirements_people", { network_id: netA, q: String(stamp) });
+    expect(all.agents_without_owner.map((a: any) => a.alias).sort()).toEqual([ALIAS.dup, ALIAS.dup, ALIAS.free].sort());
+    const bossRow = (await asBoss.call("requirements_people", { network_id: netA, q: boss.username })).people[0];
+    expect(bossRow.role).toBe("owner");
+    expect(bossRow.display_name).toBe("");
+    expect(bossRow.department).toBeNull();
+  });
+
+  test("q matches username, display name, department and Agent alias", async () => {
+    expect((await asBoss.call("requirements_people", { network_id: netA, q: "爱丽" })).people.map((p: any) => p.user_id)).toEqual([alice.id]);
+    expect((await asBoss.call("requirements_people", { network_id: netA, q: ALIAS.alice.toUpperCase() })).people.map((p: any) => p.user_id)).toEqual([alice.id]);
+    const dept = await asBoss.call("requirements_people", { network_id: netA, q: `研发部${stamp % 1000}`, limit: 200 });
+    expect(dept.total).toBe(EXTRA_MEMBERS + 1);
+  });
+
+  test("default page = 50 people under the byte bound; offset pages the rest", async () => {
+    const p1 = await asBoss.call("requirements_people", { network_id: netA });
+    expect(p1.people.length).toBe(50);
+    expect(p1.has_more).toBe(true);
+    console.log(`people page of 50: ${p1._bytes} B`);
+    expect(p1._bytes).toBeLessThan(PAGE_MAX_BYTES);
+    const p2 = await asBoss.call("requirements_people", { network_id: netA, offset: p1.next_offset });
+    expect(p2.people.length).toBe(p1.total - 50);
+    expect(p2.agents_without_owner).toBeUndefined();
+    expect(new Set([...p1.people, ...p2.people].map((p: any) => p.user_id)).size).toBe(p1.total);
+  });
+
+  test("strict params: unknown key → -32602 listing the valid ones", async () => {
+    const r = await asBoss.call("requirements_people", { network_id: netA, name: "alice" });
+    expect(r.mcpError).toBe(true);
+    expect(r.text).toContain("-32602");
+    expect(r.text).toContain("unknown parameter(s): name; valid parameters: network_id, q, limit, offset");
+  });
+
+  test("another network is not readable; a restricted member sees no ungranted Agents", async () => {
+    const other = await asBoss.call("requirements_people", { network_id: netB });
+    expect(other.ok).toBe(false);
+    const r = await asRuth.call("requirements_people", { network_id: netA, q: String(stamp), limit: 200 });
+    expect(r.people.every((p: any) => p.agents.length === 0)).toBe(true);
+    expect(r.agents_without_owner).toEqual([]);
+  });
+});
+
+describe("#473 person fields by name", () => {
+  test("create / update / upsert accept username and alias; stored as ids in this network", async () => {
+    const made = await asBoss.call("requirements_create", {
+      network_id: netA, name: `by name ${stamp}`,
+      owner: { kind: "user", username: alice.username },
+      agent_owner: { kind: "node", alias: ALIAS.alice },
+      participants: [{ kind: "user", username: bob.username }, { kind: "node", alias: ALIAS.free }],
+    });
+    expect(made.ok).toBe(true);
+    const req = made.requirement;
+    expect(req.owner).toEqual({ kind: "user", id: alice.id });
+    expect(req.agent_owner).toEqual({ kind: "node", id: node("alice") });
+    expect(req.participants).toEqual([{ kind: "user", id: bob.id }, { kind: "node", id: node("free") }]);
+
+    const upd = await asBoss.call("requirements_update", { id: req.id, network_id: netA, owner: { kind: "user", username: bob.username } });
+    expect(upd.requirement.owner).toEqual({ kind: "user", id: bob.id });
+
+    const ups = await asBoss.call("requirements_upsert_by_external_ref", {
+      network_id: netA, external_ref: `test:people#${stamp}`, name: "upserted", agent_owner: { kind: "node", alias: ALIAS.alice },
+    });
+    expect(ups.requirement.agent_owner).toEqual({ kind: "node", id: node("alice") });
+    // id 照旧可用,且优先于名字
+    const byId = await asBoss.call("requirements_update", { id: req.id, network_id: netA, owner: { kind: "user", id: alice.id, username: bob.username } });
+    expect(byId.requirement.owner).toEqual({ kind: "user", id: alice.id });
+  });
+
+  test("ambiguous alias → person_ambiguous with field and a requirements_people hint", async () => {
+    const r = await asBoss.call("requirements_create", { network_id: netA, name: "amb", agent_owner: { kind: "node", alias: ALIAS.dup } });
+    expect(r.ok).toBe(false);
+    expect(r.error).toBe("person_ambiguous");
+    expect(r.field).toBe("agent_owner");
+    expect(r.hint).toContain("requirements_people");
+    expect(r.hint).toContain("node_id");
+  });
+
+  test("unknown name → person_not_in_network naming the field and requirements_people", async () => {
+    const r = await asBoss.call("requirements_create", { network_id: netA, name: "nope", participants: [{ kind: "user", username: `ghost_${stamp}` }] });
+    expect(r.error).toBe("person_not_in_network");
+    expect(r.field).toBe("participants");
+    expect(r.hint).toContain("requirements_people");
+  });
+
+  test("never across networks: another network's username / alias is not found", async () => {
+    const u = await asBoss.call("requirements_create", { network_id: netA, name: "x", owner: { kind: "user", username: carol.username } });
+    expect(u.error).toBe("person_not_in_network");
+    const n = await asBoss.call("requirements_create", { network_id: netA, name: "x", agent_owner: { kind: "node", alias: ALIAS.far } });
+    expect(n.error).toBe("person_not_in_network");
+  });
+
+  test("wrong-kind or missing identifier → invalid_person", async () => {
+    for (const bad of [{ kind: "user", alias: ALIAS.alice }, { kind: "node", username: alice.username }, { kind: "user" }]) {
+      const r = await asBoss.call("requirements_create", { network_id: netA, name: "bad", participants: [bad] });
+      expect(r.error).toBe("invalid_person");
+      expect(r.hint).toContain("requirements_people");
+    }
+  });
+
+  test("a restricted member cannot resolve an Agent alias they are not granted", async () => {
+    const r = await asRuth.call("requirements_create", { network_id: netA, name: "hidden", agent_owner: { kind: "node", alias: ALIAS.alice } });
+    expect(r.error).toBe("person_not_in_network");
+  });
+
+  test("REST GET /api/requirements/people keeps its shape", async () => {
+    const res = await fetch(`${base}/api/requirements/people?network_id=${netA}`, { headers: { Authorization: `Bearer ${boss.token}` } });
+    const body = await res.json() as any;
+    expect(res.status).toBe(200);
+    for (const p of body.people) expect(Object.keys(p).sort()).toEqual(["display_name", "id", "kind", "name", "networkId"]);
+  });
+});

package/src/requirements-people.ts

@@ -0,0 +1,127 @@
+// #473(#469 问题 2)—— Agent 查人。
+//
+// 现场:Agent 想把任务派给「张三」或者某个节点,手里只有用户名 / 别名,而任务的人员字段只收 id;
+// GET /api/requirements/people 只给显示名,没有用户名、角色、部门,也看不出哪个 Agent 是谁的。
+// 这里给 MCP requirements_people 一份紧凑的通讯录:每个成员一行(user_id、username、display_name、网络角色、
+// 部门),带上他名下的 Agent(node_id、alias);没有主人(或主人不在本网络)的 Agent 单列。
+// 只在一个网络里查,受限成员看不见的 Agent 一律不出现(与 /people 同一个 hidden 判据)。
+//
+// 人员字段按名字写(owner {kind:'user', username} / agent_owner {kind:'node', alias})的解析在
+// requirements.ts personRef():同样只在任务所在的那个网络里找,看不见的节点等同不存在。
+
+import { db } from "./db.js";
+import "./departments.js"; // network_departments 表 + network_members.department_id 列(导入即建,只增)
+
+type HiddenNode = ((nodeId: string) => boolean) | null;
+
+export const PEOPLE_DEFAULT_LIMIT = 50;
+export const PEOPLE_MAX_LIMIT = 200;
+
+export type DirectoryAgent = { node_id: string; alias: string };
+export type DirectoryPerson = {
+  user_id: string;
+  username: string;
+  /** 没设(或等于用户名)为 ""(与 /people 同一规则)。 */
+  display_name: string;
+  role: string;
+  department: { id: string; name: string } | null;
+  agents: DirectoryAgent[];
+};
+
+/** q / limit / offset 解析;不合法 → 错误码(400)。 */
+export function parsePeopleQuery(params: URLSearchParams): { q: string; limit: number; offset: number } | { error: string } {
+  const q = (params.get("q") ?? "").trim();
+  if (q.length > 100) return { error: "invalid_q" };
+  let limit = PEOPLE_DEFAULT_LIMIT;
+  const rawLimit = params.get("limit");
+  if (rawLimit !== null) {
+    if (!/^\d{1,4}$/.test(rawLimit)) return { error: "invalid_limit" };
+    limit = Number(rawLimit);
+    if (limit < 1 || limit > PEOPLE_MAX_LIMIT) return { error: "invalid_limit" };
+  }
+  let offset = 0;
+  const rawOffset = params.get("offset");
+  if (rawOffset !== null) {
+    if (!/^\d{1,6}$/.test(rawOffset)) return { error: "invalid_offset" };
+    offset = Number(rawOffset);
+  }
+  return { q, limit, offset };
+}
+
+/**
+ * 一个网络的通讯录。q = 不区分大小写的子串,匹配用户名 / 显示名 / 部门名 / 名下 Agent 的别名;
+ * 成员按 username 排序、offset 翻页;没主人的 Agent 只在第一页给(按 q 过滤)。
+ */
+export function peopleDirectory(networkId: string, hidden: HiddenNode, query: { q: string; limit: number; offset: number }) {
+  const members = db.all<{ user_id: string; username: string; display_name: string | null; role: string | null; department_id: string | null; department_name: string | null }>(
+    `SELECT u.user_id, u.username, u.display_name, m.role, d.department_id, d.name AS department_name
+       FROM network_members m
+       JOIN users u ON u.user_id = m.user_id
+       LEFT JOIN network_departments d ON d.network_id = m.network_id AND d.department_id = m.department_id
+      WHERE m.network_id = ?1
+      ORDER BY u.username, u.user_id`,
+    networkId,
+  );
+  const nodes = db.all<{ node_id: string; alias: string | null; node_name: string; owner_user_id: string | null }>(
+    "SELECT node_id, alias, node_name, owner_user_id FROM nodes WHERE network_id = ?1 ORDER BY COALESCE(alias, node_name), node_id",
+    networkId,
+  ).filter(n => !hidden?.(n.node_id));
+  const memberIds = new Set(members.map(m => m.user_id));
+  const byOwner = new Map<string, DirectoryAgent[]>();
+  const unowned: DirectoryAgent[] = [];
+  for (const n of nodes) {
+    const agent = { node_id: n.node_id, alias: n.alias || n.node_name };
+    if (n.owner_user_id && memberIds.has(n.owner_user_id)) {
+      const list = byOwner.get(n.owner_user_id) ?? [];
+      list.push(agent);
+      byOwner.set(n.owner_user_id, list);
+    } else unowned.push(agent);
+  }
+  const needle = query.q.toLowerCase();
+  const hit = (s: string | null | undefined) => !needle || (s ?? "").toLowerCase().includes(needle);
+  const people: DirectoryPerson[] = [];
+  for (const m of members) {
+    const displayName = !m.display_name || m.display_name === m.username ? "" : m.display_name;
+    const agents = byOwner.get(m.user_id) ?? [];
+    if (!(hit(m.username) || (displayName && hit(displayName)) || (m.department_name && hit(m.department_name)) || agents.some(a => hit(a.alias)))) continue;
+    people.push({
+      user_id: m.user_id,
+      username: m.username,
+      display_name: displayName,
+      role: m.role ?? "member",
+      department: m.department_id && m.department_name ? { id: m.department_id, name: m.department_name } : null,
+      agents,
+    });
+  }
+  const page = people.slice(query.offset, query.offset + query.limit);
+  const hasMore = query.offset + query.limit < people.length;
+  return {
+    ok: true,
+    network_id: networkId,
+    total: people.length,
+    people: page,
+    ...(query.offset === 0 ? { agents_without_owner: unowned.filter(a => hit(a.alias)) } : {}),
+    has_more: hasMore,
+    next_offset: hasMore ? query.offset + query.limit : null,
+  };
+}
+
+/**
+ * 按名字找人(personRef 用):只在 networkId 里找,hidden 的节点等同不存在。
+ * 返回 id;找不到 → person_not_in_network;同一个别名对上多个节点 → person_ambiguous。
+ */
+export function resolvePersonName(kind: "user" | "node", name: string, networkId: string, hidden: HiddenNode): string {
+  if (kind === "user") {
+    const row = db.get<{ user_id: string }>(
+      "SELECT u.user_id FROM network_members m JOIN users u ON u.user_id = m.user_id WHERE m.network_id = ?1 AND u.username = ?2",
+      networkId, name,
+    );
+    if (!row) throw new Error("person_not_in_network");
+    return row.user_id;
+  }
+  const rows = db.all<{ node_id: string }>("SELECT node_id FROM nodes WHERE network_id = ?1 AND alias = ?2", networkId, name)
+    .filter(r => !hidden?.(r.node_id));
+  if (rows.length === 0) throw new Error("person_not_in_network");
+  if (rows.length > 1) throw new Error("person_ambiguous");
+  return rows[0].node_id;
+}