@sleep2agi/commhub-server 0.9.0-preview.8 → 0.9.0-preview.81

package/src/requirement-tags.ts

@@ -0,0 +1,89 @@
+/** Small, network-local labels; count Unicode code points rather than UTF-16 units. */
+export function normalizeTags(value: unknown): string[] | null {
+  if (!Array.isArray(value) || value.length > 10) return null;
+  const tags: string[] = [];
+  for (const valueTag of value) {
+    if (typeof valueTag !== "string") return null;
+    const tag = valueTag.trim();
+    if (!tag || [...tag].length > 20 || /[\u0000-\u001f\u007f]/u.test(tag)) return null;
+    if (!tags.includes(tag)) tags.push(tag);
+  }
+  return tags;
+}
+
+export function storedTags(value: string | null): string[] {
+  try { return normalizeTags(JSON.parse(value || "[]")) ?? []; } catch { return []; }
+}
+
+// ── 标签管理(改名 / 合并 / 删除 / 颜色) ──
+// 标签只是卡片 tags 数组里的字符串,没有自己的表;批量操作 = 把网络里每张带这个标签的卡的数组改写一遍。
+// 颜色是可选的,单独存在 network_tags(network_id, name, color);没行 = 客户端用默认灰。
+export const MAX_MERGE_SOURCES = 50;
+export type TagOp =
+  | { op: "rename"; from: string; to: string }
+  | { op: "merge"; from: string[]; to: string }
+  | { op: "delete"; tag: string }
+  | { op: "color"; tag: string; color: string | null };
+
+/** 单个标签名,规则同 normalizeTags。不合法 = null。 */
+export function tagName(value: unknown): string | null {
+  const tags = normalizeTags([value]);
+  return tags && tags.length === 1 ? tags[0] : null;
+}
+
+const TAG_COLOR = /^#[0-9a-fA-F]{6}$/;
+/** 请求体 → 操作;不合法返回错误码。 */
+export function parseTagOp(body: Record<string, unknown>): TagOp | { error: string } {
+  switch (body.op) {
+    case "rename": {
+      const from = tagName(body.from), to = tagName(body.to);
+      if (!from || !to) return { error: "invalid_tag" };
+      if (from === to) return { error: "same_tag" };
+      return { op: "rename", from, to };
+    }
+    case "merge": {
+      if (!Array.isArray(body.from) || body.from.length === 0 || body.from.length > MAX_MERGE_SOURCES) return { error: "invalid_tag" };
+      const from: string[] = [];
+      for (const value of body.from) {
+        const tag = tagName(value);
+        if (!tag) return { error: "invalid_tag" };
+        if (!from.includes(tag)) from.push(tag);
+      }
+      const to = tagName(body.to);
+      if (!to) return { error: "invalid_tag" };
+      // 目标自己出现在来源里不算来源(合并进自己 = 什么都不做)。
+      const sources = from.filter(tag => tag !== to);
+      if (!sources.length) return { error: "same_tag" };
+      return { op: "merge", from: sources, to };
+    }
+    case "delete": {
+      const tag = tagName(body.tag);
+      return tag ? { op: "delete", tag } : { error: "invalid_tag" };
+    }
+    case "color": {
+      const tag = tagName(body.tag);
+      if (!tag) return { error: "invalid_tag" };
+      if (body.color !== null && (typeof body.color !== "string" || !TAG_COLOR.test(body.color))) return { error: "invalid_tag_color" };
+      return { op: "color", tag, color: body.color === null ? null : (body.color as string).toLowerCase() };
+    }
+    default:
+      return { error: "invalid_tag_op" };
+  }
+}
+
+/** 这张卡的标签被这个操作改写后的样子;没变返回 null。顺序保留(新名字占第一个来源的位置),去重。 */
+export function applyTagOp(tags: string[], op: TagOp): string[] | null {
+  let sources: string[];
+  let to: string | null;
+  if (op.op === "rename") { sources = [op.from]; to = op.to; }
+  else if (op.op === "merge") { sources = op.from; to = op.to; }
+  else if (op.op === "delete") { sources = [op.tag]; to = null; }
+  else return null;
+  if (!tags.some(tag => sources.includes(tag))) return null;
+  const next: string[] = [];
+  for (const tag of tags) {
+    const mapped = sources.includes(tag) ? to : tag;
+    if (mapped !== null && !next.includes(mapped)) next.push(mapped);
+  }
+  return next;
+}

package/src/requirements-completed-at-migration.test.ts

@@ -0,0 +1,70 @@
+// 完成时间的启动迁移(requirements-migrate.ts ensureRequirementCompletedAt):用加完成时间之前的表结构建库、塞行,
+// 再 import db.ts + requirements.ts(真实启动路径)。覆盖:两种旧时间形状、没有 updated_at 的行、
+// 回滚到旧 Hub 期间「移出完成」留下的残值被清掉、「移进完成」的卡被补上,以及重复执行不再改任何东西。
+import { afterAll, expect, test } from "bun:test";
+import { Database } from "bun:sqlite";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+const dir = mkdtempSync(join(tmpdir(), "anet-req-completed-at-"));
+const file = join(dir, "hub.db");
+process.env.COMMHUB_DB = file;
+
+const legacy = new Database(file);
+legacy.exec(`CREATE TABLE requirements (
+  requirement_id TEXT PRIMARY KEY, network_id TEXT NOT NULL, title TEXT NOT NULL,
+  column_name TEXT NOT NULL DEFAULT 'pool' CHECK(column_name IN ('pool', 'doing', 'done')), priority TEXT NOT NULL DEFAULT 'normal', due_on TEXT, assignee TEXT,
+  client_id TEXT, issues_json TEXT, created_by TEXT,
+  created_at TEXT NOT NULL DEFAULT (datetime('now')), updated_at TEXT NOT NULL DEFAULT (datetime('now')),
+  owner_json TEXT, participants_json TEXT NOT NULL DEFAULT '[]', updated_by_json TEXT)`);
+const seed: [string, string, string, string][] = [
+  // id, column, created_at, updated_at
+  ["r_done_sqlite_ts", "done", "2026-08-01 08:00:00", "2026-09-01 10:00:00"],
+  ["r_done_iso", "done", "2026-08-02T00:00:00.000Z", "2026-09-02T03:04:05.678Z"],
+  ["r_done_bad_updated", "done", "2026-08-03T00:00:00.000Z", "not a time"],
+  ["r_doing", "doing", "2026-08-04T00:00:00.000Z", "2026-09-04T00:00:00.000Z"],
+  ["r_pool", "pool", "2026-08-05T00:00:00.000Z", "2026-09-05T00:00:00.000Z"],
+];
+for (const [id, column, createdAt, updatedAt] of seed) {
+  legacy.run("INSERT INTO requirements (requirement_id, network_id, title, column_name, created_at, updated_at, updated_by_json) VALUES (?1, 'net', ?1, ?2, ?3, ?4, ?5)",
+    [id, column, createdAt, updatedAt, JSON.stringify({ kind: "user", id: "u_last_editor" })]);
+}
+legacy.close();
+
+afterAll(() => { try { rmSync(dir, { recursive: true, force: true }); } catch {} });
+
+const read = (db: any) => Object.fromEntries((db.all("SELECT requirement_id, column_name, updated_at, completed_at, completed_by_json, completed_at_approx FROM requirements") as any[]).map(r => [r.requirement_id, r]));
+
+test("backfill: done rows get an approximate ISO completed_at from updated_at; others stay empty; idempotent", async () => {
+  const { db } = await import("./db.js");
+  await import("./requirements.js");
+  const { ensureRequirementCompletedAt } = await import("./requirements-migrate.js");
+  const by = read(db);
+  expect(by.r_done_sqlite_ts.completed_at).toBe("2026-09-01T10:00:00.000Z");
+  expect(by.r_done_iso.completed_at).toBe("2026-09-02T03:04:05.678Z");
+  // updated_at 读不懂 → 退到 created_at,而不是留空(留空的完成卡在仪表盘上就「没完成过」)
+  expect(by.r_done_bad_updated.completed_at).toBe("2026-08-03T00:00:00.000Z");
+  for (const id of ["r_done_sqlite_ts", "r_done_iso", "r_done_bad_updated"]) {
+    expect(by[id].completed_at_approx).toBe(1);
+    // 最后改的人不是「完成的人」:近似值不猜完成者
+    expect(by[id].completed_by_json).toBeNull();
+    // 补值不碰 updated_at
+    expect(by[id].updated_at).toBe(seed.find(s => s[0] === id)![3]);
+  }
+  for (const id of ["r_doing", "r_pool"]) expect([by[id].completed_at, by[id].completed_by_json, by[id].completed_at_approx]).toEqual([null, null, 0]);
+
+  // 下次启动:什么都不动
+  expect(ensureRequirementCompletedAt(db)).toEqual({ backfilled: 0, cleared: 0 });
+  expect(read(db)).toEqual(by);
+
+  // 回滚到旧 Hub 期间:旧 Hub 不认识这三列 —— 把一张完成的卡移出(列留着旧值)、把一张卡移进完成(列是空的)。
+  db.run("UPDATE requirements SET column_name = 'doing' WHERE requirement_id = 'r_done_iso'");
+  db.run("UPDATE requirements SET column_name = 'done', updated_at = '2026-09-06T00:00:00.000Z' WHERE requirement_id = 'r_pool'");
+  expect(ensureRequirementCompletedAt(db)).toEqual({ backfilled: 1, cleared: 1 });
+  const after = read(db);
+  expect([after.r_done_iso.completed_at, after.r_done_iso.completed_by_json, after.r_done_iso.completed_at_approx]).toEqual([null, null, 0]);
+  expect([after.r_pool.completed_at, after.r_pool.completed_at_approx]).toEqual(["2026-09-06T00:00:00.000Z", 1]);
+  expect(after.r_done_sqlite_ts).toEqual(by.r_done_sqlite_ts);
+  expect(ensureRequirementCompletedAt(db)).toEqual({ backfilled: 0, cleared: 0 });
+});

package/src/requirements-etag-http.test.ts

@@ -0,0 +1,91 @@
+// GET /api/requirements conditional requests: ETag on every list response, 304 with an empty body
+// when If-None-Match matches. The app polls the whole list every 15 s (production: 500 rows,
+// 708 KB / 163 KB gzip) and it is unchanged on almost every poll. Old clients never send
+// If-None-Match and keep getting the full 200.
+import { afterAll, beforeAll, describe, expect, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+const dir = mkdtempSync(join(tmpdir(), "anet-requirements-etag-"));
+process.env.COMMHUB_DB = join(dir, "hub.db");
+
+let server: { port: number; stop?: (force?: boolean) => void };
+let base = "";
+let ownerToken = "", network = "";
+
+const list = (token: string, headers: Record<string, string> = {}) =>
+  fetch(`${base}/api/requirements?network_id=${network}`, { headers: { Authorization: `Bearer ${token}`, ...headers } });
+
+beforeAll(async () => {
+  const { register } = await import("./auth.js");
+  const owner = register(`etag_owner_${Date.now()}`, "EtagOwnerPassw0rd!", undefined, "seed");
+  ownerToken = owner.token!; network = owner.network_id!;
+  const mod: any = await import("./server.js");
+  server = mod.bootServer({ port: 0, hostname: "127.0.0.1" });
+  base = `http://127.0.0.1:${server.port}`;
+  const created = await fetch(`${base}/api/requirements`, {
+    method: "POST",
+    headers: { Authorization: `Bearer ${ownerToken}`, "Content-Type": "application/json" },
+    body: JSON.stringify({ name: "etag card", network_id: network }),
+  });
+  expect(created.status).toBe(201);
+}, 30_000);
+
+afterAll(() => {
+  try { server?.stop?.(true); } catch {}
+  try { rmSync(dir, { recursive: true, force: true }); } catch {}
+});
+
+describe("GET /api/requirements conditional requests", () => {
+  test("a plain GET is the same 200 JSON as before, plus ETag and private/no-cache", async () => {
+    const res = await list(ownerToken);
+    expect(res.status).toBe(200);
+    expect(res.headers.get("content-type")).toBe("application/json;charset=utf-8");
+    expect(res.headers.get("etag")).toMatch(/^W\/"[A-Za-z0-9_-]{27}"$/);
+    expect(res.headers.get("cache-control")).toBe("private, no-cache");
+    const body = await res.json() as any;
+    expect(body.ok).toBe(true);
+    expect(body.requirements.map((r: any) => r.name)).toEqual(["etag card"]);
+    expect(Array.isArray(body.capabilities)).toBe(true);
+  });
+
+  test("If-None-Match with the current ETag → 304, empty body, same ETag", async () => {
+    const etag = (await list(ownerToken)).headers.get("etag")!;
+    const res = await list(ownerToken, { "If-None-Match": etag });
+    expect(res.status).toBe(304);
+    expect(res.headers.get("etag")).toBe(etag);
+    expect(await res.text()).toBe("");
+    // strong/weak spelling and lists are accepted
+    expect((await list(ownerToken, { "If-None-Match": etag.replace(/^W\//, "") })).status).toBe(304);
+    expect((await list(ownerToken, { "If-None-Match": `W/"stale", ${etag}` })).status).toBe(304);
+  });
+
+  test("304 survives gzip negotiation (not compressed, still empty)", async () => {
+    const etag = (await list(ownerToken, { "Accept-Encoding": "gzip" })).headers.get("etag")!;
+    const res = await list(ownerToken, { "If-None-Match": etag, "Accept-Encoding": "gzip" });
+    expect(res.status).toBe(304);
+    expect(res.headers.get("content-encoding")).toBeNull();
+  });
+
+  test("any change to the list changes the ETag → full 200 again", async () => {
+    const before = await list(ownerToken);
+    const etag = before.headers.get("etag")!;
+    const id = ((await before.json()) as any).requirements[0].id;
+    const patched = await fetch(`${base}/api/requirements/${id}?network_id=${network}`, {
+      method: "PATCH",
+      headers: { Authorization: `Bearer ${ownerToken}`, "Content-Type": "application/json" },
+      body: JSON.stringify({ name: "etag card renamed" }),
+    });
+    expect(patched.status).toBe(200);
+    const res = await list(ownerToken, { "If-None-Match": etag });
+    expect(res.status).toBe(200);
+    expect(res.headers.get("etag")).not.toBe(etag);
+    expect(((await res.json()) as any).requirements[0].name).toBe("etag card renamed");
+  });
+
+  test("a stale or foreign ETag never yields 304", async () => {
+    expect((await list(ownerToken, { "If-None-Match": 'W/"not-the-current-one"' })).status).toBe(200);
+    expect((await list(ownerToken, { "If-None-Match": "" })).status).toBe(200);
+  });
+});