@sleep2agi/commhub-server 0.9.0-preview.70 → 0.9.0-preview.72

package/README.md

@@ -150,9 +150,11 @@ delivered/acked/running → reassign → delivered (new agent)
 
 ## PostgreSQL (community extension point — not on the maintained roadmap)
 
+> **PostgreSQL support is still in development and does not work yet** (PostgreSQL 支持尚在开发中，目前不可用). With `DATABASE_URL=postgres://…` the hub builds its schema, but `startHub()` refuses to run on PostgreSQL unless you also set `COMMHUB_PG_EXPERIMENTAL=1` (experimental, for testing only: it switches on the scheduler, task runtime evidence and side-thread commands on PostgreSQL before their PostgreSQL tests exist; RFC-039 S4 removes the flag). Progress: [RFC-039](https://github.com/sleep2agi/agent-network/blob/main/docs/rfcs/RFC-039-hub-postgresql-backend.md).
+
 > v0.8+ product direction is **SQLite only** (see [docs/v3-postgresql-design.md banner](https://github.com/sleep2agi/agent-network/blob/main/docs/v3-postgresql-design.md)). The PostgreSQL adapter interface is preserved as a community extension point — no E2E coverage on the current stable line; **not recommended for mainline production**.
 
-Set `DATABASE_URL` to switch to PostgreSQL — the SQL layer auto-translates SQLite-isms (datetime, parameter placeholders) so application code is unchanged. Requires `bun add pg`.
+Design intent (not working today): setting `DATABASE_URL` switches to PostgreSQL, and the SQL layer translates SQLite-isms (datetime, parameter placeholders). Requires `bun add pg`.
 
 ```bash
 DATABASE_URL=postgres://user:pass@host:5432/commhub bunx @sleep2agi/commhub-server
@@ -166,7 +168,7 @@ DATABASE_URL=postgres://user:pass@host:5432/commhub bunx @sleep2agi/commhub-serv
 | `HOST` | `0.0.0.0` in the server package, `127.0.0.1` when launched by `anet hub start` | listen address |
 | `COMMHUB_AUTH_TOKEN` | (none) | Bearer token gate (legacy) |
 | `COMMHUB_DB` | `~/.commhub/commhub.db` | SQLite path |
-| `DATABASE_URL` | (none) | switches to PostgreSQL when set (unverified) |
+| `DATABASE_URL` | (none) | switches to PostgreSQL when set — **does not work yet**, see above |
 
 ## Running the unit tests
 
@@ -274,7 +276,7 @@ main 上 66 处写的是 `SOURCE_COMMIT`,另有若干写成 `TEST<编号>_SOURCE
 ## Not verified
 
 - `/api/license*` — experimental legacy trial/pro-license endpoints.
-- PostgreSQL backend — translation layer exists, no E2E run.
+- PostgreSQL backend — in development, does not work yet (the hub refuses to start on it without the experimental opt-in; RFC-039).
 - Telegram / WeChat / Feishu channel endpoints — channel code exists, but only Telegram-oriented agent-node paths are actively exercised.
 
 ## License

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sleep2agi/commhub-server",
-  "version": "0.9.0-preview.70",
+  "version": "0.9.0-preview.72",
   "description": "CommHub Server — AI Agent communication hub with MCP protocol, multi-network isolation, user auth, and MCP tools (17 collaboration-core + node/provider ops tools; authoritative list: docs-site/docs/api/mcp-tools.md).",
   "type": "module",
   "main": "src/index.ts",

package/src/admin-delete-network-http.test.ts

@@ -0,0 +1,228 @@
+// Hub 管理员删别人的**空**网络(清理旧测试账号留下的个人网络)。
+// 真 HTTP:走 DELETE /api/networks/:id,库和上传目录都是本文件私有的临时目录。
+//   bun test server/src/admin-delete-network-http.test.ts
+import { afterAll, beforeAll, describe, expect, test } from "bun:test";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+const PRIVATE_DIR = mkdtempSync(join(tmpdir(), "anet-admin-delete-network-"));
+process.env.COMMHUB_DB ||= join(PRIVATE_DIR, "hub.db");
+process.env.COMMHUB_UPLOADS_DIR = join(PRIVATE_DIR, "uploads");
+
+let server: ReturnType<typeof Bun.serve>;
+let base = "";
+let db: typeof import("./db.js").db;
+let auth: typeof import("./auth.js");
+let adminToken = "";
+let adminUserId = "";
+let adminNetworkId = "";
+let memberToken = "";
+let memberUserId = "";
+let memberNodeToken = "";
+const stamp = Date.now();
+
+function del(networkId: string, token: string) {
+  return fetch(`${base}/api/networks/${networkId}`, { method: "DELETE", headers: { Authorization: `Bearer ${token}` } });
+}
+
+function memberNetwork(name: string): string {
+  const created = auth.createNetwork(memberUserId, `${name}-${stamp}`);
+  expect(created.ok).toBe(true);
+  return created.network_id!;
+}
+
+function rowCount(table: string, networkId: string): number {
+  return db.get<{ cnt: number }>(`SELECT COUNT(*) AS cnt FROM ${table} WHERE network_id = ?1`, networkId)!.cnt;
+}
+
+// 同 admin-networks-http.test.ts:register() 跑 KDF + bootServer,给 30s 而不是 bun 默认 5s。
+beforeAll(async () => {
+  ({ db } = await import("./db.js"));
+  auth = await import("./auth.js");
+
+  // 第一个注册的是 Hub 管理员;第二个是普通用户,不在管理员的网络里。
+  const admin = auth.register(`admin_delnet_${stamp}`, "AdminDelNet-Strong-1!", undefined, "admin");
+  expect(admin.ok).toBe(true);
+  adminToken = admin.token!;
+  adminNetworkId = admin.network_id!;
+  adminUserId = db.get<{ user_id: string }>("SELECT user_id FROM users WHERE username = ?1", `admin_delnet_${stamp}`)!.user_id;
+
+  const member = auth.register(`member_delnet_${stamp}`, "MemberDelNet-Strong-1!", undefined, "member");
+  expect(member.ok).toBe(true);
+  memberToken = member.token!;
+  memberUserId = db.get<{ user_id: string }>("SELECT user_id FROM users WHERE username = ?1", `member_delnet_${stamp}`)!.user_id;
+  expect(db.get<{ role: string }>("SELECT role FROM users WHERE user_id = ?1", adminUserId)!.role).toBe("admin");
+  expect(db.get<{ role: string }>("SELECT role FROM users WHERE user_id = ?1", memberUserId)!.role).not.toBe("admin");
+  // free 档只能拥有 2 个网络;本文件要给它建七八个。plan 只影响配额,不影响任何权限判定。
+  db.run("UPDATE users SET plan = 'pro' WHERE user_id = ?1", [memberUserId]);
+
+  const minted = auth.createNetworkTokenForNode(memberUserId, member.network_id!, "delnet-node");
+  expect(minted.ok).toBe(true);
+  memberNodeToken = minted.token!;
+
+  const mod = await import("./server.js");
+  server = mod.bootServer({ port: 0, hostname: "127.0.0.1" });
+  base = `http://127.0.0.1:${server.port}`;
+}, 30_000);
+
+afterAll(() => {
+  try { server?.stop(true); } catch {}
+  try { rmSync(PRIVATE_DIR, { recursive: true, force: true }); } catch {}
+});
+
+describe("DELETE /api/networks/:id — hub admin override for empty foreign networks", () => {
+  test("admin deletes an empty foreign network: 200, network + members + scoped tokens gone, audit has admin_override", async () => {
+    const netId = memberNetwork("empty");
+    const minted = auth.createNetworkTokenForNode(memberUserId, netId, "leftover-node");
+    expect(minted.ok).toBe(true);
+    expect(rowCount("network_members", netId)).toBe(1);
+    expect(rowCount("api_tokens", netId)).toBe(1);
+
+    const res = await del(netId, adminToken);
+    const body = await res.json() as any;
+    expect(res.status).toBe(200);
+    expect(body.ok).toBe(true);
+    expect(body.admin_override).toBe(true);
+
+    expect(db.get("SELECT 1 AS x FROM networks WHERE network_id = ?1", netId)).toBeFalsy();
+    expect(rowCount("network_members", netId)).toBe(0);
+    expect(rowCount("api_tokens", netId)).toBe(0);
+    // 被删网络的节点令牌不再能解析。
+    expect(auth.resolveToken(minted.token!)).toBeFalsy();
+
+    const audit = db.get<{ user_id: string; detail: string; network_id: string }>(
+      "SELECT user_id, detail, network_id FROM audit_log WHERE action = 'network_deleted' AND target_id = ?1", netId);
+    expect(audit).toBeTruthy();
+    expect(audit!.user_id).toBe(adminUserId);
+    const detail = JSON.parse(audit!.detail);
+    expect(detail.admin_override).toBe(true);
+    expect(detail.owner_id).toBe(memberUserId);
+  });
+
+  test("admin is refused with 409 and counts when the network has a node and a session", async () => {
+    const netId = memberNetwork("busy");
+    db.run("INSERT INTO nodes (node_id, node_name, alias, network_id, created_at, updated_at) VALUES (?1, ?2, ?2, ?3, datetime('now'), datetime('now'))",
+      [`node-${stamp}`, `busy-node-${stamp}`, netId]);
+    db.run("INSERT INTO sessions (resume_id, alias, network_id) VALUES (?1, ?2, ?3)", [`resume-${stamp}`, `busy-node-${stamp}`, netId]);
+
+    const res = await del(netId, adminToken);
+    const body = await res.json() as any;
+    expect(res.status).toBe(409);
+    expect(body.ok).toBe(false);
+    expect(body.counts).toEqual({ nodes: 1, sessions: 1 });
+    expect(body.error).toContain("nodes=1");
+    expect(db.get("SELECT 1 AS x FROM networks WHERE network_id = ?1", netId)).toBeTruthy();
+    expect(rowCount("network_members", netId)).toBe(1);
+  });
+
+  test("admin is refused when the only content left is an uploaded file (disk index, not the DB)", async () => {
+    const netId = memberNetwork("files");
+    const indexDir = join(process.env.COMMHUB_UPLOADS_DIR!, ".index");
+    mkdirSync(indexDir, { recursive: true });
+    writeFileSync(join(indexDir, `f${stamp}.json`), JSON.stringify({ file_id: `f${stamp}`, network_id: netId }));
+
+    const res = await del(netId, adminToken);
+    const body = await res.json() as any;
+    expect(res.status).toBe(409);
+    expect(body.counts).toEqual({ files: 1 });
+    expect(db.get("SELECT 1 AS x FROM networks WHERE network_id = ?1", netId)).toBeTruthy();
+  });
+
+  test("admin cannot delete the 'default' network even when it is empty", async () => {
+    db.run("INSERT INTO networks (network_id, network_name, owner_id) VALUES ('default', ?1, ?2)", [`legacy-default-${stamp}`, memberUserId]);
+    const res = await del("default", adminToken);
+    expect(res.status).toBe(409);
+    expect(((await res.json()) as any).error).toContain("default");
+    expect(db.get("SELECT 1 AS x FROM networks WHERE network_id = 'default'")).toBeTruthy();
+  });
+
+  test("a non-admin user cannot delete someone else's network", async () => {
+    const res = await del(adminNetworkId, memberToken);
+    expect(res.status).toBe(400);
+    expect(((await res.json()) as any).error).toBe("not your network");
+    expect(db.get("SELECT 1 AS x FROM networks WHERE network_id = ?1", adminNetworkId)).toBeTruthy();
+  });
+
+  test("a node token is refused with user_token_required", async () => {
+    const netId = memberNetwork("ntok");
+    const res = await del(netId, memberNodeToken);
+    expect(res.status).toBe(403);
+    expect(((await res.json()) as any).error).toBe("user_token_required");
+    expect(db.get("SELECT 1 AS x FROM networks WHERE network_id = ?1", netId)).toBeTruthy();
+  });
+
+  test("owner path is unchanged: owner deletes own network (even with a node row), sessions still block it", async () => {
+    const withNode = memberNetwork("owner-node");
+    db.run("INSERT INTO nodes (node_id, node_name, alias, network_id, created_at, updated_at) VALUES (?1, ?2, ?2, ?3, datetime('now'), datetime('now'))",
+      [`owner-node-${stamp}`, `owner-node-${stamp}`, withNode]);
+    const ok = await del(withNode, memberToken);
+    expect(ok.status).toBe(200);
+    expect(await ok.json()).toEqual({ ok: true });
+
+    const withSession = memberNetwork("owner-session");
+    db.run("INSERT INTO sessions (resume_id, alias, network_id) VALUES (?1, ?2, ?3)", [`owner-resume-${stamp}`, `owner-s-${stamp}`, withSession]);
+    const blocked = await del(withSession, memberToken);
+    expect(blocked.status).toBe(400);
+    expect(((await blocked.json()) as any).error).toContain("active session");
+  });
+
+  test("admin deleting its OWN network goes through the owner path (no admin_override)", async () => {
+    const created = auth.createNetwork(adminUserId, `admin-own-${stamp}`);
+    expect(created.ok).toBe(true);
+    const res = await del(created.network_id!, adminToken);
+    expect(res.status).toBe(200);
+    expect(await res.json()).toEqual({ ok: true });
+  });
+
+  // #2144 —— Agent 分组(#2131)的三张表。
+  function addGroup(netId: string, tag: string): string {
+    const groupId = `grp-${tag}-${stamp}`;
+    db.run("INSERT INTO agent_groups (group_id, network_id, name) VALUES (?1, ?2, ?3)", [groupId, netId, `g-${tag}`]);
+    db.run("INSERT INTO agent_group_members (group_id, node_id) VALUES (?1, ?2)", [groupId, `node-${tag}-${stamp}`]);
+    db.run("INSERT INTO network_member_group_grants (network_id, user_id, group_id) VALUES (?1, ?2, ?3)", [netId, memberUserId, groupId]);
+    return groupId;
+  }
+  function groupRows(netId: string, groupId: string) {
+    return {
+      agent_groups: rowCount("agent_groups", netId),
+      agent_group_members: db.get<{ cnt: number }>("SELECT COUNT(*) AS cnt FROM agent_group_members WHERE group_id = ?1", groupId)!.cnt,
+      network_member_group_grants: rowCount("network_member_group_grants", netId),
+    };
+  }
+
+  test("#2144 admin is refused with 409 counts.agent_groups when the network has an agent group", async () => {
+    const netId = memberNetwork("grouped");
+    const groupId = addGroup(netId, "admin-blocked");
+    const res = await del(netId, adminToken);
+    const body = await res.json() as any;
+    expect(res.status).toBe(409);
+    expect(body.counts).toEqual({ agent_groups: 1 });
+    expect(db.get("SELECT 1 AS x FROM networks WHERE network_id = ?1", netId)).toBeTruthy();
+    expect(groupRows(netId, groupId)).toEqual({ agent_groups: 1, agent_group_members: 1, network_member_group_grants: 1 });
+  });
+
+  test("#2144 admin delete of an otherwise-empty network cleans orphan group grants", async () => {
+    const netId = memberNetwork("orphan-grant");
+    db.run("INSERT INTO network_member_group_grants (network_id, user_id, group_id) VALUES (?1, ?2, ?3)", [netId, memberUserId, `grp-gone-${stamp}`]);
+    const res = await del(netId, adminToken);
+    const body = await res.json() as any;
+    expect(res.status).toBe(200);
+    expect(body.cleaned.network_member_group_grants).toBe(1);
+    expect(rowCount("network_member_group_grants", netId)).toBe(0);
+  });
+
+  test("#2144 owner delete removes the network's groups, group members and group grants, and leaves other networks' groups", async () => {
+    const netId = memberNetwork("owner-grouped");
+    const groupId = addGroup(netId, "owner");
+    const otherNet = memberNetwork("owner-grouped-other");
+    const otherGroup = addGroup(otherNet, "other");
+
+    const res = await del(netId, memberToken);
+    expect(res.status).toBe(200);
+    expect(await res.json()).toEqual({ ok: true });
+    expect(db.get("SELECT 1 AS x FROM networks WHERE network_id = ?1", netId)).toBeFalsy();
+    expect(groupRows(netId, groupId)).toEqual({ agent_groups: 0, agent_group_members: 0, network_member_group_grants: 0 });
+    expect(groupRows(otherNet, otherGroup)).toEqual({ agent_groups: 1, agent_group_members: 1, network_member_group_grants: 1 });
+  });
+});

package/src/agent-access-batch.test.ts

@@ -0,0 +1,210 @@
+// visibleAgents() batched into one query. The old implementation (kept here verbatim as the
+// reference) ran one nodes ∪ sessions lookup per node_id grant — ~300 queries per call for a
+// restricted member with 300 grants, on every restricted /api/status poll. The new one must return
+// IDENTICAL output (same members, same order) on randomized fixtures.
+
+import { afterAll, beforeAll, describe, expect, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+const dir = mkdtempSync(join(tmpdir(), "anet-agent-access-batch-"));
+process.env.COMMHUB_DB = join(dir, "hub.db");
+
+let db: any;
+let visibleAgents: (userId: string, networkId: string) => any;
+let listAgentGrants: (networkId: string, userId: string) => any[];
+let CHUNK = 0;
+
+function visibleAgentsReference(userId: string, networkId: string) {
+  const aliases = new Set<string>();
+  const nodeIds = new Set<string>();
+  const messageAliases = new Set<string>();
+  const messageNodeIds = new Set<string>();
+  // Group grants (#2131) expanded exactly as agent-access.ts groupGrantNodes() does, appended after
+  // the direct grants — the order the old loop saw them in.
+  const groupNodes = db.all(
+    `SELECT m.node_id, g.can_message
+       FROM network_member_group_grants g
+       JOIN agent_groups ag ON ag.group_id = g.group_id AND ag.network_id = g.network_id
+       JOIN agent_group_members m ON m.group_id = g.group_id
+       JOIN nodes n ON n.node_id = m.node_id AND n.network_id = g.network_id
+      WHERE g.network_id = ?1 AND g.user_id = ?2`,
+    networkId, userId,
+  ).map((row: any) => ({ node_id: row.node_id, alias: null, can_message: row.can_message === 1 }));
+  for (const grant of [...listAgentGrants(networkId, userId), ...groupNodes]) {
+    const grantAliases: string[] = [];
+    if (grant.node_id) {
+      nodeIds.add(grant.node_id);
+      if (grant.can_message) messageNodeIds.add(grant.node_id);
+      for (const row of db.all(
+        `SELECT alias FROM nodes WHERE node_id = ?1 AND network_id = ?2
+         UNION SELECT alias FROM sessions WHERE node_id = ?1 AND network_id = ?2`,
+        grant.node_id, networkId,
+      )) {
+        if (row.alias) grantAliases.push(row.alias);
+      }
+    } else if (grant.alias) {
+      grantAliases.push(grant.alias);
+    }
+    for (const alias of grantAliases) {
+      aliases.add(alias);
+      if (grant.can_message) messageAliases.add(alias);
+    }
+  }
+  return { aliases: [...aliases], nodeIds: [...nodeIds], messageAliases: [...messageAliases], messageNodeIds: [...messageNodeIds] };
+}
+
+// Deterministic PRNG so a failure is reproducible from the printed seed.
+function rng(seed: number) {
+  let s = seed >>> 0;
+  return () => { s = (s * 1664525 + 1013904223) >>> 0; return s / 2 ** 32; };
+}
+
+let seq = 0;
+function seedFixture(seed: number, opts: { nodes: number; grants: number; groups?: number }) {
+  const r = rng(seed);
+  const pick = <T,>(xs: T[]) => xs[Math.floor(r() * xs.length)];
+  const tag = `s${seed}_${seq++}`;
+  db.exec("BEGIN");
+  const net = `net_${tag}`, other = `net_${tag}_other`, user = `u_${tag}`;
+  db.run(`INSERT INTO users (user_id, username, password_hash) VALUES (?1, ?1, 'x')`, [user]);
+  const nodeIds: string[] = [];
+  const legacyAliases: string[] = [];
+  for (let i = 0; i < opts.nodes; i++) {
+    const nodeId = `node_${tag}_${i}`;
+    nodeIds.push(nodeId);
+    const alias = `agent-${tag}-${i}`;
+    const shape = r();
+    // nodes row (sometimes missing, sometimes NULL alias)
+    if (shape > 0.1) db.run(`INSERT INTO nodes (node_id, node_name, alias, network_id) VALUES (?1, ?2, ?3, ?4)`, [nodeId, alias, shape > 0.15 ? alias : null, net]);
+    // sessions rows: same alias, a renamed alias (rename window), several, or none
+    const sessions = r() < 0.2 ? 0 : 1 + Math.floor(r() * 3);
+    for (let k = 0; k < sessions; k++) {
+      const sAlias = k === 0 && r() < 0.6 ? alias : `${alias}-renamed-${k}`;
+      db.run(`INSERT INTO sessions (resume_id, alias, node_id, status, network_id) VALUES (?1, ?2, ?3, 'idle', ?4)`, [`r_${tag}_${i}_${k}`, sAlias, nodeId, net]);
+    }
+    // same node_id in another network must never leak in
+    if (r() < 0.3) db.run(`INSERT INTO sessions (resume_id, alias, node_id, status, network_id) VALUES (?1, ?2, ?3, 'idle', ?4)`, [`r_${tag}_${i}_x`, `${alias}-elsewhere`, nodeId, other]);
+  }
+  for (let i = 0; i < Math.ceil(opts.nodes / 5); i++) {
+    const alias = `legacy-${tag}-${i}`;
+    legacyAliases.push(alias);
+    db.run(`INSERT INTO sessions (resume_id, alias, status, network_id) VALUES (?1, ?2, 'idle', ?3)`, [`rl_${tag}_${i}`, alias, net]);
+  }
+  const usedAliases = new Set<string>();
+  // distinct nodes in a shuffled order (the grant table has one row per node per member)
+  const order = nodeIds.map(n => [r(), n] as const).sort((a, b) => a[0] - b[0]).map(([, n]) => n);
+  for (let i = 0; i < opts.grants; i++) {
+    const byNode = r() < 0.8;
+    const can = r() < 0.5 ? 1 : 0;
+    if (byNode) {
+      const nodeId = r() < 0.05 ? `node_${tag}_ghost_${i}` : order.pop();
+      if (!nodeId) continue;
+      db.run(`INSERT INTO network_member_agent_grants (network_id, user_id, node_id, alias, can_message) VALUES (?1, ?2, ?3, NULL, ?4)`, [net, user, nodeId, can]);
+    } else {
+      const alias = pick(legacyAliases);
+      if (usedAliases.has(alias)) continue;
+      usedAliases.add(alias);
+      db.run(`INSERT INTO network_member_agent_grants (network_id, user_id, node_id, alias, can_message) VALUES (?1, ?2, NULL, ?3, ?4)`, [net, user, alias, can]);
+    }
+  }
+  // Groups (#2131): some granted, some not; members include nodes also granted directly (with a
+  // different can_message), ghost nodes with no nodes row, and a node that lives in another network.
+  const groups = opts.groups ?? 0;
+  for (let gi = 0; gi < groups; gi++) {
+    const groupId = `grp_${tag}_${gi}`;
+    const groupNet = r() < 0.1 ? other : net;
+    db.run(`INSERT INTO agent_groups (group_id, network_id, name) VALUES (?1, ?2, ?3)`, [groupId, groupNet, `group ${tag} ${gi}`]);
+    const size = 1 + Math.floor(r() * 8);
+    const members = new Set<string>();
+    for (let k = 0; k < size; k++) members.add(r() < 0.05 ? `node_${tag}_ghostmember_${gi}_${k}` : pick(nodeIds));
+    if (r() < 0.2) {
+      const foreign = `node_${tag}_foreign_${gi}`;
+      db.run(`INSERT INTO nodes (node_id, node_name, alias, network_id) VALUES (?1, ?1, ?2, ?3)`, [foreign, `foreign-${tag}-${gi}`, other]);
+      members.add(foreign);
+    }
+    for (const m of members) db.run(`INSERT INTO agent_group_members (group_id, node_id) VALUES (?1, ?2)`, [groupId, m]);
+    if (r() < 0.7) db.run(`INSERT INTO network_member_group_grants (network_id, user_id, group_id, can_message) VALUES (?1, ?2, ?3, ?4)`, [net, user, groupId, r() < 0.5 ? 1 : 0]);
+  }
+  db.exec("COMMIT");
+  return { net, user };
+}
+
+beforeAll(async () => {
+  ({ db } = await import("./db.js"));
+  ({ visibleAgents, listAgentGrants, VISIBLE_AGENTS_CHUNK: CHUNK } = await import("./agent-access.js") as any);
+});
+
+afterAll(() => {
+  try { rmSync(dir, { recursive: true, force: true }); } catch {}
+});
+
+describe("visibleAgents batched = reference, on randomized fixtures", () => {
+  test("200 random fixtures: identical output (members and order)", () => {
+    for (let seed = 1; seed <= 200; seed++) {
+      const { net, user } = seedFixture(seed, { nodes: 5 + (seed % 40), grants: seed % 7 === 0 ? 0 : 3 + (seed % 50), groups: seed % 3 === 0 ? 0 : 1 + (seed % 12) });
+      const got = visibleAgents(user, net);
+      const want = visibleAgentsReference(user, net);
+      if (JSON.stringify(got) !== JSON.stringify(want)) {
+        throw new Error(`seed ${seed} differs:\nnew ${JSON.stringify(got)}\nold ${JSON.stringify(want)}`);
+      }
+    }
+  }, 120_000);
+
+  test("the fixtures exercise every shape (rename window, NULL alias, ghost node, legacy alias, other network, groups)", () => {
+    const { net, user } = seedFixture(4242, { nodes: 60, grants: 80, groups: 15 });
+    const groupNodes = db.get<{ n: number }>("SELECT COUNT(*) AS n FROM network_member_group_grants WHERE network_id = ?1 AND user_id = ?2", net, user)!.n;
+    expect(groupNodes).toBeGreaterThan(0);
+    const got = visibleAgents(user, net);
+    expect(got.aliases.some((a: string) => a.includes("-renamed-"))).toBe(true);
+    expect(got.aliases.some((a: string) => a.startsWith("legacy-"))).toBe(true);
+    expect(got.aliases.some((a: string) => a.endsWith("-elsewhere"))).toBe(false);
+    expect(got.messageAliases.length).toBeLessThan(got.aliases.length);
+    expect(JSON.stringify(got)).toBe(JSON.stringify(visibleAgentsReference(user, net)));
+  });
+
+  test("groups only (no direct grants): identical output, group nodes visible", () => {
+    const { net, user } = seedFixture(9090, { nodes: 80, grants: 0, groups: 25 });
+    const got = visibleAgents(user, net);
+    expect(got.nodeIds.length).toBeGreaterThan(0);
+    expect(JSON.stringify(got)).toBe(JSON.stringify(visibleAgentsReference(user, net)));
+  });
+
+  test("no grants → all empty; unknown user → all empty", () => {
+    const { net } = seedFixture(7, { nodes: 10, grants: 0 });
+    expect(visibleAgents("nobody", net)).toEqual({ aliases: [], nodeIds: [], messageAliases: [], messageNodeIds: [] });
+  });
+
+  test("query-count guard: a fixed number of queries per call, not one per grant (#2133)", () => {
+    const { net, user } = seedFixture(301, { nodes: 400, grants: 420, groups: 30 });
+    const grants = listAgentGrants(net, user).length;
+    expect(grants).toBeGreaterThanOrEqual(300);
+    const calls = { all: 0, get: 0 };
+    const all = db.all.bind(db), get = db.get.bind(db);
+    db.all = (...a: any[]) => { calls.all++; return all(...a); };
+    db.get = (...a: any[]) => { calls.get++; return get(...a); };
+    try { visibleAgents(user, net); } finally { db.all = all; db.get = get; }
+    // direct grants + group grants + ceil(nodes / chunk) alias reads
+    expect(calls.all + calls.get).toBeLessThanOrEqual(2 + Math.ceil(grants / CHUNK));
+    expect(calls.all + calls.get).toBeLessThanOrEqual(3);
+  }, 60_000);
+
+  test("more granted nodes than one chunk: same output across the chunk boundary", () => {
+    const { net, user } = seedFixture(777, { nodes: CHUNK + 120, grants: CHUNK + 200 });
+    expect(listAgentGrants(net, user).filter((g: any) => g.node_id).length).toBeGreaterThan(CHUNK);
+    expect(JSON.stringify(visibleAgents(user, net))).toBe(JSON.stringify(visibleAgentsReference(user, net)));
+  }, 120_000);
+
+  test("timing at 300 grants (printed; new must be faster)", () => {
+    const { net, user } = seedFixture(300, { nodes: 400, grants: 420 });
+    const grants = listAgentGrants(net, user).length;
+    expect(grants).toBeGreaterThanOrEqual(300);
+    const time = (fn: () => unknown, n = 50) => { fn(); const t0 = performance.now(); for (let i = 0; i < n; i++) fn(); return (performance.now() - t0) / n; };
+    const oldMs = time(() => visibleAgentsReference(user, net));
+    const newMs = time(() => visibleAgents(user, net));
+    console.log(`visibleAgents @ ${grants} grants: old ${oldMs.toFixed(2)} ms/call, new ${newMs.toFixed(2)} ms/call (${(oldMs / newMs).toFixed(1)}x)`);
+    expect(JSON.stringify(visibleAgents(user, net))).toBe(JSON.stringify(visibleAgentsReference(user, net)));
+    expect(newMs).toBeLessThan(oldMs);
+  }, 120_000);
+});