@sleep2agi/commhub-server 0.9.0-preview.37 → 0.9.0-preview.38

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sleep2agi/commhub-server",
-  "version": "0.9.0-preview.37",
+  "version": "0.9.0-preview.38",
   "description": "CommHub Server — AI Agent communication hub with MCP protocol, multi-network isolation, user auth, and MCP tools (17 collaboration-core + node/provider ops tools; authoritative list: docs-site/docs/api/mcp-tools.md).",
   "type": "module",
   "main": "src/index.ts",

package/src/create-node.ts

@@ -306,6 +306,7 @@ export function auditCreateNodeStrict(input: {
 export function auditCreateNode(input: {
   action:
     | "create_node_dispatched"
+    | "create_node_dispatch_attempted"
     | "create_node_rejected"
     | "create_node_succeeded"
     | "create_node_sweeper_revoked"

package/src/stop-delete-node.test.ts

@@ -36,6 +36,7 @@ interface Reply { ok?: boolean; error?: string; [k: string]: unknown; }
 function cleanup() {
   for (const n of [NET_A, NET_B]) {
     try { db.run("DELETE FROM node_stop_requests WHERE network_id = ?1", [n]); } catch {}
+    try { db.run("DELETE FROM node_create_requests WHERE network_id = ?1", [n]); } catch {}
     try { db.run("DELETE FROM audit_log WHERE network_id = ?1", [n]); } catch {}
     try { db.run("DELETE FROM inbox WHERE network_id = ?1", [n]); } catch {}
     // PR1.2a restart_node tests leave node_config_updates rows; clear
@@ -676,6 +677,60 @@ describe("list_my_children HANDLER (RFC-027 PR1.1)", () => {
   });
 });
 
+describe("create_node audit wording (#1362)", () => {
+  test("create_node records a dispatch attempt, not guaranteed SSE delivery", async () => {
+    setupAlphaNetwork();
+    const tools = buildHandlers(USER_A_ID);
+    const r = await call(tools.create_node, {
+      daemon_node_id: DAEMON_A_ID,
+      node_spec: {
+        name: "sd-new-child",
+        runtime: "claude-agent-sdk",
+        model: "x",
+      },
+      network_id: NET_A,
+    });
+
+    expect(r.ok).toBe(true);
+    expect(typeof r.request_id).toBe("string");
+    expect(readAudit("create_node_dispatch_attempted", NET_A).length).toBe(1);
+    expect(readAudit("create_node_dispatched", NET_A).length).toBe(0);
+  });
+});
+
+describe("list_my_pending_create_requests HANDLER (#1362 SSE reconnect compensation)", () => {
+  test("daemon-bound caller gets only its own pending create requests", async () => {
+    setupAlphaNetwork();
+    const otherDaemonId = "node_sd_daemon_other";
+    seedDaemon(NET_A, otherDaemonId, "sd-daemon-other", USER_A_ID, "tok_sd_daemon_other");
+    db.run(
+      `INSERT INTO node_create_requests
+         (request_id, daemon_node_id, child_name, network_id, runtime, model, flags_json, env_keys, status, child_token_id, created_at, created_by_token)
+       VALUES
+         ('cr_pending_mine', ?1, 'child-pending-mine', ?2, 'claude-agent-sdk', 'x', '{}', '[]', 'pending', NULL, ?3, 'tok_test'),
+         ('cr_delivered_mine', ?1, 'child-delivered-mine', ?2, 'claude-agent-sdk', 'x', '{}', '[]', 'delivered', NULL, ?4, 'tok_test'),
+         ('cr_pending_other', ?5, 'child-pending-other', ?2, 'claude-agent-sdk', 'x', '{}', '[]', 'pending', NULL, ?6, 'tok_test')`,
+      [DAEMON_A_ID, NET_A, Date.now(), Date.now() + 1, otherDaemonId, Date.now() + 2],
+    );
+
+    const daemonTools = buildHandlers(USER_A_ID, true, DAEMON_A_TOK, NET_A);
+    const r = await call(daemonTools.list_my_pending_create_requests, {});
+
+    expect(r.ok).toBe(true);
+    expect(r.count).toBe(1);
+    expect(r.requests).toEqual([
+      expect.objectContaining({ request_id: "cr_pending_mine", child_name: "child-pending-mine" }),
+    ]);
+  });
+
+  test("non-daemon caller (utok) refused", async () => {
+    setupAlphaNetwork();
+    const userTools = buildHandlers(USER_A_ID);
+    const r = await call(userTools.list_my_pending_create_requests, {});
+    expect(r.ok).toBe(false);
+  });
+});
+
 // ─── PR1.2a — restart_node resets lifecycle_state ──────────────────
 //
 // 通信龙 #346 ack latent: without this, a stopped node restart-ed via

package/src/tools.ts

@@ -3215,9 +3215,10 @@ export function registerTools(server: McpServer, clientIP?: string, enforceNetwo
       // SSE handler resolves the rest via MCP call.
       pushEvent(daemon.alias, { type: "create_node", request_id: requestId }, networkIdForChild);
 
-      // §4.5 audit — dispatch succeeded
+      // §4.5 audit — request queued and doorbell attempted. pushEvent is
+      // fire-and-forget, so actual SSE delivery is intentionally not claimed.
       auditCreateNode({
-        action: "create_node_dispatched",
+        action: "create_node_dispatch_attempted",
         user_id: enforceUserId,
         network_id: networkIdForChild,
         target_id: requestId,
@@ -3237,6 +3238,31 @@ export function registerTools(server: McpServer, clientIP?: string, enforceNetwo
     },
   );
 
+  // #1362 — daemon-side compensation for missed SSE doorbells. pushEvent is
+  // intentionally best-effort; after a daemon connects or reconnects, it pulls
+  // any still-pending requests bound to its own daemon token.
+  server.tool(
+    "list_my_pending_create_requests",
+    "Daemon lists pending create-node requests bound to itself for SSE reconnect compensation. RFC-026/#1362.",
+    {},
+    async () => {
+      const callerDaemon = resolveCallerDaemonTokenBound();
+      if (!callerDaemon.ok) {
+        return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: callerDaemon.error }) }] };
+      }
+      const rows = db.all<{ request_id: string; child_name: string; created_at: number }>(
+        `SELECT request_id, child_name, created_at
+           FROM node_create_requests
+          WHERE daemon_node_id = ?1
+            AND network_id = ?2
+            AND status = 'pending'
+          ORDER BY created_at ASC`,
+        callerDaemon.daemonNodeId, callerDaemon.networkId,
+      );
+      return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, count: rows.length, requests: rows }) }] };
+    },
+  );
+
   // §2.5 step 3 — daemon-facing pull. Returns full spec + env_blob +
   // child_ntok in one shot. Map evicted on take (one-shot consume).
   //