@sleep2agi/commhub-server 0.9.0-preview.28 → 0.9.0-preview.280

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (479) hide show
  1. package/README.md +120 -3
  2. package/bin/commhub.ts +93 -9
  3. package/build-info.json +7 -0
  4. package/package.json +10 -8
  5. package/src/ack-create-request-transport.test.ts +182 -0
  6. package/src/ack-create-request.test.ts +52 -8
  7. package/src/admin-delete-network-http.test.ts +229 -0
  8. package/src/admin-networks-http.test.ts +88 -0
  9. package/src/adoption-candidates-http.test.ts +140 -0
  10. package/src/adoption-candidates.ts +158 -0
  11. package/src/agent-access-batch.test.ts +215 -0
  12. package/src/agent-access.ts +585 -0
  13. package/src/agent-acl-groups-http.test.ts +247 -0
  14. package/src/agent-acl-http.test.ts +691 -0
  15. package/src/agent-acl-slice3-http.test.ts +888 -0
  16. package/src/agent-department-grants.test.ts +129 -0
  17. package/src/agent-department-http.test.ts +215 -0
  18. package/src/agent-groups-perf.test.ts +228 -0
  19. package/src/agent-notice.ts +48 -0
  20. package/src/agent-team-whoami-http.test.ts +98 -0
  21. package/src/agent-teams-http.test.ts +330 -0
  22. package/src/agent-teams.ts +244 -0
  23. package/src/alias-baseline-2571.test.ts +162 -0
  24. package/src/alias-baseline.ts +113 -0
  25. package/src/alias-filter.test.ts +72 -0
  26. package/src/alias-filter.ts +42 -0
  27. package/src/all-status-cache.test.ts +31 -0
  28. package/src/all-status-cache.ts +37 -0
  29. package/src/anet-variant-real-daemon-http.test.ts +184 -0
  30. package/src/api-host-supervisors-can-create-nodes.test.ts +350 -0
  31. package/src/api-host-supervisors-fallback.test.ts +6 -7
  32. package/src/api-host-supervisors-runtime-readiness.test.ts +195 -0
  33. package/src/api-nodes-shape.test.ts +131 -4
  34. package/src/auth-abuse-counters.test.ts +144 -0
  35. package/src/auth-abuse-counters.ts +122 -0
  36. package/src/auth-layer-shape.test.ts +105 -0
  37. package/src/auth-password-change-cli-tokens-http.test.ts +423 -0
  38. package/src/auth-sessions-http.test.ts +260 -0
  39. package/src/auth-validate.test.ts +5 -1
  40. package/src/auth-weak-password-login.test.ts +176 -0
  41. package/src/auth.ts +641 -68
  42. package/src/backfill-node-ids-2664.test.ts +128 -0
  43. package/src/binding-generation-http.test.ts +141 -0
  44. package/src/blocked-exit-on-reply.test.ts +122 -0
  45. package/src/broadcast-fanout-2721.test.ts +149 -0
  46. package/src/broadcast-fanout.ts +117 -0
  47. package/src/build-commit-report-http.test.ts +218 -0
  48. package/src/build-info.test.ts +60 -0
  49. package/src/build-info.ts +85 -0
  50. package/src/chain-attempt-dedup.test.ts +447 -0
  51. package/src/clip.test.ts +36 -0
  52. package/src/clip.ts +48 -0
  53. package/src/clone-node.test.ts +269 -0
  54. package/src/clone-node.ts +289 -0
  55. package/src/codex-config-flags.ts +77 -0
  56. package/src/codex-fork-contract.ts +23 -0
  57. package/src/codex-fork-migration.test.ts +38 -0
  58. package/src/commhub-bin-args.test.ts +85 -0
  59. package/src/config-apply-sec1.test.ts +37 -0
  60. package/src/config-apply-validate.test.ts +188 -1
  61. package/src/config-apply-validate.ts +226 -3
  62. package/src/contracts/session-project-create.ts +14 -0
  63. package/src/contracts/session-source-delivery.ts +16 -0
  64. package/src/contracts/session-source-directory.ts +54 -0
  65. package/src/contracts/session-source-evidence.ts +72 -0
  66. package/src/contracts/session-source-execution.ts +24 -0
  67. package/src/contracts/session-source-transport.ts +18 -0
  68. package/src/cors-origins.test.ts +73 -0
  69. package/src/create-node-blocked-gate.test.ts +365 -0
  70. package/src/create-node-error-domain.test.ts +127 -0
  71. package/src/create-node-network-id.test.ts +91 -0
  72. package/src/create-node-tool-schema.test.ts +59 -0
  73. package/src/create-node-unicode-name.test.ts +126 -0
  74. package/src/create-node-validate.test.ts +199 -7
  75. package/src/create-node-validate.ts +232 -15
  76. package/src/create-node-workdir.test.ts +298 -0
  77. package/src/create-node.ts +88 -23
  78. package/src/daemon-provider-snapshots.test.ts +453 -0
  79. package/src/daemon-provider-snapshots.ts +327 -0
  80. package/src/daemon-token-owner-http.test.ts +346 -0
  81. package/src/dashboard-slash-routing-http.test.ts +109 -0
  82. package/src/db-adapter-guard.test.ts +148 -0
  83. package/src/db-adapter-translate.test.ts +128 -0
  84. package/src/db-adapter.ts +377 -91
  85. package/src/db-timestamp.test.ts +38 -0
  86. package/src/db-timestamp.ts +15 -0
  87. package/src/db.ts +1334 -154
  88. package/src/delivered-without-push.test.ts +140 -0
  89. package/src/department-groups-http.test.ts +209 -0
  90. package/src/department-groups-sync-http.test.ts +328 -0
  91. package/src/department-groups.ts +434 -0
  92. package/src/department-heads-http.test.ts +350 -0
  93. package/src/department-heads.ts +226 -0
  94. package/src/departments-agent-count.test.ts +139 -0
  95. package/src/departments-http.test.ts +185 -0
  96. package/src/departments-mcp-error-domain.test.ts +135 -0
  97. package/src/departments-mcp.test.ts +128 -0
  98. package/src/departments.ts +318 -0
  99. package/src/desktop-message-seam.test.ts +150 -0
  100. package/src/desktop-message.test.ts +368 -0
  101. package/src/dm-file-scope-http.test.ts +227 -0
  102. package/src/empty-node-sweeper.test.ts +104 -0
  103. package/src/empty-node-sweeper.ts +88 -0
  104. package/src/env-transport-gate-http.test.ts +240 -0
  105. package/src/env-transport-gate.ts +80 -0
  106. package/src/env-transport-policy.ts +56 -0
  107. package/src/etag-of.test.ts +57 -0
  108. package/src/event-loop-lag.test.ts +180 -0
  109. package/src/event-loop-lag.ts +201 -0
  110. package/src/expiry-counters.test.ts +187 -0
  111. package/src/expiry-counters.ts +227 -0
  112. package/src/expiry-evidence-db.test.ts +103 -0
  113. package/src/ext-token-shared.test.ts +60 -0
  114. package/src/ext-validation-regression.test.ts +10 -17
  115. package/src/external-schedule-edits-http.test.ts +321 -0
  116. package/src/external-schedule-edits-timestamps.test.ts +64 -0
  117. package/src/external-schedule-edits.ts +327 -0
  118. package/src/file-download-authz-dev-open.test.ts +1 -1
  119. package/src/file-download-authz.test.ts +25 -4
  120. package/src/file-download-date-bucket.test.ts +1 -1
  121. package/src/file-network-scope-dev-open.test.ts +1 -1
  122. package/src/file-network-scope.test.ts +7 -6
  123. package/src/group-membership-events-http.test.ts +264 -0
  124. package/src/group-messages-http.test.ts +483 -0
  125. package/src/group-messages.ts +297 -0
  126. package/src/health-anon-readers.ts +67 -0
  127. package/src/health-host-disk-2756.test.ts +71 -0
  128. package/src/health-identity-root.test.ts +98 -0
  129. package/src/health-redaction.test.ts +1599 -7
  130. package/src/health-status-reasons.test.ts +84 -0
  131. package/src/host-supervisor-identity-http.test.ts +152 -0
  132. package/src/host-supervisor-identity.ts +92 -0
  133. package/src/host-supervisors-daemon-version.test.ts +137 -0
  134. package/src/http-gzip.test.ts +94 -0
  135. package/src/http-gzip.ts +112 -0
  136. package/src/hub-catalog-read-http.test.ts +664 -0
  137. package/src/hub-provider-config.test.ts +166 -0
  138. package/src/hub-provider-config.ts +202 -0
  139. package/src/hub-timestamp.test.ts +38 -0
  140. package/src/hub-timestamp.ts +27 -0
  141. package/src/human-dm.ts +215 -0
  142. package/src/human-inbox.ts +42 -0
  143. package/src/inbox-caller.ts +49 -0
  144. package/src/inbox-count-sse.test.ts +318 -0
  145. package/src/inbox-count.ts +29 -0
  146. package/src/index.ts +6 -2
  147. package/src/license-state.test.ts +105 -0
  148. package/src/license-state.ts +48 -0
  149. package/src/lifecycle-error-domain.test.ts +149 -0
  150. package/src/list-ack-error-domain.test.ts +108 -0
  151. package/src/list-host-supervisors.test.ts +15 -4
  152. package/src/list-tasks-omit-default.test.ts +84 -0
  153. package/src/list-tasks-since-last.test.ts +100 -0
  154. package/src/list-tasks-since.test.ts +104 -0
  155. package/src/mcp-context-cost-http.test.ts +127 -0
  156. package/src/mcp-inflight.test.ts +92 -0
  157. package/src/mcp-inflight.ts +38 -0
  158. package/src/mcp-projects-events-http.test.ts +168 -0
  159. package/src/mcp-route-label-http.test.ts +120 -0
  160. package/src/mcp-write-network-resolution.test.ts +21 -0
  161. package/src/member-audit-network-id-http.test.ts +93 -0
  162. package/src/member-presence-http.test.ts +210 -0
  163. package/src/messages-ack-by-agent-http.test.ts +142 -0
  164. package/src/migrate-sqlite-to-pg.test.ts +47 -0
  165. package/src/migrate-sqlite-to-pg.ts +263 -0
  166. package/src/model-auth-notify-http.test.ts +181 -0
  167. package/src/model-auth-notify.ts +116 -0
  168. package/src/network-name-http.test.ts +75 -0
  169. package/src/network-quota-config.test.ts +100 -0
  170. package/src/network-rules-http.test.ts +169 -0
  171. package/src/network-rules.ts +129 -0
  172. package/src/network-scope.ts +222 -3
  173. package/src/network-token-membership-http.test.ts +186 -0
  174. package/src/node-alias-control.ts +12 -0
  175. package/src/node-attrs.test.ts +47 -2
  176. package/src/node-caller-identity-http.test.ts +1108 -0
  177. package/src/node-config-last-update.test.ts +126 -0
  178. package/src/node-config-last-update.ts +107 -0
  179. package/src/node-create-request-status-http.test.ts +105 -0
  180. package/src/node-daemon-bindings.test.ts +142 -0
  181. package/src/node-daemon-bindings.ts +135 -0
  182. package/src/node-failure-alert.test.ts +150 -0
  183. package/src/node-failure-alert.ts +177 -0
  184. package/src/node-files-transport.test.ts +350 -0
  185. package/src/node-health-codex-login.test.ts +120 -0
  186. package/src/node-health-dispatch-http.test.ts +373 -0
  187. package/src/node-health-guard-origin.test.ts +98 -0
  188. package/src/node-health-guard.ts +121 -0
  189. package/src/node-health-passthrough.test.ts +115 -0
  190. package/src/node-health-store.ts +101 -0
  191. package/src/node-id-alias.test.ts +190 -0
  192. package/src/node-identity-conflict-http.test.ts +269 -0
  193. package/src/node-identity-conflict.ts +142 -0
  194. package/src/node-identity-mismatch.test.ts +74 -0
  195. package/src/node-in-flight-tasks.ts +31 -0
  196. package/src/node-lifecycle-controllable.test.ts +64 -0
  197. package/src/node-lifecycle-controllable.ts +53 -0
  198. package/src/node-lifecycle-read-http.test.ts +257 -0
  199. package/src/node-lifecycle-read.ts +126 -0
  200. package/src/node-logs-transport.test.ts +266 -0
  201. package/src/node-peer-allowlist.test.ts +114 -0
  202. package/src/node-permissions-http.test.ts +901 -0
  203. package/src/node-permissions.ts +496 -0
  204. package/src/node-request-retention.test.ts +281 -0
  205. package/src/node-request-retention.ts +120 -0
  206. package/src/node-secret-rest-http.test.ts +190 -0
  207. package/src/node-secret-vault-inject.test.ts +132 -0
  208. package/src/node-security-write-gate.test.ts +72 -0
  209. package/src/node-serviceability.test.ts +86 -0
  210. package/src/node-serviceability.ts +124 -0
  211. package/src/node-session-control-http.test.ts +398 -0
  212. package/src/node-session-control.ts +316 -0
  213. package/src/node-skills-transport.test.ts +212 -0
  214. package/src/node-token-identity.ts +35 -0
  215. package/src/node-token-ownership.ts +51 -0
  216. package/src/node-token-privilege-http.test.ts +224 -0
  217. package/src/node-token-usage.test.ts +128 -0
  218. package/src/node-token-usage.ts +228 -0
  219. package/src/not-found-api-http.test.ts +67 -0
  220. package/src/observer-avatar-http.test.ts +103 -10
  221. package/src/observer-push.test.ts +76 -0
  222. package/src/opencode-catalog-report-http.test.ts +139 -0
  223. package/src/opencode-v2-catalog.test.ts +282 -0
  224. package/src/opencode-v2-catalog.ts +357 -0
  225. package/src/package-self-contained.test.ts +32 -0
  226. package/src/package-version-consistency.test.ts +25 -0
  227. package/src/parent-infer.test.ts +82 -0
  228. package/src/parent-infer.ts +110 -0
  229. package/src/parent-source-marker.test.ts +70 -0
  230. package/src/parent-source-orphan.test.ts +121 -0
  231. package/src/password-network-tokens.ts +25 -0
  232. package/src/peer-reply-atomic.test.ts +462 -0
  233. package/src/peer-reply-capability.test.ts +70 -0
  234. package/src/pg-worker.ts +87 -0
  235. package/src/poll-pacing.test.ts +74 -0
  236. package/src/poll-pacing.ts +123 -0
  237. package/src/probe-provider-error-domain.test.ts +145 -0
  238. package/src/project-dir-warn-clear-http.test.ts +132 -0
  239. package/src/project-viewer-can-http.test.ts +116 -0
  240. package/src/provider-skill-error-domain.test.ts +130 -0
  241. package/src/provider-tools-shape.test.ts +165 -0
  242. package/src/push.test.ts +20 -10
  243. package/src/push.ts +373 -9
  244. package/src/redact-tokens.test.ts +86 -0
  245. package/src/redact-tokens.ts +43 -0
  246. package/src/rejection-counters.test.ts +72 -0
  247. package/src/rejection-counters.ts +173 -0
  248. package/src/rename.ts +38 -10
  249. package/src/reply-target-derivation.test.ts +96 -0
  250. package/src/report-status-handover-capabilities-http.test.ts +124 -0
  251. package/src/report-status-host-schema.test.ts +272 -0
  252. package/src/report-status-resume-id-handover.test.ts +184 -0
  253. package/src/report-status-secret-keys.test.ts +140 -0
  254. package/src/require-explicit-test-db.ts +9 -0
  255. package/src/requirement-due-reminders-http.test.ts +620 -0
  256. package/src/requirement-due-reminders.ts +416 -0
  257. package/src/requirement-events-http.test.ts +318 -0
  258. package/src/requirement-events.test.ts +45 -0
  259. package/src/requirement-events.ts +144 -0
  260. package/src/requirement-notify.ts +165 -0
  261. package/src/requirement-participant-notify-http.test.ts +313 -0
  262. package/src/requirement-tag-ops-http.test.ts +454 -0
  263. package/src/requirement-tag-tree-http.test.ts +275 -0
  264. package/src/requirement-tag-tree.ts +127 -0
  265. package/src/requirement-tags.ts +102 -0
  266. package/src/requirements-abandoned-http.test.ts +236 -0
  267. package/src/requirements-assignee-drift.test.ts +154 -0
  268. package/src/requirements-comment-http.test.ts +174 -0
  269. package/src/requirements-completed-at-migration.test.ts +70 -0
  270. package/src/requirements-errors-mcp-http.test.ts +164 -0
  271. package/src/requirements-errors.ts +158 -0
  272. package/src/requirements-etag-http.test.ts +91 -0
  273. package/src/requirements-http.test.ts +709 -0
  274. package/src/requirements-last-event-http.test.ts +349 -0
  275. package/src/requirements-list-mcp-slim-http.test.ts +155 -0
  276. package/src/requirements-list-slim-http.test.ts +324 -0
  277. package/src/requirements-mcp.test.ts +180 -0
  278. package/src/requirements-migrate.ts +283 -0
  279. package/src/requirements-owner-strict-mcp-http.test.ts +145 -0
  280. package/src/requirements-people-http.test.ts +114 -0
  281. package/src/requirements-people-mcp-http.test.ts +231 -0
  282. package/src/requirements-people.ts +196 -0
  283. package/src/requirements-priority-lowest.test.ts +114 -0
  284. package/src/requirements-projects-network-echo.test.ts +57 -0
  285. package/src/requirements-projects-parent-http.test.ts +123 -0
  286. package/src/requirements-search-http.test.ts +182 -0
  287. package/src/requirements-search.test.ts +32 -0
  288. package/src/requirements-search.ts +145 -0
  289. package/src/requirements-seq-http.test.ts +193 -0
  290. package/src/requirements-seq-migration.test.ts +63 -0
  291. package/src/requirements-start-date.test.ts +125 -0
  292. package/src/requirements-stats-http.test.ts +357 -0
  293. package/src/requirements-stats.ts +195 -0
  294. package/src/requirements-status-participants-http.test.ts +222 -0
  295. package/src/requirements-upgrade-e2e.test.ts +126 -0
  296. package/src/requirements-upgrade-migration.test.ts +98 -0
  297. package/src/requirements.ts +2205 -0
  298. package/src/resolve-port.test.ts +57 -0
  299. package/src/resolve-port.ts +44 -0
  300. package/src/rest-alias-network-fallback-http.test.ts +123 -0
  301. package/src/rest-alias-network-fallback.test.ts +60 -0
  302. package/src/rest-alias-network-fallback.ts +65 -0
  303. package/src/rest-explicit-columns-http.test.ts +266 -0
  304. package/src/rest-identity.test.ts +130 -0
  305. package/src/rest-identity.ts +141 -0
  306. package/src/rest-projections.ts +72 -0
  307. package/src/rest-read-network-real-chain.test.ts +97 -0
  308. package/src/rest-write-network-resolution.test.ts +133 -0
  309. package/src/restart-readiness-http.test.ts +121 -0
  310. package/src/restricted-files.ts +76 -0
  311. package/src/retention-first-sweep-quiet.test.ts +31 -0
  312. package/src/retention.test.ts +100 -40
  313. package/src/retention.ts +423 -104
  314. package/src/route-callers-http.test.ts +120 -0
  315. package/src/route-timing.test.ts +218 -0
  316. package/src/route-timing.ts +262 -0
  317. package/src/rules-file-duplicate-alias.test.ts +234 -0
  318. package/src/rules-file-session-target.test.ts +207 -0
  319. package/src/rules-file-transport.test.ts +280 -0
  320. package/src/runtime-label.test.ts +22 -0
  321. package/src/runtime-label.ts +21 -0
  322. package/src/runtime-readiness.ts +90 -0
  323. package/src/schedule-agent-mcp-http.test.ts +486 -0
  324. package/src/schedule-agent.ts +252 -0
  325. package/src/schedule-starved.test.ts +92 -0
  326. package/src/schedule-starved.ts +114 -0
  327. package/src/scheduled-backoff-http.test.ts +203 -0
  328. package/src/scheduled-backoff.ts +64 -0
  329. package/src/scheduled-doorbell-nodeless-session.test.ts +134 -0
  330. package/src/scheduled-failure-backoff-2622.test.ts +145 -0
  331. package/src/scheduled-failure-code.test.ts +73 -0
  332. package/src/scheduled-failure-code.ts +105 -0
  333. package/src/scheduled-failures-http.test.ts +279 -0
  334. package/src/scheduled-failures.ts +425 -0
  335. package/src/scheduled-noprogress-backoff-2622.test.ts +163 -0
  336. package/src/scheduled-offline-backoff-probe.test.ts +56 -0
  337. package/src/scheduled-offline.test.ts +131 -0
  338. package/src/scheduled-offline.ts +66 -0
  339. package/src/scheduled-outcome-guidance-http.test.ts +139 -0
  340. package/src/scheduled-outcome-guidance.ts +9 -0
  341. package/src/scheduled-reply-unread-http.test.ts +212 -0
  342. package/src/scheduled-requirement-wake-http.test.ts +289 -0
  343. package/src/scheduled-requirement-wake.ts +125 -0
  344. package/src/scheduled-run-terminal.test.ts +290 -0
  345. package/src/scheduled-skip-blocking-task.test.ts +120 -0
  346. package/src/scheduled-skip-path-backoff-2622.test.ts +98 -0
  347. package/src/scheduled-stuck-http.test.ts +316 -0
  348. package/src/scheduled-stuck-notice-cap.test.ts +80 -0
  349. package/src/scheduled-stuck.ts +219 -0
  350. package/src/scheduled-tasks-http.test.ts +679 -0
  351. package/src/scheduled-tasks.ts +964 -0
  352. package/src/scheduled-work-outcome-http.test.ts +154 -0
  353. package/src/scheduled-work-outcome.ts +50 -0
  354. package/src/scoped-secrets.ts +167 -0
  355. package/src/secret-echo-negative-control.test.ts +118 -0
  356. package/src/send-dedup-request-id.test.ts +229 -0
  357. package/src/send-reply-agent-warning.test.ts +38 -38
  358. package/src/send-reply-alias-optional.test.ts +131 -0
  359. package/src/send-reply-attachments.test.ts +28 -7
  360. package/src/send_dedup.test.ts +54 -0
  361. package/src/send_dedup.ts +52 -6
  362. package/src/serve-error.test.ts +73 -0
  363. package/src/serve-error.ts +56 -0
  364. package/src/server.ts +5033 -377
  365. package/src/session-fork-store.test.ts +43 -0
  366. package/src/session-fork-store.ts +51 -0
  367. package/src/session-project-attach-migration.test.ts +22 -0
  368. package/src/session-project-attach-native.test.ts +121 -0
  369. package/src/session-project-create-http.test.ts +407 -0
  370. package/src/session-project-create-native.test.ts +290 -0
  371. package/src/session-project-create.ts +159 -0
  372. package/src/session-source-admission-store.ts +58 -0
  373. package/src/session-source-create.test.ts +155 -0
  374. package/src/session-source-create.ts +97 -0
  375. package/src/session-source-delivery.ts +109 -0
  376. package/src/session-source-directory-http.test.ts +192 -0
  377. package/src/session-source-evidence.test.ts +898 -0
  378. package/src/session-source-evidence.ts +191 -0
  379. package/src/session-source-execution.ts +87 -0
  380. package/src/session-source-grant.test.ts +117 -0
  381. package/src/session-source-grant.ts +78 -0
  382. package/src/session-source-issuer.test.ts +250 -0
  383. package/src/session-source-issuer.ts +164 -0
  384. package/src/session-source-transport.ts +375 -0
  385. package/src/session-task-on-dispatch.ts +14 -0
  386. package/src/session-token-ownership-http.test.ts +122 -0
  387. package/src/shared/codex-inventory.ts +41 -0
  388. package/src/shared/daemon-provider-login.ts +31 -0
  389. package/src/shared/daemon-provider-snapshot.ts +52 -0
  390. package/src/shared/external-schedule-contract.ts +60 -0
  391. package/src/shared/node-name.test.ts +62 -0
  392. package/src/shared/node-name.ts +161 -0
  393. package/src/shared/probe-host-allowlist-drift.test.ts +45 -0
  394. package/src/shared/provider-application.ts +29 -0
  395. package/src/shared/provider-collection.ts +14 -0
  396. package/src/shared/provider-initialization.ts +8 -0
  397. package/src/shared/reserved-env-drift.test.ts +10 -0
  398. package/src/shared/scoped-secret-contract.ts +5 -0
  399. package/src/shared/task-content-limit-drift.test.ts +28 -0
  400. package/src/shared/task-content-limit.ts +25 -0
  401. package/src/side-thread-command-transport.test.ts +312 -0
  402. package/src/side-thread-command-transport.ts +318 -0
  403. package/src/side-thread-http-integration.test.ts +233 -0
  404. package/src/side-thread-http.ts +504 -0
  405. package/src/side-thread-production.test.ts +72 -0
  406. package/src/side-thread-production.ts +118 -0
  407. package/src/side-thread.test.ts +1067 -0
  408. package/src/side-thread.ts +2499 -0
  409. package/src/skillhub-http.test.ts +144 -0
  410. package/src/sqlite-close-checkpoint.test.ts +78 -0
  411. package/src/start-node.test.ts +265 -0
  412. package/src/start-request-error-domain.test.ts +182 -0
  413. package/src/start-skill-error-domain.test.ts +122 -0
  414. package/src/stats-versions-http.test.ts +65 -0
  415. package/src/status-alias-filter-http.test.ts +106 -0
  416. package/src/status-alias-resolver-http.test.ts +163 -0
  417. package/src/status-alias-resolver.ts +19 -0
  418. package/src/status-node-id-filter-http.test.ts +161 -0
  419. package/src/status-node-secrets-capable-http.test.ts +44 -0
  420. package/src/status-read-cache-http.test.ts +229 -0
  421. package/src/status-read-cache.ts +129 -0
  422. package/src/stop-delete-node.test.ts +567 -1
  423. package/src/task-access-http.test.ts +407 -0
  424. package/src/task-access.ts +420 -0
  425. package/src/task-activity.ts +60 -0
  426. package/src/task-auth-origin-http.test.ts +93 -0
  427. package/src/task-auth-origin.test.ts +24 -0
  428. package/src/task-auth-origin.ts +7 -0
  429. package/src/task-consumption.test.ts +512 -0
  430. package/src/task-diagnostic-http.test.ts +149 -0
  431. package/src/task-diagnostic.test.ts +115 -0
  432. package/src/task-diagnostic.ts +118 -0
  433. package/src/task-expiry-notice-http.test.ts +298 -0
  434. package/src/task-expiry-notice.ts +318 -0
  435. package/src/task-idempotency-mcp.test.ts +148 -0
  436. package/src/task-idempotency.test.ts +76 -0
  437. package/src/task-idempotency.ts +81 -0
  438. package/src/task-late-replies.ts +54 -0
  439. package/src/task-late-reply-http.test.ts +227 -0
  440. package/src/task-lifecycle-watcher-busy.test.ts +114 -0
  441. package/src/task-lifecycle-watcher.test.ts +209 -0
  442. package/src/task-lifecycle-watcher.ts +109 -0
  443. package/src/task-network-resolution-http.test.ts +140 -0
  444. package/src/task-not-found-error-domain.test.ts +117 -0
  445. package/src/task-offline-delivery-2668.test.ts +119 -0
  446. package/src/task-offline-delivery.ts +81 -0
  447. package/src/task-orphan-http.test.ts +287 -0
  448. package/src/task-orphan.ts +119 -0
  449. package/src/task-queue-ahead-http.test.ts +309 -0
  450. package/src/task-queue-ahead-scale.test.ts +236 -0
  451. package/src/task-queue-ahead.ts +186 -0
  452. package/src/task-rejection-log-http.test.ts +160 -0
  453. package/src/task-rejection-log.ts +61 -0
  454. package/src/task-sender-http.test.ts +143 -0
  455. package/src/task-stale-open-http.test.ts +292 -0
  456. package/src/task-stale-open.ts +103 -0
  457. package/src/tasks-pagination-http.test.ts +141 -0
  458. package/src/team-rules-status-http.test.ts +90 -0
  459. package/src/team-rules-status.test.ts +59 -0
  460. package/src/team-rules-status.ts +72 -0
  461. package/src/tmux-allowlist.test.ts +48 -0
  462. package/src/token-usage-http.test.ts +156 -0
  463. package/src/tool-audience-http.test.ts +266 -0
  464. package/src/tool-audience.ts +130 -0
  465. package/src/tools-list-json-schema.test.ts +94 -0
  466. package/src/tools.ts +4530 -471
  467. package/src/update-node-config-error-domain.test.ts +107 -0
  468. package/src/uploads-http.test.ts +6 -4
  469. package/src/uploads.ts +23 -4
  470. package/src/user-avatar-http.test.ts +74 -0
  471. package/src/user-avatar-image.ts +160 -0
  472. package/src/user-avatar-migration.test.ts +25 -0
  473. package/src/user-avatar-upload-http.test.ts +353 -0
  474. package/src/user-inbox-by-agent-http.test.ts +189 -0
  475. package/src/user-inbox-netid-notnull.test.ts +122 -0
  476. package/src/user-inbox-read-http.test.ts +223 -0
  477. package/src/user-inbox-schema.test.ts +54 -0
  478. package/src/version-stats.test.ts +66 -0
  479. package/src/version-stats.ts +109 -0
@@ -0,0 +1,107 @@
1
+ // #3309 读数覆盖第三批 —— `update_node_config` 的 3 个 error 字面量此前在测试里一次都没出现过:
2
+ //
3
+ // channels_all_invalid / insufficient_role_for_security_flag / invalid_patch
4
+ //
5
+ // 现有测试覆盖的是**成功改配置**与**响应键集**,所以这三条拒绝分支从来没被走过。
6
+ //
7
+ // 三条的处置完全不同,这也是它们必须各有断言的理由:
8
+ // channels_all_invalid ⇒ 调用方发来的渠道**全不认识**(可能是拼错,也可能是客户端版本旧)
9
+ // —— 绝不能静默当成「停用全部」,那会灭掉用户已有的 worker
10
+ // insufficient_role_for_security_flag ⇒ 权限不足;换个人来做或升级角色
11
+ // invalid_patch ⇒ 载荷本身不合法;改载荷
12
+ //
13
+ // 特别注意三条里 **两条的 error 都是 invalid_patch 家族之外的东西** ——
14
+ // 只按 ok===false 断言时,它们与「网络不通」「节点不存在」完全同形。
15
+ import { afterAll, beforeEach, describe, expect, test } from "bun:test";
16
+ import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
17
+ import { db } from "./db.js";
18
+ import { registerTools } from "./tools.js";
19
+
20
+ const NET = "net_unc";
21
+ const ADMIN = "u_unc_admin";
22
+ const MEMBER = "u_unc_member";
23
+ const NODE = "n_unc_node";
24
+
25
+ type ToolHandler = (args: any) => Promise<any>;
26
+
27
+ function handlers(userId: string): Record<string, ToolHandler> {
28
+ const server = new McpServer({ name: "t", version: "0" }) as any;
29
+ const tools: Record<string, ToolHandler> = {};
30
+ const orig = server.tool.bind(server);
31
+ server.tool = (name: string, desc: string, schema: any, handler: ToolHandler) => {
32
+ tools[name] = handler;
33
+ return orig(name, desc, schema, handler);
34
+ };
35
+ registerTools(server, undefined, NET, userId, "unc-node", false, null);
36
+ return tools;
37
+ }
38
+
39
+ async function patch(userId: string, p: Record<string, unknown>, baseRevision = 0) {
40
+ const r = await handlers(userId).update_node_config({
41
+ node_id: NODE, base_revision: baseRevision, patch: p,
42
+ });
43
+ return JSON.parse(r.content[0].text);
44
+ }
45
+
46
+ function cleanup() {
47
+ db.run("DELETE FROM network_members WHERE network_id = ?1", [NET]);
48
+ db.run("DELETE FROM nodes WHERE network_id = ?1", [NET]);
49
+ db.run("DELETE FROM networks WHERE network_id = ?1", [NET]);
50
+ db.run("DELETE FROM users WHERE user_id IN (?1, ?2)", [ADMIN, MEMBER]);
51
+ }
52
+
53
+ function seed() {
54
+ cleanup();
55
+ db.run("INSERT INTO users (user_id, username, password_hash, role, created_at) VALUES (?1, ?1, 'x', 'user', datetime('now'))", [ADMIN]);
56
+ db.run("INSERT INTO users (user_id, username, password_hash, role, created_at) VALUES (?1, ?1, 'x', 'user', datetime('now'))", [MEMBER]);
57
+ db.run("INSERT INTO networks (network_id, network_name, owner_id, created_at) VALUES (?1, ?1, ?2, datetime('now'))", [NET, ADMIN]);
58
+ db.run("INSERT INTO network_members (user_id, network_id, role, joined_at) VALUES (?1, ?2, 'owner', datetime('now'))", [ADMIN, NET]);
59
+ db.run("INSERT INTO network_members (user_id, network_id, role, joined_at) VALUES (?1, ?2, 'member', datetime('now'))", [MEMBER, NET]);
60
+ db.run(`INSERT INTO nodes (node_id, node_name, alias, network_id, runtime, model, channels, config_snapshot,
61
+ hostname, created_at, updated_at, lifecycle_state)
62
+ VALUES (?1, 'unc-node', 'unc-node', ?2, 'claude-agent-sdk', 'm', '["commhub"]', '{}', 'host-u',
63
+ datetime('now'), datetime('now'), 'active')`, [NODE, NET]);
64
+ }
65
+
66
+ beforeEach(seed);
67
+ afterAll(cleanup);
68
+
69
+ describe("#3309 update_node_config 错误值域:三条拒绝各有一条会红的断言", () => {
70
+ test("渠道全不认识 ⇒ channels_all_invalid(且回显 requested,**不是** invalid_patch)", async () => {
71
+ const r = await patch(ADMIN, { channels: ["telegarm"] });
72
+ expect(r.ok).toBe(false);
73
+ expect(r.error).toBe("channels_all_invalid");
74
+ // 回显调用方发来的原值:只说「全不合法」时,读的人还得自己猜发了什么。
75
+ expect(r.requested).toEqual(["telegarm"]);
76
+ // 与 invalid_patch 的区别是本条的重点:一个要改渠道名,一个要改载荷结构。
77
+ expect(r.error).not.toBe("invalid_patch");
78
+ });
79
+
80
+ test("成员改安全敏感 flag ⇒ insufficient_role_for_security_flag(带 field 与 required_role)", async () => {
81
+ const r = await patch(MEMBER, { flags: { permissionMode: "restricted" } });
82
+ expect(r.ok).toBe(false);
83
+ expect(r.error).toBe("insufficient_role_for_security_flag");
84
+ expect(r.field).toBe("flags.permissionMode");
85
+ expect(r.required_role).toBe("admin");
86
+ });
87
+
88
+ test("模型名非法 ⇒ invalid_patch(带 field=model 与 reason)", async () => {
89
+ // zod 只限 max(200),空串能过 zod、被 validatePatch 拦下 ⇒ 正好走到这条分支。
90
+ const r = await patch(ADMIN, { model: "" });
91
+ expect(r.ok).toBe(false);
92
+ expect(r.error).toBe("invalid_patch");
93
+ expect(r.field).toBe("model");
94
+ expect(typeof r.reason).toBe("string");
95
+ });
96
+
97
+ test("三条的载荷都**没有** code 字段(现状,不是契约)", async () => {
98
+ for (const r of [
99
+ await patch(ADMIN, { channels: ["telegarm"] }),
100
+ await patch(MEMBER, { flags: { permissionMode: "restricted" } }),
101
+ await patch(ADMIN, { model: "" }),
102
+ ]) {
103
+ expect(r.ok).toBe(false);
104
+ expect(Object.prototype.hasOwnProperty.call(r, "code")).toBe(false);
105
+ }
106
+ });
107
+ });
@@ -7,12 +7,12 @@
7
7
  // this file already exercises the same code path). The hub binds to
8
8
  // an ephemeral port so multiple test runs don't collide.
9
9
  import { describe, expect, test, beforeAll, afterAll } from "bun:test";
10
+ import "./require-explicit-test-db.js";
10
11
  import { mkdtempSync, rmSync, existsSync } from "fs";
11
12
  import { join } from "path";
12
13
  import { tmpdir } from "os";
13
14
  import { register, login } from "./auth.js";
14
15
 
15
- const SERVER_DB = mkdtempSync(join(tmpdir(), "anet-upload-http-db-")) + "/commhub.db";
16
16
  const UPLOADS_DIR = mkdtempSync(join(tmpdir(), "anet-upload-http-fs-"));
17
17
  // #438 corrective: private bootServer({ port: 0 }) instance — the OS
18
18
  // assigns the port and BASE is derived from the ACTUAL bound port, so
@@ -24,11 +24,14 @@ let server: any;
24
24
  let userToken = "";
25
25
  let userNetworkId = "";
26
26
 
27
+ // 30s 而不是 bun 默认的 5s:这个 hook 跑 register()(KDF)+bootServer(),
28
+ // 本机空载基线 ~620ms,而 2026-08-17 与 2026-08-31 两次 CI 上它被 5s 上限打死
29
+ // (0 pass / 1 fail / Ran 1 test —— 见 #928、#1627)。5247ms 是**被截断的下界**,
30
+ // 不是测量值,所以余量按基线的 ~48x 取,而不是按那个数取。
27
31
  beforeAll(async () => {
28
32
  // Bootstrap a real admin + token on the temp DB so the server can
29
33
  // resolve it via requireAuth (we don't want to short-circuit auth —
30
34
  // we want to validate the production code path).
31
- process.env.COMMHUB_DB = SERVER_DB;
32
35
  process.env.COMMHUB_UPLOADS_DIR = UPLOADS_DIR;
33
36
  process.env.HOST = "127.0.0.1";
34
37
 
@@ -59,12 +62,11 @@ beforeAll(async () => {
59
62
  BASE = `http://127.0.0.1:${server.port}`;
60
63
  // Tiny settle so the listener is ready.
61
64
  await new Promise((r) => setTimeout(r, 100));
62
- });
65
+ }, 30_000);
63
66
 
64
67
  afterAll(() => {
65
68
  try { server?.stop?.(true); } catch {}
66
69
  try { rmSync(UPLOADS_DIR, { recursive: true, force: true }); } catch {}
67
- try { rmSync(SERVER_DB, { recursive: true, force: true }); } catch {}
68
70
  });
69
71
 
70
72
  function authHeaders(): Record<string, string> {
package/src/uploads.ts CHANGED
@@ -53,6 +53,17 @@ export const UPLOAD_RATE_MAX_ENTRIES = 50_000;
53
53
  // traversal.
54
54
  export const FILE_ID_REGEX = /^[A-Za-z0-9_-]{8,64}$/;
55
55
 
56
+ // Stored extension tokens have one invariant at every path boundary:
57
+ // either no extension, or a leading dot followed by 1-16 ASCII
58
+ // alphanumeric characters. Keep this separate from sanitizeExt(), which
59
+ // parses a client filename and therefore deliberately has different
60
+ // capture/anchoring semantics.
61
+ const EXT_TOKEN_REGEX = /^\.[A-Za-z0-9]{1,16}$/;
62
+
63
+ function isValidExtToken(ext: unknown): ext is string {
64
+ return typeof ext === "string" && (ext === "" || EXT_TOKEN_REGEX.test(ext));
65
+ }
66
+
56
67
  export type GeneratedFile = {
57
68
  fileId: string;
58
69
  ext: string;
@@ -138,7 +149,7 @@ export function isValidCalendarBucket(bucket: unknown): bucket is string {
138
149
  */
139
150
  export function buildStoragePath(fileId: string, ext: string, opts: { uploadsRoot?: string; now?: Date } = {}): GeneratedFile {
140
151
  if (!FILE_ID_REGEX.test(fileId)) throw new Error(`file_id "${fileId}" is invalid`);
141
- if (ext && !/^\.[A-Za-z0-9]{1,16}$/.test(ext)) throw new Error(`ext "${ext}" is invalid`);
152
+ if (!isValidExtToken(ext)) throw new Error(`ext "${ext}" is invalid`);
142
153
  const dateBucket = getDateBucket(opts.now);
143
154
  const root = opts.uploadsRoot ?? getUploadsRoot();
144
155
  const relativePath = join(dateBucket, fileId + ext);
@@ -162,7 +173,7 @@ export function buildStoragePath(fileId: string, ext: string, opts: { uploadsRoo
162
173
  */
163
174
  export function pathForExistingBlob(dateBucket: string, fileId: string, ext: string, opts: { uploadsRoot?: string } = {}): GeneratedFile {
164
175
  if (!FILE_ID_REGEX.test(fileId)) throw new Error(`file_id "${fileId}" is invalid`);
165
- if (ext && !/^\.[A-Za-z0-9]{1,16}$/.test(ext)) throw new Error(`ext "${ext}" is invalid`);
176
+ if (!isValidExtToken(ext)) throw new Error(`ext "${ext}" is invalid`);
166
177
  if (typeof dateBucket !== "string" || !DATE_BUCKET_REGEX.test(dateBucket)) {
167
178
  throw new Error(`date_bucket "${dateBucket}" is invalid`);
168
179
  }
@@ -189,9 +200,15 @@ export type UploadIndexEntry = {
189
200
  // "unattributed" are the same on-disk shape and legacy entries written
190
201
  // before #503 are indistinguishable from new unattributed ones.
191
202
  network_id?: string;
203
+ // 私信文件:上传时声明 `?purpose=dm`(App 的私信输入框这么传)。第一次用途就是私信 ——
204
+ // 只有上传者、收到/发出过带它的私信的人和管理员能下载(server.ts authorizeFileDownload)。
205
+ // 不是私信的文件不写这个键;以后被转进私信也不会补写,原来谁能看还是谁能看。
206
+ scope?: typeof DM_FILE_SCOPE;
192
207
  uploaded_at: string; // ISO 8601
193
208
  };
194
209
 
210
+ export const DM_FILE_SCOPE = "dm";
211
+
195
212
  /** Path to the index entry file for a given file_id. Lives in
196
213
  * `<uploadsRoot>/.index/<file_id>.json` so /api/files/:file_id can do
197
214
  * an O(1) lookup without scanning every date bucket. */
@@ -213,10 +230,12 @@ export function validateIndexEntry(entry: unknown): entry is UploadIndexEntry {
213
230
  // rather than writing null. owner_id is deliberately NOT constrained
214
231
  // here — existing entries legitimately carry owner_id=null.
215
232
  if ("network_id" in e && !(typeof e.network_id === "string" && e.network_id.length > 0)) return false;
233
+ // 未知的 scope 值不当成「没有 scope」放行(那等于把私信文件退回全网可见):整条判坏,下载 404。
234
+ if ("scope" in e && e.scope !== DM_FILE_SCOPE) return false;
216
235
  return (
217
236
  typeof e.file_id === "string" && FILE_ID_REGEX.test(e.file_id) &&
218
237
  typeof e.date_bucket === "string" && /^\d{4}-\d{2}-\d{2}$/.test(e.date_bucket) &&
219
- typeof e.ext === "string" && (e.ext === "" || /^\.[A-Za-z0-9]{1,16}$/.test(e.ext)) &&
238
+ isValidExtToken(e.ext) &&
220
239
  typeof e.size === "number" && e.size >= 0 && e.size <= MAX_UPLOAD_BYTES
221
240
  );
222
241
  }
@@ -325,7 +344,7 @@ export type TaskAttachment = {
325
344
  * returns `{file_id, path}` where `path` is a hub-machine-local
326
345
  * absolute path. Senders sometimes echo `path` back into meta.attachments.
327
346
  * When the receiving agent runs on a different host (Vincent 2026-06-30
328
- * toodadev2 case), that path string is meaningless. agent-node's
347
+ * a partner-team host case), that path string is meaningless. agent-node's
329
348
  * fetch-attachment.ts will fetch via `file_id` regardless, but leaving
330
349
  * the stale `path` in the JSON misleads any tooling that reads it.
331
350
  *
@@ -0,0 +1,74 @@
1
+ import { expect, test } from "bun:test";
2
+ import { register, login, createNetworkTokenForNode, addNetworkMember } from "./auth.js";
3
+ import { db } from "./db.js";
4
+
5
+ // One sequential HTTP scenario: fail a prerequisite before running the next layer.
6
+ // Docker supplies an isolated DB; never import this against a production DB.
7
+ test("human avatar: auth → save/read/login → member visibility → isolation/rejection → clear", async () => {
8
+ const a = register("avatar_alice", "AvatarPassw0rd!");
9
+ const b = register("avatar_bob", "AvatarPassw0rd!");
10
+ const stranger = register("avatar_stranger", "AvatarPassw0rd!");
11
+ expect(a.ok && b.ok && stranger.ok).toBe(true);
12
+ expect(addNetworkMember(a.network_id!, b.user!.user_id, "member").ok).toBe(true);
13
+ const node = createNetworkTokenForNode(a.user!.user_id, a.network_id!, "avatar_alice", "avatar_node");
14
+ expect(node.ok).toBe(true);
15
+ const { bootServer } = await import("./server.js");
16
+ const hub = bootServer({ port: 0, hostname: "127.0.0.1" });
17
+ const base = `http://127.0.0.1:${hub.port}`;
18
+ const call = async (token: string, method: string, path: string, body?: unknown) => {
19
+ const res = await fetch(base + path, { method,
20
+ headers: { Authorization: `Bearer ${token}`, "Content-Type": "application/json" },
21
+ body: body === undefined ? undefined : JSON.stringify(body) });
22
+ return { status: res.status, body: await res.json() as any };
23
+ };
24
+ const put = (token: string, body: unknown) => call(token, "PUT", "/api/auth/me/avatar", body);
25
+ const me = (token: string) => call(token, "GET", "/api/auth/me");
26
+ try {
27
+ expect((await me(a.token!)).status).toBe(200);
28
+ expect((await me(a.token!)).body.user.avatar_url).toBeNull();
29
+ expect((await put("invalid", { avatar_url: null })).status).toBe(401);
30
+ expect((await put(node.token!, { avatar_url: null })).status).toBe(403);
31
+
32
+ const avatar = "/avatars/avatar-03.webp";
33
+ const saved = await put(a.token!, { avatar_url: avatar });
34
+ expect(saved.status).toBe(200);
35
+ expect(saved.body).toEqual({ ok: true, user_id: a.user!.user_id, avatar_url: avatar });
36
+ expect((await me(a.token!)).body.user.avatar_url).toBe(avatar);
37
+ const secondDevice = login("avatar_alice", "AvatarPassw0rd!");
38
+ expect(secondDevice.ok).toBe(true);
39
+ expect(secondDevice.user!.avatar_url).toBe(avatar);
40
+ expect((await me(secondDevice.token!)).body.user.avatar_url).toBe(avatar);
41
+ // An ordinary profile edit must preserve and return the saved avatar.
42
+ const profile = await call(a.token!, "PUT", "/api/auth/me", { display_name: "Alice" });
43
+ expect(profile.status).toBe(200);
44
+ expect(profile.body.user.avatar_url).toBe(avatar);
45
+ const people = await call(b.token!, "GET", `/api/networks/${a.network_id}/humans`);
46
+ expect(people.status).toBe(200);
47
+ expect(people.body.humans.find((u: any) => u.user_id === a.user!.user_id).avatar_url).toBe(avatar);
48
+ expect((await call(stranger.token!, "GET", `/api/networks/${a.network_id}/humans`)).status).toBe(403);
49
+ expect((await me(b.token!)).body.user.avatar_url).toBeNull();
50
+
51
+ for (const body of [null, [], {}, { avatar_url: avatar, user_id: b.user!.user_id },
52
+ ...[123, {}, "javascript:alert(1)", "file:///tmp/photo.png", "data:image/png;base64,AAAA",
53
+ "//evil.example/a.png", "/avatars/../x.png", "https://user:secret@example.com/x.png", "x".repeat(3000)]
54
+ .map((avatar_url) => ({ avatar_url }))]) {
55
+ expect((await put(a.token!, body)).status).toBe(400);
56
+ expect((await me(a.token!)).body.user.avatar_url).toBe(avatar);
57
+ }
58
+ const malformed = await fetch(base + "/api/auth/me/avatar", { method: "PUT",
59
+ headers: { Authorization: `Bearer ${a.token}`, "Content-Type": "application/json" }, body: "{" });
60
+ expect(malformed.status).toBe(400);
61
+ expect((await put(node.token!, { avatar_url: "/avatars/avatar-09.webp" })).status).toBe(403);
62
+ expect((await me(a.token!)).body.user.avatar_url).toBe(avatar);
63
+ expect((await me(b.token!)).body.user.avatar_url).toBeNull();
64
+ expect(db.get<any>("SELECT avatar_url FROM nodes WHERE node_id = ?1", "avatar_node")?.avatar_url ?? null).toBeNull();
65
+
66
+ const remote = "https://example.invalid/photo.png";
67
+ expect((await put(a.token!, { avatar_url: remote })).status).toBe(200);
68
+ expect((await me(a.token!)).body.user.avatar_url).toBe(remote);
69
+ expect((await put(a.token!, { avatar_url: null })).status).toBe(200);
70
+ expect((await me(secondDevice.token!)).body.user.avatar_url).toBeNull();
71
+ expect((await put(a.token!, { avatar_url: avatar })).status).toBe(200);
72
+ expect((await put(a.token!, { avatar_url: " " })).body.avatar_url).toBeNull();
73
+ } finally { hub.stop(true); }
74
+ }, 30_000);
@@ -0,0 +1,160 @@
1
+ // #725-adjacent? No: Hub 专用账号头像上传(通信Mac马 交付单)。
2
+ //
3
+ // 头像不是普通附件:它必须 PNG、边长 ≤512、≤8 MiB,且只能由本人用自己的
4
+ // **用户令牌**写入;读取按「人类资料可见性」(本人或共享网络的合法成员)判定,
5
+ // 不借用 /api/files 的附件 ACL(那是按网络/会话/DM 作用域判的,语义不同)。
6
+ //
7
+ // 这个模块只做纯校验,便于单测与复用;HTTP 与落库在 server.ts。
8
+ import { inflateSync } from "node:zlib";
9
+
10
+ // 校验强度:结构(签名/chunk/CRC)+ 真实解码(IDAT 解压且扫描行长度与 IHDR 相符)。
11
+
12
+ export const MAX_AVATAR_BYTES = 8 * 1024 * 1024;
13
+
14
+ /**
15
+ * #2054 —— 单个 Hub 的头像总存储上界。公开注册可以持续创建账号,per-user 单条
16
+ * 上限(每人 1 条 × 8 MiB)挡不住轮换账号把主库撑大,所以再加一道总量边界。
17
+ * 超限时上传返回 503 `avatar_storage_full`;不回收/删除任何既有用户的头像。
18
+ */
19
+ export const MAX_AVATAR_STORAGE_BYTES = 1024 * 1024 * 1024;
20
+ /** 客户端会把图重编码到最长边 512;服务端独立复核这条上限。 */
21
+ export const MAX_AVATAR_EDGE = 512;
22
+ /** version 只允许 URL 安全字符,长度有界(避免拼路径时引入 `.`、`/`)。 */
23
+ export const AVATAR_VERSION_RE = /^[A-Za-z0-9_-]{1,128}$/;
24
+ export const AVATAR_FIELD = "file";
25
+
26
+ const PNG_SIGNATURE = [0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a];
27
+
28
+ export type AvatarImageCheck =
29
+ | { ok: true; width: number; height: number }
30
+ | { ok: false; reason: "empty" | "too_large" | "not_png" | "truncated" | "bad_dimensions" | "too_big" | "bad_crc" | "bad_image" | "interlaced_unsupported" };
31
+
32
+ const CHANNELS: Record<number, number> = { 0: 1, 2: 3, 3: 1, 4: 2, 6: 4 };
33
+
34
+
35
+ /** 标准 CRC-32(PNG 每个 chunk 的尾部)。表只建一次。 */
36
+ const CRC_TABLE = (() => {
37
+ const table = new Uint32Array(256);
38
+ for (let n = 0; n < 256; n++) {
39
+ let c = n;
40
+ for (let k = 0; k < 8; k++) c = c & 1 ? 0xedb88320 ^ (c >>> 1) : c >>> 1;
41
+ table[n] = c >>> 0;
42
+ }
43
+ return table;
44
+ })();
45
+
46
+ function crc32(bytes: Uint8Array): number {
47
+ let c = 0xffffffff;
48
+ for (let i = 0; i < bytes.length; i++) c = CRC_TABLE[(c ^ bytes[i]) & 0xff] ^ (c >>> 8);
49
+ return (c ^ 0xffffffff) >>> 0;
50
+ }
51
+
52
+ function be32(bytes: Uint8Array, offset: number): number {
53
+ return ((bytes[offset] << 24) | (bytes[offset + 1] << 16) | (bytes[offset + 2] << 8) | bytes[offset + 3]) >>> 0;
54
+ }
55
+
56
+ /**
57
+ * PNG 结构校验:签名 + 逐个 chunk 的 CRC + 必须有 IDAT 且以 IEND 结尾。
58
+ *
59
+ * 只信任「结构完整」而不是「声明了什么」:截断的 33/40 字节、零填充的伪图
60
+ * (IHDR 对但 CRC 与 IDAT 缺失)都会被拒;合法用户因此不能把已有头像
61
+ * 覆盖成一张显示不出来的图。
62
+ */
63
+ export function inspectAvatarImage(input: Uint8Array): AvatarImageCheck {
64
+ if (input.byteLength === 0) return { ok: false, reason: "empty" };
65
+ if (input.byteLength > MAX_AVATAR_BYTES) return { ok: false, reason: "too_large" };
66
+ for (let i = 0; i < PNG_SIGNATURE.length && i < input.byteLength; i++) {
67
+ if (input[i] !== PNG_SIGNATURE[i]) return { ok: false, reason: "not_png" };
68
+ }
69
+ if (input.byteLength < 45) return { ok: false, reason: "truncated" }; // 签名 + IHDR(25) + 最小 IEND(12)
70
+
71
+ let pos = 8;
72
+ let width = 0;
73
+ let height = 0;
74
+ let sawIHDR = false;
75
+ let idatChunks = 0;
76
+ let sawIEND = false;
77
+ let sawPLTE = false;
78
+ let bitDepth = 0;
79
+ let colorType = 0;
80
+ const idat: Uint8Array[] = [];
81
+
82
+ while (pos + 12 <= input.byteLength) {
83
+ const length = be32(input, pos);
84
+ const type = String.fromCharCode(input[pos + 4], input[pos + 5], input[pos + 6], input[pos + 7]);
85
+ const dataStart = pos + 8;
86
+ const dataEnd = dataStart + length;
87
+ const crcEnd = dataEnd + 4;
88
+ if (crcEnd > input.byteLength) return { ok: false, reason: "truncated" };
89
+ if (!sawIHDR && type !== "IHDR") return { ok: false, reason: "not_png" };
90
+ if ((crc32(input.subarray(pos + 4, dataEnd)) >>> 0) !== be32(input, dataEnd)) {
91
+ return { ok: false, reason: "bad_crc" };
92
+ }
93
+ if (type === "IHDR") {
94
+ if (sawIHDR || length !== 13) return { ok: false, reason: "not_png" };
95
+ width = be32(input, dataStart);
96
+ height = be32(input, dataStart + 4);
97
+ bitDepth = input[dataStart + 8];
98
+ colorType = input[dataStart + 9];
99
+ const compression = input[dataStart + 10];
100
+ const filter = input[dataStart + 11];
101
+ const interlace = input[dataStart + 12];
102
+ // 只接受规范的 IHDR 取值组合;非法组合的图多数解码器也会拒绝。
103
+ const legalDepth: Record<number, number[]> = { 0: [1, 2, 4, 8, 16], 2: [8, 16], 3: [1, 2, 4, 8], 4: [8, 16], 6: [8, 16] };
104
+ if (!legalDepth[colorType]?.includes(bitDepth)) return { ok: false, reason: "not_png" };
105
+ if (compression !== 0 || filter !== 0) return { ok: false, reason: "not_png" };
106
+ // 本实现只校验逐行(interlace=0)扫描布局:Adam7(=1) 的布局不同,其余取值(2..255)
107
+ // 在 PNG 规范里根本不合法。一律明确拒收,而不是错算长度后放行。
108
+ if (interlace !== 0) return { ok: false, reason: "interlaced_unsupported" };
109
+ if (width === 0 || height === 0) return { ok: false, reason: "bad_dimensions" };
110
+ if (width > MAX_AVATAR_EDGE || height > MAX_AVATAR_EDGE) return { ok: false, reason: "too_big" };
111
+ sawIHDR = true;
112
+ } else if (type === "PLTE") {
113
+ if (length === 0 || length % 3 !== 0) return { ok: false, reason: "not_png" };
114
+ sawPLTE = true;
115
+ } else if (type === "IDAT") {
116
+ idatChunks++;
117
+ idat.push(input.subarray(dataStart, dataEnd));
118
+ } else if (type === "IEND") {
119
+ if (length !== 0) return { ok: false, reason: "not_png" };
120
+ if (crcEnd !== input.byteLength) return { ok: false, reason: "not_png" };
121
+ sawIEND = true;
122
+ break;
123
+ }
124
+ pos = crcEnd;
125
+ }
126
+
127
+ if (!sawIHDR || !sawIEND) return { ok: false, reason: "truncated" };
128
+ if (idatChunks === 0) return { ok: false, reason: "not_png" };
129
+ // 调色板图必须带 PLTE,否则解码器无从取色。
130
+ if (colorType === 3 && !sawPLTE) return { ok: false, reason: "not_png" };
131
+ // CRC 只证明「容器没坏」,不证明 IDAT 里是图像数据:真解一次 zlib,并核对
132
+ // 解压后长度正好等于 IHDR 声明的扫描行总长(每行 1 字节 filter + 像素字节)。
133
+ const bytesPerRow = Math.ceil((width * (CHANNELS[colorType] ?? 0) * bitDepth) / 8);
134
+ const expected = height * (1 + bytesPerRow);
135
+ let raw: Uint8Array;
136
+ try {
137
+ const merged = Buffer.concat(idat.map(part => Buffer.from(part)));
138
+ raw = new Uint8Array(inflateSync(merged, { maxOutputLength: expected + 1024 }));
139
+ } catch {
140
+ return { ok: false, reason: "bad_image" };
141
+ }
142
+ if (raw.byteLength !== expected) return { ok: false, reason: "bad_image" };
143
+ for (let row = 0; row < height; row++) {
144
+ if (raw[row * (1 + bytesPerRow)] > 4) return { ok: false, reason: "bad_image" }; // 过滤器 0..4
145
+ }
146
+ return { ok: true, width, height };
147
+ }
148
+
149
+ export function isValidAvatarVersion(value: unknown): value is string {
150
+ return typeof value === "string" && AVATAR_VERSION_RE.test(value);
151
+ }
152
+
153
+ export function avatarUrl(userId: string, version: string): string {
154
+ return `/api/users/${encodeURIComponent(userId)}/avatar/${version}.png`;
155
+ }
156
+
157
+ /** 只接受 multipart 里的单张图;多余字段一律拒绝,避免「顺手塞个 filename 覆盖路径」。 */
158
+ export function isMultipart(contentType: string | null): boolean {
159
+ return !!contentType && /^multipart\/form-data\b/i.test(contentType);
160
+ }
@@ -0,0 +1,25 @@
1
+ import { expect, test } from "bun:test";
2
+ import { Database } from "bun:sqlite";
3
+
4
+ test("existing users survive additive avatar migration and next process preserves it", async () => {
5
+ const path = process.env.COMMHUB_DB!;
6
+ expect(typeof path).toBe("string");
7
+ const old = new Database(path);
8
+ old.exec(`CREATE TABLE users (
9
+ user_id TEXT PRIMARY KEY, username TEXT UNIQUE NOT NULL, password_hash TEXT NOT NULL,
10
+ email TEXT, display_name TEXT, role TEXT DEFAULT 'user',
11
+ created_at TEXT NOT NULL DEFAULT (datetime('now')),
12
+ updated_at TEXT NOT NULL DEFAULT (datetime('now'))
13
+ ); INSERT INTO users (user_id, username, password_hash) VALUES ('old_user', 'old_user', 'test-only-hash');`);
14
+ old.close();
15
+ const { db } = await import("./db.js");
16
+ expect(db.get<any>("SELECT avatar_url, password_hash FROM users WHERE user_id = ?1", "old_user"))
17
+ .toEqual({ avatar_url: null, password_hash: "test-only-hash" });
18
+ db.run("UPDATE users SET avatar_url = ?1 WHERE user_id = ?2", ["/avatars/avatar-03.webp", "old_user"]);
19
+ const child = Bun.spawn([process.execPath, "-e", `
20
+ const { db } = await import('./src/db.ts');
21
+ const row = db.get('SELECT avatar_url, password_hash FROM users WHERE user_id = ?1', 'old_user');
22
+ if (row.avatar_url !== '/avatars/avatar-03.webp' || row.password_hash !== 'test-only-hash') process.exit(1);
23
+ `], { cwd: new URL("..", import.meta.url).pathname, env: process.env, stdout: "pipe", stderr: "pipe" });
24
+ expect(await child.exited).toBe(0);
25
+ });