@sleep2agi/commhub-server 0.9.0-preview.226 → 0.9.0-preview.228

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@sleep2agi/commhub-server",
3
- "version": "0.9.0-preview.226",
3
+ "version": "0.9.0-preview.228",
4
4
  "description": "CommHub Server — AI Agent communication hub with MCP protocol, multi-network isolation, user auth, and MCP tools (17 collaboration-core + node/provider ops tools; authoritative list: docs-site/docs/api/mcp-tools.md).",
5
5
  "type": "module",
6
6
  "main": "src/index.ts",
@@ -12,7 +12,7 @@
12
12
  // 判据:写一个允许清单的默认值之前,先写出它的**最松值**。
13
13
  // 这里最松值不是空(空 = 谁都不许 = 最严),而是 `*`。所以空绝不能被读成「用默认」。
14
14
  import { describe, expect, test } from "bun:test";
15
- import { normalizeOrigin, parseCorsOrigins } from "./server.js";
15
+ import { assertCorsOrigins, normalizeOrigin, parseCorsOrigins } from "./server.js";
16
16
 
17
17
  describe("parseCorsOrigins: 未设 / 设空 / 设值 三态", () => {
18
18
  test("未设 ⇒ 开发默认(localhost 两个端口)", () => {
@@ -53,4 +53,21 @@ describe("parseCorsOrigins: 未设 / 设空 / 设值 三态", () => {
53
53
  // 去重:同一 origin 的两种写法只留一条
54
54
  expect(parseCorsOrigins("https://a.example,https://a.example:443/")).toEqual(["https://a.example"]);
55
55
  });
56
+
57
+ // 2026-10-31 —— **配错了就别起服务**(「解除武装 ≠ 修好」):
58
+ // 丢弃非法条目只是让服务更安全,但配置仍然是错的,而且没有任何信号。
59
+ // 这里钉的是启动期断言:非法条目必须**抛**,且把非法条目逐个点出来。
60
+ test("startup assertion refuses invalid CORS entries and names them", () => {
61
+ expect(() => assertCorsOrigins(undefined)).not.toThrow(); // 未设 ⇒ 默认,合法
62
+ expect(() => assertCorsOrigins("")).not.toThrow(); // 设空 ⇒ 空清单,合法(更严)
63
+ expect(() => assertCorsOrigins("https://a.example,http://b.example:8080")).not.toThrow();
64
+ // 每个非法形态都要抛,并且错误信息里能看到那个值
65
+ for (const bad of ["*", "a.example", "ftp://a.example", "https://a.example, *"]) {
66
+ let msg = "";
67
+ try { assertCorsOrigins(bad); } catch (e) { msg = String((e as Error).message); }
68
+ expect(msg).toContain("不是 http(s) origin");
69
+ expect(msg.length).toBeGreaterThan(20);
70
+ }
71
+ expect(() => assertCorsOrigins("*")).toThrow(/\*/);
72
+ });
56
73
  });
@@ -1135,6 +1135,19 @@ describe("#473 anonymous /health — watchdog contract intact, no topology leak"
1135
1135
  }
1136
1136
  });
1137
1137
 
1138
+ // 2026-10-31 —— **单一出口**(外部复核 (a):
1139
+ // 「一个必须在『所有字段写完之后』执行的变换,只有收敛到单一出口才可靠 —— 多出口 × 惰性 = 迟早漏」)。
1140
+ // 这条门只看一件事:`shape(...)` 在源码里只能出现在**一处**。
1141
+ // 出现第二处 ⇒ 说明又有一个 return 各自记得调它 ⇒ 下一个人加第三个出口时就会裸奔。
1142
+ test("the anonymous projection is applied at exactly one call site", async () => {
1143
+ const { readFileSync } = await import("node:fs");
1144
+ const src = readFileSync(new URL("./server.ts", import.meta.url), "utf8");
1145
+ const calls = [...src.matchAll(/Response\.json\(\s*shape\(/g)];
1146
+ expect(calls.length).toBe(1);
1147
+ // 定义处也算一处(`const shape = ...`),但它不是 Response.json 包裹,所以上面的正则不会数到
1148
+ expect((src.match(/const shape = /g) || []).length).toBe(1);
1149
+ });
1150
+
1138
1151
  test("no dead entries: every allow-listed key is actually served to anonymous callers", async () => {
1139
1152
  const { PUBLIC_HEALTH_KEYS } = await import("./server.js");
1140
1153
  const plain = await (await fetch(`${BASE}/health`)).json() as any;
package/src/server.ts CHANGED
@@ -979,9 +979,35 @@ export function parseCorsOrigins(raw: string | undefined): string[] {
979
979
  return out;
980
980
  }
981
981
 
982
- const CORS_ORIGINS = parseCorsOrigins(
983
- "COMMHUB_CORS_ORIGINS" in process.env ? (process.env.COMMHUB_CORS_ORIGINS ?? "") : undefined,
984
- );
982
+ /**
983
+ * 2026-10-31 —— **「解除武装」不等于「修好」**(外部复核:
984
+ * 「『断掉』和『修好』都是正确的下一步,但它们解决的不是同一个问题」)。
985
+ *
986
+ * 现在非法条目会被**丢弃**(等于不放行)——那是解除武装:更安全,但**配置仍然是错的**,
987
+ * 而且没有任何信号,运维只会看到「前端突然 CORS 不过」。
988
+ * ⇒ 启动时直接拒绝:非法条目 = 配错了,别让它带着错的清单跑起来。
989
+ * (生产未设置这个变量,走 localhost 默认,不受影响。)
990
+ */
991
+ export function assertCorsOrigins(raw: string | undefined): void {
992
+ if (raw === undefined) return;
993
+ const bad: string[] = [];
994
+ for (const part of raw.split(",")) {
995
+ const trimmed = part.trim();
996
+ if (!trimmed) continue;
997
+ if (!normalizeOrigin(trimmed)) bad.push(trimmed);
998
+ }
999
+ if (bad.length) {
1000
+ throw new Error(
1001
+ `COMMHUB_CORS_ORIGINS 里有 ${bad.length} 个条目不是 http(s) origin:${bad.join(", ")}\n` +
1002
+ " ⇒ 它们会被丢弃(等于不放行)。配错了就别起服务:改成 https://host[:port] 的形式再启动。",
1003
+ );
1004
+ }
1005
+ }
1006
+ const CORS_ORIGINS = (() => {
1007
+ const raw = "COMMHUB_CORS_ORIGINS" in process.env ? (process.env.COMMHUB_CORS_ORIGINS ?? "") : undefined;
1008
+ assertCorsOrigins(raw);
1009
+ return parseCorsOrigins(raw);
1010
+ })();
985
1011
 
986
1012
  function corsHeaders(req: Request): Record<string, string> {
987
1013
  const origin = req.headers.get("Origin") || "";