@sleep2agi/commhub-server 0.9.0-preview.22 → 0.9.0-preview.221

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (407) hide show
  1. package/README.md +129 -9
  2. package/bin/commhub.ts +93 -9
  3. package/package.json +7 -7
  4. package/src/ack-create-request-transport.test.ts +182 -0
  5. package/src/ack-create-request.test.ts +50 -7
  6. package/src/admin-delete-network-http.test.ts +228 -0
  7. package/src/admin-networks-http.test.ts +88 -0
  8. package/src/adoption-candidates-http.test.ts +137 -0
  9. package/src/adoption-candidates.ts +158 -0
  10. package/src/agent-access-batch.test.ts +210 -0
  11. package/src/agent-access.ts +487 -0
  12. package/src/agent-acl-groups-http.test.ts +247 -0
  13. package/src/agent-acl-http.test.ts +659 -0
  14. package/src/agent-acl-slice3-http.test.ts +654 -0
  15. package/src/agent-department-http.test.ts +215 -0
  16. package/src/agent-groups-perf.test.ts +223 -0
  17. package/src/agent-notice.ts +48 -0
  18. package/src/agent-team-whoami-http.test.ts +98 -0
  19. package/src/agent-teams-http.test.ts +330 -0
  20. package/src/agent-teams.ts +244 -0
  21. package/src/alias-baseline-2571.test.ts +162 -0
  22. package/src/alias-baseline.ts +113 -0
  23. package/src/alias-filter.test.ts +72 -0
  24. package/src/alias-filter.ts +42 -0
  25. package/src/api-host-supervisors-can-create-nodes.test.ts +350 -0
  26. package/src/api-host-supervisors-fallback.test.ts +6 -7
  27. package/src/api-host-supervisors-runtime-readiness.test.ts +195 -0
  28. package/src/api-nodes-shape.test.ts +120 -13
  29. package/src/auth-password-change-cli-tokens-http.test.ts +423 -0
  30. package/src/auth-sessions-http.test.ts +250 -0
  31. package/src/auth-validate.test.ts +5 -1
  32. package/src/auth-weak-password-login.test.ts +176 -0
  33. package/src/auth.ts +609 -51
  34. package/src/avatar-validate.test.ts +52 -2
  35. package/src/avatar-validate.ts +35 -1
  36. package/src/backfill-node-ids-2664.test.ts +128 -0
  37. package/src/binding-generation-http.test.ts +121 -0
  38. package/src/blocked-exit-on-reply.test.ts +122 -0
  39. package/src/broadcast-fanout-2721.test.ts +149 -0
  40. package/src/broadcast-fanout.ts +117 -0
  41. package/src/chain-attempt-dedup.test.ts +447 -0
  42. package/src/clone-node.test.ts +248 -0
  43. package/src/clone-node.ts +289 -0
  44. package/src/codex-config-flags.ts +77 -0
  45. package/src/codex-fork-contract.ts +23 -0
  46. package/src/codex-fork-migration.test.ts +38 -0
  47. package/src/commhub-bin-args.test.ts +85 -0
  48. package/src/config-apply-validate.test.ts +188 -1
  49. package/src/config-apply-validate.ts +222 -3
  50. package/src/cors-origins.test.ts +56 -0
  51. package/src/create-node-blocked-gate.test.ts +356 -0
  52. package/src/create-node-network-id.test.ts +91 -0
  53. package/src/create-node-tool-schema.test.ts +49 -0
  54. package/src/create-node-unicode-name.test.ts +120 -0
  55. package/src/create-node-validate.test.ts +199 -7
  56. package/src/create-node-validate.ts +232 -15
  57. package/src/create-node-workdir.test.ts +289 -0
  58. package/src/create-node.ts +88 -23
  59. package/src/daemon-provider-snapshots.test.ts +421 -0
  60. package/src/daemon-provider-snapshots.ts +327 -0
  61. package/src/daemon-token-owner-http.test.ts +236 -0
  62. package/src/dashboard-slash-routing-http.test.ts +109 -0
  63. package/src/db-adapter-guard.test.ts +148 -0
  64. package/src/db-adapter-translate.test.ts +128 -0
  65. package/src/db-adapter.ts +377 -91
  66. package/src/db-timestamp.test.ts +38 -0
  67. package/src/db-timestamp.ts +15 -0
  68. package/src/db.ts +1296 -153
  69. package/src/delivered-without-push.test.ts +140 -0
  70. package/src/department-groups-http.test.ts +209 -0
  71. package/src/department-groups-sync-http.test.ts +328 -0
  72. package/src/department-groups.ts +434 -0
  73. package/src/department-heads-http.test.ts +350 -0
  74. package/src/department-heads.ts +226 -0
  75. package/src/departments-agent-count.test.ts +132 -0
  76. package/src/departments-http.test.ts +185 -0
  77. package/src/departments-mcp.test.ts +128 -0
  78. package/src/departments.ts +318 -0
  79. package/src/desktop-message-seam.test.ts +150 -0
  80. package/src/desktop-message.test.ts +368 -0
  81. package/src/dm-file-scope-http.test.ts +178 -0
  82. package/src/empty-node-sweeper.test.ts +104 -0
  83. package/src/empty-node-sweeper.ts +88 -0
  84. package/src/env-transport-gate-http.test.ts +240 -0
  85. package/src/env-transport-gate.ts +80 -0
  86. package/src/env-transport-policy.ts +56 -0
  87. package/src/etag-of.test.ts +57 -0
  88. package/src/event-loop-lag.test.ts +180 -0
  89. package/src/event-loop-lag.ts +201 -0
  90. package/src/ext-token-shared.test.ts +60 -0
  91. package/src/ext-validation-regression.test.ts +131 -0
  92. package/src/external-schedule-edits-http.test.ts +321 -0
  93. package/src/external-schedule-edits-timestamps.test.ts +64 -0
  94. package/src/external-schedule-edits.ts +327 -0
  95. package/src/file-download-authz-dev-open.test.ts +135 -0
  96. package/src/file-download-authz.test.ts +404 -0
  97. package/src/file-download-date-bucket.test.ts +436 -0
  98. package/src/file-network-scope-dev-open.test.ts +97 -0
  99. package/src/file-network-scope.test.ts +732 -0
  100. package/src/group-membership-events-http.test.ts +264 -0
  101. package/src/group-messages-http.test.ts +482 -0
  102. package/src/group-messages.ts +297 -0
  103. package/src/health-anon-readers.ts +59 -0
  104. package/src/health-host-disk-2756.test.ts +71 -0
  105. package/src/health-redaction.test.ts +1583 -2
  106. package/src/host-supervisor-identity-http.test.ts +152 -0
  107. package/src/host-supervisor-identity.ts +92 -0
  108. package/src/host-supervisors-daemon-version.test.ts +137 -0
  109. package/src/http-gzip.test.ts +94 -0
  110. package/src/http-gzip.ts +112 -0
  111. package/src/hub-catalog-read-http.test.ts +266 -0
  112. package/src/hub-provider-config.test.ts +156 -0
  113. package/src/hub-provider-config.ts +124 -0
  114. package/src/hub-timestamp.test.ts +38 -0
  115. package/src/hub-timestamp.ts +27 -0
  116. package/src/human-dm.ts +215 -0
  117. package/src/human-inbox.ts +42 -0
  118. package/src/inbox-caller.ts +49 -0
  119. package/src/inbox-count-sse.test.ts +310 -0
  120. package/src/inbox-count.ts +29 -0
  121. package/src/index.ts +6 -2
  122. package/src/license-state.test.ts +56 -0
  123. package/src/license-state.ts +48 -0
  124. package/src/list-host-supervisors.test.ts +15 -4
  125. package/src/mcp-context-cost-http.test.ts +127 -0
  126. package/src/mcp-inflight.test.ts +92 -0
  127. package/src/mcp-inflight.ts +38 -0
  128. package/src/mcp-projects-events-http.test.ts +165 -0
  129. package/src/mcp-route-label-http.test.ts +120 -0
  130. package/src/mcp-write-network-resolution.test.ts +435 -0
  131. package/src/member-audit-network-id-http.test.ts +93 -0
  132. package/src/member-presence-http.test.ts +210 -0
  133. package/src/messages-ack-by-agent-http.test.ts +142 -0
  134. package/src/migrate-sqlite-to-pg.test.ts +47 -0
  135. package/src/migrate-sqlite-to-pg.ts +263 -0
  136. package/src/model-auth-notify-http.test.ts +181 -0
  137. package/src/model-auth-notify.ts +116 -0
  138. package/src/network-name-http.test.ts +75 -0
  139. package/src/network-rules-http.test.ts +169 -0
  140. package/src/network-rules.ts +129 -0
  141. package/src/network-scope.ts +276 -0
  142. package/src/network-token-membership-http.test.ts +139 -0
  143. package/src/node-alias-control.ts +12 -0
  144. package/src/node-attrs-validate.ts +88 -0
  145. package/src/node-attrs.test.ts +258 -0
  146. package/src/node-caller-identity-http.test.ts +1091 -0
  147. package/src/node-create-request-status-http.test.ts +105 -0
  148. package/src/node-daemon-bindings.test.ts +132 -0
  149. package/src/node-daemon-bindings.ts +135 -0
  150. package/src/node-failure-alert.test.ts +150 -0
  151. package/src/node-failure-alert.ts +177 -0
  152. package/src/node-files-transport.test.ts +344 -0
  153. package/src/node-health-codex-login.test.ts +120 -0
  154. package/src/node-health-dispatch-http.test.ts +335 -0
  155. package/src/node-health-guard.ts +121 -0
  156. package/src/node-health-passthrough.test.ts +115 -0
  157. package/src/node-health-store.ts +101 -0
  158. package/src/node-id-alias.test.ts +190 -0
  159. package/src/node-identity-conflict-http.test.ts +269 -0
  160. package/src/node-identity-conflict.ts +142 -0
  161. package/src/node-identity-mismatch.test.ts +74 -0
  162. package/src/node-in-flight-tasks.ts +31 -0
  163. package/src/node-lifecycle-controllable.test.ts +64 -0
  164. package/src/node-lifecycle-controllable.ts +53 -0
  165. package/src/node-lifecycle-read-http.test.ts +250 -0
  166. package/src/node-lifecycle-read.ts +124 -0
  167. package/src/node-logs-transport.test.ts +263 -0
  168. package/src/node-peer-allowlist.test.ts +114 -0
  169. package/src/node-permissions-http.test.ts +728 -0
  170. package/src/node-permissions.ts +494 -0
  171. package/src/node-request-retention.test.ts +281 -0
  172. package/src/node-request-retention.ts +120 -0
  173. package/src/node-secret-rest-http.test.ts +190 -0
  174. package/src/node-serviceability.test.ts +86 -0
  175. package/src/node-serviceability.ts +124 -0
  176. package/src/node-session-control-http.test.ts +310 -0
  177. package/src/node-session-control.ts +258 -0
  178. package/src/node-skills-transport.test.ts +212 -0
  179. package/src/node-token-identity.ts +35 -0
  180. package/src/node-token-ownership.ts +51 -0
  181. package/src/node-token-privilege-http.test.ts +158 -0
  182. package/src/not-found-api-http.test.ts +67 -0
  183. package/src/observer-avatar-http.test.ts +102 -9
  184. package/src/observer-push.test.ts +76 -0
  185. package/src/opencode-catalog-report-http.test.ts +139 -0
  186. package/src/opencode-v2-catalog.test.ts +268 -0
  187. package/src/opencode-v2-catalog.ts +356 -0
  188. package/src/package-version-consistency.test.ts +25 -0
  189. package/src/parent-source-marker.test.ts +50 -0
  190. package/src/password-network-tokens.ts +25 -0
  191. package/src/peer-reply-atomic.test.ts +457 -0
  192. package/src/peer-reply-capability.test.ts +70 -0
  193. package/src/pg-worker.ts +87 -0
  194. package/src/poll-pacing.test.ts +74 -0
  195. package/src/poll-pacing.ts +123 -0
  196. package/src/project-dir-warn-clear-http.test.ts +132 -0
  197. package/src/project-viewer-can-http.test.ts +116 -0
  198. package/src/push.test.ts +20 -10
  199. package/src/push.ts +382 -9
  200. package/src/redact-tokens.test.ts +86 -0
  201. package/src/redact-tokens.ts +43 -0
  202. package/src/rejection-counters.test.ts +72 -0
  203. package/src/rejection-counters.ts +173 -0
  204. package/src/rename.ts +38 -10
  205. package/src/reply-target-derivation.test.ts +96 -0
  206. package/src/report-status-handover-capabilities-http.test.ts +124 -0
  207. package/src/report-status-host-schema.test.ts +235 -0
  208. package/src/report-status-resume-id-handover.test.ts +184 -0
  209. package/src/report-status-secret-keys.test.ts +140 -0
  210. package/src/require-explicit-test-db.ts +9 -0
  211. package/src/requirement-due-reminders-http.test.ts +620 -0
  212. package/src/requirement-due-reminders.ts +416 -0
  213. package/src/requirement-events-http.test.ts +295 -0
  214. package/src/requirement-events.test.ts +45 -0
  215. package/src/requirement-events.ts +144 -0
  216. package/src/requirement-notify.ts +165 -0
  217. package/src/requirement-participant-notify-http.test.ts +309 -0
  218. package/src/requirement-tag-ops-http.test.ts +425 -0
  219. package/src/requirement-tag-tree-http.test.ts +275 -0
  220. package/src/requirement-tag-tree.ts +127 -0
  221. package/src/requirement-tags.ts +102 -0
  222. package/src/requirements-abandoned-http.test.ts +236 -0
  223. package/src/requirements-comment-http.test.ts +167 -0
  224. package/src/requirements-completed-at-migration.test.ts +70 -0
  225. package/src/requirements-errors-mcp-http.test.ts +164 -0
  226. package/src/requirements-errors.ts +158 -0
  227. package/src/requirements-etag-http.test.ts +91 -0
  228. package/src/requirements-http.test.ts +709 -0
  229. package/src/requirements-last-event-http.test.ts +349 -0
  230. package/src/requirements-list-mcp-slim-http.test.ts +155 -0
  231. package/src/requirements-list-slim-http.test.ts +324 -0
  232. package/src/requirements-mcp.test.ts +163 -0
  233. package/src/requirements-migrate.ts +283 -0
  234. package/src/requirements-owner-strict-mcp-http.test.ts +145 -0
  235. package/src/requirements-people-http.test.ts +114 -0
  236. package/src/requirements-people-mcp-http.test.ts +231 -0
  237. package/src/requirements-people.ts +196 -0
  238. package/src/requirements-priority-lowest.test.ts +114 -0
  239. package/src/requirements-projects-network-echo.test.ts +57 -0
  240. package/src/requirements-projects-parent-http.test.ts +123 -0
  241. package/src/requirements-search-http.test.ts +182 -0
  242. package/src/requirements-search.test.ts +32 -0
  243. package/src/requirements-search.ts +145 -0
  244. package/src/requirements-seq-http.test.ts +193 -0
  245. package/src/requirements-seq-migration.test.ts +63 -0
  246. package/src/requirements-start-date.test.ts +125 -0
  247. package/src/requirements-stats-http.test.ts +357 -0
  248. package/src/requirements-stats.ts +195 -0
  249. package/src/requirements-status-participants-http.test.ts +222 -0
  250. package/src/requirements-upgrade-e2e.test.ts +126 -0
  251. package/src/requirements-upgrade-migration.test.ts +98 -0
  252. package/src/requirements.ts +2057 -0
  253. package/src/resolve-port.test.ts +57 -0
  254. package/src/resolve-port.ts +44 -0
  255. package/src/rest-alias-network-fallback-http.test.ts +123 -0
  256. package/src/rest-alias-network-fallback.test.ts +60 -0
  257. package/src/rest-alias-network-fallback.ts +65 -0
  258. package/src/rest-explicit-columns-http.test.ts +266 -0
  259. package/src/rest-identity.test.ts +130 -0
  260. package/src/rest-identity.ts +141 -0
  261. package/src/rest-projections.ts +72 -0
  262. package/src/rest-read-network-real-chain.test.ts +97 -0
  263. package/src/rest-write-network-resolution.test.ts +133 -0
  264. package/src/restart-readiness-http.test.ts +121 -0
  265. package/src/restricted-files.ts +76 -0
  266. package/src/retention-first-sweep-quiet.test.ts +31 -0
  267. package/src/retention.test.ts +100 -40
  268. package/src/retention.ts +423 -104
  269. package/src/route-callers-http.test.ts +120 -0
  270. package/src/route-timing.test.ts +218 -0
  271. package/src/route-timing.ts +262 -0
  272. package/src/rules-file-duplicate-alias.test.ts +234 -0
  273. package/src/rules-file-session-target.test.ts +207 -0
  274. package/src/rules-file-transport.test.ts +237 -0
  275. package/src/runtime-label.test.ts +22 -0
  276. package/src/runtime-label.ts +21 -0
  277. package/src/runtime-readiness.ts +90 -0
  278. package/src/schedule-agent-mcp-http.test.ts +432 -0
  279. package/src/schedule-agent.ts +252 -0
  280. package/src/schedule-starved.test.ts +92 -0
  281. package/src/schedule-starved.ts +114 -0
  282. package/src/scheduled-backoff-http.test.ts +193 -0
  283. package/src/scheduled-backoff.ts +64 -0
  284. package/src/scheduled-doorbell-nodeless-session.test.ts +134 -0
  285. package/src/scheduled-failure-backoff-2622.test.ts +145 -0
  286. package/src/scheduled-failure-code.test.ts +73 -0
  287. package/src/scheduled-failure-code.ts +105 -0
  288. package/src/scheduled-failures-http.test.ts +279 -0
  289. package/src/scheduled-failures.ts +425 -0
  290. package/src/scheduled-noprogress-backoff-2622.test.ts +163 -0
  291. package/src/scheduled-offline-backoff-probe.test.ts +56 -0
  292. package/src/scheduled-offline.test.ts +131 -0
  293. package/src/scheduled-offline.ts +66 -0
  294. package/src/scheduled-outcome-guidance-http.test.ts +139 -0
  295. package/src/scheduled-outcome-guidance.ts +9 -0
  296. package/src/scheduled-reply-unread-http.test.ts +212 -0
  297. package/src/scheduled-requirement-wake-http.test.ts +279 -0
  298. package/src/scheduled-requirement-wake.ts +125 -0
  299. package/src/scheduled-run-terminal.test.ts +268 -0
  300. package/src/scheduled-skip-blocking-task.test.ts +120 -0
  301. package/src/scheduled-skip-path-backoff-2622.test.ts +98 -0
  302. package/src/scheduled-stuck-http.test.ts +316 -0
  303. package/src/scheduled-stuck-notice-cap.test.ts +80 -0
  304. package/src/scheduled-stuck.ts +219 -0
  305. package/src/scheduled-tasks-http.test.ts +679 -0
  306. package/src/scheduled-tasks.ts +959 -0
  307. package/src/scheduled-work-outcome-http.test.ts +154 -0
  308. package/src/scheduled-work-outcome.ts +50 -0
  309. package/src/scoped-secrets.ts +141 -0
  310. package/src/send-dedup-request-id.test.ts +229 -0
  311. package/src/send-reply-agent-warning.test.ts +202 -0
  312. package/src/send-reply-alias-optional.test.ts +131 -0
  313. package/src/send-reply-attachments.test.ts +458 -0
  314. package/src/send_dedup.test.ts +54 -0
  315. package/src/send_dedup.ts +52 -6
  316. package/src/serve-error.test.ts +73 -0
  317. package/src/serve-error.ts +56 -0
  318. package/src/server.ts +4945 -338
  319. package/src/session-task-on-dispatch.ts +14 -0
  320. package/src/session-token-ownership-http.test.ts +122 -0
  321. package/src/shared/codex-inventory.ts +41 -0
  322. package/src/shared/daemon-provider-login.ts +31 -0
  323. package/src/shared/daemon-provider-snapshot.ts +52 -0
  324. package/src/shared/external-schedule-contract.ts +60 -0
  325. package/src/shared/node-name.test.ts +62 -0
  326. package/src/shared/node-name.ts +161 -0
  327. package/src/shared/probe-host-allowlist-drift.test.ts +45 -0
  328. package/src/shared/provider-application.ts +29 -0
  329. package/src/shared/provider-collection.ts +14 -0
  330. package/src/shared/provider-initialization.ts +8 -0
  331. package/src/shared/reserved-env-drift.test.ts +10 -0
  332. package/src/shared/scoped-secret-contract.ts +5 -0
  333. package/src/shared/task-content-limit-drift.test.ts +28 -0
  334. package/src/shared/task-content-limit.ts +25 -0
  335. package/src/side-thread-command-transport.test.ts +312 -0
  336. package/src/side-thread-command-transport.ts +318 -0
  337. package/src/side-thread-http-integration.test.ts +233 -0
  338. package/src/side-thread-http.ts +504 -0
  339. package/src/side-thread-production.test.ts +72 -0
  340. package/src/side-thread-production.ts +118 -0
  341. package/src/side-thread.test.ts +1067 -0
  342. package/src/side-thread.ts +2499 -0
  343. package/src/skillhub-http.test.ts +142 -0
  344. package/src/sqlite-close-checkpoint.test.ts +78 -0
  345. package/src/start-node.test.ts +264 -0
  346. package/src/status-alias-filter-http.test.ts +106 -0
  347. package/src/status-alias-resolver-http.test.ts +163 -0
  348. package/src/status-alias-resolver.ts +19 -0
  349. package/src/status-node-id-filter-http.test.ts +161 -0
  350. package/src/status-read-cache-http.test.ts +229 -0
  351. package/src/status-read-cache.ts +129 -0
  352. package/src/stop-delete-node.test.ts +567 -1
  353. package/src/task-access-http.test.ts +402 -0
  354. package/src/task-access.ts +420 -0
  355. package/src/task-activity.ts +60 -0
  356. package/src/task-auth-origin-http.test.ts +93 -0
  357. package/src/task-auth-origin.test.ts +24 -0
  358. package/src/task-auth-origin.ts +7 -0
  359. package/src/task-consumption.test.ts +490 -0
  360. package/src/task-diagnostic-http.test.ts +149 -0
  361. package/src/task-diagnostic.test.ts +115 -0
  362. package/src/task-diagnostic.ts +118 -0
  363. package/src/task-expiry-notice-http.test.ts +287 -0
  364. package/src/task-expiry-notice.ts +315 -0
  365. package/src/task-idempotency-mcp.test.ts +142 -0
  366. package/src/task-idempotency.test.ts +76 -0
  367. package/src/task-idempotency.ts +81 -0
  368. package/src/task-late-replies.ts +54 -0
  369. package/src/task-late-reply-http.test.ts +227 -0
  370. package/src/task-lifecycle-watcher-busy.test.ts +114 -0
  371. package/src/task-lifecycle-watcher.test.ts +204 -0
  372. package/src/task-lifecycle-watcher.ts +109 -0
  373. package/src/task-network-resolution-http.test.ts +140 -0
  374. package/src/task-offline-delivery-2668.test.ts +119 -0
  375. package/src/task-offline-delivery.ts +81 -0
  376. package/src/task-orphan-http.test.ts +287 -0
  377. package/src/task-orphan.ts +119 -0
  378. package/src/task-queue-ahead-http.test.ts +309 -0
  379. package/src/task-queue-ahead-scale.test.ts +236 -0
  380. package/src/task-queue-ahead.ts +186 -0
  381. package/src/task-rejection-log-http.test.ts +160 -0
  382. package/src/task-rejection-log.ts +58 -0
  383. package/src/task-sender-http.test.ts +143 -0
  384. package/src/task-stale-open-http.test.ts +292 -0
  385. package/src/task-stale-open.ts +103 -0
  386. package/src/tasks-pagination-http.test.ts +141 -0
  387. package/src/team-rules-status-http.test.ts +90 -0
  388. package/src/team-rules-status.test.ts +59 -0
  389. package/src/team-rules-status.ts +72 -0
  390. package/src/tmux-allowlist.test.ts +48 -0
  391. package/src/tool-audience-http.test.ts +230 -0
  392. package/src/tool-audience.ts +127 -0
  393. package/src/tools-list-json-schema.test.ts +94 -0
  394. package/src/tools.ts +4320 -413
  395. package/src/upload-early-reject-guard.test.ts +155 -0
  396. package/src/uploads-http.test.ts +86 -7
  397. package/src/uploads.ts +103 -6
  398. package/src/user-avatar-http.test.ts +74 -0
  399. package/src/user-avatar-image.ts +160 -0
  400. package/src/user-avatar-migration.test.ts +25 -0
  401. package/src/user-avatar-upload-http.test.ts +348 -0
  402. package/src/user-inbox-by-agent-http.test.ts +161 -0
  403. package/src/user-inbox-netid-notnull.test.ts +122 -0
  404. package/src/user-inbox-read-http.test.ts +223 -0
  405. package/src/user-inbox-schema.test.ts +54 -0
  406. package/src/version-stats.test.ts +66 -0
  407. package/src/version-stats.ts +109 -0
@@ -0,0 +1,276 @@
1
+ // Network-scope resolution shared by BOTH transports.
2
+ //
3
+ // #517: REST (server.ts) and MCP (tools.ts) each carried their own copy of
4
+ // the "which network does this caller write to" rule. REST grew a
5
+ // single-network fallback (POST /api/task); MCP never did — so a utok_
6
+ // caller could read everything but write nothing, with a misleading
7
+ // permission_denied. Extracted here (same pattern as lifecycle-guard.ts)
8
+ // so the rule has exactly ONE implementation. If you change write-scope
9
+ // semantics, this module is the only place — do NOT re-inline a copy in
10
+ // server.ts or tools.ts.
11
+
12
+ import { db } from "./db.js";
13
+ import { getUserNetworkRole } from "./auth.js";
14
+ import { isAgentRestricted, restrictedNetworkIds, usernameIsAgentAlias, visibleAgents } from "./agent-access.js";
15
+
16
+ export type RestNetworkScope = {
17
+ networkId: string | null;
18
+ networkIds: string[] | null;
19
+ denied?: string;
20
+ // 多用户 Agent 权限:scope 里哪些网络对这个调用者是「只看授权 Agent」的。
21
+ // addNetworkScope 对这些网络 fail-closed(整网不返回);要按授权放行的路径
22
+ // 显式改用 addAgentNetworkScope / addOwnTrafficScope,人类数据用 addHumanNetworkScope。
23
+ agentRestriction?: { userId: string; username: string; networkIds: string[] };
24
+ };
25
+
26
+ type ScopeAuthCtx = { userId: string; networkId: string | null; username?: string | null };
27
+
28
+ function usernameOf(userId: string, known?: string | null): string {
29
+ if (known) return known;
30
+ return db.get<{ username: string }>("SELECT username FROM users WHERE user_id = ?1", userId)?.username ?? "";
31
+ }
32
+
33
+ function withAgentRestriction(scope: RestNetworkScope, authCtx: ScopeAuthCtx): RestNetworkScope {
34
+ const inScope = scope.networkId ? [scope.networkId] : (scope.networkIds ?? []);
35
+ if (inScope.length === 0) return scope;
36
+ const restricted = restrictedNetworkIds(authCtx.userId).filter((id) => inScope.includes(id));
37
+ if (restricted.length === 0) return scope;
38
+ return { ...scope, agentRestriction: { userId: authCtx.userId, username: usernameOf(authCtx.userId, authCtx.username), networkIds: restricted } };
39
+ }
40
+
41
+ export function getUserNetworkIds(userId: string): string[] {
42
+ // JOIN networks: deleteNetwork historically left network_members rows
43
+ // behind (fixed alongside PR #519, but legacy DBs still carry strays).
44
+ // A ghost membership must neither make a single-network user look
45
+ // ambiguous nor let the write fallback resolve INTO a deleted network.
46
+ return db.all<{ network_id: string }>(
47
+ `SELECT m.network_id FROM network_members m
48
+ JOIN networks n ON n.network_id = m.network_id
49
+ WHERE m.user_id = ?1`,
50
+ userId
51
+ ).map((row) => row.network_id);
52
+ }
53
+
54
+ export function resolveRestNetworkScope(requested: string | null, authCtx: ScopeAuthCtx | null, isAdmin: boolean): RestNetworkScope {
55
+ // Legacy global token or open dev mode keeps the old global behavior.
56
+ if (!authCtx) return { networkId: requested || null, networkIds: null };
57
+
58
+ // Network tokens are forcibly scoped to their bound network.
59
+ if (authCtx.networkId) return { networkId: authCtx.networkId, networkIds: null };
60
+
61
+ // System admins may intentionally inspect all networks.
62
+ if (isAdmin) return { networkId: requested || null, networkIds: null };
63
+
64
+ if (requested) {
65
+ const role = getUserNetworkRole(authCtx.userId, requested);
66
+ if (!role) return { networkId: null, networkIds: [], denied: "access denied to requested network" };
67
+ return withAgentRestriction({ networkId: requested, networkIds: null }, authCtx);
68
+ }
69
+
70
+ return withAgentRestriction({ networkId: null, networkIds: getUserNetworkIds(authCtx.userId) }, authCtx);
71
+ }
72
+
73
+ function unrestrictedNetworks(scope: RestNetworkScope): string[] | null {
74
+ const excluded = scope.agentRestriction?.networkIds ?? [];
75
+ if (scope.networkId) return excluded.includes(scope.networkId) ? [] : [scope.networkId];
76
+ if (scope.networkIds) return scope.networkIds.filter((id) => !excluded.includes(id));
77
+ return null;
78
+ }
79
+
80
+ function placeholders(params: any[], values: string[]): string {
81
+ const start = params.length;
82
+ params.push(...values);
83
+ return values.map((_, i) => `?${start + i + 1}`).join(", ");
84
+ }
85
+
86
+ /**
87
+ * 默认的网络作用域 —— 对受限成员的受限网络 **fail-closed**:整网不返回。
88
+ * 没被逐条审过、不知道按授权怎么放行的查询,默认走这里,受限成员什么都看不到。
89
+ */
90
+ export function addNetworkScope(sql: string, params: any[], scope: RestNetworkScope, column = "network_id"): string {
91
+ if (!scope.agentRestriction) return addHumanNetworkScope(sql, params, scope, column);
92
+ const allowed = unrestrictedNetworks(scope) ?? [];
93
+ if (allowed.length === 0) return `${sql} AND 1=0`;
94
+ return `${sql} AND ${column} IN (${placeholders(params, allowed)})`;
95
+ }
96
+
97
+ /**
98
+ * 人类数据(自己的私信收件箱、需求看板、项目、网络成员)的作用域:受限成员照常看得到
99
+ * 自己所在网络。只给已确认不含 Agent 内容的查询用。
100
+ */
101
+ export function addHumanNetworkScope(sql: string, params: any[], scope: RestNetworkScope, column = "network_id"): string {
102
+ if (scope.networkId) {
103
+ sql += ` AND ${column} = ?${params.length + 1}`;
104
+ params.push(scope.networkId);
105
+ } else if (scope.networkIds) {
106
+ if (scope.networkIds.length === 0) {
107
+ sql += " AND 1=0";
108
+ } else {
109
+ const placeholders = scope.networkIds.map((_, i) => `?${params.length + i + 1}`).join(", ");
110
+ sql += ` AND ${column} IN (${placeholders})`;
111
+ params.push(...scope.networkIds);
112
+ }
113
+ }
114
+ return sql;
115
+ }
116
+
117
+ type AgentColumns = { network?: string; alias: string; nodeId?: string };
118
+
119
+ /**
120
+ * Agent 行(sessions / nodes)的作用域:不受限的网络整网放行;受限网络只放行授权的 Agent。
121
+ * mode="message" 时只放行 can_message 的授权。
122
+ */
123
+ export function addAgentNetworkScope(sql: string, params: any[], scope: RestNetworkScope, cols: AgentColumns, mode: "see" | "message" = "see"): string {
124
+ const restriction = scope.agentRestriction;
125
+ if (!restriction) return addHumanNetworkScope(sql, params, scope, cols.network ?? "network_id");
126
+ const net = cols.network ?? "network_id";
127
+ const parts: string[] = [];
128
+ const allowed = unrestrictedNetworks(scope) ?? [];
129
+ if (allowed.length) parts.push(`${net} IN (${placeholders(params, allowed)})`);
130
+ for (const networkId of restriction.networkIds) {
131
+ const visible = visibleAgents(restriction.userId, networkId);
132
+ const aliases = mode === "message" ? visible.messageAliases : visible.aliases;
133
+ const nodeIds = mode === "message" ? visible.messageNodeIds : visible.nodeIds;
134
+ const conds: string[] = [];
135
+ if (aliases.length) conds.push(`${cols.alias} IN (${placeholders(params, aliases)})`);
136
+ if (cols.nodeId && nodeIds.length) conds.push(`${cols.nodeId} IN (${placeholders(params, nodeIds)})`);
137
+ if (conds.length === 0) continue;
138
+ parts.push(`(${net} = ${placeholders(params, [networkId])} AND (${conds.join(" OR ")}))`);
139
+ }
140
+ return parts.length ? `${sql} AND (${parts.join(" OR ")})` : `${sql} AND 1=0`;
141
+ }
142
+
143
+ type TrafficColumns = { network?: string; from: string; to: string; fromNodeId?: string; toNodeId?: string };
144
+
145
+ /**
146
+ * 任务 / inbox 这类「谁发给谁」的行:受限网络里只放行**自己**与**授权 Agent**之间的往来
147
+ * (from=自己 且 to=授权 Agent,或反过来)。别人(包括 owner)和同一个 Agent 的对话看不到。
148
+ */
149
+ export function addOwnTrafficScope(sql: string, params: any[], scope: RestNetworkScope, cols: TrafficColumns): string {
150
+ const restriction = scope.agentRestriction;
151
+ if (!restriction) return addHumanNetworkScope(sql, params, scope, cols.network ?? "network_id");
152
+ const net = cols.network ?? "network_id";
153
+ const parts: string[] = [];
154
+ const allowed = unrestrictedNetworks(scope) ?? [];
155
+ if (allowed.length) parts.push(`${net} IN (${placeholders(params, allowed)})`);
156
+ if (restriction.username) {
157
+ for (const networkId of restriction.networkIds) {
158
+ // 用户名与本网络某个 Agent 的 alias 撞名时(入网时拦过,但 Agent 之后注册的 alias 拦不住),
159
+ // 「发给我的」无法和「发给那个 Agent 的」区分开 —— 这个网络的往来一律不放行。
160
+ if (usernameIsAgentAlias(networkId, restriction.username)) continue;
161
+ const visible = visibleAgents(restriction.userId, networkId);
162
+ // 先判空再生成占位符:side() 会往 params 里推值,推了又丢弃会让参数个数对不上。
163
+ const useNodeIds = !!(cols.fromNodeId && cols.toNodeId) && visible.nodeIds.length > 0;
164
+ if (visible.aliases.length === 0 && !useNodeIds) continue;
165
+ const side = (aliasCol: string, nodeCol?: string): string | null => {
166
+ const conds: string[] = [];
167
+ if (visible.aliases.length) conds.push(`${aliasCol} IN (${placeholders(params, visible.aliases)})`);
168
+ if (nodeCol && useNodeIds) conds.push(`${nodeCol} IN (${placeholders(params, visible.nodeIds)})`);
169
+ return conds.length ? `(${conds.join(" OR ")})` : null;
170
+ };
171
+ const toAgent = side(cols.to, cols.toNodeId)!;
172
+ const fromAgent = side(cols.from, cols.fromNodeId)!;
173
+ const me = placeholders(params, [restriction.username]);
174
+ parts.push(`(${net} = ${placeholders(params, [networkId])} AND ((${cols.from} = ${me} AND ${toAgent}) OR (${cols.to} = ${me} AND ${fromAgent})))`);
175
+ }
176
+ }
177
+ return parts.length ? `${sql} AND (${parts.join(" OR ")})` : `${sql} AND 1=0`;
178
+ }
179
+
180
+ /**
181
+ * #563 —— 「不同用户看到同一个节点,消息应该是一样的」。
182
+ *
183
+ * tasks 行(聊天窗口的历史 + 回复都在这张表)的作用域:受限网络里,只要成员**看得见** Agent N
184
+ * (直接授权或经组授权,见 visibleAgents),N 的整条时间线他都看得见 —— 不论是谁发的(包括 owner、
185
+ * 其他成员),也包括授权之前的历史。时间线 = 一端是看得见的 Agent,另一端是:
186
+ * - 另一个看得见的 Agent;或
187
+ * - 不是本网络任何 Agent 的名字(人类用户 / scheduler / hub 这类系统发送方)。
188
+ * 另一端是**看不见**的 Agent 的行一律不放行(不借时间线暴露看不见的节点)。
189
+ * 没有任何授权的成员什么都看不到(与之前一样);能不能**发**仍由 canMessageAgent 管。
190
+ * Agent 主动发给某个人的 user_inbox 私信不在这张表里,不受影响。
191
+ *
192
+ * 与 addOwnTrafficScope 的区别只在受限网络:那里只放行「自己 ↔ 授权 Agent」。inbox(投递队列)
193
+ * 仍走 addOwnTrafficScope。用户名与 Agent alias 撞名的网络照旧整网不放行(fail-closed)。
194
+ */
195
+ export function addAgentTimelineScope(sql: string, params: any[], scope: RestNetworkScope, cols: Required<Pick<TrafficColumns, "from" | "to" | "fromNodeId" | "toNodeId">> & { network?: string }): string {
196
+ const restriction = scope.agentRestriction;
197
+ if (!restriction) return addHumanNetworkScope(sql, params, scope, cols.network ?? "network_id");
198
+ const net = cols.network ?? "network_id";
199
+ const parts: string[] = [];
200
+ const allowed = unrestrictedNetworks(scope) ?? [];
201
+ if (allowed.length) parts.push(`${net} IN (${placeholders(params, allowed)})`);
202
+ if (restriction.username) {
203
+ for (const networkId of restriction.networkIds) {
204
+ if (usernameIsAgentAlias(networkId, restriction.username)) continue;
205
+ const visible = visibleAgents(restriction.userId, networkId);
206
+ // 先判空再推参数:推了又不用的绑定参数会让 PG 报错(SQLite 会忽略)。
207
+ if (visible.aliases.length === 0 && visible.nodeIds.length === 0) continue;
208
+ const aliasIn = visible.aliases.length ? placeholders(params, visible.aliases) : null;
209
+ const nodeIn = visible.nodeIds.length ? placeholders(params, visible.nodeIds) : null;
210
+ const netP = placeholders(params, [networkId]);
211
+ const isVisible = (aliasCol: string, nodeCol: string): string => {
212
+ const conds: string[] = [];
213
+ if (aliasIn) conds.push(`${aliasCol} IN (${aliasIn})`);
214
+ if (nodeIn) conds.push(`${nodeCol} IN (${nodeIn})`);
215
+ return `(${conds.join(" OR ")})`;
216
+ };
217
+ // 「不是本网络任何 Agent」:没有 node_id,且 alias 不在本网络的 sessions / nodes 里。
218
+ const notAnAgent = (aliasCol: string, nodeCol: string): string =>
219
+ `(${nodeCol} IS NULL`
220
+ + ` AND ${aliasCol} NOT IN (SELECT alias FROM sessions WHERE network_id = ${netP} AND alias IS NOT NULL)`
221
+ + ` AND ${aliasCol} NOT IN (SELECT alias FROM nodes WHERE network_id = ${netP} AND alias IS NOT NULL))`;
222
+ const toV = isVisible(cols.to, cols.toNodeId);
223
+ const fromV = isVisible(cols.from, cols.fromNodeId);
224
+ const otherFrom = `(${fromV} OR ${notAnAgent(cols.from, cols.fromNodeId)})`;
225
+ const otherTo = `(${toV} OR ${notAnAgent(cols.to, cols.toNodeId)})`;
226
+ parts.push(`(${net} = ${netP} AND ((${toV} AND ${otherFrom}) OR (${fromV} AND ${otherTo})))`);
227
+ }
228
+ }
229
+ return parts.length ? `${sql} AND (${parts.join(" OR ")})` : `${sql} AND 1=0`;
230
+ }
231
+
232
+ export function singleNetworkId(scope: RestNetworkScope): string | null {
233
+ if (scope.networkId) return scope.networkId;
234
+ if (scope.networkIds?.length === 1) return scope.networkIds[0];
235
+ return null;
236
+ }
237
+
238
+ /**
239
+ * Resolve one unambiguous network for a REST write.
240
+ *
241
+ * Admin read scope is intentionally global (`networkIds=null`), so it cannot
242
+ * by itself express that an admin happens to have exactly one membership.
243
+ * Writes must not inherit that ambiguity: use the sole real membership when
244
+ * one exists, and keep requiring an explicit network for zero or 2+.
245
+ */
246
+ export function resolveRestWriteNetworkId(
247
+ scope: RestNetworkScope,
248
+ authCtx: { userId: string; networkId: string | null } | null,
249
+ isAdmin: boolean,
250
+ ): string | null {
251
+ const scoped = singleNetworkId(scope);
252
+ if (scoped) return scoped;
253
+ if (!authCtx || !isAdmin) return null;
254
+ const memberships = getUserNetworkIds(authCtx.userId);
255
+ return memberships.length === 1 ? memberships[0] : null;
256
+ }
257
+
258
+ /**
259
+ * 能不能往这个网络写**面向 Agent 的东西**(派任务、改节点、排程……)。
260
+ * 受限成员在受限网络里恒为 false(fail-closed);给授权 Agent 发任务的路径另用
261
+ * canMessageAgent 单独放行,人类侧的写入(私信、需求、上传)用 canRestWriteNetworkAsHuman。
262
+ */
263
+ export function canRestWriteNetwork(authCtx: { userId: string; networkId: string | null } | null, networkId: string | null, isAdmin: boolean): boolean {
264
+ if (!canRestWriteNetworkAsHuman(authCtx, networkId, isAdmin)) return false;
265
+ if (!authCtx || isAdmin || !networkId) return true;
266
+ return !isAgentRestricted(authCtx.userId, networkId);
267
+ }
268
+
269
+ /** 旧的「成员且不是 viewer」判据,不看 Agent 授权。只给人类侧写入用。 */
270
+ export function canRestWriteNetworkAsHuman(authCtx: { userId: string; networkId: string | null } | null, networkId: string | null, isAdmin: boolean): boolean {
271
+ if (!authCtx) return true; // legacy global token or open dev mode
272
+ if (isAdmin) return true;
273
+ if (!networkId) return false;
274
+ const role = getUserNetworkRole(authCtx.userId, networkId);
275
+ return !!role && role !== "viewer";
276
+ }
@@ -0,0 +1,139 @@
1
+ // #488 —— 网络令牌只在它的用户还是这个网络的成员时有效(RFC-041 §1)。
2
+ //
3
+ // 以前:被移出网络的成员留下的节点令牌照样解析 —— MCP 每个工具都拒(not a member),REST 读却拿得到整个网络
4
+ // (GET /api/status 返回全部名册)。受限成员的令牌本来就在 resolveToken 被拒,但 401 只写 unauthorized。
5
+ //
6
+ // 钉住:
7
+ // (i) 非成员的网络令牌:每个 REST GET 与 /mcp 都 401,reason = not_network_member(下面 GETS 是逐条探过的读路径)。
8
+ // (ii) removeNetworkMember 在同一个事务里吊销这个人在该网络的令牌(revoked_at),别的网络的令牌不动。
9
+ // (iii) 受限成员的节点令牌:401 带 reason = node_owner_restricted + hint;不认识的令牌只有 unauthorized。
10
+ // 成员的节点令牌、不受限的情况与以前完全一样。
11
+ //
12
+ // 跑法:cd server && COMMHUB_DB=/tmp/x.db bun test src/network-token-membership-http.test.ts
13
+ // PG:COMMHUB_TEST_PG_URL=… COMMHUB_PG_EXPERIMENTAL=1(tests/test2123-hub-postgres-ladder 里注册)
14
+ import { afterAll, beforeAll, describe, expect, test } from "bun:test";
15
+ import { addNetworkMember, createNetworkTokenForNode, createNetwork, register, removeNetworkMember } from "./auth.js";
16
+ import { replaceAgentGrants } from "./agent-access.js";
17
+ import { db } from "./db.js";
18
+
19
+ const activeDbPath = process.env.COMMHUB_DB ?? (process.env.COMMHUB_TEST_PG_URL ? "postgres" : undefined);
20
+ if (!activeDbPath) throw new Error("network-token-membership requires COMMHUB_DB (or COMMHUB_TEST_PG_URL) before module import");
21
+
22
+ const stamp = Date.now();
23
+ const PW = "TokenMember123!";
24
+ const OTHER = `other-${stamp}`; // 网络里别人的 Agent —— 出现在响应里 = 读到了不该读的
25
+ let server: any, base = "", net = "", net2 = "", taskId = "";
26
+ const tok: Record<string, string> = {};
27
+ const ids: Record<string, string> = {};
28
+
29
+ const get = (t: string, path: string) =>
30
+ fetch(`${base}${path}`, { headers: { Authorization: `Bearer ${t}` } })
31
+ .then(async (r) => ({ status: r.status, text: await r.text() }));
32
+ const mcp = (t: string, name: string, args: Record<string, unknown>) =>
33
+ fetch(`${base}/mcp`, {
34
+ method: "POST",
35
+ headers: { Authorization: `Bearer ${t}`, "Content-Type": "application/json", Accept: "application/json, text/event-stream" },
36
+ body: JSON.stringify({ jsonrpc: "2.0", id: 1, method: "tools/call", params: { name, arguments: args } }),
37
+ }).then(async (r) => ({ status: r.status, text: await r.text() }));
38
+
39
+ // 拿网络令牌能调的 REST GET 读路径(server.ts 里 restScope 之后的每个 GET,加上之前自己解析令牌的 /api/auth/me、/api/networks)。
40
+ const GETS = () => [
41
+ "/api/auth/me", "/api/networks",
42
+ `/api/status?network_id=${net}`, `/api/status?light=1`, "/api/servers", "/api/server/unknown/health", "/api/server/unknown/agents",
43
+ "/api/messages", "/api/messages?scope=user", "/api/stats", "/api/stats/sse", "/api/stats/routes", "/api/server-logs", "/api/audit-log",
44
+ "/api/task_events", "/api/nodes", `/api/nodes/${ids.other}/config`, "/api/node-create-requests", "/api/host-supervisors",
45
+ `/api/task/${taskId}`, "/api/tasks", "/api/completions", "/api/dm/threads", "/api/requirements",
46
+ ];
47
+
48
+ beforeAll(async () => {
49
+ const boss = register(`tm_boss_${stamp}`, PW); net = boss.network_id!; ids.boss = boss.user!.user_id; tok.bossUser = boss.token!;
50
+ for (const k of ["exm", "rem", "mia", "stay"]) {
51
+ const u = register(`tm_${k}_${stamp}`, PW); ids[k] = u.user!.user_id;
52
+ expect(addNetworkMember(net, ids[k], "member", ids.boss, { agentAccess: "all" }).ok).toBe(true);
53
+ const t = createNetworkTokenForNode(ids[k], net, `${k}-${stamp}`, `n_tm_${k}_${stamp}`);
54
+ expect(t.ok).toBe(true);
55
+ tok[k] = t.token!;
56
+ }
57
+ // rem 在另一个网络里也有令牌 —— 被移出 net 时那枚不能被一起吊销。
58
+ const n2 = createNetwork(ids.rem, `tm-net2-${stamp}`); expect(n2.ok).toBe(true); net2 = n2.network_id!;
59
+ const t2 = createNetworkTokenForNode(ids.rem, net2, `rem2-${stamp}`, `n_tm_rem2_${stamp}`); tok.rem2 = t2.token!;
60
+
61
+ ids.other = `n_tm_other_${stamp}`;
62
+ db.run("INSERT INTO nodes (node_id, node_name, alias, network_id, owner_user_id) VALUES (?1, ?2, ?2, ?3, ?4)", [ids.other, OTHER, net, ids.boss]);
63
+ db.run("INSERT INTO sessions (resume_id, alias, status, node_id, network_id, server) VALUES (?1, ?2, 'idle', ?3, ?4, 'unknown')", [`r_${ids.other}`, OTHER, ids.other, net]);
64
+ taskId = `task_tm_${stamp}`;
65
+ db.run("INSERT INTO tasks (task_id, from_name, to_name, to_node_id, content, status, network_id) VALUES (?1, 'boss', ?2, ?3, 'secret plan', 'pending', ?4)", [taskId, OTHER, ids.other, net]);
66
+
67
+ // exm:老数据 —— 成员行没了,令牌还在(移出前的版本不吊销)。rem:走真实的 removeNetworkMember。
68
+ db.run("DELETE FROM network_members WHERE network_id = ?1 AND user_id = ?2", [net, ids.exm]);
69
+ expect(removeNetworkMember(net, ids.rem).ok).toBe(true);
70
+ // mia:铸完令牌后被收窄成只看授权的 Agent。
71
+ expect(replaceAgentGrants({ networkId: net, userId: ids.mia, grants: [], agentAccess: "granted", actorUserId: ids.boss }).ok).toBe(true);
72
+
73
+ const mod: any = await import("./server.js");
74
+ server = mod.bootServer({ port: 0, hostname: "127.0.0.1" });
75
+ base = `http://127.0.0.1:${server.port}`;
76
+ }, 60_000);
77
+ afterAll(() => { server?.stop?.(true); });
78
+
79
+ describe("#488 (i) a network token whose user left the network", () => {
80
+ test("every REST GET read is 401 not_network_member and leaks nothing", async () => {
81
+ const leaks: string[] = [];
82
+ for (const path of GETS()) {
83
+ const r = await get(tok.exm, path);
84
+ if (r.status !== 401 || r.text.includes(OTHER) || r.text.includes("secret plan")) leaks.push(`${path} → ${r.status}`);
85
+ else expect(JSON.parse(r.text).reason).toBe("not_network_member");
86
+ }
87
+ expect(leaks).toEqual([]);
88
+ });
89
+
90
+ test("/mcp is 401 too, with the reason", async () => {
91
+ const r = await mcp(tok.exm, "get_all_status", {});
92
+ expect(r.status).toBe(401);
93
+ expect(JSON.parse(r.text).reason).toBe("not_network_member");
94
+ expect(JSON.parse(r.text).hint).toContain("no longer a member");
95
+ });
96
+ });
97
+
98
+ describe("#488 (ii) removeNetworkMember revokes the member's tokens for that network", () => {
99
+ test("revoked_at is set for that network only, and the token is rejected", async () => {
100
+ const rows = db.all<{ network_id: string; revoked_at: string | null }>("SELECT network_id, revoked_at FROM api_tokens WHERE user_id = ?1 AND network_id IS NOT NULL", ids.rem);
101
+ expect(rows.filter((r) => r.network_id === net).length).toBeGreaterThan(0);
102
+ expect(rows.filter((r) => r.network_id === net).every((r) => !!r.revoked_at)).toBe(true);
103
+ expect(rows.filter((r) => r.network_id === net2).every((r) => !r.revoked_at)).toBe(true);
104
+ expect((await get(tok.rem, `/api/status?network_id=${net}`)).status).toBe(401);
105
+ expect((await get(tok.rem2, "/api/status")).status).toBe(200);
106
+ });
107
+ });
108
+
109
+ describe("#488 (iii) a restricted owner's node token says why it is refused", () => {
110
+ test("401 with reason node_owner_restricted + hint on REST and /mcp", async () => {
111
+ for (const r of [await get(tok.mia, "/api/status"), await mcp(tok.mia, "report_status", { resume_id: "r", alias: `mia-${stamp}`, status: "idle" })]) {
112
+ expect(r.status).toBe(401);
113
+ const body = JSON.parse(r.text);
114
+ expect(body.reason).toBe("node_owner_restricted");
115
+ expect(body.hint).toContain("Agent access");
116
+ }
117
+ const me = await get(tok.mia, "/api/auth/me");
118
+ expect(me.status).toBe(401);
119
+ expect(JSON.parse(me.text).reason).toBe("node_owner_restricted");
120
+ });
121
+
122
+ test("an unknown token gets no reason (nothing to explain, nothing leaked)", async () => {
123
+ const r = await get("ntok_doesnotexist", "/api/status");
124
+ expect(r.status).toBe(401);
125
+ expect(JSON.parse(r.text)).toEqual({ error: "unauthorized" });
126
+ });
127
+ });
128
+
129
+ describe("#488 unchanged for members", () => {
130
+ test("an all-access member's node token reads and heartbeats as before", async () => {
131
+ const st = await get(tok.stay, `/api/status?network_id=${net}`);
132
+ expect(st.status).toBe(200);
133
+ expect(st.text).toContain(OTHER);
134
+ const hb = await mcp(tok.stay, "report_status", { resume_id: `r_stay_${stamp}`, alias: `stay-${stamp}`, status: "idle" });
135
+ expect(hb.status).toBe(200);
136
+ expect(hb.text).toContain('\\"ok\\":true');
137
+ expect((await get(tok.bossUser, `/api/task/${taskId}`)).status).toBe(200);
138
+ });
139
+ });
@@ -0,0 +1,12 @@
1
+ // C0/C1 controls plus Unicode's two dedicated line separators. The latter are
2
+ // not General_Category=Cc, but they still split log/source-prefix lines.
3
+ const CONTROL_CHARACTER = /[\p{Cc}\u2028\u2029]/u;
4
+
5
+ export function aliasControlCharacter(alias: string): string | null {
6
+ return [...alias].find((char) => CONTROL_CHARACTER.test(char)) ?? null;
7
+ }
8
+
9
+ export function describeAliasControlCharacter(char: string): string {
10
+ const codePoint = char.codePointAt(0) ?? 0;
11
+ return `U+${codePoint.toString(16).toUpperCase().padStart(4, "0")}`;
12
+ }
@@ -0,0 +1,88 @@
1
+ // Boundary validation for node DISPLAY attributes (display_name / team /
2
+ // tags). Mirrors `avatar-validate.ts` in spirit: this is the only place
3
+ // that decides what a client is allowed to store, and it trusts nothing.
4
+ //
5
+ // Two different postures on purpose:
6
+ //
7
+ // display_name / team — SCALAR fields the user typed. A wrong TYPE here
8
+ // is a client bug, so it is REJECTED (400) rather than coerced: silently
9
+ // turning `{}` into "[object Object]" would persist garbage the user
10
+ // never typed and can't explain.
11
+ //
12
+ // tags — a LIST. Same reasoning as the `channels` patch in tools.ts: the
13
+ // wire contract wants junk dropped instead of failing the whole request,
14
+ // so one fat-fingered entry from a dashboard doesn't 400 the save. Each
15
+ // element is narrowed independently (typeof → trim → length cap →
16
+ // dedup), so nothing non-string can reach the database.
17
+
18
+ /** Max stored length of display_name / team. */
19
+ export const MAX_ATTR_LEN = 120;
20
+ /** Max stored length of a single tag. */
21
+ export const MAX_TAG_LEN = 64;
22
+ /** Max number of tags kept per node. */
23
+ export const MAX_TAGS = 16;
24
+
25
+ export type ScalarAttrResult =
26
+ | { ok: true; value: string | null }
27
+ | { ok: false; reason: string };
28
+
29
+ /**
30
+ * Narrow an optional scalar display attribute.
31
+ * undefined → not part of this patch (caller leaves the column alone)
32
+ * null / "" → explicit clear
33
+ * non-string → rejected (never coerced)
34
+ * over-long → rejected (the user should see it, not silently lose text)
35
+ */
36
+ export function validateScalarAttr(raw: unknown, field: string): ScalarAttrResult {
37
+ if (raw === undefined) return { ok: true, value: null };
38
+ if (raw === null) return { ok: true, value: null };
39
+ if (typeof raw !== "string") {
40
+ return { ok: false, reason: `${field} must be a string or null` };
41
+ }
42
+ const trimmed = raw.trim();
43
+ if (trimmed.length === 0) return { ok: true, value: null };
44
+ if (trimmed.length > MAX_ATTR_LEN) {
45
+ return { ok: false, reason: `${field} exceeds ${MAX_ATTR_LEN} characters` };
46
+ }
47
+ // Control characters would corrupt any log line / table cell that renders
48
+ // the value; strip rather than reject (they are almost always a paste
49
+ // artefact, not user intent).
50
+ // eslint-disable-next-line no-control-regex
51
+ const clean = trimmed.replace(/[\u0000-\u001f\u007f]+/g, " ").trim();
52
+ return { ok: true, value: clean.length > 0 ? clean : null };
53
+ }
54
+
55
+ /**
56
+ * Narrow an untrusted tags array. NEVER throws, never rejects the request:
57
+ * unusable entries are dropped. Returns the canonical list to store.
58
+ */
59
+ export function narrowTags(raw: unknown): string[] {
60
+ if (!Array.isArray(raw)) return [];
61
+ const out: string[] = [];
62
+ const seen = new Set<string>();
63
+ for (const item of raw) {
64
+ if (typeof item !== "string") continue; // numbers/objects/arrays/null
65
+ // eslint-disable-next-line no-control-regex
66
+ const t = item.replace(/[\u0000-\u001f\u007f]+/g, " ").trim();
67
+ if (t.length === 0) continue;
68
+ if (t.length > MAX_TAG_LEN) continue; // absurd entry — drop, don't truncate
69
+ const key = t.toLowerCase(); // case-fold for dedup, keep first spelling
70
+ if (seen.has(key)) continue;
71
+ seen.add(key);
72
+ out.push(t);
73
+ if (out.length >= MAX_TAGS) break;
74
+ }
75
+ return out;
76
+ }
77
+
78
+ /** Parse the stored tags column back into an array. Storage is JSON text;
79
+ * anything unparseable (hand-edited DB, older format) reads as empty so a
80
+ * dashboard can always `.map()` without a guard. */
81
+ export function parseStoredTags(stored: unknown): string[] {
82
+ if (typeof stored !== "string" || stored.length === 0) return [];
83
+ try {
84
+ return narrowTags(JSON.parse(stored));
85
+ } catch {
86
+ return [];
87
+ }
88
+ }