@sleep2agi/commhub-server 0.9.0-preview.151 → 0.9.0-preview.152

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sleep2agi/commhub-server",
-  "version": "0.9.0-preview.151",
+  "version": "0.9.0-preview.152",
   "description": "CommHub Server — AI Agent communication hub with MCP protocol, multi-network isolation, user auth, and MCP tools (17 collaboration-core + node/provider ops tools; authoritative list: docs-site/docs/api/mcp-tools.md).",
   "type": "module",
   "main": "src/index.ts",

package/src/network-rules-http.test.ts

@@ -107,6 +107,16 @@ describe("#993 — network rules storage + CAS write", () => {
     expect(r.body.error).toBe("rules_too_large");
   });
 
+  test("a node token cannot read another network's rules", async () => {
+    // The node token belongs to a hub admin (that is how it was minted), so the
+    // hubAdmin branch alone would have allowed it. A node stays inside its network.
+    const other = register(`nr_net2_${Date.now()}`, "OtherPw123Aa!", undefined, "net2");
+    expect(other.ok).toBe(true);
+    const r = await send(nodeToken, "GET", `/api/networks/${other.network_id}/rules`);
+    expect(r.status).toBe(403);
+    expect(r.body.error).toBe("not_a_member");
+  });
+
   test("a non-member cannot read", async () => {
     const other = register(`nr_other_${Date.now()}`, "OtherPw123Aa!", undefined, "other");
     expect(other.ok).toBe(true);

package/src/server.ts

@@ -1903,6 +1903,12 @@ return Bun.serve({
       const role = getUserNetworkRole(resolved.user.user_id, netId);
       ensureNetworkRulesOnce(db);
       if (req.method === "GET") {
+        // A node token resolves to the human who created it, which may be a hub
+        // admin — that must not turn a node into a reader of *every* network's
+        // rules. A node token is confined to its own network.
+        if (resolved.networkId && resolved.networkId !== netId) {
+          return withCors(req, Response.json({ ok: false, error: "not_a_member" }, { status: 403 }));
+        }
         // Reading is for anyone in the network: the rules are what the nodes obey.
         if (!hubAdmin && !role) return withCors(req, Response.json({ ok: false, error: "not_a_member" }, { status: 403 }));
         return withCors(req, Response.json({ ok: true, rules: readNetworkRules(db, netId) }));