@slates/provider-handler 1.0.0-rc.31 → 1.0.0-rc.32

package/dist/index.cjs

@@ -187,6 +187,14 @@ var mapAction = (_slate, a) => {
     triggerGroupId: a.triggerGroup.key
   };
 };
+var isMappableTrigger = (action) => action.type !== "trigger" || !!action.triggerGroup;
+var getMappableAction = (slate, actionId) => {
+  let action = getAction(slate, actionId);
+  if (!isMappableTrigger(action)) {
+    throw new import_error2.ServiceError((0, import_error2.notFoundError)(`action`, actionId));
+  }
+  return action;
+};
 var getTriggerGroup = (slate, triggerGroupId) => {
   let group = slate.triggerGroups.find((g) => g.key === triggerGroupId);
   if (!group) {
@@ -195,7 +203,7 @@ var getTriggerGroup = (slate, triggerGroupId) => {
   return group;
 };
 var getTriggersForGroup = (slate, triggerGroupId) => slate.actions.filter(
-  (action) => action.type === "trigger" && action.triggerGroup.key === triggerGroupId
+  (action) => action.type === "trigger" && action.triggerGroup?.key === triggerGroupId
 );
 var evaluateTriggerMatches = (slate, triggerGroupId, payload) => getTriggersForGroup(slate, triggerGroupId).filter((trigger) => trigger.matches(payload)).map((trigger) => trigger.key);
 var getWebhookAutoRegistration = (group) => {
@@ -230,8 +238,12 @@ var mapTriggerGroup = (group) => ({
     type: "webhook",
     registration: group.webhook?.manualRegistration ? {
       mode: "manual",
-      userConfigSchema: toJsonSchema(group.webhook.manualRegistration.userConfigSchema),
-      fullConfigSchema: toJsonSchema(group.webhook.manualRegistration.fullConfigSchema)
+      userConfigSchema: toJsonSchema(
+        group.webhook.manualRegistration.userConfigSchema
+      ),
+      fullConfigSchema: toJsonSchema(
+        group.webhook.manualRegistration.fullConfigSchema
+      )
     } : { mode: "auto" }
   }
 });
@@ -557,7 +569,7 @@ var createProviderHandler = (slate, listeners) => (0, import_proto.createSlatesP
         liveInvocation: true
       },
       provider: {
-        triggerGroups: true
+        triggerGroups: (slate.triggerGroups?.length ?? 0) > 0 && (slate.actions ?? []).every(isMappableTrigger)
       }
     }
   }));
@@ -969,6 +981,7 @@ var createProviderHandler = (slate, listeners) => (0, import_proto.createSlatesP
   manager.onRequest("slates/actions.list", async ({ params }) => {
     getContextBasic();
     let actions = params.includeAdapterActions ? slate.actions : slate.actions.filter((action) => !action.adapter);
+    actions = actions.filter(isMappableTrigger);
     if (!supportsTriggerGroups()) {
       actions = actions.filter((action) => action.type !== "trigger");
     }
@@ -991,7 +1004,7 @@ var createProviderHandler = (slate, listeners) => (0, import_proto.createSlatesP
   });
   manager.onRequest("slates/action.get", async ({ params }) => {
     getContextBasic();
-    let action = getAction(slate, params.actionId);
+    let action = getMappableAction(slate, params.actionId);
     return {
       action: mapAction(slate, action)
     };

package/dist/index.module.js

@@ -165,6 +165,14 @@ var mapAction = (_slate, a) => {
     triggerGroupId: a.triggerGroup.key
   };
 };
+var isMappableTrigger = (action) => action.type !== "trigger" || !!action.triggerGroup;
+var getMappableAction = (slate, actionId) => {
+  let action = getAction(slate, actionId);
+  if (!isMappableTrigger(action)) {
+    throw new ServiceError2(notFoundError(`action`, actionId));
+  }
+  return action;
+};
 var getTriggerGroup = (slate, triggerGroupId) => {
   let group = slate.triggerGroups.find((g) => g.key === triggerGroupId);
   if (!group) {
@@ -173,7 +181,7 @@ var getTriggerGroup = (slate, triggerGroupId) => {
   return group;
 };
 var getTriggersForGroup = (slate, triggerGroupId) => slate.actions.filter(
-  (action) => action.type === "trigger" && action.triggerGroup.key === triggerGroupId
+  (action) => action.type === "trigger" && action.triggerGroup?.key === triggerGroupId
 );
 var evaluateTriggerMatches = (slate, triggerGroupId, payload) => getTriggersForGroup(slate, triggerGroupId).filter((trigger) => trigger.matches(payload)).map((trigger) => trigger.key);
 var getWebhookAutoRegistration = (group) => {
@@ -208,8 +216,12 @@ var mapTriggerGroup = (group) => ({
     type: "webhook",
     registration: group.webhook?.manualRegistration ? {
       mode: "manual",
-      userConfigSchema: toJsonSchema(group.webhook.manualRegistration.userConfigSchema),
-      fullConfigSchema: toJsonSchema(group.webhook.manualRegistration.fullConfigSchema)
+      userConfigSchema: toJsonSchema(
+        group.webhook.manualRegistration.userConfigSchema
+      ),
+      fullConfigSchema: toJsonSchema(
+        group.webhook.manualRegistration.fullConfigSchema
+      )
     } : { mode: "auto" }
   }
 });
@@ -535,7 +547,7 @@ var createProviderHandler = (slate, listeners) => createSlatesProviderProtoHandl
         liveInvocation: true
       },
       provider: {
-        triggerGroups: true
+        triggerGroups: (slate.triggerGroups?.length ?? 0) > 0 && (slate.actions ?? []).every(isMappableTrigger)
       }
     }
   }));
@@ -947,6 +959,7 @@ var createProviderHandler = (slate, listeners) => createSlatesProviderProtoHandl
   manager.onRequest("slates/actions.list", async ({ params }) => {
     getContextBasic();
     let actions = params.includeAdapterActions ? slate.actions : slate.actions.filter((action) => !action.adapter);
+    actions = actions.filter(isMappableTrigger);
     if (!supportsTriggerGroups()) {
       actions = actions.filter((action) => action.type !== "trigger");
     }
@@ -969,7 +982,7 @@ var createProviderHandler = (slate, listeners) => createSlatesProviderProtoHandl
   });
   manager.onRequest("slates/action.get", async ({ params }) => {
     getContextBasic();
-    let action = getAction(slate, params.actionId);
+    let action = getMappableAction(slate, params.actionId);
     return {
       action: mapAction(slate, action)
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@slates/provider-handler",
-  "version": "1.0.0-rc.31",
+  "version": "1.0.0-rc.32",
   "publishConfig": {
     "access": "public"
   },
@@ -43,4 +43,4 @@
     "typescript": "5.8.2",
     "vitest": "^3.1.2"
   }
-}
+}

package/src/index.ts

@@ -19,13 +19,14 @@ import {
 import { PQueue } from './pQueue';
 import {
   evaluateTriggerMatches,
-  getAction,
   getActionWithType,
   getAdapter,
   getAuthMethod,
+  getMappableAction,
   getTriggerGroup,
   getWebhookAutoRegistration,
   getWebhookManualRegistration,
+  isMappableTrigger,
   mapAction,
   mapAdapter,
   mapAuthMethod,
@@ -402,7 +403,9 @@ export let createProviderHandler = <ConfigType extends {}, AuthType extends {}>(
           liveInvocation: true
         },
         provider: {
-          triggerGroups: true
+          triggerGroups:
+            (slate.triggerGroups?.length ?? 0) > 0 &&
+            (slate.actions ?? []).every(isMappableTrigger)
         }
       }
     }));
@@ -868,6 +871,8 @@ export let createProviderHandler = <ConfigType extends {}, AuthType extends {}>(
         ? slate.actions
         : slate.actions.filter(action => !action.adapter);
 
+      actions = actions.filter(isMappableTrigger);
+
       if (!supportsTriggerGroups()) {
         actions = actions.filter(action => action.type !== 'trigger');
       }
@@ -896,7 +901,7 @@ export let createProviderHandler = <ConfigType extends {}, AuthType extends {}>(
 
     manager.onRequest('slates/action.get', async ({ params }) => {
       getContextBasic();
-      let action = getAction(slate, params.actionId);
+      let action = getMappableAction(slate, params.actionId);
 
       return {
         action: mapAction(slate, action)

package/src/spec.test.ts

@@ -0,0 +1,83 @@
+import { isServiceError } from '@lowerdeck/error';
+import { describe, expect, it } from 'vitest';
+import { z } from 'zod';
+import { getMappableAction, getTriggersForGroup, isMappableTrigger, mapAction } from './spec';
+
+let baseAction = {
+  key: 'do_thing',
+  name: 'Do Thing',
+  description: 'desc',
+  instructions: undefined,
+  constraints: undefined,
+  tags: [],
+  metadata: {},
+  scopes: [],
+  authMethods: [],
+  docs: [],
+  adapter: undefined,
+  inputSchema: z.object({}),
+  outputSchema: z.object({})
+};
+
+let toolAction: any = { ...baseAction, type: 'tool', isPublic: false };
+
+let validTriggerGroup = { key: 'my_group', name: 'My Group' };
+let validTrigger: any = {
+  ...baseAction,
+  type: 'trigger',
+  triggerGroup: validTriggerGroup,
+  matches: () => true,
+  map: () => ({})
+};
+
+let incompatibleTrigger: any = { ...baseAction, type: 'trigger', triggerGroup: undefined };
+
+describe('isMappableTrigger', () => {
+  it('is true for tool actions', () => {
+    expect(isMappableTrigger(toolAction)).toBe(true);
+  });
+
+  it('is true for triggers with a trigger group', () => {
+    expect(isMappableTrigger(validTrigger)).toBe(true);
+  });
+
+  it('is false for triggers missing a trigger group', () => {
+    expect(isMappableTrigger(incompatibleTrigger)).toBe(false);
+  });
+});
+
+describe('mapAction', () => {
+  it('maps a well-formed trigger', () => {
+    let mapped = mapAction({} as any, validTrigger);
+    expect(mapped).toMatchObject({ type: 'action.trigger', triggerGroupId: 'my_group' });
+  });
+});
+
+describe('getTriggersForGroup', () => {
+  it('filters out triggers missing a trigger group instead of throwing', () => {
+    let slate = { actions: [toolAction, validTrigger, incompatibleTrigger] } as any;
+
+    expect(getTriggersForGroup(slate, 'my_group')).toEqual([validTrigger]);
+    expect(getTriggersForGroup(slate, 'other_group')).toEqual([]);
+  });
+});
+
+describe('getMappableAction', () => {
+  it('returns tool and well-formed trigger actions', () => {
+    let slate = { actions: [toolAction, validTrigger] } as any;
+
+    expect(getMappableAction(slate, 'do_thing')).toBe(toolAction);
+  });
+
+  it('treats a trigger missing its group as not found instead of crashing', () => {
+    let slate = { actions: [incompatibleTrigger] } as any;
+
+    try {
+      getMappableAction(slate, 'do_thing');
+      expect.unreachable();
+    } catch (e) {
+      expect(isServiceError(e)).toBe(true);
+      expect((e as any).data.status).toBe(404);
+    }
+  });
+});

package/src/spec.ts

@@ -155,6 +155,22 @@ export let mapAction = <ConfigType extends {}, AuthType extends {}>(
   };
 };
 
+export let isMappableTrigger = <ConfigType extends {}, AuthType extends {}>(
+  action: Slate<ConfigType, AuthType>['actions'][number]
+): boolean => action.type !== 'trigger' || !!action.triggerGroup;
+
+export let getMappableAction = <ConfigType extends {}, AuthType extends {}>(
+  slate: Slate<ConfigType, AuthType>,
+  actionId: string
+) => {
+  let action = getAction(slate, actionId);
+  if (!isMappableTrigger(action)) {
+    throw new ServiceError(notFoundError(`action`, actionId));
+  }
+
+  return action;
+};
+
 export let getTriggerGroup = <ConfigType extends {}, AuthType extends {}>(
   slate: Slate<ConfigType, AuthType>,
   triggerGroupId: string
@@ -173,7 +189,7 @@ export let getTriggersForGroup = <ConfigType extends {}, AuthType extends {}>(
 ): SlateTrigger<ConfigType, AuthType, any, any>[] =>
   slate.actions.filter(
     (action): action is SlateTrigger<ConfigType, AuthType, any, any> =>
-      action.type === 'trigger' && action.triggerGroup.key === triggerGroupId
+      action.type === 'trigger' && action.triggerGroup?.key === triggerGroupId
   );
 
 export let evaluateTriggerMatches = <ConfigType extends {}, AuthType extends {}>(
@@ -231,8 +247,12 @@ export let mapTriggerGroup = <ConfigType extends {}, AuthType extends {}>(
           registration: group.webhook?.manualRegistration
             ? {
                 mode: 'manual',
-                userConfigSchema: toJsonSchema(group.webhook.manualRegistration.userConfigSchema),
-                fullConfigSchema: toJsonSchema(group.webhook.manualRegistration.fullConfigSchema)
+                userConfigSchema: toJsonSchema(
+                  group.webhook.manualRegistration.userConfigSchema
+                ),
+                fullConfigSchema: toJsonSchema(
+                  group.webhook.manualRegistration.fullConfigSchema
+                )
               }
             : { mode: 'auto' }
         }