@skyux/core 5.6.0 → 5.7.0

package/bundles/skyux-core.umd.js

@@ -1304,14 +1304,13 @@
         var SkyDockService = /** @class */ (function () {
             function SkyDockService(dynamicComponentService) {
                 this.dynamicComponentService = dynamicComponentService;
-                this._items = [];
             }
             Object.defineProperty(SkyDockService.prototype, "items", {
                 /**
                  * Returns all docked items.
                  */
                 get: function () {
-                    return this._items;
+                    return SkyDockService._items;
                 },
                 enumerable: false,
                 configurable: true
@@ -1323,20 +1322,20 @@
              */
             SkyDockService.prototype.insertComponent = function (component, config) {
                 var _this = this;
-                if (!this.dockRef) {
+                if (!SkyDockService.dockRef) {
                     this.createDock();
                 }
-                var itemRef = this.dockRef.instance.insertComponent(component, config);
+                var itemRef = SkyDockService.dockRef.instance.insertComponent(component, config);
                 var item = new SkyDockItem(itemRef.componentRef.instance, itemRef.stackOrder);
                 item.destroyed.subscribe(function () {
-                    _this.dockRef.instance.removeItem(itemRef);
-                    _this._items.splice(_this._items.indexOf(item), 1);
-                    if (_this._items.length === 0) {
+                    SkyDockService.dockRef.instance.removeItem(itemRef);
+                    SkyDockService._items.splice(SkyDockService._items.indexOf(item), 1);
+                    if (SkyDockService._items.length === 0) {
                         _this.destroyDock();
                     }
                 });
-                this._items.push(item);
-                this._items.sort(sortByStackOrder);
+                SkyDockService._items.push(item);
+                SkyDockService._items.sort(sortByStackOrder);
                 return item;
             };
             /**
@@ -1369,21 +1368,25 @@
                         referenceEl: this.options.referenceEl,
                     };
                 }
-                this.dockRef = this.dynamicComponentService.createComponent(SkyDockComponent, dockOptions);
-                this.dockRef.instance.setOptions(this.options);
+                SkyDockService.dockRef = this.dynamicComponentService.createComponent(SkyDockComponent, dockOptions);
+                SkyDockService.dockRef.instance.setOptions(this.options);
             };
             SkyDockService.prototype.destroyDock = function () {
-                this.dynamicComponentService.removeComponent(this.dockRef);
-                this.dockRef = undefined;
+                this.dynamicComponentService.removeComponent(SkyDockService.dockRef);
+                SkyDockService.dockRef = undefined;
             };
             return SkyDockService;
         }());
+        SkyDockService._items = [];
         SkyDockService.ɵfac = i0__namespace.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "12.2.16", ngImport: i0__namespace, type: SkyDockService, deps: [{ token: SkyDynamicComponentService }], target: i0__namespace.ɵɵFactoryTarget.Injectable });
-        SkyDockService.ɵprov = i0__namespace.ɵɵngDeclareInjectable({ minVersion: "12.0.0", version: "12.2.16", ngImport: i0__namespace, type: SkyDockService, providedIn: 'root' });
+        SkyDockService.ɵprov = i0__namespace.ɵɵngDeclareInjectable({ minVersion: "12.0.0", version: "12.2.16", ngImport: i0__namespace, type: SkyDockService, providedIn: 'any' });
         i0__namespace.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "12.2.16", ngImport: i0__namespace, type: SkyDockService, decorators: [{
                     type: i0.Injectable,
                     args: [{
-                            providedIn: 'root',
+                            // Must be 'any' so that the dock component is created in the context of its module's injector.
+                            // If set to 'root', the component's dependency injections would only be derived from the root
+                            // injector and may loose context if the dock was opened from within a lazy-loaded module.
+                            providedIn: 'any',
                         }]
                 }], ctorParameters: function () { return [{ type: SkyDynamicComponentService }]; } });
 
@@ -1511,6 +1514,7 @@
                 }
                 /*istanbul ignore else */
                 if (window.console) {
+                    // eslint-disable-next-line prefer-spread,prefer-rest-params
                     window.console.warn.apply(window.console, arguments);
                 }
             };
@@ -1668,7 +1672,7 @@
         /**
          * NOTICE: DO NOT MODIFY THIS FILE!
          * The contents of this file were automatically generated by
-         * the 'ng generate @skyux/i18n:lib-resources-module modules/shared/sky-core' schematic.
+         * the 'ng generate @skyux/i18n:lib-resources-module lib/modules/shared/sky-core' schematic.
          * To update this file, simply rerun the command.
          */
         var RESOURCES = {
@@ -1747,7 +1751,7 @@
                 this.iso = 'USD';
                 /**
                  * Indicates whether to shorten numbers to rounded numbers and abbreviation characters
-                 * such as K for thousands, M for millions, B for billions, and T for trillion.
+                 * such as K for thousands, M for millions, B for billions, and T for trillions.
                  */
                 this.truncate = true;
                 /**
@@ -2094,7 +2098,6 @@
         // See: https://github.com/ng-packagr/ng-packagr/issues/641
         // @dynamic
         var SkyNumberFormatUtility = /** @class */ (function () {
-            /* istanbul ignore next */
             function SkyNumberFormatUtility() {
             }
             SkyNumberFormatUtility.formatNumber = function (locale, value, style, digits, currency, currencyAsSymbol, currencySign) {
@@ -2211,6 +2214,7 @@
                 this.storeShortenSymbol(output);
                 var locale = options.locale || this.currentLocale;
                 var digits;
+                var isDecimal;
                 // Checks the string entered for format. Using toLowerCase to ignore case.
                 switch ((_a = options.format) === null || _a === void 0 ? void 0 : _a.toLowerCase()) {
                     // In a case where a decimal value was not shortened and
@@ -2219,7 +2223,7 @@
                     // Note: This will need to be reviewed if we support currencies with
                     // three decimal digits.
                     case 'currency':
-                        var isDecimal = value % 1 !== 0;
+                        isDecimal = value % 1 !== 0;
                         if (options.minDigits) {
                             digits = "1." + options.minDigits + "-" + options.digits;
                         }
@@ -2229,12 +2233,12 @@
                         else {
                             digits = "1.0-" + options.digits;
                         }
+                        output = SkyNumberFormatUtility.formatNumber(locale, parseFloat(output), i1.SkyIntlNumberFormatStyle.Currency, digits, options.iso, 
                         // Angular 5+ needs a string for this parameter, but Angular 4 needs a boolean.
                         // To support both versions we can supply 'symbol' which will evaluate truthy for Angular 4
                         // and the appropriate string value for Angular 5+.
                         // See: https://angular.io/api/common/CurrencyPipe#parameters
-                        var symbolDisplay = 'symbol';
-                        output = SkyNumberFormatUtility.formatNumber(locale, parseFloat(output), i1.SkyIntlNumberFormatStyle.Currency, digits, options.iso, symbolDisplay, options.currencySign);
+                        'symbol', options.currencySign);
                         break;
                     // The following is a catch-all to ensure that if
                     // anything but currency (or a future option) are entered,
@@ -2939,20 +2943,30 @@
             SkyScrollableHostService.prototype.watchScrollableHost = function (elementRef) {
                 var _this = this;
                 var subscribers = [];
-                var mutationObserver;
+                var parentMutationObserver;
+                var documentHiddenElementMutationObserver;
                 return new rxjs.Observable(function (subscriber) {
                     subscribers.push(subscriber);
                     var scrollableHost = _this.findScrollableHost(elementRef.nativeElement);
                     if (subscribers.length === 1) {
-                        mutationObserver = _this.mutationObserverSvc.create(function () {
+                        parentMutationObserver = _this.mutationObserverSvc.create(function () {
                             var newScrollableHost = _this.findScrollableHost(elementRef.nativeElement);
-                            if (newScrollableHost !== scrollableHost) {
+                            if (newScrollableHost !== scrollableHost &&
+                                elementRef.nativeElement.offsetParent) {
                                 scrollableHost = newScrollableHost;
-                                _this.observeForScrollableHostChanges(scrollableHost, mutationObserver);
+                                _this.observeForScrollableHostChanges(scrollableHost, parentMutationObserver);
+                                notifySubscribers(subscribers, scrollableHost);
+                            }
+                        });
+                        _this.observeForScrollableHostChanges(scrollableHost, parentMutationObserver);
+                        documentHiddenElementMutationObserver = _this.mutationObserverSvc.create(function () {
+                            if (!elementRef.nativeElement.offsetParent) {
+                                scrollableHost = undefined;
+                                _this.observeForScrollableHostChanges(scrollableHost, parentMutationObserver);
                                 notifySubscribers(subscribers, scrollableHost);
                             }
                         });
-                        _this.observeForScrollableHostChanges(scrollableHost, mutationObserver);
+                        _this.observeDocumentHiddenElementChanges(documentHiddenElementMutationObserver);
                     }
                     subscriber.next(scrollableHost);
                     subscriber.add(function () {
@@ -2963,7 +2977,8 @@
                             subscribers.splice(subIndex, 1);
                         }
                         if (subscribers.length === 0) {
-                            mutationObserver.disconnect();
+                            documentHiddenElementMutationObserver.disconnect();
+                            parentMutationObserver.disconnect();
                         }
                     });
                 });
@@ -2972,7 +2987,7 @@
              * Returns an observable which emits whenever the element's scrollable host emits a scroll event. The observable will always emit the scroll events from the elements current scrollable host and will update based on any scrollable host changes. The observable will also emit once whenever the scrollable host changes.
              * @param elementRef The element whose scrollable host scroll events are being requested
              * @param completionObservable An observable which alerts the internal observers that they should complete
-             * @returns An observable which emits the scroll events from the given element's scrollable host
+             * @returns An observable which emits when the elements scrollable host is scrolled or is changed
              */
             SkyScrollableHostService.prototype.watchScrollableHostScrollEvents = function (elementRef) {
                 var _this = this;
@@ -2992,11 +3007,13 @@
                             }
                             scrollableHost = newScrollableHost;
                             newScrollableHostObservable = new rxjs.Subject();
-                            scrollEventSubscription = rxjs.fromEvent(newScrollableHost, 'scroll')
-                                .pipe(operators.takeUntil(newScrollableHostObservable))
-                                .subscribe(function () {
-                                notifySubscribers(subscribers);
-                            });
+                            if (newScrollableHost) {
+                                scrollEventSubscription = rxjs.fromEvent(newScrollableHost, 'scroll')
+                                    .pipe(operators.takeUntil(newScrollableHostObservable))
+                                    .subscribe(function () {
+                                    notifySubscribers(subscribers);
+                                });
+                            }
                         });
                     }
                     subscriber.add(function () {
@@ -3039,12 +3056,20 @@
                 }
                 return parent;
             };
+            SkyScrollableHostService.prototype.observeDocumentHiddenElementChanges = function (mutationObserver) {
+                mutationObserver.observe(document.documentElement, {
+                    attributes: true,
+                    attributeFilter: ['class', 'style', 'hidden'],
+                    childList: true,
+                    subtree: true,
+                });
+            };
             SkyScrollableHostService.prototype.observeForScrollableHostChanges = function (element, mutationObserver) {
                 mutationObserver.disconnect();
                 if (element instanceof HTMLElement) {
                     mutationObserver.observe(element, {
                         attributes: true,
-                        attributeFilter: ['class', 'style.overflow', 'style.overflow-y'],
+                        attributeFilter: ['class', 'style'],
                         childList: true,
                         subtree: true,
                     });
@@ -3052,7 +3077,7 @@
                 else {
                     mutationObserver.observe(document.documentElement, {
                         attributes: true,
-                        attributeFilter: ['class', 'style.overflow', 'style.overflow-y'],
+                        attributeFilter: ['class', 'style'],
                         childList: true,
                         subtree: true,
                     });
@@ -3284,25 +3309,22 @@
             };
             SkyViewkeeper.prototype.shouldFixEl = function (boundaryInfo, verticalOffset) {
                 var anchorTop;
-                var doFixEl;
                 if (boundaryInfo.spacerEl) {
                     anchorTop = getOffset(boundaryInfo.spacerEl, this.scrollableHost).top;
                 }
                 else {
                     anchorTop = getOffset(this.el, this.scrollableHost).top;
                 }
-                doFixEl =
-                    boundaryInfo.scrollTop + verticalOffset + this.viewportMarginTop >
-                        anchorTop;
+                var doFixEl = boundaryInfo.scrollTop + verticalOffset + this.viewportMarginTop >
+                    anchorTop;
                 return doFixEl;
             };
             SkyViewkeeper.prototype.getFixedStyles = function (boundaryInfo, verticalOffset) {
-                var elFixedTop;
                 // If the element needs to be fixed, this will calculate its position.  The position
                 // will be 0 (fully visible) unless the user is scrolling the boundary out of view.
                 // In that case, the element should begin to scroll out of view with the
                 // rest of the boundary by setting its top position to a negative value.
-                elFixedTop = Math.min(boundaryInfo.boundaryBottom -
+                var elFixedTop = Math.min(boundaryInfo.boundaryBottom -
                     boundaryInfo.elHeight -
                     boundaryInfo.scrollTop, verticalOffset);
                 var elFixedWidth = boundaryInfo.boundaryEl.getBoundingClientRect().width;