@skyscanner/backpack-web 33.4.0 → 34.0.0-premajor

package/bpk-component-star-rating/index.js

@@ -14,11 +14,11 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- */import BpkStar, { BpkStarNonRtl, STAR_TYPES } from "./src/BpkStar";
-import BpkInteractiveStar from "./src/BpkInteractiveStar";
-import BpkStarRating, { ROUNDING_TYPES } from "./src/BpkStarRating";
+ */import BpkInteractiveStar from "./src/BpkInteractiveStar";
 import BpkInteractiveStarRating from "./src/BpkInteractiveStarRating";
-import withInteractiveStarRatingState from "./src/withInteractiveStarRatingState";
+import BpkStar, { BpkStarNonRtl, STAR_TYPES } from "./src/BpkStar";
+import BpkStarRating, { ROUNDING_TYPES } from "./src/BpkStarRating";
 import themeAttributes from "./src/themeAttributes";
+import withInteractiveStarRatingState from "./src/withInteractiveStarRatingState";
 export { BpkStar, BpkStarNonRtl, STAR_TYPES, ROUNDING_TYPES, BpkInteractiveStar, BpkInteractiveStarRating, withInteractiveStarRatingState, themeAttributes };
 export default BpkStarRating;

package/bpk-component-star-rating/src/BpkInteractiveStar.js

@@ -44,9 +44,13 @@ const BpkInteractiveStar = props => {
     className: buttonClassNames,
     "aria-pressed": selected,
     type: "button",
-    children: /*#__PURE__*/_jsx(BpkStarNonRtl, {
+    children: /*#__PURE__*/_jsx(BpkStarNonRtl
+    // TODO: className to be removed
+    // eslint-disable-next-line @skyscanner/rules/forbid-component-props
+    , {
       className: iconClassNames,
-      type: type,
+      type: type
+      /* $FlowFixMe[cannot-spread-inexact] - inexact rest. See decisions/flowfixme.md */,
       ...rest
     })
   });

package/bpk-component-star-rating/src/BpkInteractiveStarRating.js

@@ -16,8 +16,8 @@
  * limitations under the License.
  */import PropTypes from 'prop-types';
 import { cssModules } from "../../bpk-react-utils";
-import { STAR_TYPES } from "./BpkStar";
 import BpkInteractiveStar from "./BpkInteractiveStar";
+import { STAR_TYPES } from "./BpkStar";
 import STYLES from "./BpkStarRating.module.css";
 import { jsx as _jsx } from "react/jsx-runtime";
 const getClassName = cssModules(STYLES);

package/bpk-component-star-rating/src/BpkStar.js

@@ -15,13 +15,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */import PropTypes from 'prop-types';
-import SmallIcon from "../../bpk-component-icon/sm/star";
+import { withRtlSupport } from "../../bpk-component-icon";
 import LargeIcon from "../../bpk-component-icon/lg/star";
-import OutlineSmallIcon from "../../bpk-component-icon/sm/star-outline";
+import HalfLargeIcon from "../../bpk-component-icon/lg/star-half";
 import OutlineLargeIcon from "../../bpk-component-icon/lg/star-outline";
+import SmallIcon from "../../bpk-component-icon/sm/star";
 import HalfSmallIcon from "../../bpk-component-icon/sm/star-half";
-import HalfLargeIcon from "../../bpk-component-icon/lg/star-half";
-import { withRtlSupport } from "../../bpk-component-icon";
+import OutlineSmallIcon from "../../bpk-component-icon/sm/star-outline";
 import { cssModules } from "../../bpk-react-utils";
 import STYLES from "./BpkStar.module.css";
 import { jsx as _jsx } from "react/jsx-runtime";
@@ -56,23 +56,30 @@ const BpkStar = props => {
       _jsx("span", {
         className: containerClassNames,
         ...rest,
-        children: /*#__PURE__*/_jsx(HalfIcon, {
+        children: /*#__PURE__*/_jsx(HalfIcon
+        // TODO: className to be removed
+        // eslint-disable-next-line @skyscanner/rules/forbid-component-props
+        , {
           className: halfIconClassNames
         })
       })
     );
   }
-  return type === STAR_TYPES.FULL ?
-  /*#__PURE__*/
-  // $FlowFixMe[cannot-spread-inexact] - inexact rest. See decisions/flowfixme.md
-  _jsx(Icon, {
-    className: iconClassNames,
+  return type === STAR_TYPES.FULL ? /*#__PURE__*/_jsx(Icon
+  // TODO: className to be removed
+  // eslint-disable-next-line @skyscanner/rules/forbid-component-props
+  , {
+    className: iconClassNames
+    // $FlowFixMe[cannot-spread-inexact] - inexact rest. See decisions/flowfixme.md
+    ,
     ...rest
-  }) :
-  /*#__PURE__*/
-  // $FlowFixMe[cannot-spread-inexact] - inexact rest. See decisions/flowfixme.md
-  _jsx(OutlineIcon, {
-    className: iconClassNames,
+  }) : /*#__PURE__*/_jsx(OutlineIcon
+  // TODO: className to be removed
+  // eslint-disable-next-line @skyscanner/rules/forbid-component-props
+  , {
+    className: iconClassNames
+    // $FlowFixMe[cannot-spread-inexact] - inexact rest. See decisions/flowfixme.md
+    ,
     ...rest
   });
 };

package/bpk-component-swap-button/src/BpkSwapButton.js

@@ -17,9 +17,10 @@
  */
 
 import { useState } from 'react';
-import { cssModules } from "../../bpk-react-utils";
+
 // @ts-expect-error Untyped import. See `decisions/imports-ts-suppressions.md`.
 import SwapVertical from "../../bpk-component-icon/sm/swap--vertical";
+import { cssModules } from "../../bpk-react-utils";
 import STYLES from "./BpkSwapButton.module.css";
 import { jsx as _jsx } from "react/jsx-runtime";
 const getClassName = cssModules(STYLES);

package/bpk-component-table/index.js

@@ -15,9 +15,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */import BpkTable from "./src/BpkTable";
-import BpkTableHead from "./src/BpkTableHead";
 import BpkTableBody from "./src/BpkTableBody";
-import BpkTableRow from "./src/BpkTableRow";
 import BpkTableCell from "./src/BpkTableCell";
+import BpkTableHead from "./src/BpkTableHead";
 import BpkTableHeadCell from "./src/BpkTableHeadCell";
+import BpkTableRow from "./src/BpkTableRow";
 export { BpkTable, BpkTableHead, BpkTableBody, BpkTableRow, BpkTableCell, BpkTableHeadCell };

package/bpk-component-text/src/BpkText.js

@@ -57,10 +57,15 @@ const BpkText = ({
   ...rest
 }) => {
   const classNames = getClassName('bpk-text', `bpk-text--${textStyle}`, className);
-  return /*#__PURE__*/_jsx(TagName, {
-    className: classNames,
-    ...rest,
-    children: children
-  });
+  return (
+    /*#__PURE__*/
+    // Allowed, TagName is always a dom element.
+    // eslint-disable-next-line @skyscanner/rules/forbid-component-props
+    _jsx(TagName, {
+      className: classNames,
+      ...rest,
+      children: children
+    })
+  );
 };
 export default BpkText;

package/bpk-component-theme-toggle/src/BpkThemeToggle.js

@@ -81,7 +81,10 @@ class BpkThemeToggle extends Component {
     } = this.props;
     return /*#__PURE__*/_jsxs("div", {
       ...rest,
-      children: [/*#__PURE__*/_jsx(BpkLabel, {
+      children: [/*#__PURE__*/_jsx(BpkLabel
+      // TODO: className to be removed
+      // eslint-disable-next-line @skyscanner/rules/forbid-component-props
+      , {
         className: getClassName('bpk-theme-toggle__label'),
         htmlFor: inputId,
         children: "Change theme"

package/bpk-component-theme-toggle/src/updateOnThemeChange.js

@@ -16,8 +16,8 @@
  * limitations under the License.
  */
 
-import { Component } from 'react';
 import PropTypes from 'prop-types';
+import { Component } from 'react';
 import { wrapDisplayName } from "../../bpk-react-utils";
 import { getHtmlElement, THEME_CHANGE_EVENT } from "./utils";
 import { jsx as _jsx } from "react/jsx-runtime";

package/bpk-component-tooltip/src/BpkTooltipPortal.js

@@ -137,7 +137,10 @@ class BpkTooltipPortal extends Component {
         onOpen: this.onOpen,
         onClose: this.closeTooltip,
         style: portalStyle,
-        renderTarget: renderTarget,
+        renderTarget: renderTarget
+        // TODO: className to be removed
+        // eslint-disable-next-line @skyscanner/rules/forbid-component-props
+        ,
         className: classNames.join(' '),
         children: /*#__PURE__*/_jsx(BpkTooltip, {
           padded: padded,

package/bpk-mixins/_chips.scss

@@ -237,4 +237,13 @@
     color: $bpk-text-disabled-day;
     cursor: not-allowed;
   }
+
+  &--icon-only {
+    padding-inline-end: bpk-spacing-md();
+    padding-inline-start: bpk-spacing-md();
+
+    &__leading-accessory-view {
+      @include bpk-margin-trailing(0);
+    }
+  }
 }

package/bpk-react-utils/index.js

@@ -16,16 +16,16 @@
  * limitations under the License.
  */
 
-import wrapDisplayName from "./src/wrapDisplayName";
+import { BpkDialogWrapper } from "./src/BpkDialogWrapper/BpkDialogWrapper";
 import Portal from "./src/Portal";
 import TransitionInitialMount from "./src/TransitionInitialMount";
 import cssModules from "./src/cssModules";
 // @ts-expect-error Untyped import. See `decisions/imports-ts-suppressions.md`.
 import deprecated from "./src/deprecated";
 import { isDeviceIphone, isDeviceIpad, isDeviceIos } from "./src/deviceDetection";
-import withDefaultProps from "./src/withDefaultProps";
 import isRTL from "./src/isRTL";
-import { BpkDialogWrapper } from "./src/BpkDialogWrapper/BpkDialogWrapper";
+import withDefaultProps from "./src/withDefaultProps";
+import wrapDisplayName from "./src/wrapDisplayName";
 export { Portal, TransitionInitialMount, cssModules, deprecated, withDefaultProps, wrapDisplayName, isDeviceIphone, isDeviceIpad, isDeviceIos, isRTL, BpkDialogWrapper };
 export default {
   Portal,

package/bpk-react-utils/src/withDefaultProps.js

@@ -35,7 +35,10 @@ const withDefaultProps = (WrappedComponent, defaultProps) => {
     if (innerClassName) {
       classNames.push(innerClassName);
     }
-    return /*#__PURE__*/_jsx(WrappedComponent, {
+    return /*#__PURE__*/_jsx(WrappedComponent
+    // General HOC difficult/impossible to remove
+    // eslint-disable-next-line @skyscanner/rules/forbid-component-props
+    , {
       className: classNames.join(' '),
       ...defaultRest,
       ...rest,

package/bpk-scrim-utils/src/withScrimmedPortal.js

@@ -18,8 +18,8 @@
 
 import { useState, useEffect } from 'react';
 import { createPortal } from 'react-dom';
-import withScrim from "./withScrim";
 import BpkScrim from "./BpkScrim";
+import withScrim from "./withScrim";
 import { jsx as _jsx } from "react/jsx-runtime";
 const getPortalElement = target => {
   const portalElement = target && typeof target === 'function' ? target() : null;

package/bpk-theming/src/BpkThemeProvider.js

@@ -16,8 +16,8 @@
  * limitations under the License.
  */
 
-import { Component } from 'react';
 import PropTypes from 'prop-types';
+import { Component } from 'react';
 import { jsx as _jsx } from "react/jsx-runtime";
 const uniq = (arr = []) => {
   const seen = {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skyscanner/backpack-web",
-  "version": "33.4.0",
+  "version": "34.0.0-premajor",
   "description": "Backpack Design System web library",
   "repository": {
     "type": "git",
@@ -22,9 +22,11 @@
     "access": "public"
   },
   "dependencies": {
-    "@popperjs/core": "^2.11.5",
+    "@floating-ui/dom": "^1.6.3",
+    "@floating-ui/react": "^0.26.12",
+    "@popperjs/core": "^2.11.8",
     "@react-google-maps/api": "^2.12.0",
-    "@skyscanner/bpk-foundations-web": "^17.5.3",
+    "@skyscanner/bpk-foundations-web": "^17.9.0",
     "@skyscanner/bpk-svgs": "^19.1.0",
     "a11y-focus-scope": "^1.1.3",
     "a11y-focus-store": "^1.0.0",

package/unstable__bpk-mixins/_chips.scss

@@ -237,4 +237,13 @@
     color: tokens.$bpk-text-disabled-day;
     cursor: not-allowed;
   }
+
+  &--icon-only {
+    padding-inline-end: tokens.bpk-spacing-md();
+    padding-inline-start: tokens.bpk-spacing-md();
+
+    &__leading-accessory-view {
+      @include margins.bpk-margin-trailing(0);
+    }
+  }
 }

package/bpk-component-button/src/commonButtonTests.js

@@ -1,133 +0,0 @@
-/*
- * Backpack - Skyscanner's Design System
- *
- * Copyright 2016 Skyscanner Ltd
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import { render } from '@testing-library/react';
-import { jsx as _jsx } from "react/jsx-runtime";
-const commonButtonTests = ButtonToTest => {
-  describe('ButtonToTest', () => {
-    it('should render correctly', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should render correctly with a "href" attribute', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        href: "#",
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should render correctly with a "disabled" attribute', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        disabled: true,
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should render correctly with a "large" attribute', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        large: true,
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should render correctly with an "iconOnly" attribute', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        iconOnly: true,
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should respect the class names entered as a string', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        large: true,
-        className: "custom-class-1 custom-class-2",
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should add only bpk specific classes if className prop is set to empty string', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        large: true,
-        className: "",
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should render correctly with "blank" attribute', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        href: "#",
-        blank: true,
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should render correctly with "rel" attribute', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        href: "#",
-        rel: "rel-attr",
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should render correctly with "blank" and "rel" attributes', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        href: "#",
-        blank: true,
-        rel: "rel-overwrite",
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-    it('should render correctly with "disabled" and "href" attributes', () => {
-      const {
-        asFragment
-      } = render( /*#__PURE__*/_jsx(ButtonToTest, {
-        href: "#",
-        disabled: true,
-        children: "My button"
-      }));
-      expect(asFragment()).toMatchSnapshot();
-    });
-  });
-};
-
-// We export these to reuse them in other tests for buttons.
-// eslint-disable-next-line jest/no-export
-export default commonButtonTests;