@skyscanner/backpack-web 22.2.0 → 22.3.1

package/bpk-component-chip/src/commonTypes.js

@@ -33,7 +33,7 @@ export type CommonProps = {
   disabled: boolean,
   onClick: (event: SyntheticEvent<>) => mixed,
   selected: boolean,
-  type: $Keys<typeof CHIP_TYPES>,
+  type: $Values<typeof CHIP_TYPES>,
   className: ?string,
   leadingAccessoryView: ?Node,
 };
@@ -47,7 +47,7 @@ export const COMMON_PROP_TYPES = {
   leadingAccessoryView: PropTypes.node,
   selected: PropTypes.bool,
   trailingAccessoryView: PropTypes.node,
-  type: PropTypes.oneOf(Object.keys(CHIP_TYPES)),
+  type: PropTypes.oneOf(Object.values(CHIP_TYPES)),
 };
 
 export const COMMON_DEFAULT_PROPS = {

package/bpk-react-utils/README.md

@@ -26,30 +26,28 @@ class MyComponent extends Component {
     this.state = {
       isOpen: false,
     };
-
   }
 
   onOpen = () => {
     this.setState({
       isOpen: true,
     });
-  }
+  };
 
   onClose = () => {
     this.setState({
       isOpen: false,
     });
-  }
+  };
 
   render() {
     return (
       <div>
         <BpkButton onClick={this.onOpen}>Open portal</BpkButton>
-        <Portal
-          isOpen={this.state.isOpen}
-          onClose={this.onClose}
-        >
-          <div>I'm now appended to <BpkCode>document.body</BpkCode></div>
+        <Portal isOpen={this.state.isOpen} onClose={this.onClose}>
+          <div>
+            I'm now appended to <BpkCode>document.body</BpkCode>
+          </div>
         </Portal>
       </div>
     );
@@ -57,19 +55,25 @@ class MyComponent extends Component {
 }
 ```
 
+**NOTE:** Events used to bubble up from the portal into the parent component. Due to the way React works, events do not
+bubble up into the component in the DOM where the portal is rendered (i.e. render target), but instead they bubble up
+into the parent component in the shadow DOM, that is the component where you added the `Portal` in your React code. To
+avoid confusion and bugs caused by this behaviour, we have prevented mouse and keyboard events from bubbling up outside
+the portal.
+
 ### Props
 
-| Property              | PropType                | Required | Default Value |
-| --------------------- | ----------------------- | -------- | ------------- |
-| children              | node                    | true     | -             |
-| isOpen                | bool                    | true     | -             |
-| beforeClose           | func                    | false    | null          |
-| onClose               | func                    | false    | noop          |
-| onOpen                | func                    | false    | noop          |
-| onRender              | func                    | false    | noop          |
-| renderTarget          | func                    | false    | null          |
-| target                | oneOf([function, node]) | false    | null          |
-| closeOnEscPressed     | bool                    | false    | true          |
+| Property          | PropType                | Required | Default Value |
+| ----------------- | ----------------------- | -------- | ------------- |
+| children          | node                    | true     | -             |
+| isOpen            | bool                    | true     | -             |
+| beforeClose       | func                    | false    | null          |
+| onClose           | func                    | false    | noop          |
+| onOpen            | func                    | false    | noop          |
+| onRender          | func                    | false    | noop          |
+| renderTarget      | func                    | false    | null          |
+| target            | oneOf([function, node]) | false    | null          |
+| closeOnEscPressed | bool                    | false    | true          |
 
 ## `cssModules.js`
 
@@ -86,9 +90,7 @@ const getClassName = cssModules(STYLES);
 
 const MyComponent = (props) => (
   <div className={getClassName('MyComponent')}>
-    <div className={getClassName('MyComponent__inner')}>
-      {props.children}
-    </div>
+    <div className={getClassName('MyComponent__inner')}>{props.children}</div>
   </div>
 );
 ```
@@ -97,9 +99,7 @@ With CSS modules:
 
 ```html
 <div class="_35WloynrPDta8fhSfoHEgE">
-  <div class="_1ghNYY7jOYzUneVCT4piQ9">
-    Some text.
-  </div>
+  <div class="_1ghNYY7jOYzUneVCT4piQ9">Some text.</div>
 </div>
 ```
 
@@ -107,9 +107,7 @@ Without CSS modules:
 
 ```html
 <div class="MyComponent">
-  <div class="MyComponent__inner">
-    Some text.
-  </div>
+  <div class="MyComponent__inner">Some text.</div>
 </div>
 ```
 
@@ -123,8 +121,13 @@ import STYLES from './MyComponent.scss';
 const getClassNames = cssModules(STYLES);
 
 const MyComponent = (props) => (
-  <div className={getClassName('MyComponent', props.disabled && 'MyComponent--disabled')}>
-   {props.children}
+  <div
+    className={getClassName(
+      'MyComponent',
+      props.disabled && 'MyComponent--disabled',
+    )}
+  >
+    {props.children}
   </div>
 );
 ```

package/bpk-react-utils/src/Portal.js

@@ -263,7 +263,22 @@ class Portal extends Component {
       return null;
     }
 
-    return createPortal(children, portalElement);
+    const stopPropagationHandler = (e) => e.stopPropagation();
+
+    return createPortal(
+      <div
+        onClick={stopPropagationHandler}
+        onMouseDown={stopPropagationHandler}
+        onMouseUp={stopPropagationHandler}
+        onKeyDown={stopPropagationHandler}
+        onKeyUp={stopPropagationHandler}
+        tabIndex={-1}
+        role="none"
+      >
+        {children}
+      </div>,
+      portalElement,
+    );
   }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skyscanner/backpack-web",
-  "version": "22.2.0",
+  "version": "22.3.1",
   "description": "Backpack Design System web library",
   "repository": {
     "type": "git",