@skyramp/skyramp 1.2.39 → 1.2.41

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skyramp/skyramp",
-  "version": "1.2.39",
+  "version": "1.2.41",
   "description": "module for leveraging skyramp cli functionality",
   "scripts": {
     "lint": "eslint 'src/**/*.js' 'src/**/*.ts' --fix",

package/src/classes/SmartPlaywright.js

@@ -52,6 +52,57 @@ function debug(...args) {
     }
 }
 
+/**
+ * Detect if we're running inside a Docker container.
+ *
+ * Checks the SKYRAMP_IN_DOCKER environment variable
+ *
+ * @returns {boolean} True if running in Docker, false otherwise
+ */
+function isRunningInDocker() {
+    const envValue = (process.env.SKYRAMP_IN_DOCKER || '').toLowerCase();
+    return envValue === 'true' || envValue === '1' || envValue === 'yes';
+}
+
+/**
+ * Transform localhost URLs to host.docker.internal when running in Docker.
+ *
+ * This helper function automatically detects if we're running inside a Docker
+ * container and transforms localhost URLs to use host.docker.internal, which
+ * allows containers to access services running on the host machine.
+ *
+ * @param {string} url - The URL to potentially transform
+ * @returns {string} The transformed URL if in Docker and URL contains localhost, otherwise the original URL
+ */
+function transformUrlForDocker(url) {
+    if (!url) {
+        return url;
+    }
+
+    // Auto-detect if we're running in Docker
+    if (!isRunningInDocker()) {
+        return url;
+    }
+
+    // Use proper URL parsing to only replace the hostname component
+    try {
+        const urlObj = new URL(url);
+        const hostname = urlObj.hostname;
+
+        // Only transform if hostname is exactly 'localhost' or '127.0.0.1'
+        if (hostname === 'localhost' || hostname === '127.0.0.1') {
+            urlObj.hostname = 'host.docker.internal';
+            const transformed = urlObj.toString();
+            debug(`Transformed URL: ${url} -> ${transformed}`);
+            return transformed;
+        }
+    } catch (error) {
+        debug(`Failed to parse URL: ${url}, returning original`);
+    }
+
+    return url;
+}
+
 function shouldAttemptImprovement(errorMessage, errorName) {
     const improvementKeywords = [
         "timeout",
@@ -272,6 +323,13 @@ class SkyrampPlaywrightLocator {
             newMsg += this.generateLLMErrors();
         }
 
+        // Ensure error is an Error object, not a string
+        if (typeof error === 'string') {
+            error = new Error(error);
+        } else if (!(error instanceof Error)) {
+            error = new Error(String(error));
+        }
+
         error.message = error.message + "\n" + newMsg
 
         return error
@@ -279,7 +337,7 @@ class SkyrampPlaywrightLocator {
 
     hydrationErrorMsg = "Potentially a hydration issue. Please add enough waitForTimeout()"
 
-    newPrevHyrdationErrorMsg() {
+    newPrevHydrationErrorMsg() {
         return `Cannot find locator ${this._locator} and likely a hydration issue on ${this._previousLocator._locator}.\n` +
                `Please add enough waitForTimeout() on ${this._previoousLocator._locator}`;
     }
@@ -765,7 +823,8 @@ class SkyrampPlaywrightPage {
     }
 
     async goto(url, options) {
-        const result = await this._page.goto(url, options);
+        const transformedUrl = transformUrlForDocker(url);
+        const result = await this._page.goto(transformedUrl, options);
         const content = await this._page.content();
         if (hasJavascriptWrapper(content)) {
             debug(`javascript download detected when visiting ${this._page.url()}`);