@skyramp/mcp 0.4.4-rc.1 → 0.4.4

package/build/tools/test-management/registerTestPlanTool.js

@@ -12,10 +12,7 @@ import { collectChangedRuns } from "../../utils/changedRuns.js";
 import { LOCKFILE, NOT_SOURCE_DIR, } from "../../recommendation/verifiers/endpointGrounded.js";
 import { hasUITestTypeLabel, isHTTPStep, } from "../../recommendation/subjectStep.js";
 import { STEP_METHOD_DESCRIPTION, isUiStepVerb, normalizeStepMethod, stepMethodSchema, } from "../../types/StepMethod.js";
-import { registerPlan, } from "../../recommendation/registerPlan.js";
-import { BLOCKER_DESCRIPTION } from "../../recommendation/answers.js";
-import { probeBlockers, blockersIn, } from "../../recommendation/blockerProbes.js";
-import { blockerSchema, verifyBlocker } from "../../recommendation/blockers.js";
+import { registerPlan } from "../../recommendation/registerPlan.js";
 import { targetElementSchema } from "../submitReportTool.js";
 import { capturedBlueprintDigests } from "../../playwright/blueprintDigestStore.js";
 import { pullRequestText } from "../../recommendation/pullRequestText.js";
@@ -92,7 +89,7 @@ const registerStepSchema = z
         if (step[field] === undefined)
             continue;
         ctx.addIssue({
-            code: z.ZodIssueCode.custom,
+            code: "custom",
             path: [field],
             message: `\`${field}\` belongs to a step that sends a request; \`${step.method}\` is a page interaction, which sends none. Assert the page through \`declarations.elements\`, or write the request as its own step.`,
         });
@@ -132,7 +129,7 @@ const plannedTestCitations = citationFields({
     changesSubject: "test proves",
     defectsSubject: "test proves",
     changesExtra: " This test proves one behaviour: list the id of every change that the behaviour covers. The server checks that each declared change has a planned test that cites it, or an answer. The server does not check that the test exercises the change. CHECKED on a `requirement_conflict` test: at least one cited change must have been read from the pull request or a requirements file, never only from the diff.",
-    defectsExtra: " The server checks that each declared defect has a planned test that cites it and expects to fail. The server does not check that the test reaches the defect. CHECKED on a `requirement_conflict` test: it must cite at least one defect.",
+    defectsExtra: " The server checks that each declared defect has a planned test that cites it and expects to fail, or a blocker naming what stopped the test. The server does not check that the test reaches the defect. CHECKED on a `requirement_conflict` test: it must cite at least one defect.",
 });
 // The fields `declarations` accepts. Named on its own so one list of them can be
 // derived from it — a hand-written second copy had already fallen behind.
@@ -249,7 +246,7 @@ const declarationsSchema = declarationFieldsSchema
         if (identifies)
             return;
         ctx.addIssue({
-            code: z.ZodIssueCode.custom,
+            code: "custom",
             path: ["elements", "items", index],
             message: "every `elements.items` entry needs at least one of `accessibleName`, `testId` or `stableId` with a value in it — an entry with none names no element that can be looked up in a capture.",
         });
@@ -341,7 +338,7 @@ const registerPlannedTestSchema = z.preprocess(hoistDeclarationFields, z
     const isUILabel = hasUITestTypeLabel(plannedTest.testType);
     if (plannedTest.steps.length === 0 && !isUILabel) {
         ctx.addIssue({
-            code: z.ZodIssueCode.custom,
+            code: "custom",
             path: ["steps"],
             message: "steps must not be empty for a contract, integration or other non-UI planned test: the route, duplicate and existing-coverage checks all read the steps to find the endpoint this test is about. List the requests the test makes.",
         });
@@ -355,7 +352,7 @@ const registerPlannedTestSchema = z.preprocess(hoistDeclarationFields, z
     const url = typeof rawUrl === "string" ? rawUrl.trim() : "";
     if (isUILabel && !hasHTTPStep && url.length === 0) {
         ctx.addIssue({
-            code: z.ZodIssueCode.custom,
+            code: "custom",
             path: ["declarations", "elements", "pageUrl"],
             message: "a ui or e2e planned test whose steps make no HTTP call must set `declarations.elements.pageUrl` to the screen it opens: a planned test naming no request and no screen is not a plan the server can read.",
         });
@@ -366,7 +363,7 @@ const registerPlannedTestSchema = z.preprocess(hoistDeclarationFields, z
     // no page either could look up and drew no objection from either.
     if (isUILabel && url.length > 0 && !namesAScreen(url)) {
         ctx.addIssue({
-            code: z.ZodIssueCode.custom,
+            code: "custom",
             path: ["declarations", "elements", "pageUrl"],
             message: "`declarations.elements.pageUrl` is accepted in two spellings and no others: a route path starting with `/`, e.g. `/orders/1`, or an absolute `http` or `https` URL, e.g. `http://localhost:5173/orders/1`. Give the path when this run has no host to name.",
         });
@@ -477,7 +474,7 @@ const registerTestPlanSchema = {
                 return;
             }
             ctx.addIssue({
-                code: z.ZodIssueCode.custom,
+                code: "custom",
                 path: [index, "id"],
                 message: `change id "${change.id}" is already used by change ${seen + 1}. Every change needs its own id — planned tests cite it by that id.`,
             });
@@ -523,14 +520,14 @@ const registerTestPlanSchema = {
                 return;
             }
             ctx.addIssue({
-                code: z.ZodIssueCode.custom,
+                code: "custom",
                 path: [index, "id"],
                 message: `defect id "${defect.id}" is already used by defect ${seen + 1}. Every defect needs its own id — planned tests cite it by that id.`,
             });
         });
     })
         .default([])
-        .describe("The defects your code review found in the code that serves each change, whether or not the diff contains the line. Every defect closes one of two ways: a planned test that cites it in `defects` and expects to fail, or a `maintains` entry that cites it because your edit to an existing test covers it. A service that is down does not stop the test: write it, and it runs once the service is back. A pre-existing defect in a file this pull request touches belongs on this list. An empty list says the review found none; the check asks you to confirm that in one line. A requirement conflict is a defect: list it here, and the `requirement_conflict` test cites it."),
+        .describe("The defects your code review found in the code that serves each change, whether or not the diff contains the line. Every defect closes one of three ways: a planned test that cites it in `defects` and expects to fail, a `maintains` entry that cites it because your edit to an existing test covers it, or a blocker naming what stopped the test. A pre-existing defect in a file this pull request touches belongs on this list. An empty list says the review found none; the check asks you to confirm that in one line. A requirement conflict is a defect: list it here, and the `requirement_conflict` test cites it."),
     // REQUIRED, not `.default([])`. The MCP SDK wraps this shape in a plain
     // `z.object`, which STRIPS an undeclared top-level key, so with a default
     // `planned test:` for `planned tests:` stored an EMPTY plan and counted the
@@ -555,7 +552,7 @@ const registerTestPlanSchema = {
                 return;
             }
             ctx.addIssue({
-                code: z.ZodIssueCode.custom,
+                code: "custom",
                 path: [index, "scenarioName"],
                 message: `scenarioName "${plannedTest.scenarioName}" is already used by planned test ${first + 1}. Every planned test needs its own name — the name is its id.`,
             });
@@ -587,7 +584,10 @@ const registerTestPlanSchema = {
         answer: z
             .string()
             .describe("Why the objection does not apply, or what you decided instead."),
-        blocker: blockerSchema.optional().describe(BLOCKER_DESCRIPTION),
+        blocker: z
+            .string()
+            .optional()
+            .describe("What stopped this run from writing the test: a service that is not running, a paired branch that no longer exists, the one credential the run holds. An objection about a change or a defect with no test, or about a value a page and API change refuses that no UI test names, closes only with this. A reason the change is not worth testing is not a blocker."),
     })
         .strict())
         .default([])
@@ -795,25 +795,10 @@ function recordedPullRequest() {
     logger.warning("No pull request text was recorded before the plan was registered; the checks that read it will see an empty pull request.");
     return { title: "", description: "" };
 }
-/** The blockers this registration is judged on: the ones it sends AND the ones the
- *  stored plan carries. A carried close is re-probed on every registration — the
- *  service that was down when it was accepted may be up now. */
-export function blockersToProbe(registration, previous) {
-    return [
-        ...blockersIn(registration.answers),
-        ...blockersIn(previous?.answeredObjections ?? []),
-        ...blockersIn(previous?.unverifiedCloses ?? []),
-    ];
-}
-/** Every fact the verifiers check against, gathered once per registration. The
- *  blockers are probed HERE rather than inside a verifier: an HTTP request and a
- *  `git` call are both asynchronous and every verifier is not. */
-export async function buildVerifyContext(state, blockers = []) {
+/** Every fact the verifiers check against, gathered once per registration. */
+export async function buildVerifyContext(state) {
     const sections = repoSections(state);
-    const [listings, checks] = await Promise.all([
-        Promise.all(sections.map((section) => changedFilesForVerification(section))),
-        probeBlockers(blockers),
-    ]);
+    const listings = await Promise.all(sections.map((section) => changedFilesForVerification(section)));
     // Per repository, so a planned test is checked against the one it names. Every
     // planned test names one; a single-repository run names that one repository.
     return {
@@ -836,7 +821,6 @@ export async function buildVerifyContext(state, blockers = []) {
         citedFileExists: makeCitedFileCheck(state),
         readSpecFile: makeSpecFileReader(state),
         routesRenderingFile: makeScreenRouteResolver(state),
-        blockerVerdict: (blocker) => verifyBlocker(blocker, checks),
     };
 }
 // ── Output ──────────────────────────────────────────────────────────────────
@@ -923,7 +907,7 @@ export function registerRegisterTestPlanTool(server) {
             "An undeclared key is refused by name on a planned test and on `declarations`, so a declaration written one level too high is corrected rather than dropped in silence. " +
             "Checks run against the stored plan and return objections. Fix one and register it again as often as you like, or answer it by id through `answers`. " +
             "There is no fallback plan: if you never register, this run has no plan.",
-        inputSchema: registerTestPlanSchema,
+        inputSchema: z.object(registerTestPlanSchema),
     }, async (params) => {
         // The run's own state file, unless the agent named one. Outside a run there
         // is no path to fall back to, and no analysis to check a plan against.
@@ -946,7 +930,7 @@ export function registerRegisterTestPlanTool(server) {
                 const registration = buildRegistration(params, registrationNumber);
                 // The previous registration's answers are already on the stored plan, which
                 // the write below replaces.
-                const result = registerPlan(registration, await buildVerifyContext(fullState, blockersToProbe(registration, fullState.plan)), fullState.plan);
+                const result = registerPlan(registration, await buildVerifyContext(fullState), fullState.plan);
                 try {
                     const { metadata: _metadata, relatedRepos: _sections, ...rootData } = fullState;
                     await stateManager.appendData({

package/build/tools/test-management/resolveScreenTool.d.ts

@@ -1,4 +1,4 @@
-import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { McpServer } from "@modelcontextprotocol/server";
 import { ScreenRouteCandidate } from "../../utils/screenRoutes.js";
 /** Where a bound route parameter came from. `unresolved` never carries a value. */
 export type ParamSource = "currentUrl" | "blueprint" | "unresolved";

package/build/tools/test-management/resolveScreenTool.js

@@ -260,7 +260,7 @@ const outputSchema = {
         .array(z.object({
         url: z.string(),
         routePattern: z.string(),
-        params: z.record(z.object({
+        params: z.record(z.string(), z.object({
             value: z.string(),
             from: z.enum(["currentUrl", "blueprint", "unresolved"]),
         })),
@@ -282,7 +282,11 @@ const DESCRIPTION = "Answer which page of the running app renders a changed fron
     "(skip the browser and say so), or 'unknown' when no route table could be read (find the page yourself). " +
     "The current page is read from this server's own browser session — do not pass it.";
 export function registerResolveScreenTool(server) {
-    server.registerTool(TOOL_RESOLVE_SCREEN, { description: DESCRIPTION, inputSchema, outputSchema }, async (params) => {
+    server.registerTool(TOOL_RESOLVE_SCREEN, {
+        description: DESCRIPTION,
+        inputSchema: z.object(inputSchema),
+        outputSchema: z.object(outputSchema),
+    }, async (params) => {
         const repositoryPath = String(params.repositoryPath ?? "").trim();
         const changedFile = String(params.changedFile ?? "").trim();
         const location = lastKnownBrowserUrl();

package/build/tools/trace/startTraceCollectionTool.d.ts

@@ -1,2 +1,2 @@
-import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { McpServer } from "@modelcontextprotocol/server";
 export declare function registerTraceTool(server: McpServer): void;

package/build/tools/trace/startTraceCollectionTool.js

@@ -47,7 +47,7 @@ Pass \`sessionMode\` to declare what you want to do with the workspace's session
 \`sessionMode: "auto"\` (default) — Use when the user does not signal an intent either way. If a session file already exists in \`outputDir\`, behaves like \`reuse\` (loads it, does not overwrite). If no session file exists, does **no** session handling — it neither loads nor saves. Storing a session is always opt-in: it only happens with \`sessionMode: "capture"\` or an explicit \`playwrightSaveStoragePath\`. Plain auto never writes credentials the user did not ask to store.
 
 For detailed documentation visit: https://www.skyramp.dev/docs/load-test/advanced-generation#start-trace-collection`,
-        inputSchema: {
+        inputSchema: z.object({
             playwright: z
                 .boolean()
                 .describe("Whether to enable Playwright for trace collection. Set to true for UI interactions, false for API-only tracing")
@@ -94,14 +94,14 @@ For detailed documentation visit: https://www.skyramp.dev/docs/load-test/advance
             prompt: z
                 .string()
                 .describe("The prompt user provided to start trace collection"),
-        },
+        }),
         _meta: {
             keywords: ["start trace", "trace collection", "trace generation"],
         },
-    }, async (params, extra) => {
+    }, async (params, ctx) => {
         let errorResult;
         // Helper to send progress notifications to the MCP client
-        const sendProgress = makeProgressReporter(extra);
+        const sendProgress = makeProgressReporter(ctx);
         logger.info("Starting trace collection", {
             playwright: params.playwright,
             browser: params.browser,

package/build/tools/trace/stopTraceCollectionTool.d.ts

@@ -1,2 +1,2 @@
-import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { McpServer } from "@modelcontextprotocol/server";
 export declare function registerTraceStopTool(server: McpServer): void;

package/build/tools/trace/stopTraceCollectionTool.js

@@ -22,7 +22,7 @@ The generated trace and Playwright files can be used as inputs for:
 - UI test generation (using Playwright files)
 
 For detailed documentation visit: https://www.skyramp.dev/docs/load-test/advanced-generation#end-trace-collection`,
-        inputSchema: {
+        inputSchema: z.object({
             traceOutputFile: z
                 .string()
                 .default("skyramp_traces.json")
@@ -38,7 +38,7 @@ For detailed documentation visit: https://www.skyramp.dev/docs/load-test/advance
             prompt: z
                 .string()
                 .describe("The prompt user provided to stop trace collection"),
-        },
+        }),
         _meta: {
             keywords: ["stop trace", "collect generated trace"],
         },

package/build/tools/verifyTestDependenciesTool.d.ts

@@ -1,3 +1,3 @@
-import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { McpServer } from "@modelcontextprotocol/server";
 export declare const VERIFY_TEST_DEPENDENCIES_TOOL = "skyramp_verify_test_dependencies";
 export declare function registerVerifyTestDependenciesTool(server: McpServer): void;

package/build/tools/verifyTestDependenciesTool.js

@@ -14,7 +14,7 @@ const schema = z.object({
 export function registerVerifyTestDependenciesTool(server) {
     server.registerTool(VERIFY_TEST_DEPENDENCIES_TOOL, {
         description: "Verify that dependency changes made while fixing tests use only approved testing packages and development/test-only manifest scopes.",
-        inputSchema: schema.shape,
+        inputSchema: schema,
         _meta: {
             keywords: [
                 "dependencies",

package/build/tools/workspace/initScanWorkspaceTool.d.ts

@@ -1,4 +1,4 @@
-import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { McpServer } from "@modelcontextprotocol/server";
 export declare function issueScanToken(): string;
 export declare function validateAndConsumeScanToken(token: string): boolean;
 export declare function registerInitScanWorkspaceTool(server: McpServer): void;

package/build/tools/workspace/initScanWorkspaceTool.js

@@ -33,7 +33,7 @@ export function registerInitScanWorkspaceTool(server) {
             "PREREQUISITE for skyramp_init_workspace. " +
             "Scans a repository and returns instructions for discovering all services, along with a scanToken. " +
             "Follow the instructions to build the services array, then pass both to skyramp_init_workspace to create the workspace config.",
-        inputSchema: initScanWorkspaceSchema.shape,
+        inputSchema: initScanWorkspaceSchema,
     }, async (params) => {
         let errorResult;
         const recordParams = {

package/build/tools/workspace/initializeWorkspaceTool.d.ts

@@ -1,2 +1,2 @@
-import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { McpServer } from "@modelcontextprotocol/server";
 export declare function registerInitializeWorkspaceTool(server: McpServer): void;

package/build/tools/workspace/initializeWorkspaceTool.js

@@ -111,7 +111,7 @@ export function registerInitializeWorkspaceTool(server) {
             "Then call this tool to write .skyramp/workspace.yml with the discovered services and scanToken. " +
             "2. Edit existing workspace.yml: omit scanToken, set force: true, and pass the FULL updated services array (overwrite, not merge — fields not in the array are dropped). " +
             "The services schema is strict: any field not in the schema (e.g. inventing `serverStopCommand` on `runtimeDetails`) fails validation and the call is rejected.",
-        inputSchema: initializeWorkspaceSchema.shape,
+        inputSchema: initializeWorkspaceSchema,
         _meta: {
             keywords: [
                 "initialize",