@skyramp/mcp 0.3.5 → 0.3.6-rc.1

package/build/types/Recommendation.d.ts

@@ -1,4 +1,4 @@
-import { DraftedScenario } from "../types/RepositoryAnalysis.js";
+import { DraftedScenario, SubjectEndpoint } from "../types/RepositoryAnalysis.js";
 import { Novelty, PriorityTier } from "../types/TestRecommendation.js";
 /**
  * The structural bug-shape a candidate claims to probe. Verified against the
@@ -53,21 +53,42 @@ export interface BudgetContext {
     hasFrontendChanges: boolean;
     /** Method-aware coverage keys of external tests; matching candidates are dropped. */
     externalCoverage: Set<string>;
+    /**
+     * Whether the PR's own diff changes any test file. External coverage is
+     * discovered from the working tree, so a test the PR itself adds is
+     * indistinguishable from pre-existing coverage; when this is true the
+     * covered-candidate reserve stays shut rather than forcing duplicates of a
+     * test the author already wrote.
+     */
+    diffChangesTestFiles: boolean;
 }
 /** A demoted claim: which candidate, and the human-readable reason returned to
- *  the agent so it can fix the claim (never a silent drop). */
+ *  the agent so it can fix the claim (never a silent drop of the claim itself).
+ *  A demotion records that a declared discriminator claim failed to verify.
+ *  It does not say whether the candidate is still in the plan. Budgeting
+ *  decides that separately. A candidate can be both demoted and dropped. */
 export interface Demotion {
     candidateId: string;
     reason: string;
 }
+/** A candidate the selection stage removed, and why. A demotion annotates a
+ *  claim. A drop removes a candidate from `generate` and `additional`. The
+ *  two are independent. The same candidate can carry both. */
+export interface Dropped {
+    candidateId: string;
+    reason: string;
+}
 /** Result of budgeting: the GENERATE set, the ADDITIONAL set, how many UI
- *  placeholder slots the render layer should add (mixed/UI-only PRs), and the
- *  demoted-claim channel (the missing rejection surface for register-plan). */
+ *  placeholder slots the render layer should add (mixed/UI-only PRs), the
+ *  demoted-claim channel (the missing rejection surface for register-plan),
+ *  and the dropped-candidate channel (SKYR-4214: every candidate the
+ *  selection stage removed outright, with a human-actionable reason). */
 export interface SelectionResult {
     generate: Candidate[];
     additional: Candidate[];
     reservedUISlots: number;
     demotions: Demotion[];
+    dropped: Dropped[];
 }
 /** A pluggable budgeting algorithm. Deterministic and pure. */
 export interface Budgeter {
@@ -105,7 +126,14 @@ export declare function scenarioMergeKey(scenarioName: string | undefined): stri
 export declare function computeCandidateId(scenario: DraftedScenario): string;
 /** One approved plan item as persisted in `UnifiedAnalysisState.approvedPlan`.
  *  Deliberately slim (no steps/requestBody/etc.) — `matchKeys` already carries
- *  everything a downstream matcher needs. */
+ *  everything a downstream matcher needs.
+ *
+ *  `subjectEndpoints` is the one exception. `matchKeys` holds one key per
+ *  step and is deliberately broad, so a generated test can be matched back
+ *  to its plan item. It does not say which step is the subject. Dedup
+ *  judges the subject, not the whole step list, so the plan item must
+ *  record it too. See `DraftedScenario.subjectEndpoints` for the
+ *  absent-vs-empty contract this field carries over unchanged. */
 export interface ApprovedPlanItem {
     candidateId: string;
     scenarioName: string;
@@ -113,5 +141,6 @@ export interface ApprovedPlanItem {
     category: string;
     source: CandidateSource;
     verifiedDiscriminator?: string;
+    subjectEndpoints?: SubjectEndpoint[];
     matchKeys: string[];
 }