@skyramp/mcp 0.3.2 → 0.3.4

package/build/tools/test-management/analyzeChangesTool.js

@@ -6,6 +6,7 @@ import * as path from "path";
 import yaml from "js-yaml";
 import { simpleGit } from "simple-git";
 import { logger } from "../../utils/logger.js";
+import { dualChannelResult } from "../../utils/utils.js";
 import { parseWorkspaceAuthType, getDefaultAuthHeader, WorkspaceAuthType, readWorkspaceConfigRaw } from "../../utils/workspaceAuth.js";
 import { AnalyticsService } from "../../services/AnalyticsService.js";
 import { makeProgressReporter } from "../../utils/progress.js";
@@ -367,6 +368,14 @@ These components have no DOM presence in the running app: no route, page, or oth
 - Log an \`issuesFound\` entry (high severity) naming the unintegrated file(s) above and stating that the changed code is unreachable in the running app.
 - Backend/other work in this PR is unaffected — proceed with it normally.`;
 }
+/**
+ * Assemble the tool result. See `dualChannelResult` for why the payload is
+ * carried on both result channels.
+ */
+export function buildAnalyzeChangesResult(parts) {
+    const executionPlan = `\`\`\`json\n${parts.structuredSummary}\n\`\`\`\n\n## UI Blueprint Capture — do this BEFORE writing UI recommendation reasoning\n${parts.uiInstructions}\n\n${parts.outputText}\n\n---\n\n## Pre-built Test Catalog — Fill in placeholders from source code, then display verbatim\n⚠️ Do NOT reformat, rename sections, or generate a new catalog. Replace \`<…from source>\` values, then show this output exactly as-is, grouped by test type.\n\n${parts.recommendationPrompt}`;
+    return dualChannelResult({ executionPlan });
+}
 export function registerAnalyzeChangesTool(server) {
     server.registerTool(TOOL_NAME, {
         annotations: {
@@ -376,8 +385,14 @@ export function registerAnalyzeChangesTool(server) {
             openWorldHint: true, // may fetch PR comments from GitHub
         },
         description: `Scan repository API endpoints and discover existing tests — first step of the unified Test Health Analysis Flow. Returns a stateFile path and ranked test recommendations. Pass stateFile to skyramp_analyze_test_health and skyramp_actions.`,
-        // TODO: Replace description-embedded output format with outputSchema — structural
-        // output schema reduces token usage vs natural language in description.
+        // SKYR-4182: the payload is returned via structuredContent, which requires a
+        // declared outputSchema. This also keeps the result out of the single-line
+        // `.json` spill shape that Read cannot paginate — see buildAnalyzeChangesResult.
+        outputSchema: {
+            executionPlan: z
+                .string()
+                .describe("Analysis summary, UI blueprint capture instructions, and the ranked Execution Plan. Read and follow this field."),
+        },
         inputSchema: analyzeChangesInputSchema,
     }, async (params, extra) => {
         let errorResult;
@@ -419,12 +434,9 @@ export function registerAnalyzeChangesTool(server) {
                     logger.info("All user-changed files are non-application — skipping analysis", {
                         changedFiles: filesToCheck,
                     });
-                    return {
-                        content: [{
-                                type: "text",
-                                text: `All ${filesToCheck.length} changed file(s) are non-application (CI/CD, docs, lock files, config). No test analysis needed for this diff.\n\nChanged files: ${filesToCheck.join(", ")}`,
-                            }],
-                    };
+                    return dualChannelResult({
+                        executionPlan: `All ${filesToCheck.length} changed file(s) are non-application (CI/CD, docs, lock files, config). No test analysis needed for this diff.\n\nChanged files: ${filesToCheck.join(", ")}`,
+                    });
                 }
             }
             // ── Step 2: Scan endpoints ──
@@ -569,22 +581,17 @@ export function registerAnalyzeChangesTool(server) {
                     logger.info("GraphQL-only diff detected — REST testing not supported", {
                         changedFiles: diffData.changedFiles,
                     });
-                    return {
-                        content: [{
-                                type: "text",
-                                text: [
-                                    "**GraphQL-only diff detected.**",
-                                    "",
-                                    "The changed files appear to be GraphQL schema, artifact, or endpoint implementation files.",
-                                    "Skyramp currently supports REST API testing only — GraphQL introspection,",
-                                    "query validation, and type-name grounding are not yet supported.",
-                                    "",
-                                    "No test recommendations can be generated for this diff.",
-                                    "",
-                                    `Changed files: ${diffData.changedFiles.join(", ")}`,
-                                ].join("\n"),
-                            }],
-                    };
+                    return dualChannelResult({ executionPlan: [
+                            "**GraphQL-only diff detected.**",
+                            "",
+                            "The changed files appear to be GraphQL schema, artifact, or endpoint implementation files.",
+                            "Skyramp currently supports REST API testing only — GraphQL introspection,",
+                            "query validation, and type-name grounding are not yet supported.",
+                            "",
+                            "No test recommendations can be generated for this diff.",
+                            "",
+                            `Changed files: ${diffData.changedFiles.join(", ")}`,
+                        ].join("\n") });
                 }
             }
             await sendProgress(50, 100, "Discovering existing tests...");
@@ -1601,15 +1608,12 @@ export function registerAnalyzeChangesTool(server) {
                 unmatchedFiles: classifiedEndpoints?.unmatchedFiles,
                 nextTool: "skyramp_analyze_test_health",
             });
-            return {
-                content: [
-                    {
-                        type: "text",
-                        text: `\`\`\`json\n${structuredSummary}\n\`\`\`\n\n## UI Blueprint Capture — do this BEFORE writing UI recommendation reasoning\n${uiInstructions}\n\n${outputText}\n\n---\n\n## Pre-built Test Catalog — Fill in placeholders from source code, then display verbatim\n⚠️ Do NOT reformat, rename sections, or generate a new catalog. Replace \`<…from source>\` values, then show this output exactly as-is, grouped by test type.\n\n${recommendationPrompt}`,
-                    },
-                ],
-                isError: false,
-            };
+            return buildAnalyzeChangesResult({
+                structuredSummary,
+                uiInstructions,
+                outputText,
+                recommendationPrompt,
+            });
         }
         catch (error) {
             const errorMessage = error instanceof Error ? error.message : String(error);

package/build/tools/test-management/analyzeTestHealthTool.js

@@ -62,7 +62,7 @@ export function registerAnalyzeTestHealthTool(server) {
         inputSchema: {
             stateFile: z
                 .string()
-                .describe("Path to the analyze-changes-state.json file returned by skyramp_analyze_changes (the stateFile field in its output). Do NOT pass summaryOutputFile or testbot-result.txt here."),
+                .describe("Path to the analyze-changes-state.json file returned by skyramp_analyze_changes (the stateFile field in its output). Do NOT pass testbot-result.txt here."),
             blueprintCaptured: z
                 .boolean()
                 .optional()
@@ -88,10 +88,10 @@ export function registerAnalyzeTestHealthTool(server) {
                 return toolError(`State file is empty or invalid: ${args.stateFile}${args.repository ? ` (no section for repository ${args.repository})` : ""}. Call skyramp_analyze_changes first to generate a valid state file.`);
             }
             if (!repositoryPath || typeof repositoryPath !== "string") {
-                return toolError(`repositoryPath not found in state file metadata. The stateFile parameter must be the analyze-changes-state.json path returned by skyramp_analyze_changes — not summaryOutputFile or testbot-result.txt. Re-run skyramp_analyze_changes to regenerate it.`);
+                return toolError(`repositoryPath not found in state file metadata. The stateFile parameter must be the analyze-changes-state.json path returned by skyramp_analyze_changes — not testbot-result.txt. Re-run skyramp_analyze_changes to regenerate it.`);
             }
             if (!Array.isArray(stateData.existingTests)) {
-                return toolError(`stateFile does not contain test discovery data (existingTests missing). The stateFile parameter must be the analyze-changes-state.json path returned by skyramp_analyze_changes — not summaryOutputFile or testbot-result.txt.`);
+                return toolError(`stateFile does not contain test discovery data (existingTests missing). The stateFile parameter must be the analyze-changes-state.json path returned by skyramp_analyze_changes — not testbot-result.txt.`);
             }
             // External tests: UPDATE only — REGENERATE/DELETE are report-only (enforced in
             // skyramp_actions). Already scoped to relevant ones by discovery.

package/build/tools/test-management/registerTestPlanTool.js

@@ -128,38 +128,57 @@ function toDraftedScenario(input) {
         testType: input.testType,
     };
 }
-/** Build the agent-submitted candidates, running discriminator verification
- *  against the persisted diff text. Failed claims demote (never reject). */
-function buildAgentCandidates(candidates, diffText) {
-    const demotions = [];
-    const built = candidates.map((input) => {
+/** Build the agent-submitted candidates. Discriminator claims are verified
+ *  later, by {@link applyDiscriminatorClaims}, once the merge has settled which
+ *  scenario each name resolves to. */
+function buildAgentCandidates(candidates) {
+    return candidates.map((input) => {
         const scenario = toDraftedScenario(input);
-        const candidateId = computeCandidateId(scenario);
-        let verifiedDiscriminator;
-        if (input.discriminator) {
-            const claim = input.discriminator;
-            const result = validateDiscriminator(scenario, claim, diffText);
-            if (result.verified) {
-                verifiedDiscriminator = claim.kind;
-            }
-            else {
-                demotions.push({
-                    candidateId,
-                    reason: result.reason ?? `${claim.kind} discriminator claim could not be verified.`,
-                });
-            }
-        }
-        const candidate = {
+        return {
             scenario,
             priority: derivePriorityTier(scenario),
             novelty: Novelty.NEW,
             source: CandidateSource.AGENT,
-            candidateId,
-            ...(verifiedDiscriminator ? { verifiedDiscriminator } : {}),
+            candidateId: computeCandidateId(scenario),
         };
-        return candidate;
     });
-    return { candidates: built, demotions };
+}
+/**
+ * Verify each declared discriminator against the candidate that actually won
+ * the merge, and mark it. Failed claims demote (never reject).
+ *
+ * Runs AFTER the merge, not while building the agent's candidates: a server
+ * pre-seeded candidate wins the name, so verifying the agent's copy first
+ * attaches the result to a candidate that is about to be discarded — silently
+ * stripping the verification. Verification is against the WINNER's
+ * steps, so a claim that only held for the agent's rewrite is correctly refused
+ * rather than carried across.
+ *
+ * The marker is cleared before the current claim is applied. Each call replaces
+ * the agent's previous submission (see the `candidates` schema), and
+ * recoverServerCandidates restores whatever the LAST plan recorded — so keeping
+ * it would let a boost earned by an earlier registration outlive the claim that
+ * earned it, on a submission that no longer makes that claim or whose new claim
+ * fails.
+ */
+function applyDiscriminatorClaims(candidates, claimsByKey, diffText, reposWithoutDiff = []) {
+    const demotions = [];
+    const marked = candidates.map((candidate) => {
+        const { verifiedDiscriminator: _stale, ...unmarked } = candidate;
+        const claim = claimsByKey.get(scenarioMergeKey(candidate.scenario.scenarioName) || candidate.candidateId);
+        if (!claim)
+            return unmarked;
+        const result = validateDiscriminator(candidate.scenario, claim, diffText, reposWithoutDiff);
+        if (result.verified) {
+            return { ...unmarked, verifiedDiscriminator: claim.kind };
+        }
+        demotions.push({
+            candidateId: candidate.candidateId,
+            reason: result.reason ?? `${claim.kind} discriminator claim could not be verified.`,
+        });
+        return unmarked;
+    });
+    return { candidates: marked, demotions };
 }
 /** Recover full Candidates for pre-seeded ("server") plan items by matching
  *  candidateId back to the analyzed scenarios (repositoryAnalysis.scenarios) —
@@ -190,15 +209,49 @@ function recoverServerCandidates(priorPlan, allScenarios) {
     }
     return recovered;
 }
-function resolveBudgetContext(stateData) {
+/** Whether a repo section's persisted diff classification contains any new,
+ *  modified, or removed endpoint — the same signal `computeScoredCandidates`
+ *  derives `hasApiChanges` from at analyze time. */
+function sectionHasApiChanges(data) {
+    const diff = data?.repositoryAnalysis?.diff;
+    return ((diff?.newEndpoints?.length ?? 0) > 0 ||
+        (diff?.modifiedEndpoints?.length ?? 0) > 0 ||
+        (diff?.removedEndpoints?.length ?? 0) > 0);
+}
+function resolveBudgetContext(stateData, fullState) {
     const pbc = stateData.planBudgetContext;
-    return {
+    const base = {
         maxGenerate: pbc?.maxGenerate ?? MAX_TESTS_TO_GENERATE,
         maxTotal: pbc?.maxTotal ?? MAX_RECOMMENDATIONS,
         isUIOnlyPR: pbc?.isUIOnlyPR ?? false,
         hasFrontendChanges: pbc?.hasFrontendChanges ?? false,
         externalCoverage: new Set(pbc?.externalCoverageKeys ?? []),
     };
+    const relatedSections = Object.values(fullState?.relatedRepos ?? {}).map((section) => section.data);
+    if (relatedSections.length === 0)
+        return base;
+    // SKYR-4204: isUIOnlyPR/hasFrontendChanges are per-SECTION facts — each
+    // analyze call computes them from its own repo's diff. The approved plan is
+    // one run-wide decision, so a frontend-only PRIMARY diff must not put the
+    // budgeter on its all-UI branch (backendGenerateCount() = 0) while a related
+    // repo carries endpoint changes; that pinned GENERATE to UI placeholders and
+    // left every API candidate in ADDITIONAL regardless of maxGenerate. Derive
+    // the flags across ALL sections. A related repo checked out on its default
+    // branch classifies no endpoint changes, so it leaves a UI-only run UI-only.
+    // Budget numbers come from the root (primary) section: the testbot prompt
+    // passes topN/maxGenerate only to the primary analyze call, so related
+    // sections carry defaults.
+    const sections = [fullState ?? undefined, ...relatedSections];
+    const hasFrontendChanges = sections.some((s) => s?.planBudgetContext?.hasFrontendChanges ?? false);
+    const hasApiChanges = sections.some(sectionHasApiChanges);
+    const rootPbc = fullState?.planBudgetContext;
+    return {
+        maxGenerate: rootPbc?.maxGenerate ?? base.maxGenerate,
+        maxTotal: rootPbc?.maxTotal ?? base.maxTotal,
+        isUIOnlyPR: hasFrontendChanges && !hasApiChanges,
+        hasFrontendChanges,
+        externalCoverage: base.externalCoverage,
+    };
 }
 function describeGenerationCall(item) {
     switch (item.testType) {
@@ -316,9 +369,27 @@ export function registerRegisterTestPlanTool(server) {
                 errorResult = toolError(`State file is empty or invalid: ${params.stateFile}. Call skyramp_analyze_changes first to generate a valid state file.`);
                 return errorResult;
             }
-            const diffText = stateData.diffText ?? "";
+            // SKYR-4203: one register call carries candidates for EVERY repo of the
+            // run, but `stateData` is a single repo's section — and the candidate
+            // schema has no per-candidate repository, so a related repo's anchors
+            // were unverifiable by construction. Verify anchors (and rank diff-hunk
+            // proximity) against the union of ALL sections' diffs: an anchor
+            // grounded in a related repo's change is as real as one in the
+            // primary's. Sections with no diff (a related repo checked out on its
+            // default branch) are collected so an unmatched anchor reads as
+            // uncheckable rather than ungrounded.
+            const fullState = await stateManager.readFullState();
+            const diffSections = [
+                { repo: fullState?.metadata?.repository ?? "the primary repository", diff: fullState?.diffText },
+                ...Object.entries(fullState?.relatedRepos ?? {}).map(([repo, section]) => ({
+                    repo,
+                    diff: section.data?.diffText,
+                })),
+            ];
+            const diffText = diffSections.map((s) => s.diff).filter(Boolean).join("\n");
+            const reposWithoutDiff = diffSections.filter((s) => !s.diff).map((s) => s.repo);
             const allScenarios = stateData.repositoryAnalysis?.scenarios ?? [];
-            const { candidates: agentCandidates, demotions } = buildAgentCandidates(params.candidates ?? [], diffText);
+            const agentCandidates = buildAgentCandidates(params.candidates ?? []);
             const serverCandidates = recoverServerCandidates(stateData.approvedPlan, allScenarios);
             // Merge by scenario-name identity, NOT the full content-hashed candidateId:
             // the server (analyze_changes) and the agent frequently draft their own
@@ -341,7 +412,18 @@ export function registerRegisterTestPlanTool(server) {
                 merged.set(mergeKey(candidate), candidate);
             for (const candidate of serverCandidates)
                 merged.set(mergeKey(candidate), candidate);
-            const allCandidates = [...merged.values()];
+            // The agent declares a claim per scenario NAME, so key the claims the
+            // same way the merge does and verify against whichever copy survived.
+            const claimsByKey = new Map();
+            // Keyed through mergeKey, not scenarioMergeKey alone: a name that
+            // slugifies to nothing (e.g. an all-non-ASCII name) would be stored
+            // under "" while the lookup falls back to the candidateId, so the claim
+            // would be neither verified nor demoted.
+            (params.candidates ?? []).forEach((input, i) => {
+                if (input.discriminator)
+                    claimsByKey.set(mergeKey(agentCandidates[i]), input.discriminator);
+            });
+            const { candidates: allCandidates, demotions } = applyDiscriminatorClaims([...merged.values()], claimsByKey, diffText, reposWithoutDiff);
             // An empty union would persist an authoritative plan with an empty
             // GENERATE list, which the generation gate then enforces — bricking
             // the run until re-registration. Reject instead so the agent can
@@ -351,7 +433,7 @@ export function registerRegisterTestPlanTool(server) {
                     "Submit your complete candidate list (every test you would generate or recommend) in `candidates` — an empty plan would block all generation.");
                 return errorResult;
             }
-            const budgetContext = resolveBudgetContext(stateData);
+            const budgetContext = resolveBudgetContext(stateData, fullState);
             const result = selectPlan(allCandidates, { ...budgetContext, demotions, diffText });
             const approvedPlan = {
                 planId: crypto.randomUUID(),

package/build/types/TestAnalysis.d.ts

@@ -34,12 +34,16 @@ export interface MaintenanceActionCore {
     testType: TestType;
     endpoint: string;
     rationale: string;
+    /** When selectors are abstracted into a page object, pomFile is the POM path to edit.
+     *  testFilePath remains the spec (for catalog lookup and report); pomFile is what gets
+     *  patched. Part of the core shape because the EXECUTED file (the spec, which carries the
+     *  execution records) and the EDITED file (the POM) are structurally different, and every
+     *  downstream stage that reasons about the edit needs both — notably the report-time
+     *  working-tree check, which otherwise calls a POM-backed UPDATE unbacked (SKYR-4129). */
+    pomFile?: string;
 }
 /** Normalized internal recommendation built from LLM-supplied args.recommendations. */
 export interface DriftRecommendation extends MaintenanceActionCore {
-    /** When selectors are abstracted into a page object, pomFile is the POM path to edit.
-     *  testFilePath remains the spec (for catalog lookup and report); pomFile is what gets patched. */
-    pomFile?: string;
     priority: RecommendationPriority;
     estimatedWork: EstimatedWork;
     updateInstructions: string;

package/build/types/TestExecution.d.ts

@@ -26,6 +26,20 @@ export interface TestExecutionResult extends TestExecutionData {
     testFile: string;
     videoPath?: string;
 }
+/**
+ * One browser execution's recorded video, as persisted in run state by
+ * skyramp_execute_test and read back by skyramp_submit_report (SKYR-4156).
+ *
+ * `status`/`executedAt` are not rendered in the report — they identify WHICH
+ * execution the referenced recording belongs to, which matters because a retried
+ * test leaves a video directory behind for every attempt.
+ */
+export interface VideoRecord {
+    /** Host path to the recorded video.webm. */
+    videoPath: string;
+    status: TestExecutionStatus;
+    executedAt: string;
+}
 export interface BatchExecutionResult {
     totalTests: number;
     passed: number;

package/build/types/TestTypes.js

@@ -216,8 +216,9 @@ export const baseTestSchema = {
         .string()
         .default("")
         .describe("MUST be string of comma separated values like 'id=1,name=John' for URL query parameters. "
-        + "Workspace-configured api.defaultQueryParams (if set) are merged in automatically — "
-        + "no need to repeat them here. An explicit value for the same key here overrides the workspace default."),
+        + "Workspace-configured api.defaultQueryParams (if set) are merged in automatically, with any "
+        + "api.queryParamOverrides entry whose pathPattern matches this endpoint layered on top — "
+        + "no need to repeat them here. An explicit value for the same key here overrides both."),
     formParams: z
         .string()
         .default("")

package/build/types/TestbotPromptOptions.d.ts

@@ -0,0 +1,34 @@
+import type { Service } from "../workspace/workspace.js";
+/** One related repository to analyze as shared context in multi-repo mode. */
+export interface RelatedRepository {
+    repositoryPath: string;
+    baseBranch?: string;
+    /** `owner/repo` slug, resolved by the action from the checkout's git remote.
+     *  Used verbatim as the `repository` argument/attribution for this repo so the
+     *  agent never has to infer it. */
+    repo: string;
+}
+/**
+ * Options accepted by getTestbotPrompt (src/prompts/testbot/testbot-prompts.ts).
+ * Shared here — rather than declared inline in the prompt module — so testbot.git
+ * can import this exact type instead of hand-maintaining its own mirror.
+ */
+export interface TestbotPromptOptions {
+    prTitle: string;
+    prDescription: string;
+    repositoryPath: string;
+    baseBranch?: string;
+    maxRecommendations?: number;
+    maxGenerate?: number;
+    /** Reserved — accepted for API compat but not yet wired into the prompt. */
+    maxCritical?: number;
+    prNumber?: number;
+    userPrompt?: string;
+    services?: Service[];
+    uiCredentials?: string;
+    testsRepoDir?: string;
+    relatedRepositories?: RelatedRepository[];
+    primaryRepo?: string;
+    planOnly?: boolean;
+    language?: string;
+}

package/build/types/TestbotPromptOptions.js

@@ -0,0 +1 @@
+export {};

package/build/types/TestbotReport.d.ts

@@ -2,6 +2,15 @@ import type { DriftAction } from "./TestAnalysis.js";
 import type { TestExecutionStatus } from "./TestExecution.js";
 import type { HttpMethod, TestType } from "./TestTypes.js";
 import type { ReuseOutcome } from "./ReuseOutcome.js";
+/** Classification of an issuesFound entry. Bug is a product/code defect; the
+ *  other values are tooling noise that the Testbot report renders in its
+ *  Configuration Errors section instead of Issues Found. */
+export declare enum IssueFoundCategory {
+    Bug = "bug",
+    Lint = "lint",
+    Type = "type",
+    Config = "config"
+}
 /**
  * Shape of the JSON report written by skyramp_submit_report and read by testbot
  * for rendering as Markdown. All fields mirror the corresponding Zod schemas in
@@ -69,6 +78,7 @@ export interface TestbotReport {
     issuesFound: {
         description: string;
         severity?: "critical" | "high" | "medium" | "low";
+        category: IssueFoundCategory;
     }[];
     nextSteps: string[];
     commitMessage: string;

package/build/types/TestbotReport.js

@@ -1 +1,10 @@
-export {};
+/** Classification of an issuesFound entry. Bug is a product/code defect; the
+ *  other values are tooling noise that the Testbot report renders in its
+ *  Configuration Errors section instead of Issues Found. */
+export var IssueFoundCategory;
+(function (IssueFoundCategory) {
+    IssueFoundCategory["Bug"] = "bug";
+    IssueFoundCategory["Lint"] = "lint";
+    IssueFoundCategory["Type"] = "type";
+    IssueFoundCategory["Config"] = "config";
+})(IssueFoundCategory || (IssueFoundCategory = {}));

package/build/types/index.d.ts

@@ -2,5 +2,7 @@ export { TestExecutionStatus } from "./TestExecution.js";
 export { DriftAction } from "./TestAnalysis.js";
 export { TestType, HttpMethod } from "./TestTypes.js";
 export type { TestbotReport } from "./TestbotReport.js";
+export { IssueFoundCategory } from "./TestbotReport.js";
 export { ReuseDeclinedBy, ReuseVerificationOutcome } from "./ReuseOutcome.js";
 export type { ReuseOutcome, ReuseSkippedEntry } from "./ReuseOutcome.js";
+export type { RelatedRepository, TestbotPromptOptions, } from "./TestbotPromptOptions.js";

package/build/types/index.js

@@ -1,4 +1,5 @@
 export { TestExecutionStatus } from "./TestExecution.js";
 export { DriftAction } from "./TestAnalysis.js";
 export { TestType, HttpMethod } from "./TestTypes.js";
+export { IssueFoundCategory } from "./TestbotReport.js";
 export { ReuseDeclinedBy, ReuseVerificationOutcome } from "./ReuseOutcome.js";

package/build/utils/AnalysisStateManager.d.ts

@@ -7,13 +7,33 @@ import type { CandidateUiPage } from "./uiPageEnumerator.js";
 import type { FrontendFileIntegration } from "../types/FrontendIntegration.js";
 import type { ApprovedPlanItem } from "../types/Recommendation.js";
 import type { ExternalTestRunRecord } from "../types/ExternalTestExecution.js";
+import type { VideoRecord } from "../types/TestExecution.js";
 export type { CandidateUiPage } from "./uiPageEnumerator.js";
 export declare function setTestsRepoDir(dir: string | undefined): void;
 export declare function getTestsRepoDir(): string | undefined;
-/** Filename of the run-scoped analysis state file under `<RUNNER_TEMP>/skyramp/`.
+/** Filename of the run-scoped analysis state file under `runArtifactDir()`.
  *  Single-sourced so the constructor that WRITES there and `resolveRunStatePath`
  *  which LOOKS there cannot drift apart. */
 export declare const RUN_STATE_FILE_NAME = "analyze-changes-state.json";
+/**
+ * Directory holding this run's Skyramp artifacts — the state file, and the report written
+ * beside it (SKYR-4147) — or undefined outside a run.
+ *
+ * `RUNNER_TEMP` is a fresh directory per CI job, and the caller and this server can each
+ * work it out from the environment on their own. So neither has to tell the other where
+ * the run's files live, and the path never passes through the model.
+ *
+ * The GitHub Action is the only caller customers run, and GitHub sets `RUNNER_TEMP` for
+ * it; the eval harness sets it itself. Nothing customers run is on another CI system, so
+ * the GitHub-specific name is only a naming problem — it does not break anything today.
+ * If a caller on another CI system is added, rename this then, or let it read that
+ * system's variable. Do not add a second variable for a caller that does not exist.
+ *
+ * Kept in one place for the same reason `RUN_STATE_FILE_NAME` is: the directory used to be
+ * written out at three call sites, so only the filename was safe from the three copies
+ * drifting apart. testbot keeps its matching copy in one place too, in `skyrampTempDir()`.
+ */
+export declare function runArtifactDir(): string | undefined;
 export declare function setActiveRunStatePath(stateFilePath: string): void;
 export declare function getActiveRunStatePath(): string | undefined;
 /** Reset the run anchor — for tests, and as a safety hook between runs. */
@@ -25,7 +45,7 @@ export declare function clearActiveRunStatePath(): void;
  * `setActiveRunStatePath` is only called by skyramp_analyze_changes on multi-repo
  * runs (the ones carrying a `repository` param), but a single-repo Testbot run's
  * path is still deterministic in CI: the StateManager constructor above roots
- * "analysis" state under `$RUNNER_TEMP/skyramp/`. Falling back to that covers
+ * "analysis" state under `runArtifactDir()`. Falling back to that covers
  * single-repo runs without a new anchor mechanism. Standalone/IDE usage has no
  * RUNNER_TEMP and resolves to undefined — correct, since there is no run state.
  *
@@ -166,6 +186,20 @@ export interface UnifiedAnalysisState {
      *  which computes every value in-process; skyramp_submit_report merges it into
      *  the report's `reuse` field. Never supplied by the LLM. */
     reuseOutcomes?: Record<string, ReuseRecord>;
+    /**
+     * SKYR-4156. Recorded video per executed browser test, keyed by test-file
+     * BASENAME (the same key `reuseOutcomes` uses, so matching needs no path
+     * normalization). Written in-process by skyramp_execute_test — the only place
+     * the path is known — and merged into the report's `testResults[].videoPath` by
+     * skyramp_submit_report. Never supplied by the LLM.
+     *
+     * Deliberately separate from `existingTests[].executionBefore/After`: those only
+     * exist for tests skyramp_analyze_changes discovered, so a NEWLY generated spec
+     * has nowhere to record into — which is exactly how one run recorded three videos
+     * and referenced none of them. Last write wins, so a retried execution replaces
+     * the earlier attempt's now-stale directory.
+     */
+    executionVideos?: Record<string, VideoRecord>;
 }
 /**
  * State file metadata

package/build/utils/AnalysisStateManager.js

@@ -35,10 +35,32 @@ export function getTestsRepoDir() {
  * Single-repo / standalone calls (no `repository`) never set or read this.
  */
 let _activeRunStatePath;
-/** Filename of the run-scoped analysis state file under `<RUNNER_TEMP>/skyramp/`.
+/** Filename of the run-scoped analysis state file under `runArtifactDir()`.
  *  Single-sourced so the constructor that WRITES there and `resolveRunStatePath`
  *  which LOOKS there cannot drift apart. */
 export const RUN_STATE_FILE_NAME = "analyze-changes-state.json";
+/**
+ * Directory holding this run's Skyramp artifacts — the state file, and the report written
+ * beside it (SKYR-4147) — or undefined outside a run.
+ *
+ * `RUNNER_TEMP` is a fresh directory per CI job, and the caller and this server can each
+ * work it out from the environment on their own. So neither has to tell the other where
+ * the run's files live, and the path never passes through the model.
+ *
+ * The GitHub Action is the only caller customers run, and GitHub sets `RUNNER_TEMP` for
+ * it; the eval harness sets it itself. Nothing customers run is on another CI system, so
+ * the GitHub-specific name is only a naming problem — it does not break anything today.
+ * If a caller on another CI system is added, rename this then, or let it read that
+ * system's variable. Do not add a second variable for a caller that does not exist.
+ *
+ * Kept in one place for the same reason `RUN_STATE_FILE_NAME` is: the directory used to be
+ * written out at three call sites, so only the filename was safe from the three copies
+ * drifting apart. testbot keeps its matching copy in one place too, in `skyrampTempDir()`.
+ */
+export function runArtifactDir() {
+    const runnerTemp = process.env.RUNNER_TEMP?.trim();
+    return runnerTemp ? path.join(runnerTemp, "skyramp") : undefined;
+}
 export function setActiveRunStatePath(stateFilePath) {
     _activeRunStatePath = stateFilePath;
 }
@@ -56,7 +78,7 @@ export function clearActiveRunStatePath() {
  * `setActiveRunStatePath` is only called by skyramp_analyze_changes on multi-repo
  * runs (the ones carrying a `repository` param), but a single-repo Testbot run's
  * path is still deterministic in CI: the StateManager constructor above roots
- * "analysis" state under `$RUNNER_TEMP/skyramp/`. Falling back to that covers
+ * "analysis" state under `runArtifactDir()`. Falling back to that covers
  * single-repo runs without a new anchor mechanism. Standalone/IDE usage has no
  * RUNNER_TEMP and resolves to undefined — correct, since there is no run state.
  *
@@ -70,8 +92,9 @@ export function resolveRunStatePath(explicitPath) {
     const anchored = getActiveRunStatePath();
     if (anchored)
         return anchored;
-    if (process.env.RUNNER_TEMP) {
-        return path.join(process.env.RUNNER_TEMP, "skyramp", RUN_STATE_FILE_NAME);
+    const runDir = runArtifactDir();
+    if (runDir) {
+        return path.join(runDir, RUN_STATE_FILE_NAME);
     }
     return undefined;
 }
@@ -169,17 +192,15 @@ export class StateManager {
     constructor(stateType = "analysis", sessionId, stateDir, stateFilePath) {
         this.stateType = stateType;
         this.sessionId = sessionId || crypto.randomUUID();
+        const runDir = stateType === "analysis" ? runArtifactDir() : undefined;
         if (stateFilePath) {
             this.stateFile = stateFilePath;
         }
-        else if (stateType === "analysis" && process.env.RUNNER_TEMP) {
-            // In CI (testbot action), RUNNER_TEMP is a job-isolated dir that both the
-            // action and this tool can independently derive — no LLM input needed.
-            // TODO: interim step — remove this branch when stateFile and summaryOutputFile are merged
-            // (see getTestbotPrompt TODO). RUNNER_TEMP is GitHub Actions-specific; other CI systems
-            // (Jenkins, GitLab, Buildkite) must set it explicitly. Once merged, path flows through
-            // summaryOutputFile which is already testbot-controlled and CI-agnostic.
-            this.stateFile = path.join(process.env.RUNNER_TEMP, "skyramp", RUN_STATE_FILE_NAME);
+        else if (runDir) {
+            // In CI, the run directory is fresh per job and the caller and this tool each work
+            // it out from the environment — no LLM input needed. It is also where
+            // skyramp_submit_report writes the report (SKYR-4147).
+            this.stateFile = path.join(runDir, RUN_STATE_FILE_NAME);
         }
         else {
             const baseDir = stateDir || os.tmpdir();
@@ -435,7 +456,7 @@ export class StateManager {
      * @returns Number of files deleted
      */
     static async cleanupOldFiles(maxAgeHours = 24, stateDir, stateTypes) {
-        const baseDir = stateDir || (process.env.RUNNER_TEMP ? path.join(process.env.RUNNER_TEMP, "skyramp") : os.tmpdir());
+        const baseDir = stateDir || runArtifactDir() || os.tmpdir();
         const files = await fs.promises.readdir(baseDir).catch(() => []);
         const statePrefixes = stateTypes
             ? stateTypes.map((t) => STATE_FILE_PREFIXES[t])

package/build/utils/frontendSelectors.js

@@ -74,7 +74,6 @@ export function extractChangedSelectors(fileDiff) {
     // `data-testid="x"`, `data-testid={'x'}`, `data-testid={`x`}`. The closing delimiter
     // deliberately rejects interpolated template literals (`data-testid={`members-${id}`}`),
     // which would otherwise leak a partial prefix (`members-`) into the selector set.
-    // eslint-disable-next-line no-useless-escape
     const ATTR = /\bdata-(?:test-?id|test|cy|qa)\b\s*=\s*\{?\s*[`'"]([A-Za-z][\w:-]{2,})[`'"]/g;
     const GET_BY_TEST_ID = /getByTestId\(\s*[`'"]([A-Za-z][\w:-]{2,})[`'"]/g;
     const KEBAB = /[a-z][a-z0-9]*(?:-{1,2}[a-z0-9]+)+/g;