@skyramp/mcp 0.2.6 → 0.2.7

package/build/tools/test-management/uiAnalyzeChangesTool.test.js

@@ -1,147 +0,0 @@
-jest.mock("@skyramp/skyramp", () => ({
-    WorkspaceConfigManager: { create: jest.fn() },
-}));
-import { runUiAnalyzeChanges } from "./uiAnalyzeChangesTool.js";
-import * as workspaceAuth from "../../utils/workspaceAuth.js";
-import * as fs from "fs";
-import * as os from "os";
-import * as path from "path";
-function makeRepoWithDiff(changedFiles) {
-    const dir = fs.mkdtempSync(path.join(os.tmpdir(), "skyramp-uiac-test-"));
-    // Write .skyramp_git_diff with the requested file changes — match the
-    // format the runtime uses (raw `diff --git a/X b/X` block).
-    const diff = changedFiles
-        .map((f) => `diff --git a/${f} b/${f}\n+++ b/${f}\n@@ -0,0 +1,1 @@\n+x`)
-        .join("\n");
-    fs.writeFileSync(path.join(dir, ".skyramp_git_diff"), diff);
-    return dir;
-}
-describe("runUiAnalyzeChanges", () => {
-    let readSpy;
-    beforeEach(() => {
-        readSpy = jest.spyOn(workspaceAuth, "readWorkspaceConfigRaw");
-    });
-    afterEach(() => {
-        readSpy.mockRestore();
-    });
-    it("returns empty changedFrontendFiles for backend-only diffs", async () => {
-        readSpy.mockResolvedValue({ services: [] });
-        const repo = makeRepoWithDiff(["api/handlers/users.ts"]);
-        const result = await runUiAnalyzeChanges({ repositoryPath: repo });
-        expect(result.uiContext.changedFrontendFiles).toEqual([]);
-        expect(result.uiContext.candidateUiPages).toEqual([]);
-        expect(result.instructions).toMatch(/no UI changes/i);
-        fs.rmSync(repo, { recursive: true, force: true });
-    });
-    it("returns candidateUiPages and capture instructions for frontend diffs", async () => {
-        readSpy.mockResolvedValue({
-            services: [{ serviceName: "frontend", api: { baseUrl: "http://localhost:3000" } }],
-        });
-        const repo = makeRepoWithDiff(["frontend/src/components/Cart.tsx"]);
-        const result = await runUiAnalyzeChanges({ repositoryPath: repo });
-        expect(result.uiContext.changedFrontendFiles.length).toBeGreaterThan(0);
-        expect(result.uiContext.candidateUiPages.length).toBeGreaterThan(0);
-        expect(result.instructions).toMatch(/browser_navigate/);
-        expect(result.instructions).toMatch(/browser_blueprint/);
-        expect(result.instructions).toMatch(/skyramp_analyze_changes/);
-        // Captures stay in agent's tool-result history; we no longer thread them
-        // back through analyze_changes as a param.
-        expect(result.instructions).not.toMatch(/capturedBlueprints/);
-        fs.rmSync(repo, { recursive: true, force: true });
-    });
-    it("includes inline-credentials login step in non-testbot mode", async () => {
-        // SKYRAMP_FEATURE_TESTBOT is not set here, so the tool emits the
-        // credentials inline rather than referencing the testbot's
-        // <ui-credentials> context tag (which doesn't exist outside testbot).
-        delete process.env.SKYRAMP_FEATURE_TESTBOT;
-        readSpy.mockResolvedValue({
-            services: [{ serviceName: "frontend", api: { baseUrl: "http://localhost:3000" } }],
-        });
-        const repo = makeRepoWithDiff(["frontend/src/components/Cart.tsx"]);
-        const result = await runUiAnalyzeChanges({
-            repositoryPath: repo,
-            uiCredentials: "admin@example.com:admin",
-        });
-        expect(result.instructions).toMatch(/log in/i);
-        expect(result.instructions).toContain("admin@example.com:admin");
-        fs.rmSync(repo, { recursive: true, force: true });
-    });
-    it("references the <ui-credentials> testbot context tag in testbot mode", async () => {
-        process.env.SKYRAMP_FEATURE_TESTBOT = "1";
-        try {
-            readSpy.mockResolvedValue({
-                services: [{ serviceName: "frontend", api: { baseUrl: "http://localhost:3000" } }],
-            });
-            const repo = makeRepoWithDiff(["frontend/src/components/Cart.tsx"]);
-            const result = await runUiAnalyzeChanges({
-                repositoryPath: repo,
-                uiCredentials: "admin@example.com:admin",
-            });
-            expect(result.instructions).toMatch(/log in/i);
-            expect(result.instructions).toContain("ui-credentials");
-            // Inline credentials should NOT leak in testbot mode (the
-            // <ui-credentials> tag is the secure carrier in that flow).
-            expect(result.instructions).not.toContain("admin@example.com:admin");
-            fs.rmSync(repo, { recursive: true, force: true });
-        }
-        finally {
-            delete process.env.SKYRAMP_FEATURE_TESTBOT;
-        }
-    });
-    it("instructs the agent to proceed to analyze_changes (source-grounded) when frontend baseUrl unresolvable", async () => {
-        readSpy.mockResolvedValue(null); // no workspace yml
-        const repo = makeRepoWithDiff(["frontend/src/components/Cart.tsx"]);
-        const result = await runUiAnalyzeChanges({ repositoryPath: repo });
-        expect(result.uiContext.changedFrontendFiles.length).toBeGreaterThan(0);
-        expect(result.uiContext.candidateUiPages).toEqual([]);
-        expect(result.instructions).toMatch(/source-grounded/i);
-        fs.rmSync(repo, { recursive: true, force: true });
-    });
-    // Flutter support — the headline case the Confluence plan validates.
-    // Without the .dart classifier change, a Flutter PR returns
-    // changedFrontendFiles: [] → "No UI changes detected" → agent skips
-    // browser_navigate entirely. With the change + a Flutter pubspec, the
-    // diff registers as frontend and the agent gets told to navigate.
-    it("recognises .dart files as frontend in a Flutter project (with pubspec.yaml)", async () => {
-        readSpy.mockResolvedValue({
-            services: [
-                {
-                    serviceName: "birdle-frontend",
-                    language: "typescript",
-                    framework: "playwright",
-                    api: { baseUrl: "http://localhost:8080" },
-                },
-            ],
-        });
-        const repo = makeRepoWithDiff(["lib/main.dart"]);
-        // Write a Flutter pubspec.yaml at the repo root so hasFlutterSdkDep returns true
-        fs.writeFileSync(path.join(repo, "pubspec.yaml"), `name: birdle\ndependencies:\n  flutter:\n    sdk: flutter\n`);
-        const result = await runUiAnalyzeChanges({ repositoryPath: repo });
-        expect(result.uiContext.changedFrontendFiles).toContain("lib/main.dart");
-        expect(result.uiContext.candidateUiPages.length).toBeGreaterThan(0);
-        expect(result.instructions).toMatch(/browser_navigate/);
-        fs.rmSync(repo, { recursive: true, force: true });
-    });
-    it("does NOT recognise .dart files as frontend without a Flutter pubspec.yaml", async () => {
-        // Pure Dart project (server/CLI) — pubspec.yaml absent or missing the SDK dep.
-        // .dart files should NOT enter the UI pipeline.
-        readSpy.mockResolvedValue({ services: [] });
-        const repo = makeRepoWithDiff(["bin/server.dart"]);
-        // No pubspec.yaml written at all
-        const result = await runUiAnalyzeChanges({ repositoryPath: repo });
-        expect(result.uiContext.changedFrontendFiles).toEqual([]);
-        expect(result.uiContext.candidateUiPages).toEqual([]);
-        expect(result.instructions).toMatch(/no UI changes/i);
-        fs.rmSync(repo, { recursive: true, force: true });
-    });
-    it("does NOT recognise .dart files as frontend in a pure Dart project (pubspec without flutter SDK dep)", async () => {
-        // pubspec.yaml exists but declares a Dart server (e.g. shelf) — no flutter SDK
-        readSpy.mockResolvedValue({ services: [] });
-        const repo = makeRepoWithDiff(["bin/server.dart"]);
-        fs.writeFileSync(path.join(repo, "pubspec.yaml"), `name: my_dart_server\ndependencies:\n  shelf: ^1.4.0\n`);
-        const result = await runUiAnalyzeChanges({ repositoryPath: repo });
-        expect(result.uiContext.changedFrontendFiles).toEqual([]);
-        expect(result.uiContext.candidateUiPages).toEqual([]);
-        fs.rmSync(repo, { recursive: true, force: true });
-    });
-});