@skyramp/mcp 0.2.3 → 0.2.5-rc.1

package/build/playwright/registerPlaywrightTools.js

@@ -40,11 +40,6 @@ export async function registerPlaywrightTools(server, options) {
         'browser_select_option',
         'browser_hover',
         'browser_drag',
-        'browser_mouse_move_xy',
-        'browser_mouse_click_xy',
-        'browser_mouse_drag_xy',
-        'browser_mouse_down',
-        'browser_mouse_up',
         'browser_file_upload',
         'browser_evaluate',
         'browser_tabs',
@@ -54,6 +49,8 @@ export async function registerPlaywrightTools(server, options) {
         'browser_assert',
         'browser_assert_api_request',
         'browser_assert_table_cell',
+        'browser_mouse_action',
+        'browser_visual_snapshot',
         'skyramp_export_zip',
         'skyramp_load_trace',
         'browser_mouse_action',
@@ -93,26 +90,7 @@ function jsonSchemaToZod(schema) {
     const required = new Set(schema.required || []);
     const shape = {};
     for (const [key, prop] of Object.entries(properties)) {
-        let field;
-        switch (prop.type) {
-            case "string":
-                field = prop.enum
-                    ? z.enum(prop.enum)
-                    : z.string();
-                break;
-            case "number":
-            case "integer":
-                field = z.number();
-                break;
-            case "boolean":
-                field = z.boolean();
-                break;
-            case "array":
-                field = z.array(prop.items ? jsonSchemaPropertyToZod(prop.items) : z.unknown());
-                break;
-            default:
-                field = z.unknown();
-        }
+        let field = jsonSchemaPropertyToZod(prop);
         if (prop.description)
             field = field.describe(prop.description);
         if (prop.default !== undefined)
@@ -136,6 +114,24 @@ function jsonSchemaPropertyToZod(prop) {
             return z.boolean();
         case "array":
             return z.array(prop.items ? jsonSchemaPropertyToZod(prop.items) : z.unknown());
+        case "object": {
+            // Nested object (e.g. a clip rect). Recurse into its properties so the
+            // SDK registers a real object schema; without this it falls through to
+            // z.unknown(), which serializes the nested object as a string and the
+            // inner backend's z.object(...) then rejects it.
+            const nestedProps = prop.properties || {};
+            const nestedRequired = new Set(prop.required || []);
+            const nestedShape = {};
+            for (const [k, p] of Object.entries(nestedProps)) {
+                let f = jsonSchemaPropertyToZod(p);
+                if (p.description)
+                    f = f.describe(p.description);
+                if (!nestedRequired.has(k))
+                    f = f.optional();
+                nestedShape[k] = f;
+            }
+            return z.object(nestedShape);
+        }
         default:
             return z.unknown();
     }

package/build/playwright/traceRecordingPrompt.js

@@ -4,7 +4,7 @@
  */
 import { z } from "zod";
 import { logger } from "../utils/logger.js";
-import { SKYRAMP_QA_PERSONA } from "../prompts/personas.js";
+import { getPersonaPrefix } from "../prompts/personas.js";
 export function getTraceRecordingPromptText(opts) {
     const outputDir = opts?.outputDir;
     const modularize = opts?.modularize ?? true;
@@ -19,7 +19,7 @@ export function getTraceRecordingPromptText(opts) {
         : `- Do NOT run \`skyramp_modularization\` — skip modularization in CI.`;
     return `## Skyramp UI Test Recording
 
-${SKYRAMP_QA_PERSONA} For UI recording, every action must be grounded in what \`browser_snapshot\` returns. If an element is not visible in the snapshot, do not interact with it.
+${getPersonaPrefix()} For UI recording, every action must be grounded in what \`browser_snapshot\` returns. If an element is not visible in the snapshot, do not interact with it.
 
 ### Required workflow
 

package/build/prompts/test-maintenance/actionsInstructions.js

@@ -0,0 +1,60 @@
+/**
+ * Prompt language for skyramp_actions output — the LLM_INSTRUCTIONS block
+ * emitted to the agent that applies UPDATE and REGENERATE edits.
+ *
+ * Kept separate from actionsTool.ts so prompt text is co-located with other
+ * maintenance prompts and can be reviewed/edited without touching tool logic.
+ */
+/** Strategy string for URL-path find-and-replace updates. */
+export function buildRenameStrategy() {
+    return `For each file, find-and-replace all occurrences of oldPath with newPath. Do NOT regenerate or restructure the test — only update the URL paths.`;
+}
+/** Strategy string for file renames after path substitution. */
+export function buildFileRenameStrategy() {
+    return `After updating path content in each file, rename the file using 'mv' or equivalent. Use git mv if the repo tracks the file.`;
+}
+/** Strategy string for in-place UPDATE edits. */
+export function buildUpdateStrategy() {
+    return `For each file in update_context, apply the changes described in context. Preserve all existing test logic — only add or adjust what is described in context. After applying all edits, call skyramp_enhance_assertions with each updated file path.`;
+}
+/** Strategy string for REGENERATE — call generation tool to overwrite the file. */
+export function buildRegenerateStrategy() {
+    return `For each file in regenerate_context, call the appropriate generation tool (skyramp_integration_test_generation or skyramp_contract_test_generation) with outputDir set to the file's directory and output set to the filename. Use existing_content to determine the test type, endpoint, auth pattern, and language. The generation tool will overwrite the file. Do NOT use skyramp_ui_test_generation here — UI test regeneration requires a recorded trace (playwrightInput) and must be handled separately.`;
+}
+/** Per-file instruction block for a single UPDATE recommendation. */
+export function buildUpdateFileInstruction(params) {
+    const { testFile, renames, suggestedNewFile, updateInstructions, rationale } = params;
+    const renameTable = renames.length > 0 ? [
+        `**Endpoint Rename Detected — Path Substitution Required:**\n`,
+        `| Old Path | New Path | Method |`,
+        `|----------|----------|--------|`,
+        ...renames.map((r) => `| \`${r.oldPath}\` | \`${r.newPath}\` | ${r.method} |`),
+        ``,
+        `**Action:** Find-and-replace all occurrences of the old path with the new path in this test file. Do NOT change any test logic, assertions, or structure — only update the URL paths.\n`,
+        ...(suggestedNewFile ? [
+            `**File Rename:** After updating the paths, rename this file:`,
+            `- From: \`${testFile.split("/").pop()}\``,
+            `- To: \`${suggestedNewFile.split("/").pop()}\`\n`,
+        ] : []),
+    ].join("\n") : "";
+    const changeBlock = updateInstructions
+        ? `**What to change:**\n\n${updateInstructions}\n`
+        : renames.length === 0
+            ? [
+                rationale ? `**Why:** ${rationale}\n` : "",
+                `**Action:** Update this test file based on the rationale above.\n`,
+            ].filter(Boolean).join("\n")
+            : "";
+    return `\n### ${testFile}\n\n${renameTable}${changeBlock}`;
+}
+/** Per-file instruction block for a single REGENERATE recommendation. */
+export function buildRegenerateFileInstruction(params) {
+    const { testFile, updateInstructions, outputDir, outputFile } = params;
+    const whatChanged = updateInstructions ? `**What changed:**\n\n${updateInstructions}\n\n` : "";
+    return [
+        `\n### ${testFile}\n`,
+        `**Action: REGENERATE** — the response shape changed too drastically for targeted edits.\n`,
+        whatChanged,
+        `Call the appropriate generation tool (e.g. \`skyramp_integration_test_generation\`, \`skyramp_contract_test_generation\`) with \`outputDir: "${outputDir}"\` and \`output: "${outputFile}"\` to overwrite this file from scratch. Use the provided existing file content for context on the endpoint, auth pattern, and test structure — replicate the test type and language.\n`,
+    ].join("\n");
+}

package/build/prompts/test-maintenance/drift-analysis-prompt.js

@@ -1,102 +1,19 @@
-import { buildActionDecisionMatrix, buildBreakingChangePatterns, buildTestAssessmentGuidelines, buildAddRecommendationGuidelines, buildDriftOutputChecklist, buildUpdateExecutionRules, } from "./driftAnalysisSections.js";
-import { isTestbotEnabled } from "../../utils/featureFlags.js";
-import { readDiffFile } from "../../utils/utils.js";
-export function buildDriftAnalysisPrompt(params) {
-    const { existingTests, scannedEndpoints, repositoryPath, stateFile, routerMountContext, candidateRouteFiles, diffFilePath } = params;
-    // Read raw diff once — used for both the inline summary block and the per-line file reference.
-    const rawDiff = readDiffFile(diffFilePath);
-    let newEndpointCount = 0;
-    let diffSection = "";
-    if (rawDiff) {
-        const lines = rawDiff.split("\n");
-        const newEndpointMatch = rawDiff.match(/\*\*New Endpoints\*\*\s+\((\d+)\)/);
-        if (newEndpointMatch)
-            newEndpointCount = parseInt(newEndpointMatch[1], 10);
-        diffSection = `## Branch Diff
-\`\`\`
-${lines.slice(0, 200).join("\n")}
-\`\`\`
-`;
-    }
-    const testListSection = existingTests.length > 0
-        ? `## Existing Test Files (${existingTests.length})
-${existingTests.map((t) => `- ${t.testFile} (${t.testType})`).join("\n")}
-`
-        : `## Existing Test Files
-No existing Skyramp tests found in repository.
-`;
-    const scannedSection = scannedEndpoints.length > 0
-        ? `## Scanned Endpoints (${scannedEndpoints.length})
-Note: paths below come from static analysis and may be incomplete for nested resources or unsupported frameworks. Use the Routing entry-point files section below to verify and reconstruct full paths.
-${scannedEndpoints.map((ep) => {
-            let methods;
-            if (Array.isArray(ep.methods)) {
-                methods = ep.methods.map((m) => (typeof m === "string" ? m : m.method)).join("|");
-            }
-            else {
-                methods = ep.method;
-            }
-            return `- ${methods} ${ep.path}`;
-        }).join("\n")}
-`
-        : "";
-    const mountSection = routerMountContext?.length
-        ? `## Routing entry-point files
-Read these to trace the full router/module hierarchy when verifying endpoint paths:
-${routerMountContext.map(f => `- \`${f}\``).join("\n")}
-`
-        : "";
-    const hasJavaFiles = candidateRouteFiles?.some(f => /\.(java|kt)$/.test(f)) ?? false;
-    const candidateFilesSection = candidateRouteFiles && candidateRouteFiles.length > 0
-        ? `## Route Files (read these to find endpoints from any framework)
-${candidateRouteFiles.map(f => `- ${f}`).join("\n")}
-${hasJavaFiles ? "Note — Java Spring: full URL = class-level `@RequestMapping` prefix + method-level path. If the prefix is a constant reference (e.g. `@RequestMapping(Url.PAGE_URL)`), find the constant — same file, inner class, or a separate `Url.java` — and resolve it (including `+` concatenation)." : ""}
-`
-        : "";
-    const diffFileSection = diffFilePath
-        ? `## Raw Diff File
-Read \`${diffFilePath}\` to get the full line-by-line diff. Use it to detect:
-- Additive response fields: lines starting with \`+\` inside a view/serializer/controller (e.g. \`+ "newField":\`, \`+ newField =\`)
-- Renamed routes: \`-  @app.route("/old")\` / \`+  @app.route("/new")\` or similar framework patterns
-- Status code changes: \`- return 200\` / \`+ return 201\`, \`- res.status(200)\` / \`+ res.status(204)\`
-- Auth additions/removals: \`+ @require_auth\`, \`- @login_required\`, middleware changes
-Read the file once and cache its contents — it is the primary source for per-line breaking-change detection. Use it as evidence for Checks A–D below.
-`
-        : "";
-    // In inline mode (testbot), skip the context header — existing tests and diff
-    // are provided by skyramp_analyze_changes at runtime, not at prompt-build time.
-    const contextSection = isTestbotEnabled()
-        ? ""
-        : `# Test Health Analysis
-
-**Repository**: \`${repositoryPath}\`
-**Existing tests**: ${existingTests.length}
-**New endpoints in diff**: ${newEndpointCount}
-
-${diffSection}
-${diffFileSection}
-${testListSection}
-${scannedSection}
-${mountSection}
-${candidateFilesSection}`;
-    if (isTestbotEnabled()) {
-        // Testbot inline mode: all maintenance logic lives here so the testbot
-        // prompt only orchestrates steps without duplicating rules.
-        // No persona statement here — the outer testbot prompt already establishes
-        // the agent's context; a nested identity statement causes role confusion.
-        return `<drift_analysis_rules>
-${buildActionDecisionMatrix()}
-${buildUpdateExecutionRules()}
-${buildDriftOutputChecklist(existingTests.length, newEndpointCount, isTestbotEnabled())}
-</drift_analysis_rules>`;
-    }
-    return `You are acting as a Skyramp Integration Architect. Your responsibility is to assess each existing test against the branch diff and determine the correct maintenance action.
-
-${contextSection}
-${buildActionDecisionMatrix()}
-${buildBreakingChangePatterns()}
-${buildTestAssessmentGuidelines()}
-${buildUpdateExecutionRules()}
-${buildAddRecommendationGuidelines()}
-${buildDriftOutputChecklist(existingTests.length, newEndpointCount, isTestbotEnabled(), stateFile)}`;
+import { buildActionDecisionTree, buildCheckAdditiveFields, buildCheckEndpointExistence, buildCheckResponseShape, buildCheckAuthAndAuthorization, buildCheckBehavioralContract, buildCheckAssignAction, buildDriftOutputChecklist, } from "./driftAnalysisSections.js";
+import { PromptPlan } from "../test-recommendation/promptPlan.js";
+const _plan = new PromptPlan()
+    .addPhase("maintenance", "Test Maintenance Assessment", {
+    headerLevel: "##",
+    stepFormat: "hash",
+})
+    .step("ASSESS", "Action Decision Tree — assess each existing test against the diff", () => buildActionDecisionTree())
+    .subStep("ENDPOINT_EXISTENCE", "Endpoint existence", () => buildCheckEndpointExistence())
+    .subStep("RESPONSE_SHAPE", "Request/response shape (breaking changes)", () => buildCheckResponseShape())
+    .subStep("ADDITIVE_FIELDS", "Additive response fields (coverage gaps)", () => buildCheckAdditiveFields())
+    .subStep("AUTH_AUTHZ", "Auth and authorization changes", () => buildCheckAuthAndAuthorization())
+    .subStep("BEHAVIORAL_CONTRACT", "Behavioral and semantic contract changes", () => buildCheckBehavioralContract())
+    .subStep("ASSIGN_ACTION", "Assign action", () => buildCheckAssignAction())
+    .step("CALL_TOOL", "Submit recommendations", (p) => buildDriftOutputChecklist(p.stateFile, p.existingTests))
+    .done();
+export function buildDriftAnalysisPrompt(stateFile, existingTests) {
+    return `<drift_analysis_rules>\n${_plan.render({ stateFile, existingTests })}\n</drift_analysis_rules>`;
 }