@skyramp/mcp 0.1.4 → 0.1.5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/build/prompts/test-maintenance/driftAnalysisSections.js +2 -2
- package/build/prompts/test-recommendation/analysisOutputPrompt.js +2 -2
- package/build/prompts/test-recommendation/recommendationSections.js +10 -42
- package/build/prompts/test-recommendation/registerRecommendTestsPrompt.js +5 -2
- package/build/prompts/test-recommendation/test-recommendation-prompt.js +152 -67
- package/build/prompts/test-recommendation/test-recommendation-prompt.test.js +18 -111
- package/build/prompts/testbot/testbot-prompts.js +9 -17
- package/build/services/ScenarioGenerationService.js +1 -2
- package/build/tools/generate-tests/generateBatchScenarioRestTool.js +4 -3
- package/build/tools/generate-tests/generateBatchScenarioRestTool.test.js +0 -9
- package/build/tools/test-management/analyzeChangesTool.js +5 -10
- package/build/types/TestRecommendation.js +0 -2
- package/build/utils/featureFlags.js +0 -25
- package/build/utils/scenarioDrafting.js +505 -116
- package/build/utils/scenarioDrafting.test.js +480 -260
- package/package.json +1 -1
- package/build/utils/httpDefaults.js +0 -12
|
@@ -459,7 +459,7 @@ describe("buildRecommendationPrompt — maxGenerateOverride", () => {
|
|
|
459
459
|
expect(prompt).toContain("Test type mix — MANDATORY");
|
|
460
460
|
expect(prompt).toContain("Present up to 6 recommendations.");
|
|
461
461
|
});
|
|
462
|
-
it("full_repo mode
|
|
462
|
+
it("full_repo mode pre-allocates E2E and UI sections for full-stack repos", () => {
|
|
463
463
|
const fullStackAnalysis = minimalAnalysis({
|
|
464
464
|
projectClassification: {
|
|
465
465
|
projectType: "full-stack",
|
|
@@ -476,11 +476,11 @@ describe("buildRecommendationPrompt — maxGenerateOverride", () => {
|
|
|
476
476
|
},
|
|
477
477
|
});
|
|
478
478
|
const prompt = buildRecommendationPrompt(fullStackAnalysis, AnalysisScope.FullRepo, 10);
|
|
479
|
-
// E2E
|
|
480
|
-
|
|
479
|
+
// E2E and UI sections must be present even though scenarioDrafting only produces backend types
|
|
480
|
+
expect(prompt).toContain("### E2E");
|
|
481
|
+
expect(prompt).toContain("### UI");
|
|
481
482
|
expect(prompt).toContain("skyramp_e2e_test_generation");
|
|
482
483
|
expect(prompt).toContain("skyramp_ui_test_generation");
|
|
483
|
-
expect(prompt).toContain("Budget Plan");
|
|
484
484
|
// Backend sections should still be present
|
|
485
485
|
expect(prompt).toContain("### Integration");
|
|
486
486
|
});
|
|
@@ -689,7 +689,7 @@ describe("buildRecommendationPrompt — GENERATE slot allocation", () => {
|
|
|
689
689
|
function makeScenario(name) {
|
|
690
690
|
return minimalScenario({ scenarioName: name, category: "new_endpoint" });
|
|
691
691
|
}
|
|
692
|
-
it("UI-only PR:
|
|
692
|
+
it("UI-only PR: all GENERATE slots are UI placeholders (no backend)", () => {
|
|
693
693
|
const analysis = minimalAnalysis({
|
|
694
694
|
businessContext: { mainPurpose: "Test", userFlows: [], dataFlows: [], integrationPatterns: [], draftedScenarios: [] },
|
|
695
695
|
branchDiffContext: {
|
|
@@ -702,14 +702,15 @@ describe("buildRecommendationPrompt — GENERATE slot allocation", () => {
|
|
|
702
702
|
},
|
|
703
703
|
});
|
|
704
704
|
const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 10);
|
|
705
|
-
//
|
|
706
|
-
expect(prompt).toContain("
|
|
705
|
+
// The GENERATE slots are the UI placeholder blocks — check their specific scenario names
|
|
706
|
+
expect(prompt).toContain("#1 — GENERATE** | ui | workflow | new");
|
|
707
|
+
expect(prompt).toContain("ui-test-for-changed-component-1");
|
|
708
|
+
expect(prompt).toContain("ui_test_1_trace.zip");
|
|
707
709
|
expect(prompt).toContain("skyramp_ui_test_generation");
|
|
708
|
-
|
|
709
|
-
// Each item must be distinct
|
|
710
|
+
// Each slot targets a distinct changed component/flow
|
|
710
711
|
expect(prompt).toContain("distinct changed component or user flow");
|
|
711
712
|
});
|
|
712
|
-
it("mixed PR:
|
|
713
|
+
it("mixed PR: last GENERATE slot is UI, preceding slots are backend scenarios", () => {
|
|
713
714
|
const scenarios = [
|
|
714
715
|
makeScenario("orders-create"),
|
|
715
716
|
makeScenario("orders-update"),
|
|
@@ -727,12 +728,14 @@ describe("buildRecommendationPrompt — GENERATE slot allocation", () => {
|
|
|
727
728
|
},
|
|
728
729
|
});
|
|
729
730
|
const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 10);
|
|
730
|
-
//
|
|
731
|
+
// Last GENERATE slot is UI (not E2E)
|
|
732
|
+
expect(prompt).toContain("— GENERATE** | ui");
|
|
733
|
+
expect(prompt).toContain("skyramp_ui_test_generation");
|
|
734
|
+
expect(prompt).not.toContain("— GENERATE** | e2e");
|
|
735
|
+
// At least one backend scenario in GENERATE (#1 or #2)
|
|
731
736
|
expect(prompt).toContain("#1 — GENERATE** | integration");
|
|
737
|
+
// Scenario name from the pre-ranked list (orders-create or orders-update)
|
|
732
738
|
expect(prompt).toContain("orders-create");
|
|
733
|
-
// UI/E2E guidance is present for the LLM to add per its Budget Plan
|
|
734
|
-
expect(prompt).toContain("UI/E2E tests (add per your Budget Plan)");
|
|
735
|
-
expect(prompt).toContain("skyramp_ui_test_generation");
|
|
736
739
|
});
|
|
737
740
|
it("backend-only PR: all GENERATE slots are backend scenarios (no E2E injection)", () => {
|
|
738
741
|
const scenarios = [makeScenario("items-create"), makeScenario("items-get"), makeScenario("items-delete")];
|
|
@@ -839,21 +842,12 @@ describe("buildRecommendationPrompt — Mandatory Reasoning Protocol", () => {
|
|
|
839
842
|
expect(protocol).toContain("requestBody");
|
|
840
843
|
expect(protocol).toContain("endpointURL");
|
|
841
844
|
expect(protocol).toContain("authHeader");
|
|
842
|
-
expect(protocol).toContain("
|
|
845
|
+
expect(protocol).toContain("FK path params");
|
|
843
846
|
});
|
|
844
847
|
it("reasoning protocol instructs to read source file when value cannot be sourced", () => {
|
|
845
848
|
const protocol = buildReasoningProtocol();
|
|
846
849
|
expect(protocol).toContain("read the relevant source file");
|
|
847
850
|
});
|
|
848
|
-
it("reasoning protocol includes Coverage Reasoning Block for all 3 PR types", () => {
|
|
849
|
-
const protocol = buildReasoningProtocol();
|
|
850
|
-
expect(protocol).toContain("Coverage Reasoning Block");
|
|
851
|
-
expect(protocol).toContain("backend-only PRs");
|
|
852
|
-
expect(protocol).toContain("frontend-only PRs");
|
|
853
|
-
expect(protocol).toContain("mixed (frontend + backend) PRs");
|
|
854
|
-
expect(protocol).toContain("All HTTP methods affected");
|
|
855
|
-
expect(protocol).toContain("Testable surfaces:");
|
|
856
|
-
});
|
|
857
851
|
});
|
|
858
852
|
// ---------------------------------------------------------------------------
|
|
859
853
|
// Tests — Context Fetching Guidance
|
|
@@ -1518,90 +1512,3 @@ describe("externalDedupKey", () => {
|
|
|
1518
1512
|
expect(externalDedupKey(scenario)).toBe("POST::orders::contract");
|
|
1519
1513
|
});
|
|
1520
1514
|
});
|
|
1521
|
-
// ---------------------------------------------------------------------------
|
|
1522
|
-
// Tests — UI-only PR classification fix
|
|
1523
|
-
// ---------------------------------------------------------------------------
|
|
1524
|
-
describe("buildRecommendationPrompt — isUIOnlyPR classification", () => {
|
|
1525
|
-
it("does not classify as UI-only when backend service files changed but no endpoints detected", () => {
|
|
1526
|
-
const analysis = minimalAnalysis({
|
|
1527
|
-
branchDiffContext: {
|
|
1528
|
-
baseBranch: "main",
|
|
1529
|
-
currentBranch: "feature/field-rbac",
|
|
1530
|
-
changedFiles: [
|
|
1531
|
-
"api/src/services/items.ts",
|
|
1532
|
-
"api/src/services/permissions.ts",
|
|
1533
|
-
"api/src/middleware/validate-access.ts",
|
|
1534
|
-
"app/src/components/fields.vue",
|
|
1535
|
-
],
|
|
1536
|
-
newEndpoints: [],
|
|
1537
|
-
modifiedEndpoints: [],
|
|
1538
|
-
affectedServices: ["items", "permissions"],
|
|
1539
|
-
},
|
|
1540
|
-
});
|
|
1541
|
-
const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 6);
|
|
1542
|
-
expect(prompt).toContain("Endpoint Discovery Required");
|
|
1543
|
-
expect(prompt).not.toContain("UI-only PR");
|
|
1544
|
-
expect(prompt).not.toContain("frontend-only PR — set **100% UI/E2E**");
|
|
1545
|
-
});
|
|
1546
|
-
it("correctly classifies as UI-only when only frontend files changed", () => {
|
|
1547
|
-
const analysis = minimalAnalysis({
|
|
1548
|
-
branchDiffContext: {
|
|
1549
|
-
baseBranch: "main",
|
|
1550
|
-
currentBranch: "feature/ui-tweak",
|
|
1551
|
-
changedFiles: [
|
|
1552
|
-
"app/src/components/fields.vue",
|
|
1553
|
-
"app/src/views/settings.vue",
|
|
1554
|
-
],
|
|
1555
|
-
newEndpoints: [],
|
|
1556
|
-
modifiedEndpoints: [],
|
|
1557
|
-
affectedServices: [],
|
|
1558
|
-
},
|
|
1559
|
-
});
|
|
1560
|
-
const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 6);
|
|
1561
|
-
expect(prompt).toContain("UI-only PR");
|
|
1562
|
-
expect(prompt).not.toContain("Endpoint Discovery Required");
|
|
1563
|
-
});
|
|
1564
|
-
it("does not classify as UI-only when endpoints are directly detected", () => {
|
|
1565
|
-
const analysis = minimalAnalysis({
|
|
1566
|
-
branchDiffContext: {
|
|
1567
|
-
baseBranch: "main",
|
|
1568
|
-
currentBranch: "feature/new-route",
|
|
1569
|
-
changedFiles: [
|
|
1570
|
-
"api/src/routes/items.ts",
|
|
1571
|
-
"app/src/components/fields.vue",
|
|
1572
|
-
],
|
|
1573
|
-
newEndpoints: [{
|
|
1574
|
-
path: "/api/items",
|
|
1575
|
-
methods: [{ method: "POST", sourceFile: "api/src/routes/items.ts", interactionCount: 1 }],
|
|
1576
|
-
}],
|
|
1577
|
-
modifiedEndpoints: [],
|
|
1578
|
-
affectedServices: ["items"],
|
|
1579
|
-
},
|
|
1580
|
-
});
|
|
1581
|
-
const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 6);
|
|
1582
|
-
expect(prompt).not.toContain("UI-only PR");
|
|
1583
|
-
expect(prompt).toContain("Mixed PR");
|
|
1584
|
-
});
|
|
1585
|
-
it("backend-only PR: no UI-only or Mixed classification in mode preamble", () => {
|
|
1586
|
-
const analysis = minimalAnalysis({
|
|
1587
|
-
branchDiffContext: {
|
|
1588
|
-
baseBranch: "main",
|
|
1589
|
-
currentBranch: "feature/add-endpoint",
|
|
1590
|
-
changedFiles: [
|
|
1591
|
-
"api/src/routes/orders.ts",
|
|
1592
|
-
"api/src/services/orders.ts",
|
|
1593
|
-
],
|
|
1594
|
-
newEndpoints: [{
|
|
1595
|
-
path: "/api/orders",
|
|
1596
|
-
methods: [{ method: "POST", sourceFile: "api/src/routes/orders.ts", interactionCount: 2 }],
|
|
1597
|
-
}],
|
|
1598
|
-
modifiedEndpoints: [],
|
|
1599
|
-
affectedServices: ["orders"],
|
|
1600
|
-
},
|
|
1601
|
-
});
|
|
1602
|
-
const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 6);
|
|
1603
|
-
// Mode preamble should NOT label this as UI-only or Mixed
|
|
1604
|
-
expect(prompt).not.toContain("**UI-only PR**");
|
|
1605
|
-
expect(prompt).not.toContain("**Mixed PR**");
|
|
1606
|
-
});
|
|
1607
|
-
});
|
|
@@ -4,7 +4,7 @@ import { AnalyticsService } from "../../services/AnalyticsService.js";
|
|
|
4
4
|
import { MAX_TESTS_TO_GENERATE, MAX_RECOMMENDATIONS, MAX_CRITICAL_TESTS, PATH_PARAM_UUID_GUIDANCE, AUTH_CONFLICT_ERROR_MSG, } from "../test-recommendation/recommendationSections.js";
|
|
5
5
|
import { buildDriftAnalysisPrompt } from "../test-maintenance/drift-analysis-prompt.js";
|
|
6
6
|
import { getTraceRecordingPromptText } from "../../playwright/traceRecordingPrompt.js";
|
|
7
|
-
import { isContractConsumerModeEnabled
|
|
7
|
+
import { isContractConsumerModeEnabled } from "../../utils/featureFlags.js";
|
|
8
8
|
import { readWorkspaceConfigRaw } from "../../utils/workspaceAuth.js";
|
|
9
9
|
// Cached at module-load — the flag is process-wide and cannot change per call.
|
|
10
10
|
const CONSUMER_MODE_ENABLED = isContractConsumerModeEnabled();
|
|
@@ -100,23 +100,16 @@ ${userPrompt ? "Generate only the tests that the user requested from the Additio
|
|
|
100
100
|
Keep advancing until you have created exactly ${maxGenerate} new test files OR exhausted all candidates.
|
|
101
101
|
- Example: If enrichment reveals that sending \`discount_value\` without \`discount_type\` silently orphans the value (a concrete bug), complete all planned GENERATE items first, then generate this discovered scenario as an extra test and report it in \`newTestsCreated\`.
|
|
102
102
|
- Total generated: Follow the "Budget: N generate" line in the Execution Plan. Process every GENERATE-tagged item in order. Backfill from ADDITIONAL candidates (highest-ranked first) until \`newTestsCreated\` reaches ${maxGenerate} or all candidates are exhausted.
|
|
103
|
-
- **
|
|
104
|
-
|
|
105
|
-
1. PR-endpoint edge cases — error paths (404, 422), auth boundary (401/403), validation for endpoints changed in this PR
|
|
106
|
-
2. Same-resource alternative flows — different HTTP methods or state variations on the same resource
|
|
107
|
-
3. Cross-resource workflows involving a PR endpoint
|
|
108
|
-
4. UI/E2E tests per your Budget Plan's UI% allocation
|
|
109
|
-
5. Unrelated endpoint coverage — NEVER backfill with tests for endpoints or pages not touched by this PR unless ALL options 1–4 are exhausted
|
|
110
|
-
- **UI test generation** (only when Budget Plan allocates UI% > 0): Use \`browser_navigate\` to the app's base URL — if the app responds, record a trace and generate the test.
|
|
111
|
-
**Skip UI only if one of these conditions is met:**
|
|
103
|
+
- **UI test priority**: If the diff contains frontend/UI changes (e.g. \`.tsx\`, \`.jsx\`, \`.vue\`, \`.svelte\` files), you MUST attempt to generate at least one UI test. Use \`browser_navigate\` to the app's base URL — if the app responds, record a trace and generate the test.
|
|
104
|
+
**Skip only if one of these conditions is met:**
|
|
112
105
|
- **(a) App is unreachable** — \`browser_navigate\` fails or connection is refused.
|
|
113
|
-
- **(b)
|
|
114
|
-
- **(c) Unintegrated non-route component** — the changed file is a leaf component (not a framework route/entrypoint) that has no integration point in the running app. To confirm:
|
|
106
|
+
- **(b) Unintegrated non-route component** — the changed file is a leaf component (not a framework route/entrypoint) that has no integration point in the running app. To confirm:
|
|
115
107
|
1. Grep for the component's exported name AND its module path/filename across all production source files (excluding \`*.test.*\`, \`*.spec.*\`, \`*.stories.*\`, \`__tests__/\` directories — only production code imports count).
|
|
116
108
|
2. If no production file imports, re-exports, or renders it, the component has no DOM node in the running app → unintegrated.
|
|
117
109
|
3. **Exception**: if the same PR also adds a route/page file (e.g. under Next.js \`pages/\` or \`app/\`) that imports the component, the route IS the integration point — test through it.
|
|
118
110
|
**Never** apply the unintegrated heuristic to framework route/entrypoint files themselves — those are always reachable by convention.
|
|
119
111
|
**Never** generate tests for unrelated pages as a substitute for an unintegrated component.
|
|
112
|
+
This rule takes priority over generating additional backend-only tests.
|
|
120
113
|
- **Always generate a test for critical bugs, even if it will fail.** When a GENERATE-tagged item targets a page or endpoint with a known bug, do NOT skip it because you expect the test to fail — a failing test that documents a bug is more valuable than a text-only description. This applies within the existing GENERATE budget; do not add extra tests beyond the plan.
|
|
121
114
|
- For UI rendering bugs: navigate to the broken page and add a \`browser_assert\` that verifies the page rendered its expected content (e.g. assert the page heading is visible). The assertion will fail on the broken page, which is the correct outcome — it documents the bug as a failing test.
|
|
122
115
|
- The assertion MUST target the broken page itself, not a different page that works. If \`/orders/{id}/edit\` crashes, assert on \`/orders/{id}/edit\` (e.g. "Edit Order" heading visible), NOT on \`/orders\`.
|
|
@@ -128,8 +121,8 @@ ${userPrompt ? "Generate only the tests that the user requested from the Additio
|
|
|
128
121
|
- Critical-category tests are already ranked first by the pre-computed scores — follow the plan order.
|
|
129
122
|
|
|
130
123
|
**Auth — determine ONCE, apply to EVERY tool call:**
|
|
131
|
-
1. Read auth params from the Execution Plan returned by \`skyramp_analyze_changes\` — they are
|
|
132
|
-
2. If workspace shows \`authType: none\` or \`authHeader: ""\` → proceed with no auth (\`authHeader: ""\`). If tests fail due to 401/403, add to \`issuesFound\`: "Auth may be required — update \`api.authType\` in
|
|
124
|
+
1. Read auth params from the Execution Plan returned by \`skyramp_analyze_changes\` — they are resolved directly from workspace.yml. **Use these as-is; do not infer or override.**
|
|
125
|
+
2. If workspace shows \`authType: none\` or \`authHeader: ""\` → proceed with no auth (\`authHeader: ""\`). If tests fail due to 401/403, add to \`issuesFound\`: "Auth may be required — update \`api.authType\` in workspace.yml."
|
|
133
126
|
3. **Auth params by header type — quick reference:**
|
|
134
127
|
|
|
135
128
|
| \`authHeader\` | \`authType\` examples | \`skyramp_batch_scenario_*\` / \`skyramp_contract_*\` | \`skyramp_integration_test_generation\` (scenarioFile) |
|
|
@@ -140,7 +133,7 @@ ${userPrompt ? "Generate only the tests that the user requested from the Additio
|
|
|
140
133
|
| none / \`""\` | \`none\` | \`authHeader: ""\` only when endpoint confirmed unauthenticated | \`authHeader: ""\` |
|
|
141
134
|
|
|
142
135
|
**Omit \`authToken\` entirely** — \`SKYRAMP_PLACEHOLDER_TOKEN\` is auto-inserted at execution time.
|
|
143
|
-
The \`authScheme\` for \`Authorization\` headers is pre-resolved in the Execution Plan — use it exactly (e.g. \`"Bearer"\`, \`"Token"\`, or a custom scheme from
|
|
136
|
+
The \`authScheme\` for \`Authorization\` headers is pre-resolved in the Execution Plan — use it exactly (e.g. \`"Bearer"\`, \`"Token"\`, or a custom scheme from \`api.authScheme\` in workspace.yml).
|
|
144
137
|
|
|
145
138
|
Passing auth alongside workspace \`authType\` on \`skyramp_integration_test_generation\` causes "${AUTH_CONFLICT_ERROR_MSG}" — follow the table.
|
|
146
139
|
4. Only pass \`authHeader: ""\` if you can confirm the endpoint is truly unauthenticated.
|
|
@@ -148,7 +141,7 @@ ${userPrompt ? "Generate only the tests that the user requested from the Additio
|
|
|
148
141
|
**How to generate each type (for ADD):**
|
|
149
142
|
- **Integration**: call \`skyramp_batch_scenario_test_generation\` with ALL steps in a single call (pass the \`steps\` array with method, path, requestBody, statusCode for each step). Then call \`skyramp_integration_test_generation\` with the returned scenario file.
|
|
150
143
|
**Use the pre-built scenario JSON from the Execution Plan** — pass the steps array directly. Do NOT read source code models to construct request bodies if the plan already provides them.
|
|
151
|
-
Scenario JSON and test files go in
|
|
144
|
+
Scenario JSON and test files go in the \`testDirectory\` from \`workspace.yml\` (visible in the service context block at the top of this prompt). Do NOT create a new \`tests/\` directory at the repo root — use the path the workspace config specifies. If no \`testDirectory\` is configured, default to the language-conventional location (e.g. \`src/test/java/...\` for Java, \`tests/\` for Python).
|
|
152
145
|
**Pipeline for speed**: Call ALL \`skyramp_batch_scenario_test_generation\` calls in one batch. When they return, call ALL \`skyramp_integration_test_generation\` calls in the next batch. Do NOT serialize per-scenario (batch→integration→batch→integration) — batch ALL scenarios first, then generate ALL integration tests.
|
|
153
146
|
- **Contract**: call \`skyramp_contract_test_generation\` with \`endpointURL\`, \`method\`, and \`requestData\` for POST/PUT/PATCH.
|
|
154
147
|
Pass \`apiSchema\` if an OpenAPI spec exists.
|
|
@@ -156,7 +149,6 @@ ${CONTRACT_MODE_GUIDANCE}
|
|
|
156
149
|
- ${PATH_PARAM_UUID_GUIDANCE}
|
|
157
150
|
- **UI**: First check for existing Playwright trace \`.zip\` files in the repo (Testbot scans recursively up to 5 directory levels — the per-service output directories, \`frontend/\`, \`public/\`, \`.skyramp/\`, or any subdirectory).
|
|
158
151
|
If a relevant trace exists (covers the UI changes in this PR), use it directly with \`skyramp_ui_test_generation\` and \`modularizeCode: false\`.
|
|
159
|
-
**Output directory**: When calling \`skyramp_ui_test_generation\`, set \`outputDir\` to ${resolveServiceDetailsRef().frontendTestDirRef} — NOT \`.skyramp/\` (that directory is only for trace \`.zip\` files and workspace config).
|
|
160
152
|
If NO relevant trace exists, **you MUST write out your full trace plan as text BEFORE calling \`browser_navigate\`**. Do not touch the browser until the plan is written.
|
|
161
153
|
|
|
162
154
|
**Browser authentication (check BEFORE navigating)**: If \`<ui-credentials>\` appears in your context above, the app requires login. Parse the credentials — each line is \`username:password\`. Type the values verbatim (they are not encoded or escaped). Before navigating to ANY feature URL:
|
|
@@ -1,6 +1,5 @@
|
|
|
1
1
|
import { AUTH_PLACEHOLDER_TOKEN } from "../types/TestTypes.js";
|
|
2
2
|
import { isAuthorizationHeaderName } from "../utils/workspaceAuth.js";
|
|
3
|
-
import { inferExpectedStatus } from "../utils/httpDefaults.js";
|
|
4
3
|
import { logger } from "../utils/logger.js";
|
|
5
4
|
import fs from "fs";
|
|
6
5
|
import path from "path";
|
|
@@ -125,7 +124,7 @@ ${JSON.stringify(traceRequest, null, 2)}
|
|
|
125
124
|
}
|
|
126
125
|
const timestamp = new Date().toISOString();
|
|
127
126
|
const method = params.method;
|
|
128
|
-
const statusCode = params.statusCode ??
|
|
127
|
+
const statusCode = params.statusCode ?? (method === "POST" ? 201 : method === "DELETE" ? 204 : 200);
|
|
129
128
|
const requestBody = params.requestBody ||
|
|
130
129
|
(method === "GET" || method === "DELETE" ? "" : "{}");
|
|
131
130
|
const responseHeaders = params.responseHeaders
|
|
@@ -57,7 +57,8 @@ export const stepSchema = z.object({
|
|
|
57
57
|
.describe("JSON string of the expected response body"),
|
|
58
58
|
statusCode: z
|
|
59
59
|
.number()
|
|
60
|
-
.
|
|
60
|
+
.optional()
|
|
61
|
+
.describe("Expected HTTP status code. Defaults: POST→201, DELETE→204, GET/PUT/PATCH→200."),
|
|
61
62
|
responseHeaders: z
|
|
62
63
|
.record(z.array(z.string()))
|
|
63
64
|
.optional()
|
|
@@ -140,7 +141,7 @@ export function registerBatchScenarioTestTool(server) {
|
|
|
140
141
|
This tool accepts AI-parsed structured parameters from a natural language scenario description. Analyze the scenario and provide structured parameters for all steps.
|
|
141
142
|
1. **Dynamic context**: If \`skyramp_analyze_changes\` has already run and returned a \`sessionId\`, fetch endpoint detail before building each step: \`skyramp://analysis/{sessionId}/endpoints/{path}/{method}\`. This gives you exact request body fields, types, and required vs optional — use it instead of guessing from field names.
|
|
142
143
|
2. **Endpoints**: Confirm each step's method + path exists as a real endpoint (from OpenAPI spec, source code routes, or skyramp_analyze_changes output). Do NOT invent paths.
|
|
143
|
-
3. **
|
|
144
|
+
3. **Status codes**: Confirm expected status code per step (defaults: POST→201, DELETE→204, GET/PUT/PATCH→200 — note if non-standard).
|
|
144
145
|
4. **Request bodies**: Identify each field and its source (schema / prior step response / user input). For GET/DELETE steps, confirm filters go in queryParams — NEVER in requestBody.
|
|
145
146
|
5. **Chaining**: For steps that use an ID from a prior step, use the same concrete value in the path (e.g. \`/api/v1/orders/1\`) that will appear in the prior step's response body (e.g. \`{"id": 1}\`). The backend auto-detects chaining by matching values across step responses.
|
|
146
147
|
6. **Echo-back fields**: Identify which request body fields will be returned unchanged in the response — these will need exact-value assertions in the generated test.
|
|
@@ -258,7 +259,7 @@ Call \`skyramp_integration_test_generation\` with the returned \`scenarioFile\`
|
|
|
258
259
|
type: "text",
|
|
259
260
|
text: `**Batch Scenario Generated — ${stepCount} steps**\n\n`
|
|
260
261
|
+ `**Scenario:** ${params.scenarioName}\n`
|
|
261
|
-
+ `**Steps:**\n${steps.map((s, i) => ` ${i + 1}. ${s.method} ${s.path} → ${s.statusCode ?? ""}`).join("\n")}\n\n`
|
|
262
|
+
+ `**Steps:**\n${steps.map((s, i) => ` ${i + 1}. ${s.method} ${s.path} → ${s.statusCode ?? "default"}`).join("\n")}\n\n`
|
|
262
263
|
+ `**File:** ${filePath}\n\n`
|
|
263
264
|
+ `**Next:** Call \`skyramp_integration_test_generation\` with \`scenarioFile: "${filePath}"\``,
|
|
264
265
|
},
|
|
@@ -9,7 +9,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
9
9
|
const result = stepSchema.safeParse({
|
|
10
10
|
method: "POST",
|
|
11
11
|
path: "/api/v1/products",
|
|
12
|
-
statusCode: 201,
|
|
13
12
|
requestBody: JSON.stringify({ name: "Widget-123", price: 9.99 }),
|
|
14
13
|
});
|
|
15
14
|
expect(result.success).toBe(true);
|
|
@@ -18,7 +17,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
18
17
|
const result = stepSchema.safeParse({
|
|
19
18
|
method: "POST",
|
|
20
19
|
path: "/api/v1/products",
|
|
21
|
-
statusCode: 201,
|
|
22
20
|
requestBody: "{}",
|
|
23
21
|
});
|
|
24
22
|
expect(result.success).toBe(false);
|
|
@@ -30,7 +28,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
30
28
|
const result = stepSchema.safeParse({
|
|
31
29
|
method: "PATCH",
|
|
32
30
|
path: "/api/v1/orders/1",
|
|
33
|
-
statusCode: 200,
|
|
34
31
|
requestBody: "{}",
|
|
35
32
|
});
|
|
36
33
|
expect(result.success).toBe(false);
|
|
@@ -40,7 +37,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
40
37
|
const result = stepSchema.safeParse({
|
|
41
38
|
method: "PUT",
|
|
42
39
|
path: "/api/v1/products/1",
|
|
43
|
-
statusCode: 200,
|
|
44
40
|
requestBody: "{}",
|
|
45
41
|
});
|
|
46
42
|
expect(result.success).toBe(false);
|
|
@@ -53,7 +49,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
53
49
|
const result = stepSchema.safeParse({
|
|
54
50
|
method: "POST",
|
|
55
51
|
path: "/api/v1/products",
|
|
56
|
-
statusCode: 201,
|
|
57
52
|
});
|
|
58
53
|
expect(result.success).toBe(true);
|
|
59
54
|
});
|
|
@@ -62,7 +57,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
62
57
|
const result = stepSchema.safeParse({
|
|
63
58
|
method: "POST",
|
|
64
59
|
path: "/api/v1/products",
|
|
65
|
-
statusCode: 201,
|
|
66
60
|
requestBody: "null",
|
|
67
61
|
});
|
|
68
62
|
expect(result.success).toBe(true); // null is not an empty object — not rejected
|
|
@@ -71,7 +65,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
71
65
|
const result = stepSchema.safeParse({
|
|
72
66
|
method: "GET",
|
|
73
67
|
path: "/api/v1/products/1",
|
|
74
|
-
statusCode: 200,
|
|
75
68
|
});
|
|
76
69
|
expect(result.success).toBe(true);
|
|
77
70
|
});
|
|
@@ -79,7 +72,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
79
72
|
const result = stepSchema.safeParse({
|
|
80
73
|
method: "DELETE",
|
|
81
74
|
path: "/api/v1/products/1",
|
|
82
|
-
statusCode: 204,
|
|
83
75
|
});
|
|
84
76
|
expect(result.success).toBe(true);
|
|
85
77
|
});
|
|
@@ -89,7 +81,6 @@ describe("stepSchema — requestBody validation", () => {
|
|
|
89
81
|
const result = stepSchema.safeParse({
|
|
90
82
|
method: "GET",
|
|
91
83
|
path: "/api/v1/products",
|
|
92
|
-
statusCode: 200,
|
|
93
84
|
requestBody: "{}",
|
|
94
85
|
});
|
|
95
86
|
expect(result.success).toBe(true);
|
|
@@ -573,22 +573,17 @@ to produce a unified state file for the test health workflow.
|
|
|
573
573
|
}
|
|
574
574
|
}
|
|
575
575
|
// ── Step 9: Draft scenarios ──
|
|
576
|
-
//
|
|
577
|
-
//
|
|
578
|
-
//
|
|
579
|
-
//
|
|
576
|
+
// Only new endpoints are passed as "diff-direct" — draftDiffDirectScenarios
|
|
577
|
+
// generates success-oriented scenarios (200/201/204) which are wrong for
|
|
578
|
+
// removed endpoints. Removal coverage (verify-404) is handled by the LLM
|
|
579
|
+
// from the diffContext.removedEndpoints signal in the recommendation prompt.
|
|
580
580
|
// Classified endpoints have full paths and concrete methods (no MULTI sentinels).
|
|
581
581
|
const newEndpointsForDrafting = classifiedEndpoints?.newEndpoints.flatMap((ep) => ep.methods.map((m) => ({
|
|
582
582
|
method: m,
|
|
583
583
|
path: ep.path,
|
|
584
584
|
sourceFile: ep.sourceFile,
|
|
585
585
|
}))) ?? [];
|
|
586
|
-
const
|
|
587
|
-
method: m,
|
|
588
|
-
path: ep.path,
|
|
589
|
-
sourceFile: ep.sourceFile,
|
|
590
|
-
}))) ?? [];
|
|
591
|
-
const codeInferredScenarios = draftScenariosFromEndpoints(skeletonEndpoints, newEndpointsForDrafting, changedEndpointsForDrafting);
|
|
586
|
+
const codeInferredScenarios = draftScenariosFromEndpoints(skeletonEndpoints, newEndpointsForDrafting);
|
|
592
587
|
let allDraftedScenarios = codeInferredScenarios;
|
|
593
588
|
if (traceResult && traceResult.userFlows.length > 0) {
|
|
594
589
|
const traceScenarios = traceResult.userFlows
|
|
@@ -24,8 +24,6 @@ const CATEGORIES = [
|
|
|
24
24
|
export const SCENARIO_CATEGORIES = [...INTERNAL_CATEGORIES, ...CATEGORIES];
|
|
25
25
|
/** Categories valid for tool submissions (excludes internal-only categories). */
|
|
26
26
|
export const TEST_CATEGORIES = CATEGORIES;
|
|
27
|
-
/** Numeric ordering for priority tiers (higher = more important). */
|
|
28
|
-
export const PRIORITY_TIER_ORDER = { CRITICAL: 4, HIGH: 3, MEDIUM: 2, LOW: 1 };
|
|
29
27
|
/** Priority assignment for each category. */
|
|
30
28
|
export const CATEGORY_PRIORITY = {
|
|
31
29
|
new_endpoint: "CRITICAL",
|
|
@@ -32,28 +32,3 @@
|
|
|
32
32
|
export function isContractConsumerModeEnabled() {
|
|
33
33
|
return process.env.SKYRAMP_FEATURE_CONTRACT_CONSUMER_MODE === "1";
|
|
34
34
|
}
|
|
35
|
-
export function isTestbotMode() {
|
|
36
|
-
return process.env.SKYRAMP_FEATURE_TESTBOT === "1";
|
|
37
|
-
}
|
|
38
|
-
/**
|
|
39
|
-
* Returns the prompt phrasing for where to find service details.
|
|
40
|
-
*
|
|
41
|
-
* - Testbot mode: references the `<services>` XML block injected at the top of the prompt.
|
|
42
|
-
* - Normal MCP mode: references `.skyramp/workspace.yml`.
|
|
43
|
-
*/
|
|
44
|
-
export function resolveServiceDetailsRef() {
|
|
45
|
-
if (isTestbotMode()) {
|
|
46
|
-
return {
|
|
47
|
-
testDirRef: "the `<output_dir>` from the `<services>` block",
|
|
48
|
-
frontendTestDirRef: "the **frontend** service's `<output_dir>` from the `<services>` block",
|
|
49
|
-
baseUrlRef: "the `<base_url>` from the `<services>` block",
|
|
50
|
-
authSourceRef: "the `<services>` block",
|
|
51
|
-
};
|
|
52
|
-
}
|
|
53
|
-
return {
|
|
54
|
-
testDirRef: "the `testDirectory` from `.skyramp/workspace.yml`",
|
|
55
|
-
frontendTestDirRef: "the **frontend** service's `testDirectory` from `.skyramp/workspace.yml`",
|
|
56
|
-
baseUrlRef: "the `api.baseUrl` from `.skyramp/workspace.yml`",
|
|
57
|
-
authSourceRef: "`.skyramp/workspace.yml`",
|
|
58
|
-
};
|
|
59
|
-
}
|