@skyramp/mcp 0.1.1 → 0.1.3

package/build/prompts/test-recommendation/test-recommendation-prompt.test.js

@@ -886,6 +886,145 @@ describe("buildRecommendationPrompt — Tool Contract Framing", () => {
     });
 });
 // ---------------------------------------------------------------------------
+// Tests — Multi-method endpoint partitioning
+// ---------------------------------------------------------------------------
+describe("buildRecommendationPrompt — multi-method endpoint partitioning", () => {
+    it("classifies all methods of a changed endpoint as changed", () => {
+        // When classifyEndpointsByChangedFiles identifies a file as changed,
+        // all methods from that endpoint's scanned catalog entry are included
+        // with concrete methods (no MULTI sentinels).
+        const analysis = minimalAnalysis({
+            apiEndpoints: {
+                totalCount: 2,
+                baseUrl: "http://localhost:3000",
+                endpoints: [
+                    {
+                        path: "/api/products",
+                        resourceGroup: "products",
+                        pathParams: [],
+                        methods: [
+                            { method: "GET", description: "List products", queryParams: [], authRequired: false, sourceFile: "app/api/products/route.ts", interactions: [] },
+                            { method: "POST", description: "Create product", queryParams: [], authRequired: false, sourceFile: "app/api/products/route.ts", interactions: [] },
+                        ],
+                    },
+                    {
+                        path: "/api/items",
+                        resourceGroup: "items",
+                        pathParams: [],
+                        methods: [
+                            { method: "GET", description: "List items", queryParams: [], authRequired: false, sourceFile: "routes/items.ts", interactions: [] },
+                        ],
+                    },
+                ],
+            },
+            branchDiffContext: {
+                baseBranch: "main",
+                currentBranch: "feature/products",
+                changedFiles: ["app/api/products/route.ts"],
+                newEndpoints: [{
+                        path: "/api/products",
+                        methods: [
+                            { method: "GET", sourceFile: "app/api/products/route.ts", interactionCount: 0 },
+                            { method: "POST", sourceFile: "app/api/products/route.ts", interactionCount: 0 },
+                        ],
+                    }],
+                modifiedEndpoints: [],
+                affectedServices: [],
+            },
+        });
+        const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 10);
+        // Both GET and POST for /api/products should be in "Changed in this PR"
+        expect(prompt).toContain("Changed in this PR");
+        expect(prompt).toMatch(/Changed in this PR:[\s\S]*GET \/api\/products/);
+        expect(prompt).toMatch(/Changed in this PR:[\s\S]*POST \/api\/products/);
+        // /api/items should NOT be in changed section
+        expect(prompt).toMatch(/Other endpoints[\s\S]*GET \/api\/items/);
+    });
+    it("handles mix of new and modified endpoints with concrete methods", () => {
+        const analysis = minimalAnalysis({
+            apiEndpoints: {
+                totalCount: 2,
+                baseUrl: "http://localhost:3000",
+                endpoints: [
+                    {
+                        path: "/api/products",
+                        resourceGroup: "products",
+                        pathParams: [],
+                        methods: [
+                            { method: "GET", description: "List", queryParams: [], authRequired: false, sourceFile: "routes.ts", interactions: [] },
+                            { method: "POST", description: "Create", queryParams: [], authRequired: false, sourceFile: "routes.ts", interactions: [] },
+                        ],
+                    },
+                    {
+                        path: "/api/orders",
+                        resourceGroup: "orders",
+                        pathParams: [],
+                        methods: [
+                            { method: "POST", description: "Create order", queryParams: [], authRequired: false, sourceFile: "routes.ts", interactions: [] },
+                        ],
+                    },
+                ],
+            },
+            branchDiffContext: {
+                baseBranch: "main",
+                currentBranch: "feature/mix",
+                changedFiles: ["routes.ts"],
+                newEndpoints: [
+                    { path: "/api/products", methods: [
+                            { method: "GET", sourceFile: "routes.ts", interactionCount: 0 },
+                            { method: "POST", sourceFile: "routes.ts", interactionCount: 0 },
+                        ] },
+                ],
+                modifiedEndpoints: [
+                    { path: "/api/orders", methods: [{ method: "POST", sourceFile: "routes.ts", changeType: "modified" }] },
+                ],
+                affectedServices: [],
+            },
+        });
+        const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 10);
+        // Both products and orders should be in changed section
+        expect(prompt).toMatch(/Changed in this PR:[\s\S]*GET \/api\/products/);
+        expect(prompt).toMatch(/Changed in this PR:[\s\S]*POST \/api\/orders/);
+    });
+});
+// ---------------------------------------------------------------------------
+// Tests — Removed endpoint [removed] marker in prompt (Fix 3 verification)
+// ---------------------------------------------------------------------------
+describe("buildRecommendationPrompt — removed endpoint listing", () => {
+    it("appends [removed] marker for removed endpoints not in current catalog", () => {
+        const analysis = minimalAnalysis({
+            apiEndpoints: {
+                totalCount: 1,
+                baseUrl: "http://localhost:3000",
+                endpoints: [{
+                        path: "/api/items",
+                        resourceGroup: "items",
+                        pathParams: [],
+                        methods: [{
+                                method: "GET", description: "List items", queryParams: [],
+                                authRequired: false, sourceFile: "routes.ts", interactions: [],
+                            }],
+                    }],
+            },
+            branchDiffContext: {
+                baseBranch: "main",
+                currentBranch: "feature/remove",
+                changedFiles: ["routes.ts"],
+                newEndpoints: [],
+                modifiedEndpoints: [],
+                removedEndpoints: [{
+                        path: "/api/legacy",
+                        methods: [{ method: "DELETE", sourceFile: "routes.ts", changeType: "removed" }],
+                    }],
+                affectedServices: [],
+            },
+        });
+        const prompt = buildRecommendationPrompt(analysis, AnalysisScope.CurrentBranchDiff, 10);
+        expect(prompt).toContain("DELETE /api/legacy [removed]");
+        expect(prompt).toContain("Changed in this PR");
+    });
+});
+// ---------------------------------------------------------------------------
 // Tests — Long-context best practices: XML tags structure
 // ---------------------------------------------------------------------------
 describe("buildRecommendationPrompt — XML tag structure (long-context best practice)", () => {

package/build/services/TestDiscoveryService.js

@@ -62,10 +62,11 @@ export class TestDiscoveryService {
      * Uses fast-glob for cross-platform file scanning, then classifies discovered files
      * as Skyramp-generated tests, external tests, or not-a-test during processing.
      *
-     * When `options.changedResources` is provided (PR mode), external files are partitioned
-     * by relevance: files whose path/name overlaps with the changed resource names get full
-     * endpoint extraction; low-relevance files are returned as name-only entries (no reads).
-     * This eliminates the old hard cap while keeping state file size bounded.
+     * External test handling depends on `options.changedResources`:
+     * - `string[]` with entries (PR mode, endpoints detected): partition by relevance.
+     * - `[]` empty array (PR mode, scanner found no endpoints): skip external tests entirely
+     *   rather than flooding context with irrelevant files.
+     * - `undefined` (full-repo mode, no diff): cap at MAX_EXTERNAL_FULL_REPO.
      */
     async discoverTests(repositoryPath, options = {}) {
         logger.info(`Starting test discovery in: ${repositoryPath}`);
@@ -86,23 +87,37 @@ export class TestDiscoveryService {
         skyrampTests.forEach(t => { t.source = TestSource.Skyramp; });
         // Partition external tests into relevant (full extraction) and low-relevance (name-only).
         //
-        // PR mode (changedResources provided):
+        // PR mode + endpoints detected (changedResources is non-empty array):
         //   Files whose path/name token-overlaps with the changed resource names are "relevant".
         //   Only they get full endpoint extraction. Low-relevance files get name-only entries.
         //   No hard cap — the relevance filter naturally bounds the read set to PR scope.
+        //   The sentinel ["unknown"] falls into this branch — most files score 0 (low-relevance)
+        //   and get name-only entries, so external coverage is preserved without context flood.
         //
-        // Full-repo mode (no changedResources):
+        // PR mode + truly no endpoints (changedResources is empty array []):
+        //   Diff contained no endpoints at all (new, modified, or removed) — skip external
+        //   tests entirely rather than flooding the prompt with hundreds of irrelevant files.
+        //
+        // Full-repo mode (changedResources is undefined):
         //   No diff context — all external files treated as potentially relevant.
         //   Cap at MAX_EXTERNAL_FULL_REPO to avoid reading hundreds of files.
         const { changedResources } = options;
         let relevantExternal;
         let otherExternal;
         if (changedResources?.length) {
+            // PR mode with detected endpoints — partition by relevance
             ({ relevant: relevantExternal, other: otherExternal } =
                 this.partitionByRelevance(classified.external, changedResources));
         }
+        else if (changedResources !== undefined) {
+            // PR mode with an explicit empty endpoint list from diff parsing — don't flood
+            // context with irrelevant external tests. The LLM will work from Skyramp tests
+            // and scanned endpoints only.
+            relevantExternal = [];
+            otherExternal = [];
+        }
         else {
-            // Full-repo mode: cap full-extraction set, remaining become name-only
+            // Full-repo mode (no diff context): cap full-extraction set, remaining become name-only
             relevantExternal = classified.external.slice(0, this.MAX_EXTERNAL_FULL_REPO);
             otherExternal = classified.external.slice(this.MAX_EXTERNAL_FULL_REPO);
         }

package/build/services/TestDiscoveryService.test.js

@@ -348,6 +348,50 @@ describe("TestDiscoveryService", () => {
             const withEndpoints = externalTests.filter(t => t.apiEndpoint !== "");
             expect(withEndpoints.length).toBe(12);
         });
+        it("returns zero external tests when changedResources is empty array (PR mode, no endpoints)", async () => {
+            // Simulate PR mode where a parsed diff produced no detected endpoints:
+            // newEndpoints=[], modifiedEndpoints=[], and removedEndpoints=[] → changedResources = []
+            writeFile("test_orders_api.py", 'import requests\nrequests.get("/api/orders")');
+            writeFile("test_products_api.py", 'import requests\nrequests.get("/api/products")');
+            const result = await service.discoverTests(tmpDir, { changedResources: [] });
+            const externalTests = result.tests.filter(t => t.source === TestSource.External);
+            // Empty changedResources = PR mode with no detected endpoints → zero external tests
+            expect(externalTests.length).toBe(0);
+            expect(result.relevantExternalTestPaths.length).toBe(0);
+        });
+        it("still returns external tests in full-repo mode (changedResources undefined)", async () => {
+            // Full-repo mode: changedResources not provided → should use capped full-repo behavior
+            writeFile("test_orders_api.py", 'import requests\nrequests.get("/api/orders")');
+            writeFile("test_products_api.py", 'import requests\nrequests.get("/api/products")');
+            const result = await service.discoverTests(tmpDir); // no options → undefined
+            const externalTests = result.tests.filter(t => t.source === TestSource.External);
+            expect(externalTests.length).toBe(2);
+            expect(result.relevantExternalTestPaths.length).toBe(2);
+        });
+        it("Skyramp tests are unaffected by empty changedResources", async () => {
+            writeFile("tests/test_orders_smoke.py", '# Generated by Skyramp\nskyramp generate smoke rest');
+            writeFile("test_external.py", 'import pytest\ndef test(): pass');
+            const result = await service.discoverTests(tmpDir, { changedResources: [] });
+            const skyrampTests = result.tests.filter(t => t.source === TestSource.Skyramp);
+            const externalTests = result.tests.filter(t => t.source === TestSource.External);
+            // Skyramp tests always discovered regardless of changedResources
+            expect(skyrampTests.length).toBe(1);
+            // External tests suppressed in PR-mode-no-endpoints
+            expect(externalTests.length).toBe(0);
+        });
+        it("returns external tests as name-only with ['unknown'] sentinel (unresolvable resources)", async () => {
+            // When diff endpoints exist but all paths resolve to "unknown" (e.g. decorator-relative
+            // paths like "/{order_id}"), changedResources = ["unknown"]. External tests should be
+            // discovered (not skipped) but scored as low-relevance since "unknown" won't match filenames.
+            writeFile("test_orders_api.py", 'import requests\nrequests.get("/api/orders")');
+            writeFile("test_products_api.py", 'import requests\nrequests.get("/api/products")');
+            const result = await service.discoverTests(tmpDir, { changedResources: ["unknown"] });
+            const externalTests = result.tests.filter(t => t.source === TestSource.External);
+            // External tests discovered (not skipped like empty array)
+            expect(externalTests.length).toBe(2);
+            // But all are low-relevance (name-only) since "unknown" doesn't match any filename tokens
+            expect(result.relevantExternalTestPaths.length).toBe(0);
+        });
         it("low-relevance files have empty apiEndpoint and empty framework in PR mode", async () => {
             writeFile("test_orders_api.py", 'import requests\nrequests.get("/api/orders")');
             writeFile("test_products_api.py", 'import requests\nrequests.get("/api/products")');

package/build/tools/code-refactor/enhanceAssertionsTool.js

@@ -1,12 +1,10 @@
 import { z } from "zod";
 import { TestType } from "../../types/TestTypes.js";
 import { AnalyticsService } from "../../services/AnalyticsService.js";
-import { CONTRACT_PROVIDER_ASSERTIONS_PROMPT } from "../../prompts/enhance-assertions/contractProviderAssertionsPrompt.js";
-import { INTEGRATION_ASSERTIONS_PROMPT } from "../../prompts/enhance-assertions/integrationAssertionsPrompt.js";
-import { UI_ASSERTIONS_PROMPT } from "../../prompts/enhance-assertions/uiAssertionsPrompt.js";
+import { getContractProviderAssertionsPrompt } from "../../prompts/enhance-assertions/contractProviderAssertionsPrompt.js";
+import { getIntegrationAssertionsPrompt } from "../../prompts/enhance-assertions/integrationAssertionsPrompt.js";
+import { getUIAssertionsPrompt } from "../../prompts/enhance-assertions/uiAssertionsPrompt.js";
 const TOOL_NAME = "skyramp_enhance_assertions";
-const SCOPE_GENERATION = "Apply to every test function in the generated file.";
-const SCOPE_MAINTENANCE = "Apply to **new test functions you are adding** and **existing functions that cover endpoints changed in the diff** only. Do NOT touch existing functions for endpoints unrelated to the diff.";
 const TESTBOT_UI_CHECKS = `
 ### Additional Testbot-Specific Checks
 - If no suitable selector exists in the generated file for an assertion you need to add, go back and call \`browser_assert\` on the live page to record it with a valid selector, then re-export and regenerate.
@@ -35,28 +33,28 @@ export function registerEnhanceAssertionsTool(server) {
         inputSchema: enhanceAssertionsSchema,
     }, async (params) => {
         const { testFile, testType, enhanceType } = params;
+        const enhanceCtx = enhanceType;
         let instructions;
         if (testType === TestType.UI) {
-            instructions = UI_ASSERTIONS_PROMPT;
+            instructions = getUIAssertionsPrompt(testFile, enhanceCtx);
             if (process.env.SKYRAMP_FEATURE_TESTBOT === "1") {
                 instructions += TESTBOT_UI_CHECKS;
             }
         }
         else if (testType === TestType.CONTRACT) {
-            instructions = CONTRACT_PROVIDER_ASSERTIONS_PROMPT;
+            instructions = getContractProviderAssertionsPrompt(testFile, enhanceCtx);
         }
         else if (testType === TestType.INTEGRATION) {
-            instructions = INTEGRATION_ASSERTIONS_PROMPT;
+            instructions = getIntegrationAssertionsPrompt(testFile, enhanceCtx);
         }
         else {
             throw new Error(`Unsupported testType for ${TOOL_NAME}: ${testType}`);
         }
-        const scope = enhanceType === "maintenance" ? SCOPE_MAINTENANCE : SCOPE_GENERATION;
         const result = {
             content: [
                 {
                     type: "text",
-                    text: `**You MUST execute the following assertion enhancement instructions to modify the test file.**\n\n**Target file:** ${testFile}\n\n**Scope:** ${scope}\n\n${instructions}`,
+                    text: instructions,
                 },
             ],
             isError: false,