@skyramp/mcp 0.0.20 → 0.0.22

package/build/prompts/modularization-prompts.js

@@ -3,35 +3,38 @@ export function getModularizationPrompt(filePath, language) {
 **CRITICAL: Refactor code with modularization principles. Respond with complete, modularized code only WITHOUT ERRORS AND WRITTEN BACK TO THE FILE ${filePath}**
 
 **CRITICAL: DO NOT CHANGE THE FUNCTIONALITY OF THE TESTS. ONLY MODULARIZE THE CODE.**
+
+**ABSOLUTELY FORBIDDEN: DO NOT CREATE ANY INTERFACES, CLASSES, TYPES, OR NEW DATA STRUCTURES. USE INLINE TYPES ONLY.**
+
 Only if NO existing function can be reused:
 1. Group related lines logically (e.g., login steps together) to improve readability and parameterize the test function(s) with meaningful parameters to make it more flexible.
 2. If functions are already modularized (like breakpoint_section_0, breakpoint_section_1), then rename them with meaningful names WITHOUT ANY OTHER CHANGES.
 3. KEEP CHANGES TO A MINIMUM. DO NOT MODIFY THE FUNCTIONALITY OF THE TESTS. ONLY MODULARIZE THE CODE.
 4. Parameterize the test function(s) with meaningful parameters to make it more flexible. Preserve the original order of code lines within each function.
-5. Only extract reusable logical sections into helper functions or parameterized structures where applicable. Do not create any new test cases or a new modular file but only helper functions with modularization done in the same file. Do not add any new logic or classes or any other files.
-6. CRITICAL: DO NOT CHANGE THE FUNCTIONALITY OF THE TESTS. ONLY MODULARIZE THE CODE.
-
-**EXECUTION CHECKLIST - YOU MUST COMPLETE EACH:**
-- [ ] STEP 1: Searched for existing files using grep_search or file_search
-- [ ] STEP 2: Found reusable functions and imported them at the top of the file
-- [ ] STEP 3: Replaced duplicate code with imported function calls
-- [ ] STEP 4: Created minimal new helpers only where needed
-- [ ] Verified import paths are correct
-- [ ] Verified original functionality is maintained
+5. Only extract reusable logical sections into helper functions. Use inline parameter types instead of creating interfaces or type definitions.
+6. **If extracting UI operations, ensure each helper function is self-contained** and leaves the UI in a clean state for the next operation WITHOUT UPDATING THE LOGIC OF THE TESTS.
 
-**CRITICAL: If you skip any step, the modularization is incomplete. You MUST complete all steps before proceeding.**
+**CRITICAL CONSTRAINTS:**
+- NO interfaces, classes, types, or data structures
+- NO new test cases or logic
+- NO additional files
+- ONLY helper functions with inline types
+- PRESERVE original functionality exactly
 
-**CRITICAL: FIX ERRORS IN MODULARIZED CODE USING skyramp_fix_errors TOOL**
+**CRITICAL: If you skip any step, the modularization is incomplete. You MUST complete all steps before proceeding.FIX ERRORS IN MODULARIZED CODE USING skyramp_fix_errors TOOL**
 `;
 }
 export function getFixErrorsPrompt() {
     return `
 **Fix errors in refactored code.**
 
-1. **Parameter Passing:** Identify functions using variables from outside scope (like Playwright 'page' object). Pass these as parameters.
+1. **Parameter Passing:** Identify functions using variables from outside scope (like 'page' object). Pass these as parameters.
 2. **Validate Correctness:** Ensure code is free of reference errors, undefined variables, runtime issues.
 3. **Import Paths:** Ensure import paths are correct and there are no circular imports.
+4. **UI State Management:** Check for UI state conflicts, modal interference, or element interaction issues.
+5. **Sequential Operations:** Ensure UI operations don't interfere with each other when called in sequence.
 
 **KEY: Variables not defined within function scope MUST be passed as parameters.**
+**UI KEY: Helper functions that perform UI operations must be self-contained and not leave modals/dialogs open.**
 `;
 }

package/build/prompts/startTraceCollectionPrompts.js

@@ -25,7 +25,7 @@ export function registerStartTraceCollectionPrompt(mcpServer) {
 * To start a playwright trace collection session using agent, run the following command:
   Start playwright trace collection with default settings.
 
-**CRITICAL: FOR UI TESTS ALWAYS SHOW THE ABOVE PROMPT FOR PLAYWRIGHT TRACE COLLECTION. NEVER SHOW THE CLI COMMANDS.**
+**CRITICAL: NEVER SHOW THE CLI COMMANDS.**
 `,
                 },
             },

package/build/prompts/testGenerationPrompt.js

@@ -92,7 +92,7 @@ Let us generate an E2E test with backend trace file skyramp-traces.json and fron
 \`\`\`
 
 **UI TEST:**
-- Purpose: Generate UI tests using Playwright traces
+- Purpose: Generate UI tests using Playwright traces captured using skyramp_start_trace_collection tool
 - Requirements: A frontend playwright trace file, test language, test framework
 
 **Sample UI Test Prompt:**

package/build/tools/executeSkyrampTestTool.js

@@ -5,6 +5,8 @@ import { Writable } from "stream";
 import { logger } from "../utils/logger.js";
 import { stripVTControlCharacters } from "util";
 import fs from "fs";
+const EXECUTOR_DOCKER_IMAGE = "skyramp/executor:v1.2.16";
+const DOCKER_PLATFORM = "linux/amd64";
 export function registerExecuteSkyrampTestTool(server) {
     server.registerTool("skyramp_execute_test", {
         description: `Execute a Skyramp-generated test in isolated containerized environments for reliable, deterministic testing.
@@ -54,7 +56,6 @@ For detailed documentation visit: https://www.skyramp.dev/docs/quickstart`,
         },
     }, async (params) => {
         var docker = new Docker();
-        var image = "public.ecr.aws/skyramp/rampup/runner:mcp-v0.0.9";
         const containerMountPath = "/home/user";
         // Use path.basename for safer filename extraction
         const filename = path.basename(params.testFile);
@@ -116,14 +117,17 @@ For detailed documentation visit: https://www.skyramp.dev/docs/quickstart`,
             var statusCode = 0;
             // check if image exists
             const images = await docker.listImages();
-            const imageExists = images.some((img) => (img.RepoTags && img.RepoTags.includes(image)) ||
-                (img.RepoDigests && img.RepoDigests.includes(image)));
+            const imageExists = images.some((img) => (img.RepoTags && img.RepoTags.includes(EXECUTOR_DOCKER_IMAGE)) ||
+                (img.RepoDigests &&
+                    img.RepoDigests.includes(EXECUTOR_DOCKER_IMAGE)));
             if (!imageExists) {
                 // Pull the image if it does not exist
                 await new Promise((resolve, reject) => {
-                    docker.pull(image, (err, stream) => {
+                    docker.pull(EXECUTOR_DOCKER_IMAGE, { platform: DOCKER_PLATFORM }, (err, stream) => {
                         if (err)
                             return reject(err);
+                        if (!stream)
+                            return reject(new Error("No stream received from docker pull"));
                         docker.modem.followProgress(stream, (err, res) => {
                             if (err)
                                 return reject(err);
@@ -133,7 +137,10 @@ For detailed documentation visit: https://www.skyramp.dev/docs/quickstart`,
                 });
             }
             await docker
-                .run(image, command, stream, { Env: env, HostConfig: hostConfig })
+                .run(EXECUTOR_DOCKER_IMAGE, command, stream, {
+                Env: env,
+                HostConfig: hostConfig,
+            })
                 .then(function (data) {
                 var result = data[0];
                 var container = data[1];

package/build/tools/generateE2ERestTool.js

@@ -6,7 +6,7 @@ const e2eTestSchema = {
     ...baseTraceSchema.shape,
     playwrightInput: z
         .string()
-        .describe("MUST be absolute path to the playwright input file like /path/to/playwright-ui-test.zip and MUST be a zip file"),
+        .describe("MUST be absolute path to the playwright input file like /path/to/playwright-ui-test.zip and MUST be a zip file captured using start_trace_collection tool"),
 };
 export class E2ETestService extends TestGenerationService {
     getTestType() {
@@ -30,7 +30,7 @@ export function registerE2ETestTool(server) {
 End-to-End tests validate complete user journeys by testing the entire application flow from frontend UI interactions to backend API responses. They ensure that all components work together correctly in realistic user scenarios, providing the highest confidence in application functionality.
 
 TRACE & UI INTEGRATION:
-E2E tests require both trace files (capturing backend API interactions) and Playwright recordings (capturing UI interactions) to generate comprehensive tests that validate the complete user experience.`,
+E2E tests require both trace files (capturing backend API interactions) and Playwright recordings (capturing UI interactions captured using start_trace_collection tool) to generate comprehensive tests that validate the complete user experience.`,
         inputSchema: e2eTestSchema,
         annotations: {
             keywords: ["e2e test", "end-to-end test"],

package/build/tools/generateUIRestTool.js

@@ -21,7 +21,7 @@ const uiTestSchema = {
     ...languageSchema.shape,
     playwrightInput: z
         .string()
-        .describe("MUST be absolute path to the playwright input file like /path/to/playwright-ui-test.zip and MUST be a zip file"),
+        .describe("MUST be absolute path to the playwright input file like /path/to/playwright-ui-test.zip and MUST be a zip file captured using start_trace_collection tool"),
     output: baseSchema.shape.output,
     outputDir: baseSchema.shape.outputDir,
     force: baseSchema.shape.force,

package/build/tools/stopTraceCollectionTool.js

@@ -4,7 +4,6 @@ import { z } from "zod";
 import { TELEMETRY_entrypoint_FIELD_NAME, } from "../utils/utils.js";
 import { logger } from "../utils/logger.js";
 import { baseSchema } from "../types/TestTypes.js";
-import path from "path";
 import { existsSync, mkdirSync } from "fs";
 export function registerTraceStopTool(server) {
     server.registerTool("skyramp_stop_trace_collection", {
@@ -59,11 +58,6 @@ For detailed documentation visit: https://www.skyramp.dev/docs/load-test/advance
             if (!existsSync(params.outputDir)) {
                 mkdirSync(params.outputDir, { recursive: true });
             }
-            // Temporary fix until library is updated
-            if (params.outputDir) {
-                stopTraceOptions.output = path.join(stopTraceOptions.outputDir, stopTraceOptions.output);
-                stopTraceOptions.playwrightOutput = path.join(stopTraceOptions.outputDir, stopTraceOptions.playwrightOutput);
-            }
             let errList = {
                 content: [],
                 isError: true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skyramp/mcp",
-  "version": "0.0.20",
+  "version": "0.0.22",
   "main": "build/index.js",
   "type": "module",
   "bin": {
@@ -42,7 +42,7 @@
   },
   "dependencies": {
     "@modelcontextprotocol/sdk": "^1.11.4",
-    "@skyramp/skyramp": "^1.2.15",
+    "@skyramp/skyramp": "^1.2.16",
     "dockerode": "^4.0.6",
     "zod": "^3.25.3"
   },