@skyramp/mcp 0.0.17 → 0.0.18

package/build/tools/executeSkyrampTestTool.js

@@ -4,6 +4,7 @@ import path from "path";
 import { Writable } from "stream";
 import { logger } from "../utils/logger.js";
 import { stripVTControlCharacters } from "util";
+import fs from "fs";
 // Configuration for language-specific file paths
 const LANGUAGE_PATHS = {
     python: "/tmp",
@@ -39,6 +40,9 @@ IMPORTANT NOTES:
 
 For detailed documentation visit: https://www.skyramp.dev/docs/quickstart`,
         inputSchema: {
+            workspacePath: z
+                .string()
+                .describe("The path to the workspace directory where the test file is located"),
             language: z
                 .string()
                 .describe("Programming language of the test file to execute (e.g., python, javascript, typescript, java)"),
@@ -58,6 +62,7 @@ For detailed documentation visit: https://www.skyramp.dev/docs/quickstart`,
     }, async (params) => {
         var docker = new Docker();
         var image = "public.ecr.aws/skyramp/rampup/runner:mcp-v0.0.9";
+        const containerMountPath = "/home/user";
         // Use path.basename for safer filename extraction
         const filename = path.basename(params.testFile);
         if (!filename) {
@@ -67,18 +72,30 @@ For detailed documentation visit: https://www.skyramp.dev/docs/quickstart`,
         const basePath = LANGUAGE_PATHS[params.language] || "/tmp";
         const filePath = path.join(basePath, filename);
         const dockerSocketPath = "/var/run/docker.sock";
+        //remove workspace path from test file path
+        let testFilePath = path.relative(params.workspacePath, params.testFile);
+        testFilePath = path.resolve(containerMountPath, testFilePath);
         var command = [
             "./root/runner.sh",
             params.language,
-            filePath,
+            testFilePath,
             params.testType,
         ];
+        const workspacePath = path.resolve(params.workspacePath);
+        // check if workspace valid path
+        // Validate that the workspace path exists and is accessible
+        try {
+            fs.accessSync(workspacePath, fs.constants.R_OK);
+        }
+        catch (err) {
+            throw new Error(`Workspace path does not exist or is not readable: ${workspacePath}`);
+        }
         const hostConfig = {
             ExtraHosts: ["host.docker.internal:host-gateway"],
             Mounts: [
                 {
-                    Target: filePath,
-                    Source: path.resolve(params.testFile),
+                    Target: containerMountPath,
+                    Source: workspacePath,
                     Type: "bind",
                 },
                 {

package/build/utils/language-helper.js

@@ -78,7 +78,7 @@ java -jar "./lib/junit-platform-console-standalone-\${JUNIT_PLATFORM_VER}.jar" \
 }
 function appendExecutionInstruction() {
     return `
-- Notify the user that they can also use ** Execute with Skyramp ** tool to run the test.If this is your first test you are trying to execute with Skyramp, it may take a little bit longer than usual.
+- Notify the user that they can also use ** Execute with Skyramp ** tool to run the test.If this is your first test you are trying to execute with Skyramp, it may take a little bit longer than usual because we need to build the image for the first time.
 - Before I can execute the test for you, I need to confirm the following information:
   Authentication: Please provide me with your authentication token (by default we assume a Bearer Token). If you don't require any token for your service please just say: 'No token required'
 `;

package/build/utils/modularization-prompts.js

@@ -1,23 +1,64 @@
 export function getModularizationPrompt() {
     return `
-**CRITICAL: Please refactor the code with these modularization principles. Respond with the complete, modularized code only in the same file WITHOUT ANY ERRORS**
+**CRITICAL: Refactor code with modularization principles. Respond with complete, modularized code only WITHOUT ERRORS**
 
+**STEP 1: SEARCH & ANALYZE EXISTING CODE - MANDATORY**
+You MUST search for existing test files by language:
+- Python: .py files with "skyramp"
+- TypeScript/JavaScript: .ts/.js files with "@skyramp/skyramp"  
+- Java: .java files with "SkyrampClient"
+
+You MUST look for reusable patterns: authentication, HTTP helpers, data setup, validation, configuration, cleanup functions.
+
+**STEP 2: IMPORT & REUSE (HIGHEST PRIORITY) - MANDATORY**
+You MUST import existing functions instead of duplicating. If you find reusable functions, you MUST import them:
+
+\`\`\`python
+from path.to.existing import helper_function
+from utils.auth_helpers import authenticate
+\`\`\`
+
+\`\`\`typescript/javascript
+import { helperFunction } from './path/to/existing';
+import { authenticate } from './utils/authHelpers';
+\`\`\`
+
+\`\`\`java
+import path.to.existing.helper_function;
+import utils.auth_helpers.authenticate;
+\`\`\`
+
+**STEP 3: REPLACE DUPLICATE CODE - MANDATORY**
+You MUST replace duplicate code with imported function calls. If you imported functions, you MUST use them.
+
+**STEP 4: CREATE MINIMAL NEW HELPERS (ONLY IF NEEDED)**
+Only if NO existing function can be reused:
 1. Group related lines logically (e.g., login steps together) to improve readability and parameterize the test function(s) with meaningful parameters to make it more flexible.
 2. If functions are already modularized (like breakpoint_section_0, breakpoint_section_1), then rename them with meaningful names WITHOUT ANY OTHER CHANGES.
 3. KEEP CHANGES TO A MINIMUM. DO NOT MODIFY THE FUNCTIONALITY OF THE TESTS. ONLY MODULARIZE THE CODE.
 4. Parameterize the test function(s) with meaningful parameters to make it more flexible. Preserve the original order of code lines within each function.
 5. Only extract reusable logical sections into helper functions or parameterized structures where applicable. Do not create any new test cases or a new modular file but only helper functions with modularization done in the same file. Do not add any new logic or classes or any other files.
 
-CRITICAL: FIX ERRORS IN THE MODULARIZED CODE USING skyramp_fix_errors TOOL
+**EXECUTION CHECKLIST - YOU MUST COMPLETE EACH:**
+- [ ] STEP 1: Searched for existing files using grep_search or file_search
+- [ ] STEP 2: Found reusable functions and imported them at the top of the file
+- [ ] STEP 3: Replaced duplicate code with imported function calls
+- [ ] STEP 4: Created minimal new helpers only where needed
+- [ ] Verified import paths are correct
+- [ ] Verified original functionality is maintained
+
+**CRITICAL: If you skip any step, the modularization is incomplete. You MUST complete all steps before proceeding.**
+
+**CRITICAL: FIX ERRORS IN MODULARIZED CODE USING skyramp_fix_errors TOOL**
 `;
 }
 export function getFixErrorsPrompt() {
     return `
-**Fix errors in the refactored code.**
+**Fix errors in refactored code.**
 
-1. **Parameter Passing:** Carefully examine the code. Identify all functions that use variables defined outside their own scope (like a Playwright 'page' object or a shared configuration).
-2. **Validate Correctness:** Ensure the final code is free of any reference errors, undefined variables, or other runtime issues. The code must be ready to execute.
+1. **Parameter Passing:** Identify functions using variables from outside scope (like Playwright 'page' object). Pass these as parameters.
+2. **Validate Correctness:** Ensure code is free of reference errors, undefined variables, runtime issues.
 
-**REMEMBER: The key insight is that if a function references any variable that's not defined within its scope, that variable MUST be passed as a parameter. The "page" object is the most common culprit in Playwright tests.**
+**KEY: Variables not defined within function scope MUST be passed as parameters.**
 `;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skyramp/mcp",
-  "version": "0.0.17",
+  "version": "0.0.18",
   "main": "build/index.js",
   "type": "module",
   "bin": {